)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f4b62d66eccf161946d2d8ba3e45432d7eb1552b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"626e8326_21b915d0","updated":"2023-08-26 23:09:08.000000000","message":"please add the releasenote","commit_id":"ce9b512d7ea2e98288392b215e43a328e9a351c8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"14ae516c9866cb542fd44e650512cb0a01c86c67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"20eaf930_56a69541","updated":"2022-04-22 13:02:19.000000000","message":"this hides the fact that someone forgot to set containerd_configure_for_zun, i.e., the zun might not be workable afterwards - I guess we need better prechecks - the path for the copy should exist as docker should be configured to use it","commit_id":"ce9b512d7ea2e98288392b215e43a328e9a351c8"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"1256601281d378ed8db4354211cc08d46329cb56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b61b32ab_e6be1c53","in_reply_to":"20eaf930_56a69541","updated":"2022-04-22 21:28:11.000000000","message":"When you not use the bare-metal role you do not have to set this parameter. We don\u0027t use the role because we install Docker/Containerd with another role. Therefore, at this point we need to make sure that the directory was created independently of this role.","commit_id":"ce9b512d7ea2e98288392b215e43a328e9a351c8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"77038f90275fcbc46741737c3f9d67bb27d1b532","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fb56d8cc_a4e665b1","in_reply_to":"b61b32ab_e6be1c53","updated":"2022-04-29 09:09:01.000000000","message":"The point is you probably end up with broken config because you should as well configure containerd to consume the cni dir. Thus, whatever you do, this should happen with containerd bootstrap, not here. I think the solution you seek is actually just disabling this task (i.e. you do not care about capsule API, only containers, and thus you don\u0027t need the CNI configured).","commit_id":"ce9b512d7ea2e98288392b215e43a328e9a351c8"}],"ansible/roles/zun/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e160ca71447a301a3c13d1962095fd14b9c584b0","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":"  when:"},{"line_number":107,"context_line":"    - inventory_hostname in groups[\u0027zun-cni-daemon\u0027]"},{"line_number":108,"context_line":"    - zun_services[\u0027zun-cni-daemon\u0027].enabled | bool"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- include_tasks: check-containers.yml"},{"line_number":111,"context_line":"  when: kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_c372c3ad","line":108,"updated":"2020-06-09 09:57:47.000000000","message":"This is done during kolla-ansible bootstrap-servers. Doesn\u0027t hurt to do it again, in case you\u0027re not using that.","commit_id":"9946de4c4ac55b4b59145e7d4f8c3c1a4bc1d5ff"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"a655b56822a3e4a34219c3523b7311ae2a18ed83","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":"  when:"},{"line_number":107,"context_line":"    - inventory_hostname in groups[\u0027zun-cni-daemon\u0027]"},{"line_number":108,"context_line":"    - zun_services[\u0027zun-cni-daemon\u0027].enabled | bool"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- include_tasks: check-containers.yml"},{"line_number":111,"context_line":"  when: kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_8c83f704","line":108,"range":{"start_line":108,"start_character":3,"end_line":108,"end_character":51},"updated":"2020-06-14 09:51:54.000000000","message":"well, better use:\n\nvars:\n  service: \"{{ zun_services[\u0027zun-cni-daemon\u0027] }}\"\n\nwhen:\n  - service.enable | bool\n\nto keep consistence with others","commit_id":"9946de4c4ac55b4b59145e7d4f8c3c1a4bc1d5ff"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"206223939c2038cb6eff9c6419cda188e13ade42","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":"  when:"},{"line_number":107,"context_line":"    - inventory_hostname in groups[\u0027zun-cni-daemon\u0027]"},{"line_number":108,"context_line":"    - zun_services[\u0027zun-cni-daemon\u0027].enabled | bool"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- include_tasks: check-containers.yml"},{"line_number":111,"context_line":"  when: kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_ac799b30","line":108,"range":{"start_line":108,"start_character":3,"end_line":108,"end_character":51},"in_reply_to":"bf51134e_8c83f704","updated":"2020-06-14 09:54:05.000000000","message":"I will give my +2 after your upated follow my comment","commit_id":"9946de4c4ac55b4b59145e7d4f8c3c1a4bc1d5ff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8f9ec4913a1e674469c631cc7a45d0671dc9fefc","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":"  when:"},{"line_number":107,"context_line":"    - inventory_hostname in groups[\u0027zun-cni-daemon\u0027]"},{"line_number":108,"context_line":"    - zun_services[\u0027zun-cni-daemon\u0027].enabled | bool"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- include_tasks: check-containers.yml"},{"line_number":111,"context_line":"  when: kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_de7bbc78","line":108,"in_reply_to":"ff570b3c_c372c3ad","updated":"2020-06-09 10:35:48.000000000","message":"Hmm, but there it is templated out from cni_bin_dir, hence it should be here as well","commit_id":"9946de4c4ac55b4b59145e7d4f8c3c1a4bc1d5ff"}]}
