)]}'
{"ansible/roles/nova-cell/tasks/config-host.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"293e73d293f099c03d7b89eece64ec0f6588e297","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# NOTE(yoctozepto): Part of bug #1681461 fix."},{"line_number":18,"context_line":"# This part can actually run on any distro and lets us drop the hardcoded"},{"line_number":19,"context_line":"# chown and chmod from the nova-libvirt image extend_start and make the process"},{"line_number":20,"context_line":"# more robust."},{"line_number":21,"context_line":"- name: Install udev kolla kvm rules"},{"line_number":22,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_e441fc3a","line":19,"updated":"2020-07-16 08:07:42.000000000","message":"Should we make that change as part of the same bugfix and clean up the TODO there?\n\nhttps://github.com/openstack/kolla/blob/master/docker/nova/nova-libvirt/extend_start.sh#L3\n\nI suppose the approach mention by Sam there would still require some configuration in Kolla Ansible: https://libvirt.org/drvqemu.html#securitydac","commit_id":"5bc9837603fbc5416f62fc85aef4de0859767726"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"223bc82f2d9784296a03bc86a1844b1fc93e7478","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# NOTE(yoctozepto): Part of bug #1681461 fix."},{"line_number":18,"context_line":"# This part can actually run on any distro and lets us drop the hardcoded"},{"line_number":19,"context_line":"# chown and chmod from the nova-libvirt image extend_start and make the process"},{"line_number":20,"context_line":"# more robust."},{"line_number":21,"context_line":"- name: Install udev kolla kvm rules"},{"line_number":22,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_19e1eed0","line":19,"in_reply_to":"bf51134e_a8aa32ce","updated":"2020-07-16 18:10:49.000000000","message":"Done: https://review.opendev.org/741510\nwith Kolla KVM testing under it. We should feel safer touching Nova/libvirt.","commit_id":"5bc9837603fbc5416f62fc85aef4de0859767726"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9ce960532456e2663753f47c08441e47f83e77c1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# NOTE(yoctozepto): Part of bug #1681461 fix."},{"line_number":18,"context_line":"# This part can actually run on any distro and lets us drop the hardcoded"},{"line_number":19,"context_line":"# chown and chmod from the nova-libvirt image extend_start and make the process"},{"line_number":20,"context_line":"# more robust."},{"line_number":21,"context_line":"- name: Install udev kolla kvm rules"},{"line_number":22,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_a8aa32ce","line":19,"in_reply_to":"bf51134e_e441fc3a","updated":"2020-07-16 14:45:23.000000000","message":"I think we have it all set now. I can propose the drop of TODO; forgot the last time.","commit_id":"5bc9837603fbc5416f62fc85aef4de0859767726"}],"ansible/roles/nova-cell/templates/99-kolla-kvm.rules.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"293e73d293f099c03d7b89eece64ec0f6588e297","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Part of Kolla Ansible OpenStack Nova deployment."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# This ensures the /dev/kvm has proper permissions."},{"line_number":4,"context_line":"KERNEL\u003d\u003d\"kvm\", GROUP\u003d\"{{ qemu_user_gid }}\", MODE\u003d\"0660\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bf51134e_a43ee487","line":4,"range":{"start_line":4,"start_character":44,"end_line":4,"end_character":55},"updated":"2020-07-16 08:07:42.000000000","message":"Looking at [1] this appears to be the default, but doesn\u0027t hurt to be explicit.\n\n[1] http://reactivated.net/writing_udev_rules.html","commit_id":"5bc9837603fbc5416f62fc85aef4de0859767726"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9ce960532456e2663753f47c08441e47f83e77c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Part of Kolla Ansible OpenStack Nova deployment."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# This ensures the /dev/kvm has proper permissions."},{"line_number":4,"context_line":"KERNEL\u003d\u003d\"kvm\", GROUP\u003d\"{{ qemu_user_gid }}\", MODE\u003d\"0660\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bf51134e_c83cc6c9","line":4,"range":{"start_line":4,"start_character":44,"end_line":4,"end_character":55},"in_reply_to":"bf51134e_a43ee487","updated":"2020-07-16 14:45:23.000000000","message":"I like it explicit.","commit_id":"5bc9837603fbc5416f62fc85aef4de0859767726"}]}