)]}'
{"ansible/roles/etcd/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5186f40e24730db3d9fc32bda3bda7cafb691975","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      ETCD_INITIAL_ADVERTISE_PEER_URLS: \"{{ ectd_protocol }}://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ etcd_peer_port }}\""},{"line_number":15,"context_line":"      ETCD_LISTEN_PEER_URLS: \"{{ ectd_protocol }}://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ etcd_peer_port }}\""},{"line_number":16,"context_line":"      ETCD_INITIAL_CLUSTER_TOKEN: \"{{ etcd_cluster_token }}\""},{"line_number":17,"context_line":"      ETCD_INITIAL_CLUSTER: \"{% for host in groups[\u0027etcd\u0027] %}{{ hostvars[host][\u0027ansible_hostname\u0027] }}\u003d{{ ectd_protocol }}://{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ etcd_peer_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":18,"context_line":"      ETCD_INITIAL_CLUSTER_STATE: \"new\""},{"line_number":19,"context_line":"      ETCD_OUT_FILE: \"/var/log/kolla/etcd/etcd.log\""},{"line_number":20,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_bcc68247","line":17,"updated":"2020-06-19 07:19:54.000000000","message":"typos all over the place here","commit_id":"008b2e5fbbecf4a4ff61cbb20859ab44409dc665"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"5a2707d67ae24e6fb33d53fa7024299be13f8caf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    environment:"},{"line_number":10,"context_line":"      ETCD_DATA_DIR: \"/var/lib/etcd\""},{"line_number":11,"context_line":"      ETCD_NAME: \"{{ ansible_hostname }}\""},{"line_number":12,"context_line":"      ETCD_ADVERTISE_CLIENT_URLS: \"{{ etcd_protocol }}://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ etcd_client_port }}\""},{"line_number":13,"context_line":"      ETCD_LISTEN_CLIENT_URLS: \"{{ etcd_protocol }}://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ etcd_client_port }}\""},{"line_number":14,"context_line":"      ETCD_INITIAL_ADVERTISE_PEER_URLS: \"{{ etcd_protocol }}://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ etcd_peer_port }}\""},{"line_number":15,"context_line":"      ETCD_LISTEN_PEER_URLS: \"{{ etcd_protocol }}://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ etcd_peer_port }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_79f67565","line":12,"range":{"start_line":12,"start_character":35,"end_line":12,"end_character":38},"updated":"2020-06-24 00:33:15.000000000","message":"Some of these URLS are similar. What about extracting them to a variable?","commit_id":"06d08d40afddc28e8d292e7d15fa1523c6bf47bd"}],"ansible/roles/skydive/templates/skydive-agent.conf.j2":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"5a2707d67ae24e6fb33d53fa7024299be13f8caf","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  servers:"},{"line_number":16,"context_line":"{% if enable_etcd | bool %}"},{"line_number":17,"context_line":"{% for host in groups[\u0027etcd\u0027] %}"},{"line_number":18,"context_line":"    - {{ etcd_protocol }}://{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ etcd_client_port }}"},{"line_number":19,"context_line":"{% endfor %}"},{"line_number":20,"context_line":"{% else %}"},{"line_number":21,"context_line":"{% for host in groups[\u0027skydive-analyzer\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bf51134e_b9ec8d8f","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":116},"updated":"2020-06-24 00:33:15.000000000","message":"Same URL construction here. What about extracting to a variable?","commit_id":"06d08d40afddc28e8d292e7d15fa1523c6bf47bd"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"cba55d2164145d4b6a77a691f32acc5b463d1c82","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  servers:"},{"line_number":16,"context_line":"{% if enable_etcd | bool %}"},{"line_number":17,"context_line":"{% for host in groups[\u0027etcd\u0027] %}"},{"line_number":18,"context_line":"    - {{ etcd_protocol }}://{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ etcd_client_port }}"},{"line_number":19,"context_line":"{% endfor %}"},{"line_number":20,"context_line":"{% else %}"},{"line_number":21,"context_line":"{% for host in groups[\u0027skydive-analyzer\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bf51134e_9d86ce12","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":116},"in_reply_to":"bf51134e_7068421c","updated":"2020-06-24 11:07:48.000000000","message":"I see. You are right, I missed the for loop. \nMy bad.","commit_id":"06d08d40afddc28e8d292e7d15fa1523c6bf47bd"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b2f82bf41ed387e0775ae61712e49e04d5cb31e8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  servers:"},{"line_number":16,"context_line":"{% if enable_etcd | bool %}"},{"line_number":17,"context_line":"{% for host in groups[\u0027etcd\u0027] %}"},{"line_number":18,"context_line":"    - {{ etcd_protocol }}://{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ etcd_client_port }}"},{"line_number":19,"context_line":"{% endfor %}"},{"line_number":20,"context_line":"{% else %}"},{"line_number":21,"context_line":"{% for host in groups[\u0027skydive-analyzer\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bf51134e_7068421c","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":116},"in_reply_to":"bf51134e_b9ec8d8f","updated":"2020-06-24 08:35:57.000000000","message":"It could be tricky to accommodate for loops.","commit_id":"06d08d40afddc28e8d292e7d15fa1523c6bf47bd"}],"ansible/roles/skydive/templates/skydive-analyzer.conf.j2":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"5a2707d67ae24e6fb33d53fa7024299be13f8caf","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  embedded: false"},{"line_number":27,"context_line":"  servers:"},{"line_number":28,"context_line":"{% for host in groups[\u0027etcd\u0027] %}"},{"line_number":29,"context_line":"    - {{ etcd_protocol }}://{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ etcd_client_port }}"},{"line_number":30,"context_line":"{% endfor %}"},{"line_number":31,"context_line":"{% else %}"},{"line_number":32,"context_line":"  embedded: true"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bf51134e_1905b946","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":8},"updated":"2020-06-24 00:33:15.000000000","message":"Same here","commit_id":"06d08d40afddc28e8d292e7d15fa1523c6bf47bd"}],"ansible/roles/zun/templates/zun.conf.j2":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"5a2707d67ae24e6fb33d53fa7024299be13f8caf","unresolved":false,"context_lines":[{"line_number":79,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":80,"context_line":"endpoint_type \u003d internalURL"},{"line_number":81,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":82,"context_line":"insecure \u003d true"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"[neutron_client]"},{"line_number":85,"context_line":"region_name \u003d {{ openstack_region_name }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bf51134e_b9a12d49","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":15},"updated":"2020-06-24 00:33:15.000000000","message":"Insecure by default?\nWhat about leaving the default here (I mean, not declaring it)? Then, if needed, one can just use Kolla-ansible template override mechanism to override it.","commit_id":"06d08d40afddc28e8d292e7d15fa1523c6bf47bd"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b2f82bf41ed387e0775ae61712e49e04d5cb31e8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":80,"context_line":"endpoint_type \u003d internalURL"},{"line_number":81,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":82,"context_line":"insecure \u003d true"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"[neutron_client]"},{"line_number":85,"context_line":"region_name \u003d {{ openstack_region_name }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bf51134e_f06a9217","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":15},"in_reply_to":"bf51134e_b9a12d49","updated":"2020-06-24 08:35:57.000000000","message":"James and Hongbin are testing Zun for why it ignores the cacerts","commit_id":"06d08d40afddc28e8d292e7d15fa1523c6bf47bd"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"cba55d2164145d4b6a77a691f32acc5b463d1c82","unresolved":false,"context_lines":[{"line_number":79,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":80,"context_line":"endpoint_type \u003d internalURL"},{"line_number":81,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":82,"context_line":"insecure \u003d true"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"[neutron_client]"},{"line_number":85,"context_line":"region_name \u003d {{ openstack_region_name }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bf51134e_9db40ed3","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":15},"in_reply_to":"bf51134e_f06a9217","updated":"2020-06-24 11:07:48.000000000","message":"Ok, I see. Thanks for the clarification.","commit_id":"06d08d40afddc28e8d292e7d15fa1523c6bf47bd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"12d9d5acd4cd85af0d94b0e85690ed678527ba91","unresolved":false,"context_lines":[{"line_number":69,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":70,"context_line":"{% endif %}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"[zun_client]"},{"line_number":73,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":74,"context_line":"endpoint_type \u003d internalURL"},{"line_number":75,"context_line":"ca_file \u003d {{ openstack_cacert }}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"[glance_client]"},{"line_number":78,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":79,"context_line":"endpoint_type \u003d internalURL"},{"line_number":80,"context_line":"ca_file \u003d {{ openstack_cacert }}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"[neutron_client]"},{"line_number":83,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":84,"context_line":"endpoint_type \u003d internalURL"},{"line_number":85,"context_line":"ca_file \u003d {{ openstack_cacert }}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"[cinder_client]"},{"line_number":88,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":89,"context_line":"endpoint_type \u003d internalURL"},{"line_number":90,"context_line":"ca_file \u003d {{ openstack_cacert }}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"[placement_client]"},{"line_number":93,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":94,"context_line":"endpoint_type \u003d internalURL"},{"line_number":95,"context_line":"ca_file \u003d {{ openstack_cacert }}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"{% if enable_osprofiler | bool %}"},{"line_number":98,"context_line":"[profiler]"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bf51134e_ae36d601","line":95,"range":{"start_line":72,"start_character":0,"end_line":95,"end_character":32},"updated":"2020-06-26 11:13:18.000000000","message":"I suppose strictly this is a fix for Zun, rather than etcd. We should at least call that out in the commit message, or make a separate commit.","commit_id":"6ddcc716cc98e1b399915e0846dc6aef10aeb46b"}],"zuul.d/base.yaml":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"5a2707d67ae24e6fb33d53fa7024299be13f8caf","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      - ^tests/test-dashboard.sh"},{"line_number":89,"context_line":"    vars:"},{"line_number":90,"context_line":"      scenario: zun"},{"line_number":91,"context_line":"      tls_enabled: true"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- job:"},{"line_number":94,"context_line":"    name: kolla-ansible-swift-base"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_f98605b9","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":23},"updated":"2020-06-24 00:33:15.000000000","message":"It should be enabled only when `etcd_protocol \u003d\u003d https`. Otherwise, it should be false.","commit_id":"06d08d40afddc28e8d292e7d15fa1523c6bf47bd"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"cba55d2164145d4b6a77a691f32acc5b463d1c82","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      - ^tests/test-dashboard.sh"},{"line_number":89,"context_line":"    vars:"},{"line_number":90,"context_line":"      scenario: zun"},{"line_number":91,"context_line":"      tls_enabled: true"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- job:"},{"line_number":94,"context_line":"    name: kolla-ansible-swift-base"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_7dde5a11","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":23},"in_reply_to":"bf51134e_106e262e","updated":"2020-06-24 11:07:48.000000000","message":"Ok, I see.","commit_id":"06d08d40afddc28e8d292e7d15fa1523c6bf47bd"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b2f82bf41ed387e0775ae61712e49e04d5cb31e8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      - ^tests/test-dashboard.sh"},{"line_number":89,"context_line":"    vars:"},{"line_number":90,"context_line":"      scenario: zun"},{"line_number":91,"context_line":"      tls_enabled: true"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- job:"},{"line_number":94,"context_line":"    name: kolla-ansible-swift-base"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_106e262e","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":23},"in_reply_to":"bf51134e_f98605b9","updated":"2020-06-24 08:35:57.000000000","message":"This is Zuul job specification, not part of kolla-ansible.","commit_id":"06d08d40afddc28e8d292e7d15fa1523c6bf47bd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"12d9d5acd4cd85af0d94b0e85690ed678527ba91","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      - ^tests/test-dashboard.sh"},{"line_number":89,"context_line":"    vars:"},{"line_number":90,"context_line":"      scenario: zun"},{"line_number":91,"context_line":"      tls_enabled: true"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- job:"},{"line_number":94,"context_line":"    name: kolla-ansible-swift-base"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bf51134e_ee3c4ee2","line":91,"updated":"2020-06-26 11:13:18.000000000","message":"Needs removing before commit.","commit_id":"6ddcc716cc98e1b399915e0846dc6aef10aeb46b"}]}