)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"change_message_id":"b1f65aa74c2e14da567f9fa7fdb6072770bfc63b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"this patchset has implemented:"},{"line_number":10,"context_line":"  - network(lb_managent_network)"},{"line_number":11,"context_line":"  - secruity_groups and rules (used by amphora and o-hm0)"},{"line_number":12,"context_line":"  - amphora_flvor(used by amphora)"},{"line_number":13,"context_line":"  - nova_keypair(used by amphora at the time of debugging)"},{"line_number":14,"context_line":"  - bond o-hm0 port to ovs"},{"line_number":15,"context_line":"  - create a octavia-interface.service(used for setting o-hm0 after"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"bf51134e_dc01c1b1","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":17},"updated":"2020-08-05 06:10:22.000000000","message":"amphora_flavor","commit_id":"2499121ec8780d524f46a733b6a36cdc325fafa3"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":947,"context_line":"# Load balancer topology options are [ SINGLE, ACTIVE_STANDBY ]"},{"line_number":948,"context_line":"octavia_loadbalancer_topology: \"SINGLE\""},{"line_number":949,"context_line":"octavia_amp_boot_network_list:"},{"line_number":950,"context_line":"octavia_amp_secgroup_list:"},{"line_number":951,"context_line":"octavia_amp_flavor_id:"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"#################"},{"line_number":954,"context_line":"# Qinling options"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_3913a468","side":"PARENT","line":951,"range":{"start_line":950,"start_character":0,"end_line":951,"end_character":22},"updated":"2020-07-23 13:32:01.000000000","message":"Don\u0027t we still need these, for the case where auto_configure_octavia is false?","commit_id":"376988125a8f924f3853c845e12c73ac13b2df74"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":947,"context_line":"# Load balancer topology options are [ SINGLE, ACTIVE_STANDBY ]"},{"line_number":948,"context_line":"octavia_loadbalancer_topology: \"SINGLE\""},{"line_number":949,"context_line":"octavia_amp_boot_network_list:"},{"line_number":950,"context_line":"octavia_amp_secgroup_list:"},{"line_number":951,"context_line":"octavia_amp_flavor_id:"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"#################"},{"line_number":954,"context_line":"# Qinling options"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_cb03a0bd","side":"PARENT","line":951,"range":{"start_line":950,"start_character":0,"end_line":951,"end_character":22},"in_reply_to":"bf51134e_3913a468","updated":"2020-07-24 08:53:53.000000000","message":"those vaules should be written in global.yaml which has a high priority.","commit_id":"376988125a8f924f3853c845e12c73ac13b2df74"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fde718d2101f8ff9a5d7fa40370492b6b92e80ef","unresolved":false,"context_lines":[{"line_number":947,"context_line":"# Load balancer topology options are [ SINGLE, ACTIVE_STANDBY ]"},{"line_number":948,"context_line":"octavia_loadbalancer_topology: \"SINGLE\""},{"line_number":949,"context_line":"octavia_amp_boot_network_list:"},{"line_number":950,"context_line":"octavia_amp_secgroup_list:"},{"line_number":951,"context_line":"octavia_amp_flavor_id:"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"#################"},{"line_number":954,"context_line":"# Qinling options"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_ee0af21d","side":"PARENT","line":951,"range":{"start_line":950,"start_character":0,"end_line":951,"end_character":22},"in_reply_to":"bf51134e_cb03a0bd","updated":"2020-07-24 09:02:11.000000000","message":"left it here for compatibility is also a good way","commit_id":"376988125a8f924f3853c845e12c73ac13b2df74"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":201,"context_line":"swift_replication_interface: \"{{ swift_storage_interface }}\""},{"line_number":202,"context_line":"migration_interface: \"{{ api_interface }}\""},{"line_number":203,"context_line":"tunnel_interface: \"{{ network_interface }}\""},{"line_number":204,"context_line":"octavia_network_interface: \"{{ lb_mgmt_network[\u0027hm_iface_name\u0027] }}\""},{"line_number":205,"context_line":"bifrost_network_interface: \"{{ network_interface }}\""},{"line_number":206,"context_line":"dns_interface: \"{{ network_interface }}\""},{"line_number":207,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_d94d489a","line":204,"updated":"2020-07-23 13:32:01.000000000","message":"I\u0027m concerned about changing this default.","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":955,"context_line":"  disk: 5"},{"line_number":956,"context_line":"lb_mgmt_network:"},{"line_number":957,"context_line":"  name: lb-mgmt-net"},{"line_number":958,"context_line":"  hm_iface_name: o-hm0"},{"line_number":959,"context_line":"  subnet:"},{"line_number":960,"context_line":"    subnet_name: lb-mgmt-subnet"},{"line_number":961,"context_line":"    cidr: 172.16.0.0/24"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_597018db","line":958,"updated":"2020-07-23 13:32:01.000000000","message":"This isn\u0027t really part of the network. Let\u0027s just use octavia_network_interface.","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":955,"context_line":"  disk: 5"},{"line_number":956,"context_line":"lb_mgmt_network:"},{"line_number":957,"context_line":"  name: lb-mgmt-net"},{"line_number":958,"context_line":"  hm_iface_name: o-hm0"},{"line_number":959,"context_line":"  subnet:"},{"line_number":960,"context_line":"    subnet_name: lb-mgmt-subnet"},{"line_number":961,"context_line":"    cidr: 172.16.0.0/24"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_4b20304a","line":958,"in_reply_to":"bf51134e_597018db","updated":"2020-07-24 08:53:53.000000000","message":"ok","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":957,"context_line":"  name: lb-mgmt-net"},{"line_number":958,"context_line":"  hm_iface_name: o-hm0"},{"line_number":959,"context_line":"  subnet:"},{"line_number":960,"context_line":"    subnet_name: lb-mgmt-subnet"},{"line_number":961,"context_line":"    cidr: 172.16.0.0/24"},{"line_number":962,"context_line":"    start:"},{"line_number":963,"context_line":"    end:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_1cadee9a","line":960,"range":{"start_line":960,"start_character":4,"end_line":960,"end_character":15},"updated":"2020-07-23 13:32:01.000000000","message":"name","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":957,"context_line":"  name: lb-mgmt-net"},{"line_number":958,"context_line":"  hm_iface_name: o-hm0"},{"line_number":959,"context_line":"  subnet:"},{"line_number":960,"context_line":"    subnet_name: lb-mgmt-subnet"},{"line_number":961,"context_line":"    cidr: 172.16.0.0/24"},{"line_number":962,"context_line":"    start:"},{"line_number":963,"context_line":"    end:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_2b1b3c1c","line":960,"range":{"start_line":960,"start_character":4,"end_line":960,"end_character":15},"in_reply_to":"bf51134e_1cadee9a","updated":"2020-07-24 08:53:53.000000000","message":"ok","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":959,"context_line":"  subnet:"},{"line_number":960,"context_line":"    subnet_name: lb-mgmt-subnet"},{"line_number":961,"context_line":"    cidr: 172.16.0.0/24"},{"line_number":962,"context_line":"    start:"},{"line_number":963,"context_line":"    end:"},{"line_number":964,"context_line":"auto_generate_certs: \"no\""},{"line_number":965,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_3caa7284","line":962,"range":{"start_line":962,"start_character":4,"end_line":962,"end_character":9},"updated":"2020-07-23 13:32:01.000000000","message":"I would keep the same names as the os_subnet module.","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":959,"context_line":"  subnet:"},{"line_number":960,"context_line":"    subnet_name: lb-mgmt-subnet"},{"line_number":961,"context_line":"    cidr: 172.16.0.0/24"},{"line_number":962,"context_line":"    start:"},{"line_number":963,"context_line":"    end:"},{"line_number":964,"context_line":"auto_generate_certs: \"no\""},{"line_number":965,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_8b1a4814","line":962,"range":{"start_line":962,"start_character":4,"end_line":962,"end_character":9},"in_reply_to":"bf51134e_3caa7284","updated":"2020-07-24 08:53:53.000000000","message":"ok","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":946,"context_line":"#################"},{"line_number":947,"context_line":"# Load balancer topology options are [ SINGLE, ACTIVE_STANDBY ]"},{"line_number":948,"context_line":"octavia_loadbalancer_topology: \"SINGLE\""},{"line_number":949,"context_line":"auto_configure_octavia: yes"},{"line_number":950,"context_line":"octavia_amp_boot_network_list:"},{"line_number":951,"context_line":"amphora_flavor:"},{"line_number":952,"context_line":"  name: \"amphora\""},{"line_number":953,"context_line":"  vcpus: 1"},{"line_number":954,"context_line":"  ram: 1024"},{"line_number":955,"context_line":"  disk: 5"},{"line_number":956,"context_line":"lb_mgmt_network:"},{"line_number":957,"context_line":"  name: lb-mgmt-net"},{"line_number":958,"context_line":"  hm_iface_name: o-hm0"},{"line_number":959,"context_line":"  subnet:"},{"line_number":960,"context_line":"    subnet_name: lb-mgmt-subnet"},{"line_number":961,"context_line":"    cidr: 172.16.0.0/24"},{"line_number":962,"context_line":"    start:"},{"line_number":963,"context_line":"    end:"},{"line_number":964,"context_line":"auto_generate_certs: \"no\""},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"#################"},{"line_number":967,"context_line":"# Qinling options"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_9928f097","line":964,"range":{"start_line":949,"start_character":0,"end_line":964,"end_character":25},"updated":"2020-07-23 13:32:01.000000000","message":"These should all have an octavia_ prefix.","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":946,"context_line":"#################"},{"line_number":947,"context_line":"# Load balancer topology options are [ SINGLE, ACTIVE_STANDBY ]"},{"line_number":948,"context_line":"octavia_loadbalancer_topology: \"SINGLE\""},{"line_number":949,"context_line":"auto_configure_octavia: yes"},{"line_number":950,"context_line":"octavia_amp_boot_network_list:"},{"line_number":951,"context_line":"amphora_flavor:"},{"line_number":952,"context_line":"  name: \"amphora\""},{"line_number":953,"context_line":"  vcpus: 1"},{"line_number":954,"context_line":"  ram: 1024"},{"line_number":955,"context_line":"  disk: 5"},{"line_number":956,"context_line":"lb_mgmt_network:"},{"line_number":957,"context_line":"  name: lb-mgmt-net"},{"line_number":958,"context_line":"  hm_iface_name: o-hm0"},{"line_number":959,"context_line":"  subnet:"},{"line_number":960,"context_line":"    subnet_name: lb-mgmt-subnet"},{"line_number":961,"context_line":"    cidr: 172.16.0.0/24"},{"line_number":962,"context_line":"    start:"},{"line_number":963,"context_line":"    end:"},{"line_number":964,"context_line":"auto_generate_certs: \"no\""},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"#################"},{"line_number":967,"context_line":"# Qinling options"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_cbd1e031","line":964,"range":{"start_line":949,"start_character":0,"end_line":964,"end_character":25},"in_reply_to":"bf51134e_9928f097","updated":"2020-07-24 08:53:53.000000000","message":"ok","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f0f2c44e734e88b624c9ead405ec04cff24d7674","unresolved":false,"context_lines":[{"line_number":977,"context_line":"    gateway_ip: 10.0.0.1"},{"line_number":978,"context_line":"    allocation_pool_start: 10.0.0.2"},{"line_number":979,"context_line":"    allocation_pool_end: 10.255.255.254"},{"line_number":980,"context_line":"octavia_certs_generate: \"no\""},{"line_number":981,"context_line":"octavia_amp_image_tag: \"amphora\""},{"line_number":982,"context_line":"octavia_network_type: \"tenant\""},{"line_number":983,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_79d50ce5","line":980,"updated":"2020-08-19 22:52:42.000000000","message":"Shouldn\u0027t the default be yes to generate the certificates?\nself-signed certificates are almost always the right answer for the internal TLS.","commit_id":"d6b37896bd30328afb00b281fb2a05283909a372"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"86a364786594d9eccef9fa9fd70ad9d1fc0ab276","unresolved":false,"context_lines":[{"line_number":977,"context_line":"    gateway_ip: 10.0.0.1"},{"line_number":978,"context_line":"    allocation_pool_start: 10.0.0.2"},{"line_number":979,"context_line":"    allocation_pool_end: 10.255.255.254"},{"line_number":980,"context_line":"octavia_certs_generate: \"no\""},{"line_number":981,"context_line":"octavia_amp_image_tag: \"amphora\""},{"line_number":982,"context_line":"octavia_network_type: \"tenant\""},{"line_number":983,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_c7842ed6","line":980,"in_reply_to":"9f560f44_79d50ce5","updated":"2020-08-20 09:26:30.000000000","message":"i am not sure whether this is safe. but change it to \"yes\" is ok for me.","commit_id":"d6b37896bd30328afb00b281fb2a05283909a372"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":379,"context_line":"octavia_external_fqdn: \"{{ kolla_external_fqdn }}\""},{"line_number":380,"context_line":"octavia_api_port: \"9876\""},{"line_number":381,"context_line":"octavia_api_listen_port: \"{{ octavia_api_port }}\""},{"line_number":382,"context_line":"octavia_amphora_listen_port: \"9443\""},{"line_number":383,"context_line":"octavia_health_manager_port: \"5555\""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"ovn_nb_db_port: \"6641\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_f46fd190","line":382,"range":{"start_line":382,"start_character":0,"end_line":382,"end_character":35},"updated":"2020-09-14 16:43:55.000000000","message":"This is more relevant to octavia than the API. Please move under octavia defaults.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":988,"context_line":"octavia_amp_boot_network_list:"},{"line_number":989,"context_line":"octavia_amp_secgroup_list:"},{"line_number":990,"context_line":"octavia_amp_flavor_id:"},{"line_number":991,"context_line":"octavia_amphora_flavor:"},{"line_number":992,"context_line":"  flavorid:"},{"line_number":993,"context_line":"  is_public: no"},{"line_number":994,"context_line":"  name: \"amphora\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_cad306d3","line":991,"updated":"2020-09-14 16:43:55.000000000","message":"These variables are only used by octavia, and could be moved to octavia defaults.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":995,"context_line":"  vcpus: 1"},{"line_number":996,"context_line":"  ram: 1024"},{"line_number":997,"context_line":"  disk: 5"},{"line_number":998,"context_line":"octavia_tenant_network:"},{"line_number":999,"context_line":"  name: lb-mgmt-net"},{"line_number":1000,"context_line":"  subnet:"},{"line_number":1001,"context_line":"    name: lb-mgmt-subnet"},{"line_number":1002,"context_line":"    cidr: 10.0.0.0/8"},{"line_number":1003,"context_line":"    allocation_pool_start:"},{"line_number":1004,"context_line":"    allocation_pool_end:"},{"line_number":1005,"context_line":"octavia_provider_network:"},{"line_number":1006,"context_line":"  name: lb-provider-net"},{"line_number":1007,"context_line":"  provider_network_type:"},{"line_number":1008,"context_line":"  provider_physical_network: physnet1"},{"line_number":1009,"context_line":"  provider_segmentation_id:"},{"line_number":1010,"context_line":"  external: yes"},{"line_number":1011,"context_line":"  shared: no"},{"line_number":1012,"context_line":"  subnet:"},{"line_number":1013,"context_line":"    name: lb-provider-subnet"},{"line_number":1014,"context_line":"    cidr: 10.0.0.0/8"},{"line_number":1015,"context_line":"    gateway_ip: 10.0.0.1"},{"line_number":1016,"context_line":"    allocation_pool_start: 10.0.0.2"},{"line_number":1017,"context_line":"    allocation_pool_end: 10.255.255.254"},{"line_number":1018,"context_line":"octavia_certs_generate: \"yes\""},{"line_number":1019,"context_line":"octavia_amp_image_tag: \"amphora\""},{"line_number":1020,"context_line":"octavia_network_type: \"tenant\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_0a705e08","line":1017,"range":{"start_line":998,"start_character":0,"end_line":1017,"end_character":39},"updated":"2020-09-14 16:43:55.000000000","message":"I think these could be combined into a single variable. We could document which fields to set for the different use cases.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1d45d186fee1be7cafb097f1e49fa7d5dc7d14f7","unresolved":false,"context_lines":[{"line_number":379,"context_line":"octavia_external_fqdn: \"{{ kolla_external_fqdn }}\""},{"line_number":380,"context_line":"octavia_api_port: \"9876\""},{"line_number":381,"context_line":"octavia_api_listen_port: \"{{ octavia_api_port }}\""},{"line_number":382,"context_line":"octavia_amphora_listen_port: \"9443\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"ovn_nb_db_port: \"6641\""},{"line_number":385,"context_line":"ovn_sb_db_port: \"6642\""}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f560f44_119cd268","line":382,"updated":"2020-09-21 13:54:32.000000000","message":"Moved the wrong port! octavia_health_manager_port should be here","commit_id":"12521f9350662ccb2b06ccf23e79394d451c5568"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4e48c20af176daf89eb7b0b769b4b5ad69e18533","unresolved":false,"context_lines":[{"line_number":379,"context_line":"octavia_external_fqdn: \"{{ kolla_external_fqdn }}\""},{"line_number":380,"context_line":"octavia_api_port: \"9876\""},{"line_number":381,"context_line":"octavia_api_listen_port: \"{{ octavia_api_port }}\""},{"line_number":382,"context_line":"octavia_amphora_listen_port: \"9443\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"ovn_nb_db_port: \"6641\""},{"line_number":385,"context_line":"ovn_sb_db_port: \"6642\""}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f560f44_aa773f08","line":382,"in_reply_to":"9f560f44_119cd268","updated":"2020-09-21 16:01:49.000000000","message":"yeah, sorry for my mistake.","commit_id":"12521f9350662ccb2b06ccf23e79394d451c5568"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8f4c81a466ad1d36cd62274741374dec4880fbb","unresolved":false,"context_lines":[{"line_number":991,"context_line":"#################"},{"line_number":992,"context_line":"# Load balancer topology options are [ SINGLE, ACTIVE_STANDBY ]"},{"line_number":993,"context_line":"octavia_loadbalancer_topology: \"SINGLE\""},{"line_number":994,"context_line":"octavia_auto_configure: yes"},{"line_number":995,"context_line":"octavia_amp_boot_network_list:"},{"line_number":996,"context_line":"octavia_amp_secgroup_list:"},{"line_number":997,"context_line":"octavia_amp_flavor_id:"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_470b43d4","line":994,"range":{"start_line":994,"start_character":24,"end_line":994,"end_character":27},"updated":"2020-10-01 15:37:33.000000000","message":"upgraders might be unhappy","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2c40b3218135844add96ecbb4d4ed4956038ed9e","unresolved":false,"context_lines":[{"line_number":991,"context_line":"#################"},{"line_number":992,"context_line":"# Load balancer topology options are [ SINGLE, ACTIVE_STANDBY ]"},{"line_number":993,"context_line":"octavia_loadbalancer_topology: \"SINGLE\""},{"line_number":994,"context_line":"octavia_auto_configure: yes"},{"line_number":995,"context_line":"octavia_amp_boot_network_list:"},{"line_number":996,"context_line":"octavia_amp_secgroup_list:"},{"line_number":997,"context_line":"octavia_amp_flavor_id:"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_42b21108","line":994,"range":{"start_line":994,"start_character":24,"end_line":994,"end_character":27},"in_reply_to":"9f560f44_470b43d4","updated":"2020-10-01 18:30:43.000000000","message":"yeah, we have a note","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d1462c51cdfd16256195a13f3791bbf10631ed96","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"# Load balancer topology options are [ SINGLE, ACTIVE_STANDBY ]"},{"line_number":1007,"context_line":"octavia_loadbalancer_topology: \"SINGLE\""},{"line_number":1008,"context_line":"octavia_auto_configure: yes"},{"line_number":1009,"context_line":"octavia_amp_boot_network_list:"},{"line_number":1010,"context_line":"octavia_amp_secgroup_list:"},{"line_number":1011,"context_line":"octavia_amp_flavor_id:"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"#################"},{"line_number":1014,"context_line":"# Qinling options"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"9f560f44_08802e9c","line":1011,"range":{"start_line":1009,"start_character":0,"end_line":1011,"end_character":22},"updated":"2020-10-02 11:29:53.000000000","message":"These are now undefined. Was that intentional? It means that if autoconfigure is disabled, you must set them otherwise config will fail. If you are not using the Amphora backend you might not need to set these. Also affects those deploying from scratch (although that is less important).","commit_id":"8a505ae0238ffbaac30bdb881d5fb487cfab0390"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7c7d38207a465042bf145e4dab38c5e14a0ca887","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"# Load balancer topology options are [ SINGLE, ACTIVE_STANDBY ]"},{"line_number":1007,"context_line":"octavia_loadbalancer_topology: \"SINGLE\""},{"line_number":1008,"context_line":"octavia_auto_configure: yes"},{"line_number":1009,"context_line":"octavia_amp_boot_network_list:"},{"line_number":1010,"context_line":"octavia_amp_secgroup_list:"},{"line_number":1011,"context_line":"octavia_amp_flavor_id:"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"#################"},{"line_number":1014,"context_line":"# Qinling options"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"9f560f44_8b2d5847","line":1011,"range":{"start_line":1009,"start_character":0,"end_line":1011,"end_character":22},"in_reply_to":"9f560f44_08802e9c","updated":"2020-10-02 11:58:55.000000000","message":"Hmm, you have a point. I wanted to have an explicit failure but avoid it for current users - I did not think it thoroughly enough it seems. :-) (but still, there is one if-defined used!)","commit_id":"8a505ae0238ffbaac30bdb881d5fb487cfab0390"}],"ansible/roles/octavia/defaults/main.yml":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"1a6fbfdac9678151c5b715b65c6c0d4791edd8d1","unresolved":false,"context_lines":[{"line_number":167,"context_line":"  username: \"octavia\""},{"line_number":168,"context_line":"  password: \"{{ octavia_keystone_password }}\""},{"line_number":169,"context_line":"  project_name: \"service\""},{"line_number":170,"context_line":"  domain_name: \"default\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"security_groups:"},{"line_number":173,"context_line":"  mgmt-sec-grp:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bf51134e_75326211","line":170,"updated":"2020-07-22 10:04:22.000000000","message":"should add openstack certs variable?","commit_id":"2499121ec8780d524f46a733b6a36cdc325fafa3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":166,"context_line":"  auth_url: \"{{ keystone_admin_url }}\""},{"line_number":167,"context_line":"  username: \"octavia\""},{"line_number":168,"context_line":"  password: \"{{ octavia_keystone_password }}\""},{"line_number":169,"context_line":"  project_name: \"service\""},{"line_number":170,"context_line":"  domain_name: \"default\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"security_groups:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_dc009603","line":169,"range":{"start_line":169,"start_character":17,"end_line":169,"end_character":24},"updated":"2020-07-23 13:32:01.000000000","message":"octavia_service_auth_project","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":166,"context_line":"  auth_url: \"{{ keystone_admin_url }}\""},{"line_number":167,"context_line":"  username: \"octavia\""},{"line_number":168,"context_line":"  password: \"{{ octavia_keystone_password }}\""},{"line_number":169,"context_line":"  project_name: \"service\""},{"line_number":170,"context_line":"  domain_name: \"default\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"security_groups:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_ebde643c","line":169,"range":{"start_line":169,"start_character":17,"end_line":169,"end_character":24},"in_reply_to":"bf51134e_dc009603","updated":"2020-07-24 08:53:53.000000000","message":"got it","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":167,"context_line":"  username: \"octavia\""},{"line_number":168,"context_line":"  password: \"{{ octavia_keystone_password }}\""},{"line_number":169,"context_line":"  project_name: \"service\""},{"line_number":170,"context_line":"  domain_name: \"default\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"security_groups:"},{"line_number":173,"context_line":"  mgmt-sec-grp:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_5c0c8638","line":170,"range":{"start_line":170,"start_character":16,"end_line":170,"end_character":23},"updated":"2020-07-23 13:32:01.000000000","message":"default_project_domain_name","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":167,"context_line":"  username: \"octavia\""},{"line_number":168,"context_line":"  password: \"{{ octavia_keystone_password }}\""},{"line_number":169,"context_line":"  project_name: \"service\""},{"line_number":170,"context_line":"  domain_name: \"default\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"security_groups:"},{"line_number":173,"context_line":"  mgmt-sec-grp:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_4be5d009","line":170,"range":{"start_line":170,"start_character":16,"end_line":170,"end_character":23},"in_reply_to":"bf51134e_5c0c8638","updated":"2020-07-24 08:53:53.000000000","message":"ok","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  project_name: \"service\""},{"line_number":170,"context_line":"  domain_name: \"default\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"security_groups:"},{"line_number":173,"context_line":"  mgmt-sec-grp:"},{"line_number":174,"context_line":"    name: \"lb-mgmt-sec-grp\""},{"line_number":175,"context_line":"    rules:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_b906941f","line":172,"updated":"2020-07-23 13:32:01.000000000","message":"This can be a list - we don\u0027t use the keys.","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  project_name: \"service\""},{"line_number":170,"context_line":"  domain_name: \"default\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"security_groups:"},{"line_number":173,"context_line":"  mgmt-sec-grp:"},{"line_number":174,"context_line":"    name: \"lb-mgmt-sec-grp\""},{"line_number":175,"context_line":"    rules:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_ebb784f4","line":172,"in_reply_to":"bf51134e_b906941f","updated":"2020-07-24 08:53:53.000000000","message":"key name used as a hardcode, but the name is changeable.","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  project_name: \"service\""},{"line_number":170,"context_line":"  domain_name: \"default\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"security_groups:"},{"line_number":173,"context_line":"  mgmt-sec-grp:"},{"line_number":174,"context_line":"    name: \"lb-mgmt-sec-grp\""},{"line_number":175,"context_line":"    rules:"},{"line_number":176,"context_line":"      - protocol: icmp"},{"line_number":177,"context_line":"      - protocol: tcp"},{"line_number":178,"context_line":"        src_port: 22"},{"line_number":179,"context_line":"        dst_port: 22"},{"line_number":180,"context_line":"      - protocol: tcp"},{"line_number":181,"context_line":"        src_port: 9443"},{"line_number":182,"context_line":"        dst_port: 9443"},{"line_number":183,"context_line":"  health-mgr-sec-grp:"},{"line_number":184,"context_line":"    name: \"lb-health-mgr-sec-grp\""},{"line_number":185,"context_line":"    rules:"},{"line_number":186,"context_line":"      - protocol: udp"},{"line_number":187,"context_line":"        src_port: \"{{ octavia_health_manager_port }}\""},{"line_number":188,"context_line":"        dst_port: \"{{ octavia_health_manager_port }}\""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"amp_ssh_key_name: \"octavia_ssh_key\""},{"line_number":191,"context_line":"certs_work_dir: \"/tmp/certs\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_dc29b689","line":191,"range":{"start_line":172,"start_character":0,"end_line":191,"end_character":28},"updated":"2020-07-23 13:32:01.000000000","message":"octavia_ prefix","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  project_name: \"service\""},{"line_number":170,"context_line":"  domain_name: \"default\""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"security_groups:"},{"line_number":173,"context_line":"  mgmt-sec-grp:"},{"line_number":174,"context_line":"    name: \"lb-mgmt-sec-grp\""},{"line_number":175,"context_line":"    rules:"},{"line_number":176,"context_line":"      - protocol: icmp"},{"line_number":177,"context_line":"      - protocol: tcp"},{"line_number":178,"context_line":"        src_port: 22"},{"line_number":179,"context_line":"        dst_port: 22"},{"line_number":180,"context_line":"      - protocol: tcp"},{"line_number":181,"context_line":"        src_port: 9443"},{"line_number":182,"context_line":"        dst_port: 9443"},{"line_number":183,"context_line":"  health-mgr-sec-grp:"},{"line_number":184,"context_line":"    name: \"lb-health-mgr-sec-grp\""},{"line_number":185,"context_line":"    rules:"},{"line_number":186,"context_line":"      - protocol: udp"},{"line_number":187,"context_line":"        src_port: \"{{ octavia_health_manager_port }}\""},{"line_number":188,"context_line":"        dst_port: \"{{ octavia_health_manager_port }}\""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"amp_ssh_key_name: \"octavia_ssh_key\""},{"line_number":191,"context_line":"certs_work_dir: \"/tmp/certs\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_0baab883","line":191,"range":{"start_line":172,"start_character":0,"end_line":191,"end_character":28},"in_reply_to":"bf51134e_dc29b689","updated":"2020-07-24 08:53:53.000000000","message":"got it","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f0f2c44e734e88b624c9ead405ec04cff24d7674","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        src_port: 22"},{"line_number":179,"context_line":"        dst_port: 22"},{"line_number":180,"context_line":"      - protocol: tcp"},{"line_number":181,"context_line":"        src_port: 9443"},{"line_number":182,"context_line":"        dst_port: 9443"},{"line_number":183,"context_line":"  health-mgr-sec-grp:"},{"line_number":184,"context_line":"    name: \"lb-health-mgr-sec-grp\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_b9084491","line":181,"range":{"start_line":181,"start_character":18,"end_line":181,"end_character":22},"updated":"2020-08-19 22:52:42.000000000","message":"This port is also configurable, so maybe it should also be a variable like \"octavia_health_manager_port\" is below?","commit_id":"d6b37896bd30328afb00b281fb2a05283909a372"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"86a364786594d9eccef9fa9fd70ad9d1fc0ab276","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        src_port: 22"},{"line_number":179,"context_line":"        dst_port: 22"},{"line_number":180,"context_line":"      - protocol: tcp"},{"line_number":181,"context_line":"        src_port: 9443"},{"line_number":182,"context_line":"        dst_port: 9443"},{"line_number":183,"context_line":"  health-mgr-sec-grp:"},{"line_number":184,"context_line":"    name: \"lb-health-mgr-sec-grp\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_0753c66c","line":181,"range":{"start_line":181,"start_character":18,"end_line":181,"end_character":22},"in_reply_to":"9f560f44_b9084491","updated":"2020-08-20 09:26:30.000000000","message":"good catch. will update it","commit_id":"d6b37896bd30328afb00b281fb2a05283909a372"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":158,"context_line":"#####################"},{"line_number":159,"context_line":"# integration Options"},{"line_number":160,"context_line":"#####################"},{"line_number":161,"context_line":"octavia_user_auth:"},{"line_number":162,"context_line":"  auth_url: \"{{ keystone_admin_url }}\""},{"line_number":163,"context_line":"  username: \"octavia\""},{"line_number":164,"context_line":"  password: \"{{ octavia_keystone_password }}\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_b4955935","line":161,"range":{"start_line":161,"start_character":0,"end_line":161,"end_character":17},"updated":"2020-09-14 16:43:55.000000000","message":"nit: service_auth would be more consistent with octavia_service_auth_project","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"aa98333501e91d0f4100a845b393cd28a72a18d6","unresolved":false,"context_lines":[{"line_number":158,"context_line":"#####################"},{"line_number":159,"context_line":"# integration Options"},{"line_number":160,"context_line":"#####################"},{"line_number":161,"context_line":"octavia_user_auth:"},{"line_number":162,"context_line":"  auth_url: \"{{ keystone_admin_url }}\""},{"line_number":163,"context_line":"  username: \"octavia\""},{"line_number":164,"context_line":"  password: \"{{ octavia_keystone_password }}\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_c3e3ecd7","line":161,"range":{"start_line":161,"start_character":0,"end_line":161,"end_character":17},"in_reply_to":"9f560f44_b4955935","updated":"2020-09-15 13:52:09.000000000","message":"octavia_service_auth_project is used for backward compatibility, but this patch does not need. even user upgrade from \u0027U\u0027, those variables will not be effect.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1d45d186fee1be7cafb097f1e49fa7d5dc7d14f7","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    allocation_pool_start:"},{"line_number":212,"context_line":"    allocation_pool_end:"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"octavia_provider_network:"},{"line_number":215,"context_line":"  name: lb-provider-net"},{"line_number":216,"context_line":"  provider_network_type:"},{"line_number":217,"context_line":"  provider_physical_network: physnet1"},{"line_number":218,"context_line":"  provider_segmentation_id:"},{"line_number":219,"context_line":"  external: yes"},{"line_number":220,"context_line":"  shared: no"},{"line_number":221,"context_line":"  subnet:"},{"line_number":222,"context_line":"    name: lb-provider-subnet"},{"line_number":223,"context_line":"    cidr: 10.0.0.0/8"},{"line_number":224,"context_line":"    no_gateway_ip: no"},{"line_number":225,"context_line":"    gateway_ip: 10.0.0.1"},{"line_number":226,"context_line":"    allocation_pool_start: 10.0.0.2"},{"line_number":227,"context_line":"    allocation_pool_end: 10.255.255.254"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f560f44_e0b83d76","line":227,"range":{"start_line":214,"start_character":0,"end_line":227,"end_character":39},"updated":"2020-09-21 13:54:32.000000000","message":"I don\u0027t think this is too useful. The user will always need to override it. Why not just have one octavia_network dict?","commit_id":"12521f9350662ccb2b06ccf23e79394d451c5568"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4e48c20af176daf89eb7b0b769b4b5ad69e18533","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    allocation_pool_start:"},{"line_number":212,"context_line":"    allocation_pool_end:"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"octavia_provider_network:"},{"line_number":215,"context_line":"  name: lb-provider-net"},{"line_number":216,"context_line":"  provider_network_type:"},{"line_number":217,"context_line":"  provider_physical_network: physnet1"},{"line_number":218,"context_line":"  provider_segmentation_id:"},{"line_number":219,"context_line":"  external: yes"},{"line_number":220,"context_line":"  shared: no"},{"line_number":221,"context_line":"  subnet:"},{"line_number":222,"context_line":"    name: lb-provider-subnet"},{"line_number":223,"context_line":"    cidr: 10.0.0.0/8"},{"line_number":224,"context_line":"    no_gateway_ip: no"},{"line_number":225,"context_line":"    gateway_ip: 10.0.0.1"},{"line_number":226,"context_line":"    allocation_pool_start: 10.0.0.2"},{"line_number":227,"context_line":"    allocation_pool_end: 10.255.255.254"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f560f44_7b469cc2","line":227,"range":{"start_line":214,"start_character":0,"end_line":227,"end_character":39},"in_reply_to":"9f560f44_e0b83d76","updated":"2020-09-21 16:01:49.000000000","message":"yeah, i will try to use one dict. and remove octavia_provider_network","commit_id":"12521f9350662ccb2b06ccf23e79394d451c5568"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8f4c81a466ad1d36cd62274741374dec4880fbb","unresolved":false,"context_lines":[{"line_number":159,"context_line":"# Integration Options"},{"line_number":160,"context_line":"#####################"},{"line_number":161,"context_line":"octavia_ssh_key_name: \"octavia_ssh_key\""},{"line_number":162,"context_line":"octavia_amphora_listen_port: \"9443\""},{"line_number":163,"context_line":"octavia_amp_image_tag: \"amphora\""},{"line_number":164,"context_line":"octavia_network_type: \"tenant\""},{"line_number":165,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_67f127df","line":162,"range":{"start_line":162,"start_character":8,"end_line":162,"end_character":15},"updated":"2020-10-01 15:37:33.000000000","message":"is not amp \u003d\u003d amphora?","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2c40b3218135844add96ecbb4d4ed4956038ed9e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"# Integration Options"},{"line_number":160,"context_line":"#####################"},{"line_number":161,"context_line":"octavia_ssh_key_name: \"octavia_ssh_key\""},{"line_number":162,"context_line":"octavia_amphora_listen_port: \"9443\""},{"line_number":163,"context_line":"octavia_amp_image_tag: \"amphora\""},{"line_number":164,"context_line":"octavia_network_type: \"tenant\""},{"line_number":165,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_82cb8971","line":162,"range":{"start_line":162,"start_character":8,"end_line":162,"end_character":15},"in_reply_to":"9f560f44_67f127df","updated":"2020-10-01 18:30:43.000000000","message":"yes","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"75e2c60b7d8f1414779a530c2c3a2b9965ef6f8e","unresolved":false,"context_lines":[{"line_number":161,"context_line":"octavia_ssh_key_name: \"octavia_ssh_key\""},{"line_number":162,"context_line":"octavia_amphora_listen_port: \"9443\""},{"line_number":163,"context_line":"octavia_amp_image_tag: \"amphora\""},{"line_number":164,"context_line":"octavia_network_type: \"tenant\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"octavia_user_auth:"},{"line_number":167,"context_line":"  auth_url: \"{{ keystone_admin_url }}\""}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_0527b1c9","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":30},"updated":"2020-09-29 10:07:26.000000000","message":"I don\u0027t feel we should default to creating OVS ports and systemd services, the auto configuration is nice - but as an operator I don\u0027t like the idea that by default I\u0027ll get the additional host-level config. We should add documentation stating that if you want it - you need to set it to \"tenant\".","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"52d0cf126ae6064dbfbc277190020c832e4e23ee","unresolved":false,"context_lines":[{"line_number":161,"context_line":"octavia_ssh_key_name: \"octavia_ssh_key\""},{"line_number":162,"context_line":"octavia_amphora_listen_port: \"9443\""},{"line_number":163,"context_line":"octavia_amp_image_tag: \"amphora\""},{"line_number":164,"context_line":"octavia_network_type: \"tenant\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"octavia_user_auth:"},{"line_number":167,"context_line":"  auth_url: \"{{ keystone_admin_url }}\""}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_af5a1fef","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":30},"in_reply_to":"9f560f44_0527b1c9","updated":"2020-09-29 12:28:14.000000000","message":"I suppose the current approach could be seen as the minimum number of additional dependencies, since you don\u0027t need to enable provider networks or create a VLAN interface.\n\nI was unsure at first too, since I\u0027ve always used provider networks, but maybe it\u0027s ok if it\u0027s clearly documented?","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"21d1ff116e2481368489abd92f56fe29bc28e91b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"octavia_ssh_key_name: \"octavia_ssh_key\""},{"line_number":162,"context_line":"octavia_amphora_listen_port: \"9443\""},{"line_number":163,"context_line":"octavia_amp_image_tag: \"amphora\""},{"line_number":164,"context_line":"octavia_network_type: \"tenant\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"octavia_user_auth:"},{"line_number":167,"context_line":"  auth_url: \"{{ keystone_admin_url }}\""}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_477a2377","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":30},"in_reply_to":"9f560f44_af5a1fef","updated":"2020-10-01 15:16:49.000000000","message":"From one perspective - yes I agree, it\u0027s a minimum number of additional dependencies. From another perspective - with my operator hat - I\u0027m not really used to Kolla-Ansible create systemd units, especially that this systemd unit is not the standard way to configure networking... It needs to be thoroughly documented at least - and still I feel it will become \u0027\u0027fernet\u0027\u0027 of Victoria :)","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8f4c81a466ad1d36cd62274741374dec4880fbb","unresolved":false,"context_lines":[{"line_number":163,"context_line":"octavia_amp_image_tag: \"amphora\""},{"line_number":164,"context_line":"octavia_network_type: \"tenant\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"octavia_user_auth:"},{"line_number":167,"context_line":"  auth_url: \"{{ keystone_admin_url }}\""},{"line_number":168,"context_line":"  username: \"octavia\""},{"line_number":169,"context_line":"  password: \"{{ octavia_keystone_password }}\""}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_07866b17","line":166,"updated":"2020-10-01 15:37:33.000000000","message":"could use a comment what this one is used for","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2c40b3218135844add96ecbb4d4ed4956038ed9e","unresolved":false,"context_lines":[{"line_number":163,"context_line":"octavia_amp_image_tag: \"amphora\""},{"line_number":164,"context_line":"octavia_network_type: \"tenant\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"octavia_user_auth:"},{"line_number":167,"context_line":"  auth_url: \"{{ keystone_admin_url }}\""},{"line_number":168,"context_line":"  username: \"octavia\""},{"line_number":169,"context_line":"  password: \"{{ octavia_keystone_password }}\""}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_02865917","line":166,"in_reply_to":"9f560f44_07866b17","updated":"2020-10-01 18:30:43.000000000","message":"Done","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8f4c81a466ad1d36cd62274741374dec4880fbb","unresolved":false,"context_lines":[{"line_number":181,"context_line":"# - ram"},{"line_number":182,"context_line":"# - swap (optional)"},{"line_number":183,"context_line":"# - vcpus"},{"line_number":184,"context_line":"octavia_amphora_flavor:"},{"line_number":185,"context_line":"  name: \"amphora\""},{"line_number":186,"context_line":"  is_public: no"},{"line_number":187,"context_line":"  vcpus: 1"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_e72ed740","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":15},"updated":"2020-10-01 15:37:33.000000000","message":"ditto","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2c40b3218135844add96ecbb4d4ed4956038ed9e","unresolved":false,"context_lines":[{"line_number":181,"context_line":"# - ram"},{"line_number":182,"context_line":"# - swap (optional)"},{"line_number":183,"context_line":"# - vcpus"},{"line_number":184,"context_line":"octavia_amphora_flavor:"},{"line_number":185,"context_line":"  name: \"amphora\""},{"line_number":186,"context_line":"  is_public: no"},{"line_number":187,"context_line":"  vcpus: 1"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_c273c14d","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":15},"in_reply_to":"9f560f44_e72ed740","updated":"2020-10-01 18:30:43.000000000","message":"Done","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8f4c81a466ad1d36cd62274741374dec4880fbb","unresolved":false,"context_lines":[{"line_number":188,"context_line":"  ram: 1024"},{"line_number":189,"context_line":"  disk: 5"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"octavia_security_groups:"},{"line_number":192,"context_line":"  mgmt-sec-grp:"},{"line_number":193,"context_line":"    name: \"lb-mgmt-sec-grp\""},{"line_number":194,"context_line":"    rules:"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_e78a5718","line":191,"range":{"start_line":191,"start_character":0,"end_line":191,"end_character":23},"updated":"2020-10-01 15:37:33.000000000","message":"ditto: could use a comment (and why such defaults)","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2c40b3218135844add96ecbb4d4ed4956038ed9e","unresolved":false,"context_lines":[{"line_number":188,"context_line":"  ram: 1024"},{"line_number":189,"context_line":"  disk: 5"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"octavia_security_groups:"},{"line_number":192,"context_line":"  mgmt-sec-grp:"},{"line_number":193,"context_line":"    name: \"lb-mgmt-sec-grp\""},{"line_number":194,"context_line":"    rules:"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_a2704d42","line":191,"range":{"start_line":191,"start_character":0,"end_line":191,"end_character":23},"in_reply_to":"9f560f44_e78a5718","updated":"2020-10-01 18:30:43.000000000","message":"Done","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"}],"ansible/roles/octavia/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1d45d186fee1be7cafb097f1e49fa7d5dc7d14f7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    dest: \"{{ node_config_directory }}/octavia-worker/{{ octavia_ssh_key_name }}\""},{"line_number":89,"context_line":"    owner: \"{{ config_owner_user }}\""},{"line_number":90,"context_line":"    group: \"{{ config_owner_group }}\""},{"line_number":91,"context_line":"    mode: \"0400\""},{"line_number":92,"context_line":"  become: True"},{"line_number":93,"context_line":"  when: inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f560f44_20aa3519","line":91,"range":{"start_line":91,"start_character":11,"end_line":91,"end_character":15},"updated":"2020-09-21 13:54:32.000000000","message":"This makes it not writeable. Is that correct?","commit_id":"12521f9350662ccb2b06ccf23e79394d451c5568"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4e48c20af176daf89eb7b0b769b4b5ad69e18533","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    dest: \"{{ node_config_directory }}/octavia-worker/{{ octavia_ssh_key_name }}\""},{"line_number":89,"context_line":"    owner: \"{{ config_owner_user }}\""},{"line_number":90,"context_line":"    group: \"{{ config_owner_group }}\""},{"line_number":91,"context_line":"    mode: \"0400\""},{"line_number":92,"context_line":"  become: True"},{"line_number":93,"context_line":"  when: inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f560f44_5b5c7818","line":91,"range":{"start_line":91,"start_character":11,"end_line":91,"end_character":15},"in_reply_to":"9f560f44_20aa3519","updated":"2020-09-21 16:01:49.000000000","message":"yeah, this is a private key, and only used while debugging,  the permission should not open, otherwise, ssh can not use it. i prefer to put the key to a hidden directory(eg: .ssh/)","commit_id":"12521f9350662ccb2b06ccf23e79394d451c5568"}],"ansible/roles/octavia/tasks/generate_octavia_certs.yml":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"1a6fbfdac9678151c5b715b65c6c0d4791edd8d1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: create server_ca and client_ca directory"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"/tmp/certs/{{ item }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    mode: 0770"},{"line_number":7,"context_line":"  loop:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bf51134e_155e8644","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":22},"updated":"2020-07-22 10:04:22.000000000","message":"this directory should not hardcode?","commit_id":"2499121ec8780d524f46a733b6a36cdc325fafa3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f0f2c44e734e88b624c9ead405ec04cff24d7674","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    block: \"{{ lookup(\u0027file\u0027, \u0027{{ octavia_certs_work_dir }}/client_ca/client.cert.pem\u0027) }}\""},{"line_number":124,"context_line":"  when: client_info.changed"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"- name: copy the certs to {{ node_custom_config }}"},{"line_number":127,"context_line":"  copy:"},{"line_number":128,"context_line":"    src: \"{{ item.src }}\""},{"line_number":129,"context_line":"    dest: \"{{ item.dest }}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_198330ce","line":126,"updated":"2020-08-19 22:52:42.000000000","message":"You might want to set the file mode and owner here.\nThese files should only be accessible to the Octavia account/process.","commit_id":"d6b37896bd30328afb00b281fb2a05283909a372"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"593a06eac18c33afddd6f1aaed0793ce40347a94","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    block: \"{{ lookup(\u0027file\u0027, \u0027{{ octavia_certs_work_dir }}/client_ca/client.cert.pem\u0027) }}\""},{"line_number":124,"context_line":"  when: client_info.changed"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"- name: copy the certs to {{ node_custom_config }}"},{"line_number":127,"context_line":"  copy:"},{"line_number":128,"context_line":"    src: \"{{ item.src }}\""},{"line_number":129,"context_line":"    dest: \"{{ item.dest }}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_b614c6a1","line":126,"in_reply_to":"9f560f44_198330ce","updated":"2020-08-20 13:50:21.000000000","message":"here we cannot  set owner, because the current user need to access them. otherwise, ansible can not copy them to other nodes.  finally, those certs will copy to octavia container and set owner and permission. https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/octavia/templates/octavia-health-manager.json.j2","commit_id":"d6b37896bd30328afb00b281fb2a05283909a372"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1d45d186fee1be7cafb097f1e49fa7d5dc7d14f7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    - { src: \"{{ octavia_certs_work_dir }}/server_ca/ca.cert.pem\", dest: \"{{ node_custom_config }}/octavia/server_ca.cert.pem\" }"},{"line_number":132,"context_line":"    - { src: \"{{ octavia_certs_work_dir }}/server_ca/server_ca.key.pem\", dest: \"{{ node_custom_config }}/octavia/server_ca.key.pem\" }"},{"line_number":133,"context_line":"    - { src: \"{{ octavia_certs_work_dir }}/client_ca/ca.cert.pem\", dest: \"{{ node_custom_config }}/octavia/client_ca.cert.pem\" }"},{"line_number":134,"context_line":"    - { src: \"{{ octavia_certs_work_dir }}/client_ca/client.cert-and-key.pem\", dest: \"{{ node_custom_config }}/octavia/client.cert-and-key.pem\" }"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f560f44_e06ddd03","line":134,"updated":"2020-09-21 13:54:32.000000000","message":"This would be easier to read if you move octavia_certs_work_dir and octavia_certs_work_dir/octavia to src and dest.","commit_id":"12521f9350662ccb2b06ccf23e79394d451c5568"}],"ansible/roles/octavia/tasks/hm-interface.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8f4c81a466ad1d36cd62274741374dec4880fbb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Bond port to openvswitch br-int"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    port_mac: \"{{ port_info.port.mac_address }}\""},{"line_number":5,"context_line":"    port_id: \"{{ port_info.id }}\""}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_e72b77e7","line":2,"range":{"start_line":2,"start_character":8,"end_line":2,"end_character":12},"updated":"2020-10-01 15:37:33.000000000","message":"nit: Add octavia port...","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"}],"ansible/roles/octavia/tasks/prepare.yml":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"1a6fbfdac9678151c5b715b65c6c0d4791edd8d1","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    --os-project-domain-name {{ octavia_user_auth.domain_name }}"},{"line_number":158,"context_line":"    --os-project-name {{ octavia_user_auth.project_name }}"},{"line_number":159,"context_line":"    --os-username {{ octavia_user_auth.username }}"},{"line_number":160,"context_line":"    --os-password {{ octavia_user_auth.password }}"},{"line_number":161,"context_line":"    port set --host {{ ansible_hostname }} {{ port_id }}"},{"line_number":162,"context_line":"  when:"},{"line_number":163,"context_line":"    - port_info.changed"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bf51134e_152326c0","line":160,"updated":"2020-07-22 10:04:22.000000000","message":"should add openstack certs variable too?","commit_id":"2499121ec8780d524f46a733b6a36cdc325fafa3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Create amphora flavor"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_toolbox:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_3c59d2fd","line":1,"updated":"2020-07-23 13:32:01.000000000","message":"All of these tasks need these arguments:\n\ncacert: \"{{ openstack_cacert }}\"\ninterface: internal\nregion_name: \"{{ openstack_region_name }}\"","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Create amphora flavor"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_toolbox:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_cb88c023","line":1,"in_reply_to":"bf51134e_3c59d2fd","updated":"2020-07-24 08:53:53.000000000","message":"ok","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      name: \"{{ amphora_flavor.name }}\""},{"line_number":10,"context_line":"      vcpus: \"{{ amphora_flavor.vcpus }}\""},{"line_number":11,"context_line":"      ram: \"{{ amphora_flavor.ram }}\""},{"line_number":12,"context_line":"      disk: \"{{ amphora_flavor.disk }}\""},{"line_number":13,"context_line":"  run_once: True"},{"line_number":14,"context_line":"  delegate_to: \"{{ groups[\u0027octavia-api\u0027][0] }}\""},{"line_number":15,"context_line":"  register: amphora_flavor_info"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_3ca43208","line":12,"updated":"2020-07-23 13:32:01.000000000","message":"Let\u0027s support specifying a flavor ID:\n\nflavorid: \"{{ octavia_amp_flavor_id or omit }}\"\n\nAnd make it private:\n\nis_public: false","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      name: \"{{ amphora_flavor.name }}\""},{"line_number":10,"context_line":"      vcpus: \"{{ amphora_flavor.vcpus }}\""},{"line_number":11,"context_line":"      ram: \"{{ amphora_flavor.ram }}\""},{"line_number":12,"context_line":"      disk: \"{{ amphora_flavor.disk }}\""},{"line_number":13,"context_line":"  run_once: True"},{"line_number":14,"context_line":"  delegate_to: \"{{ groups[\u0027octavia-api\u0027][0] }}\""},{"line_number":15,"context_line":"  register: amphora_flavor_info"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_6bd414ea","line":12,"in_reply_to":"bf51134e_3ca43208","updated":"2020-07-24 08:53:53.000000000","message":"i have tested private flavor, if use a private flavor, the octavia vms which created by octavia user in service project can not show a correct flavor info in dashboard. but it works  \nproperly","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      auth: \"{{ octavia_user_auth }}\""},{"line_number":107,"context_line":"      state: present"},{"line_number":108,"context_line":"      name: \"{{ lb_mgmt_network[\u0027name\u0027] }}\""},{"line_number":109,"context_line":"      shared: no"},{"line_number":110,"context_line":"  register: network_info"},{"line_number":111,"context_line":"  run_once: True"},{"line_number":112,"context_line":"  delegate_to: \"{{ groups[\u0027octavia-api\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_9cea9ed5","line":109,"updated":"2020-07-23 13:32:01.000000000","message":"We should support VLAN provider networks here too.\n\nprovider_network_type\nprovider_physical_network\nprovider_segmentation_id","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      auth: \"{{ octavia_user_auth }}\""},{"line_number":107,"context_line":"      state: present"},{"line_number":108,"context_line":"      name: \"{{ lb_mgmt_network[\u0027name\u0027] }}\""},{"line_number":109,"context_line":"      shared: no"},{"line_number":110,"context_line":"  register: network_info"},{"line_number":111,"context_line":"  run_once: True"},{"line_number":112,"context_line":"  delegate_to: \"{{ groups[\u0027octavia-api\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_eb84a4d5","line":109,"in_reply_to":"bf51134e_9cea9ed5","updated":"2020-07-24 08:53:53.000000000","message":"this network is a tenant net, not a provider network. vlan or vxlan or gre decided by neutron configs. we can\u0027t decide this tenant type.","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    --os-project-domain-name {{ octavia_user_auth.domain_name }}"},{"line_number":158,"context_line":"    --os-project-name {{ octavia_user_auth.project_name }}"},{"line_number":159,"context_line":"    --os-username {{ octavia_user_auth.username }}"},{"line_number":160,"context_line":"    --os-password {{ octavia_user_auth.password }}"},{"line_number":161,"context_line":"    port set --host {{ ansible_hostname }} {{ port_id }}"},{"line_number":162,"context_line":"  when:"},{"line_number":163,"context_line":"    - port_info.changed"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_7ccfca56","line":160,"updated":"2020-07-23 13:32:01.000000000","message":"--os-cacert {{ openstack_cacert }}","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  run_once: True"},{"line_number":129,"context_line":"  delegate_to: \"{{ groups[\u0027octavia-api\u0027][0] }}\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- name: Create ports for octavia-worker nodes"},{"line_number":132,"context_line":"  become: true"},{"line_number":133,"context_line":"  kolla_toolbox:"},{"line_number":134,"context_line":"    module_name: os_port"},{"line_number":135,"context_line":"    module_args:"},{"line_number":136,"context_line":"      auth: \"{{ octavia_user_auth }}\""},{"line_number":137,"context_line":"      state: present"},{"line_number":138,"context_line":"      network: \"{{ lb_mgmt_network[\u0027name\u0027] }}\""},{"line_number":139,"context_line":"      security_groups: \"{{ security_groups[\u0027health-mgr-sec-grp\u0027][\u0027name\u0027] }}\""},{"line_number":140,"context_line":"      device_owner: \u0027Octavia:health-mgr\u0027"},{"line_number":141,"context_line":"      name: \"octava-listen-port-{{ ansible_hostname }}\""},{"line_number":142,"context_line":"  register: port_info"},{"line_number":143,"context_line":"  when: inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"# ansible os_port module does not support \u0027host\u0027 parameter, but we need set the port\u0027s host"},{"line_number":146,"context_line":"# value to {{ ansible_hostname }}, once os_port support this parameter, remove the task below"},{"line_number":147,"context_line":"# https://docs.ansible.com/ansible/latest/modules/os_port_module.html#parameters"},{"line_number":148,"context_line":"- name: update port host_id"},{"line_number":149,"context_line":"  become: True"},{"line_number":150,"context_line":"  vars:"},{"line_number":151,"context_line":"    port_id: \"{{ port_info.id }}\""},{"line_number":152,"context_line":"  command: \u003e"},{"line_number":153,"context_line":"    docker exec kolla_toolbox openstack"},{"line_number":154,"context_line":"    --os-interface internal"},{"line_number":155,"context_line":"    --os-auth-url {{ octavia_user_auth.auth_url }}"},{"line_number":156,"context_line":"    --os-identity-api-version 3"},{"line_number":157,"context_line":"    --os-project-domain-name {{ octavia_user_auth.domain_name }}"},{"line_number":158,"context_line":"    --os-project-name {{ octavia_user_auth.project_name }}"},{"line_number":159,"context_line":"    --os-username {{ octavia_user_auth.username }}"},{"line_number":160,"context_line":"    --os-password {{ octavia_user_auth.password }}"},{"line_number":161,"context_line":"    port set --host {{ ansible_hostname }} {{ port_id }}"},{"line_number":162,"context_line":"  when:"},{"line_number":163,"context_line":"    - port_info.changed"},{"line_number":164,"context_line":"    - inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# TODO(wuchunyang): need to implement brctl agent"},{"line_number":167,"context_line":"- name: Bond port to openvswitch br-int"},{"line_number":168,"context_line":"  vars:"},{"line_number":169,"context_line":"    port_ip: \"{{ port_info.port.fixed_ips[0].ip_address }}\""},{"line_number":170,"context_line":"    port_mac: \"{{ port_info.port.mac_address }}\""},{"line_number":171,"context_line":"    port_id: \"{{ port_info.id }}\""},{"line_number":172,"context_line":"    iface_name: \"{{ lb_mgmt_network[\u0027hm_iface_name\u0027] }}\""},{"line_number":173,"context_line":"  become: True"},{"line_number":174,"context_line":"  command: \u003e"},{"line_number":175,"context_line":"    docker exec openvswitch_vswitchd ovs-vsctl --may-exist \\"},{"line_number":176,"context_line":"    add-port br-int {{ iface_name }} -- set Interface {{ iface_name }} type\u003dinternal \\"},{"line_number":177,"context_line":"    -- set Interface {{ iface_name }} external-ids:iface-status\u003dactive -- set Interface \\"},{"line_number":178,"context_line":"    {{ iface_name }}  external-ids:attached-mac\u003d{{ port_mac }}  -- set Interface \\"},{"line_number":179,"context_line":"    {{ iface_name }}  external-ids:iface-id\u003d{{ port_id }} -- set Interface {{ iface_name }} \\"},{"line_number":180,"context_line":"    external-ids:skip_cleanup\u003dtrue"},{"line_number":181,"context_line":"  when:"},{"line_number":182,"context_line":"    - inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"- block:"},{"line_number":185,"context_line":"    - name: Create octavia dhclient conf"},{"line_number":186,"context_line":"      copy:"},{"line_number":187,"context_line":"        content: |"},{"line_number":188,"context_line":"          request subnet-mask,broadcast-address,interface-mtu;"},{"line_number":189,"context_line":"          do-forward-updates false;"},{"line_number":190,"context_line":"        dest: /etc/dhcp/octavia-dhclient.conf"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    - name: Create octavia-interface service"},{"line_number":193,"context_line":"      become: True"},{"line_number":194,"context_line":"      template:"},{"line_number":195,"context_line":"        src: octavia-interface.service.j2"},{"line_number":196,"context_line":"        dest: /etc/systemd/system/octavia-interface.service"},{"line_number":197,"context_line":"      when: inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    - name: enable and start octavia-interface.service"},{"line_number":200,"context_line":"      become: True"},{"line_number":201,"context_line":"      service:"},{"line_number":202,"context_line":"        name: octavia-interface"},{"line_number":203,"context_line":"        enabled: yes"},{"line_number":204,"context_line":"        state: started"},{"line_number":205,"context_line":"  when: inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"- name: Ensure octavia certificates exist"},{"line_number":208,"context_line":"  stat:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_dc909645","line":205,"range":{"start_line":131,"start_character":0,"end_line":205,"end_character":81},"updated":"2020-07-23 13:32:01.000000000","message":"This should be optional. A valid alternative is to use a VLAN provider network.","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  run_once: True"},{"line_number":129,"context_line":"  delegate_to: \"{{ groups[\u0027octavia-api\u0027][0] }}\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- name: Create ports for octavia-worker nodes"},{"line_number":132,"context_line":"  become: true"},{"line_number":133,"context_line":"  kolla_toolbox:"},{"line_number":134,"context_line":"    module_name: os_port"},{"line_number":135,"context_line":"    module_args:"},{"line_number":136,"context_line":"      auth: \"{{ octavia_user_auth }}\""},{"line_number":137,"context_line":"      state: present"},{"line_number":138,"context_line":"      network: \"{{ lb_mgmt_network[\u0027name\u0027] }}\""},{"line_number":139,"context_line":"      security_groups: \"{{ security_groups[\u0027health-mgr-sec-grp\u0027][\u0027name\u0027] }}\""},{"line_number":140,"context_line":"      device_owner: \u0027Octavia:health-mgr\u0027"},{"line_number":141,"context_line":"      name: \"octava-listen-port-{{ ansible_hostname }}\""},{"line_number":142,"context_line":"  register: port_info"},{"line_number":143,"context_line":"  when: inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"# ansible os_port module does not support \u0027host\u0027 parameter, but we need set the port\u0027s host"},{"line_number":146,"context_line":"# value to {{ ansible_hostname }}, once os_port support this parameter, remove the task below"},{"line_number":147,"context_line":"# https://docs.ansible.com/ansible/latest/modules/os_port_module.html#parameters"},{"line_number":148,"context_line":"- name: update port host_id"},{"line_number":149,"context_line":"  become: True"},{"line_number":150,"context_line":"  vars:"},{"line_number":151,"context_line":"    port_id: \"{{ port_info.id }}\""},{"line_number":152,"context_line":"  command: \u003e"},{"line_number":153,"context_line":"    docker exec kolla_toolbox openstack"},{"line_number":154,"context_line":"    --os-interface internal"},{"line_number":155,"context_line":"    --os-auth-url {{ octavia_user_auth.auth_url }}"},{"line_number":156,"context_line":"    --os-identity-api-version 3"},{"line_number":157,"context_line":"    --os-project-domain-name {{ octavia_user_auth.domain_name }}"},{"line_number":158,"context_line":"    --os-project-name {{ octavia_user_auth.project_name }}"},{"line_number":159,"context_line":"    --os-username {{ octavia_user_auth.username }}"},{"line_number":160,"context_line":"    --os-password {{ octavia_user_auth.password }}"},{"line_number":161,"context_line":"    port set --host {{ ansible_hostname }} {{ port_id }}"},{"line_number":162,"context_line":"  when:"},{"line_number":163,"context_line":"    - port_info.changed"},{"line_number":164,"context_line":"    - inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# TODO(wuchunyang): need to implement brctl agent"},{"line_number":167,"context_line":"- name: Bond port to openvswitch br-int"},{"line_number":168,"context_line":"  vars:"},{"line_number":169,"context_line":"    port_ip: \"{{ port_info.port.fixed_ips[0].ip_address }}\""},{"line_number":170,"context_line":"    port_mac: \"{{ port_info.port.mac_address }}\""},{"line_number":171,"context_line":"    port_id: \"{{ port_info.id }}\""},{"line_number":172,"context_line":"    iface_name: \"{{ lb_mgmt_network[\u0027hm_iface_name\u0027] }}\""},{"line_number":173,"context_line":"  become: True"},{"line_number":174,"context_line":"  command: \u003e"},{"line_number":175,"context_line":"    docker exec openvswitch_vswitchd ovs-vsctl --may-exist \\"},{"line_number":176,"context_line":"    add-port br-int {{ iface_name }} -- set Interface {{ iface_name }} type\u003dinternal \\"},{"line_number":177,"context_line":"    -- set Interface {{ iface_name }} external-ids:iface-status\u003dactive -- set Interface \\"},{"line_number":178,"context_line":"    {{ iface_name }}  external-ids:attached-mac\u003d{{ port_mac }}  -- set Interface \\"},{"line_number":179,"context_line":"    {{ iface_name }}  external-ids:iface-id\u003d{{ port_id }} -- set Interface {{ iface_name }} \\"},{"line_number":180,"context_line":"    external-ids:skip_cleanup\u003dtrue"},{"line_number":181,"context_line":"  when:"},{"line_number":182,"context_line":"    - inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"- block:"},{"line_number":185,"context_line":"    - name: Create octavia dhclient conf"},{"line_number":186,"context_line":"      copy:"},{"line_number":187,"context_line":"        content: |"},{"line_number":188,"context_line":"          request subnet-mask,broadcast-address,interface-mtu;"},{"line_number":189,"context_line":"          do-forward-updates false;"},{"line_number":190,"context_line":"        dest: /etc/dhcp/octavia-dhclient.conf"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    - name: Create octavia-interface service"},{"line_number":193,"context_line":"      become: True"},{"line_number":194,"context_line":"      template:"},{"line_number":195,"context_line":"        src: octavia-interface.service.j2"},{"line_number":196,"context_line":"        dest: /etc/systemd/system/octavia-interface.service"},{"line_number":197,"context_line":"      when: inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    - name: enable and start octavia-interface.service"},{"line_number":200,"context_line":"      become: True"},{"line_number":201,"context_line":"      service:"},{"line_number":202,"context_line":"        name: octavia-interface"},{"line_number":203,"context_line":"        enabled: yes"},{"line_number":204,"context_line":"        state: started"},{"line_number":205,"context_line":"  when: inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"- name: Ensure octavia certificates exist"},{"line_number":208,"context_line":"  stat:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_eba02445","line":205,"range":{"start_line":131,"start_character":0,"end_line":205,"end_character":81},"in_reply_to":"bf51134e_dc909645","updated":"2020-07-24 08:53:53.000000000","message":"for compatibility, i will add a octavia_network_id parameter ,if this parameter is not none ,then we don\u0027t do those above, but for vlan or flat provider network, create it  manually may better. because we can\u0027t ensure that network works correctly,\nThe Provider network requires the cooperation of an external switch","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"58819c6fbbcb62304663f38ed0290febe75699bf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      interface: internal"},{"line_number":10,"context_line":"      region_name: \"{{ openstack_region_name }}\""},{"line_number":11,"context_line":"      state: present"},{"line_number":12,"context_line":"      is_public: no"},{"line_number":13,"context_line":"      name: \"{{ octavia_amphora_flavor.name }}\""},{"line_number":14,"context_line":"      flavorid: \"{{ octavia_amphora_flavor.flavorid if octavia_amphora_flavor.flavorid is not none else omit }}\""},{"line_number":15,"context_line":"      vcpus: \"{{ octavia_amphora_flavor.vcpus }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_1221b04e","line":12,"range":{"start_line":12,"start_character":6,"end_line":12,"end_character":15},"updated":"2020-07-27 10:44:07.000000000","message":"is_public: \"{{ octavia_amphora_flavor.is_public | default(\u0027no\u0027) }}\"","commit_id":"abc2f836cc751fbf8c782f3c6a4d6830437e9925"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"58819c6fbbcb62304663f38ed0290febe75699bf","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      state: present"},{"line_number":12,"context_line":"      is_public: no"},{"line_number":13,"context_line":"      name: \"{{ octavia_amphora_flavor.name }}\""},{"line_number":14,"context_line":"      flavorid: \"{{ octavia_amphora_flavor.flavorid if octavia_amphora_flavor.flavorid is not none else omit }}\""},{"line_number":15,"context_line":"      vcpus: \"{{ octavia_amphora_flavor.vcpus }}\""},{"line_number":16,"context_line":"      ram: \"{{ octavia_amphora_flavor.ram }}\""},{"line_number":17,"context_line":"      disk: \"{{ octavia_amphora_flavor.disk }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_ef5b7751","line":14,"updated":"2020-07-27 10:44:07.000000000","message":"octavia_amphora_flavor.flavorid | default(omit, true)","commit_id":"abc2f836cc751fbf8c782f3c6a4d6830437e9925"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fdb923a8375791090dc3661c89508fbd524fafea","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      state: present"},{"line_number":12,"context_line":"      is_public: no"},{"line_number":13,"context_line":"      name: \"{{ octavia_amphora_flavor.name }}\""},{"line_number":14,"context_line":"      flavorid: \"{{ octavia_amphora_flavor.flavorid if octavia_amphora_flavor.flavorid is not none else omit }}\""},{"line_number":15,"context_line":"      vcpus: \"{{ octavia_amphora_flavor.vcpus }}\""},{"line_number":16,"context_line":"      ram: \"{{ octavia_amphora_flavor.ram }}\""},{"line_number":17,"context_line":"      disk: \"{{ octavia_amphora_flavor.disk }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_b8e6e3e7","line":14,"in_reply_to":"9f560f44_ef5b7751","updated":"2020-07-27 11:34:02.000000000","message":"good knowledge , thanks , will do this soon","commit_id":"abc2f836cc751fbf8c782f3c6a4d6830437e9925"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"58819c6fbbcb62304663f38ed0290febe75699bf","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      protocol: \"{{ item.1.protocol }}\""},{"line_number":53,"context_line":"      port_range_min: \"{{ item.1.src_port | default(omit) }}\""},{"line_number":54,"context_line":"      port_range_max: \"{{ item.1.dst_port | default(omit) }}\""},{"line_number":55,"context_line":"  with_subelements:"},{"line_number":56,"context_line":"    - \"{{ octavia_security_groups }}\""},{"line_number":57,"context_line":"    - rules"},{"line_number":58,"context_line":"  run_once: True"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_f2f4fcd1","line":55,"range":{"start_line":55,"start_character":2,"end_line":55,"end_character":18},"updated":"2020-07-27 10:44:07.000000000","message":"Does this work with a dict?","commit_id":"abc2f836cc751fbf8c782f3c6a4d6830437e9925"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fdb923a8375791090dc3661c89508fbd524fafea","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      protocol: \"{{ item.1.protocol }}\""},{"line_number":53,"context_line":"      port_range_min: \"{{ item.1.src_port | default(omit) }}\""},{"line_number":54,"context_line":"      port_range_max: \"{{ item.1.dst_port | default(omit) }}\""},{"line_number":55,"context_line":"  with_subelements:"},{"line_number":56,"context_line":"    - \"{{ octavia_security_groups }}\""},{"line_number":57,"context_line":"    - rules"},{"line_number":58,"context_line":"  run_once: True"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_b8ff0366","line":55,"range":{"start_line":55,"start_character":2,"end_line":55,"end_character":18},"in_reply_to":"9f560f44_f2f4fcd1","updated":"2020-07-27 11:34:02.000000000","message":"yeah, i have tested it.","commit_id":"abc2f836cc751fbf8c782f3c6a4d6830437e9925"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"58819c6fbbcb62304663f38ed0290febe75699bf","unresolved":false,"context_lines":[{"line_number":250,"context_line":"      when:"},{"line_number":251,"context_line":"        - neutron_plugin_agent \u003d\u003d \"openvswitch\""},{"line_number":252,"context_line":"        - inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":253,"context_line":"  when: octavia_network_type \u003d\u003d \"internal\""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"- block:"},{"line_number":256,"context_line":"    - name: Ensure octavia certificates exist"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_f2e23c01","line":253,"range":{"start_line":253,"start_character":8,"end_line":253,"end_character":28},"updated":"2020-07-27 10:44:07.000000000","message":"What values are supported for this?","commit_id":"abc2f836cc751fbf8c782f3c6a4d6830437e9925"},{"author":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"change_message_id":"4731ff77fabd87a5b7dd3154315870a26a93f165","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  run_once: True"},{"line_number":70,"context_line":"  delegate_to: localhost"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Create openssh keypair"},{"line_number":73,"context_line":"  openssh_keypair:"},{"line_number":74,"context_line":"    path: \"{{ node_custom_config }}/octavia/.ssh/{{ octavia_ssh_key_name }}\""},{"line_number":75,"context_line":"  delegate_to: localhost"},{"line_number":76,"context_line":"  run_once: True"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# we create this directory before run config.yml because we need"},{"line_number":79,"context_line":"# copy private key to this directroy"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9f560f44_95b21c48","line":76,"range":{"start_line":72,"start_character":0,"end_line":76,"end_character":16},"updated":"2020-08-06 08:21:32.000000000","message":"There is an error when deploy by not-root and  octavia_ssh_key belong to  root user even use not-root","commit_id":"19fa3393894be6305523fd97141050a7f788235b"},{"author":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"change_message_id":"440092cbc04160030f10b0c1ebd70733887f3df5","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  openssh_keypair:"},{"line_number":72,"context_line":"    path: \"{{ node_custom_config }}/octavia/.ssh/{{ octavia_ssh_key_name }}\""},{"line_number":73,"context_line":"    mode: \"0400\""},{"line_number":74,"context_line":"    owner: \"{{ ansible_user }}\""},{"line_number":75,"context_line":"  register: key_info"},{"line_number":76,"context_line":"  delegate_to: localhost"},{"line_number":77,"context_line":"  run_once: True"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"9f560f44_5465dd44","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":31},"updated":"2020-08-12 06:12:58.000000000","message":"if the user not exist on the deployment node ?","commit_id":"d2fa8f09e3346be216ab83d7ab241a04269c3176"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"83c6859c710f21ef2c5caaf57bc5a90b235f1156","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  openssh_keypair:"},{"line_number":72,"context_line":"    path: \"{{ node_custom_config }}/octavia/.ssh/{{ octavia_ssh_key_name }}\""},{"line_number":73,"context_line":"    mode: \"0400\""},{"line_number":74,"context_line":"    owner: \"{{ ansible_user }}\""},{"line_number":75,"context_line":"  register: key_info"},{"line_number":76,"context_line":"  delegate_to: localhost"},{"line_number":77,"context_line":"  run_once: True"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"9f560f44_5d34d9fb","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":31},"in_reply_to":"9f560f44_5465dd44","updated":"2020-08-12 15:57:04.000000000","message":"this user will be the current user.","commit_id":"d2fa8f09e3346be216ab83d7ab241a04269c3176"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f0f2c44e734e88b624c9ead405ec04cff24d7674","unresolved":false,"context_lines":[{"line_number":150,"context_line":"      run_once: True"},{"line_number":151,"context_line":"      delegate_to: \"{{ groups[\u0027octavia-api\u0027][0] }}\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    - name: Create ports for octavia-worker nodes"},{"line_number":154,"context_line":"      become: true"},{"line_number":155,"context_line":"      kolla_toolbox:"},{"line_number":156,"context_line":"        module_name: os_port"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_b964c44a","line":153,"updated":"2020-08-19 22:52:42.000000000","message":"The API instance doesn\u0027t need this port, does there need to be a group restriction here?","commit_id":"d6b37896bd30328afb00b281fb2a05283909a372"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"86a364786594d9eccef9fa9fd70ad9d1fc0ab276","unresolved":false,"context_lines":[{"line_number":150,"context_line":"      run_once: True"},{"line_number":151,"context_line":"      delegate_to: \"{{ groups[\u0027octavia-api\u0027][0] }}\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    - name: Create ports for octavia-worker nodes"},{"line_number":154,"context_line":"      become: true"},{"line_number":155,"context_line":"      kolla_toolbox:"},{"line_number":156,"context_line":"        module_name: os_port"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_678f22cd","line":153,"in_reply_to":"9f560f44_b964c44a","updated":"2020-08-20 09:26:30.000000000","message":"yeah, the restriction is located at line 251,  lines between 116 and 251 only affect octavia worker nodes. those ports needed by octavia worker only.","commit_id":"d6b37896bd30328afb00b281fb2a05283909a372"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    module_name: os_nova_flavor"},{"line_number":6,"context_line":"    module_args:"},{"line_number":7,"context_line":"      auth: \"{{ octavia_user_auth }}\""},{"line_number":8,"context_line":"      ca_cert: \"{{ openstack_cacert }}\""},{"line_number":9,"context_line":"      interface: internal"},{"line_number":10,"context_line":"      region_name: \"{{ openstack_region_name }}\""},{"line_number":11,"context_line":"      state: present"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_1449a5b6","line":8,"range":{"start_line":8,"start_character":6,"end_line":8,"end_character":13},"updated":"2020-09-14 16:43:55.000000000","message":"nit: we use cacert elsewhere.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    module_args:"},{"line_number":7,"context_line":"      auth: \"{{ octavia_user_auth }}\""},{"line_number":8,"context_line":"      ca_cert: \"{{ openstack_cacert }}\""},{"line_number":9,"context_line":"      interface: internal"},{"line_number":10,"context_line":"      region_name: \"{{ openstack_region_name }}\""},{"line_number":11,"context_line":"      state: present"},{"line_number":12,"context_line":"      is_public: \"{{ octavia_amphora_flavor.is_public }}\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_742d81ad","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":25},"updated":"2020-09-14 16:43:55.000000000","message":"{{ openstack_interface }}","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      interface: internal"},{"line_number":10,"context_line":"      region_name: \"{{ openstack_region_name }}\""},{"line_number":11,"context_line":"      state: present"},{"line_number":12,"context_line":"      is_public: \"{{ octavia_amphora_flavor.is_public }}\""},{"line_number":13,"context_line":"      name: \"{{ octavia_amphora_flavor.name }}\""},{"line_number":14,"context_line":"      flavorid: \"{{ octavia_amphora_flavor.flavorid | default(omit, true) }}\""},{"line_number":15,"context_line":"      vcpus: \"{{ octavia_amphora_flavor.vcpus }}\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_b4cd5932","line":12,"updated":"2020-09-14 16:43:55.000000000","message":"| bool","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      flavorid: \"{{ octavia_amphora_flavor.flavorid | default(omit, true) }}\""},{"line_number":15,"context_line":"      vcpus: \"{{ octavia_amphora_flavor.vcpus }}\""},{"line_number":16,"context_line":"      ram: \"{{ octavia_amphora_flavor.ram }}\""},{"line_number":17,"context_line":"      disk: \"{{ octavia_amphora_flavor.disk }}\""},{"line_number":18,"context_line":"  run_once: True"},{"line_number":19,"context_line":"  delegate_to: \"{{ groups[\u0027octavia-api\u0027][0] }}\""},{"line_number":20,"context_line":"  register: amphora_flavor_info"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_14f7e55b","line":17,"updated":"2020-09-14 16:43:55.000000000","message":"We should probably support extra_specs, with default(omit). Maybe also swap and ephemeral.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Ensuring octavia custom config directory exist"},{"line_number":78,"context_line":"  file:"},{"line_number":79,"context_line":"    path: \"{{ node_custom_config }}/octavia/.ssh\""},{"line_number":80,"context_line":"    state: \"directory\""},{"line_number":81,"context_line":"    mode: \"0770\""},{"line_number":82,"context_line":"  run_once: True"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_cf0b1820","line":79,"range":{"start_line":79,"start_character":44,"end_line":79,"end_character":48},"updated":"2020-09-14 16:43:55.000000000","message":"A dot directory will make this hidden, and may confuse people. Can we just create the key in the octavia/ directory?","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"aa98333501e91d0f4100a845b393cd28a72a18d6","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Ensuring octavia custom config directory exist"},{"line_number":78,"context_line":"  file:"},{"line_number":79,"context_line":"    path: \"{{ node_custom_config }}/octavia/.ssh\""},{"line_number":80,"context_line":"    state: \"directory\""},{"line_number":81,"context_line":"    mode: \"0770\""},{"line_number":82,"context_line":"  run_once: True"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_415d0f14","line":79,"range":{"start_line":79,"start_character":44,"end_line":79,"end_character":48},"in_reply_to":"9f560f44_cf0b1820","updated":"2020-09-15 13:52:09.000000000","message":"I did this on purpose because I didn\u0027t want the common user  to see this file. so use a hidden directory, if we don\u0027t need ,we can put this file under /etc/octavia/worker/, because only octavia worker node need this key.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"- name: Create openssh keypair"},{"line_number":86,"context_line":"  become: True"},{"line_number":87,"context_line":"  openssh_keypair:"},{"line_number":88,"context_line":"    path: \"{{ node_custom_config }}/octavia/.ssh/{{ octavia_ssh_key_name }}\""},{"line_number":89,"context_line":"    mode: \"0400\""},{"line_number":90,"context_line":"    owner: \"{{ ansible_user }}\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_8f580032","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":18},"updated":"2020-09-14 16:43:55.000000000","message":"We do have support in kolla-genpwd to generate SSH keys.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  openssh_keypair:"},{"line_number":88,"context_line":"    path: \"{{ node_custom_config }}/octavia/.ssh/{{ octavia_ssh_key_name }}\""},{"line_number":89,"context_line":"    mode: \"0400\""},{"line_number":90,"context_line":"    owner: \"{{ ansible_user }}\""},{"line_number":91,"context_line":"  register: key_info"},{"line_number":92,"context_line":"  delegate_to: localhost"},{"line_number":93,"context_line":"  run_once: True"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_4f29c887","line":90,"range":{"start_line":90,"start_character":15,"end_line":90,"end_character":27},"updated":"2020-09-14 16:43:55.000000000","message":"This variable is optional and may not be set. It is better to use ansible_user_id","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  delegate_to: localhost"},{"line_number":93,"context_line":"  run_once: True"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# we create this directory before run config.yml because we need"},{"line_number":96,"context_line":"# copy private key to this directroy"},{"line_number":97,"context_line":"- name: Ensuring config directory exist for octavia-worker"},{"line_number":98,"context_line":"  become: true"},{"line_number":99,"context_line":"  file:"},{"line_number":100,"context_line":"    path: \"{{ node_config_directory }}/octavia-worker\""},{"line_number":101,"context_line":"    state: \"directory\""},{"line_number":102,"context_line":"    owner: \"{{ config_owner_user }}\""},{"line_number":103,"context_line":"    group: \"{{ config_owner_group }}\""},{"line_number":104,"context_line":"    mode: \"0770\""},{"line_number":105,"context_line":"  when: inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"- name: Copying over octavia_ssh_key for octavia"},{"line_number":108,"context_line":"  copy:"},{"line_number":109,"context_line":"    src: \"{{ node_custom_config }}/octavia/.ssh\""},{"line_number":110,"context_line":"    dest: \"{{ node_config_directory }}/octavia-worker\""},{"line_number":111,"context_line":"    owner: \"{{ config_owner_user }}\""},{"line_number":112,"context_line":"    group: \"{{ config_owner_group }}\""},{"line_number":113,"context_line":"    mode: \"0400\""},{"line_number":114,"context_line":"  become: True"},{"line_number":115,"context_line":"  when: inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"- name: Create nova keypair for amphora"},{"line_number":118,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_8f23e0a7","line":115,"range":{"start_line":95,"start_character":0,"end_line":115,"end_character":81},"updated":"2020-09-14 16:43:55.000000000","message":"We can move this to config.yml","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        port_id: \"{{ port_info.id }}\""},{"line_number":192,"context_line":"      command: \u003e"},{"line_number":193,"context_line":"        docker exec kolla_toolbox openstack"},{"line_number":194,"context_line":"        --os-interface internal"},{"line_number":195,"context_line":"        --os-auth-url {{ octavia_user_auth.auth_url }}"},{"line_number":196,"context_line":"        --os-identity-api-version 3"},{"line_number":197,"context_line":"        --os-project-domain-name {{ octavia_user_auth.domain_name }}"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_6a33dac5","line":194,"range":{"start_line":194,"start_character":23,"end_line":194,"end_character":31},"updated":"2020-09-14 16:43:55.000000000","message":"openstack_interface","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        --os-username {{ octavia_user_auth.username }}"},{"line_number":201,"context_line":"        --os-password {{ octavia_user_auth.password }}"},{"line_number":202,"context_line":"        {% if openstack_cacert !\u003d \u0027\u0027 %}--os-cacert {{ openstack_cacert }}{% endif %}"},{"line_number":203,"context_line":"        port set --host {{ ansible_hostname }} {{ port_id }}"},{"line_number":204,"context_line":"      when:"},{"line_number":205,"context_line":"        - port_info.changed"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_0ab97e14","line":203,"range":{"start_line":203,"start_character":27,"end_line":203,"end_character":43},"updated":"2020-09-14 16:43:55.000000000","message":"I expect this should be ansible_nodename","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":182,"context_line":"          name: \"octava-listen-port-{{ ansible_hostname }}\""},{"line_number":183,"context_line":"      register: port_info"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # ansible os_port module does not support \u0027host\u0027 parameter, but we need set the port\u0027s host"},{"line_number":186,"context_line":"    # value to {{ ansible_hostname }}, once os_port support this parameter, remove the task below"},{"line_number":187,"context_line":"    # https://docs.ansible.com/ansible/latest/modules/os_port_module.html#parameters"},{"line_number":188,"context_line":"    - name: update port host_id"},{"line_number":189,"context_line":"      become: True"},{"line_number":190,"context_line":"      vars:"},{"line_number":191,"context_line":"        port_id: \"{{ port_info.id }}\""},{"line_number":192,"context_line":"      command: \u003e"},{"line_number":193,"context_line":"        docker exec kolla_toolbox openstack"},{"line_number":194,"context_line":"        --os-interface internal"},{"line_number":195,"context_line":"        --os-auth-url {{ octavia_user_auth.auth_url }}"},{"line_number":196,"context_line":"        --os-identity-api-version 3"},{"line_number":197,"context_line":"        --os-project-domain-name {{ octavia_user_auth.domain_name }}"},{"line_number":198,"context_line":"        --os-project-name {{ octavia_user_auth.project_name }}"},{"line_number":199,"context_line":"        --os-region-name {{ openstack_region_name }}"},{"line_number":200,"context_line":"        --os-username {{ octavia_user_auth.username }}"},{"line_number":201,"context_line":"        --os-password {{ octavia_user_auth.password }}"},{"line_number":202,"context_line":"        {% if openstack_cacert !\u003d \u0027\u0027 %}--os-cacert {{ openstack_cacert }}{% endif %}"},{"line_number":203,"context_line":"        port set --host {{ ansible_hostname }} {{ port_id }}"},{"line_number":204,"context_line":"      when:"},{"line_number":205,"context_line":"        - port_info.changed"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    - name: Bond port to openvswitch br-int"},{"line_number":208,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_6a975a9e","line":205,"range":{"start_line":185,"start_character":0,"end_line":205,"end_character":27},"updated":"2020-09-14 16:43:55.000000000","message":"Shouldn\u0027t this be done after the interface has been created?","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"1713300fdd29909ba0d71f339a78a567697ba84b","unresolved":false,"context_lines":[{"line_number":182,"context_line":"          name: \"octava-listen-port-{{ ansible_hostname }}\""},{"line_number":183,"context_line":"      register: port_info"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # ansible os_port module does not support \u0027host\u0027 parameter, but we need set the port\u0027s host"},{"line_number":186,"context_line":"    # value to {{ ansible_hostname }}, once os_port support this parameter, remove the task below"},{"line_number":187,"context_line":"    # https://docs.ansible.com/ansible/latest/modules/os_port_module.html#parameters"},{"line_number":188,"context_line":"    - name: update port host_id"},{"line_number":189,"context_line":"      become: True"},{"line_number":190,"context_line":"      vars:"},{"line_number":191,"context_line":"        port_id: \"{{ port_info.id }}\""},{"line_number":192,"context_line":"      command: \u003e"},{"line_number":193,"context_line":"        docker exec kolla_toolbox openstack"},{"line_number":194,"context_line":"        --os-interface internal"},{"line_number":195,"context_line":"        --os-auth-url {{ octavia_user_auth.auth_url }}"},{"line_number":196,"context_line":"        --os-identity-api-version 3"},{"line_number":197,"context_line":"        --os-project-domain-name {{ octavia_user_auth.domain_name }}"},{"line_number":198,"context_line":"        --os-project-name {{ octavia_user_auth.project_name }}"},{"line_number":199,"context_line":"        --os-region-name {{ openstack_region_name }}"},{"line_number":200,"context_line":"        --os-username {{ octavia_user_auth.username }}"},{"line_number":201,"context_line":"        --os-password {{ octavia_user_auth.password }}"},{"line_number":202,"context_line":"        {% if openstack_cacert !\u003d \u0027\u0027 %}--os-cacert {{ openstack_cacert }}{% endif %}"},{"line_number":203,"context_line":"        port set --host {{ ansible_hostname }} {{ port_id }}"},{"line_number":204,"context_line":"      when:"},{"line_number":205,"context_line":"        - port_info.changed"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    - name: Bond port to openvswitch br-int"},{"line_number":208,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_33c5cc3e","line":205,"range":{"start_line":185,"start_character":0,"end_line":205,"end_character":27},"in_reply_to":"9f560f44_136d28cc","updated":"2020-09-15 14:55:09.000000000","message":"that is no need, we create this interface by a service called octavia-interface, this service will create the link, set mac, and obtain ip. linux interface  must be created after neutron port. otherwise the interface will not get the ip. this may cause  octavia-interface service failed .","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"aa98333501e91d0f4100a845b393cd28a72a18d6","unresolved":false,"context_lines":[{"line_number":182,"context_line":"          name: \"octava-listen-port-{{ ansible_hostname }}\""},{"line_number":183,"context_line":"      register: port_info"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # ansible os_port module does not support \u0027host\u0027 parameter, but we need set the port\u0027s host"},{"line_number":186,"context_line":"    # value to {{ ansible_hostname }}, once os_port support this parameter, remove the task below"},{"line_number":187,"context_line":"    # https://docs.ansible.com/ansible/latest/modules/os_port_module.html#parameters"},{"line_number":188,"context_line":"    - name: update port host_id"},{"line_number":189,"context_line":"      become: True"},{"line_number":190,"context_line":"      vars:"},{"line_number":191,"context_line":"        port_id: \"{{ port_info.id }}\""},{"line_number":192,"context_line":"      command: \u003e"},{"line_number":193,"context_line":"        docker exec kolla_toolbox openstack"},{"line_number":194,"context_line":"        --os-interface internal"},{"line_number":195,"context_line":"        --os-auth-url {{ octavia_user_auth.auth_url }}"},{"line_number":196,"context_line":"        --os-identity-api-version 3"},{"line_number":197,"context_line":"        --os-project-domain-name {{ octavia_user_auth.domain_name }}"},{"line_number":198,"context_line":"        --os-project-name {{ octavia_user_auth.project_name }}"},{"line_number":199,"context_line":"        --os-region-name {{ openstack_region_name }}"},{"line_number":200,"context_line":"        --os-username {{ octavia_user_auth.username }}"},{"line_number":201,"context_line":"        --os-password {{ octavia_user_auth.password }}"},{"line_number":202,"context_line":"        {% if openstack_cacert !\u003d \u0027\u0027 %}--os-cacert {{ openstack_cacert }}{% endif %}"},{"line_number":203,"context_line":"        port set --host {{ ansible_hostname }} {{ port_id }}"},{"line_number":204,"context_line":"      when:"},{"line_number":205,"context_line":"        - port_info.changed"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    - name: Bond port to openvswitch br-int"},{"line_number":208,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_9797659d","line":205,"range":{"start_line":185,"start_character":0,"end_line":205,"end_character":27},"in_reply_to":"9f560f44_6a975a9e","updated":"2020-09-15 13:52:09.000000000","message":"sorry, i don\u0027t understand you. i do this because after neutron port created, we  must set port host value to hostname. otherwise this port will not work.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4a123d19715514c7f6ad5764527016814d8ecfde","unresolved":false,"context_lines":[{"line_number":182,"context_line":"          name: \"octava-listen-port-{{ ansible_hostname }}\""},{"line_number":183,"context_line":"      register: port_info"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # ansible os_port module does not support \u0027host\u0027 parameter, but we need set the port\u0027s host"},{"line_number":186,"context_line":"    # value to {{ ansible_hostname }}, once os_port support this parameter, remove the task below"},{"line_number":187,"context_line":"    # https://docs.ansible.com/ansible/latest/modules/os_port_module.html#parameters"},{"line_number":188,"context_line":"    - name: update port host_id"},{"line_number":189,"context_line":"      become: True"},{"line_number":190,"context_line":"      vars:"},{"line_number":191,"context_line":"        port_id: \"{{ port_info.id }}\""},{"line_number":192,"context_line":"      command: \u003e"},{"line_number":193,"context_line":"        docker exec kolla_toolbox openstack"},{"line_number":194,"context_line":"        --os-interface internal"},{"line_number":195,"context_line":"        --os-auth-url {{ octavia_user_auth.auth_url }}"},{"line_number":196,"context_line":"        --os-identity-api-version 3"},{"line_number":197,"context_line":"        --os-project-domain-name {{ octavia_user_auth.domain_name }}"},{"line_number":198,"context_line":"        --os-project-name {{ octavia_user_auth.project_name }}"},{"line_number":199,"context_line":"        --os-region-name {{ openstack_region_name }}"},{"line_number":200,"context_line":"        --os-username {{ octavia_user_auth.username }}"},{"line_number":201,"context_line":"        --os-password {{ octavia_user_auth.password }}"},{"line_number":202,"context_line":"        {% if openstack_cacert !\u003d \u0027\u0027 %}--os-cacert {{ openstack_cacert }}{% endif %}"},{"line_number":203,"context_line":"        port set --host {{ ansible_hostname }} {{ port_id }}"},{"line_number":204,"context_line":"      when:"},{"line_number":205,"context_line":"        - port_info.changed"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    - name: Bond port to openvswitch br-int"},{"line_number":208,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_136d28cc","line":205,"range":{"start_line":185,"start_character":0,"end_line":205,"end_character":27},"in_reply_to":"9f560f44_9797659d","updated":"2020-09-15 14:36:13.000000000","message":"I mean the linux interface. I think if the MAC address is deterministic we can create the linux interface first.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":204,"context_line":"      when:"},{"line_number":205,"context_line":"        - port_info.changed"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    - name: Bond port to openvswitch br-int"},{"line_number":208,"context_line":"      vars:"},{"line_number":209,"context_line":"        port_ip: \"{{ port_info.port.fixed_ips[0].ip_address }}\""},{"line_number":210,"context_line":"        port_mac: \"{{ port_info.port.mac_address }}\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_0a8cded5","line":207,"updated":"2020-09-14 16:43:55.000000000","message":"I think we could separate this host configuration for the port into a separate file. It could be included in a config-host.yml file for consistency with other services.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    - name: wait interface {{ octavia_network_interface }} ip appear"},{"line_number":253,"context_line":"      vars:"},{"line_number":254,"context_line":"        port_ip: \"{{ port_info.port.fixed_ips[0].ip_address }}\""},{"line_number":255,"context_line":"      command: hostname -I"},{"line_number":256,"context_line":"      changed_when: false"},{"line_number":257,"context_line":"      register: ip_info"},{"line_number":258,"context_line":"      until: ip_info.stdout.find(port_ip) !\u003d -1"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_4a2ff63d","line":255,"range":{"start_line":255,"start_character":15,"end_line":255,"end_character":26},"updated":"2020-09-14 16:43:55.000000000","message":"ip address show dev {{ octavia_network_interface }}","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    - octavia_network_type \u003d\u003d \"tenant\""},{"line_number":267,"context_line":"    - inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"- block:"},{"line_number":270,"context_line":"    - name: Create loadbalancer management network"},{"line_number":271,"context_line":"      become: true"},{"line_number":272,"context_line":"      kolla_toolbox:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_0a15fee5","line":269,"updated":"2020-09-14 16:43:55.000000000","message":"I would prefer to collapse these tasks with the tenant network ones. We can just use default(omit) and support every parameter.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"09b1f3d97e8a94bef68b1b29aa97e953194fc6e1","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    - octavia_network_type \u003d\u003d \"tenant\""},{"line_number":267,"context_line":"    - inventory_hostname in groups[octavia_services[\u0027octavia-worker\u0027][\u0027group\u0027]]"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"- block:"},{"line_number":270,"context_line":"    - name: Create loadbalancer management network"},{"line_number":271,"context_line":"      become: true"},{"line_number":272,"context_line":"      kolla_toolbox:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_d9d90f29","line":269,"in_reply_to":"9f560f44_0a15fee5","updated":"2020-09-15 16:31:42.000000000","message":"maybe i need consider how to do it.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":308,"context_line":"      delegate_to: \"{{ groups[\u0027octavia-api\u0027][0] }}\""},{"line_number":309,"context_line":"  when: octavia_network_type \u003d\u003d \"provider\""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"- block:"},{"line_number":312,"context_line":"    - name: Ensure octavia certificates exist"},{"line_number":313,"context_line":"      stat:"},{"line_number":314,"context_line":"        path: \"{{ node_custom_config }}/octavia/{{ item }}\""},{"line_number":315,"context_line":"      loop:"},{"line_number":316,"context_line":"        - client_ca.cert.pem"},{"line_number":317,"context_line":"        - client.cert-and-key.pem"},{"line_number":318,"context_line":"        - server_ca.cert.pem"},{"line_number":319,"context_line":"        - server_ca.key.pem"},{"line_number":320,"context_line":"      register: cert_info"},{"line_number":321,"context_line":"      run_once: True"},{"line_number":322,"context_line":"      delegate_to: localhost"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    # 0 indicates that there is no cert in \u0027/etc/kolla/config/octavia\u0027 directory"},{"line_number":325,"context_line":"    # 4 indicates that there are four certs in \u0027/etc/kolla/config/octavia\u0027 directory"},{"line_number":326,"context_line":"    # if there is no certs in the directory, we create certs, otherwise, do not create"},{"line_number":327,"context_line":"    - name: generate octavia certificates"},{"line_number":328,"context_line":"      vars:"},{"line_number":329,"context_line":"        exists_cert_counts: \"{{ cert_info.results | selectattr(\u0027stat.exists\u0027, \u0027equalto\u0027, true) | list | length }}\""},{"line_number":330,"context_line":"      import_tasks: generate_octavia_certs.yml"},{"line_number":331,"context_line":"      run_once: True"},{"line_number":332,"context_line":"      delegate_to: localhost"},{"line_number":333,"context_line":"      when:"},{"line_number":334,"context_line":"        - exists_cert_counts \u003d\u003d \u00270\u0027"},{"line_number":335,"context_line":"  when: octavia_certs_generate | bool"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9f560f44_ca766640","line":335,"range":{"start_line":311,"start_character":0,"end_line":335,"end_character":37},"updated":"2020-09-14 16:43:55.000000000","message":"I\u0027m tempted to say this should be a separate command. e.g. kolla-ansible octavia-certificates. I will think.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"}],"ansible/roles/octavia/templates/octavia-interface.service.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"Type\u003doneshot"},{"line_number":8,"context_line":"RemainAfterExit\u003dtrue"},{"line_number":9,"context_line":"ExecStartPre\u003d/usr/bin/sudo /sbin/ip link set dev {{ octavia_network_interface}} address {{ port_info.port.mac_address }}"},{"line_number":10,"context_line":"ExecStart\u003d/usr/bin/sudo /sbin/dhclient -v {{ octavia_network_interface }} -cf /etc/dhcp/octavia-dhclient.conf"},{"line_number":11,"context_line":"ExecStop\u003d/usr/bin/sudo /sbin/dhclient -r {{ octavia_network_interface }}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"9f560f44_2ac28235","line":9,"range":{"start_line":9,"start_character":88,"end_line":9,"end_character":120},"updated":"2020-09-14 16:43:55.000000000","message":"We could make this deterministic (using a seed of the hostname plus some string):\n\nhttps://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#random-mac-address-filter\n\nThat would decouple the host configuration from the neutron port.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4a123d19715514c7f6ad5764527016814d8ecfde","unresolved":false,"context_lines":[{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"Type\u003doneshot"},{"line_number":8,"context_line":"RemainAfterExit\u003dtrue"},{"line_number":9,"context_line":"ExecStartPre\u003d/usr/bin/sudo /sbin/ip link set dev {{ octavia_network_interface}} address {{ port_info.port.mac_address }}"},{"line_number":10,"context_line":"ExecStart\u003d/usr/bin/sudo /sbin/dhclient -v {{ octavia_network_interface }} -cf /etc/dhcp/octavia-dhclient.conf"},{"line_number":11,"context_line":"ExecStop\u003d/usr/bin/sudo /sbin/dhclient -r {{ octavia_network_interface }}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"9f560f44_735d8414","line":9,"range":{"start_line":9,"start_character":88,"end_line":9,"end_character":120},"in_reply_to":"9f560f44_23d468e9","updated":"2020-09-15 14:36:13.000000000","message":"yes, it would have to match the MAC address of the neutron port.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"aa98333501e91d0f4100a845b393cd28a72a18d6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"Type\u003doneshot"},{"line_number":8,"context_line":"RemainAfterExit\u003dtrue"},{"line_number":9,"context_line":"ExecStartPre\u003d/usr/bin/sudo /sbin/ip link set dev {{ octavia_network_interface}} address {{ port_info.port.mac_address }}"},{"line_number":10,"context_line":"ExecStart\u003d/usr/bin/sudo /sbin/dhclient -v {{ octavia_network_interface }} -cf /etc/dhcp/octavia-dhclient.conf"},{"line_number":11,"context_line":"ExecStop\u003d/usr/bin/sudo /sbin/dhclient -r {{ octavia_network_interface }}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"9f560f44_23d468e9","line":9,"range":{"start_line":9,"start_character":88,"end_line":9,"end_character":120},"in_reply_to":"9f560f44_2ac28235","updated":"2020-09-15 13:52:09.000000000","message":"the mac_address must matches the neutron port mac, otherwise we can not get the DHCP ip. should we use a custom mac when create neutron port?","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"21d1ff116e2481368489abd92f56fe29bc28e91b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dOctavia Interface Creator"},{"line_number":3,"context_line":"Requires\u003ddocker.service"},{"line_number":4,"context_line":"After\u003ddocker.service"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[Service]"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"9f560f44_07e5cb3e","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":23},"updated":"2020-10-01 15:16:49.000000000","message":"What about adding a wait for an OVS managed network interface to be online?\nExecStartPre\u003d/usr/lib/systemd/systemd-networkd-wait-online --interface\u003dbr-int (or something similar)","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8f4c81a466ad1d36cd62274741374dec4880fbb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dOctavia Interface Creator"},{"line_number":3,"context_line":"Requires\u003ddocker.service"},{"line_number":4,"context_line":"After\u003ddocker.service"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[Service]"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"9f560f44_87cc3b63","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":23},"in_reply_to":"9f560f44_07e5cb3e","updated":"2020-10-01 15:37:33.000000000","message":"++","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2c40b3218135844add96ecbb4d4ed4956038ed9e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dOctavia Interface Creator"},{"line_number":3,"context_line":"Requires\u003ddocker.service"},{"line_number":4,"context_line":"After\u003ddocker.service"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[Service]"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"9f560f44_e22b65e7","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":23},"in_reply_to":"9f560f44_87cc3b63","updated":"2020-10-01 18:30:43.000000000","message":"Done","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8f4c81a466ad1d36cd62274741374dec4880fbb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dOctavia Interface Creator"},{"line_number":3,"context_line":"Requires\u003ddocker.service"},{"line_number":4,"context_line":"After\u003ddocker.service"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"Type\u003doneshot"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"9f560f44_67c92750","line":4,"updated":"2020-10-01 15:37:33.000000000","message":"ditto","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"144ad228d08acb895bc32dca2df1b70564ade43d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dOctavia Interface Creator"},{"line_number":3,"context_line":"Requires\u003ddocker.service"},{"line_number":4,"context_line":"After\u003ddocker.service"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"Type\u003doneshot"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"9f560f44_798edf26","line":4,"in_reply_to":"9f560f44_42317159","updated":"2020-10-02 09:33:54.000000000","message":"that was ditto for Requires\u003ddocker; same goes for After\u003ddocker","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2c40b3218135844add96ecbb4d4ed4956038ed9e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dOctavia Interface Creator"},{"line_number":3,"context_line":"Requires\u003ddocker.service"},{"line_number":4,"context_line":"After\u003ddocker.service"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"Type\u003doneshot"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"9f560f44_42317159","line":4,"in_reply_to":"9f560f44_67c92750","updated":"2020-10-01 18:30:43.000000000","message":"?","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8f4c81a466ad1d36cd62274741374dec4880fbb","unresolved":false,"context_lines":[{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"Type\u003doneshot"},{"line_number":8,"context_line":"RemainAfterExit\u003dtrue"},{"line_number":9,"context_line":"ExecStartPre\u003d/usr/bin/sudo /sbin/ip link set dev {{ octavia_network_interface}} address {{ port_info.port.mac_address }}"},{"line_number":10,"context_line":"ExecStart\u003d/usr/bin/sudo /sbin/dhclient -v {{ octavia_network_interface }} -cf /etc/dhcp/octavia-dhclient.conf"},{"line_number":11,"context_line":"ExecStop\u003d/usr/bin/sudo /sbin/dhclient -r {{ octavia_network_interface }}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"9f560f44_0702eb72","line":9,"range":{"start_line":9,"start_character":76,"end_line":9,"end_character":78},"updated":"2020-10-01 15:37:33.000000000","message":"nit: lack of space","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8f4c81a466ad1d36cd62274741374dec4880fbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"9f560f44_87239b06","line":16,"updated":"2020-10-01 15:37:33.000000000","message":"nit: extra line","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"}],"ansible/roles/octavia/templates/octavia.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d69ebea93e63a7c5a444d09f769c720f9a6fbe4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"stats_update_threads \u003d {{ openstack_service_workers }}"},{"line_number":66,"context_line":"health_update_threads \u003d {{ openstack_service_workers }}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[controller_worker]"},{"line_number":69,"context_line":"{% if not auto_configure_octavia  %}"},{"line_number":70,"context_line":"amp_boot_network_list \u003d {{ octavia_amp_boot_network_list }}"},{"line_number":71,"context_line":"amp_image_tag \u003d amphora"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"bf51134e_bcf20299","line":68,"updated":"2020-07-23 13:32:01.000000000","message":"no need to repeat amp_ssh_key_name and amp_image_tag","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b6bb9e62d5743e32cb9880662a3f6e18e542ebd4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"stats_update_threads \u003d {{ openstack_service_workers }}"},{"line_number":66,"context_line":"health_update_threads \u003d {{ openstack_service_workers }}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[controller_worker]"},{"line_number":69,"context_line":"{% if not auto_configure_octavia  %}"},{"line_number":70,"context_line":"amp_boot_network_list \u003d {{ octavia_amp_boot_network_list }}"},{"line_number":71,"context_line":"amp_image_tag \u003d amphora"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"bf51134e_4b8790b7","line":68,"in_reply_to":"bf51134e_bcf20299","updated":"2020-07-24 08:53:53.000000000","message":"ok","commit_id":"b3e1f7937ac18212f05d2401ddc8dc62c5661448"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f0f2c44e734e88b624c9ead405ec04cff24d7674","unresolved":false,"context_lines":[{"line_number":65,"context_line":"stats_update_threads \u003d {{ openstack_service_workers }}"},{"line_number":66,"context_line":"health_update_threads \u003d {{ openstack_service_workers }}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[controller_worker]"},{"line_number":69,"context_line":"{% if not octavia_auto_configure | bool %}"},{"line_number":70,"context_line":"amp_boot_network_list \u003d {{ octavia_amp_boot_network_list }}"},{"line_number":71,"context_line":"amp_secgroup_list \u003d {{ octavia_amp_secgroup_list }}"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"9f560f44_d9bd3869","line":68,"updated":"2020-08-19 22:52:42.000000000","message":"For security we highly recommend setting the \"amp_image_owner_id\" setting to the image owner ID.\nThis is typically the octavia project ID.\n\nThis way no one can create a public image with the amphora tag and inject a bad image.","commit_id":"d6b37896bd30328afb00b281fb2a05283909a372"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"86a364786594d9eccef9fa9fd70ad9d1fc0ab276","unresolved":false,"context_lines":[{"line_number":65,"context_line":"stats_update_threads \u003d {{ openstack_service_workers }}"},{"line_number":66,"context_line":"health_update_threads \u003d {{ openstack_service_workers }}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[controller_worker]"},{"line_number":69,"context_line":"{% if not octavia_auto_configure | bool %}"},{"line_number":70,"context_line":"amp_boot_network_list \u003d {{ octavia_amp_boot_network_list }}"},{"line_number":71,"context_line":"amp_secgroup_list \u003d {{ octavia_amp_secgroup_list }}"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"9f560f44_87c356ed","line":68,"in_reply_to":"9f560f44_d9bd3869","updated":"2020-08-20 09:26:30.000000000","message":"nice suggestion,  will add it soon.","commit_id":"d6b37896bd30328afb00b281fb2a05283909a372"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"099e4d60c1b294b0650bdb5b56f965fbc2d7a313","unresolved":false,"context_lines":[{"line_number":73,"context_line":"amp_flavor_id \u003d {{ octavia_amp_flavor_id }}"},{"line_number":74,"context_line":"{% else %}"},{"line_number":75,"context_line":"{% if octavia_network_type \u003d\u003d \u0027tenant\u0027 %}"},{"line_number":76,"context_line":"amp_boot_network_list \u003d {{ network_tenant_info.id }}"},{"line_number":77,"context_line":"{% else %}"},{"line_number":78,"context_line":"amp_boot_network_list \u003d {{ network_provider_info.id }}"},{"line_number":79,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"9f560f44_ca37864b","line":76,"range":{"start_line":76,"start_character":27,"end_line":76,"end_character":49},"updated":"2020-09-14 16:43:55.000000000","message":"This will be a problem for the kolla-ansible genconfig command, which only runs config.yml.\n\nWhat if prepare.yml used set_fact to set octavia_amp_secgroup_list etc based on the registered resources? Then we would have one set of logic here, and a user wanting to run genconfig could set those variables in their globals.yml.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"aa98333501e91d0f4100a845b393cd28a72a18d6","unresolved":false,"context_lines":[{"line_number":73,"context_line":"amp_flavor_id \u003d {{ octavia_amp_flavor_id }}"},{"line_number":74,"context_line":"{% else %}"},{"line_number":75,"context_line":"{% if octavia_network_type \u003d\u003d \u0027tenant\u0027 %}"},{"line_number":76,"context_line":"amp_boot_network_list \u003d {{ network_tenant_info.id }}"},{"line_number":77,"context_line":"{% else %}"},{"line_number":78,"context_line":"amp_boot_network_list \u003d {{ network_provider_info.id }}"},{"line_number":79,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"9f560f44_412fcf87","line":76,"range":{"start_line":76,"start_character":27,"end_line":76,"end_character":49},"in_reply_to":"9f560f44_ca37864b","updated":"2020-09-15 13:52:09.000000000","message":"i think use octavia_amp_boot_network_list if network_tenant_info not define is better, octavia_amp_boot_network_list not used now, we can reuse this value. i will consider a better way.","commit_id":"177935afc7719c3afc1e435f3d06dda245a93256"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8f4c81a466ad1d36cd62274741374dec4880fbb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"health_update_threads \u003d {{ openstack_service_workers }}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"[controller_worker]"},{"line_number":72,"context_line":"{% if not octavia_auto_configure | bool or kolla_action \u003d\u003d \u0027config\u0027 %}"},{"line_number":73,"context_line":"amp_boot_network_list \u003d {{ octavia_amp_boot_network_list }}"},{"line_number":74,"context_line":"amp_secgroup_list \u003d {{ octavia_amp_secgroup_list }}"},{"line_number":75,"context_line":"amp_flavor_id \u003d {{ octavia_amp_flavor_id }}"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"9f560f44_e7dd3714","line":72,"range":{"start_line":72,"start_character":43,"end_line":72,"end_character":67},"updated":"2020-10-01 15:37:33.000000000","message":"! IMPORTANT !\nthis violates the assumption that action\u003dconfig generates the exact same config - we are relying on that","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dec8bba08a2fb8a60f230b610129acd7da1fe124","unresolved":false,"context_lines":[{"line_number":69,"context_line":"health_update_threads \u003d {{ openstack_service_workers }}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"[controller_worker]"},{"line_number":72,"context_line":"{% if not octavia_auto_configure | bool or kolla_action \u003d\u003d \u0027config\u0027 %}"},{"line_number":73,"context_line":"amp_boot_network_list \u003d {{ octavia_amp_boot_network_list }}"},{"line_number":74,"context_line":"amp_secgroup_list \u003d {{ octavia_amp_secgroup_list }}"},{"line_number":75,"context_line":"amp_flavor_id \u003d {{ octavia_amp_flavor_id }}"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"9f560f44_c250e1d8","line":72,"range":{"start_line":72,"start_character":43,"end_line":72,"end_character":67},"in_reply_to":"9f560f44_8720bbb3","updated":"2020-10-01 16:01:33.000000000","message":"OK, then it would make sense not to do this in the template but rather do external control of their values. Possibly recommend to switch auto_configure off once initial deployment is done. Maybe k-a should save these values in a file on the deployment host? And then be able to source them freely.","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1951048721e28b6b6809aa846315cf62813d07ec","unresolved":false,"context_lines":[{"line_number":69,"context_line":"health_update_threads \u003d {{ openstack_service_workers }}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"[controller_worker]"},{"line_number":72,"context_line":"{% if not octavia_auto_configure | bool or kolla_action \u003d\u003d \u0027config\u0027 %}"},{"line_number":73,"context_line":"amp_boot_network_list \u003d {{ octavia_amp_boot_network_list }}"},{"line_number":74,"context_line":"amp_secgroup_list \u003d {{ octavia_amp_secgroup_list }}"},{"line_number":75,"context_line":"amp_flavor_id \u003d {{ octavia_amp_flavor_id }}"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"9f560f44_8720bbb3","line":72,"range":{"start_line":72,"start_character":43,"end_line":72,"end_character":67},"in_reply_to":"9f560f44_e7dd3714","updated":"2020-10-01 15:46:31.000000000","message":"Given that we want genconfig to work offline one day, it doesn\u0027t make sense to query resource IDs. So the idea is that for genconfig you need to populate octavia_amp_boot_network_list etc. These may have been generated via a previous kolla deploy.","commit_id":"02e551cb44fb8ef221d20ef220bd659d81658b8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c21e09fc09a77d151f1df53379f8b91b22bdc249","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"[controller_worker]"},{"line_number":72,"context_line":"{% if not octavia_auto_configure | bool %}"},{"line_number":73,"context_line":"amp_boot_network_list \u003d {{ octavia_amp_boot_network_list }}"},{"line_number":74,"context_line":"amp_secgroup_list \u003d {{ octavia_amp_secgroup_list }}"},{"line_number":75,"context_line":"amp_flavor_id \u003d {{ octavia_amp_flavor_id }}"},{"line_number":76,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":46,"id":"9f560f44_c808f628","line":73,"updated":"2020-10-02 10:28:46.000000000","message":"ok, so we lack a way to pass amp_image_owner_id after autoconf (except for config override which sounds messy for autogen purposes)","commit_id":"8a505ae0238ffbaac30bdb881d5fb487cfab0390"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c21e09fc09a77d151f1df53379f8b91b22bdc249","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"[controller_worker]"},{"line_number":72,"context_line":"{% if not octavia_auto_configure | bool %}"},{"line_number":73,"context_line":"amp_boot_network_list \u003d {{ octavia_amp_boot_network_list }}"},{"line_number":74,"context_line":"amp_secgroup_list \u003d {{ octavia_amp_secgroup_list }}"},{"line_number":75,"context_line":"amp_flavor_id \u003d {{ octavia_amp_flavor_id }}"},{"line_number":76,"context_line":"{% else %}"},{"line_number":77,"context_line":"amp_boot_network_list \u003d {{ network_info.id }}"},{"line_number":78,"context_line":"amp_image_owner_id \u003d {{ project_info.openstack_projects.0.id }}"}],"source_content_type":"text/x-jinja2","patch_set":46,"id":"9f560f44_283d32bc","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":43},"updated":"2020-10-02 10:28:46.000000000","message":"and need to mention all these will be ignored except for no-autoconf mode","commit_id":"8a505ae0238ffbaac30bdb881d5fb487cfab0390"}],"etc/kolla/globals.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"58819c6fbbcb62304663f38ed0290febe75699bf","unresolved":false,"context_lines":[{"line_number":676,"context_line":"# https://docs.openstack.org/octavia/latest/admin/guides/certificates.html"},{"line_number":677,"context_line":"#octavia_certs_generate: \"no\""},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"# octavia network type options are [ internal, external ]"},{"line_number":680,"context_line":"# internal indicates that we will create a tenant network and get through the communication"},{"line_number":681,"context_line":"# between octavia-worker nodes and amphoras."},{"line_number":682,"context_line":"# external indicates that we will create a flat or vlan provider network. if use external network,"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_12cb7053","line":679,"range":{"start_line":679,"start_character":37,"end_line":679,"end_character":55},"updated":"2020-07-27 10:44:07.000000000","message":"maybe it should be tenant vs. provider?","commit_id":"abc2f836cc751fbf8c782f3c6a4d6830437e9925"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fdb923a8375791090dc3661c89508fbd524fafea","unresolved":false,"context_lines":[{"line_number":676,"context_line":"# https://docs.openstack.org/octavia/latest/admin/guides/certificates.html"},{"line_number":677,"context_line":"#octavia_certs_generate: \"no\""},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"# octavia network type options are [ internal, external ]"},{"line_number":680,"context_line":"# internal indicates that we will create a tenant network and get through the communication"},{"line_number":681,"context_line":"# between octavia-worker nodes and amphoras."},{"line_number":682,"context_line":"# external indicates that we will create a flat or vlan provider network. if use external network,"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_b8b1c3e4","line":679,"range":{"start_line":679,"start_character":37,"end_line":679,"end_character":55},"in_reply_to":"9f560f44_12cb7053","updated":"2020-07-27 11:34:02.000000000","message":"no problem.  i will do it soon","commit_id":"abc2f836cc751fbf8c782f3c6a4d6830437e9925"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"534797a1237f1ed2e7266ee538125020051510cf","unresolved":false,"context_lines":[{"line_number":676,"context_line":"# https://docs.openstack.org/octavia/latest/admin/guides/certificates.html"},{"line_number":677,"context_line":"#octavia_certs_generate: \"no\""},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"# octavia network type options are [ internal, external ]"},{"line_number":680,"context_line":"# internal indicates that we will create a tenant network and get through the communication"},{"line_number":681,"context_line":"# between octavia-worker nodes and amphoras."},{"line_number":682,"context_line":"# external indicates that we will create a flat or vlan provider network. if use external network,"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_e33c30c1","line":679,"range":{"start_line":679,"start_character":37,"end_line":679,"end_character":55},"in_reply_to":"9f560f44_38fdb33a","updated":"2020-07-27 11:54:54.000000000","message":"It\u0027s not just interfaces and ports, subnet_network cidr and gateway  are  also important for vlan or flat provider network. so i think keep use of tenanut and provider is better. but more clear information we can write it into octavia docs.","commit_id":"abc2f836cc751fbf8c782f3c6a4d6830437e9925"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ffab3f6b318121fd8b7c61858d3fdc85e71f965b","unresolved":false,"context_lines":[{"line_number":676,"context_line":"# https://docs.openstack.org/octavia/latest/admin/guides/certificates.html"},{"line_number":677,"context_line":"#octavia_certs_generate: \"no\""},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"# octavia network type options are [ internal, external ]"},{"line_number":680,"context_line":"# internal indicates that we will create a tenant network and get through the communication"},{"line_number":681,"context_line":"# between octavia-worker nodes and amphoras."},{"line_number":682,"context_line":"# external indicates that we will create a flat or vlan provider network. if use external network,"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_38fdb33a","line":679,"range":{"start_line":679,"start_character":37,"end_line":679,"end_character":55},"in_reply_to":"9f560f44_b8b1c3e4","updated":"2020-07-27 11:39:14.000000000","message":"or we could be more clear about what it actually controls - whether to create an interface and neutron port for health manager.","commit_id":"abc2f836cc751fbf8c782f3c6a4d6830437e9925"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"58819c6fbbcb62304663f38ed0290febe75699bf","unresolved":false,"context_lines":[{"line_number":687,"context_line":"# your external network device."},{"line_number":688,"context_line":"octavia_vlan_provider_network:"},{"line_number":689,"context_line":"  name: lb-mgmt-network"},{"line_number":690,"context_line":"  provider_network_type:"},{"line_number":691,"context_line":"  provider_physical_network:"},{"line_number":692,"context_line":"  provider_segmentation_id:"},{"line_number":693,"context_line":"  shared: no"},{"line_number":694,"context_line":"  subnet:"},{"line_number":695,"context_line":"    name: lb-mgmt-subnet"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_52acc88b","line":692,"range":{"start_line":690,"start_character":0,"end_line":692,"end_character":27},"updated":"2020-07-27 10:44:07.000000000","message":"I don\u0027t see these supported","commit_id":"abc2f836cc751fbf8c782f3c6a4d6830437e9925"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fdb923a8375791090dc3661c89508fbd524fafea","unresolved":false,"context_lines":[{"line_number":687,"context_line":"# your external network device."},{"line_number":688,"context_line":"octavia_vlan_provider_network:"},{"line_number":689,"context_line":"  name: lb-mgmt-network"},{"line_number":690,"context_line":"  provider_network_type:"},{"line_number":691,"context_line":"  provider_physical_network:"},{"line_number":692,"context_line":"  provider_segmentation_id:"},{"line_number":693,"context_line":"  shared: no"},{"line_number":694,"context_line":"  subnet:"},{"line_number":695,"context_line":"    name: lb-mgmt-subnet"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_b898a36a","line":692,"range":{"start_line":690,"start_character":0,"end_line":692,"end_character":27},"in_reply_to":"9f560f44_52acc88b","updated":"2020-07-27 11:34:02.000000000","message":"yeah， i have not done this , i just save it to gerrit, so i can get the code from my other compute","commit_id":"abc2f836cc751fbf8c782f3c6a4d6830437e9925"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b5272e7226b581a9f3c75be9e26e87ff3766b4a3","unresolved":false,"context_lines":[{"line_number":666,"context_line":"# and configure octavia like before."},{"line_number":667,"context_line":"#octavia_auto_configure: yes"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"# octavia network type options are [ tenant, provider ]"},{"line_number":670,"context_line":"# tenant indicates that we will create a tenant network and get through the communication"},{"line_number":671,"context_line":"# between octavia-worker nodes and amphoras."},{"line_number":672,"context_line":"# provider indicates that we will create a flat or vlan provider network. if use provider network,"},{"line_number":673,"context_line":"# you may need set octavia_network_interface to a proper network interface."},{"line_number":674,"context_line":"#octavia_network_type: \"tenant\""},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"# this only works when octavia network type is provider, please ensure the subnet is matching"},{"line_number":677,"context_line":"# your external network device."},{"line_number":678,"context_line":"#octavia_provider_network:"},{"line_number":679,"context_line":"#  name: lb-provider-net"},{"line_number":680,"context_line":"#  provider_network_type:"},{"line_number":681,"context_line":"#  provider_physical_network: physnet1"},{"line_number":682,"context_line":"#  provider_segmentation_id:"},{"line_number":683,"context_line":"#  external: yes"},{"line_number":684,"context_line":"#  shared: no"},{"line_number":685,"context_line":"#  subnet:"},{"line_number":686,"context_line":"#    name: lb-provider-subnet"},{"line_number":687,"context_line":"#    cidr: 10.0.0.0/8"},{"line_number":688,"context_line":"#    no_gateway_ip: no"},{"line_number":689,"context_line":"#    gateway_ip: 10.0.0.1"},{"line_number":690,"context_line":"#    allocation_pool_start: 10.0.0.2"},{"line_number":691,"context_line":"#    allocation_pool_end: 10.255.255.254"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"#octavia_amphora_flavor:"},{"line_number":694,"context_line":"#  flavorid:"},{"line_number":695,"context_line":"#  is_public: no"},{"line_number":696,"context_line":"#  name: \"amphora\""},{"line_number":697,"context_line":"#  vcpus: 1"},{"line_number":698,"context_line":"#  ram: 1024"},{"line_number":699,"context_line":"#  disk: 5"},{"line_number":700,"context_line":"#  ephemeral:"},{"line_number":701,"context_line":"#  swap:"},{"line_number":702,"context_line":"#octavia_amp_image_tag: \"amphora\""},{"line_number":703,"context_line":"# Load balancer topology options are [ SINGLE, ACTIVE_STANDBY ]"},{"line_number":704,"context_line":"#octavia_loadbalancer_topology: \"SINGLE\""}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f560f44_bf70690a","line":701,"range":{"start_line":669,"start_character":0,"end_line":701,"end_character":8},"updated":"2020-09-16 14:33:57.000000000","message":"i prefer to remove them to docs. and add docs link to here.","commit_id":"12521f9350662ccb2b06ccf23e79394d451c5568"}]}