)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2f7a344f31e1b8b27713232ff0e5dfda40496fb2","unresolved":false,"context_lines":[{"line_number":193,"context_line":"####################"},{"line_number":194,"context_line":"network_interface: \"eth0\""},{"line_number":195,"context_line":"neutron_external_interface: \"eth1\""},{"line_number":196,"context_line":"neutron_mlnx_physnet_mappings:"},{"line_number":197,"context_line":"  ib0: \"ibphysnet\""},{"line_number":198,"context_line":"kolla_external_vip_interface: \"{{ network_interface }}\""},{"line_number":199,"context_line":"api_interface: \"{{ network_interface }}\""},{"line_number":200,"context_line":"storage_interface: \"{{ network_interface }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_11915a47","line":197,"range":{"start_line":196,"start_character":0,"end_line":197,"end_character":18},"updated":"2020-07-23 10:14:54.000000000","message":"This can go in the neutron role defaults.","commit_id":"ede6b2548f5748cf5a834604408448b710da4856"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"2c8488e479dc439f9384d08a6b58c4cd951b9eca","unresolved":false,"context_lines":[{"line_number":193,"context_line":"####################"},{"line_number":194,"context_line":"network_interface: \"eth0\""},{"line_number":195,"context_line":"neutron_external_interface: \"eth1\""},{"line_number":196,"context_line":"neutron_mlnx_physnet_mappings:"},{"line_number":197,"context_line":"  ib0: \"ibphysnet\""},{"line_number":198,"context_line":"kolla_external_vip_interface: \"{{ network_interface }}\""},{"line_number":199,"context_line":"api_interface: \"{{ network_interface }}\""},{"line_number":200,"context_line":"storage_interface: \"{{ network_interface }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_e62ceb02","line":197,"range":{"start_line":196,"start_character":0,"end_line":197,"end_character":18},"in_reply_to":"bf51134e_11915a47","updated":"2020-07-23 11:30:01.000000000","message":"Done","commit_id":"ede6b2548f5748cf5a834604408448b710da4856"}],"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2f7a344f31e1b8b27713232ff0e5dfda40496fb2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  neutron-mlnx-agent:"},{"line_number":101,"context_line":"    container_name: \"neutron_mlnx_agent\""},{"line_number":102,"context_line":"    image: \"{{ neutron_mlnx_agent_image_full }}\""},{"line_number":103,"context_line":"    privileged: True"},{"line_number":104,"context_line":"    enabled: \"{{ enable_neutron_mlnx | bool and neutron_plugin_agent not in [\u0027vmware_nsxv\u0027, \u0027vmware_nsxv3\u0027 ] }}\""},{"line_number":105,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027compute\u0027] }}\""},{"line_number":106,"context_line":"    volumes: \"{{ neutron_mlnx_agent_default_volumes + neutron_mlnx_agent_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_91ca8a43","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":14},"updated":"2020-07-23 10:14:54.000000000","message":"Do they both need to be privileged?","commit_id":"ede6b2548f5748cf5a834604408448b710da4856"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"2c8488e479dc439f9384d08a6b58c4cd951b9eca","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  neutron-mlnx-agent:"},{"line_number":101,"context_line":"    container_name: \"neutron_mlnx_agent\""},{"line_number":102,"context_line":"    image: \"{{ neutron_mlnx_agent_image_full }}\""},{"line_number":103,"context_line":"    privileged: True"},{"line_number":104,"context_line":"    enabled: \"{{ enable_neutron_mlnx | bool and neutron_plugin_agent not in [\u0027vmware_nsxv\u0027, \u0027vmware_nsxv3\u0027 ] }}\""},{"line_number":105,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027compute\u0027] }}\""},{"line_number":106,"context_line":"    volumes: \"{{ neutron_mlnx_agent_default_volumes + neutron_mlnx_agent_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_6638db3a","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":14},"in_reply_to":"bf51134e_91ca8a43","updated":"2020-07-23 11:30:01.000000000","message":"Only eswitchd does it turns out","commit_id":"ede6b2548f5748cf5a834604408448b710da4856"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"892a52068accf393700b348253c188df8deedbf2","unresolved":false,"context_lines":[{"line_number":199,"context_line":"neutron_mlnx_agent_tag: \"{{ neutron_tag }}\""},{"line_number":200,"context_line":"neutron_mlnx_agent_image_full: \"{{ neutron_mlnx_agent_image }}:{{ neutron_mlnx_agent_tag }}\""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"neutron_eswitchd_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ neutron_install_type }}-neutron-mlnx-agent\""},{"line_number":203,"context_line":"neutron_eswitchd_tag: \"{{ neutron_mlnx_agent_tag }}\""},{"line_number":204,"context_line":"neutron_eswitchd_image_full: \"{{ neutron_eswitchd_image }}:{{ neutron_eswitchd_tag }}\""},{"line_number":205,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_7c6d2897","line":202,"range":{"start_line":202,"start_character":25,"end_line":202,"end_character":171},"updated":"2020-08-17 17:51:17.000000000","message":"should really just be neutron_mlnx_agent_image","commit_id":"4809462f4e4306d76888f36f48005dd416b75d4d"}],"ansible/roles/neutron/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2f7a344f31e1b8b27713232ff0e5dfda40496fb2","unresolved":false,"context_lines":[{"line_number":184,"context_line":"  notify:"},{"line_number":185,"context_line":"    - \"Restart {{ service_name }} container\""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"- name: Copying over sriov_agent.ini"},{"line_number":188,"context_line":"  vars:"},{"line_number":189,"context_line":"    service_name: \"neutron-sriov-agent\""},{"line_number":190,"context_line":"    neutron_sriov_agent: \"{{ neutron_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_312a9ee6","line":187,"updated":"2020-07-23 10:14:54.000000000","message":"needs become: true","commit_id":"ede6b2548f5748cf5a834604408448b710da4856"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2f7a344f31e1b8b27713232ff0e5dfda40496fb2","unresolved":false,"context_lines":[{"line_number":201,"context_line":"  notify:"},{"line_number":202,"context_line":"    - \"Restart {{ service_name }} container\""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"- name: Copying over mlnx_agent.ini"},{"line_number":205,"context_line":"  vars:"},{"line_number":206,"context_line":"    service_name: \"neutron-mlnx-agent\""},{"line_number":207,"context_line":"    neutron_mlnx_agent: \"{{ neutron_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_f1f2e699","line":204,"updated":"2020-07-23 10:14:54.000000000","message":"needs become: true","commit_id":"ede6b2548f5748cf5a834604408448b710da4856"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"2c8488e479dc439f9384d08a6b58c4cd951b9eca","unresolved":false,"context_lines":[{"line_number":201,"context_line":"  notify:"},{"line_number":202,"context_line":"    - \"Restart {{ service_name }} container\""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"- name: Copying over mlnx_agent.ini"},{"line_number":205,"context_line":"  vars:"},{"line_number":206,"context_line":"    service_name: \"neutron-mlnx-agent\""},{"line_number":207,"context_line":"    neutron_mlnx_agent: \"{{ neutron_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_e6f18b6c","line":204,"in_reply_to":"bf51134e_f1f2e699","updated":"2020-07-23 11:30:01.000000000","message":"Done","commit_id":"ede6b2548f5748cf5a834604408448b710da4856"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2f7a344f31e1b8b27713232ff0e5dfda40496fb2","unresolved":false,"context_lines":[{"line_number":218,"context_line":"  notify:"},{"line_number":219,"context_line":"    - \"Restart {{ service_name }} container\""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"- name: Copying over eswitchd.conf"},{"line_number":222,"context_line":"  vars:"},{"line_number":223,"context_line":"    service_name: \"neutron-eswitchd\""},{"line_number":224,"context_line":"    neutron_eswitchd: \"{{ neutron_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_d1ed22b8","line":221,"updated":"2020-07-23 10:14:54.000000000","message":"ditto","commit_id":"ede6b2548f5748cf5a834604408448b710da4856"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"2c8488e479dc439f9384d08a6b58c4cd951b9eca","unresolved":false,"context_lines":[{"line_number":218,"context_line":"  notify:"},{"line_number":219,"context_line":"    - \"Restart {{ service_name }} container\""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"- name: Copying over eswitchd.conf"},{"line_number":222,"context_line":"  vars:"},{"line_number":223,"context_line":"    service_name: \"neutron-eswitchd\""},{"line_number":224,"context_line":"    neutron_eswitchd: \"{{ neutron_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_86024f3d","line":221,"in_reply_to":"bf51134e_d1ed22b8","updated":"2020-07-23 11:30:01.000000000","message":"Done","commit_id":"ede6b2548f5748cf5a834604408448b710da4856"}],"ansible/roles/nova-cell/templates/libvirtd.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2f7a344f31e1b8b27713232ff0e5dfda40496fb2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"listen_addr \u003d \"{{ migration_interface_address }}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Allow read-only access to libvirt socket"},{"line_number":25,"context_line":"unix_sock_ro_perms \u003d \"0777\""},{"line_number":26,"context_line":"auth_unix_ro \u003d \"none\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf51134e_b16b4e1d","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":21},"updated":"2020-07-23 10:14:54.000000000","message":"These do appear to be the default: https://libvirt.org/remote.html","commit_id":"ede6b2548f5748cf5a834604408448b710da4856"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"2c8488e479dc439f9384d08a6b58c4cd951b9eca","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"listen_addr \u003d \"{{ migration_interface_address }}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Allow read-only access to libvirt socket"},{"line_number":25,"context_line":"unix_sock_ro_perms \u003d \"0777\""},{"line_number":26,"context_line":"auth_unix_ro \u003d \"none\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf51134e_a6f79359","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":21},"in_reply_to":"bf51134e_b16b4e1d","updated":"2020-07-23 11:30:01.000000000","message":"unix_sock_ro_perms defaults to \"0777\" but looks like auth_unix_ro \u003d \"none\" is required to activate read only socket.","commit_id":"ede6b2548f5748cf5a834604408448b710da4856"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"86a8f974e7f5ab0079850190b929375f54cdee5c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"listen_addr \u003d \"{{ migration_interface_address }}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Enable read-only access to libvirt socket"},{"line_number":25,"context_line":"auth_unix_ro \u003d \"none\""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9f560f44_1e1ed7b9","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":21},"updated":"2020-07-27 13:19:48.000000000","message":"I don\u0027t know if opening something like this, is a wise approach - at least doing it everytime. Especially that we are bind-mounting /run from the host level, and any OS user can have read-only access to Libvirtd socket without any authentication mechanism?","commit_id":"d2bd76baf64c2f6ec1111363c0ea41cd60890151"}],"releasenotes/notes/neutron-mlnx-agent-3e7b3aecbb298811.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"db54c54083bd0f3c2edb7bc7d33b76069dba5ca8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Kolla started building neutron-mlnx-agent in Ussuri cycle. Now those"},{"line_number":5,"context_line":"    containers can be deployed too via Kolla-Ansible. Note than"},{"line_number":6,"context_line":"    neutron-mlnx-agent image is also used to deploy neutron-eswitchd container."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_0ccb5953","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":63},"updated":"2020-07-27 08:53:05.000000000","message":"that","commit_id":"7d9a1b126b8f85584e6cf503b41ccb70fcbea955"}]}