)]}'
{"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c10b304dd7447884948111c0917f23c64f83aba2","unresolved":false,"context_lines":[{"line_number":370,"context_line":"  - name: \"ovn\""},{"line_number":371,"context_line":"    enabled: \"{{ neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":372,"context_line":"  - name: \"sriovnicswitch\""},{"line_number":373,"context_line":"    enabled: \"{{ enable_neutron_sriov | bool }}\""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"neutron_mechanism_drivers: \"{{ mechanism_drivers | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":376,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf51134e_268543d0","line":373,"updated":"2020-07-23 11:24:18.000000000","message":"Could you update the docs to reflect that you no longer need to set the mechanism drivers?","commit_id":"2db4602adabc0857f27dde3834656064f42bfe84"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c10b304dd7447884948111c0917f23c64f83aba2","unresolved":false,"context_lines":[{"line_number":505,"context_line":"infoblox_admin_user_name: \"admin\""},{"line_number":506,"context_line":"infoblox_wapi_version: \"2.3\""},{"line_number":507,"context_line":"infoblox_wapi_max_results: \"-50000\""},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"######################"},{"line_number":510,"context_line":"# Notification Drivers"},{"line_number":511,"context_line":"######################"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf51134e_460dd78e","line":508,"updated":"2020-07-23 11:24:18.000000000","message":"Probably needs to go here in a new section","commit_id":"2db4602adabc0857f27dde3834656064f42bfe84"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b0afacd34cb6232fb1ab1e362c907e3c346ed644","unresolved":false,"context_lines":[{"line_number":540,"context_line":"####################"},{"line_number":541,"context_line":"# SRIOV"},{"line_number":542,"context_line":"####################"},{"line_number":543,"context_line":"neutron_sriov_physnets: \"{{ neutron_sriov_physnet_mappings.items() | map(\u0027join\u0027, \u0027:\u0027) | join(\u0027,\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9f560f44_78ade6e7","line":543,"range":{"start_line":543,"start_character":14,"end_line":543,"end_character":22},"updated":"2020-08-04 08:58:33.000000000","message":"nit: they\u0027re physical device mappings, not physnets","commit_id":"fdab1b75848e8e6d5167626cab234569faf1742a"}],"ansible/roles/neutron/templates/linuxbridge_agent.ini.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e115b7852617d33dfd68efcf8873cbcd038c4133","unresolved":false,"context_lines":[{"line_number":17,"context_line":"[FDB]"},{"line_number":18,"context_line":"# Allows instances using sriov ports to communicate with instances that do not."},{"line_number":19,"context_line":"# See https://docs.openstack.org/neutron/latest/admin/config-sriov.html"},{"line_number":20,"context_line":"shared_physical_device_mappings \u003d {{  neutron_sriov_physnets }}"},{"line_number":21,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"9f560f44_b1d450bd","line":20,"range":{"start_line":20,"start_character":37,"end_line":20,"end_character":38},"updated":"2020-08-28 09:30:03.000000000","message":"nit: space","commit_id":"dceb1ba0665e5cbb84cd8d795e23b852cd50e245"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"0f56e0b358699ce5eb9196115a752c80b84684ed","unresolved":false,"context_lines":[{"line_number":17,"context_line":"[FDB]"},{"line_number":18,"context_line":"# Allows instances using sriov ports to communicate with instances that do not."},{"line_number":19,"context_line":"# See https://docs.openstack.org/neutron/latest/admin/config-sriov.html"},{"line_number":20,"context_line":"shared_physical_device_mappings \u003d {{  neutron_sriov_physnets }}"},{"line_number":21,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"9f560f44_8cb5b381","line":20,"range":{"start_line":20,"start_character":37,"end_line":20,"end_character":38},"in_reply_to":"9f560f44_b1d450bd","updated":"2020-08-28 10:46:59.000000000","message":"Done","commit_id":"dceb1ba0665e5cbb84cd8d795e23b852cd50e245"}],"ansible/roles/neutron/templates/ml2_conf.ini.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c10b304dd7447884948111c0917f23c64f83aba2","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{% if enable_neutron_sriov | bool %}"},{"line_number":46,"context_line":"[agent]"},{"line_number":47,"context_line":"# fbd allows instances not using sriov ports to communicate with instances that do,"},{"line_number":48,"context_line":"# see: https://docs.openstack.org/neutron/latest/admin/config-sriov.html"},{"line_number":49,"context_line":"extensions \u003d fdb"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bf51134e_6621fbfc","line":47,"range":{"start_line":47,"start_character":2,"end_line":47,"end_character":5},"updated":"2020-07-23 11:24:18.000000000","message":"fdb","commit_id":"2db4602adabc0857f27dde3834656064f42bfe84"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c5b6cb0edb113f4df2cca7f3adc558e8e69de829","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# https://docs.openstack.org/neutron/latest/admin/config-sriov.html"},{"line_number":50,"context_line":"extensions \u003d fdb"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[FDB]"},{"line_number":53,"context_line":"shared_physical_device_mappings \u003d {% for physnet, dev in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{{ physnet }}:{{ dev }}{% endfor %}"},{"line_number":54,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"bf51134e_ee6e72fe","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":172},"updated":"2020-07-24 09:43:25.000000000","message":"ml2_conf is installed in for neutron-server\u0027s ml2 plugin and neutron-server might not run on a host that has the mappings; moreover, these could be different per host so a centralized mapping with dev names does not make sense","commit_id":"cc3d44cff521dc693be63d6274e909ee146a0680"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2785339f6ae14dc7ecab9a96b14c16477fdea435","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# https://docs.openstack.org/neutron/latest/admin/config-sriov.html"},{"line_number":50,"context_line":"extensions \u003d fdb"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[FDB]"},{"line_number":53,"context_line":"shared_physical_device_mappings \u003d {% for physnet, dev in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{{ physnet }}:{{ dev }}{% endfor %}"},{"line_number":54,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"bf51134e_49495830","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":172},"in_reply_to":"bf51134e_09a48007","updated":"2020-07-24 10:01:52.000000000","message":"As a matter of fact, we have separate agent configs! :D ml2_conf is no longer consumed by agents to avoid the confusion.","commit_id":"cc3d44cff521dc693be63d6274e909ee146a0680"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"dfd742817e3a46e1e2de4af58a96fe62bd54e253","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# https://docs.openstack.org/neutron/latest/admin/config-sriov.html"},{"line_number":50,"context_line":"extensions \u003d fdb"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[FDB]"},{"line_number":53,"context_line":"shared_physical_device_mappings \u003d {% for physnet, dev in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{{ physnet }}:{{ dev }}{% endfor %}"},{"line_number":54,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"bf51134e_497cb81f","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":172},"in_reply_to":"bf51134e_49495830","updated":"2020-07-24 10:21:07.000000000","message":"Cool, I will move the config over then.","commit_id":"cc3d44cff521dc693be63d6274e909ee146a0680"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"87875d666dbef8430d7de9f10d9cd1d549e549b0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# https://docs.openstack.org/neutron/latest/admin/config-sriov.html"},{"line_number":50,"context_line":"extensions \u003d fdb"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[FDB]"},{"line_number":53,"context_line":"shared_physical_device_mappings \u003d {% for physnet, dev in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{{ physnet }}:{{ dev }}{% endfor %}"},{"line_number":54,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"bf51134e_09a48007","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":172},"in_reply_to":"bf51134e_c974489f","updated":"2020-07-24 09:56:19.000000000","message":"Operators can override this at per-host level if they need to in their local kolla config.","commit_id":"cc3d44cff521dc693be63d6274e909ee146a0680"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"c76f2b3a63291a8cf4e7605794bd9efd2067e530","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# https://docs.openstack.org/neutron/latest/admin/config-sriov.html"},{"line_number":50,"context_line":"extensions \u003d fdb"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[FDB]"},{"line_number":53,"context_line":"shared_physical_device_mappings \u003d {% for physnet, dev in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{{ physnet }}:{{ dev }}{% endfor %}"},{"line_number":54,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"bf51134e_c974489f","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":172},"in_reply_to":"bf51134e_ee6e72fe","updated":"2020-07-24 09:55:18.000000000","message":"According to the docs (https://docs.openstack.org/neutron/latest/admin/config-sriov.html#optional-fdb-l2-agent-extension), this config is only consumed by ovs or linuxbridge agent. So neutron-server doesnt use it at all. From what I can tell, we do not have a separate config for ovs and linuxbridge agents, both consume ml2_conf.ini so this is safe.","commit_id":"cc3d44cff521dc693be63d6274e909ee146a0680"}],"ansible/roles/neutron/templates/sriov_agent.ini.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ec71a43dbba7d5d6f120636698ae424574435670","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Maps a physical network to network inferface used for SRIOV"},{"line_number":4,"context_line":"# This template should be modified for specific environments"},{"line_number":5,"context_line":"# See Official OpenStack SRIOV documentation for all available options"},{"line_number":6,"context_line":"physical_device_mappings  \u003d {% for dev, physnet in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{{ physnet }}:{{ dev }}{% endfor %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"exclude_devices \u003d"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9f560f44_8acd1b33","line":6,"range":{"start_line":6,"start_character":28,"end_line":6,"end_character":166},"updated":"2020-08-01 20:19:26.000000000","message":"IISC this begs for refactoring, I think I saw this three times already","commit_id":"5ee2cbf0504969fe2c7e04654a4bd058c57ecdac"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ec71a43dbba7d5d6f120636698ae424574435670","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# This template should be modified for specific environments"},{"line_number":5,"context_line":"# See Official OpenStack SRIOV documentation for all available options"},{"line_number":6,"context_line":"physical_device_mappings  \u003d {% for dev, physnet in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{{ physnet }}:{{ dev }}{% endfor %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"exclude_devices \u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"[securitygroup]"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9f560f44_aac8df21","line":7,"updated":"2020-08-01 20:19:26.000000000","message":"nit: line","commit_id":"5ee2cbf0504969fe2c7e04654a4bd058c57ecdac"}],"ansible/roles/nova-cell/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"be88a4a030afb8c9161e64953961e585fc88faef","unresolved":false,"context_lines":[{"line_number":437,"context_line":"###################################"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"nova_pci_passthrough_whitelist:"},{"line_number":440,"context_line":"  - \"{{ enable_neutron_sriov | bool | ternary(neutron_sriov_physnet_mappings | dict2items(key_name\u003d\u0027physical_network\u0027, value_name\u003d\u0027devname\u0027), []) }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9f560f44_f670790b","line":440,"updated":"2020-08-28 12:49:24.000000000","message":"Why is it a list of lists?","commit_id":"c083aa1ce2420bc21c35c6bb60dfdeafeea98668"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"3a28e9cca0626debd4265cd333b27f9edd6f454f","unresolved":false,"context_lines":[{"line_number":437,"context_line":"###################################"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"nova_pci_passthrough_whitelist:"},{"line_number":440,"context_line":"  - \"{{ enable_neutron_sriov | bool | ternary(neutron_sriov_physnet_mappings | dict2items(key_name\u003d\u0027physical_network\u0027, value_name\u003d\u0027devname\u0027), []) }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9f560f44_942495b1","line":440,"in_reply_to":"9f560f44_f670790b","updated":"2020-08-28 13:38:15.000000000","message":"Gives the possiblility of adding a new category of device mappings. e.g:\n\n    gpu_device_mappings:\n      - vendor_id: x\n        product_id: y\n    nova_pci_passthrough_whitelist:\n      - \"{{ enable_gpu_passthrough | bool | ternary(gpu_device_mappings, []) }}\"","commit_id":"c083aa1ce2420bc21c35c6bb60dfdeafeea98668"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8eac1f1f3fdcb6f96db35257ab18abc01cd72ae9","unresolved":false,"context_lines":[{"line_number":437,"context_line":"###################################"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"nova_pci_passthrough_whitelist:"},{"line_number":440,"context_line":"  - \"{{ enable_neutron_sriov | bool | ternary(neutron_sriov_physnet_mappings | dict2items(key_name\u003d\u0027physical_network\u0027, value_name\u003d\u0027devname\u0027), []) }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9f560f44_5e613cd3","line":440,"updated":"2020-09-17 10:16:31.000000000","message":"I find the nested list a bit unintuitive, but I can live with it.","commit_id":"788d90678c846111b0b12d0656f855dd5be24ca8"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"fe09c9d9e1eced81ba0f0d1128a8f4b1313f67c7","unresolved":false,"context_lines":[{"line_number":437,"context_line":"###################################"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"nova_pci_passthrough_whitelist:"},{"line_number":440,"context_line":"  - \"{{ enable_neutron_sriov | bool | ternary(neutron_sriov_physnet_mappings | dict2items(key_name\u003d\u0027physical_network\u0027, value_name\u003d\u0027devname\u0027), []) }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9f560f44_5efbfc45","line":440,"in_reply_to":"9f560f44_5e4dbcc2","updated":"2020-09-17 11:01:12.000000000","message":"This is what the flatten does in https://review.opendev.org/#/c/742633/20/ansible/roles/nova-cell/templates/nova.conf.j2 line 250, I just thought this was neater way of representing it but I can change that if adding together is preferred. I dont have a strong preference either way.","commit_id":"788d90678c846111b0b12d0656f855dd5be24ca8"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"09643b9d893dc503365c34e36d2333789e084e82","unresolved":false,"context_lines":[{"line_number":437,"context_line":"###################################"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"nova_pci_passthrough_whitelist:"},{"line_number":440,"context_line":"  - \"{{ enable_neutron_sriov | bool | ternary(neutron_sriov_physnet_mappings | dict2items(key_name\u003d\u0027physical_network\u0027, value_name\u003d\u0027devname\u0027), []) }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9f560f44_9e28f4ee","line":440,"in_reply_to":"9f560f44_5e613cd3","updated":"2020-09-17 10:50:27.000000000","message":"It doesnt make a lot of sense to have this here now but imagine a scenario where a new flag requires more devices to be whitelisted?","commit_id":"788d90678c846111b0b12d0656f855dd5be24ca8"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0753e0c2e6b2cc5ab375f99f5d0a5df9bd23d7f6","unresolved":false,"context_lines":[{"line_number":437,"context_line":"###################################"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"nova_pci_passthrough_whitelist:"},{"line_number":440,"context_line":"  - \"{{ enable_neutron_sriov | bool | ternary(neutron_sriov_physnet_mappings | dict2items(key_name\u003d\u0027physical_network\u0027, value_name\u003d\u0027devname\u0027), []) }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9f560f44_5e4dbcc2","line":440,"in_reply_to":"9f560f44_9e28f4ee","updated":"2020-09-17 10:58:05.000000000","message":"Then the lists can be added together","commit_id":"788d90678c846111b0b12d0656f855dd5be24ca8"}],"ansible/roles/nova-cell/templates/nova.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"409ae03706f230d4c407d1fb7d4f5257e8b80f37","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"{% if enable_neutron_sriov | bool %}"},{"line_number":241,"context_line":"[pci]"},{"line_number":242,"context_line":"passthrough_whitelist \u003d [{% for physnet, dev in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{ \"devname\": \"{{ dev }}\", \"physical_network\": \"{{ physnet }}\" }{% endfor %}]"},{"line_number":243,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"bf51134e_0b00f133","line":242,"range":{"start_line":242,"start_character":48,"end_line":242,"end_character":78},"updated":"2020-07-24 15:12:27.000000000","message":"I expect the nova-cell role cannot see this variable, since it is in neutron defaults. It probably needs to go in group_vars/all.yml if it\u0027s being shared between roles.","commit_id":"83f4ff1518d909846a97746a4e39fd371af4898e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b0afacd34cb6232fb1ab1e362c907e3c346ed644","unresolved":false,"context_lines":[{"line_number":237,"context_line":"track_instance_changes \u003d false"},{"line_number":238,"context_line":"{% endif %}"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"{% if enable_neutron_sriov | bool %}"},{"line_number":241,"context_line":"[pci]"},{"line_number":242,"context_line":"passthrough_whitelist \u003d [{% for physnet, dev in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{ \"devname\": \"{{ dev }}\", \"physical_network\": \"{{ physnet }}\" }{% endfor %}]"},{"line_number":243,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9f560f44_f8a1f6f9","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":36},"updated":"2020-08-04 08:58:33.000000000","message":"Any reason not to keep this here to be consistent with neutron?","commit_id":"5ee2cbf0504969fe2c7e04654a4bd058c57ecdac"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4748f6201182cb5361cb9bb5a229228398b2839d","unresolved":false,"context_lines":[{"line_number":237,"context_line":"track_instance_changes \u003d false"},{"line_number":238,"context_line":"{% endif %}"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"{% if enable_neutron_sriov | bool %}"},{"line_number":241,"context_line":"[pci]"},{"line_number":242,"context_line":"passthrough_whitelist \u003d [{% for physnet, dev in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{ \"devname\": \"{{ dev }}\", \"physical_network\": \"{{ physnet }}\" }{% endfor %}]"},{"line_number":243,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9f560f44_d4fc2440","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":36},"in_reply_to":"9f560f44_708e0dd1","updated":"2020-08-14 15:58:35.000000000","message":"In the latest patch, this if condition has been removed. In the neutron role it is still present.","commit_id":"5ee2cbf0504969fe2c7e04654a4bd058c57ecdac"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"0f56e0b358699ce5eb9196115a752c80b84684ed","unresolved":false,"context_lines":[{"line_number":237,"context_line":"track_instance_changes \u003d false"},{"line_number":238,"context_line":"{% endif %}"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"{% if enable_neutron_sriov | bool %}"},{"line_number":241,"context_line":"[pci]"},{"line_number":242,"context_line":"passthrough_whitelist \u003d [{% for physnet, dev in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{ \"devname\": \"{{ dev }}\", \"physical_network\": \"{{ physnet }}\" }{% endfor %}]"},{"line_number":243,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9f560f44_4c60bb0e","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":36},"in_reply_to":"9f560f44_d4fc2440","updated":"2020-08-28 10:46:59.000000000","message":"In the latest patch, I have made this conditional on whether the list is empty or not. I made it like this because I was anticipating PCI Passthrough devices to be whitelistable in context other than SR-IOV, e.g. GPU passthrough.","commit_id":"5ee2cbf0504969fe2c7e04654a4bd058c57ecdac"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f646cf4ac98bd966248cade8971a978bd5af7138","unresolved":false,"context_lines":[{"line_number":237,"context_line":"track_instance_changes \u003d false"},{"line_number":238,"context_line":"{% endif %}"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"{% if enable_neutron_sriov | bool %}"},{"line_number":241,"context_line":"[pci]"},{"line_number":242,"context_line":"passthrough_whitelist \u003d [{% for physnet, dev in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{ \"devname\": \"{{ dev }}\", \"physical_network\": \"{{ physnet }}\" }{% endfor %}]"},{"line_number":243,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9f560f44_708e0dd1","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":36},"in_reply_to":"9f560f44_f8a1f6f9","updated":"2020-08-13 22:35:37.000000000","message":"how do you mean?","commit_id":"5ee2cbf0504969fe2c7e04654a4bd058c57ecdac"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ec71a43dbba7d5d6f120636698ae424574435670","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"{% if enable_neutron_sriov | bool %}"},{"line_number":241,"context_line":"[pci]"},{"line_number":242,"context_line":"passthrough_whitelist \u003d [{% for physnet, dev in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{ \"devname\": \"{{ dev }}\", \"physical_network\": \"{{ physnet }}\" }{% endfor %}]"},{"line_number":243,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9f560f44_eace572b","line":242,"range":{"start_line":242,"start_character":25,"end_line":242,"end_character":190},"updated":"2020-08-01 20:19:26.000000000","message":"this one looks different but could be nice to have it in config vars","commit_id":"5ee2cbf0504969fe2c7e04654a4bd058c57ecdac"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"0f56e0b358699ce5eb9196115a752c80b84684ed","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"{% if enable_neutron_sriov | bool %}"},{"line_number":241,"context_line":"[pci]"},{"line_number":242,"context_line":"passthrough_whitelist \u003d [{% for physnet, dev in neutron_sriov_physnet_mappings.items() %}{{ (loop.index0 \u003e 0)|ternary(\u0027,\u0027,\u0027\u0027) }}{ \"devname\": \"{{ dev }}\", \"physical_network\": \"{{ physnet }}\" }{% endfor %}]"},{"line_number":243,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9f560f44_acab571c","line":242,"range":{"start_line":242,"start_character":25,"end_line":242,"end_character":190},"in_reply_to":"9f560f44_eace572b","updated":"2020-08-28 10:46:59.000000000","message":"Done","commit_id":"5ee2cbf0504969fe2c7e04654a4bd058c57ecdac"}],"doc/source/reference/networking/sriov.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c5b6cb0edb113f4df2cca7f3adc558e8e69de829","unresolved":false,"context_lines":[{"line_number":28,"context_line":".. path /etc/kolla/config/neutron/ml2_conf.ini"},{"line_number":29,"context_line":".. code-block:: ini"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   [ml2]"},{"line_number":32,"context_line":"   mechanism_drivers \u003d openvswitch,l2population,sriovnicswitch"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"   [ml2_type_vlan]"},{"line_number":35,"context_line":"   network_vlan_ranges \u003d sriovtenant1:1000:1009"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_ce61ee13","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":62},"updated":"2020-07-24 09:43:25.000000000","message":"so this should no longer be done then","commit_id":"cc3d44cff521dc693be63d6274e909ee146a0680"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"dfd742817e3a46e1e2de4af58a96fe62bd54e253","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   [ml2_type_flat]"},{"line_number":38,"context_line":"   flat_networks \u003d sriovtenant1"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add ``PciPassthroughFilter`` to enabled_filters"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"The ``PciPassthroughFilter``, which is required by Nova Scheduler service"},{"line_number":43,"context_line":"on the Controller, should be added to ``enabled_filters``"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Modify the ``/etc/kolla/config/nova.conf`` file and add"},{"line_number":46,"context_line":"``PciPassthroughFilter`` to ``enabled_filters``. this filter is"}],"source_content_type":"text/x-rst","patch_set":10,"id":"bf51134e_89e5303b","side":"PARENT","line":43,"range":{"start_line":40,"start_character":0,"end_line":43,"end_character":57},"updated":"2020-07-24 10:21:07.000000000","message":"removing this as the same point is made 3 times but the next paragraph is the clearest.","commit_id":"6bbc7138851e3517fdf20f06bf85b5a0c88b93c0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6f4614c83be96c30c291a29090aff12bba89b717","unresolved":false,"context_lines":[{"line_number":34,"context_line":"   [ml2_type_flat]"},{"line_number":35,"context_line":"   flat_networks \u003d sriovtenant1"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Modify the ``/etc/kolla/config/nova.conf`` file and add"},{"line_number":38,"context_line":"``PciPassthroughFilter`` to ``enabled_filters``. this filter is"},{"line_number":39,"context_line":"required by The Nova Scheduler service on the controller node."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. path /etc/kolla/config/nova.conf"},{"line_number":42,"context_line":".. code-block:: ini"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"   [filter_scheduler]"},{"line_number":45,"context_line":"   enabled_filters \u003d \u003cexisting filters\u003e, PciPassthroughFilter"},{"line_number":46,"context_line":"   available_filters \u003d nova.scheduler.filters.all_filters"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Edit the ``/etc/kolla/config/nova.conf`` file and add PCI device whitelisting."},{"line_number":49,"context_line":"this is needed by OpenStack Compute service(s) on the Compute."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. path /etc/kolla/config/nova.conf"},{"line_number":52,"context_line":".. code-block:: ini"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"   [pci]"},{"line_number":55,"context_line":"   passthrough_whitelist \u003d [{\"devname\": \"ens785f0\", \"physical_network\": \"sriovtenant1\"}]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Modify the ``/etc/kolla/config/neutron/sriov_agent.ini`` file. Add physical"},{"line_number":58,"context_line":"network to interface mapping. Specific VFs can also be excluded here. Leaving"},{"line_number":59,"context_line":"blank means to enable all VFs for the interface:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. path /etc/kolla/config/neutron/sriov_agent.ini"},{"line_number":62,"context_line":".. code-block:: ini"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"   [sriov_nic]"},{"line_number":65,"context_line":"   physical_device_mappings \u003d sriovtenant1:ens785f0"},{"line_number":66,"context_line":"   exclude_devices \u003d"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Run deployment."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"bf51134e_a96114ab","line":66,"range":{"start_line":37,"start_character":0,"end_line":66,"end_character":20},"updated":"2020-07-24 10:03:02.000000000","message":"and this is also done now I guess? (or at least most of it, please check)","commit_id":"7b51114666ea278f6f955c5689b2f2b0b857ea1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"409ae03706f230d4c407d1fb7d4f5257e8b80f37","unresolved":false,"context_lines":[{"line_number":23,"context_line":"     sriovtenant1: ens785f0"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This automatically appends ``sriovnicswitch`` to the ``mechanism_drivers`` inside"},{"line_number":26,"context_line":"``/etc/kolla/config/neutron/ml2_conf.ini``.  However, the provider networks"},{"line_number":27,"context_line":"used by SRIOV should be configured. Both flat and VLAN are configured with the"},{"line_number":28,"context_line":"same physical network name in this example:"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"bf51134e_eb9add10","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":42},"updated":"2020-07-24 15:12:27.000000000","message":"It doesn\u0027t end up here, this file is for customisation. Maybe just say ml2_conf.ini.","commit_id":"83f4ff1518d909846a97746a4e39fd371af4898e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"409ae03706f230d4c407d1fb7d4f5257e8b80f37","unresolved":false,"context_lines":[{"line_number":48,"context_line":"   available_filters \u003d nova.scheduler.filters.all_filters"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"PCI devices listed under ``neutron_sriov_physnet_mappings`` will be"},{"line_number":51,"context_line":"whitelisted on the Compute hosts inside ``/etc/kolla/config/nova.conf``."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Physical network to interface mappings will be automatically be added from"},{"line_number":54,"context_line":"``neutron_sriov_physnet_mappings`` to ``physical_device_mappings`` under"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bf51134e_8bc241e8","line":51,"range":{"start_line":51,"start_character":40,"end_line":51,"end_character":71},"updated":"2020-07-24 15:12:27.000000000","message":"again, just nova.conf.","commit_id":"83f4ff1518d909846a97746a4e39fd371af4898e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"409ae03706f230d4c407d1fb7d4f5257e8b80f37","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Physical network to interface mappings will be automatically be added from"},{"line_number":54,"context_line":"``neutron_sriov_physnet_mappings`` to ``physical_device_mappings`` under"},{"line_number":55,"context_line":"``/etc/kolla/config/neutron/sriov_agent.ini``. However, specific VFs can"},{"line_number":56,"context_line":"be excluded here. Leaving blank means to enable all VFs for the interface:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. path /etc/kolla/config/neutron/sriov_agent.ini"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bf51134e_ebb3fd98","line":55,"range":{"start_line":55,"start_character":28,"end_line":55,"end_character":43},"updated":"2020-07-24 15:12:27.000000000","message":"ditto","commit_id":"83f4ff1518d909846a97746a4e39fd371af4898e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ec71a43dbba7d5d6f120636698ae424574435670","unresolved":false,"context_lines":[{"line_number":59,"context_line":"PCI devices listed under ``neutron_sriov_physnet_mappings`` will be"},{"line_number":60,"context_line":"whitelisted on the Compute hosts inside ``nova.conf``."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Physical network to interface mappings will be automatically be added"},{"line_number":63,"context_line":"from ``neutron_sriov_physnet_mappings`` to"},{"line_number":64,"context_line":"``physical_device_mappings`` under ``sriov_agent.ini``. However,"},{"line_number":65,"context_line":"specific VFs can be excluded here. Leaving blank means to enable all"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9f560f44_4a4ae3ab","line":62,"range":{"start_line":62,"start_character":61,"end_line":62,"end_character":63},"updated":"2020-08-01 20:19:26.000000000","message":"nit: drop","commit_id":"5ee2cbf0504969fe2c7e04654a4bd058c57ecdac"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e115b7852617d33dfd68efcf8873cbcd038c4133","unresolved":false,"context_lines":[{"line_number":14,"context_line":"platforms. Consult NIC and platform specific documentation for instructions"},{"line_number":15,"context_line":"on enablement."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Modify the ``/etc/kolla/globals.yml`` file as the following example"},{"line_number":18,"context_line":"shows which automatically appends ``sriovnicswitch`` to the"},{"line_number":19,"context_line":"``mechanism_drivers`` inside ``ml2_conf.ini``."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. path /etc/kolla/globals.yml"},{"line_number":22,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":17,"id":"9f560f44_71ec788f","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":46},"updated":"2020-08-28 09:30:03.000000000","message":"I feel we need some rewording here, I got lost in the sentence.","commit_id":"dceb1ba0665e5cbb84cd8d795e23b852cd50e245"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"0f56e0b358699ce5eb9196115a752c80b84684ed","unresolved":false,"context_lines":[{"line_number":14,"context_line":"platforms. Consult NIC and platform specific documentation for instructions"},{"line_number":15,"context_line":"on enablement."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Modify the ``/etc/kolla/globals.yml`` file as the following example"},{"line_number":18,"context_line":"shows which automatically appends ``sriovnicswitch`` to the"},{"line_number":19,"context_line":"``mechanism_drivers`` inside ``ml2_conf.ini``."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. path /etc/kolla/globals.yml"},{"line_number":22,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":17,"id":"9f560f44_6cbadf6e","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":46},"in_reply_to":"9f560f44_71ec788f","updated":"2020-08-28 10:46:59.000000000","message":"Done","commit_id":"dceb1ba0665e5cbb84cd8d795e23b852cd50e245"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"cc0f04ed2511b1992accda59a3a9df67191b3ac3","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"   enable_neutron_sriov: \"yes\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"It is also a requirement to define phynet:interface mappings for all"},{"line_number":27,"context_line":"SRIOV devices as shown:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. path /etc/kolla/globals.yml"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f560f44_046e17ff","line":26,"range":{"start_line":26,"start_character":35,"end_line":26,"end_character":41},"updated":"2020-09-07 10:00:36.000000000","message":"nit: physnet","commit_id":"c083aa1ce2420bc21c35c6bb60dfdeafeea98668"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"9557716a0043278dc13d98165a68eef56814fa8d","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"   enable_neutron_sriov: \"yes\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"It is also a requirement to define phynet:interface mappings for all"},{"line_number":27,"context_line":"SRIOV devices as shown:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. path /etc/kolla/globals.yml"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f560f44_548134fb","line":26,"range":{"start_line":26,"start_character":35,"end_line":26,"end_character":41},"in_reply_to":"9f560f44_046e17ff","updated":"2020-09-16 13:54:33.000000000","message":"Done","commit_id":"c083aa1ce2420bc21c35c6bb60dfdeafeea98668"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"cc0f04ed2511b1992accda59a3a9df67191b3ac3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"   enable_neutron_sriov: \"yes\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"It is also a requirement to define phynet:interface mappings for all"},{"line_number":27,"context_line":"SRIOV devices as shown:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. path /etc/kolla/globals.yml"},{"line_number":30,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f560f44_24423b69","line":27,"updated":"2020-09-07 10:00:36.000000000","message":"mention also that ens875f0 is just an example","commit_id":"c083aa1ce2420bc21c35c6bb60dfdeafeea98668"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"9557716a0043278dc13d98165a68eef56814fa8d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"   enable_neutron_sriov: \"yes\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"It is also a requirement to define phynet:interface mappings for all"},{"line_number":27,"context_line":"SRIOV devices as shown:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. path /etc/kolla/globals.yml"},{"line_number":30,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f560f44_b4d410eb","line":27,"in_reply_to":"9f560f44_24423b69","updated":"2020-09-16 13:54:33.000000000","message":"Done","commit_id":"c083aa1ce2420bc21c35c6bb60dfdeafeea98668"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"cc0f04ed2511b1992accda59a3a9df67191b3ac3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   neutron_sriov_physnet_mappings:"},{"line_number":33,"context_line":"     sriovtenant1: ens785f0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"However, the provider networks used by SRIOV should be configured."},{"line_number":36,"context_line":"Both flat and VLAN are configured with the same physical network name"},{"line_number":37,"context_line":"in this example:"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f560f44_847987c6","line":35,"range":{"start_line":35,"start_character":31,"end_line":35,"end_character":38},"updated":"2020-09-07 10:00:36.000000000","message":"using\n\n\n(they are using SRIOV and not the other way around)","commit_id":"c083aa1ce2420bc21c35c6bb60dfdeafeea98668"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"9557716a0043278dc13d98165a68eef56814fa8d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   neutron_sriov_physnet_mappings:"},{"line_number":33,"context_line":"     sriovtenant1: ens785f0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"However, the provider networks used by SRIOV should be configured."},{"line_number":36,"context_line":"Both flat and VLAN are configured with the same physical network name"},{"line_number":37,"context_line":"in this example:"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f560f44_f4de880e","line":35,"range":{"start_line":35,"start_character":31,"end_line":35,"end_character":38},"in_reply_to":"9f560f44_847987c6","updated":"2020-09-16 13:54:33.000000000","message":"Done","commit_id":"c083aa1ce2420bc21c35c6bb60dfdeafeea98668"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"cc0f04ed2511b1992accda59a3a9df67191b3ac3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   [ml2_type_flat]"},{"line_number":46,"context_line":"   flat_networks \u003d sriovtenant1"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Modify the ``nova.conf`` file and add ``PciPassthroughFilter`` to"},{"line_number":49,"context_line":"``enabled_filters``. This filter is required by the Nova Scheduler"},{"line_number":50,"context_line":"service on the controller node."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. path /etc/kolla/config/nova.conf"},{"line_number":53,"context_line":".. code-block:: ini"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"   [filter_scheduler]"},{"line_number":56,"context_line":"   enabled_filters \u003d \u003cexisting filters\u003e, PciPassthroughFilter"},{"line_number":57,"context_line":"   available_filters \u003d nova.scheduler.filters.all_filters"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"PCI devices listed under ``neutron_sriov_physnet_mappings`` will be"},{"line_number":60,"context_line":"whitelisted on the Compute hosts inside ``nova.conf``."}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f560f44_445c8f4a","line":57,"range":{"start_line":48,"start_character":0,"end_line":57,"end_character":57},"updated":"2020-09-07 10:00:36.000000000","message":"Could we automate it?","commit_id":"c083aa1ce2420bc21c35c6bb60dfdeafeea98668"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"9557716a0043278dc13d98165a68eef56814fa8d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   [ml2_type_flat]"},{"line_number":46,"context_line":"   flat_networks \u003d sriovtenant1"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Modify the ``nova.conf`` file and add ``PciPassthroughFilter`` to"},{"line_number":49,"context_line":"``enabled_filters``. This filter is required by the Nova Scheduler"},{"line_number":50,"context_line":"service on the controller node."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. path /etc/kolla/config/nova.conf"},{"line_number":53,"context_line":".. code-block:: ini"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"   [filter_scheduler]"},{"line_number":56,"context_line":"   enabled_filters \u003d \u003cexisting filters\u003e, PciPassthroughFilter"},{"line_number":57,"context_line":"   available_filters \u003d nova.scheduler.filters.all_filters"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"PCI devices listed under ``neutron_sriov_physnet_mappings`` will be"},{"line_number":60,"context_line":"whitelisted on the Compute hosts inside ``nova.conf``."}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f560f44_b4c37057","line":57,"range":{"start_line":48,"start_character":0,"end_line":57,"end_character":57},"in_reply_to":"9f560f44_445c8f4a","updated":"2020-09-16 13:54:33.000000000","message":"Yes, however probably something for another patch.","commit_id":"c083aa1ce2420bc21c35c6bb60dfdeafeea98668"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"cc0f04ed2511b1992accda59a3a9df67191b3ac3","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Physical network to interface mappings in ``neutron_sriov_physnet_mappings``"},{"line_number":63,"context_line":"will be automatically added to ``sriov_agent.ini``. However, specific VFs can"},{"line_number":64,"context_line":"be excluded as follows (leaving blank enables all VFs):"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. path /etc/kolla/config/neutron/sriov_agent.ini"},{"line_number":67,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f560f44_645f1341","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":45},"updated":"2020-09-07 10:00:36.000000000","message":"leaving blank (default) keeps all VFs enabled","commit_id":"c083aa1ce2420bc21c35c6bb60dfdeafeea98668"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"9557716a0043278dc13d98165a68eef56814fa8d","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Physical network to interface mappings in ``neutron_sriov_physnet_mappings``"},{"line_number":63,"context_line":"will be automatically added to ``sriov_agent.ini``. However, specific VFs can"},{"line_number":64,"context_line":"be excluded as follows (leaving blank enables all VFs):"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. path /etc/kolla/config/neutron/sriov_agent.ini"},{"line_number":67,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f560f44_f4b968cb","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":45},"in_reply_to":"9f560f44_645f1341","updated":"2020-09-16 13:54:33.000000000","message":"Done","commit_id":"c083aa1ce2420bc21c35c6bb60dfdeafeea98668"}]}