)]}'
{"ansible/roles/aodh/tasks/deploy.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e488bd08c9833a5390f27f5b65f879cec01d464a","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- include_tasks: bootstrap.yml"},{"line_number":13,"context_line":"  when: inventory_hostname in groups[\u0027aodh-api\u0027]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Flush handlers"},{"line_number":16,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_6e04bb15","line":14,"updated":"2020-08-07 16:34:15.000000000","message":"Might make sense to move here, allowing clone or bootstrap failures to fail early","commit_id":"c9fcc1dd689441ab01568c84cce86db0b302f1fd"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1aa1ce4da23994a32d6a2ce07338a8c4c8cc434a","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- include_tasks: bootstrap.yml"},{"line_number":13,"context_line":"  when: inventory_hostname in groups[\u0027aodh-api\u0027]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Flush handlers"},{"line_number":16,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_ee73abe5","line":14,"in_reply_to":"9f560f44_6e04bb15","updated":"2020-08-07 17:18:46.000000000","message":"Could be another patch, this one follows the config+check order very strictly.","commit_id":"c9fcc1dd689441ab01568c84cce86db0b302f1fd"}],"ansible/roles/aodh/tasks/upgrade.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e488bd08c9833a5390f27f5b65f879cec01d464a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- import_tasks: check-containers.yml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include_tasks: bootstrap_service.yml"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Flush handlers"},{"line_number":9,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_ce07c717","line":7,"updated":"2020-08-07 16:34:15.000000000","message":"ditto","commit_id":"c9fcc1dd689441ab01568c84cce86db0b302f1fd"}],"ansible/roles/glance/tasks/rolling_upgrade.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6ec549d15933414fe49e3950ec75424b102f323e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    glance_upgrading: True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Upgrade first node (NEW NODE in the Glance documentation)"},{"line_number":7,"context_line":"- include_tasks: config.yml"},{"line_number":8,"context_line":"  when: inventory_hostname \u003d\u003d glance_api_hosts[0]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- include_tasks: stop_service.yml"},{"line_number":11,"context_line":"  when: inventory_hostname \u003d\u003d glance_api_hosts[0]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_2cfe1dae","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":49},"updated":"2020-08-12 12:45:37.000000000","message":"Well first we do one node here","commit_id":"c9fcc1dd689441ab01568c84cce86db0b302f1fd"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e802b46537cd597648c581a1924182477663be90","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    restart_policy: no"},{"line_number":67,"context_line":"    volumes: \"{{ glance_api.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":68,"context_line":"  run_once: True"},{"line_number":69,"context_line":"  delegate_to: \"{{ glance_api_hosts[0] }}\""},{"line_number":70,"context_line":"  notify:"},{"line_number":71,"context_line":"    - Restart glance-api container"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Upgrade remaining node"},{"line_number":74,"context_line":"- include_tasks: config.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_bd07f518","line":71,"range":{"start_line":69,"start_character":0,"end_line":71,"end_character":34},"updated":"2020-08-12 15:13:04.000000000","message":"this is the reason it works","commit_id":"c9fcc1dd689441ab01568c84cce86db0b302f1fd"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"213ad901677fef23953fde26231f91dd55b49257","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    restart_policy: no"},{"line_number":67,"context_line":"    volumes: \"{{ glance_api.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":68,"context_line":"  run_once: True"},{"line_number":69,"context_line":"  delegate_to: \"{{ glance_api_hosts[0] }}\""},{"line_number":70,"context_line":"  notify:"},{"line_number":71,"context_line":"    - Restart glance-api container"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Upgrade remaining node"},{"line_number":74,"context_line":"- include_tasks: config.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_5e084fd8","line":71,"range":{"start_line":69,"start_character":0,"end_line":71,"end_character":34},"in_reply_to":"9f560f44_18bb8f0e","updated":"2020-08-12 18:52:17.000000000","message":"But it\u0027s a good enough fudge. :-) This is code for upgrade, we usually just refer to the deploy here, except for some services like glance.\n\nIf it makes your day any brigher, I can remove the conditional. It does not hurt.","commit_id":"c9fcc1dd689441ab01568c84cce86db0b302f1fd"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0cdbe09f10a21cb1fceeafc47d0aec2ba30e6653","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    restart_policy: no"},{"line_number":67,"context_line":"    volumes: \"{{ glance_api.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":68,"context_line":"  run_once: True"},{"line_number":69,"context_line":"  delegate_to: \"{{ glance_api_hosts[0] }}\""},{"line_number":70,"context_line":"  notify:"},{"line_number":71,"context_line":"    - Restart glance-api container"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Upgrade remaining node"},{"line_number":74,"context_line":"- include_tasks: config.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_772e11fb","line":71,"range":{"start_line":69,"start_character":0,"end_line":71,"end_character":34},"in_reply_to":"9f560f44_1c3d3a2c","updated":"2020-08-13 09:56:04.000000000","message":"You are very welcome.","commit_id":"c9fcc1dd689441ab01568c84cce86db0b302f1fd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"823230bb80060d4b205bc657c57a057a70a0e708","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    restart_policy: no"},{"line_number":67,"context_line":"    volumes: \"{{ glance_api.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":68,"context_line":"  run_once: True"},{"line_number":69,"context_line":"  delegate_to: \"{{ glance_api_hosts[0] }}\""},{"line_number":70,"context_line":"  notify:"},{"line_number":71,"context_line":"    - Restart glance-api container"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Upgrade remaining node"},{"line_number":74,"context_line":"- include_tasks: config.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_1c3d3a2c","line":71,"range":{"start_line":69,"start_character":0,"end_line":71,"end_character":34},"in_reply_to":"9f560f44_5e084fd8","updated":"2020-08-13 08:47:07.000000000","message":"Thanks, it now more closely matches previous behaviour, and guards against someone \u0027cleaning up\u0027 this weirdly placed notify.","commit_id":"c9fcc1dd689441ab01568c84cce86db0b302f1fd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f6d623005265453f09ad238df5a1549c331b2915","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    restart_policy: no"},{"line_number":67,"context_line":"    volumes: \"{{ glance_api.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":68,"context_line":"  run_once: True"},{"line_number":69,"context_line":"  delegate_to: \"{{ glance_api_hosts[0] }}\""},{"line_number":70,"context_line":"  notify:"},{"line_number":71,"context_line":"    - Restart glance-api container"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Upgrade remaining node"},{"line_number":74,"context_line":"- include_tasks: config.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_18bb8f0e","line":71,"range":{"start_line":69,"start_character":0,"end_line":71,"end_character":34},"in_reply_to":"9f560f44_bd07f518","updated":"2020-08-12 16:23:11.000000000","message":"Seems like a fudge :)","commit_id":"c9fcc1dd689441ab01568c84cce86db0b302f1fd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6ec549d15933414fe49e3950ec75424b102f323e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  notify:"},{"line_number":71,"context_line":"    - Restart glance-api container"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Upgrade remaining node"},{"line_number":74,"context_line":"- include_tasks: config.yml"},{"line_number":75,"context_line":"  when: inventory_hostname !\u003d glance_api_hosts[0]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- import_tasks: check-containers.yml"},{"line_number":78,"context_line":"  when: inventory_hostname !\u003d glance_api_hosts[0]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_8c2c894b","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":49},"updated":"2020-08-12 12:45:37.000000000","message":"Then the rest here.","commit_id":"c9fcc1dd689441ab01568c84cce86db0b302f1fd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e488bd08c9833a5390f27f5b65f879cec01d464a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  when: inventory_hostname !\u003d glance_api_hosts[0]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- import_tasks: check-containers.yml"},{"line_number":78,"context_line":"  when: inventory_hostname !\u003d glance_api_hosts[0]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Flush handlers"},{"line_number":81,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_ee38cbd3","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":49},"updated":"2020-08-07 16:34:15.000000000","message":"I think we need to check them all","commit_id":"c9fcc1dd689441ab01568c84cce86db0b302f1fd"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1aa1ce4da23994a32d6a2ce07338a8c4c8cc434a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  when: inventory_hostname !\u003d glance_api_hosts[0]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- import_tasks: check-containers.yml"},{"line_number":78,"context_line":"  when: inventory_hostname !\u003d glance_api_hosts[0]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Flush handlers"},{"line_number":81,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_eeae0b2c","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":49},"in_reply_to":"9f560f44_ee38cbd3","updated":"2020-08-07 17:18:46.000000000","message":"Nope, this preserves the old behaviour which is actually correct.","commit_id":"c9fcc1dd689441ab01568c84cce86db0b302f1fd"}]}