)]}'
{"ansible/roles/elasticsearch/defaults/main.yml":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"ba4ee39a6a68507a4508ff709e4a3150fb5986b1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# Duration after which an index is permanently erased from the cluster."},{"line_number":71,"context_line":"elasticsearch_curator_hard_retention_period_days: 60"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"elasticsearch_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ elasticsearch_port }}\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"####################"},{"line_number":76,"context_line":"# Keystone"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_ce581058","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":31},"updated":"2020-08-14 23:11:10.000000000","message":"This variable is introduced in the all.yml file in this other patch: https://review.opendev.org/#/c/652157/29/ansible/group_vars/all.yml\n\nThat was done because the same URL is used by different roles. Therefore, we should keep that in mind when handling/using URLs in Kolla-ansible.\n\nIf that other patch is merged, we should consider just using the variable `elasticsearch_internal_endpoint`, instead of re-declaring it here.","commit_id":"092250002b5c1d2b25a89725950b49f8ae0216ec"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"af4f1a968dda3c8b3e5d385ab45542e5867e0713","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# Duration after which an index is permanently erased from the cluster."},{"line_number":71,"context_line":"elasticsearch_curator_hard_retention_period_days: 60"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"elasticsearch_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ elasticsearch_port }}\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"####################"},{"line_number":76,"context_line":"# Keystone"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_a7c4b160","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":31},"in_reply_to":"9f560f44_ce581058","updated":"2020-08-19 08:16:15.000000000","message":"Thanks - hadn\u0027t seen that one!","commit_id":"092250002b5c1d2b25a89725950b49f8ae0216ec"}],"ansible/roles/elasticsearch/tasks/deploy.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0353c33bb2013a73d59601222cc11bb2f3559685","unresolved":true,"context_lines":[{"line_number":6,"context_line":"- import_tasks: check-containers.yml"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: register.yml"},{"line_number":9,"context_line":"  when: enable_keystone | bool and elasticsearch_enable_keystone_registration | bool"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Flush handlers"},{"line_number":12,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"81006a37_23c4f8f2","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":30},"updated":"2021-02-23 10:13:38.000000000","message":"In a multi-region environment this may be false. In this case it might be better to assume keystone is in use if elasticsearch_enable_keystone_registration is true.","commit_id":"2196de56ebbd485a534870821f3a0919707dc3dc"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0128a112f7ac2f46b9e835da5789f523e268b6e0","unresolved":true,"context_lines":[{"line_number":6,"context_line":"- import_tasks: check-containers.yml"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: register.yml"},{"line_number":9,"context_line":"  when: enable_keystone | bool and elasticsearch_enable_keystone_registration | bool"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Flush handlers"},{"line_number":12,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a573e0d2_43c39803","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":30},"in_reply_to":"81006a37_23c4f8f2","updated":"2021-02-23 10:19:29.000000000","message":"Hmm, good point, you could have one Elastic cluster per region.","commit_id":"2196de56ebbd485a534870821f3a0919707dc3dc"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6bf8c1a681e77f624083320ffd154c00c1e19187","unresolved":false,"context_lines":[{"line_number":6,"context_line":"- import_tasks: check-containers.yml"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: register.yml"},{"line_number":9,"context_line":"  when: enable_keystone | bool and elasticsearch_enable_keystone_registration | bool"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Flush handlers"},{"line_number":12,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e6fa8d0e_257658c1","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":30},"in_reply_to":"a573e0d2_43c39803","updated":"2021-02-23 10:26:10.000000000","message":"Done","commit_id":"2196de56ebbd485a534870821f3a0919707dc3dc"}],"ansible/roles/elasticsearch/tasks/upgrade.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0353c33bb2013a73d59601222cc11bb2f3559685","unresolved":true,"context_lines":[{"line_number":57,"context_line":"- import_tasks: check-containers.yml"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- include_tasks: register.yml"},{"line_number":60,"context_line":"  when: enable_keystone | bool and elasticsearch_enable_keystone_registration | bool"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"- name: Flush handlers"},{"line_number":63,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a917ce6e_eb8e1da8","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":30},"updated":"2021-02-23 10:13:38.000000000","message":"ditto","commit_id":"2196de56ebbd485a534870821f3a0919707dc3dc"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6bf8c1a681e77f624083320ffd154c00c1e19187","unresolved":false,"context_lines":[{"line_number":57,"context_line":"- import_tasks: check-containers.yml"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- include_tasks: register.yml"},{"line_number":60,"context_line":"  when: enable_keystone | bool and elasticsearch_enable_keystone_registration | bool"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"- name: Flush handlers"},{"line_number":63,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4118bdb7_e63a4c33","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":30},"in_reply_to":"a917ce6e_eb8e1da8","updated":"2021-02-23 10:26:10.000000000","message":"Done","commit_id":"2196de56ebbd485a534870821f3a0919707dc3dc"}],"ansible/site.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5bc73983cc37d12ef969e552abbf55cc808e6a1f","unresolved":true,"context_lines":[{"line_number":547,"context_line":"        tags: keystone,"},{"line_number":548,"context_line":"        when: enable_keystone | bool }"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"- name: Apply role elasticsearch"},{"line_number":551,"context_line":"  gather_facts: false"},{"line_number":552,"context_line":"  hosts:"},{"line_number":553,"context_line":"    - elasticsearch"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c3c839b3_adfd524a","line":550,"updated":"2021-02-19 16:00:25.000000000","message":"I think we should not move the roles as we want to capture logs in elasticsearch already.\nBut we should postpone the registration, yes.","commit_id":"2196de56ebbd485a534870821f3a0919707dc3dc"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c59538d67b57e0708ff3213af01ba0119218f16f","unresolved":true,"context_lines":[{"line_number":547,"context_line":"        tags: keystone,"},{"line_number":548,"context_line":"        when: enable_keystone | bool }"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"- name: Apply role elasticsearch"},{"line_number":551,"context_line":"  gather_facts: false"},{"line_number":552,"context_line":"  hosts:"},{"line_number":553,"context_line":"    - elasticsearch"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cc122d5f_080795c4","line":550,"in_reply_to":"c3c839b3_adfd524a","updated":"2021-02-22 09:18:44.000000000","message":"Hmm, not sure I follow. I think the Fluentd output plugin should buffer the logs until Elastic is up, so this change means it will just come up a little later during deployment compared to before. I don\u0027t think that matters?","commit_id":"2196de56ebbd485a534870821f3a0919707dc3dc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7a45b13e7f65196db50bd8c5f5929d80ad08cfdc","unresolved":true,"context_lines":[{"line_number":547,"context_line":"        tags: keystone,"},{"line_number":548,"context_line":"        when: enable_keystone | bool }"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"- name: Apply role elasticsearch"},{"line_number":551,"context_line":"  gather_facts: false"},{"line_number":552,"context_line":"  hosts:"},{"line_number":553,"context_line":"    - elasticsearch"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3a50e4d6_cce67b32","line":550,"in_reply_to":"cc122d5f_080795c4","updated":"2021-03-24 17:52:30.000000000","message":"it\u0027s ok","commit_id":"2196de56ebbd485a534870821f3a0919707dc3dc"}]}
