)]}'
{"ansible/inventory/multinode":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"747f293fa6fff1ed07dfda25eb3e3239c9a88b96","unresolved":true,"context_lines":[{"line_number":754,"context_line":"control"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"[masakari-hostmonitor:children]"},{"line_number":757,"context_line":"control"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"[masakari-instancemonitor:children]"},{"line_number":760,"context_line":"compute"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"342020d8_f105ca6a","line":757,"range":{"start_line":757,"start_character":0,"end_line":757,"end_character":7},"updated":"2022-11-21 16:08:26.000000000","message":"I think this should be compute","commit_id":"db517a44e4bc9cbc9cdf402981e04b7cd7bacd7b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"059d7d6f2dbd6663590a7f07ed7d069f6b8cf6d0","unresolved":true,"context_lines":[{"line_number":754,"context_line":"control"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"[masakari-hostmonitor:children]"},{"line_number":757,"context_line":"control"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"[masakari-instancemonitor:children]"},{"line_number":760,"context_line":"compute"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"b1addaad_e96280e3","line":757,"range":{"start_line":757,"start_character":0,"end_line":757,"end_character":7},"in_reply_to":"342020d8_f105ca6a","updated":"2022-11-21 16:48:14.000000000","message":"No, it observes from the control plane using the Pacemaker core deployed there.","commit_id":"db517a44e4bc9cbc9cdf402981e04b7cd7bacd7b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"55aecc8d3381b15f8e1dd9597b937bf038ae4c8f","unresolved":false,"context_lines":[{"line_number":754,"context_line":"control"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"[masakari-hostmonitor:children]"},{"line_number":757,"context_line":"control"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"[masakari-instancemonitor:children]"},{"line_number":760,"context_line":"compute"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"c4e8fbd7_6d10d57e","line":757,"range":{"start_line":757,"start_character":0,"end_line":757,"end_character":7},"in_reply_to":"b1addaad_e96280e3","updated":"2022-11-21 16:53:17.000000000","message":"It\u0027s coming back to me. Originally it was supposed to be deployed on computes, but you changed it to deploy on controllers, to avoid notification storms. It makes sense.","commit_id":"db517a44e4bc9cbc9cdf402981e04b7cd7bacd7b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b45ab55f5c14e8d026278fd6ac2ff45c392de01d","unresolved":false,"context_lines":[{"line_number":754,"context_line":"control"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"[masakari-hostmonitor:children]"},{"line_number":757,"context_line":"control"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"[masakari-instancemonitor:children]"},{"line_number":760,"context_line":"compute"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"442d327a_865e2b74","line":757,"range":{"start_line":757,"start_character":0,"end_line":757,"end_character":7},"in_reply_to":"c4e8fbd7_6d10d57e","updated":"2022-11-21 17:02:03.000000000","message":"And increased RTT as they all would have to go to the core to get the answer.","commit_id":"db517a44e4bc9cbc9cdf402981e04b7cd7bacd7b"}],"ansible/roles/masakari/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c848c06df72013e95199537d764c12be22aa7070","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""},{"line_number":35,"context_line":"    volumes: \"{{ masakari_instancemonitor_default_volumes + masakari_instancemonitor_extra_volumes }}\""},{"line_number":36,"context_line":"    privileged: True"},{"line_number":37,"context_line":"    dimensions: \"{{ masakari_instancemonitor_dimensions }}\""},{"line_number":38,"context_line":"  masakari-hostmonitor:"},{"line_number":39,"context_line":"    container_name: masakari_hostmonitor"},{"line_number":40,"context_line":"    group: masakari-monitors"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"055f9c45_c4415512","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":56},"updated":"2021-03-14 20:07:45.000000000","message":"let\u0027s fix this in another patch","commit_id":"f1956d50faf763ecddd5893d85e4dc57c4ae8cda"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c848c06df72013e95199537d764c12be22aa7070","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    container_name: masakari_hostmonitor"},{"line_number":40,"context_line":"    group: masakari-monitors"},{"line_number":41,"context_line":"    enabled: true"},{"line_number":42,"context_line":"    ipc_mode: host"},{"line_number":43,"context_line":"    cap_add:"},{"line_number":44,"context_line":"      - NET_ADMIN"},{"line_number":45,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"125d5629_1ff4adea","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":18},"updated":"2021-03-14 20:07:45.000000000","message":"this will need to follow the hacluster patch","commit_id":"f1956d50faf763ecddd5893d85e4dc57c4ae8cda"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c848c06df72013e95199537d764c12be22aa7070","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    enabled: true"},{"line_number":42,"context_line":"    ipc_mode: host"},{"line_number":43,"context_line":"    cap_add:"},{"line_number":44,"context_line":"      - NET_ADMIN"},{"line_number":45,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""},{"line_number":46,"context_line":"    volumes: \"{{ masakari_hostmonitor_default_volumes + masakari_hostmonitor_extra_volumes }}\""},{"line_number":47,"context_line":"    dimensions: \"{{ masakari_hostmonitor_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3370d222_be32bf15","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":17},"updated":"2021-03-14 20:07:45.000000000","message":"we should not need this one, needs verification","commit_id":"f1956d50faf763ecddd5893d85e4dc57c4ae8cda"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c848c06df72013e95199537d764c12be22aa7070","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"masakari_api_dimensions: \"{{ default_container_dimensions }}\""},{"line_number":76,"context_line":"masakari_engine_dimensions: \"{{ default_container_dimensions }}\""},{"line_number":77,"context_line":"masakari_instancemonitor_dimensions: \"{{ default_container_dimensions }}\""},{"line_number":78,"context_line":"masakari_hostmonitor_dimensions: \"{{ default_container_dimensions }}\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"masakari_extra_volumes: \"{{ default_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ab62bee9_b314774f","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":73},"updated":"2021-03-14 20:07:45.000000000","message":"let\u0027s fix this in another patch (perhaps keeping the old name for compat)","commit_id":"f1956d50faf763ecddd5893d85e4dc57c4ae8cda"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c848c06df72013e95199537d764c12be22aa7070","unresolved":true,"context_lines":[{"line_number":101,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":102,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":103,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":104,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/masakari-monitors/masakarimonitors:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/masakarimonitors\u0027 if masakari_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":105,"context_line":"masakari_hostmonitor_default_volumes:"},{"line_number":106,"context_line":"  - \"{{ node_config_directory }}/masakari-hostmonitor/:{{ container_config_directory }}/:ro\""},{"line_number":107,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"14c25a5a_f3f005c7","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":204},"updated":"2021-03-14 20:07:45.000000000","message":"let\u0027s fix this in another patch","commit_id":"f1956d50faf763ecddd5893d85e4dc57c4ae8cda"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c848c06df72013e95199537d764c12be22aa7070","unresolved":true,"context_lines":[{"line_number":132,"context_line":"masakari_dev_mode: \"{{ kolla_dev_mode }}\""},{"line_number":133,"context_line":"masakari_source_version: \"{{ kolla_source_version }}\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"masakari_monitors_git_repository: \"{{ kolla_dev_repos_git }}/masakari-monitors\""},{"line_number":136,"context_line":"masakari_monitors_dev_repos_pull: \"{{ kolla_dev_repos_pull }}\""},{"line_number":137,"context_line":"masakari_monitors_dev_mode: \"{{ kolla_dev_mode }}\""},{"line_number":138,"context_line":"masakari_monitors_source_version: \"{{ kolla_source_version }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"82168a94_cfa15f91","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":79},"updated":"2021-03-14 20:07:45.000000000","message":"let\u0027s fix this in another patch","commit_id":"f1956d50faf763ecddd5893d85e4dc57c4ae8cda"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fabbe6f352df6705d236e131a2188d3a13893080","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    dimensions: \"{{ masakari_instancemonitor_dimensions }}\""},{"line_number":38,"context_line":"  masakari-hostmonitor:"},{"line_number":39,"context_line":"    container_name: masakari_hostmonitor"},{"line_number":40,"context_line":"    group: masakari-monitors"},{"line_number":41,"context_line":"    enabled: true"},{"line_number":42,"context_line":"    ipc_mode: host"},{"line_number":43,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b1c432ea_8cf1b1a1","line":40,"range":{"start_line":40,"start_character":11,"end_line":40,"end_character":28},"updated":"2021-04-07 18:41:07.000000000","message":"TODO: has to be tweaked - I recommend on controllers; the fewer, the better","commit_id":"37e329efbfdaff71bc2fa3cf8c0dde787326ed9e"}],"ansible/roles/masakari/tasks/clone.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c848c06df72013e95199537d764c12be22aa7070","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  become: true"},{"line_number":12,"context_line":"  git:"},{"line_number":13,"context_line":"    repo: \"{{ masakarimonitors_git_repository }}\""},{"line_number":14,"context_line":"    dest: \"{{ kolla_dev_repos_directory }}/masakari-monitors\""},{"line_number":15,"context_line":"    update: \"{{ masakarimonitors_dev_repos_pull }}\""},{"line_number":16,"context_line":"    version: \"{{ masakarimonitors_source_version }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1dfb5c95_0c360996","line":14,"updated":"2021-03-14 20:07:45.000000000","message":"let\u0027s fix this in another patch","commit_id":"f1956d50faf763ecddd5893d85e4dc57c4ae8cda"}],"ansible/roles/masakari/tasks/config.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c848c06df72013e95199537d764c12be22aa7070","unresolved":true,"context_lines":[{"line_number":62,"context_line":"  when:"},{"line_number":63,"context_line":"    - kolla_copy_ca_into_containers | bool"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: Copying over masakari.conf"},{"line_number":66,"context_line":"  vars:"},{"line_number":67,"context_line":"    service_name: \"{{ item }}\""},{"line_number":68,"context_line":"    service: \"{{ masakari_services[service_name] }}\""},{"line_number":69,"context_line":"  merge_configs:"},{"line_number":70,"context_line":"    sources:"},{"line_number":71,"context_line":"      - \"{{ role_path }}/templates/masakari.conf.j2\""},{"line_number":72,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":73,"context_line":"      - \"{{ node_custom_config }}/masakari.conf\""},{"line_number":74,"context_line":"      - \"{{ node_custom_config }}/masakari/{{ service_name }}.conf\""},{"line_number":75,"context_line":"      - \"{{ node_custom_config }}/masakari/{{ inventory_hostname }}/masakari.conf\""},{"line_number":76,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/masakari.conf\""},{"line_number":77,"context_line":"    mode: \"0660\""},{"line_number":78,"context_line":"  become: true"},{"line_number":79,"context_line":"  when:"},{"line_number":80,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":81,"context_line":"    - service.enabled | bool"},{"line_number":82,"context_line":"  with_items:"},{"line_number":83,"context_line":"    - masakari-api"},{"line_number":84,"context_line":"    - masakari-engine"},{"line_number":85,"context_line":"  notify:"},{"line_number":86,"context_line":"    - Restart {{ service_name }} container"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"- name: Copying over masakari-monitors.conf"},{"line_number":89,"context_line":"  vars:"},{"line_number":90,"context_line":"    service_name: \"{{ item }}\""},{"line_number":91,"context_line":"    service: \"{{ masakari_services[service_name] }}\""},{"line_number":92,"context_line":"  merge_configs:"},{"line_number":93,"context_line":"    sources:"},{"line_number":94,"context_line":"      - \"{{ role_path }}/templates/masakari-monitors.conf.j2\""},{"line_number":95,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":96,"context_line":"      - \"{{ node_custom_config }}/masakari/{{ service_name }}.conf\""},{"line_number":97,"context_line":"      - \"{{ node_custom_config }}/masakari/masakari-monitors.conf\""},{"line_number":98,"context_line":"      - \"{{ node_custom_config }}/masakari/{{ inventory_hostname }}/masakari-monitors.conf\""},{"line_number":99,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/masakari-monitors.conf\""},{"line_number":100,"context_line":"    mode: \"0660\""},{"line_number":101,"context_line":"  become: true"},{"line_number":102,"context_line":"  when:"},{"line_number":103,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":104,"context_line":"    - service.enabled | bool"},{"line_number":105,"context_line":"  with_items:"},{"line_number":106,"context_line":"    - masakari-instancemonitor"},{"line_number":107,"context_line":"    - masakari-hostmonitor"},{"line_number":108,"context_line":"  notify:"},{"line_number":109,"context_line":"    - Restart {{ service_name }} container"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"- name: Copying over wsgi-masakari file for services"},{"line_number":112,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"88306618_8fbe9669","line":109,"range":{"start_line":65,"start_character":0,"end_line":109,"end_character":42},"updated":"2021-03-14 20:07:45.000000000","message":"let\u0027s fix this in another patch","commit_id":"f1956d50faf763ecddd5893d85e4dc57c4ae8cda"}],"ansible/roles/masakari/templates/masakari-monitors.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"18d5294a40d710e4d0ca0745df961cbf61607462","unresolved":false,"context_lines":[{"line_number":14,"context_line":"api_interface \u003d internal"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% if service_name \u003d\u003d \u0027masakari-hostmonitor\u0027 %}"},{"line_number":17,"context_line":"[host]"},{"line_number":18,"context_line":"check_systemd \u003d False"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":"{% if service_name \u003d\u003d \u0027masakari-instancemonitor\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_40d41647","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":21},"updated":"2020-09-26 12:06:07.000000000","message":"I believe it\u0027s something you forgot to upstream...","commit_id":"f1956d50faf763ecddd5893d85e4dc57c4ae8cda"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1a8a4443af6530c10cb45583d11207cde3263dcd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"api_interface \u003d internal"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% if service_name \u003d\u003d \u0027masakari-hostmonitor\u0027 %}"},{"line_number":17,"context_line":"[host]"},{"line_number":18,"context_line":"check_systemd \u003d False"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":"{% if service_name \u003d\u003d \u0027masakari-instancemonitor\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_3770eb73","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":21},"in_reply_to":"9f560f44_40d41647","updated":"2020-10-02 15:31:43.000000000","message":"That\u0027s the kind of attention to detail I expect from a PTL. https://review.opendev.org/755827","commit_id":"f1956d50faf763ecddd5893d85e4dc57c4ae8cda"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1585e6c1887cba25977417b4bfc43a464a371b8c","unresolved":true,"context_lines":[{"line_number":21,"context_line":"{% if service_name \u003d\u003d \u0027masakari-hostmonitor\u0027 %}"},{"line_number":22,"context_line":"[host]"},{"line_number":23,"context_line":"{% if inventory_hostname in groups[\u0027hacluster\u0027] %}"},{"line_number":24,"context_line":"pacemaker_node_type \u003d cluster"},{"line_number":25,"context_line":"{% elif inventory_hostname in groups[\u0027hacluster-remote\u0027] %}"},{"line_number":26,"context_line":"pacemaker_node_type \u003d remote"},{"line_number":27,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"4777c4c4_64acb5dd","line":24,"updated":"2021-04-07 19:16:02.000000000","message":"need to provide the corosync params","commit_id":"37e329efbfdaff71bc2fa3cf8c0dde787326ed9e"}]}