)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7ad5b8688c80b3b874158e4aa5b5b3b4f8707fd1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change ssh-key to a variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A key with a name of \u0027_\u0027 cannot be created using Dashboard, but"},{"line_number":10,"context_line":"commands do."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie00d3d2437abd9b6e8ff9ef5e1d535139b0389f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_e53313f5","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":12},"updated":"2020-08-04 07:36:30.000000000","message":"I don\u0027t understand this part. You want to create a key named just with an underscore \"_\"? Why?","commit_id":"c2a830aa1cd28d15c3e3d1533f1f9b422d749b9f"},{"author":{"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"},"change_message_id":"abead6c85a92d31124417670a5eb2caa65e1467c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change ssh-key to a variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A key with a name of \u0027_\u0027 cannot be created using Dashboard, but"},{"line_number":10,"context_line":"commands do."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie00d3d2437abd9b6e8ff9ef5e1d535139b0389f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_455d9fe7","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":12},"in_reply_to":"9f560f44_e53313f5","updated":"2020-08-04 09:14:23.000000000","message":"I want to create the key named without an underscore \"_\", so I change it to a variable.","commit_id":"c2a830aa1cd28d15c3e3d1533f1f9b422d749b9f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c5848a2d45221b9ec1bb9d0b83aae8737c1f6d24","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mark Goddard \u003cmark@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-06 10:24:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change ssh-key to a variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change the octavia ssh key to a variable"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_ea0720c9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":28},"updated":"2020-08-07 07:52:08.000000000","message":"Nit: you could just use the second sentence which is more descriptive, and remove this one.","commit_id":"49f2182c233422b6d0841d871a0830909a198648"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7ad5b8688c80b3b874158e4aa5b5b3b4f8707fd1","unresolved":false,"context_lines":[{"line_number":947,"context_line":"octavia_amp_boot_network_list:"},{"line_number":948,"context_line":"octavia_amp_secgroup_list:"},{"line_number":949,"context_line":"octavia_amp_flavor_id:"},{"line_number":950,"context_line":"octavia_amp_ssh_key_name:"},{"line_number":951,"context_line":""},{"line_number":952,"context_line":"#################"},{"line_number":953,"context_line":"# Qinling options"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_052f278e","line":950,"range":{"start_line":950,"start_character":0,"end_line":950,"end_character":25},"updated":"2020-08-04 07:36:30.000000000","message":"Shouldn\u0027t you be setting this variable to \"octavia_ssh_key\"?","commit_id":"c2a830aa1cd28d15c3e3d1533f1f9b422d749b9f"},{"author":{"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"},"change_message_id":"abead6c85a92d31124417670a5eb2caa65e1467c","unresolved":false,"context_lines":[{"line_number":947,"context_line":"octavia_amp_boot_network_list:"},{"line_number":948,"context_line":"octavia_amp_secgroup_list:"},{"line_number":949,"context_line":"octavia_amp_flavor_id:"},{"line_number":950,"context_line":"octavia_amp_ssh_key_name:"},{"line_number":951,"context_line":""},{"line_number":952,"context_line":"#################"},{"line_number":953,"context_line":"# Qinling options"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_857cd71f","line":950,"range":{"start_line":950,"start_character":0,"end_line":950,"end_character":25},"in_reply_to":"9f560f44_052f278e","updated":"2020-08-04 09:14:23.000000000","message":"If I use the dashboard, I cannot create a key whose name contains \"_\".","commit_id":"c2a830aa1cd28d15c3e3d1533f1f9b422d749b9f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"749c0b06bc0aedf6d852763325629592d000b155","unresolved":false,"context_lines":[{"line_number":947,"context_line":"octavia_amp_boot_network_list:"},{"line_number":948,"context_line":"octavia_amp_secgroup_list:"},{"line_number":949,"context_line":"octavia_amp_flavor_id:"},{"line_number":950,"context_line":"octavia_amp_ssh_key_name:"},{"line_number":951,"context_line":""},{"line_number":952,"context_line":"#################"},{"line_number":953,"context_line":"# Qinling options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_f8057612","line":950,"range":{"start_line":950,"start_character":0,"end_line":950,"end_character":24},"updated":"2020-08-04 08:48:51.000000000","message":"Should default to octavia_ssh_key","commit_id":"d2fbc7dfd5f2fe634011df4c4d22e9aa6b3ffa1e"}],"ansible/roles/octavia/templates/octavia.conf.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7ad5b8688c80b3b874158e4aa5b5b3b4f8707fd1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"amp_image_tag \u003d amphora"},{"line_number":71,"context_line":"amp_secgroup_list \u003d {{ octavia_amp_secgroup_list }}"},{"line_number":72,"context_line":"amp_flavor_id \u003d {{ octavia_amp_flavor_id }}"},{"line_number":73,"context_line":"amp_ssh_key_name \u003d{{ octavia_amp_ssh_key_name }}"},{"line_number":74,"context_line":"client_ca \u003d /etc/octavia/certs/client_ca.cert.pem"},{"line_number":75,"context_line":"network_driver \u003d allowed_address_pairs_driver"},{"line_number":76,"context_line":"compute_driver \u003d compute_nova_driver"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_45259faa","line":73,"range":{"start_line":73,"start_character":18,"end_line":73,"end_character":19},"updated":"2020-08-04 07:36:30.000000000","message":"Missing space here","commit_id":"c2a830aa1cd28d15c3e3d1533f1f9b422d749b9f"}]}
