)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c3a02ef45968d79b815d2eb45bf02e45389ef54b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d574f598_7d32b349","updated":"2022-01-27 10:31:34.000000000","message":"something to revive I guess","commit_id":"52242f670e0ceba83a7a09edf2c9210312c7f3ef"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"96fbf7b9b8d512bd54919eeafbb9b24b3092baf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"3d98df06_f816a0dc","updated":"2022-01-27 10:41:33.000000000","message":"also need to consider https://review.opendev.org/c/openstack/kolla-ansible/+/797900 and https://review.opendev.org/c/openstack/kolla-ansible/+/780629","commit_id":"9ed6800d97f6664f6af4a8e764f4bae5836a8abd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b2fa5647040290ec7aa2127ade3ff2d44a881b2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"407e96e9_d9ba4b43","updated":"2022-02-09 09:30:32.000000000","message":"Updated to account for latest config, and added neutron-tls-proxy.","commit_id":"69e0fcab2f9673779c5a2f9a7335a1cc3979b54d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"edb0adc81cea5be7c54d674dca6553f2712e8f18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"79016e36_aec68c3d","updated":"2022-02-11 13:40:21.000000000","message":"ah, fresh air!","commit_id":"b97832dd4ffa5fba06c38afb44cce522dbafefdc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"90fb482495ca1dc4a356edffba8398d1fa67c52f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"2d8ceea4_129a94ac","updated":"2022-02-16 19:44:43.000000000","message":"it\u0027s worth more than fixing the little imperfections","commit_id":"b97832dd4ffa5fba06c38afb44cce522dbafefdc"}],"ansible/roles/common/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f6ff58ee841f539880f8742789cdd65fb76efc42","unresolved":false,"context_lines":[{"line_number":67,"context_line":"fluentd_tag: \"{{ common_tag }}\""},{"line_number":68,"context_line":"fluentd_image_full: \"{{ fluentd_image }}:{{ fluentd_tag }}\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"syslog_swift_facility: \"local0\""},{"line_number":71,"context_line":"syslog_haproxy_facility: \"local1\""},{"line_number":72,"context_line":"syslog_glance_tls_proxy_facility: \"local2\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"kolla_toolbox_default_volumes:"},{"line_number":75,"context_line":"  - \"{{ node_config_directory }}/kolla-toolbox/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_a45d7016","side":"PARENT","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":42},"updated":"2020-08-06 13:22:50.000000000","message":"better keep these for backwards compat, can reference them in the dict","commit_id":"644f74b185a8154d3eebba5a5708e317c35ac580"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f6ff58ee841f539880f8742789cdd65fb76efc42","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  haproxy: \"local1\""},{"line_number":73,"context_line":"  glance_tls_proxy: \"local2\""},{"line_number":74,"context_line":"  keepalived: \"local3\""},{"line_number":75,"context_line":"    "},{"line_number":76,"context_line":"kolla_toolbox_default_volumes:"},{"line_number":77,"context_line":"  - \"{{ node_config_directory }}/kolla-toolbox/:{{ container_config_directory }}/:ro\""},{"line_number":78,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_6467d8ea","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":4},"updated":"2020-08-06 13:22:50.000000000","message":"whitespace","commit_id":"58eb0bae62d7493130bbfa01919f45a0328a5370"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b6133fd0c29fe8ce28406e545a7c075df0bf8cb3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"syslog_keepalived_facility: \"local3\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"syslog_facilities:"},{"line_number":76,"context_line":"  swift: \"{{ syslog_swift_facility }}\""},{"line_number":77,"context_line":"  haproxy: \"{{ syslog_haproxy_facility }}\""},{"line_number":78,"context_line":"  glance_tls_proxy: \"{{ syslog_glance_tls_proxy_facility }}\""},{"line_number":79,"context_line":"  keepalived: \"{{ syslog_keepalived_facility }}\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"kolla_toolbox_default_volumes:"},{"line_number":82,"context_line":"  - \"{{ node_config_directory }}/kolla-toolbox/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_5edda540","line":79,"range":{"start_line":76,"start_character":2,"end_line":79,"end_character":48},"updated":"2020-08-18 18:49:23.000000000","message":"re: mgoddard\u0027s point - we could make it an array of objects with more arbitrary names; I doubt we would ever need to index it (and then we could do an absurdly quick search)","commit_id":"52036da55ce13d6ac1eaa2e55840394283bbb0fe"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"127a33bfdbbb940acc649049e63a7c0ed3a5b086","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    logfilematch: \"swift_latest.*.log\""},{"line_number":80,"context_line":"  haproxy:"},{"line_number":81,"context_line":"    facility: \"{{ syslog_haproxy_facility }}\""},{"line_number":82,"context_line":"    logdir: \"haproxy\" "},{"line_number":83,"context_line":"    logfilematch: \"haproxy_latest.*.log\""},{"line_number":84,"context_line":"  glance_tls_proxy:"},{"line_number":85,"context_line":"    facility: \"{{ syslog_glance_tls_proxy_facility }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_399b9464","line":82,"updated":"2020-09-21 08:37:53.000000000","message":"pep8","commit_id":"3457c9e88ca0cc00584a0a2c4016f7512712d595"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"43b07c519a8699db238161cd9e3c50f9ad4e384f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"syslog_swift_facility: \"local0\""},{"line_number":71,"context_line":"syslog_haproxy_facility: \"local1\""},{"line_number":72,"context_line":"syslog_glance_tls_proxy_facility: \"local2\""},{"line_number":73,"context_line":"syslog_keepalived_facility: \"local3\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"syslog_facilities:"},{"line_number":76,"context_line":"  swift:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9f560f44_e85f6d72","line":73,"range":{"start_line":73,"start_character":36,"end_line":73,"end_character":36},"updated":"2020-10-08 08:26:11.000000000","message":"Not yet!","commit_id":"39556b1c12bc8dceb521144dc30aae7649d70ba7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"43b07c519a8699db238161cd9e3c50f9ad4e384f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"syslog_glance_tls_proxy_facility: \"local2\""},{"line_number":73,"context_line":"syslog_keepalived_facility: \"local3\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"syslog_facilities:"},{"line_number":76,"context_line":"  swift:"},{"line_number":77,"context_line":"    enabled: \"{{ enable_swift | bool }}\""},{"line_number":78,"context_line":"    facility: \"{{ syslog_swift_facility }}\""},{"line_number":79,"context_line":"    logdir: \"swift\""},{"line_number":80,"context_line":"    logfilematch: \"swift_latest.*.log\""},{"line_number":81,"context_line":"  haproxy:"},{"line_number":82,"context_line":"    enabled: \"{{ enable_haproxy | bool }}\""},{"line_number":83,"context_line":"    facility: \"{{ syslog_haproxy_facility }}\""},{"line_number":84,"context_line":"    logdir: \"haproxy\""},{"line_number":85,"context_line":"    logfilematch: \"haproxy_latest.*.log\""},{"line_number":86,"context_line":"  glance_tls_proxy:"},{"line_number":87,"context_line":"    enabled: \"{{ glance_enable_tls_backend | bool }}\""},{"line_number":88,"context_line":"    facility: \"{{ syslog_glance_tls_proxy_facility }}\""},{"line_number":89,"context_line":"    logdir: \"glance-tls-proxy\""},{"line_number":90,"context_line":"    logfilematch: \"glance-tls-proxy.*.log\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"kolla_toolbox_default_volumes:"},{"line_number":93,"context_line":"  - \"{{ node_config_directory }}/kolla-toolbox/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9f560f44_4822d902","line":90,"range":{"start_line":75,"start_character":0,"end_line":90,"end_character":42},"updated":"2020-10-08 08:26:11.000000000","message":"Keys are never used - make it a list? With a list you can also do this:\n\nsyslog_facilities | selectattr(\u0027enabled\u0027)","commit_id":"39556b1c12bc8dceb521144dc30aae7649d70ba7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"07bab5bdb03583524ce80ee933464c3ff36c2a46","unresolved":false,"context_lines":[{"line_number":72,"context_line":"syslog_glance_tls_proxy_facility: \"local2\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"syslog_facilities:"},{"line_number":75,"context_line":"  - name: \"swift\""},{"line_number":76,"context_line":"    enabled: \"{{ enable_swift | bool }}\""},{"line_number":77,"context_line":"    facility: \"{{ syslog_swift_facility }}\""},{"line_number":78,"context_line":"    logdir: \"swift\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f560f44_9388a26b","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":17},"updated":"2020-10-08 08:51:07.000000000","message":"I don\u0027t see the name being used. Is it just decorative?","commit_id":"52242f670e0ceba83a7a09edf2c9210312c7f3ef"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"99354458753bf96a49a4b673dabe798a6ce68430","unresolved":false,"context_lines":[{"line_number":72,"context_line":"syslog_glance_tls_proxy_facility: \"local2\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"syslog_facilities:"},{"line_number":75,"context_line":"  - name: \"swift\""},{"line_number":76,"context_line":"    enabled: \"{{ enable_swift | bool }}\""},{"line_number":77,"context_line":"    facility: \"{{ syslog_swift_facility }}\""},{"line_number":78,"context_line":"    logdir: \"swift\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f560f44_b367a6b8","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":17},"in_reply_to":"9f560f44_9388a26b","updated":"2020-10-08 08:54:32.000000000","message":"I didn\u0027t feel having it without a name is self-explanatory, so yes - decorative. If that doesn\u0027t make any sense - I can remove it.","commit_id":"52242f670e0ceba83a7a09edf2c9210312c7f3ef"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"edb0adc81cea5be7c54d674dca6553f2712e8f18","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    facility: \"{{ syslog_swift_facility }}\""},{"line_number":78,"context_line":"    logdir: \"swift\""},{"line_number":79,"context_line":"    logfile: \"swift_latest\""},{"line_number":80,"context_line":"    output_tag: true"},{"line_number":81,"context_line":"    output_time: true"},{"line_number":82,"context_line":"  - name: \"haproxy\""},{"line_number":83,"context_line":"    enabled: \"{{ enable_haproxy | bool and inventory_hostname in groups[\u0027loadbalancer\u0027] }}\""},{"line_number":84,"context_line":"    facility: \"{{ syslog_haproxy_facility }}\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"279a306c_bf8ba75e","line":81,"range":{"start_line":80,"start_character":4,"end_line":81,"end_character":21},"updated":"2022-02-11 13:40:21.000000000","message":"btw, have you figured out why these are like this?","commit_id":"b97832dd4ffa5fba06c38afb44cce522dbafefdc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"95e3b2ad9c7eb53448d8f29e2513dac767218519","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    facility: \"{{ syslog_swift_facility }}\""},{"line_number":78,"context_line":"    logdir: \"swift\""},{"line_number":79,"context_line":"    logfile: \"swift_latest\""},{"line_number":80,"context_line":"    output_tag: true"},{"line_number":81,"context_line":"    output_time: true"},{"line_number":82,"context_line":"  - name: \"haproxy\""},{"line_number":83,"context_line":"    enabled: \"{{ enable_haproxy | bool and inventory_hostname in groups[\u0027loadbalancer\u0027] }}\""},{"line_number":84,"context_line":"    facility: \"{{ syslog_haproxy_facility }}\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"04deab78_efb4ab69","line":81,"range":{"start_line":80,"start_character":4,"end_line":81,"end_character":21},"in_reply_to":"279a306c_bf8ba75e","updated":"2022-02-11 14:05:17.000000000","message":"Swift logs don\u0027t include a timestamp","commit_id":"b97832dd4ffa5fba06c38afb44cce522dbafefdc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"edb0adc81cea5be7c54d674dca6553f2712e8f18","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    logdir: \"haproxy\""},{"line_number":86,"context_line":"    logfile: \"haproxy_latest\""},{"line_number":87,"context_line":"  - name: \"glance_tls_proxy\""},{"line_number":88,"context_line":"    enabled: \"{{ glance_enable_tls_backend | bool and inventory_hostname in groups[\u0027glance-api\u0027] }}\""},{"line_number":89,"context_line":"    facility: \"{{ syslog_glance_tls_proxy_facility }}\""},{"line_number":90,"context_line":"    logdir: \"glance-tls-proxy\""},{"line_number":91,"context_line":"    logfile: \"glance-tls-proxy\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ec80c9eb_194ab68f","line":88,"updated":"2022-02-11 13:40:21.000000000","message":"I smell a smuggled fix","commit_id":"b97832dd4ffa5fba06c38afb44cce522dbafefdc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"95e3b2ad9c7eb53448d8f29e2513dac767218519","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    logdir: \"haproxy\""},{"line_number":86,"context_line":"    logfile: \"haproxy_latest\""},{"line_number":87,"context_line":"  - name: \"glance_tls_proxy\""},{"line_number":88,"context_line":"    enabled: \"{{ glance_enable_tls_backend | bool and inventory_hostname in groups[\u0027glance-api\u0027] }}\""},{"line_number":89,"context_line":"    facility: \"{{ syslog_glance_tls_proxy_facility }}\""},{"line_number":90,"context_line":"    logdir: \"glance-tls-proxy\""},{"line_number":91,"context_line":"    logfile: \"glance-tls-proxy\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"4f642ca4_8566e89a","line":88,"in_reply_to":"ec80c9eb_194ab68f","updated":"2022-02-11 14:05:17.000000000","message":"A small one perhaps","commit_id":"b97832dd4ffa5fba06c38afb44cce522dbafefdc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"edb0adc81cea5be7c54d674dca6553f2712e8f18","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    logdir: \"glance-tls-proxy\""},{"line_number":91,"context_line":"    logfile: \"glance-tls-proxy\""},{"line_number":92,"context_line":"  - name: \"neutron_tls_proxy\""},{"line_number":93,"context_line":"    enabled: \"{{ neutron_enable_tls_backend | bool and inventory_hostname in groups[\u0027neutron-server\u0027] }}\""},{"line_number":94,"context_line":"    facility: \"{{ syslog_neutron_tls_proxy_facility }}\""},{"line_number":95,"context_line":"    logdir: \"neutron-tls-proxy\""},{"line_number":96,"context_line":"    logfile: \"neutron-tls-proxy\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"47d2d506_1e78e026","line":93,"updated":"2022-02-11 13:40:21.000000000","message":"ditto","commit_id":"b97832dd4ffa5fba06c38afb44cce522dbafefdc"}],"ansible/roles/common/templates/conf/filter/00-record_transformer.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"edb0adc81cea5be7c54d674dca6553f2712e8f18","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    \u003c/record\u003e"},{"line_number":23,"context_line":"\u003c/filter\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"\u003cfilter syslog.local0.**\u003e"},{"line_number":26,"context_line":"    @type record_transformer"},{"line_number":27,"context_line":"    \u003crecord\u003e"},{"line_number":28,"context_line":"        programname swift"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"47f14989_4e494631","side":"PARENT","line":25,"range":{"start_line":25,"start_character":15,"end_line":25,"end_character":21},"updated":"2022-02-11 13:40:21.000000000","message":"I smell a smuggled fix","commit_id":"654edefca3061a9e61183544f71bc41ab7a61600"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"edb0adc81cea5be7c54d674dca6553f2712e8f18","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    \u003c/record\u003e"},{"line_number":30,"context_line":"\u003c/filter\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"\u003cfilter syslog.local1.**\u003e"},{"line_number":33,"context_line":"    @type record_transformer"},{"line_number":34,"context_line":"    \u003crecord\u003e"},{"line_number":35,"context_line":"        programname haproxy"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"d65ceed6_8d59b469","side":"PARENT","line":32,"range":{"start_line":32,"start_character":15,"end_line":32,"end_character":21},"updated":"2022-02-11 13:40:21.000000000","message":"ditto","commit_id":"654edefca3061a9e61183544f71bc41ab7a61600"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"edb0adc81cea5be7c54d674dca6553f2712e8f18","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    \u003c/record\u003e"},{"line_number":23,"context_line":"\u003c/filter\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% for item in syslog_facilities | selectattr(\u0027enabled\u0027) %}"},{"line_number":26,"context_line":"\u003cfilter syslog.{{ item.facility }}.**\u003e"},{"line_number":27,"context_line":"    @type record_transformer"},{"line_number":28,"context_line":"    \u003crecord\u003e"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"2c503ebb_a28ea862","line":25,"range":{"start_line":25,"start_character":15,"end_line":25,"end_character":56},"updated":"2022-02-11 13:40:21.000000000","message":"it\u0027s used 3 times, let\u0027s make it syslog_enable_facilitied or similar","commit_id":"b97832dd4ffa5fba06c38afb44cce522dbafefdc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"95e3b2ad9c7eb53448d8f29e2513dac767218519","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    \u003c/record\u003e"},{"line_number":23,"context_line":"\u003c/filter\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% for item in syslog_facilities | selectattr(\u0027enabled\u0027) %}"},{"line_number":26,"context_line":"\u003cfilter syslog.{{ item.facility }}.**\u003e"},{"line_number":27,"context_line":"    @type record_transformer"},{"line_number":28,"context_line":"    \u003crecord\u003e"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"5d3324a3_9bc6988b","line":25,"range":{"start_line":25,"start_character":15,"end_line":25,"end_character":56},"in_reply_to":"2c503ebb_a28ea862","updated":"2022-02-11 14:05:17.000000000","message":"I\u0027m not sure we\u0027d save on characters overall","commit_id":"b97832dd4ffa5fba06c38afb44cce522dbafefdc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8d23076239f18d81278f739a0d509f7795d1a64e","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    \u003c/record\u003e"},{"line_number":23,"context_line":"\u003c/filter\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% for item in syslog_facilities | selectattr(\u0027enabled\u0027) %}"},{"line_number":26,"context_line":"\u003cfilter syslog.{{ item.facility }}.**\u003e"},{"line_number":27,"context_line":"    @type record_transformer"},{"line_number":28,"context_line":"    \u003crecord\u003e"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"28f30fa1_69e0e65f","line":25,"range":{"start_line":25,"start_character":15,"end_line":25,"end_character":56},"in_reply_to":"5d3324a3_9bc6988b","updated":"2022-02-11 14:12:45.000000000","message":"I was thinking about saving on mistakes but mayhaps I\u0027m overcautious.","commit_id":"b97832dd4ffa5fba06c38afb44cce522dbafefdc"}],"ansible/roles/common/templates/conf/output/00-local.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fd2c5559c05e5a7be1a876339fc1b052302b14f7","unresolved":false,"context_lines":[{"line_number":179,"context_line":"{% endif %}"},{"line_number":180,"context_line":"\u003c/match\u003e"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"\u003cmatch syslog.{{ syslog_keepalived_facility }}.**\u003e"},{"line_number":183,"context_line":"  @type copy"},{"line_number":184,"context_line":"  \u003cstore\u003e"},{"line_number":185,"context_line":"    @type file"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_09d6f528","line":182,"updated":"2020-08-06 12:37:44.000000000","message":"I feel we\u0027re at the point where this should be a loop","commit_id":"1508479b66e7962ea328b36de31ca830d8e2a5e0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f6ff58ee841f539880f8742789cdd65fb76efc42","unresolved":false,"context_lines":[{"line_number":57,"context_line":"     \u003c/buffer\u003e"},{"line_number":58,"context_line":"  \u003c/store\u003e"},{"line_number":59,"context_line":"{% endif %}"},{"line_number":60,"context_line":"\u003c/match\u003e"},{"line_number":61,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_84b14c4a","line":60,"updated":"2020-08-06 13:22:50.000000000","message":"newline?","commit_id":"58eb0bae62d7493130bbfa01919f45a0328a5370"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c4bc28a728ec0164f0f6b0ef1d38912f7e4111b8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  @type copy"},{"line_number":4,"context_line":"  \u003cstore\u003e"},{"line_number":5,"context_line":"    @type file"},{"line_number":6,"context_line":"    path /var/log/kolla/{{ key }}/{{ key }}_latest.*.log"},{"line_number":7,"context_line":"    append true"},{"line_number":8,"context_line":"    compress gzip"},{"line_number":9,"context_line":"    \u003cbuffer\u003e"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9f560f44_7df461f1","line":6,"range":{"start_line":6,"start_character":27,"end_line":6,"end_character":30},"updated":"2020-08-10 09:25:05.000000000","message":"I suppose this would change the glance-tls-proxy directory to glance_tls_proxy. There was already discussion about changing it to just glance.","commit_id":"52036da55ce13d6ac1eaa2e55840394283bbb0fe"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"811a2b45d34090abdfb671446f8f13b5ca1b01f4","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    \u003cbuffer []\u003e"},{"line_number":73,"context_line":"      path /var/log/kolla/haproxy/haproxy_latest.*.buffer"},{"line_number":74,"context_line":"    \u003c/buffer\u003e"},{"line_number":75,"context_line":"    # Don\u0027t prepend syslog tag or timestamp to log output"},{"line_number":76,"context_line":"    \u003cformat\u003e"},{"line_number":77,"context_line":"      output_tag false"},{"line_number":78,"context_line":"      output_time false"},{"line_number":79,"context_line":"    \u003c/format\u003e"},{"line_number":80,"context_line":"  \u003c/store\u003e"},{"line_number":81,"context_line":"{% if log_direct_to_elasticsearch %}"},{"line_number":82,"context_line":"  \u003cstore\u003e"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"97bb3302_952a7e03","side":"PARENT","line":79,"range":{"start_line":75,"start_character":0,"end_line":79,"end_character":13},"updated":"2022-02-11 09:50:08.000000000","message":"Seems we lose this bit. Unsure how I missed that, as I diffed the different configs.","commit_id":"654edefca3061a9e61183544f71bc41ab7a61600"}],"ansible/roles/common/templates/fluentd.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"811a2b45d34090abdfb671446f8f13b5ca1b01f4","unresolved":true,"context_lines":[{"line_number":19,"context_line":"            \"owner\": \"{{ fluentd_user }}:{{ fluentd_user }}\","},{"line_number":20,"context_line":"            \"recurse\": true"},{"line_number":21,"context_line":"        },"},{"line_number":22,"context_line":"{% if enable_haproxy | bool and inventory_hostname in groups[\u0027loadbalancer\u0027] %}"},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"path\": \"/var/log/kolla/haproxy\","},{"line_number":25,"context_line":"            \"owner\": \"{{ fluentd_user }}:{{ fluentd_user }}\","},{"line_number":26,"context_line":"            \"recurse\": true"},{"line_number":27,"context_line":"        },"},{"line_number":28,"context_line":"{% endif %}"},{"line_number":29,"context_line":"{% if glance_enable_tls_backend | bool %}"},{"line_number":30,"context_line":"        {"},{"line_number":31,"context_line":"            \"path\": \"/var/log/kolla/glance-tls-proxy\","},{"line_number":32,"context_line":"            \"owner\": \"{{ fluentd_user }}:{{ fluentd_user }}\","},{"line_number":33,"context_line":"            \"recurse\": true"},{"line_number":34,"context_line":"        },"},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":"{% if neutron_enable_tls_backend | bool %}"},{"line_number":37,"context_line":"        {"},{"line_number":38,"context_line":"            \"path\": \"/var/log/kolla/neutron-tls-proxy\","},{"line_number":39,"context_line":"            \"owner\": \"{{ fluentd_user }}:{{ fluentd_user }}\","},{"line_number":40,"context_line":"            \"recurse\": true"},{"line_number":41,"context_line":"        },"},{"line_number":42,"context_line":"{% endif %}"},{"line_number":43,"context_line":"{% if enable_swift | bool and (inventory_hostname in groups[\u0027swift-proxy-server\u0027] or inventory_hostname in groups[\u0027swift-account-server\u0027] or inventory_hostname in groups[\u0027swift-container-server\u0027] or inventory_hostname in groups[\u0027swift-object-server\u0027]) %}"},{"line_number":44,"context_line":"        {"},{"line_number":45,"context_line":"            \"path\": \"/var/log/kolla/swift\","},{"line_number":46,"context_line":"            \"owner\": \"{{ fluentd_user }}:{{ fluentd_user }}\","},{"line_number":47,"context_line":"            \"recurse\": true"},{"line_number":48,"context_line":"        },"},{"line_number":49,"context_line":"{% endif %}"},{"line_number":50,"context_line":"        {"},{"line_number":51,"context_line":"            \"path\": \"/var/lib/fluentd/data\","},{"line_number":52,"context_line":"            \"owner\": \"{{ fluentd_user }}:{{ fluentd_user }}\","}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"6b00506d_2943145e","line":49,"range":{"start_line":22,"start_character":0,"end_line":49,"end_character":11},"updated":"2022-02-11 09:50:08.000000000","message":"We should handle this too.","commit_id":"69e0fcab2f9673779c5a2f9a7335a1cc3979b54d"}],"ansible/roles/haproxy/templates/keepalived.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fd2c5559c05e5a7be1a876339fc1b052302b14f7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/sbin/keepalived -nd -S 3 -p /run/keepalived.pid\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/keepalived.conf\","}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_49dc6d45","line":2,"range":{"start_line":2,"start_character":44,"end_line":2,"end_character":45},"updated":"2020-08-06 12:37:44.000000000","message":"syslog_keepalived_facility","commit_id":"1508479b66e7962ea328b36de31ca830d8e2a5e0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f6ff58ee841f539880f8742789cdd65fb76efc42","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/sbin/keepalived -nd -S {{ syslog_facilities[\u0027keepalived\u0027] | upper }} -p /run/keepalived.pid\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/keepalived.conf\","}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_a4b29047","line":2,"range":{"start_line":2,"start_character":47,"end_line":2,"end_character":64},"updated":"2020-08-06 13:22:50.000000000","message":"syslog_keepalived_facility","commit_id":"58eb0bae62d7493130bbfa01919f45a0328a5370"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4f1556bdaee7e13ee5bbfcd1673df2ecc0e0cdde","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/sbin/keepalived -nd -l -S {{ syslog_keepalived_facility[-1] }} -p /run/keepalived.pid\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/keepalived.conf\","}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"9f560f44_2dacd786","line":2,"range":{"start_line":2,"start_character":41,"end_line":2,"end_character":43},"updated":"2020-10-08 07:11:36.000000000","message":"should probably be dropped to avoid confusion","commit_id":"7c2ff486d8333281f920536851227e664befc677"}]}