)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"012eaa9e137eedd6fdf0703976933529b16d3760","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     wu.chunyang \u003cwuchunyang@yovole.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-11-29 18:17:26 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add  prepare task  for octavia upgrade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"in victoria cycle, we add support for octavia to register"},{"line_number":10,"context_line":"resources."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"58b7dc49_6ca5b681","line":7,"updated":"2020-12-17 11:07:10.000000000","message":"comment needs updating","commit_id":"63514ace25c1a2b9056e577302afd2fb3dd12d84"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c7216b881cbd186d6449f05b6aa1d8f05d72a74b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2e71921e_29c72415","updated":"2021-12-20 12:12:25.000000000","message":"\u003e Patch Set 13:\n\u003e \n\u003e \u003e Patch Set 13:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 13:\n\u003e \u003e \u003e \n\u003e \u003e \u003e \u003e Patch Set 13:\n\u003e \u003e \u003e \u003e \n\u003e \u003e \u003e \u003e This is broken on the victoria branch as well. Why was this marked as backport -2? Seems like it would work there too.\n\u003e \u003e \u003e \n\u003e \u003e \u003e we support octavia_auto_configure from victoria, so if you upgrade from \"U\", you should disable octavia_auto_configure, those tasks only used for getting resource info for octavia which deployed by octavia_auto_configure。 so， those tasks should be in the next of \u0027victoria\u0027 branch, which is \u0027w\u0027 branch\n\u003e \u003e \n\u003e \u003e I think this series of steps will produce the error on victoria:\n\u003e \u003e \n\u003e \u003e   - deploy victoria\n\u003e \u003e   - enable octavia with autoconfigure\n\u003e \u003e   - upgrade to newer version of victoria\n\u003e \u003e \n\u003e \u003e What do you think?\n\u003e yes, but i think upgrade action should be used like \u0027U\u0027 -\u003e \u0027V\u0027, or victory -\u003e wallaby.  if you want to upgrade to newer victoria, why not use deploy action ?\n\nAgreed - use deploy for minor upgrades.","commit_id":"7f7bb1b44816a13748e3e87f72722e0dcb940fe0"}],"ansible/roles/octavia/tasks/get_resources_info.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"682ceae5757b70fb1e8c69bdc61f8dbf9be01aef","unresolved":true,"context_lines":[{"line_number":47,"context_line":"  run_once: True"},{"line_number":48,"context_line":"  delegate_to: \"{{ groups[\u0027octavia-api\u0027][0] }}\""},{"line_number":49,"context_line":"  register: sec_grp_info"},{"line_number":50,"context_line":"  failed_when: sec_grp_info.changed | bool"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Get loadbalancer management network"},{"line_number":53,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"05ae8d25_a2c1d6b0","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":42},"updated":"2021-01-05 10:47:06.000000000","message":"I don\u0027t think there is anything to change, unless the group does not exist.","commit_id":"39f2d49a208344419f23a5d77c441a5cf29d18a8"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"f756b8e75f93fbee79faad1a85f2dadedb8a2ff9","unresolved":true,"context_lines":[{"line_number":47,"context_line":"  run_once: True"},{"line_number":48,"context_line":"  delegate_to: \"{{ groups[\u0027octavia-api\u0027][0] }}\""},{"line_number":49,"context_line":"  register: sec_grp_info"},{"line_number":50,"context_line":"  failed_when: sec_grp_info.changed | bool"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Get loadbalancer management network"},{"line_number":53,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"770c7659_c5cea548","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":42},"in_reply_to":"05ae8d25_a2c1d6b0","updated":"2021-01-07 15:49:13.000000000","message":"i was afraid that the security_group was changed by someone with openstack client before. so this action will undo the change.  but it seems there is nothing need to change with security_group. we can remove failed_when condition now","commit_id":"39f2d49a208344419f23a5d77c441a5cf29d18a8"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3cc9e0cc65f56cc373174d1bde595573786a3f85","unresolved":true,"context_lines":[{"line_number":64,"context_line":"- name: Set octavia resources facts"},{"line_number":65,"context_line":"  set_fact:"},{"line_number":66,"context_line":"    network_info: \"{{ network_results.openstack_networks.0 }}\""},{"line_number":67,"context_line":"    amphora_flavor_info: \"{{ flavor_results.openstack_flavors }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"0c9bf492_8fc9b897","line":67,"range":{"start_line":67,"start_character":4,"end_line":67,"end_character":65},"updated":"2021-01-07 16:20:33.000000000","message":"If you set it like this, the config file can be the same for deploy \u0026 upgrade:\n\n  amphora_flavor_info:\n    flavor: \"{{ flavor_results.openstack_flavors.0 }}\"","commit_id":"5b3de266536142b250118193c52dd1539cd837b5"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"a71d332114451f09b7c33d0526793820acb2293f","unresolved":true,"context_lines":[{"line_number":64,"context_line":"- name: Set octavia resources facts"},{"line_number":65,"context_line":"  set_fact:"},{"line_number":66,"context_line":"    network_info: \"{{ network_results.openstack_networks.0 }}\""},{"line_number":67,"context_line":"    amphora_flavor_info: \"{{ flavor_results.openstack_flavors }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"6a57d8ae_db71b9d5","line":67,"range":{"start_line":67,"start_character":4,"end_line":67,"end_character":65},"in_reply_to":"0c9bf492_8fc9b897","updated":"2021-01-09 10:19:32.000000000","message":"yes,good idea. for deploy action:\n\nok: [localhost] \u003d\u003e {\n    \"msg\": {\n        \"action\": \"os_nova_flavor\",\n        \"changed\": false,\n        \"failed\": false,\n        \"flavor\": {\n            \"OS-FLV-DISABLED:disabled\": false,\n            \"OS-FLV-EXT-DATA:ephemeral\": 0,\n            \"disk\": 5,\n            \"ephemeral\": 0,\n            \"extra_specs\": {},\n            \"id\": \"952bf932-beb8-494e-94ef-f4e6aa43beca\",\n            \"is_disabled\": false,\n            \"is_public\": false,\n            \"location\": {\n                \"cloud\": \"defaults\",\n                \"project\": {\n                    \"domain_id\": null,\n                    \"domain_name\": \"Default\",\n                    \"id\": \"f7cf257a37844d28a2eea769afeb6ae4\",\n                    \"name\": \"service\"\n                },\n                \"region_name\": \"RegionOne\",\n                \"zone\": null\n            },\n            \"name\": \"amphora\",\n            \"os-flavor-access:is_public\": false,\n            \"properties\": {\n                \"OS-FLV-DISABLED:disabled\": false,\n                \"OS-FLV-EXT-DATA:ephemeral\": 0,\n                \"os-flavor-access:is_public\": false\n            },\n            \"ram\": 1024,\n            \"rxtx_factor\": 1.0,\n            \"swap\": 0,\n            \"vcpus\": 1\n        },\n        \"id\": \"952bf932-beb8-494e-94ef-f4e6aa43beca\"\n    }\n}\n\nwe can get id from msg.id. not msg.flavor.id.","commit_id":"5b3de266536142b250118193c52dd1539cd837b5"}],"ansible/roles/octavia/templates/octavia.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d8161828364593cd049fdb1a6cf9e3567bb58869","unresolved":true,"context_lines":[{"line_number":72,"context_line":"amp_ssh_key_name \u003d {{ octavia_amp_ssh_key_name }}"},{"line_number":73,"context_line":"amp_image_tag \u003d {{ octavia_amp_image_tag }}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% if not octavia_auto_configure | bool %}"},{"line_number":76,"context_line":"{% if octavia_amp_image_owner_id is defined %}"},{"line_number":77,"context_line":"amp_image_owner_id \u003d {{ octavia_amp_image_owner_id }}"},{"line_number":78,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"d89b794a_e9dddd47","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":42},"updated":"2020-12-17 11:06:49.000000000","message":"hmm, this isn\u0027t how I remember it. It breaks kolla-ansible genconfig.","commit_id":"63514ace25c1a2b9056e577302afd2fb3dd12d84"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d8161828364593cd049fdb1a6cf9e3567bb58869","unresolved":true,"context_lines":[{"line_number":89,"context_line":"amp_image_owner_id \u003d {{ project_info.openstack_projects.0.id }}"},{"line_number":90,"context_line":"amp_boot_network_list \u003d {{ network_info.id }}"},{"line_number":91,"context_line":"amp_secgroup_list \u003d {{ (sec_grp_info.results | selectattr(\u0027secgroup.name\u0027, \u0027equalto\u0027, octavia_amp_security_groups[\u0027mgmt-sec-grp\u0027].name) | list).0.secgroup.id }}"},{"line_number":92,"context_line":"{# ansible os_flavor_info module and os_nova_flavor module return different data struct #}"},{"line_number":93,"context_line":"amp_flavor_id \u003d {{ amphora_flavor_info.flavor.id if kolla_action \u003d\u003d \u0027deploy\u0027 else amphora_flavor_info.0.id }}"},{"line_number":94,"context_line":"{% endif %}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"client_ca \u003d /etc/octavia/certs/client_ca.cert.pem"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"4e1d1f4b_097f46ac","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":109},"updated":"2020-12-17 11:06:49.000000000","message":"deploy or reconfigure. Better to reverse the logic, use if action \u003d\u003d \u0027upgrade\u0027.","commit_id":"63514ace25c1a2b9056e577302afd2fb3dd12d84"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"25733b6ad077e56e272a7b8a9e547d77aad6f96f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"amp_image_owner_id \u003d {{ project_info.openstack_projects.0.id }}"},{"line_number":90,"context_line":"amp_boot_network_list \u003d {{ network_info.id }}"},{"line_number":91,"context_line":"amp_secgroup_list \u003d {{ (sec_grp_info.results | selectattr(\u0027secgroup.name\u0027, \u0027equalto\u0027, octavia_amp_security_groups[\u0027mgmt-sec-grp\u0027].name) | list).0.secgroup.id }}"},{"line_number":92,"context_line":"{# ansible os_flavor_info module and os_nova_flavor module return different data struct #}"},{"line_number":93,"context_line":"amp_flavor_id \u003d {{ amphora_flavor_info.flavor.id if kolla_action \u003d\u003d \u0027deploy\u0027 else amphora_flavor_info.0.id }}"},{"line_number":94,"context_line":"{% endif %}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"client_ca \u003d /etc/octavia/certs/client_ca.cert.pem"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"a6154986_ae99db3d","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":109},"in_reply_to":"4e1d1f4b_097f46ac","updated":"2020-12-18 10:24:39.000000000","message":"Ack","commit_id":"63514ace25c1a2b9056e577302afd2fb3dd12d84"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"f45d466de032d503731f0e0e8461daa2e0bd6107","unresolved":true,"context_lines":[{"line_number":72,"context_line":"amp_ssh_key_name \u003d {{ octavia_amp_ssh_key_name }}"},{"line_number":73,"context_line":"amp_image_tag \u003d {{ octavia_amp_image_tag }}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% if not octavia_auto_configure | bool or kolla_action \u003d\u003d \u0027config\u0027 %}"},{"line_number":76,"context_line":"{% if octavia_amp_image_owner_id is defined %}"},{"line_number":77,"context_line":"amp_image_owner_id \u003d {{ octavia_amp_image_owner_id }}"},{"line_number":78,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"02e20623_7700343c","line":75,"updated":"2020-12-22 14:31:21.000000000","message":"kolla genconfig action may changes the octaiva.conf after deploy, so maybe we need a know issue. \nwe can add resources id to global.yml (or /etc/kolla/config/octavia.conf) after deploy, and then we set octavia_auto_configure to false. but this seems is out of the scope of kolla. Add to docs may be more suitable.\notherwise kolla genconfig may not generate config file properly.","commit_id":"39f2d49a208344419f23a5d77c441a5cf29d18a8"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"682ceae5757b70fb1e8c69bdc61f8dbf9be01aef","unresolved":true,"context_lines":[{"line_number":72,"context_line":"amp_ssh_key_name \u003d {{ octavia_amp_ssh_key_name }}"},{"line_number":73,"context_line":"amp_image_tag \u003d {{ octavia_amp_image_tag }}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% if not octavia_auto_configure | bool or kolla_action \u003d\u003d \u0027config\u0027 %}"},{"line_number":76,"context_line":"{% if octavia_amp_image_owner_id is defined %}"},{"line_number":77,"context_line":"amp_image_owner_id \u003d {{ octavia_amp_image_owner_id }}"},{"line_number":78,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3ab964a2_17b750c0","line":75,"in_reply_to":"02e20623_7700343c","updated":"2021-01-05 10:47:06.000000000","message":"I would suggest we address genconfig in a separate patch.","commit_id":"39f2d49a208344419f23a5d77c441a5cf29d18a8"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"f756b8e75f93fbee79faad1a85f2dadedb8a2ff9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"amp_ssh_key_name \u003d {{ octavia_amp_ssh_key_name }}"},{"line_number":73,"context_line":"amp_image_tag \u003d {{ octavia_amp_image_tag }}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% if not octavia_auto_configure | bool or kolla_action \u003d\u003d \u0027config\u0027 %}"},{"line_number":76,"context_line":"{% if octavia_amp_image_owner_id is defined %}"},{"line_number":77,"context_line":"amp_image_owner_id \u003d {{ octavia_amp_image_owner_id }}"},{"line_number":78,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"773a715a_50e797b1","line":75,"in_reply_to":"3ab964a2_17b750c0","updated":"2021-01-07 15:49:13.000000000","message":"Done","commit_id":"39f2d49a208344419f23a5d77c441a5cf29d18a8"}]}