)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cd84be460a905ee2b3d5ff3ee0b2634094f088e3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lijiaping \u003clijiaping@yovole.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-14 22:18:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use api_interface_address replace default bgp_router_id, because if"},{"line_number":8,"context_line":"has more than one neutron_bgp_dragent, user can choice which agent to"},{"line_number":9,"context_line":"bind to the bgp speaker, so each neutron_bgp_dragent should has unique"},{"line_number":10,"context_line":"bgp_router_id"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id5d7d202f6313d7cb757a7a8d95a1e697317d257"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_f64879b4","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":13},"updated":"2020-09-14 14:32:17.000000000","message":"please rewrite it, so first line has a short overview and more details are in next line(s)","commit_id":"65d4c73571bee103a51991eae1f8e443aa93e271"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"fbf0167a9c8b2826896bc03a848061abcd85da65","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lijiaping \u003clijiaping@yovole.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-14 23:03:52 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use api_interface_address replace default 1.1.1.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If has more than one neutron_bgp_dragent, user can choice which agent to"},{"line_number":10,"context_line":"bind to the bgp speaker, so each neutron_bgp_dragent should has unique"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_749101f8","line":7,"updated":"2020-09-14 15:27:59.000000000","message":"Your commit message is not related to the changes, could you please amend it properly?","commit_id":"afd7a19d8d829a603d7719f6b28984a3dbe3345a"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"14d456c10dbd8dbdc4cb34caeb1115b712a841dd","unresolved":false,"context_lines":[{"line_number":913,"context_line":"#######################"},{"line_number":914,"context_line":"# Neutron options"},{"line_number":915,"context_line":"#######################"},{"line_number":916,"context_line":"neutron_bgp_router_id: \"1.1.1.1\""},{"line_number":917,"context_line":"neutron_bridge_name: \"{{ \u0027br-dvs\u0027 if neutron_plugin_agent \u003d\u003d \u0027vmware_dvs\u0027 else \u0027br-ex\u0027 }}\""},{"line_number":918,"context_line":"# Comma-separated type of enabled ml2 type drivers"},{"line_number":919,"context_line":"neutron_type_drivers: \"flat,vlan,vxlan{% if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 %},geneve{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_1453653b","side":"PARENT","line":916,"updated":"2020-09-14 15:32:09.000000000","message":"This variable shouldn\u0027t be erased, it\u0027s a default variable that you can override on your host_vars/group_vars or even on the globals.yml and inline within the inventory.","commit_id":"b49c86848dcd8d256e54d424d917a3b3b94d2d2c"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"eb31f003da2bf47fddf531230cf47c9029c4ee39","unresolved":false,"context_lines":[{"line_number":913,"context_line":"#######################"},{"line_number":914,"context_line":"# Neutron options"},{"line_number":915,"context_line":"#######################"},{"line_number":916,"context_line":"neutron_bgp_router_id: \"1.1.1.1\""},{"line_number":917,"context_line":"neutron_bridge_name: \"{{ \u0027br-dvs\u0027 if neutron_plugin_agent \u003d\u003d \u0027vmware_dvs\u0027 else \u0027br-ex\u0027 }}\""},{"line_number":918,"context_line":"# Comma-separated type of enabled ml2 type drivers"},{"line_number":919,"context_line":"neutron_type_drivers: \"flat,vlan,vxlan{% if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 %},geneve{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_ba8b5766","side":"PARENT","line":916,"updated":"2020-09-16 14:54:51.000000000","message":"Additionally to my previous comment. One thing that could work would be to use a range of \u0027ID\u0027 instead of a String by default and let the playbook found about how many ID does it need.\n\nIf it need one, it take the first and then iterate over the more it needs.","commit_id":"b49c86848dcd8d256e54d424d917a3b3b94d2d2c"}],"ansible/roles/neutron/templates/bgp_dragent.ini.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cd84be460a905ee2b3d5ff3ee0b2634094f088e3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[BGP]"},{"line_number":2,"context_line":"bgp_speaker_driver \u003d neutron_dynamic_routing.services.bgp.agent.driver.os_ken.driver.OsKenBgpDriver"},{"line_number":3,"context_line":"bgp_router_id \u003d {{ api_interface_address }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_76d2a9d3","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":43},"updated":"2020-09-14 14:32:17.000000000","message":"I think it was better to leave it as configurable in host_vars and add more documentation on that aspect, you can\u0027t expect everybody will use api_interface network for bgp traffic","commit_id":"65d4c73571bee103a51991eae1f8e443aa93e271"}]}