)]}'
{"ansible/roles/designate/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ca2f288ccf3879417f89437c1626b717d2489048","unresolved":false,"context_lines":[{"line_number":253,"context_line":"##############"},{"line_number":254,"context_line":"# default zone"},{"line_number":255,"context_line":"##############"},{"line_number":256,"context_line":"zone_id:"},{"line_number":257,"context_line":"default_zone:"},{"line_number":258,"context_line":"  # must end with a dot"},{"line_number":259,"context_line":"  name: \"openstack.org.\""},{"line_number":260,"context_line":"  zone_type: \"primary\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_17ea6b9e","line":257,"range":{"start_line":256,"start_character":0,"end_line":257,"end_character":13},"updated":"2020-09-25 16:57:12.000000000","message":"Please add a designate_ prefix.","commit_id":"9e1519062d640fbd1f7786238397901f418e2477"},{"author":{"_account_id":32067,"name":"Linhui Zhou","email":"df.some@foxmail.com","username":"zhoulinhui"},"change_message_id":"c1572caea41fe595430a78a908344628b0b5664f","unresolved":false,"context_lines":[{"line_number":263,"context_line":"  # Master nameservers (only applies if zone_type is secondary)"},{"line_number":264,"context_line":"  masters:"},{"line_number":265,"context_line":"  timeout: \"180\""},{"line_number":266,"context_line":"  ttl: \"3600\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_404b8026","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":13},"updated":"2020-09-25 15:37:18.000000000","message":"no new line character at the end of file  (new-line-at-end-of-file)","commit_id":"9e1519062d640fbd1f7786238397901f418e2477"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"835305b63841da9fb1e754c0bd7c3dc43b2ea4aa","unresolved":false,"context_lines":[{"line_number":255,"context_line":"##############"},{"line_number":256,"context_line":"designate_zone_id:"},{"line_number":257,"context_line":"designate_default_zone:"},{"line_number":258,"context_line":"  # must end with a dot"},{"line_number":259,"context_line":"  name: \"openstack.org.\""},{"line_number":260,"context_line":"  zone_type: \"primary\""},{"line_number":261,"context_line":"  email: \"admin@openstack.org\""},{"line_number":262,"context_line":"  description: \"default zone\""},{"line_number":263,"context_line":"  # Master nameservers (only applies if zone_type is secondary)"},{"line_number":264,"context_line":"  masters:"},{"line_number":265,"context_line":"  timeout: \"180\""},{"line_number":266,"context_line":"  ttl: \"3600\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_5e95efe2","line":266,"range":{"start_line":258,"start_character":0,"end_line":266,"end_character":13},"updated":"2020-09-29 16:57:38.000000000","message":"There probably isn\u0027t really a sensible default here. It might be better to document the options and leave it empty.","commit_id":"3125ad13681b9ef72bc1b54497595ef58e154a19"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"0cfee0939e0b96024abd260aa63f53a9d54bd1ba","unresolved":false,"context_lines":[{"line_number":255,"context_line":"##############"},{"line_number":256,"context_line":"designate_zone_id:"},{"line_number":257,"context_line":"designate_default_zone:"},{"line_number":258,"context_line":"  # must end with a dot"},{"line_number":259,"context_line":"  name: \"openstack.org.\""},{"line_number":260,"context_line":"  zone_type: \"primary\""},{"line_number":261,"context_line":"  email: \"admin@openstack.org\""},{"line_number":262,"context_line":"  description: \"default zone\""},{"line_number":263,"context_line":"  # Master nameservers (only applies if zone_type is secondary)"},{"line_number":264,"context_line":"  masters:"},{"line_number":265,"context_line":"  timeout: \"180\""},{"line_number":266,"context_line":"  ttl: \"3600\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_7c6f1128","line":266,"range":{"start_line":258,"start_character":0,"end_line":266,"end_character":13},"in_reply_to":"9f560f44_5e95efe2","updated":"2020-09-30 10:03:17.000000000","message":"yes, just a default value.","commit_id":"3125ad13681b9ef72bc1b54497595ef58e154a19"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9282a380f18a2ff837d2b2428968e6870c3f7e9b","unresolved":false,"context_lines":[{"line_number":254,"context_line":"# default zone"},{"line_number":255,"context_line":"##############"},{"line_number":256,"context_line":"designate_zone_id:"},{"line_number":257,"context_line":"designate_default_zone:"},{"line_number":258,"context_line":"  # must end with a dot"},{"line_number":259,"context_line":"  name: \"openstack.org.\""},{"line_number":260,"context_line":"  zone_type: \"primary\""},{"line_number":261,"context_line":"  email: \"admin@openstack.org\""},{"line_number":262,"context_line":"  description: \"default zone\""},{"line_number":263,"context_line":"  # Master nameservers (only applies if zone_type is secondary)"},{"line_number":264,"context_line":"  masters:"},{"line_number":265,"context_line":"  timeout: \"180\""},{"line_number":266,"context_line":"  ttl: \"3600\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_e71417a2","line":266,"range":{"start_line":257,"start_character":0,"end_line":266,"end_character":13},"updated":"2020-10-01 15:38:33.000000000","message":"I don\u0027t think we can provide a \u0027sane\u0027 default here.","commit_id":"c9451a1aa8704534fa882d9ea33f36da047ddaa4"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4c635c4adf5f78c5eddee62b213149208f0cdcd4","unresolved":false,"context_lines":[{"line_number":254,"context_line":"# default zone"},{"line_number":255,"context_line":"##############"},{"line_number":256,"context_line":"designate_zone_id:"},{"line_number":257,"context_line":"designate_default_zone:"},{"line_number":258,"context_line":"  # must end with a dot"},{"line_number":259,"context_line":"  name: \"openstack.org.\""},{"line_number":260,"context_line":"  zone_type: \"primary\""},{"line_number":261,"context_line":"  email: \"admin@openstack.org\""},{"line_number":262,"context_line":"  description: \"default zone\""},{"line_number":263,"context_line":"  # Master nameservers (only applies if zone_type is secondary)"},{"line_number":264,"context_line":"  masters:"},{"line_number":265,"context_line":"  timeout: \"180\""},{"line_number":266,"context_line":"  ttl: \"3600\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_9ddf6865","line":266,"range":{"start_line":257,"start_character":0,"end_line":266,"end_character":13},"in_reply_to":"9f560f44_e71417a2","updated":"2020-10-01 16:46:55.000000000","message":"yes, will remove them soon","commit_id":"c9451a1aa8704534fa882d9ea33f36da047ddaa4"}],"ansible/roles/designate/tasks/post-install.yml":[{"author":{"_account_id":32067,"name":"Linhui Zhou","email":"df.some@foxmail.com","username":"zhoulinhui"},"change_message_id":"c1572caea41fe595430a78a908344628b0b5664f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      endpoint_type: \"{{ openstack_interface }}\""},{"line_number":16,"context_line":"      region_name: \"{{ openstack_region_name }}\""},{"line_number":17,"context_line":"      state: present"},{"line_number":18,"context_line":"      name:  \"{{ default_zone[\u0027name\u0027] }}\""},{"line_number":19,"context_line":"      email: \"{{ default_zone[\u0027email\u0027] | default(omit, true) }}\""},{"line_number":20,"context_line":"      zone_type: \"{{ default_zone[\u0027zone_type\u0027]  | default(omit, true) }}\""},{"line_number":21,"context_line":"      description: \"{{ default_zone[\u0027description\u0027]  | default(omit, true) }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_40f9c0c2","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":13},"updated":"2020-09-25 15:37:18.000000000","message":"too many spaces after colon  (colons)","commit_id":"9e1519062d640fbd1f7786238397901f418e2477"},{"author":{"_account_id":32067,"name":"Linhui Zhou","email":"df.some@foxmail.com","username":"zhoulinhui"},"change_message_id":"c1572caea41fe595430a78a908344628b0b5664f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    - item.key \u003d\u003d \u0027designate-sink\u0027"},{"line_number":47,"context_line":"  with_dict: \"{{ designate_services }}\""},{"line_number":48,"context_line":"  notify:"},{"line_number":49,"context_line":"    - Restart {{ item.key }} container"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_001ce810","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":38},"updated":"2020-09-25 15:37:18.000000000","message":"no new line character at the end of file  (new-line-at-end-of-file)","commit_id":"9e1519062d640fbd1f7786238397901f418e2477"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"835305b63841da9fb1e754c0bd7c3dc43b2ea4aa","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  register: default_zone_fact"},{"line_number":28,"context_line":"  when: designate_zone_id is none"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Copying over designate.conf for designate-sink"},{"line_number":31,"context_line":"  vars:"},{"line_number":32,"context_line":"    service_name: \"{{ item.key }}\""},{"line_number":33,"context_line":"  merge_configs:"},{"line_number":34,"context_line":"    sources:"},{"line_number":35,"context_line":"      - \"{{ role_path }}/templates/designate.conf.j2\""},{"line_number":36,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":37,"context_line":"      - \"{{ node_custom_config }}/designate.conf\""},{"line_number":38,"context_line":"      - \"{{ node_custom_config }}/designate/{{ item.key }}.conf\""},{"line_number":39,"context_line":"      - \"{{ node_custom_config }}/designate/{{ inventory_hostname }}/designate.conf\""},{"line_number":40,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/designate.conf\""},{"line_number":41,"context_line":"    mode: \"0660\""},{"line_number":42,"context_line":"  become: true"},{"line_number":43,"context_line":"  when:"},{"line_number":44,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":45,"context_line":"    - item.value.enabled | bool"},{"line_number":46,"context_line":"    - item.key \u003d\u003d \u0027designate-sink\u0027"},{"line_number":47,"context_line":"  with_dict: \"{{ designate_services }}\""},{"line_number":48,"context_line":"  notify:"},{"line_number":49,"context_line":"    - Restart {{ item.key }} container"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_5215e33c","line":49,"range":{"start_line":30,"start_character":0,"end_line":49,"end_character":38},"updated":"2020-09-29 16:57:38.000000000","message":"It would be nice if we could do this in one pass after the first deploy. Probably we would need to query the ID of the zone before generating config, and allow it to fail. If it fails, we can create the zone here then just do this:\n\n- import_tasks: config.yml","commit_id":"3125ad13681b9ef72bc1b54497595ef58e154a19"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"0cfee0939e0b96024abd260aa63f53a9d54bd1ba","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  register: default_zone_fact"},{"line_number":28,"context_line":"  when: designate_zone_id is none"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Copying over designate.conf for designate-sink"},{"line_number":31,"context_line":"  vars:"},{"line_number":32,"context_line":"    service_name: \"{{ item.key }}\""},{"line_number":33,"context_line":"  merge_configs:"},{"line_number":34,"context_line":"    sources:"},{"line_number":35,"context_line":"      - \"{{ role_path }}/templates/designate.conf.j2\""},{"line_number":36,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":37,"context_line":"      - \"{{ node_custom_config }}/designate.conf\""},{"line_number":38,"context_line":"      - \"{{ node_custom_config }}/designate/{{ item.key }}.conf\""},{"line_number":39,"context_line":"      - \"{{ node_custom_config }}/designate/{{ inventory_hostname }}/designate.conf\""},{"line_number":40,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/designate.conf\""},{"line_number":41,"context_line":"    mode: \"0660\""},{"line_number":42,"context_line":"  become: true"},{"line_number":43,"context_line":"  when:"},{"line_number":44,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":45,"context_line":"    - item.value.enabled | bool"},{"line_number":46,"context_line":"    - item.key \u003d\u003d \u0027designate-sink\u0027"},{"line_number":47,"context_line":"  with_dict: \"{{ designate_services }}\""},{"line_number":48,"context_line":"  notify:"},{"line_number":49,"context_line":"    - Restart {{ item.key }} container"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_5caded30","line":49,"range":{"start_line":30,"start_character":0,"end_line":49,"end_character":38},"in_reply_to":"9f560f44_5215e33c","updated":"2020-09-30 10:03:17.000000000","message":"noo!!  there is a egg and chicken problem. before we create the zone, the designate services must exists, but they created  by config.yml. so if config.yml failed,  desigate will not work , and we can not create zone. for now, default_zone_id only used by designate sink. so we defer to invoke designate-sink handler. with this, we can ensure the ansible Idempotent.","commit_id":"3125ad13681b9ef72bc1b54497595ef58e154a19"}],"ansible/roles/designate/templates/designate.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"835305b63841da9fb1e754c0bd7c3dc43b2ea4aa","unresolved":false,"context_lines":[{"line_number":62,"context_line":"max_retries \u003d 10"},{"line_number":63,"context_line":"idle_timeout \u003d 3600"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[handler:nova_fixed]"},{"line_number":66,"context_line":"{% if default_zone_fact is defined %}"},{"line_number":67,"context_line":"zone_id \u003d {{ default_zone_fact.zone.id }}"},{"line_number":68,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f560f44_3ee0fb97","line":65,"updated":"2020-09-29 16:57:38.000000000","message":"we have the same issue as with octavia for kolla-ansible genconfig.","commit_id":"3125ad13681b9ef72bc1b54497595ef58e154a19"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"0cfee0939e0b96024abd260aa63f53a9d54bd1ba","unresolved":false,"context_lines":[{"line_number":62,"context_line":"max_retries \u003d 10"},{"line_number":63,"context_line":"idle_timeout \u003d 3600"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[handler:nova_fixed]"},{"line_number":66,"context_line":"{% if default_zone_fact is defined %}"},{"line_number":67,"context_line":"zone_id \u003d {{ default_zone_fact.zone.id }}"},{"line_number":68,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f560f44_bc79a9fc","line":65,"in_reply_to":"9f560f44_3ee0fb97","updated":"2020-09-30 10:03:17.000000000","message":"for kolla-ansible genconfig, we use designate_zone_id to set zone_id. and the same as octavia https://review.opendev.org/#/c/740180/45/ansible/roles/octavia/templates/octavia.conf.j2","commit_id":"3125ad13681b9ef72bc1b54497595ef58e154a19"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9282a380f18a2ff837d2b2428968e6870c3f7e9b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"max_retries \u003d 10"},{"line_number":63,"context_line":"idle_timeout \u003d 3600"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[handler:nova_fixed]"},{"line_number":66,"context_line":"{% if default_zone_fact is defined %}"},{"line_number":67,"context_line":"zone_id \u003d {{ default_zone_fact.zone.id }}"},{"line_number":68,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9f560f44_6737674d","line":65,"range":{"start_line":65,"start_character":1,"end_line":65,"end_character":19},"updated":"2020-10-01 15:38:33.000000000","message":"I think we probably want to allow fixed and floating IPs to use different zones (but possibly the same).","commit_id":"c9451a1aa8704534fa882d9ea33f36da047ddaa4"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4c635c4adf5f78c5eddee62b213149208f0cdcd4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"max_retries \u003d 10"},{"line_number":63,"context_line":"idle_timeout \u003d 3600"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[handler:nova_fixed]"},{"line_number":66,"context_line":"{% if default_zone_fact is defined %}"},{"line_number":67,"context_line":"zone_id \u003d {{ default_zone_fact.zone.id }}"},{"line_number":68,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9f560f44_bdbb4c0d","line":65,"range":{"start_line":65,"start_character":1,"end_line":65,"end_character":19},"in_reply_to":"9f560f44_6737674d","updated":"2020-10-01 16:46:55.000000000","message":"ok,,will add a new variable","commit_id":"c9451a1aa8704534fa882d9ea33f36da047ddaa4"}]}