)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"a235586de2da2ea10ed588d96f6a1d60f200593c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Closes-Bug: 1606143"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"only del-header X-Forwarded-Proto if haproxy does the ssl termination."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If7c43ba12b395c14fb4f1291c545bbbd02577584"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f6b1bfe_69974d92","line":10,"updated":"2020-10-15 08:38:06.000000000","message":"\"Closes-Bug: 1606143\"  should in commit message. \nand you need a new git title.","commit_id":"28e93ee8b884d04caa79bf20cdc720f20f6836df"},{"author":{"_account_id":32543,"name":"Egon Rijpkema","email":"git@egonrijpkema.nl","username":"ug_egon"},"change_message_id":"b94ebcdf383faaec217f14b89b7200c6f2298d1e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Closes-Bug: 1606143"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"only del-header X-Forwarded-Proto if haproxy does the ssl termination."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If7c43ba12b395c14fb4f1291c545bbbd02577584"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f6b1bfe_578e6778","line":10,"in_reply_to":"7f6b1bfe_69974d92","updated":"2020-12-24 09:31:20.000000000","message":"This is my first review and i\u0027m sorry but i don\u0027t understand your remarks:\nMy commit message starts with \"Closes-Bug: 1606143\". \nShould i have included the quotes?\n\nAnd what is a git title in this context?","commit_id":"28e93ee8b884d04caa79bf20cdc720f20f6836df"}],"ansible/roles/haproxy-config/templates/haproxy_single_service_listen.cfg.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4dfbe2f126f3ca010bda4abf6386cbc48b65088b","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    http-request auth realm basicauth unless auth_acl"},{"line_number":25,"context_line":"        {% endif %}"},{"line_number":26,"context_line":"    {# Delete any pre-populated XFP header #}"},{"line_number":27,"context_line":"    http-request del-header X-Forwarded-Proto if { ssl_fc }"},{"line_number":28,"context_line":"        {% for http_option in haproxy_http_extra %}"},{"line_number":29,"context_line":"    {{ http_option }}"},{"line_number":30,"context_line":"        {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"2fa466e0_892a295d","line":27,"updated":"2021-01-05 10:05:52.000000000","message":"I\u0027m just trying to think through why we would want to delete this header before adding it again. It\u0027s a strange setup, but what if the external proxy is HTTP, but the internal proxy is HTTPS? We could receive a X-Forwarded-Proto HTTP header.","commit_id":"8d40bfe2210fa9e63d6af321dbf262709ff7063f"},{"author":{"_account_id":32543,"name":"Egon Rijpkema","email":"git@egonrijpkema.nl","username":"ug_egon"},"change_message_id":"04af316708912a7c4b19229595741181fa9e8050","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    http-request auth realm basicauth unless auth_acl"},{"line_number":25,"context_line":"        {% endif %}"},{"line_number":26,"context_line":"    {# Delete any pre-populated XFP header #}"},{"line_number":27,"context_line":"    http-request del-header X-Forwarded-Proto if { ssl_fc }"},{"line_number":28,"context_line":"        {% for http_option in haproxy_http_extra %}"},{"line_number":29,"context_line":"    {{ http_option }}"},{"line_number":30,"context_line":"        {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"f4e22ab5_b82dc41a","line":27,"in_reply_to":"2fa466e0_892a295d","updated":"2021-02-15 09:11:45.000000000","message":"I opted for this construction in order not to change the behaviour for other scenarios than the usecase of bug #1606143.\nBut the scenario you mention indeed seems a bit far fetched.","commit_id":"8d40bfe2210fa9e63d6af321dbf262709ff7063f"}]}