)]}'
{"ansible/inventory/all-in-one":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f3ee23c77d20a2c082edad761c31c683001c83cc","unresolved":true,"context_lines":[{"line_number":631,"context_line":"[octavia-api:children]"},{"line_number":632,"context_line":"octavia"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"[octavia-driver-agent:children]"},{"line_number":635,"context_line":"octavia"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"[octavia-health-manager:children]"},{"line_number":638,"context_line":"octavia"},{"line_number":639,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1928ff7a_ca7fb3bd","line":636,"range":{"start_line":634,"start_character":0,"end_line":636,"end_character":0},"updated":"2020-11-25 14:18:01.000000000","message":"Are we planning to backport this? I can see us getting some bug reports about missing groups, if users don\u0027t keep their inventory up to date.","commit_id":"b74f1d8131af743d7e99c07b05ec2d41afdc5cf2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cb8ddf50a0240b523474d0dce19245040a266a3a","unresolved":true,"context_lines":[{"line_number":631,"context_line":"[octavia-api:children]"},{"line_number":632,"context_line":"octavia"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"[octavia-driver-agent:children]"},{"line_number":635,"context_line":"octavia"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"[octavia-health-manager:children]"},{"line_number":638,"context_line":"octavia"},{"line_number":639,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"55f6dcc3_0f1dca3d","line":636,"range":{"start_line":634,"start_character":0,"end_line":636,"end_character":0},"in_reply_to":"1928ff7a_ca7fb3bd","updated":"2020-12-03 09:58:01.000000000","message":"We could just make it deploy in octavia-api group - if that\u0027s acceptable - I don\u0027t know if we have a case of deploying two services into the same Ansible group. Acceptable?","commit_id":"b74f1d8131af743d7e99c07b05ec2d41afdc5cf2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"087c23562c17360357cfccfd7c3c6051476d2cf6","unresolved":true,"context_lines":[{"line_number":631,"context_line":"[octavia-api:children]"},{"line_number":632,"context_line":"octavia"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"[octavia-driver-agent:children]"},{"line_number":635,"context_line":"octavia"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"[octavia-health-manager:children]"},{"line_number":638,"context_line":"octavia"},{"line_number":639,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"89700843_ebdf42f5","line":636,"range":{"start_line":634,"start_character":0,"end_line":636,"end_character":0},"in_reply_to":"55f6dcc3_0f1dca3d","updated":"2021-01-20 09:24:04.000000000","message":"As discussed, let\u0027s keep to the standard pattern of a group per-service.","commit_id":"b74f1d8131af743d7e99c07b05ec2d41afdc5cf2"}],"ansible/roles/octavia/templates/octavia-api.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fc20a5632d60f106ced1950888a64ef9a7bbbff3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        {"},{"line_number":19,"context_line":"            \"path\": \"/var/run/octavia\","},{"line_number":20,"context_line":"            \"owner\": \"octavia:octavia\","},{"line_number":21,"context_line":"            \"recurse\": true"},{"line_number":22,"context_line":"        }"},{"line_number":23,"context_line":"    ]"},{"line_number":24,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1f621f24_302eda91","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":27},"updated":"2020-11-10 11:34:01.000000000","message":"Do we need it?","commit_id":"a6cf87ab1bf663dc2b458b51dad7bb9910cab1a5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"71b8e79d6ddbe0a93610d56dcad76e62a97d3cb9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        {"},{"line_number":19,"context_line":"            \"path\": \"/var/run/octavia\","},{"line_number":20,"context_line":"            \"owner\": \"octavia:octavia\","},{"line_number":21,"context_line":"            \"recurse\": true"},{"line_number":22,"context_line":"        }"},{"line_number":23,"context_line":"    ]"},{"line_number":24,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"b2222e52_098478ba","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":27},"in_reply_to":"1f621f24_302eda91","updated":"2020-11-24 13:50:09.000000000","message":"Nope.","commit_id":"a6cf87ab1bf663dc2b458b51dad7bb9910cab1a5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"087c23562c17360357cfccfd7c3c6051476d2cf6","unresolved":true,"context_lines":[{"line_number":18,"context_line":"        {"},{"line_number":19,"context_line":"            \"path\": \"/var/run/octavia\","},{"line_number":20,"context_line":"            \"owner\": \"octavia:octavia\","},{"line_number":21,"context_line":"            \"recurse\": true"},{"line_number":22,"context_line":"        }"},{"line_number":23,"context_line":"    ]"},{"line_number":24,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"6fe1de7d_b6cc1f75","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":27},"updated":"2021-01-20 09:24:04.000000000","message":"Is it required?","commit_id":"3f5896397b298e458130335d407c96ed85df67e4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"42fc54404005469a716ae543c42c13444b4e6d49","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        {"},{"line_number":19,"context_line":"            \"path\": \"/var/run/octavia\","},{"line_number":20,"context_line":"            \"owner\": \"octavia:octavia\","},{"line_number":21,"context_line":"            \"recurse\": true"},{"line_number":22,"context_line":"        }"},{"line_number":23,"context_line":"    ]"},{"line_number":24,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"37f7784e_62102efd","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":27},"in_reply_to":"6fe1de7d_b6cc1f75","updated":"2021-02-16 10:52:17.000000000","message":"Probably not","commit_id":"3f5896397b298e458130335d407c96ed85df67e4"}],"ansible/roles/octavia/templates/octavia-driver-agent.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fc20a5632d60f106ced1950888a64ef9a7bbbff3","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"dest\": \"/etc/octavia/octavia.conf\","},{"line_number":7,"context_line":"            \"owner\": \"octavia\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if octavia_policy_file is defined %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ octavia_policy_file }}\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/octavia/{{ octavia_policy_file }}\","},{"line_number":13,"context_line":"            \"owner\": \"octavia\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }{% endif %}"},{"line_number":16,"context_line":"    ],"},{"line_number":17,"context_line":"    \"permissions\": ["},{"line_number":18,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1f621f24_30537a19","line":15,"range":{"start_line":9,"start_character":9,"end_line":15,"end_character":20},"updated":"2020-11-10 11:34:01.000000000","message":"Does it require the policy file?","commit_id":"a6cf87ab1bf663dc2b458b51dad7bb9910cab1a5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"71b8e79d6ddbe0a93610d56dcad76e62a97d3cb9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"dest\": \"/etc/octavia/octavia.conf\","},{"line_number":7,"context_line":"            \"owner\": \"octavia\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if octavia_policy_file is defined %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ octavia_policy_file }}\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/octavia/{{ octavia_policy_file }}\","},{"line_number":13,"context_line":"            \"owner\": \"octavia\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }{% endif %}"},{"line_number":16,"context_line":"    ],"},{"line_number":17,"context_line":"    \"permissions\": ["},{"line_number":18,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"13fba8c7_fc791fe2","line":15,"range":{"start_line":9,"start_character":9,"end_line":15,"end_character":20},"in_reply_to":"1f621f24_30537a19","updated":"2020-11-24 13:50:09.000000000","message":"Nope.","commit_id":"a6cf87ab1bf663dc2b458b51dad7bb9910cab1a5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fc20a5632d60f106ced1950888a64ef9a7bbbff3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        {"},{"line_number":19,"context_line":"            \"path\": \"/var/run/octavia\","},{"line_number":20,"context_line":"            \"owner\": \"octavia:octavia\","},{"line_number":21,"context_line":"            \"recurse\": true"},{"line_number":22,"context_line":"        }"},{"line_number":23,"context_line":"    ]"},{"line_number":24,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1f621f24_7024d2af","line":21,"range":{"start_line":21,"start_character":11,"end_line":21,"end_character":27},"updated":"2020-11-10 11:34:01.000000000","message":"ditto","commit_id":"a6cf87ab1bf663dc2b458b51dad7bb9910cab1a5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"087c23562c17360357cfccfd7c3c6051476d2cf6","unresolved":true,"context_lines":[{"line_number":18,"context_line":"        {"},{"line_number":19,"context_line":"            \"path\": \"/var/run/octavia\","},{"line_number":20,"context_line":"            \"owner\": \"octavia:octavia\","},{"line_number":21,"context_line":"            \"recurse\": true"},{"line_number":22,"context_line":"        }"},{"line_number":23,"context_line":"    ]"},{"line_number":24,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"379a83e3_bfe617fb","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":27},"updated":"2021-01-20 09:24:04.000000000","message":"ditto","commit_id":"3f5896397b298e458130335d407c96ed85df67e4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"42fc54404005469a716ae543c42c13444b4e6d49","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        {"},{"line_number":19,"context_line":"            \"path\": \"/var/run/octavia\","},{"line_number":20,"context_line":"            \"owner\": \"octavia:octavia\","},{"line_number":21,"context_line":"            \"recurse\": true"},{"line_number":22,"context_line":"        }"},{"line_number":23,"context_line":"    ]"},{"line_number":24,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"dd538467_b52c168a","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":27},"in_reply_to":"379a83e3_bfe617fb","updated":"2021-02-16 10:52:17.000000000","message":"Done","commit_id":"3f5896397b298e458130335d407c96ed85df67e4"}],"etc/kolla/globals.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ac1905a3e87f0eb91527032ca75412ccf53d4add","unresolved":true,"context_lines":[{"line_number":357,"context_line":"#enable_nova_serialconsole_proxy: \"no\""},{"line_number":358,"context_line":"#enable_nova_ssh: \"yes\""},{"line_number":359,"context_line":"#enable_octavia: \"no\""},{"line_number":360,"context_line":"#enable_octavia_driver_agent: \"no\""},{"line_number":361,"context_line":"#enable_openvswitch: \"{{ enable_neutron | bool and neutron_plugin_agent !\u003d \u0027linuxbridge\u0027 }}\""},{"line_number":362,"context_line":"#enable_ovn: \"{{ enable_neutron | bool and neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":363,"context_line":"#enable_ovs_dpdk: \"no\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"fad23cde_55455780","line":360,"range":{"start_line":360,"start_character":31,"end_line":360,"end_character":33},"updated":"2021-03-01 11:51:57.000000000","message":"inconsistent","commit_id":"ed9bf9a07b72294de02f4da4f958b143efe87ff2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce2e96fc2819c59487a4cf8795795bcb3b9ecf36","unresolved":false,"context_lines":[{"line_number":357,"context_line":"#enable_nova_serialconsole_proxy: \"no\""},{"line_number":358,"context_line":"#enable_nova_ssh: \"yes\""},{"line_number":359,"context_line":"#enable_octavia: \"no\""},{"line_number":360,"context_line":"#enable_octavia_driver_agent: \"no\""},{"line_number":361,"context_line":"#enable_openvswitch: \"{{ enable_neutron | bool and neutron_plugin_agent !\u003d \u0027linuxbridge\u0027 }}\""},{"line_number":362,"context_line":"#enable_ovn: \"{{ enable_neutron | bool and neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":363,"context_line":"#enable_ovs_dpdk: \"no\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"f13093d0_c4fcd439","line":360,"range":{"start_line":360,"start_character":31,"end_line":360,"end_character":33},"in_reply_to":"fad23cde_55455780","updated":"2021-03-01 14:01:01.000000000","message":"Done","commit_id":"ed9bf9a07b72294de02f4da4f958b143efe87ff2"}],"releasenotes/notes/bug-1903506-12ae72c114bede72.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"087c23562c17360357cfccfd7c3c6051476d2cf6","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``octavia-driver-agent`` to ``Octavia`` deployments to allow for"},{"line_number":5,"context_line":"    additional providers, e.g. ``ovn-octavia-provider``."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"f5dbfc79_306247de","line":5,"updated":"2021-01-20 09:24:04.000000000","message":"It is disabled by default and may be enabled via..","commit_id":"3f5896397b298e458130335d407c96ed85df67e4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"42fc54404005469a716ae543c42c13444b4e6d49","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``octavia-driver-agent`` to ``Octavia`` deployments to allow for"},{"line_number":5,"context_line":"    additional providers, e.g. ``ovn-octavia-provider``."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"acc9509e_da37a912","line":5,"in_reply_to":"f5dbfc79_306247de","updated":"2021-02-16 10:52:17.000000000","message":"Done","commit_id":"3f5896397b298e458130335d407c96ed85df67e4"}],"tests/setup_gate.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"83a3a7292adf1c528512772b3afa701952fcdb14","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        GATE_IMAGES+\u003d\",^designate,^magnum,^trove\""},{"line_number":76,"context_line":"    fi"},{"line_number":77,"context_line":"    if [[ $SCENARIO \u003d\u003d \"octavia\" ]]; then"},{"line_number":78,"context_line":"        GATE_IMAGES+\u003d\",^octavia\""},{"line_number":79,"context_line":"    fi"},{"line_number":80,"context_line":"    if [[ $SCENARIO \u003d\u003d \"masakari\" ]]; then"},{"line_number":81,"context_line":"        GATE_IMAGES+\u003d\",^masakari\""}],"source_content_type":"text/x-sh","patch_set":44,"id":"3a3699dc_e5029ae9","line":78,"updated":"2021-03-23 10:34:00.000000000","message":",^ovn","commit_id":"118ae691f5deaaa7149cdd502bdead2ed3f4659f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"82dccbe01542395267ebadd3d80146d123ee166b","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        GATE_IMAGES+\u003d\",^designate,^magnum,^trove\""},{"line_number":76,"context_line":"    fi"},{"line_number":77,"context_line":"    if [[ $SCENARIO \u003d\u003d \"octavia\" ]]; then"},{"line_number":78,"context_line":"        GATE_IMAGES+\u003d\",^octavia\""},{"line_number":79,"context_line":"    fi"},{"line_number":80,"context_line":"    if [[ $SCENARIO \u003d\u003d \"masakari\" ]]; then"},{"line_number":81,"context_line":"        GATE_IMAGES+\u003d\",^masakari\""}],"source_content_type":"text/x-sh","patch_set":44,"id":"b03c6b55_6f8f7164","line":78,"in_reply_to":"3a3699dc_e5029ae9","updated":"2021-03-23 12:53:18.000000000","message":"We rather need octavia in the OVN scenario, not the other way around :)","commit_id":"118ae691f5deaaa7149cdd502bdead2ed3f4659f"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"087c23562c17360357cfccfd7c3c6051476d2cf6","unresolved":true,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"{% if scenario \u003d\u003d \"ovn\" %}"},{"line_number":143,"context_line":"neutron_plugin_agent: \"ovn\""},{"line_number":144,"context_line":"enable_octavia: \"yes\""},{"line_number":145,"context_line":"enable_octavia_driver_agent: \"yes\""},{"line_number":146,"context_line":"{% endif %}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"{% if scenario \u003d\u003d \"prometheus-efk\" %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"8637903e_2f9aa92b","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":34},"updated":"2021-01-20 09:24:04.000000000","message":"Can we add this separately, and test that it actually works?\n\nAlso wondering whether we would want to set enable_octavia_driver_agent to true if octavia and OVN are both enabled?","commit_id":"3f5896397b298e458130335d407c96ed85df67e4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"42fc54404005469a716ae543c42c13444b4e6d49","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"{% if scenario \u003d\u003d \"ovn\" %}"},{"line_number":143,"context_line":"neutron_plugin_agent: \"ovn\""},{"line_number":144,"context_line":"enable_octavia: \"yes\""},{"line_number":145,"context_line":"enable_octavia_driver_agent: \"yes\""},{"line_number":146,"context_line":"{% endif %}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"{% if scenario \u003d\u003d \"prometheus-efk\" %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"ecbb675e_91011981","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":34},"in_reply_to":"8637903e_2f9aa92b","updated":"2021-02-16 10:52:17.000000000","message":"Changed to enable when Octavia and OVN are deployed.","commit_id":"3f5896397b298e458130335d407c96ed85df67e4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ac1905a3e87f0eb91527032ca75412ccf53d4add","unresolved":true,"context_lines":[{"line_number":142,"context_line":"{% if scenario \u003d\u003d \"ovn\" %}"},{"line_number":143,"context_line":"neutron_plugin_agent: \"ovn\""},{"line_number":144,"context_line":"enable_octavia: \"yes\""},{"line_number":145,"context_line":"#enable_octavia_driver_agent: \"yes\""},{"line_number":146,"context_line":"{% endif %}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"{% if scenario \u003d\u003d \"prometheus-efk\" %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"af1d078e_d3df41ee","line":145,"range":{"start_line":145,"start_character":0,"end_line":145,"end_character":35},"updated":"2021-03-01 11:51:57.000000000","message":"not required","commit_id":"ed9bf9a07b72294de02f4da4f958b143efe87ff2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce2e96fc2819c59487a4cf8795795bcb3b9ecf36","unresolved":false,"context_lines":[{"line_number":142,"context_line":"{% if scenario \u003d\u003d \"ovn\" %}"},{"line_number":143,"context_line":"neutron_plugin_agent: \"ovn\""},{"line_number":144,"context_line":"enable_octavia: \"yes\""},{"line_number":145,"context_line":"#enable_octavia_driver_agent: \"yes\""},{"line_number":146,"context_line":"{% endif %}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"{% if scenario \u003d\u003d \"prometheus-efk\" %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"38c9e0c5_721ef6e3","line":145,"range":{"start_line":145,"start_character":0,"end_line":145,"end_character":35},"in_reply_to":"af1d078e_d3df41ee","updated":"2021-03-01 14:01:01.000000000","message":"Done","commit_id":"ed9bf9a07b72294de02f4da4f958b143efe87ff2"}],"tests/test-ovn.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ac1905a3e87f0eb91527032ca75412ccf53d4add","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        exit 1"},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    echo \"Creating Octavia OVN LB:\""},{"line_number":45,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":46,"context_line":"    . ~/openstackclient-venv/bin/activate"},{"line_number":47,"context_line":"    openstack loadbalancer create --vip-network-id demo-net --provider ovn --name test_ovn_lb"},{"line_number":48,"context_line":"    openstack loadbalancer listener create --protocol TCP --protocol-port 60415 --name test_ovn_lb_listener test_ovn_lb"},{"line_number":49,"context_line":"    openstack loadbalancer pool create --protocol TCP --lb-algorithm SOURCE_IP_PORT --listener test_ovn_lb_listener --name test_ovn_lb_pool"},{"line_number":50,"context_line":"    SUBNET_ID\u003d$(openstack subnet list -c ID -f value --name demo-subnet)"},{"line_number":51,"context_line":"    openstack loadbalancer member create --address 10.0.0.100 --subnet-id ${SUBNET_ID} --protocol-port 60415 test_ovn_lb_pool"},{"line_number":52,"context_line":"    echo \"OVN NB entries for LB:\""},{"line_number":53,"context_line":"    sudo docker exec ovn_northd ovn-nbctl --db \"$ovn_nb_connection\" list load_balancer"},{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"function test_ovn {"}],"source_content_type":"text/x-sh","patch_set":24,"id":"19368c71_f406c8c6","line":53,"range":{"start_line":44,"start_character":0,"end_line":53,"end_character":86},"updated":"2021-03-01 11:51:57.000000000","message":"Can we use a similar test to https://review.opendev.org/c/openstack/kolla-ansible/+/754285, which actually tests that the LB works?","commit_id":"ed9bf9a07b72294de02f4da4f958b143efe87ff2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce2e96fc2819c59487a4cf8795795bcb3b9ecf36","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        exit 1"},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    echo \"Creating Octavia OVN LB:\""},{"line_number":45,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":46,"context_line":"    . ~/openstackclient-venv/bin/activate"},{"line_number":47,"context_line":"    openstack loadbalancer create --vip-network-id demo-net --provider ovn --name test_ovn_lb"},{"line_number":48,"context_line":"    openstack loadbalancer listener create --protocol TCP --protocol-port 60415 --name test_ovn_lb_listener test_ovn_lb"},{"line_number":49,"context_line":"    openstack loadbalancer pool create --protocol TCP --lb-algorithm SOURCE_IP_PORT --listener test_ovn_lb_listener --name test_ovn_lb_pool"},{"line_number":50,"context_line":"    SUBNET_ID\u003d$(openstack subnet list -c ID -f value --name demo-subnet)"},{"line_number":51,"context_line":"    openstack loadbalancer member create --address 10.0.0.100 --subnet-id ${SUBNET_ID} --protocol-port 60415 test_ovn_lb_pool"},{"line_number":52,"context_line":"    echo \"OVN NB entries for LB:\""},{"line_number":53,"context_line":"    sudo docker exec ovn_northd ovn-nbctl --db \"$ovn_nb_connection\" list load_balancer"},{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"function test_ovn {"}],"source_content_type":"text/x-sh","patch_set":24,"id":"a9ecbec2_9ed39e1f","line":53,"range":{"start_line":44,"start_character":0,"end_line":53,"end_character":86},"in_reply_to":"19368c71_f406c8c6","updated":"2021-03-01 14:01:01.000000000","message":"Done","commit_id":"ed9bf9a07b72294de02f4da4f958b143efe87ff2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"83a3a7292adf1c528512772b3afa701952fcdb14","unresolved":true,"context_lines":[{"line_number":91,"context_line":"    echo \"Attempt to access the load balanced HTTP server.\""},{"line_number":92,"context_line":"    attempts\u003d12"},{"line_number":93,"context_line":"    for i in $(seq 1 ${attempts}); do"},{"line_number":94,"context_line":"        if curl $lb_fip:8000; then"},{"line_number":95,"context_line":"            break"},{"line_number":96,"context_line":"        elif [[ $i -eq ${attempts} ]]; then"},{"line_number":97,"context_line":"            echo \"Failed to access load balanced service after ${attempts} attempts\""}],"source_content_type":"text/x-sh","patch_set":44,"id":"aff4256b_40e97801","line":94,"range":{"start_line":94,"start_character":11,"end_line":94,"end_character":15},"updated":"2021-03-23 10:34:00.000000000","message":"hmm, looks like we are not checking the HTTP response here. Proposed a fix for the octavia scenario: https://review.opendev.org/c/openstack/kolla-ansible/+/782404","commit_id":"118ae691f5deaaa7149cdd502bdead2ed3f4659f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"82dccbe01542395267ebadd3d80146d123ee166b","unresolved":true,"context_lines":[{"line_number":91,"context_line":"    echo \"Attempt to access the load balanced HTTP server.\""},{"line_number":92,"context_line":"    attempts\u003d12"},{"line_number":93,"context_line":"    for i in $(seq 1 ${attempts}); do"},{"line_number":94,"context_line":"        if curl $lb_fip:8000; then"},{"line_number":95,"context_line":"            break"},{"line_number":96,"context_line":"        elif [[ $i -eq ${attempts} ]]; then"},{"line_number":97,"context_line":"            echo \"Failed to access load balanced service after ${attempts} attempts\""}],"source_content_type":"text/x-sh","patch_set":44,"id":"e24691fe_b1b27b5f","line":94,"range":{"start_line":94,"start_character":11,"end_line":94,"end_character":15},"in_reply_to":"aff4256b_40e97801","updated":"2021-03-23 12:53:18.000000000","message":"ok then, will update.","commit_id":"118ae691f5deaaa7149cdd502bdead2ed3f4659f"}]}