)]}'
{"ansible/nova.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4c872737fcbe794bd0c055cbf5a2e4f73fc4e0d7","unresolved":true,"context_lines":[{"line_number":270,"context_line":"- name: Remove unused nova services"},{"line_number":271,"context_line":"  gather_facts: false"},{"line_number":272,"context_line":"  hosts:"},{"line_number":273,"context_line":"    - nova-conductor"},{"line_number":274,"context_line":"    - \u0027\u0026enable_nova_True\u0027"},{"line_number":275,"context_line":"  tasks:"},{"line_number":276,"context_line":"    - import_role:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c66a2d78_93ab5aa4","line":273,"range":{"start_line":273,"start_character":11,"end_line":273,"end_character":20},"updated":"2021-05-18 09:36:06.000000000","message":"scheduler","commit_id":"162dd0037f169a3f2aef24803675c1ac74bcb85b"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"8d21ee8cb50e34c1a17fc203640d5a3c7b990293","unresolved":false,"context_lines":[{"line_number":270,"context_line":"- name: Remove unused nova services"},{"line_number":271,"context_line":"  gather_facts: false"},{"line_number":272,"context_line":"  hosts:"},{"line_number":273,"context_line":"    - nova-conductor"},{"line_number":274,"context_line":"    - \u0027\u0026enable_nova_True\u0027"},{"line_number":275,"context_line":"  tasks:"},{"line_number":276,"context_line":"    - import_role:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e5e0e97c_f26afd20","line":273,"range":{"start_line":273,"start_character":11,"end_line":273,"end_character":20},"in_reply_to":"c66a2d78_93ab5aa4","updated":"2021-05-18 11:54:42.000000000","message":"Done","commit_id":"162dd0037f169a3f2aef24803675c1ac74bcb85b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4c872737fcbe794bd0c055cbf5a2e4f73fc4e0d7","unresolved":true,"context_lines":[{"line_number":271,"context_line":"  gather_facts: false"},{"line_number":272,"context_line":"  hosts:"},{"line_number":273,"context_line":"    - nova-conductor"},{"line_number":274,"context_line":"    - \u0027\u0026enable_nova_True\u0027"},{"line_number":275,"context_line":"  tasks:"},{"line_number":276,"context_line":"    - import_role:"},{"line_number":277,"context_line":"        role: nova"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2b150694_b6909858","line":274,"updated":"2021-05-18 09:36:06.000000000","message":"serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027","commit_id":"162dd0037f169a3f2aef24803675c1ac74bcb85b"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"8d21ee8cb50e34c1a17fc203640d5a3c7b990293","unresolved":false,"context_lines":[{"line_number":271,"context_line":"  gather_facts: false"},{"line_number":272,"context_line":"  hosts:"},{"line_number":273,"context_line":"    - nova-conductor"},{"line_number":274,"context_line":"    - \u0027\u0026enable_nova_True\u0027"},{"line_number":275,"context_line":"  tasks:"},{"line_number":276,"context_line":"    - import_role:"},{"line_number":277,"context_line":"        role: nova"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d39133f3_1ffcdf81","line":274,"in_reply_to":"2b150694_b6909858","updated":"2021-05-18 11:54:42.000000000","message":"Done","commit_id":"162dd0037f169a3f2aef24803675c1ac74bcb85b"}],"ansible/roles/nova/tasks/remove_unused_services.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4c872737fcbe794bd0c055cbf5a2e4f73fc4e0d7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Get all nova-schedulers services"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4b4c9ab5_51b1b960","line":1,"updated":"2021-05-18 09:36:06.000000000","message":"If we have just performed an upgrade, can we guarantee that the old schedulers will be down, and that the new schedulers will have updated more recently than the old ones?","commit_id":"162dd0037f169a3f2aef24803675c1ac74bcb85b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"daf0a294a1ea5c18abd538480d39c951bd9cd48b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Get all nova-schedulers services"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4bbbf00c_034d16f1","line":1,"in_reply_to":"1c9db9bb_8da2106c","updated":"2021-05-18 13:15:05.000000000","message":"How do we know there has been sufficient time for the new service to register itself? Seems racy to me.","commit_id":"162dd0037f169a3f2aef24803675c1ac74bcb85b"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"8d21ee8cb50e34c1a17fc203640d5a3c7b990293","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Get all nova-schedulers services"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1c9db9bb_8da2106c","line":1,"in_reply_to":"4b4c9ab5_51b1b960","updated":"2021-05-18 11:54:42.000000000","message":"Yes, because during upgrade there is replacement of old containers by new containers. Then there is additional restart of container and some additional steps. And because old service was stored on different place in DB, so there is no chance to update that old entry. I think it is safe solution.","commit_id":"162dd0037f169a3f2aef24803675c1ac74bcb85b"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"9a2d5bc558d68dbc45a6abbb0f2b29aad5a588a7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Get all nova-schedulers services"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a3c2c21a_19f84e6f","line":1,"in_reply_to":"4bbbf00c_034d16f1","updated":"2021-05-18 13:20:47.000000000","message":"No, I don\u0027t think, because new service is started when old one is stopped and the code is done by that way that it will remove only service which has duplicate entry and only the older one. So it start to be duplicated only when new service (container) started and older is stopped.","commit_id":"162dd0037f169a3f2aef24803675c1ac74bcb85b"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"9d59afa33d87b8304c33a568da4c9d134c4a88ca","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Get all nova-schedulers services"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"76cc34cc_19906e4e","line":1,"in_reply_to":"a3c2c21a_19f84e6f","updated":"2021-07-22 13:57:14.000000000","message":"Mark, I have to say that you were right. After few months of testing with this patch we hit this issue again. So we found different solution, where we are removing old schedulers from nova.services table, because between that releases there is difference that new schedulers are stored in nova_cell0.services table. So I think this solution can be proposed to specific version. But question is, if this shouldn\u0027t be solved during DB migration.","commit_id":"162dd0037f169a3f2aef24803675c1ac74bcb85b"}]}