)]}'
{".gitignore":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"44ee18c444e48498ace78dd5d21aed5a14ea7a42","unresolved":true,"context_lines":[{"line_number":57,"context_line":"# Others"},{"line_number":58,"context_line":".DS_Store"},{"line_number":59,"context_line":".vimrc"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# sphinx builds"},{"line_number":62,"context_line":"_build/"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"db2df256_991d091a","line":62,"range":{"start_line":60,"start_character":0,"end_line":62,"end_character":7},"updated":"2020-12-18 20:08:46.000000000","message":"no random extra changes please 😊","commit_id":"b8422afd38ed9881128585a38d40ad115ee7fda0"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"a5927c4c1665ab61d72e7e52d3c3ccf5531c8bf3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# Others"},{"line_number":58,"context_line":".DS_Store"},{"line_number":59,"context_line":".vimrc"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# sphinx builds"},{"line_number":62,"context_line":"_build/"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"409c7758_545d9973","line":62,"range":{"start_line":60,"start_character":0,"end_line":62,"end_character":7},"in_reply_to":"db2df256_991d091a","updated":"2021-01-14 08:13:57.000000000","message":"Ack","commit_id":"b8422afd38ed9881128585a38d40ad115ee7fda0"}],"ansible/roles/prometheus/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"700d4ff9b7627a02b0b0b42f88dd4350912b61fe","unresolved":true,"context_lines":[{"line_number":175,"context_line":"  - \"{{ node_config_directory }}/prometheus-server/:{{ container_config_directory }}/:ro\""},{"line_number":176,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":177,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":178,"context_line":"  - \"{{ prometheus_v2 if enable_prometheus_v2 | bool else prometheus }}:/var/lib/prometheus\""},{"line_number":179,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":180,"context_line":"prometheus_haproxy_exporter_default_volumes:"},{"line_number":181,"context_line":"  - \"{{ node_config_directory }}/prometheus-haproxy-exporter/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4c4d0e28_a4663825","line":178,"range":{"start_line":178,"start_character":58,"end_line":178,"end_character":68},"updated":"2020-12-15 16:48:18.000000000","message":"and here","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"700d4ff9b7627a02b0b0b42f88dd4350912b61fe","unresolved":true,"context_lines":[{"line_number":175,"context_line":"  - \"{{ node_config_directory }}/prometheus-server/:{{ container_config_directory }}/:ro\""},{"line_number":176,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":177,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":178,"context_line":"  - \"{{ prometheus_v2 if enable_prometheus_v2 | bool else prometheus }}:/var/lib/prometheus\""},{"line_number":179,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":180,"context_line":"prometheus_haproxy_exporter_default_volumes:"},{"line_number":181,"context_line":"  - \"{{ node_config_directory }}/prometheus-haproxy-exporter/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1e19aa29_9402f975","line":178,"range":{"start_line":178,"start_character":8,"end_line":178,"end_character":21},"updated":"2020-12-15 16:48:18.000000000","message":"needs \u0027quotes\u0027","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"a32bb6573890c19fe6335980dec4f0ad4accdf40","unresolved":false,"context_lines":[{"line_number":175,"context_line":"  - \"{{ node_config_directory }}/prometheus-server/:{{ container_config_directory }}/:ro\""},{"line_number":176,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":177,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":178,"context_line":"  - \"{{ prometheus_v2 if enable_prometheus_v2 | bool else prometheus }}:/var/lib/prometheus\""},{"line_number":179,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":180,"context_line":"prometheus_haproxy_exporter_default_volumes:"},{"line_number":181,"context_line":"  - \"{{ node_config_directory }}/prometheus-haproxy-exporter/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"608c6570_d5a50bd4","line":178,"range":{"start_line":178,"start_character":8,"end_line":178,"end_character":21},"in_reply_to":"1e19aa29_9402f975","updated":"2020-12-17 08:15:26.000000000","message":"Done","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"a32bb6573890c19fe6335980dec4f0ad4accdf40","unresolved":false,"context_lines":[{"line_number":175,"context_line":"  - \"{{ node_config_directory }}/prometheus-server/:{{ container_config_directory }}/:ro\""},{"line_number":176,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":177,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":178,"context_line":"  - \"{{ prometheus_v2 if enable_prometheus_v2 | bool else prometheus }}:/var/lib/prometheus\""},{"line_number":179,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":180,"context_line":"prometheus_haproxy_exporter_default_volumes:"},{"line_number":181,"context_line":"  - \"{{ node_config_directory }}/prometheus-haproxy-exporter/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"73e72b7f_cd8f1e1e","line":178,"range":{"start_line":178,"start_character":58,"end_line":178,"end_character":68},"in_reply_to":"4c4d0e28_a4663825","updated":"2020-12-17 08:15:26.000000000","message":"Done","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"}],"doc/source/reference/logging-and-monitoring/prometheus-guide.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"700d4ff9b7627a02b0b0b42f88dd4350912b61fe","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"   enable_prometheus: \"yes\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This will deploy backward incompatible Prometheus version 2.x. It means that"},{"line_number":24,"context_line":"any previous Prometheus 1.x deployment will be replaced and all it\u0027s stored"},{"line_number":25,"context_line":"metrics will be lost. It is not possible to use old data with new Prometheus"},{"line_number":26,"context_line":"version and deploying both versions with Kolla is currently unsupported."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3dcd700e_45cb6ed6","line":23,"range":{"start_line":23,"start_character":63,"end_line":23,"end_character":76},"updated":"2020-12-15 16:48:18.000000000","message":"Since Prometheus 1.x data is not compatible with Prometheus 2.x, any previous...","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"700d4ff9b7627a02b0b0b42f88dd4350912b61fe","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"   enable_prometheus: \"yes\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This will deploy backward incompatible Prometheus version 2.x. It means that"},{"line_number":24,"context_line":"any previous Prometheus 1.x deployment will be replaced and all it\u0027s stored"},{"line_number":25,"context_line":"metrics will be lost. It is not possible to use old data with new Prometheus"},{"line_number":26,"context_line":"version and deploying both versions with Kolla is currently unsupported."}],"source_content_type":"text/x-rst","patch_set":2,"id":"37eb01aa_5c7dae86","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":39},"updated":"2020-12-15 16:48:18.000000000","message":"drop this","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"a32bb6573890c19fe6335980dec4f0ad4accdf40","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"   enable_prometheus: \"yes\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This will deploy backward incompatible Prometheus version 2.x. It means that"},{"line_number":24,"context_line":"any previous Prometheus 1.x deployment will be replaced and all it\u0027s stored"},{"line_number":25,"context_line":"metrics will be lost. It is not possible to use old data with new Prometheus"},{"line_number":26,"context_line":"version and deploying both versions with Kolla is currently unsupported."}],"source_content_type":"text/x-rst","patch_set":2,"id":"78e5f55a_3ca5f0da","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":39},"in_reply_to":"37eb01aa_5c7dae86","updated":"2020-12-17 08:15:26.000000000","message":"Done","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"a32bb6573890c19fe6335980dec4f0ad4accdf40","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"   enable_prometheus: \"yes\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This will deploy backward incompatible Prometheus version 2.x. It means that"},{"line_number":24,"context_line":"any previous Prometheus 1.x deployment will be replaced and all it\u0027s stored"},{"line_number":25,"context_line":"metrics will be lost. It is not possible to use old data with new Prometheus"},{"line_number":26,"context_line":"version and deploying both versions with Kolla is currently unsupported."}],"source_content_type":"text/x-rst","patch_set":2,"id":"609079dc_b5aeab2a","line":23,"range":{"start_line":23,"start_character":63,"end_line":23,"end_character":76},"in_reply_to":"3dcd700e_45cb6ed6","updated":"2020-12-17 08:15:26.000000000","message":"Done","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"700d4ff9b7627a02b0b0b42f88dd4350912b61fe","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This will deploy backward incompatible Prometheus version 2.x. It means that"},{"line_number":24,"context_line":"any previous Prometheus 1.x deployment will be replaced and all it\u0027s stored"},{"line_number":25,"context_line":"metrics will be lost. It is not possible to use old data with new Prometheus"},{"line_number":26,"context_line":"version and deploying both versions with Kolla is currently unsupported."},{"line_number":27,"context_line":"If you only rely on Prometheus as a source of alert notifications (in pair with"},{"line_number":28,"context_line":"Alertmanager), it might be not worth migrating old metrics and they could be"}],"source_content_type":"text/x-rst","patch_set":2,"id":"27b197ba_fe6ece56","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":20},"updated":"2020-12-15 16:48:18.000000000","message":"Technically they are still on disk in the volume. Maybe say they are inaccessible.","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"a32bb6573890c19fe6335980dec4f0ad4accdf40","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This will deploy backward incompatible Prometheus version 2.x. It means that"},{"line_number":24,"context_line":"any previous Prometheus 1.x deployment will be replaced and all it\u0027s stored"},{"line_number":25,"context_line":"metrics will be lost. It is not possible to use old data with new Prometheus"},{"line_number":26,"context_line":"version and deploying both versions with Kolla is currently unsupported."},{"line_number":27,"context_line":"If you only rely on Prometheus as a source of alert notifications (in pair with"},{"line_number":28,"context_line":"Alertmanager), it might be not worth migrating old metrics and they could be"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0d5bd239_b11fb4ac","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":20},"in_reply_to":"27b197ba_fe6ece56","updated":"2020-12-17 08:15:26.000000000","message":"Done","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"180419f72195690de46a6de8176c30a3c095f46b","unresolved":true,"context_lines":[{"line_number":28,"context_line":"Alertmanager), it might be not worth migrating old metrics and they could be"},{"line_number":29,"context_line":"discarded. Otherwise, it\u0027s either possible to use"},{"line_number":30,"context_line":"`remote storage \u003chttps://prometheus.io/docs/prometheus/latest/storage/#remote-storage-integrations\u003e`_"},{"line_number":31,"context_line":"or scrape Kolla\u0027s Prometheus `/federate` endpoint with an external system."},{"line_number":32,"context_line":"However, if you want to stay on 1.x series, set the following variable:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":2,"id":"85fddf2e_d6d56153","line":31,"updated":"2020-12-15 10:06:46.000000000","message":"What do you think about adding Prometheus 2 as a new service, and optionally supporting running the old v1 service alongside (but with metric collection disabled)? Then we could document that if a user wants to access old metrics they can access them via the v1 datasource in Grafana for one release, and then the v1 service is removed in the following release?\n\nIf they want v1 and v2 data accessible from the same datasource, then that is an exercise for them to figure out as you suggest.","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"a32bb6573890c19fe6335980dec4f0ad4accdf40","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Alertmanager), it might be not worth migrating old metrics and they could be"},{"line_number":29,"context_line":"discarded. Otherwise, it\u0027s either possible to use"},{"line_number":30,"context_line":"`remote storage \u003chttps://prometheus.io/docs/prometheus/latest/storage/#remote-storage-integrations\u003e`_"},{"line_number":31,"context_line":"or scrape Kolla\u0027s Prometheus `/federate` endpoint with an external system."},{"line_number":32,"context_line":"However, if you want to stay on 1.x series, set the following variable:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba1f019d_329232a9","line":31,"in_reply_to":"49ffade7_f9412880","updated":"2020-12-17 08:15:26.000000000","message":"Ack","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"700d4ff9b7627a02b0b0b42f88dd4350912b61fe","unresolved":true,"context_lines":[{"line_number":28,"context_line":"Alertmanager), it might be not worth migrating old metrics and they could be"},{"line_number":29,"context_line":"discarded. Otherwise, it\u0027s either possible to use"},{"line_number":30,"context_line":"`remote storage \u003chttps://prometheus.io/docs/prometheus/latest/storage/#remote-storage-integrations\u003e`_"},{"line_number":31,"context_line":"or scrape Kolla\u0027s Prometheus `/federate` endpoint with an external system."},{"line_number":32,"context_line":"However, if you want to stay on 1.x series, set the following variable:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":2,"id":"49ffade7_f9412880","line":31,"in_reply_to":"85fddf2e_d6d56153","updated":"2020-12-15 16:48:18.000000000","message":"We have discussed this, but I think that ideal is stopping us from moving forward. Let\u0027s keep it simple for now, and if we have time then migration could be added later. With this approach people can stay on v1 until we drop it.","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"}],"releasenotes/notes/add-prometheus-v2-9f10c79986d3faf3.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f2e3e3abf5a9b1ade8b4b6cebee56798d8156ff5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Prometheus version 2.x deployment added."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e140201e_d8091cf3","line":4,"updated":"2020-12-09 12:04:20.000000000","message":"Needs some more details:\n\n* What is the new flag?\n* is it enabled by default?\n* what to do if you want to keep using v1?\n* can I migrate to v2?","commit_id":"928417ba358fce8a16a648a34164753d5d05c734"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"700d4ff9b7627a02b0b0b42f88dd4350912b61fe","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Prometheus version 2.x deployment added. This version is enabled by"},{"line_number":5,"context_line":"    default and replaces backward incompatible version 1.x. A variable"},{"line_number":6,"context_line":"    ``enable_prometheus_v2`` set to ``no`` can be used to preserve version"},{"line_number":7,"context_line":"    1.x deployment with it\u0027s data. Otherwise, Prometheus will start with"},{"line_number":8,"context_line":"    a new volume, discarding all previously collected metrics."},{"line_number":9,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"02379575_c91c0768","line":6,"range":{"start_line":6,"start_character":29,"end_line":6,"end_character":54},"updated":"2020-12-15 16:48:18.000000000","message":"can be set to ``no``","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"a32bb6573890c19fe6335980dec4f0ad4accdf40","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Prometheus version 2.x deployment added. This version is enabled by"},{"line_number":5,"context_line":"    default and replaces backward incompatible version 1.x. A variable"},{"line_number":6,"context_line":"    ``enable_prometheus_v2`` set to ``no`` can be used to preserve version"},{"line_number":7,"context_line":"    1.x deployment with it\u0027s data. Otherwise, Prometheus will start with"},{"line_number":8,"context_line":"    a new volume, discarding all previously collected metrics."},{"line_number":9,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0ffc116b_0c6524b9","line":6,"range":{"start_line":6,"start_character":29,"end_line":6,"end_character":54},"in_reply_to":"02379575_c91c0768","updated":"2020-12-17 08:15:26.000000000","message":"Done","commit_id":"8255555d1ddb9821294262d3ab71828d2184457a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ed1b8621b4a478f67531fdc70c7d824972f5be0","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    ``prometheus_use_v1`` can be set to ``yes`` to preserve version"},{"line_number":7,"context_line":"    1.x deployment with its data. Otherwise, Prometheus will start with"},{"line_number":8,"context_line":"    a new volume, ignoring all previously collected metrics."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    New Prometheus version ignores previously stored metrics. If you"},{"line_number":12,"context_line":"    want to keep using 1.x with the old data, set ``prometheus_use_v1``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3793dd4e_ec156b90","line":9,"updated":"2021-01-05 10:07:40.000000000","message":"Should we also say that v1 is deprecated here and will be removed in the following release? It\u0027s very hard to imagine a good reason to use it :)","commit_id":"1496fd3f550d376a4acf418aea57e2c09186a6bf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f61d0363363ae97620c4e3a62b9cbf2cf0b0d520","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    ``prometheus_use_v1`` can be set to ``yes`` to preserve version"},{"line_number":7,"context_line":"    1.x deployment with its data. Otherwise, Prometheus will start with"},{"line_number":8,"context_line":"    a new volume, ignoring all previously collected metrics."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    New Prometheus version ignores previously stored metrics. If you"},{"line_number":12,"context_line":"    want to keep using 1.x with the old data, set ``prometheus_use_v1``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f195064b_cece999f","line":9,"in_reply_to":"3793dd4e_ec156b90","updated":"2021-01-05 10:12:33.000000000","message":"I suppose the reason would be that you are already using it and don\u0027t have a path to migrate your data to v2. We need to decide to either provide that migration path, support both forever, or leave it up to users to migrate and drop v1.","commit_id":"1496fd3f550d376a4acf418aea57e2c09186a6bf"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"35e08c230fd080846da1784c287f1906e8dcd761","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    ``prometheus_use_v1`` can be set to ``yes`` to preserve version"},{"line_number":7,"context_line":"    1.x deployment with its data. Otherwise, Prometheus will start with"},{"line_number":8,"context_line":"    a new volume, ignoring all previously collected metrics."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    New Prometheus version ignores previously stored metrics. If you"},{"line_number":12,"context_line":"    want to keep using 1.x with the old data, set ``prometheus_use_v1``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"444cbdde_f052e31e","line":9,"in_reply_to":"41cc3041_5f051124","updated":"2021-01-12 09:25:13.000000000","message":"Let\u0027s drop v1 - it\u0027s a dead piece of software, with unknown count of security holes that would never get patched. As for the volume removal feature - it may be not worth implementing it for a single use case - maybe multiple ones? Like removing all not mounted volumes some time after the upgrade or letting user choose what should be cleaned up. In case of Prometheus, it should be sufficient to say that the old volume is left behind - can be deleted easily in a manual way, otherwise it stays forever.","commit_id":"1496fd3f550d376a4acf418aea57e2c09186a6bf"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8aeaffff1d68d9d6bf683cacb9e99fee3d118e1c","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    ``prometheus_use_v1`` can be set to ``yes`` to preserve version"},{"line_number":7,"context_line":"    1.x deployment with its data. Otherwise, Prometheus will start with"},{"line_number":8,"context_line":"    a new volume, ignoring all previously collected metrics."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    New Prometheus version ignores previously stored metrics. If you"},{"line_number":12,"context_line":"    want to keep using 1.x with the old data, set ``prometheus_use_v1``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"41cc3041_5f051124","line":9,"in_reply_to":"f195064b_cece999f","updated":"2021-01-05 11:07:51.000000000","message":"My vote is for letting users migrate and save development effort for improving monitoring out of the box. I think many people will be retaining only 2 weeks of data and won\u0027t be overly concerned about migrating it. For users not happy with that, I suppose with this patch, a simple option to view old data would be to manually spin up a v1 container and mount the old volume in and add some custom HAProxy config for multinode deployments.","commit_id":"1496fd3f550d376a4acf418aea57e2c09186a6bf"}]}