)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"346f4de6c916fcd664a1697676bd9b62ca25cbbd","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Configure num_pcie_ports to 16 in default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"pci device like disk and network interface hotplug need configure"},{"line_number":10,"context_line":"num_pcie_ports on q36 machine type on x86 arch and aarch64 arch."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The max value is 28, but 16 is enough on most case."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6a4107_36fed16c","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":21},"updated":"2020-12-23 10:24:05.000000000","message":"q35","commit_id":"9c5001511842a3577e86e796ca73d7576299bc3e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"b273ae11d9dda03d9aa91d082ba0fc58d683e4be","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Configure num_pcie_ports to 16 in default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"pci device like disk and network interface hotplug need configure"},{"line_number":10,"context_line":"num_pcie_ports on q36 machine type on x86 arch and aarch64 arch."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The max value is 28, but 16 is enough on most case."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da475007_7eda4163","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":21},"in_reply_to":"1a6a4107_36fed16c","updated":"2023-08-28 13:04:23.000000000","message":"Done","commit_id":"9c5001511842a3577e86e796ca73d7576299bc3e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"346f4de6c916fcd664a1697676bd9b62ca25cbbd","unresolved":true,"context_lines":[{"line_number":18,"context_line":"* [2] https://review.opendev.org/c/openstack/nova/+/545034"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I7b8063566837aeb947927b7d6858417982b63deb"},{"line_number":21,"context_line":"Closes-Issue: 1909063"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"238ea1df_2e743145","line":21,"range":{"start_line":21,"start_character":7,"end_line":21,"end_character":12},"updated":"2020-12-23 10:24:05.000000000","message":"Bug","commit_id":"9c5001511842a3577e86e796ca73d7576299bc3e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"b273ae11d9dda03d9aa91d082ba0fc58d683e4be","unresolved":false,"context_lines":[{"line_number":18,"context_line":"* [2] https://review.opendev.org/c/openstack/nova/+/545034"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I7b8063566837aeb947927b7d6858417982b63deb"},{"line_number":21,"context_line":"Closes-Issue: 1909063"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"93258cca_d7349bbb","line":21,"range":{"start_line":21,"start_character":7,"end_line":21,"end_character":12},"in_reply_to":"238ea1df_2e743145","updated":"2023-08-28 13:04:23.000000000","message":"Done","commit_id":"9c5001511842a3577e86e796ca73d7576299bc3e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6fb9c7066d5a82d588c93a5ca962265652277377","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4df009cc_69cf2c02","updated":"2023-08-28 13:33:22.000000000","message":"can we put the excellent commit message, or a short version of it into the release notes? so people know why we are deviating from upstream?\n\nThanks!","commit_id":"5751c5aae358d5785b3c7c9e078eaa828cf1d6cb"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"64e7babf2a35b040447a17416c7ee43f788655d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"97ffd191_4118cdb9","in_reply_to":"4df009cc_69cf2c02","updated":"2023-08-28 13:56:24.000000000","message":"done","commit_id":"5751c5aae358d5785b3c7c9e078eaa828cf1d6cb"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"3a0217a18488662bd945405584b46dcb18786584","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a89bee45_c6e92bfe","updated":"2023-08-28 16:59:58.000000000","message":"Can this be an integer variable?","commit_id":"01a7fd628d93d902b7151ede7524071fc029acde"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9093388a74694237bf0f827eadfaafba08a6b737","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9933177d_01d83113","updated":"2023-08-28 14:55:53.000000000","message":"LGTM apart from the typo nits mentioned by Marcin.\n\nSide Note: Do we know why this does not work with 16 devices? what I\u0027ve read so far upstream and linked here does indicate it should work?","commit_id":"01a7fd628d93d902b7151ede7524071fc029acde"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f348fb9a061635f34f5e5ffced52f91cde5497ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8dc96c89_8255ab4d","updated":"2023-08-28 14:39:25.000000000","message":"nice to see own blog post used again ;D","commit_id":"01a7fd628d93d902b7151ede7524071fc029acde"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5c60948f40c4b13d7e642f03a2365656fb6c3625","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e5c9121a_8c34d764","in_reply_to":"9933177d_01d83113","updated":"2023-08-29 07:24:15.000000000","message":"Jeffrey had some issue on ARM with 16 (not sure exactly what kind of issue), therefore I chose 12 to be on the safe side. 12 PCIe ports seems to be enough for most cases, however I\u0027m happy to bump it if to small number for community. TripleO got 16 BTW - https://bugs.launchpad.net/tripleo/+bug/1831701","commit_id":"01a7fd628d93d902b7151ede7524071fc029acde"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5c60948f40c4b13d7e642f03a2365656fb6c3625","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"87eebc67_3989fae1","in_reply_to":"a89bee45_c6e92bfe","updated":"2023-08-29 07:24:15.000000000","message":"I\u0027m not adding a variable here, rather a value for nova config directly - which can be overridden in the custom config.","commit_id":"01a7fd628d93d902b7151ede7524071fc029acde"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"10016f70aa2ec853631593bdc1222cc0a7f26dec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e6258028_31ab774d","in_reply_to":"e5c9121a_8c34d764","updated":"2023-08-29 16:24:37.000000000","message":"yeah I read that, but I found it rather not helpful because no specific error was provided, or any other information. please always provide full context when reporting something as not working.","commit_id":"01a7fd628d93d902b7151ede7524071fc029acde"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e4e230bc75302d91a5c21b8cb76a374e227ce901","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ee061d85_272a0ce3","updated":"2023-08-29 07:30:08.000000000","message":"testing 16","commit_id":"e46ab3e3f492f32c040fb894a4bb4e76994bb732"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a6d16e371780befec638454f19fbbd3e51960d19","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6df055d5_73b7bed2","updated":"2023-09-07 13:25:01.000000000","message":"Can we add some testing coverage for q35 instances? Without that we won\u0027t know if for example it doesn\u0027t break aarch64","commit_id":"f40cb5e183aa67abd55d9a76dc6b8ac495881107"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6929411b8c8b0963729e3b2c41d5c413ad815f94","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fa45141e_638558e7","in_reply_to":"6df055d5_73b7bed2","updated":"2023-09-11 08:17:26.000000000","message":"I\u0027m surprised we don\u0027t have that already, but agreed.","commit_id":"f40cb5e183aa67abd55d9a76dc6b8ac495881107"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a75924df9850555f3b32158e9d1e4889d2992bc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"db50c7d1_f60fb867","in_reply_to":"fa45141e_638558e7","updated":"2023-09-11 16:31:28.000000000","message":"Done","commit_id":"f40cb5e183aa67abd55d9a76dc6b8ac495881107"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"ecadba4e393a99d3eef9aeb000dd3260071004ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"6240d8a0_62880fb8","updated":"2023-09-08 19:08:04.000000000","message":"recheck - double checking","commit_id":"7525d3100629eee1c63799957603308fb55cf1e4"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"64deae0937f953792b15c1711fb8db3e5b75b07a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ab939c1f_ead03f2d","updated":"2023-09-11 16:52:19.000000000","message":"I\u0027m not against this, however it should be a configurable variable.\n\nOne thing to note, I think this bug [1] will block Q35 from being feasible to enable if operators perform live migration on Q35 instances. \n\n[1]\nhttps://bugs.launchpad.net/bugs/2033193","commit_id":"b8e77deeeff011b5ca9ef891d4335ff72d7986f6"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"c67e2959c996a8ac30185cc1445cc6d16bc57275","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"6d8b1891_defeb099","in_reply_to":"ab939c1f_ead03f2d","updated":"2023-09-12 07:26:04.000000000","message":"I think this is a sane default, and at one point community decided not to create variable for every config entry - this setting can be overridden via custom config.\n\nthank you for info for q35 issues - this impacts jammy as far as I can see. Furthermore this change is not enabling q35 by default.","commit_id":"b8e77deeeff011b5ca9ef891d4335ff72d7986f6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f4df8aeceae263e137d8e50564c93621a28e1d20","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"33d5a7fd_04bddbd2","in_reply_to":"ab939c1f_ead03f2d","updated":"2023-09-12 07:17:00.000000000","message":"It\u0027s configurable using the regular config overrides\nThe bug mentions:\nThe issue only occurs when using Q35 Machine type VMs, add any type of hot-plugged device (in my case a disk drive) then perform I/O on that device while simultaneously doing a live migration\n\nI don\u0027t think people do that everyday, do they?","commit_id":"b8e77deeeff011b5ca9ef891d4335ff72d7986f6"}],"releasenotes/notes/fix-q35-pcie-hotplug-libvirt-50b1879d61b1df72.yaml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f348fb9a061635f34f5e5ffced52f91cde5497ee","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configure Nova libvirt.num_pcie_ports to 12 by default. Nova currently"},{"line_number":5,"context_line":"    sets \u0027num_pcie_ports\u0027 to \"0\" (defaults to libvirt\u0027s \"1\"), which is"},{"line_number":6,"context_line":"    not sufficient for hotplug use with \u0027q35\u0027 machiine type."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Fixes an issue where \u0027q35\u0027 libvirt machine type VM couldn\u0027t hotplug"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b994c0f2_a69fcc13","line":6,"range":{"start_line":6,"start_character":51,"end_line":6,"end_character":52},"updated":"2023-08-28 14:39:25.000000000","message":"machine","commit_id":"01a7fd628d93d902b7151ede7524071fc029acde"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5c60948f40c4b13d7e642f03a2365656fb6c3625","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configure Nova libvirt.num_pcie_ports to 12 by default. Nova currently"},{"line_number":5,"context_line":"    sets \u0027num_pcie_ports\u0027 to \"0\" (defaults to libvirt\u0027s \"1\"), which is"},{"line_number":6,"context_line":"    not sufficient for hotplug use with \u0027q35\u0027 machiine type."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Fixes an issue where \u0027q35\u0027 libvirt machine type VM couldn\u0027t hotplug"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"6206c9a2_399b6f8f","line":6,"range":{"start_line":6,"start_character":51,"end_line":6,"end_character":52},"in_reply_to":"b994c0f2_a69fcc13","updated":"2023-08-29 07:24:15.000000000","message":"Done","commit_id":"01a7fd628d93d902b7151ede7524071fc029acde"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f348fb9a061635f34f5e5ffced52f91cde5497ee","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    not sufficient for hotplug use with \u0027q35\u0027 machiine type."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Fixes an issue where \u0027q35\u0027 libvirt machine type VM couldn\u0027t hotplug"},{"line_number":10,"context_line":"    more then one PCIe device at a time."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"298d7cbb_12005614","line":9,"range":{"start_line":9,"start_character":55,"end_line":9,"end_character":63},"updated":"2023-08-28 14:39:25.000000000","message":"could not\n\ndocs are formal, \"couldn\u0027t\" is not","commit_id":"01a7fd628d93d902b7151ede7524071fc029acde"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5c60948f40c4b13d7e642f03a2365656fb6c3625","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    not sufficient for hotplug use with \u0027q35\u0027 machiine type."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Fixes an issue where \u0027q35\u0027 libvirt machine type VM couldn\u0027t hotplug"},{"line_number":10,"context_line":"    more then one PCIe device at a time."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"a8d6bf3d_4f8f44ca","line":9,"range":{"start_line":9,"start_character":55,"end_line":9,"end_character":63},"in_reply_to":"298d7cbb_12005614","updated":"2023-08-29 07:24:15.000000000","message":"Done","commit_id":"01a7fd628d93d902b7151ede7524071fc029acde"}]}