)]}'
{"ansible/roles/monasca/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7dd14e1963d418e7adfbf36c3c4148ee511754c1","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# The default number of Kafka topic partitions. This effectively limits"},{"line_number":135,"context_line":"# the maximum number of workers per topic, counted over all nodes in the"},{"line_number":136,"context_line":"# Monasca deployment. For example, if you have a 3 node Monasca"},{"line_number":137,"context_line":"# deployment, you will by default have 3 instances of Monasca Persister,"},{"line_number":138,"context_line":"# with each instance having 2 workers by default for the metrics topic."},{"line_number":139,"context_line":"# In this case, each worker on the metrics topic will be assigned 5"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ecbdc161_c977d60f","line":136,"range":{"start_line":136,"start_character":50,"end_line":136,"end_character":51},"updated":"2021-02-15 15:07:38.000000000","message":"nit: -","commit_id":"e689f951f495874806e89bde1873d1a418e92160"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7dd14e1963d418e7adfbf36c3c4148ee511754c1","unresolved":true,"context_lines":[{"line_number":162,"context_line":"# workers, it is worth considering changing them. Note that if you do"},{"line_number":163,"context_line":"# change these settings, then you will need to manually remove each"},{"line_number":164,"context_line":"# topic from the Kafka deployment for the change to take effect when"},{"line_number":165,"context_line":"# the Monasca service is reconfigured."},{"line_number":166,"context_line":"monasca_all_topics:"},{"line_number":167,"context_line":"  - name: \"{{ monasca_metrics_topic }}\""},{"line_number":168,"context_line":"    partitions: \"{{ monasca_default_topic_partitions }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c0cfe276_17a8cdc1","line":165,"updated":"2021-02-15 15:07:38.000000000","message":"nit: The paragraph above needs a few more commas or rewording to be easier to digest but meh.","commit_id":"e689f951f495874806e89bde1873d1a418e92160"}],"ansible/roles/monasca/tasks/bootstrap.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7dd14e1963d418e7adfbf36c3c4148ee511754c1","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  delegate_to: \"{{ groups[\u0027influxdb\u0027][0] }}\""},{"line_number":62,"context_line":"  when: monasca_influxdb_name not in monasca_influxdb_database.stdout_lines"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# NOTE(dszumski): Although we can take advantage of automatic topic"},{"line_number":65,"context_line":"# creation in Kafka, creating the topics manually allows unique settings"},{"line_number":66,"context_line":"# to be used per topic, rather than the defaults. It also avoids an edge"},{"line_number":67,"context_line":"# case where services on multiple nodes may race to create topics, and"},{"line_number":68,"context_line":"# paves the way for enabling things like compression on a per topic basis."},{"line_number":69,"context_line":"- name: List monasca kafka topics"},{"line_number":70,"context_line":"  become: true"},{"line_number":71,"context_line":"  command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"03df899f_3fd5e9d3","line":68,"range":{"start_line":64,"start_character":18,"end_line":68,"end_character":74},"updated":"2021-02-15 15:07:38.000000000","message":"This change of the whole paragraph shows the evolution of a man. 😉","commit_id":"e689f951f495874806e89bde1873d1a418e92160"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"b4802a5d705047dc1d71fadc5f1fa974f6350829","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  delegate_to: \"{{ groups[\u0027influxdb\u0027][0] }}\""},{"line_number":62,"context_line":"  when: monasca_influxdb_name not in monasca_influxdb_database.stdout_lines"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# NOTE(dszumski): Although we can take advantage of automatic topic"},{"line_number":65,"context_line":"# creation in Kafka, creating the topics manually allows unique settings"},{"line_number":66,"context_line":"# to be used per topic, rather than the defaults. It also avoids an edge"},{"line_number":67,"context_line":"# case where services on multiple nodes may race to create topics, and"},{"line_number":68,"context_line":"# paves the way for enabling things like compression on a per topic basis."},{"line_number":69,"context_line":"- name: List monasca kafka topics"},{"line_number":70,"context_line":"  become: true"},{"line_number":71,"context_line":"  command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"49a50eac_9dbc3b7a","line":68,"range":{"start_line":64,"start_character":18,"end_line":68,"end_character":74},"in_reply_to":"03df899f_3fd5e9d3","updated":"2021-02-15 15:10:35.000000000","message":":) thanks for reviewing!","commit_id":"e689f951f495874806e89bde1873d1a418e92160"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"718dbed6df0c06a425ca536ab11c0c85a7312424","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    - item.enabled | bool"},{"line_number":93,"context_line":"  with_items: \"{{ monasca_all_topics }}\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"- name: Remove monasca kafka topics for disabled services"},{"line_number":96,"context_line":"  become: true"},{"line_number":97,"context_line":"  command: \u003e"},{"line_number":98,"context_line":"    docker exec kafka /opt/kafka/bin/kafka-topics.sh"},{"line_number":99,"context_line":"    --delete"},{"line_number":100,"context_line":"    --topic \"{{ item.name }}\""},{"line_number":101,"context_line":"    --zookeeper localhost"},{"line_number":102,"context_line":"  run_once: True"},{"line_number":103,"context_line":"  delegate_to: \"{{ groups[\u0027kafka\u0027][0] }}\""},{"line_number":104,"context_line":"  when:"},{"line_number":105,"context_line":"    - item.name in kafka_topics.stdout_lines"},{"line_number":106,"context_line":"    - not item.enabled | bool"},{"line_number":107,"context_line":"  with_items: \"{{ monasca_all_topics }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4a0a04b5_98d9faac","line":107,"range":{"start_line":95,"start_character":0,"end_line":107,"end_character":40},"updated":"2021-01-11 10:12:59.000000000","message":"Is there a risk of losing data we want to keep here?","commit_id":"e689f951f495874806e89bde1873d1a418e92160"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f032ef1467b4657f04aa1ed72a712db5f559a12b","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    - item.enabled | bool"},{"line_number":93,"context_line":"  with_items: \"{{ monasca_all_topics }}\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"- name: Remove monasca kafka topics for disabled services"},{"line_number":96,"context_line":"  become: true"},{"line_number":97,"context_line":"  command: \u003e"},{"line_number":98,"context_line":"    docker exec kafka /opt/kafka/bin/kafka-topics.sh"},{"line_number":99,"context_line":"    --delete"},{"line_number":100,"context_line":"    --topic \"{{ item.name }}\""},{"line_number":101,"context_line":"    --zookeeper localhost"},{"line_number":102,"context_line":"  run_once: True"},{"line_number":103,"context_line":"  delegate_to: \"{{ groups[\u0027kafka\u0027][0] }}\""},{"line_number":104,"context_line":"  when:"},{"line_number":105,"context_line":"    - item.name in kafka_topics.stdout_lines"},{"line_number":106,"context_line":"    - not item.enabled | bool"},{"line_number":107,"context_line":"  with_items: \"{{ monasca_all_topics }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"41eab888_4b763f94","line":107,"range":{"start_line":95,"start_character":0,"end_line":107,"end_character":40},"in_reply_to":"4a0a04b5_98d9faac","updated":"2021-01-11 11:01:50.000000000","message":"This task is really about cleaning up topics which are no longer in use, because a service that uses them has been disabled. It\u0027s intended to be triggered via a patch, rather than by a user manually tweaking topic configuration. Since the topics contain only transient data, I don\u0027t think there is much to worry about, although you could of course shoot yourself in the foot if you really wanted to.\n\nAn example might be disabling the alerting pipeline, and removing all associated topics. Sure, you might loose some imminent alerts if you disabled the pipeline, but then you\u0027d disabled the pipeline anyway, and likely wouldn\u0027t care about those alerts if you later re-enabled it.","commit_id":"e689f951f495874806e89bde1873d1a418e92160"}]}