)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dacb82b48e2051efc26c7a6e14a04b78c720c319","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-06-03 12:29:13 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow user to set sysctl_net_ipv4_tcp_retries2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is adding configuration option to"},{"line_number":10,"context_line":"manipulate with kernel option sysctl_net_ipv4_tcp_retries2."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9a4ab14c_ee980a15","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":46},"updated":"2021-06-03 12:28:27.000000000","message":"nit: wrong name","commit_id":"f79dcd4fb8e4ef6bb4cd893dfb7f979c50f9e03a"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"293596c56c7b9a970402d7bb11f8ab98a8c2c271","unresolved":true,"context_lines":[{"line_number":538,"context_line":""},{"line_number":539,"context_line":"# Avoid TCP connections refusing to die after VIP switch"},{"line_number":540,"context_line":"# https://bugs.launchpad.net/kolla-ansible/+bug/1917068"},{"line_number":541,"context_line":"sysctl_net_ipv4_tcp_retries2: 6"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"# Optionally change the path to sysctl.conf modified by Kolla Ansible plays."},{"line_number":544,"context_line":"kolla_sysctl_conf_path: /etc/sysctl.conf"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"63112c28_a244b4db","line":541,"range":{"start_line":541,"start_character":0,"end_line":541,"end_character":31},"updated":"2021-05-19 08:29:59.000000000","message":"do we need that in group_vars instead of role defaults?","commit_id":"818d7297e319c71f51794fd38da90f4c420ae8e5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"aac8ca92caaa77e17a74409fe31c144c1e7cd671","unresolved":true,"context_lines":[{"line_number":538,"context_line":""},{"line_number":539,"context_line":"# Avoid TCP connections refusing to die after VIP switch"},{"line_number":540,"context_line":"# https://bugs.launchpad.net/kolla-ansible/+bug/1917068"},{"line_number":541,"context_line":"sysctl_net_ipv4_tcp_retries2: 6"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"# Optionally change the path to sysctl.conf modified by Kolla Ansible plays."},{"line_number":544,"context_line":"kolla_sysctl_conf_path: /etc/sysctl.conf"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"33af8f01_40afbe25","line":541,"range":{"start_line":541,"start_character":0,"end_line":541,"end_character":31},"in_reply_to":"63112c28_a244b4db","updated":"2021-05-19 08:39:42.000000000","message":"Despite the fact that variable uses only haproxy role, I placed it in group_vars/all.yml because: \n\n1. There are other sysctl_ vars\n2. The variable affects the behavior of the TCP connections","commit_id":"818d7297e319c71f51794fd38da90f4c420ae8e5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"876ecb91406dc938ab4976471d23edb9789af026","unresolved":true,"context_lines":[{"line_number":538,"context_line":""},{"line_number":539,"context_line":"# Avoid TCP connections refusing to die after VIP switch"},{"line_number":540,"context_line":"# https://bugs.launchpad.net/kolla-ansible/+bug/1917068"},{"line_number":541,"context_line":"sysctl_net_ipv4_tcp_retries2: \"KOLLA_UNSET\""},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"# Optionally change the path to sysctl.conf modified by Kolla Ansible plays."},{"line_number":544,"context_line":"kolla_sysctl_conf_path: /etc/sysctl.conf"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"8d6be55d_56abaae3","line":541,"range":{"start_line":541,"start_character":0,"end_line":541,"end_character":28},"updated":"2021-06-03 10:08:47.000000000","message":"Just comparing with other similar options, we have e.g. neutron_l3_agent_host_ipv4_neigh_gc_thresh1 and nova_compute_host_rp_filter_mode. I\u0027d peronally prefer a haproxy_ prefix to this, and probably put the default in haproxy defaults.","commit_id":"a492748366b8d985b1d22e1b7f5009baaa738f9d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5a8945dce5769a0571ab0b167bde2e706b021109","unresolved":true,"context_lines":[{"line_number":538,"context_line":""},{"line_number":539,"context_line":"# Avoid TCP connections refusing to die after VIP switch"},{"line_number":540,"context_line":"# https://bugs.launchpad.net/kolla-ansible/+bug/1917068"},{"line_number":541,"context_line":"sysctl_net_ipv4_tcp_retries2: \"KOLLA_UNSET\""},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"# Optionally change the path to sysctl.conf modified by Kolla Ansible plays."},{"line_number":544,"context_line":"kolla_sysctl_conf_path: /etc/sysctl.conf"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a37f4ef8_526e0610","line":541,"range":{"start_line":541,"start_character":0,"end_line":541,"end_character":28},"in_reply_to":"8d6be55d_56abaae3","updated":"2021-06-03 10:20:25.000000000","message":"Well, but that doesn\u0027t mean that naming conventon is right at the moment, from my perspective of view you are changing sysctl variables, it\u0027s changing behaviour of underlaying system or let\u0027s say TCP layer.\n\nBut I don\u0027t care, it\u0027s important to get into master, not what it\u0027s called.\nWill upload in 5 minutes.","commit_id":"a492748366b8d985b1d22e1b7f5009baaa738f9d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"079778406869b67e75ece1aa3ebb93c216cd7f01","unresolved":true,"context_lines":[{"line_number":538,"context_line":""},{"line_number":539,"context_line":"# Avoid TCP connections refusing to die after VIP switch"},{"line_number":540,"context_line":"# https://bugs.launchpad.net/kolla-ansible/+bug/1917068"},{"line_number":541,"context_line":"sysctl_net_ipv4_tcp_retries2: \"KOLLA_UNSET\""},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"# Optionally change the path to sysctl.conf modified by Kolla Ansible plays."},{"line_number":544,"context_line":"kolla_sysctl_conf_path: /etc/sysctl.conf"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"cde63376_893d0772","line":541,"range":{"start_line":541,"start_character":0,"end_line":541,"end_character":28},"in_reply_to":"a37f4ef8_526e0610","updated":"2021-06-03 10:44:40.000000000","message":"Scope is important! This sysctl only applies to hosts running haproxy, which is a minority in most clouds.","commit_id":"a492748366b8d985b1d22e1b7f5009baaa738f9d"}],"ansible/roles/haproxy/tasks/config-host.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"293596c56c7b9a970402d7bb11f8ab98a8c2c271","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    sysctl_file: \"{{ kolla_sysctl_conf_path }}\""},{"line_number":11,"context_line":"  become: true"},{"line_number":12,"context_line":"  with_items:"},{"line_number":13,"context_line":"    - { name: \"net.ipv4.ip_nonlocal_bind\", value: 1 }"},{"line_number":14,"context_line":"    - { name: \"net.ipv6.ip_nonlocal_bind\", value: 1 }"},{"line_number":15,"context_line":"    - { name: \"net.ipv4.tcp_retries2\", value: \"{{ sysctl_net_ipv4_tcp_retries2 }}\" }"},{"line_number":16,"context_line":"    - { name: \"net.unix.max_dgram_qlen\", value: 128 }"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a9ca02f7_59918868","line":13,"range":{"start_line":13,"start_character":51,"end_line":13,"end_character":53},"updated":"2021-05-19 08:29:59.000000000","message":"why the trailing spaces?","commit_id":"818d7297e319c71f51794fd38da90f4c420ae8e5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"aac8ca92caaa77e17a74409fe31c144c1e7cd671","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    sysctl_file: \"{{ kolla_sysctl_conf_path }}\""},{"line_number":11,"context_line":"  become: true"},{"line_number":12,"context_line":"  with_items:"},{"line_number":13,"context_line":"    - { name: \"net.ipv4.ip_nonlocal_bind\", value: 1 }"},{"line_number":14,"context_line":"    - { name: \"net.ipv6.ip_nonlocal_bind\", value: 1 }"},{"line_number":15,"context_line":"    - { name: \"net.ipv4.tcp_retries2\", value: \"{{ sysctl_net_ipv4_tcp_retries2 }}\" }"},{"line_number":16,"context_line":"    - { name: \"net.unix.max_dgram_qlen\", value: 128 }"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"984ff43b_5f1e9721","line":13,"range":{"start_line":13,"start_character":51,"end_line":13,"end_character":53},"in_reply_to":"a9ca02f7_59918868","updated":"2021-05-19 08:39:42.000000000","message":"Well, it\u0027s just cosmetic :) \nTrailing space is at beggining, and should be also at the end. This coding style is used everywhere. I\u0027ve just straightened other items.","commit_id":"818d7297e319c71f51794fd38da90f4c420ae8e5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1c077a4c6dff04c9181785eac7fdbaf9da9a95c0","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  with_items:"},{"line_number":13,"context_line":"    - { name: \"net.ipv4.ip_nonlocal_bind\", value: 1 }"},{"line_number":14,"context_line":"    - { name: \"net.ipv6.ip_nonlocal_bind\", value: 1 }"},{"line_number":15,"context_line":"    - { name: \"net.ipv4.tcp_retries2\", value: \"{{ haproxy_host_ipv4_tcp_retries2 }}\" }"},{"line_number":16,"context_line":"    - { name: \"net.unix.max_dgram_qlen\", value: 128 }"},{"line_number":17,"context_line":"  when:"},{"line_number":18,"context_line":"    - set_sysctl | bool"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"4bc84df2_b63692e1","line":15,"updated":"2021-06-23 09:15:25.000000000","message":"Thinking about this again, isn\u0027t this option relevant to clients of haproxy, rather than haproxy itself? i.e. compute nodes could still suffer from this issue?","commit_id":"163c407e98de72461b14c3cefcf7d0311921d52a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"fae975826ba3f9b0bfa915867f4f6128cefc910a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  with_items:"},{"line_number":13,"context_line":"    - { name: \"net.ipv4.ip_nonlocal_bind\", value: 1 }"},{"line_number":14,"context_line":"    - { name: \"net.ipv6.ip_nonlocal_bind\", value: 1 }"},{"line_number":15,"context_line":"    - { name: \"net.ipv4.tcp_retries2\", value: \"{{ haproxy_host_ipv4_tcp_retries2 }}\" }"},{"line_number":16,"context_line":"    - { name: \"net.unix.max_dgram_qlen\", value: 128 }"},{"line_number":17,"context_line":"  when:"},{"line_number":18,"context_line":"    - set_sysctl | bool"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ed620af7_1b70d869","line":15,"in_reply_to":"26819c96_d00b9155","updated":"2021-06-23 10:00:17.000000000","message":"Yes, exactly","commit_id":"163c407e98de72461b14c3cefcf7d0311921d52a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6fce283ea2e84ec0ad03696054467f049588addb","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  with_items:"},{"line_number":13,"context_line":"    - { name: \"net.ipv4.ip_nonlocal_bind\", value: 1 }"},{"line_number":14,"context_line":"    - { name: \"net.ipv6.ip_nonlocal_bind\", value: 1 }"},{"line_number":15,"context_line":"    - { name: \"net.ipv4.tcp_retries2\", value: \"{{ haproxy_host_ipv4_tcp_retries2 }}\" }"},{"line_number":16,"context_line":"    - { name: \"net.unix.max_dgram_qlen\", value: 128 }"},{"line_number":17,"context_line":"  when:"},{"line_number":18,"context_line":"    - set_sysctl | bool"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"26819c96_d00b9155","line":15,"in_reply_to":"427276fe_13c5921d","updated":"2021-06-23 09:59:21.000000000","message":"Ah, I remember - it affected the host that previously had the VIP.","commit_id":"163c407e98de72461b14c3cefcf7d0311921d52a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cf9cd6fb5883f694d41e775ea058cc5777774efa","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  with_items:"},{"line_number":13,"context_line":"    - { name: \"net.ipv4.ip_nonlocal_bind\", value: 1 }"},{"line_number":14,"context_line":"    - { name: \"net.ipv6.ip_nonlocal_bind\", value: 1 }"},{"line_number":15,"context_line":"    - { name: \"net.ipv4.tcp_retries2\", value: \"{{ haproxy_host_ipv4_tcp_retries2 }}\" }"},{"line_number":16,"context_line":"    - { name: \"net.unix.max_dgram_qlen\", value: 128 }"},{"line_number":17,"context_line":"  when:"},{"line_number":18,"context_line":"    - set_sysctl | bool"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"427276fe_13c5921d","line":15,"in_reply_to":"4bc84df2_b63692e1","updated":"2021-06-23 09:32:27.000000000","message":"Well, when I\u0027ve tested it, it was problem only on server, because clients were able to \"fix\" this issue quite quickly - because GARP was send and clients were OK.\n\nProblem was on server side because that connection was stucked in kernel somehow.","commit_id":"163c407e98de72461b14c3cefcf7d0311921d52a"}],"doc/source/reference/high-availability/haproxy-guide.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1c077a4c6dff04c9181785eac7fdbaf9da9a95c0","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Openstack and other services. High-availability in kolla"},{"line_number":9,"context_line":"is implented as pair of Keepalived which holds virtual IP"},{"line_number":10,"context_line":"and Haproxy which do load-balancing of traffic to service backends."},{"line_number":11,"context_line":"These two components has to be installed on same baremetals"},{"line_number":12,"context_line":"and they are installed to group haproxy by default."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Preparation and deployment"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7221c4df_b1c2e036","line":11,"range":{"start_line":11,"start_character":49,"end_line":11,"end_character":59},"updated":"2021-06-23 09:15:25.000000000","message":"nit: could be VMs","commit_id":"f1be1442f50e40d164f3e869f460fe220daa85fc"}],"releasenotes/notes/fix-TCP-connections-refusing-to-die-after-VIP-switch-5f9e811783c36041.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"293596c56c7b9a970402d7bb11f8ab98a8c2c271","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with stucked connections in case of VIP failover."},{"line_number":5,"context_line":"    See `bug 1917068 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1917068\u003e`__ for details."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"68f9815f_ee1ea2c9","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":92},"updated":"2021-05-19 08:29:59.000000000","message":"I think it would be better to write that a variable has been introduced and what is it\u0027s default value.","commit_id":"818d7297e319c71f51794fd38da90f4c420ae8e5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3f93472f4956f8ea7ba3215865b38d20e3d17064","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with stucked connections in case of VIP failover."},{"line_number":5,"context_line":"    See `bug 1917068 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1917068\u003e`__ for details."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Added a new configuration variable, ``sysctl_net_ipv4_tcp_retries2``, which"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9c97f1a1_0c68814a","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":92},"updated":"2021-05-21 09:10:21.000000000","message":"so, there actually is no fix in place as the default does not fix the situation","commit_id":"3898c85cef5ba0a534d0d84bb62029560996af5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f5033178d00278c2bd3d50a54fd935522ab5c202","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with stucked connections in case of VIP failover."},{"line_number":5,"context_line":"    See `bug 1917068 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1917068\u003e`__ for details."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Added a new configuration variable, ``sysctl_net_ipv4_tcp_retries2``, which"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9111f7c6_ce80474f","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":92},"in_reply_to":"1a6f53d7_1f15963e","updated":"2021-06-02 07:44:57.000000000","message":"Done","commit_id":"3898c85cef5ba0a534d0d84bb62029560996af5f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"895b678bc002392366b5e32b63acf0285a1b0175","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with stucked connections in case of VIP failover."},{"line_number":5,"context_line":"    See `bug 1917068 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1917068\u003e`__ for details."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Added a new configuration variable, ``sysctl_net_ipv4_tcp_retries2``, which"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a6f53d7_1f15963e","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":92},"in_reply_to":"21de7e06_82e16ab6","updated":"2021-05-31 16:30:41.000000000","message":"Yeah, I think move this part to features, something like: \u0027This variable can be used to mitigate an issue with stuck connections in case of VIP failover, see bug ...\u0027","commit_id":"3898c85cef5ba0a534d0d84bb62029560996af5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8b5cce7693e5f9654051affc42f91798be9d1cec","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with stucked connections in case of VIP failover."},{"line_number":5,"context_line":"    See `bug 1917068 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1917068\u003e`__ for details."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Added a new configuration variable, ``sysctl_net_ipv4_tcp_retries2``, which"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"21de7e06_82e16ab6","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":92},"in_reply_to":"9c97f1a1_0c68814a","updated":"2021-05-31 16:27:53.000000000","message":"So, should I reword fixes: , or just remove it and add link to bug to features ?","commit_id":"3898c85cef5ba0a534d0d84bb62029560996af5f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"895b678bc002392366b5e32b63acf0285a1b0175","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    This option set maximum number of times a TCP packet is retransmitted"},{"line_number":11,"context_line":"    in established state before giving up. The default kernel value is 15,"},{"line_number":12,"context_line":"    which corresponds to a duration of approximately between 13 to 30"},{"line_number":13,"context_line":"    minutes, depending on the retransmission timeout. Default kolla value"},{"line_number":14,"context_line":"    is undefined and depends on a user."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2cb3565d_4794f59b","line":14,"range":{"start_line":13,"start_character":54,"end_line":14,"end_character":39},"updated":"2021-05-31 16:30:41.000000000","message":"we can drop this sentence, it brings nothing except confusion","commit_id":"3898c85cef5ba0a534d0d84bb62029560996af5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f5033178d00278c2bd3d50a54fd935522ab5c202","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    This option set maximum number of times a TCP packet is retransmitted"},{"line_number":11,"context_line":"    in established state before giving up. The default kernel value is 15,"},{"line_number":12,"context_line":"    which corresponds to a duration of approximately between 13 to 30"},{"line_number":13,"context_line":"    minutes, depending on the retransmission timeout. Default kolla value"},{"line_number":14,"context_line":"    is undefined and depends on a user."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9062c5cc_0ae94c25","line":14,"range":{"start_line":13,"start_character":54,"end_line":14,"end_character":39},"in_reply_to":"2cb3565d_4794f59b","updated":"2021-06-02 07:44:57.000000000","message":"Done","commit_id":"3898c85cef5ba0a534d0d84bb62029560996af5f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"855e5497fca2da23a9f215eb8862595bab2e2a36","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new configuration variable, ``sysctl_net_ipv4_tcp_retries2``, which"},{"line_number":5,"context_line":"    allows users to modify this kernel option."},{"line_number":6,"context_line":"    This option set maximum number of times a TCP packet is retransmitted"},{"line_number":7,"context_line":"    in established state before giving up. The default kernel value is 15,"},{"line_number":8,"context_line":"    which corresponds to a duration of approximately between 13 to 30"},{"line_number":9,"context_line":"    minutes, depending on the retransmission timeout. This variable can be used"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1acbbb45_ffd0861e","line":6,"range":{"start_line":6,"start_character":16,"end_line":6,"end_character":20},"updated":"2021-06-02 17:15:02.000000000","message":"nit: \"sets\"","commit_id":"f74a850db28ddc09437402d9d6aeeea2c90f168f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7c27eecb983c906145d6a2fe6a592d14d63796cf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new configuration variable, ``sysctl_net_ipv4_tcp_retries2``, which"},{"line_number":5,"context_line":"    allows users to modify this kernel option."},{"line_number":6,"context_line":"    This option set maximum number of times a TCP packet is retransmitted"},{"line_number":7,"context_line":"    in established state before giving up. The default kernel value is 15,"},{"line_number":8,"context_line":"    which corresponds to a duration of approximately between 13 to 30"},{"line_number":9,"context_line":"    minutes, depending on the retransmission timeout. This variable can be used"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"85566650_18196f24","line":6,"range":{"start_line":6,"start_character":16,"end_line":6,"end_character":20},"in_reply_to":"1acbbb45_ffd0861e","updated":"2021-06-02 17:21:32.000000000","message":"Done","commit_id":"f74a850db28ddc09437402d9d6aeeea2c90f168f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"876ecb91406dc938ab4976471d23edb9789af026","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new configuration variable, ``sysctl_net_ipv4_tcp_retries2``, which"},{"line_number":5,"context_line":"    allows users to modify this kernel option."},{"line_number":6,"context_line":"    This option sets maximum number of times a TCP packet is retransmitted"},{"line_number":7,"context_line":"    in established state before giving up. The default kernel value is 15,"},{"line_number":8,"context_line":"    which corresponds to a duration of approximately between 13 to 30"},{"line_number":9,"context_line":"    minutes, depending on the retransmission timeout. This variable can be used"},{"line_number":10,"context_line":"    to mitigate an issue with stuck connections in case of VIP failover,"},{"line_number":11,"context_line":"    see `bug 1917068 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1917068\u003e`__"},{"line_number":12,"context_line":"    for details."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"2f681fdb_07a15857","line":12,"range":{"start_line":4,"start_character":0,"end_line":12,"end_character":16},"updated":"2021-06-03 10:08:47.000000000","message":"It would be nice if this was contained in some HAProxy docs (that do not currently exist).","commit_id":"a492748366b8d985b1d22e1b7f5009baaa738f9d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5a8945dce5769a0571ab0b167bde2e706b021109","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new configuration variable, ``sysctl_net_ipv4_tcp_retries2``, which"},{"line_number":5,"context_line":"    allows users to modify this kernel option."},{"line_number":6,"context_line":"    This option sets maximum number of times a TCP packet is retransmitted"},{"line_number":7,"context_line":"    in established state before giving up. The default kernel value is 15,"},{"line_number":8,"context_line":"    which corresponds to a duration of approximately between 13 to 30"},{"line_number":9,"context_line":"    minutes, depending on the retransmission timeout. This variable can be used"},{"line_number":10,"context_line":"    to mitigate an issue with stuck connections in case of VIP failover,"},{"line_number":11,"context_line":"    see `bug 1917068 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1917068\u003e`__"},{"line_number":12,"context_line":"    for details."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f1a88146_ed93d6ea","line":12,"range":{"start_line":4,"start_character":0,"end_line":12,"end_character":16},"in_reply_to":"2f681fdb_07a15857","updated":"2021-06-03 10:20:25.000000000","message":"Agree, can provide in follow up patches with proxysql also.","commit_id":"a492748366b8d985b1d22e1b7f5009baaa738f9d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"079778406869b67e75ece1aa3ebb93c216cd7f01","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new configuration variable, ``sysctl_net_ipv4_tcp_retries2``, which"},{"line_number":5,"context_line":"    allows users to modify this kernel option."},{"line_number":6,"context_line":"    This option sets maximum number of times a TCP packet is retransmitted"},{"line_number":7,"context_line":"    in established state before giving up. The default kernel value is 15,"},{"line_number":8,"context_line":"    which corresponds to a duration of approximately between 13 to 30"},{"line_number":9,"context_line":"    minutes, depending on the retransmission timeout. This variable can be used"},{"line_number":10,"context_line":"    to mitigate an issue with stuck connections in case of VIP failover,"},{"line_number":11,"context_line":"    see `bug 1917068 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1917068\u003e`__"},{"line_number":12,"context_line":"    for details."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ffecc987_d05b9754","line":12,"range":{"start_line":4,"start_character":0,"end_line":12,"end_character":16},"in_reply_to":"f1a88146_ed93d6ea","updated":"2021-06-03 10:44:40.000000000","message":"Let\u0027s not couple it with proxysql. I had to ask a few times for mariadb docs, so I\u0027d prefer to have these in this patch. Should be pretty quick.","commit_id":"a492748366b8d985b1d22e1b7f5009baaa738f9d"}]}