)]}'
{"ansible/action_plugins/merge_configs.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3a0b48a2665cd4d0b1a548456ff640cedaada838","unresolved":true,"context_lines":[{"line_number":117,"context_line":"                    fp.write(\u0027{}{}\u003d\\n\u0027.format(key, self._whitespace))"},{"line_number":118,"context_line":"                for index, value in enumerate(v):"},{"line_number":119,"context_line":"                    if index \u003d\u003d 0:"},{"line_number":120,"context_line":"                        fp.write(\u0027{}{}\u003d{}{}\\n\u0027.format("},{"line_number":121,"context_line":"                            key, self._whitespace, self._whitespace, value))"},{"line_number":122,"context_line":"                    else:"},{"line_number":123,"context_line":"                        whitespace \u003d \u0027 \u0027 * (len(self._whitespace) * 2 + 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"295ed40c_cd78c9e5","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":54},"updated":"2021-03-05 09:58:55.000000000","message":"nit: you could label these to make the format simpler? eg: `\u0027{0}{1}\u003d{1}{2}\\n\u0027.format(key, self._whitespace, value)`","commit_id":"23b43687c00173028cb615e924e8e6b85c38cf22"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f01d55dce04390a5b3afc3375f96633afad40c7d","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    fp.write(\u0027{}{}\u003d\\n\u0027.format(key, self._whitespace))"},{"line_number":118,"context_line":"                for index, value in enumerate(v):"},{"line_number":119,"context_line":"                    if index \u003d\u003d 0:"},{"line_number":120,"context_line":"                        fp.write(\u0027{}{}\u003d{}{}\\n\u0027.format("},{"line_number":121,"context_line":"                            key, self._whitespace, self._whitespace, value))"},{"line_number":122,"context_line":"                    else:"},{"line_number":123,"context_line":"                        whitespace \u003d \u0027 \u0027 * (len(self._whitespace) * 2 + 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"846c8f7f_5f373c40","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":54},"in_reply_to":"295ed40c_cd78c9e5","updated":"2021-03-05 14:18:17.000000000","message":"Good idea. I went with variable-based formatting instead of numbers to make it even more readable.","commit_id":"23b43687c00173028cb615e924e8e6b85c38cf22"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3a0b48a2665cd4d0b1a548456ff640cedaada838","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                        fp.write(\u0027{}{}\u003d{}{}\\n\u0027.format("},{"line_number":121,"context_line":"                            key, self._whitespace, self._whitespace, value))"},{"line_number":122,"context_line":"                    else:"},{"line_number":123,"context_line":"                        whitespace \u003d \u0027 \u0027 * (len(self._whitespace) * 2 + 1)"},{"line_number":124,"context_line":"                        fp.write(\u0027{}{}{}\\n\u0027.format("},{"line_number":125,"context_line":"                            len(key) * \u0027 \u0027, whitespace, value))"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a7c5cbf8_7b7f227f","line":123,"updated":"2021-03-05 09:58:55.000000000","message":"nit: What do you think about combining this whitespace calculation with the one for the length of the key and just calling it \u0027indent\u0027 or something similar?","commit_id":"23b43687c00173028cb615e924e8e6b85c38cf22"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f01d55dce04390a5b3afc3375f96633afad40c7d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                        fp.write(\u0027{}{}\u003d{}{}\\n\u0027.format("},{"line_number":121,"context_line":"                            key, self._whitespace, self._whitespace, value))"},{"line_number":122,"context_line":"                    else:"},{"line_number":123,"context_line":"                        whitespace \u003d \u0027 \u0027 * (len(self._whitespace) * 2 + 1)"},{"line_number":124,"context_line":"                        fp.write(\u0027{}{}{}\\n\u0027.format("},{"line_number":125,"context_line":"                            len(key) * \u0027 \u0027, whitespace, value))"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f5e1211_ebf75fdc","line":123,"in_reply_to":"a7c5cbf8_7b7f227f","updated":"2021-03-05 14:18:17.000000000","message":"I was thinking the same while reading again this patch today. Done.","commit_id":"23b43687c00173028cb615e924e8e6b85c38cf22"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"de6eba7fe3451eb71673550ddcb4ce606682c956","unresolved":true,"context_lines":[{"line_number":123,"context_line":"                            ws\u003dself._whitespace,"},{"line_number":124,"context_line":"                            value\u003dvalue))"},{"line_number":125,"context_line":"                    else:"},{"line_number":126,"context_line":"                        indent_size \u003d len(key) + len(self._whitespace) * 2 + 1"},{"line_number":127,"context_line":"                        ws_indent \u003d \u0027 \u0027 * indent_size"},{"line_number":128,"context_line":"                        fp.write(\u0027{ws_indent}{value}\\n\u0027.format("},{"line_number":129,"context_line":"                            ws_indent\u003dws_indent,"}],"source_content_type":"text/x-python","patch_set":2,"id":"465b0ede_166e99e6","line":126,"updated":"2021-03-07 09:38:24.000000000","message":"could use a comment","commit_id":"2b723ead051b7f722ad61db1bb65a07259817719"}]}