)]}'
{"ansible/roles/ovn/tasks/bootstrap.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dfc06616709644200612896d4557cbbcd54d80bf","unresolved":true,"context_lines":[{"line_number":12,"context_line":"- name: Configure OVN in OVSDB"},{"line_number":13,"context_line":"  vars:"},{"line_number":14,"context_line":"    ovn_mappings: \"{% for bridge in neutron_bridge_name.split(\u0027,\u0027) %}physnet{{ loop.index0 + 1 }}:{{ bridge }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":15,"context_line":"    ovn_macs: \"{% for bridge in neutron_bridge_name.split(\u0027,\u0027) %}physnet{{ loop.index0 + 1 }}:{{ ovn_base_mac | random_mac(seed\u003dinventory_hostname) }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":16,"context_line":"    ovn_cms_opts: \"{{ \u0027enable-chassis-as-gw\u0027 if inventory_hostname in groups[\u0027ovn-controller-network\u0027] else \u0027\u0027 }}\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  kolla_toolbox:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5d28a81c_3b54d0ee","line":15,"range":{"start_line":15,"start_character":112,"end_line":15,"end_character":147},"updated":"2021-03-24 11:44:21.000000000","message":"I think these will all get the same MAC. Is that an issue?","commit_id":"6a199b3053955854d8dac692abcd3a40e42fd21e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c328ec1029139cff2c99e0975adf98c6c192447b","unresolved":true,"context_lines":[{"line_number":12,"context_line":"- name: Configure OVN in OVSDB"},{"line_number":13,"context_line":"  vars:"},{"line_number":14,"context_line":"    ovn_mappings: \"{% for bridge in neutron_bridge_name.split(\u0027,\u0027) %}physnet{{ loop.index0 + 1 }}:{{ bridge }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":15,"context_line":"    ovn_macs: \"{% for bridge in neutron_bridge_name.split(\u0027,\u0027) %}physnet{{ loop.index0 + 1 }}:{{ ovn_base_mac | random_mac(seed\u003dinventory_hostname) }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":16,"context_line":"    ovn_cms_opts: \"{{ \u0027enable-chassis-as-gw\u0027 if inventory_hostname in groups[\u0027ovn-controller-network\u0027] else \u0027\u0027 }}\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  kolla_toolbox:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a7aa1a45_9fef8c44","line":15,"range":{"start_line":15,"start_character":112,"end_line":15,"end_character":147},"in_reply_to":"5d28a81c_3b54d0ee","updated":"2021-03-24 11:56:38.000000000","message":"Well, it\u0027s only for upstream physical switches to not go crazy - I assume multiple physnets don\u0027t get cabled to the same switch and/or vlan.","commit_id":"6a199b3053955854d8dac692abcd3a40e42fd21e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"65a6b2780346ba4d9d30ffb5853dc8bb6aa9326d","unresolved":true,"context_lines":[{"line_number":12,"context_line":"- name: Configure OVN in OVSDB"},{"line_number":13,"context_line":"  vars:"},{"line_number":14,"context_line":"    ovn_mappings: \"{% for bridge in neutron_bridge_name.split(\u0027,\u0027) %}physnet{{ loop.index0 + 1 }}:{{ bridge }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":15,"context_line":"    ovn_macs: \"{% for bridge in neutron_bridge_name.split(\u0027,\u0027) %}physnet{{ loop.index0 + 1 }}:{{ ovn_base_mac | random_mac(seed\u003dinventory_hostname) }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":16,"context_line":"    ovn_cms_opts: \"{{ \u0027enable-chassis-as-gw\u0027 if inventory_hostname in groups[\u0027ovn-controller-network\u0027] else \u0027\u0027 }}\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  kolla_toolbox:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"01040979_886ea594","line":15,"range":{"start_line":15,"start_character":112,"end_line":15,"end_character":147},"in_reply_to":"a7aa1a45_9fef8c44","updated":"2021-03-24 12:11:51.000000000","message":"Probably not. We could add the index to the seed just in case though.","commit_id":"6a199b3053955854d8dac692abcd3a40e42fd21e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"48806456c06b2d7be5625ab0e148a75b46c664dd","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    - { name: ovn-encap-type, value: geneve }"},{"line_number":31,"context_line":"    - { name: ovn-remote, value: \"{{ ovn_sb_connection }}\" }"},{"line_number":32,"context_line":"    - { name: ovn-remote-probe-interval, value: \"{{ ovn_remote_probe_interval }}\" }"},{"line_number":33,"context_line":"    - { name: ovn-bridge-mappings, value: \"{{ ovn_mappings if (inventory_hostname in groups[\u0027ovn-controller-network\u0027] or computes_need_external_bridge | bool) else omit }}\", state: \"{{ \u0027present\u0027 if (inventory_hostname in groups[\u0027ovn-controller-network\u0027] or computes_need_external_bridge | bool) else \u0027absent\u0027 }}\" }"},{"line_number":34,"context_line":"    - { name: ovn-chassis-mac-mappings, value: \"{{ ovn_macs if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else omit }}\", state: \"{{ \u0027present\u0027 if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else \u0027absent\u0027 }}\" }"},{"line_number":35,"context_line":"    - { name: ovn-cms-options, value: \"{{ ovn_cms_opts }}\", state: \"{{ \u0027present\u0027 if ovn_cms_opts !\u003d \u0027\u0027 else \u0027absent\u0027 }}\" }"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d741da17_231b6286","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":314},"updated":"2021-04-27 12:36:14.000000000","message":"This one has been changed. Is it intentional?","commit_id":"354ee28d851273a96f40f37d074951b8d2613953"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f534d20271597e9f482670435b9fb9c610deb8a2","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    - { name: ovn-encap-type, value: geneve }"},{"line_number":31,"context_line":"    - { name: ovn-remote, value: \"{{ ovn_sb_connection }}\" }"},{"line_number":32,"context_line":"    - { name: ovn-remote-probe-interval, value: \"{{ ovn_remote_probe_interval }}\" }"},{"line_number":33,"context_line":"    - { name: ovn-bridge-mappings, value: \"{{ ovn_mappings if (inventory_hostname in groups[\u0027ovn-controller-network\u0027] or computes_need_external_bridge | bool) else omit }}\", state: \"{{ \u0027present\u0027 if (inventory_hostname in groups[\u0027ovn-controller-network\u0027] or computes_need_external_bridge | bool) else \u0027absent\u0027 }}\" }"},{"line_number":34,"context_line":"    - { name: ovn-chassis-mac-mappings, value: \"{{ ovn_macs if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else omit }}\", state: \"{{ \u0027present\u0027 if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else \u0027absent\u0027 }}\" }"},{"line_number":35,"context_line":"    - { name: ovn-cms-options, value: \"{{ ovn_cms_opts }}\", state: \"{{ \u0027present\u0027 if ovn_cms_opts !\u003d \u0027\u0027 else \u0027absent\u0027 }}\" }"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"94cdefa2_c3fe797d","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":314},"in_reply_to":"2973af52_d7388bf2","updated":"2021-05-07 08:59:49.000000000","message":"I guess?","commit_id":"354ee28d851273a96f40f37d074951b8d2613953"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bc90d2ad40ed2970a247c04bde39bbb20d3d4be0","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    - { name: ovn-encap-type, value: geneve }"},{"line_number":31,"context_line":"    - { name: ovn-remote, value: \"{{ ovn_sb_connection }}\" }"},{"line_number":32,"context_line":"    - { name: ovn-remote-probe-interval, value: \"{{ ovn_remote_probe_interval }}\" }"},{"line_number":33,"context_line":"    - { name: ovn-bridge-mappings, value: \"{{ ovn_mappings if (inventory_hostname in groups[\u0027ovn-controller-network\u0027] or computes_need_external_bridge | bool) else omit }}\", state: \"{{ \u0027present\u0027 if (inventory_hostname in groups[\u0027ovn-controller-network\u0027] or computes_need_external_bridge | bool) else \u0027absent\u0027 }}\" }"},{"line_number":34,"context_line":"    - { name: ovn-chassis-mac-mappings, value: \"{{ ovn_macs if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else omit }}\", state: \"{{ \u0027present\u0027 if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else \u0027absent\u0027 }}\" }"},{"line_number":35,"context_line":"    - { name: ovn-cms-options, value: \"{{ ovn_cms_opts }}\", state: \"{{ \u0027present\u0027 if ovn_cms_opts !\u003d \u0027\u0027 else \u0027absent\u0027 }}\" }"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e92c0b84_86b76483","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":314},"in_reply_to":"a35997ff_df2e70e9","updated":"2021-05-05 16:15:54.000000000","message":"Don\u0027t we want to backport this one change as fix?","commit_id":"354ee28d851273a96f40f37d074951b8d2613953"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8dbb18b8b85f44d6ece7d226c8ddfaf5f40c97f2","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    - { name: ovn-encap-type, value: geneve }"},{"line_number":31,"context_line":"    - { name: ovn-remote, value: \"{{ ovn_sb_connection }}\" }"},{"line_number":32,"context_line":"    - { name: ovn-remote-probe-interval, value: \"{{ ovn_remote_probe_interval }}\" }"},{"line_number":33,"context_line":"    - { name: ovn-bridge-mappings, value: \"{{ ovn_mappings if (inventory_hostname in groups[\u0027ovn-controller-network\u0027] or computes_need_external_bridge | bool) else omit }}\", state: \"{{ \u0027present\u0027 if (inventory_hostname in groups[\u0027ovn-controller-network\u0027] or computes_need_external_bridge | bool) else \u0027absent\u0027 }}\" }"},{"line_number":34,"context_line":"    - { name: ovn-chassis-mac-mappings, value: \"{{ ovn_macs if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else omit }}\", state: \"{{ \u0027present\u0027 if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else \u0027absent\u0027 }}\" }"},{"line_number":35,"context_line":"    - { name: ovn-cms-options, value: \"{{ ovn_cms_opts }}\", state: \"{{ \u0027present\u0027 if ovn_cms_opts !\u003d \u0027\u0027 else \u0027absent\u0027 }}\" }"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a35997ff_df2e70e9","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":314},"in_reply_to":"a69a49bd_9f27c00a","updated":"2021-04-28 08:34:32.000000000","message":"It might be more DRY to handle this via module args:\n\n value: \"{{ item.value if item.state | default(\u0027present\u0027) \u003d\u003d \u0027present\u0027 else omit }}\"\n\nThis way is fine though.","commit_id":"354ee28d851273a96f40f37d074951b8d2613953"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"3e6a17f626ee9fe65a658046e55ff1687ea0b5c6","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    - { name: ovn-encap-type, value: geneve }"},{"line_number":31,"context_line":"    - { name: ovn-remote, value: \"{{ ovn_sb_connection }}\" }"},{"line_number":32,"context_line":"    - { name: ovn-remote-probe-interval, value: \"{{ ovn_remote_probe_interval }}\" }"},{"line_number":33,"context_line":"    - { name: ovn-bridge-mappings, value: \"{{ ovn_mappings if (inventory_hostname in groups[\u0027ovn-controller-network\u0027] or computes_need_external_bridge | bool) else omit }}\", state: \"{{ \u0027present\u0027 if (inventory_hostname in groups[\u0027ovn-controller-network\u0027] or computes_need_external_bridge | bool) else \u0027absent\u0027 }}\" }"},{"line_number":34,"context_line":"    - { name: ovn-chassis-mac-mappings, value: \"{{ ovn_macs if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else omit }}\", state: \"{{ \u0027present\u0027 if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else \u0027absent\u0027 }}\" }"},{"line_number":35,"context_line":"    - { name: ovn-cms-options, value: \"{{ ovn_cms_opts }}\", state: \"{{ \u0027present\u0027 if ovn_cms_opts !\u003d \u0027\u0027 else \u0027absent\u0027 }}\" }"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a69a49bd_9f27c00a","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":314},"in_reply_to":"d741da17_231b6286","updated":"2021-04-27 12:54:11.000000000","message":"yes it is intentional. As we\u0027re always generating ovn_mappings - \u0027openvswitch.openvswitch.openvswitch_db\u0027 collection plugin cannot do absent properly if you\u0027re providing value to it.","commit_id":"354ee28d851273a96f40f37d074951b8d2613953"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"327e0c8287e8801e77913c503bd5d52f074b05e4","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    - { name: ovn-encap-type, value: geneve }"},{"line_number":31,"context_line":"    - { name: ovn-remote, value: \"{{ ovn_sb_connection }}\" }"},{"line_number":32,"context_line":"    - { name: ovn-remote-probe-interval, value: \"{{ ovn_remote_probe_interval }}\" }"},{"line_number":33,"context_line":"    - { name: ovn-bridge-mappings, value: \"{{ ovn_mappings if (inventory_hostname in groups[\u0027ovn-controller-network\u0027] or computes_need_external_bridge | bool) else omit }}\", state: \"{{ \u0027present\u0027 if (inventory_hostname in groups[\u0027ovn-controller-network\u0027] or computes_need_external_bridge | bool) else \u0027absent\u0027 }}\" }"},{"line_number":34,"context_line":"    - { name: ovn-chassis-mac-mappings, value: \"{{ ovn_macs if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else omit }}\", state: \"{{ \u0027present\u0027 if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else \u0027absent\u0027 }}\" }"},{"line_number":35,"context_line":"    - { name: ovn-cms-options, value: \"{{ ovn_cms_opts }}\", state: \"{{ \u0027present\u0027 if ovn_cms_opts !\u003d \u0027\u0027 else \u0027absent\u0027 }}\" }"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2973af52_d7388bf2","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":314},"in_reply_to":"e92c0b84_86b76483","updated":"2021-05-06 13:26:15.000000000","message":"Could backport the whole thing if the neutron bugfix has been backported?","commit_id":"354ee28d851273a96f40f37d074951b8d2613953"}]}
