)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4bedd2fe32cb963d40c04c92bfc90014850a77f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c02d06cf_760476d5","updated":"2022-03-22 16:31:51.000000000","message":"Sven, how about that release note? ;-)","commit_id":"ce16a8b0dce93442f5470b535fe564427c16d840"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1954e5e96402dc8bc162a8a1ef1afdc52975640d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b82630ec_38de461f","updated":"2022-03-10 15:33:08.000000000","message":"reno missing","commit_id":"ce16a8b0dce93442f5470b535fe564427c16d840"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9ba9ba1ff3d053e137a27eef3c503a06454c6547","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"785ec8e1_81b7dcb4","in_reply_to":"3b24f6ef_7cb0ef07","updated":"2022-03-15 17:42:49.000000000","message":"yes :)","commit_id":"ce16a8b0dce93442f5470b535fe564427c16d840"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"41d0f22b46cd2c217c661f360077ef5e7f930c5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3174a01_e20737ac","in_reply_to":"785ec8e1_81b7dcb4","updated":"2022-03-23 15:56:48.000000000","message":"Done","commit_id":"ce16a8b0dce93442f5470b535fe564427c16d840"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d7de05484487fa687073d5b3d10dcfae4f027df9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b24f6ef_7cb0ef07","in_reply_to":"b82630ec_38de461f","updated":"2022-03-14 14:22:43.000000000","message":"do you mean \"release notes missing\"? Because I don\u0027t know what else \"reno\" could mean.\n\nI will add some","commit_id":"ce16a8b0dce93442f5470b535fe564427c16d840"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"82be133bd42f4cc316e7a76783fd4f73dbebe8aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6bc3ef1c_1c496a34","in_reply_to":"c02d06cf_760476d5","updated":"2022-03-22 18:17:00.000000000","message":"thanks for bugging me, had to look up how that stuff works again. here are some notes :)","commit_id":"ce16a8b0dce93442f5470b535fe564427c16d840"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"235ad74a90b3875c20c80182e5d0c0ca8a35df4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a30b2058_a462e0a6","updated":"2022-03-23 19:17:37.000000000","message":"Also it is generally assumed that you approve a patch that you submit, an explicit review by yourself is not needed and in fact rather looks a bit weird.","commit_id":"81e473213e12978bb7981f1c54d6c768995f53ee"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4cc97fe3914bb126a58e036ed16697dda956164d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a8fcdb79_1fcb84f4","updated":"2022-03-24 09:33:29.000000000","message":"Basically we are setting LANG to en_US.UTF-8 in base Docker image already:\nhttps://github.com/openstack/kolla/blob/ac371617c9f124e9115ad8112020254477e11f24/docker/base/Dockerfile.j2#L17\n\nWonder what\u0027s wrong with curator then... (or cron)","commit_id":"81e473213e12978bb7981f1c54d6c768995f53ee"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b0127944faed74a59c946557c64bbf7ff4e60e3c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5d46babc_8d009c63","in_reply_to":"0ddc675a_6a4ec9a3","updated":"2022-03-24 10:47:54.000000000","message":"Systemd is on our roadmap, so it\u0027s not that consuming rearchitecture ;-)\nBut I think let\u0027s at least set the same value that we have in base Docker image (en_US.UTF-8).","commit_id":"81e473213e12978bb7981f1c54d6c768995f53ee"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d6c570e81bdeaa7bbceeebe8daaacc541334cc04","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"79d32278_14f1e602","in_reply_to":"5d46babc_8d009c63","updated":"2022-03-24 12:57:30.000000000","message":"please sort this out with frickler, afaik you are both core maintainers and you have now both posted conflicting requirements. I can go with either solution, fwiw.","commit_id":"81e473213e12978bb7981f1c54d6c768995f53ee"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f03df263206f2a2a82976422f6ad970fcb54a642","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c636a7d_b85b2644","in_reply_to":"79d32278_14f1e602","updated":"2022-03-24 13:28:51.000000000","message":"as discussed via IRC: let\u0027s default to en_US.UTF-8 for now, as this is also used in docker env already.","commit_id":"81e473213e12978bb7981f1c54d6c768995f53ee"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"16c37ec63898a6c5dd6970a83152e85e0fe44068","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"11f375bc_8c870c81","in_reply_to":"a30b2058_a462e0a6","updated":"2022-03-24 09:27:01.000000000","message":"thanks for the pointer! I didn\u0027t find any pointers in the docs what I\u0027m supposed to do (if I\u0027m supposed to do anything, that is), to make zuul merge this, but I also didn\u0027t read the whole dev guide, as it is rather long and sprinkled over several disjoint links. It\u0027s still a bit overwhelming as a beginner contributor :)","commit_id":"81e473213e12978bb7981f1c54d6c768995f53ee"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ff5529da668506c8247a1498cdd406e92333ca49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0ddc675a_6a4ec9a3","in_reply_to":"a8fcdb79_1fcb84f4","updated":"2022-03-24 10:39:23.000000000","message":"for poor souls who stumble upon this comment in the future, which is a reasonable question/assumption, to paraphrase the bug report:\n\ncrontab won\u0027t load LANG from the passed in ENV (via docker). LANG must be specified explicitly in your crontab, in order to be available for commands run via crontab.\n\nIt might be worth investigating if this is only an issue with the curator or also affects other software started via crontab inside kolla-ansible containers.\n\nIt might be also worth to add explicit integrationtests which check that a given cronjob really was successfully executed.\n\nas also said in the bugreport: crontab and containers are not a good match for each other in general, because crons assume a more or less standard unix system, e.g. the default mechanism to report errors in cron is via mail, but no mta or local mail delievery is configured in a standard docker container image, so you have to script some stuff to adapt oldschool crons to the modern container world.\n\nas can be seen in this example, there is not even a check or an error thrown, if the command run by crontab doesn\u0027t work.\n\na more suitable option than crontabs in general might be systemd-timers, as they are afaik more designed to also be run inside containers, but this would need a time consuming rearchitecture of kolla containers which might not be currently feasible.","commit_id":"81e473213e12978bb7981f1c54d6c768995f53ee"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"da709c8b63a352093652d45f5e9117b28a616ad1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e9459443_c1676e1c","updated":"2022-04-26 12:55:01.000000000","message":"Hey,\n\nso for people running old releases (I heard there might be still some out there)\nthis might still be a nice fix.\n\nWhat do you think?","commit_id":"d937a0662e432a094ae4041ff38d083fe28d94b0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b52e9d73b85073097548e23bfd42646c338ba66f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"73ec5631_fdf57e0f","updated":"2022-03-24 15:16:52.000000000","message":"ongoing investigation on applicability","commit_id":"d937a0662e432a094ae4041ff38d083fe28d94b0"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1e45a62cf56d0e0226eb1739b4354bfa8b2a1282","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"92046d44_f5758e9f","in_reply_to":"265e1876_d67900da","updated":"2022-04-29 12:50:43.000000000","message":"cherry pick works:\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/839912","commit_id":"d937a0662e432a094ae4041ff38d083fe28d94b0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e45dd6b409a902f1a37dcdf274131b2a7ca03f9b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cf4c5b07_7b719718","in_reply_to":"b775e442_c4145674","updated":"2022-04-29 12:21:11.000000000","message":"OK, let\u0027s then propose this against stable/ussuri.","commit_id":"d937a0662e432a094ae4041ff38d083fe28d94b0"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"aecd794115dd1320b0f918e0b88619f3d2a4f13b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"265e1876_d67900da","in_reply_to":"cf4c5b07_7b719718","updated":"2022-04-29 12:36:35.000000000","message":"okay, but I can\u0027t do that via gerrit UI? if I try to change the target branch via the option menu in the top right corner, I get a message, that this functionality has been disabled?","commit_id":"d937a0662e432a094ae4041ff38d083fe28d94b0"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"84ceb7b621157c6eea89ef97348f86e2651d3a20","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b775e442_c4145674","in_reply_to":"e6bbe92a_1c2aa923","updated":"2022-04-29 12:17:01.000000000","message":"see: https://bugs.launchpad.net/kolla-ansible/+bug/1919328/comments/8","commit_id":"d937a0662e432a094ae4041ff38d083fe28d94b0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"613f4dc6e0f13e494aa3acafca7ec66e5c72e537","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e6bbe92a_1c2aa923","in_reply_to":"e9459443_c1676e1c","updated":"2022-04-29 08:50:19.000000000","message":"How old? Very old releases are EOL (e.g. Train is very soon to be EOLed). If older than Ussuri, then it does not make sense merging this on master (Zed) at all. ;-)","commit_id":"d937a0662e432a094ae4041ff38d083fe28d94b0"}],"ansible/roles/elasticsearch/templates/elasticsearch-curator.crontab.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"07024e4abeb1bf15377a7d001d729cd20aa1f502","unresolved":true,"context_lines":[{"line_number":1,"context_line":"PATH\u003d/usr/local/bin:/usr/bin:/bin"},{"line_number":2,"context_line":"LANG\u003den_US.UTF-8"},{"line_number":3,"context_line":"{{ elasticsearch_curator_cron_schedule }} curator --config /etc/elasticsearch-curator/curator.yml {% if elasticsearch_curator_dry_run|bool %}--dry-run {% endif %}/etc/elasticsearch-curator/actions.yml"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"f7d2e157_77fe0e9c","line":2,"updated":"2022-03-23 19:16:14.000000000","message":"The bug also mentions C.UTF-8 as an option, which I would prefer as it is more neutral. Is there a specific reason to use en_US instead?","commit_id":"81e473213e12978bb7981f1c54d6c768995f53ee"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7099a27fde90882f1f468e96bf9d28de2560b2b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"PATH\u003d/usr/local/bin:/usr/bin:/bin"},{"line_number":2,"context_line":"LANG\u003den_US.UTF-8"},{"line_number":3,"context_line":"{{ elasticsearch_curator_cron_schedule }} curator --config /etc/elasticsearch-curator/curator.yml {% if elasticsearch_curator_dry_run|bool %}--dry-run {% endif %}/etc/elasticsearch-curator/actions.yml"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"32f1bb95_7717bf14","line":2,"in_reply_to":"cde7921d_f6cb5820","updated":"2022-03-24 10:30:26.000000000","message":"Done","commit_id":"81e473213e12978bb7981f1c54d6c768995f53ee"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e1c71dfa09788bd3994783c74c60421544e81b93","unresolved":true,"context_lines":[{"line_number":1,"context_line":"PATH\u003d/usr/local/bin:/usr/bin:/bin"},{"line_number":2,"context_line":"LANG\u003den_US.UTF-8"},{"line_number":3,"context_line":"{{ elasticsearch_curator_cron_schedule }} curator --config /etc/elasticsearch-curator/curator.yml {% if elasticsearch_curator_dry_run|bool %}--dry-run {% endif %}/etc/elasticsearch-curator/actions.yml"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"cde7921d_f6cb5820","line":2,"in_reply_to":"f7d2e157_77fe0e9c","updated":"2022-03-24 09:24:35.000000000","message":"as I said in the bug report already:\n- I do not know elasticsearch curator very well\n- this setting was tested and worked with \"en_US.UTF-8\", thus I provided the patch with the setting I tested and I know it works\n\nI agree, that, in theory, C.UTF-8 is \"more neutral\", but I want to stress that the entire openstack codebase is not \"neutral\" already, being mostly dependent on the english language.\n\n\nI will now test if \"C.UTF-8\" also works in a virtual environment and then submit an update, if it works.","commit_id":"81e473213e12978bb7981f1c54d6c768995f53ee"}],"releasenotes/notes/bug-1919328-9a9550e73392436e.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"07024e4abeb1bf15377a7d001d729cd20aa1f502","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    fixes broken elasticsearch_curator container"},{"line_number":5,"context_line":"    by adding the necessary \"LANG\u003den_US.UTF-8\""},{"line_number":6,"context_line":"    to the crontab."},{"line_number":7,"context_line":"    `LP#1919328 \u003chttps://launchpad.net/bugs/1919328\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8d81485d_d512b29d","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"updated":"2022-03-23 19:16:14.000000000","message":"nit: Fixes","commit_id":"81e473213e12978bb7981f1c54d6c768995f53ee"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7099a27fde90882f1f468e96bf9d28de2560b2b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    fixes broken elasticsearch_curator container"},{"line_number":5,"context_line":"    by adding the necessary \"LANG\u003den_US.UTF-8\""},{"line_number":6,"context_line":"    to the crontab."},{"line_number":7,"context_line":"    `LP#1919328 \u003chttps://launchpad.net/bugs/1919328\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6e35504d_f12d865b","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"in_reply_to":"8d81485d_d512b29d","updated":"2022-03-24 10:30:26.000000000","message":"Done","commit_id":"81e473213e12978bb7981f1c54d6c768995f53ee"}]}