)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4c76c4461df5f972c6d6d39253f0ad9f8f21bc2b","unresolved":true,"context_lines":[{"line_number":26,"context_line":"We experimented with this patch, using the following command."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"```"},{"line_number":29,"context_line":"EXTRA_OPTS\u003d\u0027--check --diff\u0027 kolla-ansible -i inventory genconfig -t ceilometer"},{"line_number":30,"context_line":"```"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Without the patch, we would get the following processing time."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c38ebc5f_43e8a268","line":29,"range":{"start_line":29,"start_character":19,"end_line":29,"end_character":26},"updated":"2021-05-18 14:23:46.000000000","message":"i think we don\u0027t support this parameter yet.","commit_id":"076b026a01f57cda66416a93d804ce1a393386e9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2298de4ae36c9baed58f0b85d542fef631904de4","unresolved":true,"context_lines":[{"line_number":26,"context_line":"We experimented with this patch, using the following command."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"```"},{"line_number":29,"context_line":"EXTRA_OPTS\u003d\u0027--check --diff\u0027 kolla-ansible -i inventory genconfig -t ceilometer"},{"line_number":30,"context_line":"```"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Without the patch, we would get the following processing time."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"26a49664_320235a5","line":29,"range":{"start_line":29,"start_character":19,"end_line":29,"end_character":26},"in_reply_to":"3f33f263_f8cc734a","updated":"2021-07-29 09:49:24.000000000","message":"\u003e Well, kolla-ansible wrapper not supports, but it\u0027s normal ansible parameter. Btw, we should support it, somewhere i have work-in-progress patch.\n\u003e \n\u003e Anyway..he used it only to demonstrate timing.\n\nSorry, I\u0027ve accidentaly added a draft comment from time before it was merged :P , now I wanted only add +1 for backport-candidate.","commit_id":"076b026a01f57cda66416a93d804ce1a393386e9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"070a239da0ca9d9d6859816a038bace67a91c043","unresolved":true,"context_lines":[{"line_number":26,"context_line":"We experimented with this patch, using the following command."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"```"},{"line_number":29,"context_line":"EXTRA_OPTS\u003d\u0027--check --diff\u0027 kolla-ansible -i inventory genconfig -t ceilometer"},{"line_number":30,"context_line":"```"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Without the patch, we would get the following processing time."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c546ade5_7369ef65","line":29,"range":{"start_line":29,"start_character":19,"end_line":29,"end_character":26},"in_reply_to":"c38ebc5f_43e8a268","updated":"2021-05-19 17:19:31.000000000","message":"I think that it is supported: https://github.com/openstack/kolla-ansible/blob/master/releasenotes/notes/support-check-and-diff-mode-for-genconfig-97703a2ed13ab9ec.yaml","commit_id":"076b026a01f57cda66416a93d804ce1a393386e9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e617543be4110f52d5b9eddb43a4195c5780cf4d","unresolved":true,"context_lines":[{"line_number":26,"context_line":"We experimented with this patch, using the following command."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"```"},{"line_number":29,"context_line":"EXTRA_OPTS\u003d\u0027--check --diff\u0027 kolla-ansible -i inventory genconfig -t ceilometer"},{"line_number":30,"context_line":"```"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Without the patch, we would get the following processing time."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3f33f263_f8cc734a","line":29,"range":{"start_line":29,"start_character":19,"end_line":29,"end_character":26},"in_reply_to":"c38ebc5f_43e8a268","updated":"2021-07-29 09:48:03.000000000","message":"Well, kolla-ansible wrapper not supports, but it\u0027s normal ansible parameter. Btw, we should support it, somewhere i have work-in-progress patch.\n\nAnyway..he used it only to demonstrate timing.","commit_id":"076b026a01f57cda66416a93d804ce1a393386e9"}],"ansible/gather-facts.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1167392ea0fde464910cd1659512c8199cd779e1","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  gather_facts: true"},{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":13,"context_line":"      group_by:"},{"line_number":14,"context_line":"        key: \"all_using_limit_{{ (ansible_play_batch | length) !\u003d (groups[\u0027all\u0027] | length) }}\""},{"line_number":15,"context_line":"      changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8e42f64c_b6f5fd11","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":32},"updated":"2021-03-26 17:31:40.000000000","message":"Is this in the correct place?","commit_id":"9f799153af8c89806d5027f218fc3a577945ade4"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d771c25c4436952b5dd5107bb0dfca6a49a8a70c","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  gather_facts: true"},{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":13,"context_line":"      group_by:"},{"line_number":14,"context_line":"        key: \"all_using_limit_{{ (ansible_play_batch | length) !\u003d (groups[\u0027all\u0027] | length) }}\""},{"line_number":15,"context_line":"      changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e1a20b90_3fe8ee20","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":32},"in_reply_to":"8e42f64c_b6f5fd11","updated":"2021-03-26 17:56:54.000000000","message":"what do you mean?\n\nIt is what we tested, and use in production right now.","commit_id":"9f799153af8c89806d5027f218fc3a577945ade4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"553b1a154ffed196a860ec70dcc066997554b988","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  gather_facts: true"},{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":13,"context_line":"      group_by:"},{"line_number":14,"context_line":"        key: \"all_using_limit_{{ (ansible_play_batch | length) !\u003d (groups[\u0027all\u0027] | length) }}\""},{"line_number":15,"context_line":"      changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fd76a837_ea0d33d9","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":32},"in_reply_to":"e1a20b90_3fe8ee20","updated":"2021-03-27 14:17:51.000000000","message":"It\u0027s failing because this is invalid syntax. setup and group_by are both modules.\n\nPerhaps in your code you set gather_facts to false on L8, then added an explicit call to the setup module?","commit_id":"9f799153af8c89806d5027f218fc3a577945ade4"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"1a485023d6903e0eef92fdc8b3043be8aaa0258e","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  gather_facts: true"},{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":13,"context_line":"      group_by:"},{"line_number":14,"context_line":"        key: \"all_using_limit_{{ (ansible_play_batch | length) !\u003d (groups[\u0027all\u0027] | length) }}\""},{"line_number":15,"context_line":"      changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"75e64886_18e6305d","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":32},"in_reply_to":"fd76a837_ea0d33d9","updated":"2021-03-29 11:21:00.000000000","message":"Exactly. My bad. I did not pay much attention to what I was doing last week 😊.\n\nIf I leave the gather_facts\u003dTrue, then there is not means for me to customize the call. I need to set it to false, and then call it manually to customize the parameters.","commit_id":"9f799153af8c89806d5027f218fc3a577945ade4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f19121e877653175d68ea76967b09a683e0d435a","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Gather facts"},{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":15,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"90c5f195_2064a755","line":12,"updated":"2021-03-29 12:04:31.000000000","message":"Wouldn\u0027t it be better to define this somewhere in group_vars/all.yml as the default value and leave it up to the user what filter to choose ?","commit_id":"1c688472233f7cbe5b37f41c1b16f8e6c894f59b"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"df2b2be34abb8369fb63a97127640b78ed51943d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Gather facts"},{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":15,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c2b67846_be9c78bd","line":12,"in_reply_to":"15915055_004ab2bb","updated":"2021-03-29 13:36:02.000000000","message":"I agree. Done.","commit_id":"1c688472233f7cbe5b37f41c1b16f8e6c894f59b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"184045aee9bd9699a5c531ec847dc04ee9be794e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Gather facts"},{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":15,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"15915055_004ab2bb","line":12,"in_reply_to":"90c5f195_2064a755","updated":"2021-03-29 12:29:03.000000000","message":"+1\n\nAlso, AFAICT, this filters out any facts beginning with q or t. That sounds like it could lead to trouble if we rely on one of those facts. (admittedly I couldn\u0027t find any).","commit_id":"1c688472233f7cbe5b37f41c1b16f8e6c894f59b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"184045aee9bd9699a5c531ec847dc04ee9be794e","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - name: Gather facts"},{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":15,"context_line":"      group_by:"},{"line_number":16,"context_line":"        key: \"all_using_limit_{{ (ansible_play_batch | length) !\u003d (groups[\u0027all\u0027] | length) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2a036006_29dac4c3","line":13,"updated":"2021-03-29 12:29:03.000000000","message":"Needs this to play nicely with fact caching:\n\nwhen: not module_setup | default(false)","commit_id":"1c688472233f7cbe5b37f41c1b16f8e6c894f59b"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"df2b2be34abb8369fb63a97127640b78ed51943d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - name: Gather facts"},{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":15,"context_line":"      group_by:"},{"line_number":16,"context_line":"        key: \"all_using_limit_{{ (ansible_play_batch | length) !\u003d (groups[\u0027all\u0027] | length) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7e826934_f71858aa","line":13,"in_reply_to":"2a036006_29dac4c3","updated":"2021-03-29 13:36:02.000000000","message":"I am not sure I follow. Can you check the latest patch?","commit_id":"1c688472233f7cbe5b37f41c1b16f8e6c894f59b"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"5b37b04a22995488cb7b21da76bc898d0b9b09eb","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - name: Gather facts"},{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":15,"context_line":"      group_by:"},{"line_number":16,"context_line":"        key: \"all_using_limit_{{ (ansible_play_batch | length) !\u003d (groups[\u0027all\u0027] | length) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f73aeec_99f38467","line":13,"in_reply_to":"4557a5cb_bed679e3","updated":"2021-03-29 14:14:07.000000000","message":"I see. Done.","commit_id":"1c688472233f7cbe5b37f41c1b16f8e6c894f59b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"48b87edad2594bf6ca0c37e2cc0127b95d8af2a7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - name: Gather facts"},{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":15,"context_line":"      group_by:"},{"line_number":16,"context_line":"        key: \"all_using_limit_{{ (ansible_play_batch | length) !\u003d (groups[\u0027all\u0027] | length) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4557a5cb_bed679e3","line":13,"in_reply_to":"7e826934_f71858aa","updated":"2021-03-29 13:56:00.000000000","message":"Still relevant. See L45","commit_id":"1c688472233f7cbe5b37f41c1b16f8e6c894f59b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f19121e877653175d68ea76967b09a683e0d435a","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  tasks:"},{"line_number":37,"context_line":"    - name: Gather facts"},{"line_number":38,"context_line":"      setup:"},{"line_number":39,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":40,"context_line":"      delegate_facts: True"},{"line_number":41,"context_line":"      delegate_to: \"{{ item }}\""},{"line_number":42,"context_line":"      with_items: \"{{ delegate_hosts }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ea8d4ee5_aea0c5c2","line":39,"updated":"2021-03-29 12:04:31.000000000","message":"Ditto","commit_id":"1c688472233f7cbe5b37f41c1b16f8e6c894f59b"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"df2b2be34abb8369fb63a97127640b78ed51943d","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  tasks:"},{"line_number":37,"context_line":"    - name: Gather facts"},{"line_number":38,"context_line":"      setup:"},{"line_number":39,"context_line":"        filter: \"ansible_[!qt]*\""},{"line_number":40,"context_line":"      delegate_facts: True"},{"line_number":41,"context_line":"      delegate_to: \"{{ item }}\""},{"line_number":42,"context_line":"      with_items: \"{{ delegate_hosts }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ef8a9c11_bcf533fb","line":39,"in_reply_to":"ea8d4ee5_aea0c5c2","updated":"2021-03-29 13:36:02.000000000","message":"done","commit_id":"1c688472233f7cbe5b37f41c1b16f8e6c894f59b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"48b87edad2594bf6ca0c37e2cc0127b95d8af2a7","unresolved":true,"context_lines":[{"line_number":42,"context_line":"      with_items: \"{{ delegate_hosts }}\""},{"line_number":43,"context_line":"      # We gathered facts for all hosts in the batch during the first play."},{"line_number":44,"context_line":"      when:"},{"line_number":45,"context_line":"        - not hostvars[item].module_setup | default(false)"},{"line_number":46,"context_line":"  tags: always"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7cdc236f_5d28f7ad","line":45,"updated":"2021-03-29 13:56:00.000000000","message":"Here is a similar condition. It\u0027s required because the setup module ignores the fact cache.","commit_id":"1c688472233f7cbe5b37f41c1b16f8e6c894f59b"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"5b37b04a22995488cb7b21da76bc898d0b9b09eb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      with_items: \"{{ delegate_hosts }}\""},{"line_number":43,"context_line":"      # We gathered facts for all hosts in the batch during the first play."},{"line_number":44,"context_line":"      when:"},{"line_number":45,"context_line":"        - not hostvars[item].module_setup | default(false)"},{"line_number":46,"context_line":"  tags: always"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d04e834b_8ec43b0d","line":45,"in_reply_to":"7cdc236f_5d28f7ad","updated":"2021-03-29 14:14:07.000000000","message":"Ack","commit_id":"1c688472233f7cbe5b37f41c1b16f8e6c894f59b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0ab6cbb0d2f7863a6c6c32a44cfafaf07c67b0ff","unresolved":true,"context_lines":[{"line_number":5,"context_line":"- name: Gather facts for all hosts"},{"line_number":6,"context_line":"  hosts: all"},{"line_number":7,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":8,"context_line":"  gather_facts: \"{{ kolla_ansible_facts_filtering_expression is not defined}}\""},{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Gather facts"},{"line_number":11,"context_line":"      setup:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f9a0bedd_eb310b6c","line":8,"range":{"start_line":8,"start_character":20,"end_line":8,"end_character":75},"updated":"2021-05-18 15:14:37.000000000","message":"It\u0027s always defined in group_vars","commit_id":"5c356e30d7a991d70b5061632495303155c224d8"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"070a239da0ca9d9d6859816a038bace67a91c043","unresolved":true,"context_lines":[{"line_number":5,"context_line":"- name: Gather facts for all hosts"},{"line_number":6,"context_line":"  hosts: all"},{"line_number":7,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":8,"context_line":"  gather_facts: \"{{ kolla_ansible_facts_filtering_expression is not defined}}\""},{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Gather facts"},{"line_number":11,"context_line":"      setup:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b346fdbb_f236a216","line":8,"range":{"start_line":8,"start_character":20,"end_line":8,"end_character":75},"in_reply_to":"f9a0bedd_eb310b6c","updated":"2021-05-19 17:19:31.000000000","message":"I see, maybe it was something that slipped through. So, you fixed this by hard coding it. Is that it?","commit_id":"5c356e30d7a991d70b5061632495303155c224d8"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0ab6cbb0d2f7863a6c6c32a44cfafaf07c67b0ff","unresolved":true,"context_lines":[{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"{{ kolla_ansible_facts_filtering_expression }}\""},{"line_number":13,"context_line":"      when:"},{"line_number":14,"context_line":"        - \"not module_setup | default(false)\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":17,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"527cb00a_5384c525","line":14,"updated":"2021-05-18 15:14:37.000000000","message":"Should not be a string.","commit_id":"5c356e30d7a991d70b5061632495303155c224d8"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"070a239da0ca9d9d6859816a038bace67a91c043","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      setup:"},{"line_number":12,"context_line":"        filter: \"{{ kolla_ansible_facts_filtering_expression }}\""},{"line_number":13,"context_line":"      when:"},{"line_number":14,"context_line":"        - \"not module_setup | default(false)\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":17,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5e0d3c55_2ac3ec7e","line":14,"in_reply_to":"527cb00a_5384c525","updated":"2021-05-19 17:19:31.000000000","message":"Ack","commit_id":"5c356e30d7a991d70b5061632495303155c224d8"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"48b87edad2594bf6ca0c37e2cc0127b95d8af2a7","unresolved":true,"context_lines":[{"line_number":27,"context_line":"# Ansible facts filtering expression."},{"line_number":28,"context_line":"# For instancce, if one wants to remove/ignore all Neutron interfaces,"},{"line_number":29,"context_line":"# we can use the following configurations "},{"line_number":30,"context_line":"# kolla_ansible_facts_filtering_expression: \"ansible_[!qt]*\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Valid options are [ COPY_ONCE, COPY_ALWAYS ]"},{"line_number":33,"context_line":"config_strategy: \"COPY_ALWAYS\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"95ec8dbf_36fd6e08","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":42},"updated":"2021-03-29 13:56:00.000000000","message":"We could use a default of \u0027*\u0027","commit_id":"e028ac2388ee14036def163f01cf61dcb655f157"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"5b37b04a22995488cb7b21da76bc898d0b9b09eb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# Ansible facts filtering expression."},{"line_number":28,"context_line":"# For instancce, if one wants to remove/ignore all Neutron interfaces,"},{"line_number":29,"context_line":"# we can use the following configurations "},{"line_number":30,"context_line":"# kolla_ansible_facts_filtering_expression: \"ansible_[!qt]*\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Valid options are [ COPY_ONCE, COPY_ALWAYS ]"},{"line_number":33,"context_line":"config_strategy: \"COPY_ALWAYS\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ddcf97d5_212b8f4e","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":42},"in_reply_to":"95ec8dbf_36fd6e08","updated":"2021-03-29 14:14:07.000000000","message":"Done","commit_id":"e028ac2388ee14036def163f01cf61dcb655f157"}]}