)]}'
{"tests/templates/globals-default.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3432cc282c2d56647547ee8858dd9ba508ae5b87","unresolved":true,"context_lines":[{"line_number":151,"context_line":"neutron_plugin_agent: \"ovn\""},{"line_number":152,"context_line":"neutron_ovn_distributed_fip: \"yes\""},{"line_number":153,"context_line":"enable_octavia: \"yes\""},{"line_number":154,"context_line":"octavia_auto_configure: \"no\""},{"line_number":155,"context_line":"octavia_provider_drivers: \"ovn:OVN provider\""},{"line_number":156,"context_line":"octavia_provider_agents: \"ovn\""},{"line_number":157,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"2b22bf13_e4cf9d85","line":154,"updated":"2021-04-12 11:50:29.000000000","message":"hmm, I understand the need for below but this is confusing - should the logic be amended further to include this setting? I mean, any amphora-related parts should not run when amphora is not enabled.","commit_id":"e26638790e7a4ea12a354fe4a63d532f53ac6557"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8908a4272bab02cc88c5132f0fee07e907240bb6","unresolved":true,"context_lines":[{"line_number":151,"context_line":"neutron_plugin_agent: \"ovn\""},{"line_number":152,"context_line":"neutron_ovn_distributed_fip: \"yes\""},{"line_number":153,"context_line":"enable_octavia: \"yes\""},{"line_number":154,"context_line":"octavia_auto_configure: \"no\""},{"line_number":155,"context_line":"octavia_provider_drivers: \"ovn:OVN provider\""},{"line_number":156,"context_line":"octavia_provider_agents: \"ovn\""},{"line_number":157,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"3f7a40b0_f83ba11d","line":154,"in_reply_to":"2b22bf13_e4cf9d85","updated":"2021-04-12 14:42:55.000000000","message":"Well, the problem is that we have a task in Octavia role named \"Fail when Neutron plugin agent is not supported\" - once we\u0027ll work out if auto config works with OVN - then we can remove it from here.","commit_id":"e26638790e7a4ea12a354fe4a63d532f53ac6557"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"037bda798a0d719e30ff53a034f8a407cfac88b0","unresolved":true,"context_lines":[{"line_number":151,"context_line":"neutron_plugin_agent: \"ovn\""},{"line_number":152,"context_line":"neutron_ovn_distributed_fip: \"yes\""},{"line_number":153,"context_line":"enable_octavia: \"yes\""},{"line_number":154,"context_line":"octavia_auto_configure: \"no\""},{"line_number":155,"context_line":"octavia_provider_drivers: \"ovn:OVN provider\""},{"line_number":156,"context_line":"octavia_provider_agents: \"ovn\""},{"line_number":157,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"e370be0f_5c8293c2","line":154,"in_reply_to":"3f7a40b0_f83ba11d","updated":"2021-04-12 15:57:05.000000000","message":"Yeah, it should be structured differently then. OK, let\u0027s approve the previous patch now and you fix the other issue here (irr-files in zuul).","commit_id":"e26638790e7a4ea12a354fe4a63d532f53ac6557"}],"zuul.d/base.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3432cc282c2d56647547ee8858dd9ba508ae5b87","unresolved":true,"context_lines":[{"line_number":210,"context_line":"    voting: false"},{"line_number":211,"context_line":"    files:"},{"line_number":212,"context_line":"      - ^ansible/roles/(neutron|octavia|openvswitch|ovn)/"},{"line_number":213,"context_line":"      - ^tests/templates/globals-default.j2"},{"line_number":214,"context_line":"      - ^tests/test-ovn.sh"},{"line_number":215,"context_line":"      - ^tests/test-core-openstack.sh"},{"line_number":216,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"cd511a1e_0e9340c5","line":213,"range":{"start_line":213,"start_character":8,"end_line":213,"end_character":43},"updated":"2021-04-12 11:50:29.000000000","message":"this should live in the base base job, let\u0027s do it in a separate patch (run.yml should also live there)","commit_id":"e26638790e7a4ea12a354fe4a63d532f53ac6557"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f77716b4634536d3f71a83c66a54c4d31ecda283","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    voting: false"},{"line_number":211,"context_line":"    files:"},{"line_number":212,"context_line":"      - ^ansible/roles/(neutron|octavia|openvswitch|ovn)/"},{"line_number":213,"context_line":"      - ^tests/templates/globals-default.j2"},{"line_number":214,"context_line":"      - ^tests/test-ovn.sh"},{"line_number":215,"context_line":"      - ^tests/test-core-openstack.sh"},{"line_number":216,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"abd33d62_bcdb2c81","line":213,"range":{"start_line":213,"start_character":8,"end_line":213,"end_character":43},"in_reply_to":"cd511a1e_0e9340c5","updated":"2021-04-13 11:13:29.000000000","message":"Ack","commit_id":"e26638790e7a4ea12a354fe4a63d532f53ac6557"}]}