)]}'
{"releasenotes/notes/reduce-cadvisor-cardinality-1213854b9fe0c828.yaml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"eff4aa88269a6281ceb562cc07e1c22978b8fb2d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for passing extra runtime options to cAdvisor via"},{"line_number":5,"context_line":"    ``prometheus_cadvisor_cmdline_extras`` new variable. By default"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"93c15ef3_9606f2a3","line":2,"updated":"2021-06-03 08:50:11.000000000","message":"Please can you add an upgrade note explaining to users that we have trimmed down the metrics collected from cAdvisor and that they should review their dashboards / alerts accordingly? It would also be helpful to explain briefly how to go back to the original behaviour if someone wants to.","commit_id":"863e4abf98431a757db75b32afbf588a90dc7f65"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"d5d8409348299ce6d58b30ce40dd5485996c3322","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for passing extra runtime options to cAdvisor via"},{"line_number":5,"context_line":"    ``prometheus_cadvisor_cmdline_extras`` new variable. By default"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c7df46c2_6f17f0c0","line":2,"in_reply_to":"93c15ef3_9606f2a3","updated":"2021-06-03 17:41:54.000000000","message":"Makes a lot of sense, yes.","commit_id":"863e4abf98431a757db75b32afbf588a90dc7f65"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"05fe8211b51a81eaa634d3edf90371defa8b11c7","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    cAdvisor has now reduced number of Prometheus metrics and labels"},{"line_number":12,"context_line":"    exported by default. This means that corresponding timeseries will"},{"line_number":13,"context_line":"    no longer be created. If existing setup relies on these, eg. for"},{"line_number":14,"context_line":"    visualisation or alerting, they could be explicitly enabled prior"},{"line_number":15,"context_line":"    upgrading with the ``prometheus_cadvisor_cmdline_extras`` new variable."},{"line_number":16,"context_line":"    Reference for the possible options: `\u003chttps://github.com/google/cadvisor/blob/master/docs/runtime_options.md#metrics\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7d30a4a5_7533b1c6","line":14,"range":{"start_line":14,"start_character":64,"end_line":14,"end_character":69},"updated":"2021-06-07 09:01:23.000000000","message":"nit: s/prior/prior to","commit_id":"65ef715f5636d5140388bce769e62e19d3763b02"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"222e6246a65d325b8b018e01139033b69376b2ac","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for passing extra runtime options to cAdvisor via"},{"line_number":5,"context_line":"    ``prometheus_cadvisor_cmdline_extras`` new variable. By default"},{"line_number":6,"context_line":"    system cgroups\u0027 metrics are disabled, plus container labels"},{"line_number":7,"context_line":"    don\u0027t get exposed to Prometheus. This creates savings in resources"},{"line_number":8,"context_line":"    usage by both cAdvisor and Prometheus."},{"line_number":9,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"438d8b09_aa206187","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":19},"updated":"2021-06-15 08:59:19.000000000","message":"Seems like there are more disabled than this?","commit_id":"e4137b4c317c33093c38b18426e6a418f59a0d43"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"6d1f46c36a8348cafbca0b895d682c73b11a7a0b","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for passing extra runtime options to cAdvisor via"},{"line_number":5,"context_line":"    ``prometheus_cadvisor_cmdline_extras`` new variable. By default"},{"line_number":6,"context_line":"    system cgroups\u0027 metrics are disabled, plus container labels"},{"line_number":7,"context_line":"    don\u0027t get exposed to Prometheus. This creates savings in resources"},{"line_number":8,"context_line":"    usage by both cAdvisor and Prometheus."},{"line_number":9,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"6e123582_122be518","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":19},"in_reply_to":"438d8b09_aa206187","updated":"2021-06-15 19:16:01.000000000","message":"I did realise cAdvisor by default exports more than it should according to it\u0027s documentation. See comparison for a single node deployment: http://paste.openstack.org/show/806648/\nEverything in the --disabled_metrics comes from the defaults (https://github.com/google/cadvisor/blob/master/docs/runtime_options.md#metrics). If --disabled_metrics flag is omitted, there is significantly more metrics exported. That\u0027s probably worth mentioning in reno.","commit_id":"e4137b4c317c33093c38b18426e6a418f59a0d43"}]}