)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"879ad482240c1b6962f8c3ed284872d6b3e84805","unresolved":true,"context_lines":[{"line_number":10,"context_line":"baremetal role configures daemon.json - which results in iptables rules being"},{"line_number":11,"context_line":"implemented - but not removed on docker engine restart."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib1faa092e0b8f0668d1752490a34d0c2165d58d2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"34ecbea2_311f6058","line":13,"updated":"2021-04-23 15:14:00.000000000","message":"https://bugs.launchpad.net/kolla-ansible/+bug/1923203","commit_id":"3f0295c8cdc46ecd50b1a2ce9277a7d338bf8d1f"}],"ansible/roles/baremetal/tasks/install.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e9e467804a39083a4dcf319f6c03a37858a8efe7","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  changed_when: false"},{"line_number":47,"context_line":"  register: running_containers"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# APT starts Docker engine right after installation, which creates"},{"line_number":50,"context_line":"# iptables rules before we disable iptables in Docker config"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Check if docker systemd unit exists"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2c8ed4e7_75ee7b26","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":5},"updated":"2021-05-14 08:16:16.000000000","message":"nit: it\u0027s not apt that does it, it\u0027s how the package scripts are designed on deb systems","commit_id":"bc96179195de171a693b83405a472dddda596bff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e9e467804a39083a4dcf319f6c03a37858a8efe7","unresolved":true,"context_lines":[{"line_number":52,"context_line":"- name: Check if docker systemd unit exists"},{"line_number":53,"context_line":"  stat:"},{"line_number":54,"context_line":"    path: /etc/systemd/system/docker.service"},{"line_number":55,"context_line":"  register: docker_unit_file"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: Mask the docker systemd unit on Debian/Ubuntu"},{"line_number":58,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ca59a88c_3bd9bec7","line":55,"updated":"2021-05-14 08:16:16.000000000","message":"could live in a common block as it\u0027s only relevant on debuntu; also, it could theoretically require `become` to succeed (though that would be rare in practice)","commit_id":"bc96179195de171a693b83405a472dddda596bff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e9e467804a39083a4dcf319f6c03a37858a8efe7","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    state: link"},{"line_number":64,"context_line":"  become: true"},{"line_number":65,"context_line":"  when:"},{"line_number":66,"context_line":"    - ansible_os_family \u003d\u003d \u0027Debian\u0027"},{"line_number":67,"context_line":"    - not docker_unit_file.stat.exists"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"- name: Install apt packages"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e2c7281d_74f4336c","line":66,"updated":"2021-05-14 08:16:16.000000000","message":"otoh, we could also use this on any distro to ensure we control (re)starts and stops ourselves","commit_id":"bc96179195de171a693b83405a472dddda596bff"}]}