)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"abb60a64ef7d0fc468bdb598206f93e1da9db03c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fbb81b17_3562da87","updated":"2021-11-15 10:15:43.000000000","message":"@mgoddard cleanup.yml is already called in upgrade.yml. What am I missing?","commit_id":"6c33ba3837aa0aee8ca20bd8d6c022210a45fffe"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3d58a9066ff44820d7bca2530eaf79c610568e8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"47497f25_6dceafc6","updated":"2021-11-15 10:21:46.000000000","message":"We also already have this reno, but I can add another one.\n\n```\ncat releasenotes/notes/remove-monasca-log-metrics-02a81671f864d1a8.yaml\n---\nupgrade:\n  - |\n    The Monasca Log Metrics service was deprecated in the Wallaby\n    release and all service instances and configuration will be\n    removed automatically. It is up to the operator to remove any\n    associated docker volumes.\n\n```","commit_id":"6c33ba3837aa0aee8ca20bd8d6c022210a45fffe"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"e0b36db592fdcc716f270dd99c7a4a9d3bef71d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8911997c_4a79f01c","in_reply_to":"47497f25_6dceafc6","updated":"2021-11-15 10:31:29.000000000","message":"Although looks like I forgot to check that one in :)","commit_id":"6c33ba3837aa0aee8ca20bd8d6c022210a45fffe"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"365f841ed53484275414d993a5324051594077ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5f134dd_e93e7fe7","updated":"2021-11-15 17:12:20.000000000","message":"@Radek - second opinion sought","commit_id":"31d08410e0d42bddb234e8dd58a381612cce18d0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ce66627e510046bf55db6beb53b0737e866332a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"122d1ea2_5619249d","updated":"2021-11-15 10:39:36.000000000","message":"small nit","commit_id":"31d08410e0d42bddb234e8dd58a381612cce18d0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"357c303aa990e83e24dca32f1acfcee6c71aa94e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70434c77_b5655629","in_reply_to":"c5f134dd_e93e7fe7","updated":"2021-12-04 19:54:28.000000000","message":"Based on the reno, I would consider backporting to Xena anyway. Better have it cleaned up properly.","commit_id":"31d08410e0d42bddb234e8dd58a381612cce18d0"}],"ansible/roles/monasca/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ce66627e510046bf55db6beb53b0737e866332a2","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    volumes: \"{{ monasca_log_persister_default_volumes + monasca_log_persister_extra_volumes }}\""},{"line_number":38,"context_line":"    dimensions: \"{{ monasca_log_persister_dimensions }}\""},{"line_number":39,"context_line":"  # TODO(dszumski): We can remove log-metrics and all other references to it after"},{"line_number":40,"context_line":"  # the Xena release. This is used for cleaning up the service."},{"line_number":41,"context_line":"  monasca-log-metrics:"},{"line_number":42,"context_line":"    container_name: monasca_log_metrics"},{"line_number":43,"context_line":"    group: monasca-log-metrics"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d9fa8a49_cdbcd8ee","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":12},"updated":"2021-11-15 10:39:36.000000000","message":"Yoga :)","commit_id":"31d08410e0d42bddb234e8dd58a381612cce18d0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"37aab11986225884dd3adaf711ecffa2ddbb0e6c","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    volumes: \"{{ monasca_log_persister_default_volumes + monasca_log_persister_extra_volumes }}\""},{"line_number":38,"context_line":"    dimensions: \"{{ monasca_log_persister_dimensions }}\""},{"line_number":39,"context_line":"  # TODO(dszumski): We can remove log-metrics and all other references to it after"},{"line_number":40,"context_line":"  # the Xena release. This is used for cleaning up the service."},{"line_number":41,"context_line":"  monasca-log-metrics:"},{"line_number":42,"context_line":"    container_name: monasca_log_metrics"},{"line_number":43,"context_line":"    group: monasca-log-metrics"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"87d659d7_8887f882","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":12},"in_reply_to":"3c60f680_6f9d555f","updated":"2021-11-15 13:51:58.000000000","message":"Strictly, it would be a behaviour change after release. See what others think","commit_id":"31d08410e0d42bddb234e8dd58a381612cce18d0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fa5801a1b829d9d8277faa46477d04425cac76d9","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    volumes: \"{{ monasca_log_persister_default_volumes + monasca_log_persister_extra_volumes }}\""},{"line_number":38,"context_line":"    dimensions: \"{{ monasca_log_persister_dimensions }}\""},{"line_number":39,"context_line":"  # TODO(dszumski): We can remove log-metrics and all other references to it after"},{"line_number":40,"context_line":"  # the Xena release. This is used for cleaning up the service."},{"line_number":41,"context_line":"  monasca-log-metrics:"},{"line_number":42,"context_line":"    container_name: monasca_log_metrics"},{"line_number":43,"context_line":"    group: monasca-log-metrics"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"87d04ca9_23623661","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":12},"in_reply_to":"7ea15287_fd40fb97","updated":"2021-12-28 07:21:36.000000000","message":"So, I have backported this to Xena but due to Xena being already released I guess we, nonetheless, have to wait with cleanup for Z.","commit_id":"31d08410e0d42bddb234e8dd58a381612cce18d0"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"fa3cb6ccdb2b37b8f76107fbef45ab33de28308a","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    volumes: \"{{ monasca_log_persister_default_volumes + monasca_log_persister_extra_volumes }}\""},{"line_number":38,"context_line":"    dimensions: \"{{ monasca_log_persister_dimensions }}\""},{"line_number":39,"context_line":"  # TODO(dszumski): We can remove log-metrics and all other references to it after"},{"line_number":40,"context_line":"  # the Xena release. This is used for cleaning up the service."},{"line_number":41,"context_line":"  monasca-log-metrics:"},{"line_number":42,"context_line":"    container_name: monasca_log_metrics"},{"line_number":43,"context_line":"    group: monasca-log-metrics"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bd84d604_d6dafefc","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":12},"in_reply_to":"87d659d7_8887f882","updated":"2021-11-15 14:32:01.000000000","message":"FWIW, we have this in the Wallaby release note:\n```\n---\nupgrade:\n  - |\n    The Monasca Log Metrics service has been deprecated and is now\n    disabled by default. If you wish to enable it, you can set\n    ``monasca_enable_log_metrics_service`` to ``True`` in ``globals.yml``.\ndeprecations:\n  - |\n    The Monasca Log Metrics service has been deprecated and will be\n    removed in the Xena release.\n```","commit_id":"31d08410e0d42bddb234e8dd58a381612cce18d0"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"389ff0b8f7a760f8314969cbf624182e30e2f4af","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    volumes: \"{{ monasca_log_persister_default_volumes + monasca_log_persister_extra_volumes }}\""},{"line_number":38,"context_line":"    dimensions: \"{{ monasca_log_persister_dimensions }}\""},{"line_number":39,"context_line":"  # TODO(dszumski): We can remove log-metrics and all other references to it after"},{"line_number":40,"context_line":"  # the Xena release. This is used for cleaning up the service."},{"line_number":41,"context_line":"  monasca-log-metrics:"},{"line_number":42,"context_line":"    container_name: monasca_log_metrics"},{"line_number":43,"context_line":"    group: monasca-log-metrics"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7ea15287_fd40fb97","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":12},"in_reply_to":"bd84d604_d6dafefc","updated":"2021-11-15 14:32:50.000000000","message":"It could be a bugfix if really necessary","commit_id":"31d08410e0d42bddb234e8dd58a381612cce18d0"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"70f0c9e9c7698ce477586627d074b31b83a4122e","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    volumes: \"{{ monasca_log_persister_default_volumes + monasca_log_persister_extra_volumes }}\""},{"line_number":38,"context_line":"    dimensions: \"{{ monasca_log_persister_dimensions }}\""},{"line_number":39,"context_line":"  # TODO(dszumski): We can remove log-metrics and all other references to it after"},{"line_number":40,"context_line":"  # the Xena release. This is used for cleaning up the service."},{"line_number":41,"context_line":"  monasca-log-metrics:"},{"line_number":42,"context_line":"    container_name: monasca_log_metrics"},{"line_number":43,"context_line":"    group: monasca-log-metrics"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3c60f680_6f9d555f","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":12},"in_reply_to":"d9fa8a49_cdbcd8ee","updated":"2021-11-15 10:48:36.000000000","message":"Can we not backport this to Xena given that we already disabled it in Wallaby?","commit_id":"31d08410e0d42bddb234e8dd58a381612cce18d0"}]}
