)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"27fd982a3e53ebf82a6d40c23e7c371f93680bc1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[docker] Add support for setting CgroupnsMode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is required to support Debian Bullseye (11) - need to set"},{"line_number":10,"context_line":"nova-libvirt to use \u0027host\u0027 CgroupnsMode."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I40213d4092fa325bcf37bb1fb4437ab125fe328b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"0f5c9d19_9f4711b1","line":10,"updated":"2021-06-01 06:20:31.000000000","message":"LGTM, but i have a small qeustion: what\u0027s the default value of CgroupnsMode in docker(it looks like it\u0027s already the host)? thanks","commit_id":"95520df0947e58d9c8e402fa88f1de957cfe059f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e26854714f8a282939106da31f1a29a129891807","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[docker] Add support for setting CgroupnsMode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is required to support Debian Bullseye (11) - need to set"},{"line_number":10,"context_line":"nova-libvirt to use \u0027host\u0027 CgroupnsMode."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I40213d4092fa325bcf37bb1fb4437ab125fe328b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7e396e21_a65ac980","line":10,"in_reply_to":"0f5c9d19_9f4711b1","updated":"2021-06-01 06:46:22.000000000","message":"pre-20.10 - host and cannot be changed\n20.10 with cgroups v1 - host\n20.10 with cgroups v2 - private (this is when libvirt would break)","commit_id":"95520df0947e58d9c8e402fa88f1de957cfe059f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"88c46b701f47ce69354dab5ba79df36ce473e428","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[docker] Add support for setting CgroupnsMode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is required to support Debian Bullseye (11) - need to set"},{"line_number":10,"context_line":"nova-libvirt to use \u0027host\u0027 CgroupnsMode."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I40213d4092fa325bcf37bb1fb4437ab125fe328b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"a2ef7fbe_7b79a60d","line":10,"in_reply_to":"34839ead_70b5d027","updated":"2021-06-01 10:19:31.000000000","message":"It\u0027s separated on purpose:\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/793698/1","commit_id":"95520df0947e58d9c8e402fa88f1de957cfe059f"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fb1ff6492729af31514d75b4e947853e3a72be33","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[docker] Add support for setting CgroupnsMode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is required to support Debian Bullseye (11) - need to set"},{"line_number":10,"context_line":"nova-libvirt to use \u0027host\u0027 CgroupnsMode."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I40213d4092fa325bcf37bb1fb4437ab125fe328b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"34839ead_70b5d027","line":10,"in_reply_to":"7e396e21_a65ac980","updated":"2021-06-01 10:14:58.000000000","message":"thanks, Do we need to set CgroupnsMode in nova-cell(ansible/roles/nova-cell/defaults/main.yml) role? or submit a new patch ?","commit_id":"95520df0947e58d9c8e402fa88f1de957cfe059f"}],"ansible/library/kolla_docker.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1f4ff06c7c160d1e4d6ba209323fffe88eb431d6","unresolved":true,"context_lines":[{"line_number":151,"context_line":"    default: None"},{"line_number":152,"context_line":"    choices:"},{"line_number":153,"context_line":"      - host"},{"line_number":154,"context_line":"  cg_mode:"},{"line_number":155,"context_line":"    description:"},{"line_number":156,"context_line":"      - Set docker cgroups namespace (default depends on Docker config)"},{"line_number":157,"context_line":"      - Supported only with Docker 20.10 (Docker API 1.41) and later"}],"source_content_type":"text/x-python","patch_set":13,"id":"1563d5bd_f515bca1","line":154,"range":{"start_line":154,"start_character":2,"end_line":154,"end_character":9},"updated":"2021-05-24 10:33:16.000000000","message":"nit: docker CLI argument is --cgroupns. Can we call this either cgroupns or cgroupns_mode?","commit_id":"17a32666fbda8946807d064294e107b9137d0f16"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5ea18f66afdf39da2a0f490071384bf9bd2e4146","unresolved":true,"context_lines":[{"line_number":151,"context_line":"    default: None"},{"line_number":152,"context_line":"    choices:"},{"line_number":153,"context_line":"      - host"},{"line_number":154,"context_line":"  cg_mode:"},{"line_number":155,"context_line":"    description:"},{"line_number":156,"context_line":"      - Set docker cgroups namespace (default depends on Docker config)"},{"line_number":157,"context_line":"      - Supported only with Docker 20.10 (Docker API 1.41) and later"}],"source_content_type":"text/x-python","patch_set":13,"id":"4c4c92ef_9a357fdb","line":154,"range":{"start_line":154,"start_character":2,"end_line":154,"end_character":9},"in_reply_to":"1563d5bd_f515bca1","updated":"2021-05-28 18:48:33.000000000","message":"cgroupns_mode ftw","commit_id":"17a32666fbda8946807d064294e107b9137d0f16"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8d7d7c883af1101833f5045280b6f008287cc97c","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    default: None"},{"line_number":152,"context_line":"    choices:"},{"line_number":153,"context_line":"      - host"},{"line_number":154,"context_line":"  cg_mode:"},{"line_number":155,"context_line":"    description:"},{"line_number":156,"context_line":"      - Set docker cgroups namespace (default depends on Docker config)"},{"line_number":157,"context_line":"      - Supported only with Docker 20.10 (Docker API 1.41) and later"}],"source_content_type":"text/x-python","patch_set":13,"id":"e7c90a6c_df5f4717","line":154,"range":{"start_line":154,"start_character":2,"end_line":154,"end_character":9},"in_reply_to":"4c4c92ef_9a357fdb","updated":"2021-05-28 18:49:21.000000000","message":"Done","commit_id":"17a32666fbda8946807d064294e107b9137d0f16"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1f4ff06c7c160d1e4d6ba209323fffe88eb431d6","unresolved":true,"context_lines":[{"line_number":421,"context_line":"    def compare_cg_mode(self, container_info):"},{"line_number":422,"context_line":"        if not self._cg_mode_supported:"},{"line_number":423,"context_line":"            return False"},{"line_number":424,"context_line":"        new_cg_mode \u003d self.params.get(\u0027cg_mode\u0027)"},{"line_number":425,"context_line":"        current_cg_mode \u003d container_info[\u0027HostConfig\u0027].get(\u0027CgroupnsMode\u0027)"},{"line_number":426,"context_line":"        return new_cg_mode !\u003d current_cg_mode"},{"line_number":427,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"4902c3d9_283a3561","line":424,"range":{"start_line":424,"start_character":8,"end_line":424,"end_character":48},"updated":"2021-05-24 10:33:16.000000000","message":"Default is None.","commit_id":"17a32666fbda8946807d064294e107b9137d0f16"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5ea18f66afdf39da2a0f490071384bf9bd2e4146","unresolved":true,"context_lines":[{"line_number":421,"context_line":"    def compare_cg_mode(self, container_info):"},{"line_number":422,"context_line":"        if not self._cg_mode_supported:"},{"line_number":423,"context_line":"            return False"},{"line_number":424,"context_line":"        new_cg_mode \u003d self.params.get(\u0027cg_mode\u0027)"},{"line_number":425,"context_line":"        current_cg_mode \u003d container_info[\u0027HostConfig\u0027].get(\u0027CgroupnsMode\u0027)"},{"line_number":426,"context_line":"        return new_cg_mode !\u003d current_cg_mode"},{"line_number":427,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"65c9d586_b3cd62ab","line":424,"range":{"start_line":424,"start_character":8,"end_line":424,"end_character":48},"in_reply_to":"4902c3d9_283a3561","updated":"2021-05-28 18:48:33.000000000","message":"Yes, which should act like \"don\u0027t care\". To fix.","commit_id":"17a32666fbda8946807d064294e107b9137d0f16"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1f4ff06c7c160d1e4d6ba209323fffe88eb431d6","unresolved":true,"context_lines":[{"line_number":422,"context_line":"        if not self._cg_mode_supported:"},{"line_number":423,"context_line":"            return False"},{"line_number":424,"context_line":"        new_cg_mode \u003d self.params.get(\u0027cg_mode\u0027)"},{"line_number":425,"context_line":"        current_cg_mode \u003d container_info[\u0027HostConfig\u0027].get(\u0027CgroupnsMode\u0027)"},{"line_number":426,"context_line":"        return new_cg_mode !\u003d current_cg_mode"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def compare_privileged(self, container_info):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9d5318c9_6f185313","line":425,"range":{"start_line":425,"start_character":8,"end_line":425,"end_character":74},"updated":"2021-05-24 10:33:16.000000000","message":"For an existing container, does this take the user-provided parameter, or does it apply the daemon-level default?","commit_id":"17a32666fbda8946807d064294e107b9137d0f16"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5ea18f66afdf39da2a0f490071384bf9bd2e4146","unresolved":true,"context_lines":[{"line_number":422,"context_line":"        if not self._cg_mode_supported:"},{"line_number":423,"context_line":"            return False"},{"line_number":424,"context_line":"        new_cg_mode \u003d self.params.get(\u0027cg_mode\u0027)"},{"line_number":425,"context_line":"        current_cg_mode \u003d container_info[\u0027HostConfig\u0027].get(\u0027CgroupnsMode\u0027)"},{"line_number":426,"context_line":"        return new_cg_mode !\u003d current_cg_mode"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def compare_privileged(self, container_info):"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf77705f_ef0479d1","line":425,"range":{"start_line":425,"start_character":8,"end_line":425,"end_character":74},"in_reply_to":"9d5318c9_6f185313","updated":"2021-05-28 18:48:33.000000000","message":"Pre-20.10 this is \"\" which is equivalent to \"host\". New containers simply inherit the default from the moment they were run at.","commit_id":"17a32666fbda8946807d064294e107b9137d0f16"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e4d1cc47da027ec976b22ce1d9ab7a7706e33238","unresolved":true,"context_lines":[{"line_number":798,"context_line":"            # natively so we stuff it in manually."},{"line_number":799,"context_line":"            cgroupns_mode \u003d self.params.get(\u0027cgroupns_mode\u0027)"},{"line_number":800,"context_line":"            if cgroupns_mode is not None:"},{"line_number":801,"context_line":"                host_config[\u0027CgroupnsMode\u0027] \u003d cgroupns_mode"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        return host_config"},{"line_number":804,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ac5930a8_a1590bab","line":801,"updated":"2021-06-02 11:00:09.000000000","message":"What happens if Docker is \u003c 1.41? Does it fail?","commit_id":"95520df0947e58d9c8e402fa88f1de957cfe059f"}],"ansible/roles/nova-cell/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4715fa1b9b2b5ac4c6213ac0a3b3661a7d0ceee3","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    pid_mode: \"host\""},{"line_number":11,"context_line":"    # Setting cgroups namespace mode requires Docker 20.10 and, as of Wallaby,"},{"line_number":12,"context_line":"    # is relevant only on Debian 11 (Bullseye)."},{"line_number":13,"context_line":"    cg_mode: \"{% if ansible_distribution \u003d\u003d \u0027Debian\u0027 and ansible_distribution_release \u003d\u003d \u0027bullseye\u0027 %}host{% else %}{{ omit }}{% endif %}\""},{"line_number":14,"context_line":"    privileged: True"},{"line_number":15,"context_line":"    volumes: \"{{ nova_libvirt_default_volumes + nova_libvirt_extra_volumes }}\""},{"line_number":16,"context_line":"    dimensions: \"{{ nova_libvirt_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9d21f6e3_cb9f1986","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":138},"updated":"2021-05-21 13:40:36.000000000","message":"We could have a variable for enabling cgroups2 - by default enable it only on Debian Bullseye - but people wanting to run cgroupsv2 for example on CentOS 8 - could benefit from that.","commit_id":"6b7bfd0dfea86ab8a8757dbac34478be713ae478"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3c23a5710d8b95f69160505008e6f65643f971cb","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    pid_mode: \"host\""},{"line_number":11,"context_line":"    # Setting cgroups namespace mode requires Docker 20.10 and, as of Wallaby,"},{"line_number":12,"context_line":"    # is relevant only on Debian 11 (Bullseye)."},{"line_number":13,"context_line":"    cg_mode: \"{% if ansible_distribution \u003d\u003d \u0027Debian\u0027 and ansible_distribution_release \u003d\u003d \u0027bullseye\u0027 %}host{% else %}{{ omit }}{% endif %}\""},{"line_number":14,"context_line":"    privileged: True"},{"line_number":15,"context_line":"    volumes: \"{{ nova_libvirt_default_volumes + nova_libvirt_extra_volumes }}\""},{"line_number":16,"context_line":"    dimensions: \"{{ nova_libvirt_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"c11a23ab_00cb5551","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":138},"in_reply_to":"9d21f6e3_cb9f1986","updated":"2021-05-21 14:17:18.000000000","message":"Or perhaps we should just detect the Docker version as that is what makes it work or not.","commit_id":"6b7bfd0dfea86ab8a8757dbac34478be713ae478"}],"tests/test_kolla_docker.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1f4ff06c7c160d1e4d6ba209323fffe88eb431d6","unresolved":true,"context_lines":[{"line_number":1000,"context_line":"                                   docker_api_version\u003d\u00271.41\u0027)"},{"line_number":1001,"context_line":"        self.assertTrue(self.dw.compare_cg_mode(container_info))"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"    def test_compare_cg_mode_unsupported(self):"},{"line_number":1004,"context_line":"        container_info \u003d {\u0027HostConfig\u0027: dict()}"},{"line_number":1005,"context_line":"        self.dw \u003d get_DockerWorker({\u0027cg_mode\u0027: \u0027whatever\u0027})"},{"line_number":1006,"context_line":"        self.assertFalse(self.dw.compare_cg_mode(container_info))"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"    def test_compare_privileged_neg(self):"},{"line_number":1009,"context_line":"        container_info \u003d {\u0027HostConfig\u0027: dict(Privileged\u003dTrue)}"}],"source_content_type":"text/x-python","patch_set":13,"id":"749f26e2_979911b7","line":1006,"range":{"start_line":1003,"start_character":0,"end_line":1006,"end_character":65},"updated":"2021-05-24 10:33:16.000000000","message":"I suppose there are two options:\n\n1. only set cg_mode when cgroupsv2 is in use, fail if unsupported by docker\n2. check docker version \u003e 1.41 in nova prechecks if using cgroups v2\n\n2 might be easier/cleaner","commit_id":"17a32666fbda8946807d064294e107b9137d0f16"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5ea18f66afdf39da2a0f490071384bf9bd2e4146","unresolved":true,"context_lines":[{"line_number":1000,"context_line":"                                   docker_api_version\u003d\u00271.41\u0027)"},{"line_number":1001,"context_line":"        self.assertTrue(self.dw.compare_cg_mode(container_info))"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"    def test_compare_cg_mode_unsupported(self):"},{"line_number":1004,"context_line":"        container_info \u003d {\u0027HostConfig\u0027: dict()}"},{"line_number":1005,"context_line":"        self.dw \u003d get_DockerWorker({\u0027cg_mode\u0027: \u0027whatever\u0027})"},{"line_number":1006,"context_line":"        self.assertFalse(self.dw.compare_cg_mode(container_info))"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"    def test_compare_privileged_neg(self):"},{"line_number":1009,"context_line":"        container_info \u003d {\u0027HostConfig\u0027: dict(Privileged\u003dTrue)}"}],"source_content_type":"text/x-python","patch_set":13,"id":"805c5691_ecfb11d2","line":1006,"range":{"start_line":1003,"start_character":0,"end_line":1006,"end_character":65},"in_reply_to":"749f26e2_979911b7","updated":"2021-05-28 18:48:33.000000000","message":"No need; see the big comment.","commit_id":"17a32666fbda8946807d064294e107b9137d0f16"}]}