)]}'
{"ansible/roles/designate/defaults/main.yml":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3add05a016ea4ada33099a6dfafceae3e3bed62f","unresolved":true,"context_lines":[{"line_number":247,"context_line":"designate_worker_default_volumes:"},{"line_number":248,"context_line":"  - \"{{ node_config_directory }}/designate-worker/:{{ container_config_directory }}/:ro\""},{"line_number":249,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":250,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":251,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":252,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/designate/designate:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/designate\u0027 if designate_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":253,"context_line":"designate_sink_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"40c0f488_847b5ce8","line":250,"updated":"2021-05-19 03:50:18.000000000","message":"what about we remove this line to default_extra_volumes? in this case , ansible should only need to calculate this vaule once.","commit_id":"6f87307248d06010e2526d2f021006f98f989eda"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fc5988894990d5aaa0c0c7b68d1d6b1524a3fe46","unresolved":true,"context_lines":[{"line_number":247,"context_line":"designate_worker_default_volumes:"},{"line_number":248,"context_line":"  - \"{{ node_config_directory }}/designate-worker/:{{ container_config_directory }}/:ro\""},{"line_number":249,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":250,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":251,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":252,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/designate/designate:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/designate\u0027 if designate_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":253,"context_line":"designate_sink_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"44251bdc_30e91d5f","line":250,"in_reply_to":"40c0f488_847b5ce8","updated":"2021-05-19 10:12:53.000000000","message":"That\u0027s an interesting idea. I might prefer to make a new variable, e.g. default_volumes or common_volumes, since default_extra_volumes is intended for users to modify.\n\nCould be a separate patch though, as I\u0027d like to backport this.","commit_id":"6f87307248d06010e2526d2f021006f98f989eda"}],"ansible/roles/ovs-dpdk/handlers/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"be910e7e7a37ff7620f4880f560846ea75f74733","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"- name: ovs-dpdk gather facts"},{"line_number":95,"context_line":"  setup:"},{"line_number":96,"context_line":"    filter: ansible_facts.*"},{"line_number":97,"context_line":"  when:"},{"line_number":98,"context_line":"    - (inventory_hostname in groups[\u0027compute\u0027]"},{"line_number":99,"context_line":"       or (enable_manila | bool and inventory_hostname in groups[\u0027manila-share\u0027])"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"32d72dc7_8b13bbd3","line":96,"range":{"start_line":96,"start_character":12,"end_line":96,"end_character":25},"updated":"2021-05-19 11:06:08.000000000","message":"This should be ansible_*","commit_id":"6f87307248d06010e2526d2f021006f98f989eda"}]}