)]}'
{"ansible/roles/monasca/handlers/main.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6e9c524af58e0a2042aa3ae3c9e0d7117592cc07","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    image: \"{{ service.image }}\""},{"line_number":79,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":80,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":81,"context_line":"    restart_policy: \"on-failure\""},{"line_number":82,"context_line":"  run_once: True"},{"line_number":83,"context_line":"  delegate_to: \"{{ groups[service.group][0] }}\""},{"line_number":84,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"72c94fd8_5f66e2a3","line":81,"updated":"2021-05-17 16:51:54.000000000","message":"For people upgrading, I think we need to delete the container to update the restart policy. If I apply this patch to a running deployment of Monasca, I see the thresh container constantly restarting after exiting 0 and finding a Storm topology. The restart policy remains as \u0027unless-stopped\u0027. Apart from that it works well.\n\nI was thinking that a simpler approach could be to submit the topology during bootstrap_service.yml. So spin up your one time container in there, on one node, and run your script to submit it if it\u0027s not already running (keep that check in the script). We could add some cleanup logic for the legacy monasca_thresh container and just remove it everywhere.\n\nOn upgrade, we could run the same bootstrap task, but pass in an ENV var to remove the topology  prior to deploying a more recent version. This env var could be optional - Monasca Thresh is rarely updated (unfortunately).\n\nOne other thing is that I see the logs from the topology get written out in the Storm directory. If you have time, please could you include those in the Fluentd config so they end up in Elastic?. If not, we can leave that for another patch, since the current logs aren\u0027t ingested by Fluentd anyway.","commit_id":"32dc3d0b85c18433949251f717e172bc479c9a0e"},{"author":{"_account_id":33469,"name":"Scott Shambarger","email":"scott-openstack@shambarger.net","username":"sshambar"},"change_message_id":"6e37e4153aefae4c5a6b350b153bf81529114185","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    image: \"{{ service.image }}\""},{"line_number":79,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":80,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":81,"context_line":"    restart_policy: \"on-failure\""},{"line_number":82,"context_line":"  run_once: True"},{"line_number":83,"context_line":"  delegate_to: \"{{ groups[service.group][0] }}\""},{"line_number":84,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"870a786e_1390455b","line":81,"in_reply_to":"72c94fd8_5f66e2a3","updated":"2021-05-20 10:11:25.000000000","message":"Makes sense to move this all to bootstrap (provided the storm is available) -- I\u0027ll still need to check for topology changes to trigger replacement of course.   Also, if there\u0027s an old non-bootstrap container out there (upgrade), removing it will need to trigger a bootstrap submission.  Fun 😊\n\nI\u0027ll look into the log issue too, if it\u0027s not too involved.","commit_id":"32dc3d0b85c18433949251f717e172bc479c9a0e"},{"author":{"_account_id":33469,"name":"Scott Shambarger","email":"scott-openstack@shambarger.net","username":"sshambar"},"change_message_id":"3fa3e175f0a53b92ced732d2c8b1a1c796f37806","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    image: \"{{ service.image }}\""},{"line_number":79,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":80,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":81,"context_line":"    restart_policy: \"on-failure\""},{"line_number":82,"context_line":"  run_once: True"},{"line_number":83,"context_line":"  delegate_to: \"{{ groups[service.group][0] }}\""},{"line_number":84,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"48cb309c_1da39cc5","line":81,"in_reply_to":"870a786e_1390455b","updated":"2021-05-24 05:20:42.000000000","message":"Latest set uses the script which is submitted to Kolla to check/remove the topology.\n\nI decided against the bootstrap idea: topology submissions need to handle changes, and aren\u0027t static initialization.  So now there\u0027s a replacement \"monasca_thresh\" container that submits any missing topology (and should replace any old \"local\" container on upgrade/restart), and also a one-shot+removed \"reconfigure_monasca_thresh\" container triggered by topology changes.  This allows deploys to work cleanly (container exists, and is in the expected \"exited\" state), and still handle any local/upgrade topology changes.  Host restarts should also work w/o problems.\n\nI figured I\u0027ll leave the fluentd issue until later, as there might be an problem with logs creating logs, and I don\u0027t want to create a loop.","commit_id":"32dc3d0b85c18433949251f717e172bc479c9a0e"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7310ed28871f659d114e0984605524b97ff7ba16","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  when:"},{"line_number":45,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Restart monasca-thresh container"},{"line_number":48,"context_line":"  vars:"},{"line_number":49,"context_line":"    service: \"{{ monasca_services[\u0027monasca-thresh\u0027] }}\""},{"line_number":50,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"837abfaf_51bd3974","line":47,"updated":"2021-06-03 16:36:02.000000000","message":"I suppose we could rename this now to \u0027submit monasca-thresh topology\u0027 or something similar?","commit_id":"b8d63b0a4714c2bf49b2419c3d14a882e2b611ef"},{"author":{"_account_id":33469,"name":"Scott Shambarger","email":"scott-openstack@shambarger.net","username":"sshambar"},"change_message_id":"0a4cdfab8d14ac8a5206d7d66d0276a819c3a04c","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  when:"},{"line_number":45,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Restart monasca-thresh container"},{"line_number":48,"context_line":"  vars:"},{"line_number":49,"context_line":"    service: \"{{ monasca_services[\u0027monasca-thresh\u0027] }}\""},{"line_number":50,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fb20ddcb_eb9c7d3b","line":47,"in_reply_to":"2bc76fbb_04b3754c","updated":"2021-06-05 16:03:59.000000000","message":"Of course, another option would be to break monasca-thresh out of the monasca_services list and handle it on it\u0027s own.  That approach would allow it to be correctly handled as a \"non-running\" container, but would require that the user be warned that any custom configs for it under monasca_services:monasca-thresh would need to be moved on upgrade.","commit_id":"b8d63b0a4714c2bf49b2419c3d14a882e2b611ef"},{"author":{"_account_id":33469,"name":"Scott Shambarger","email":"scott-openstack@shambarger.net","username":"sshambar"},"change_message_id":"93993a02176fd7a43f2ef6ef02978bcdc5e3b518","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  when:"},{"line_number":45,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Restart monasca-thresh container"},{"line_number":48,"context_line":"  vars:"},{"line_number":49,"context_line":"    service: \"{{ monasca_services[\u0027monasca-thresh\u0027] }}\""},{"line_number":50,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2bc76fbb_04b3754c","line":47,"in_reply_to":"837abfaf_51bd3974","updated":"2021-06-05 02:01:56.000000000","message":"The name has to stay Restart as it\u0027s used in the check-containers loop as a template 😊\n\nI\u0027ll update the Reconfigure to Resubmitting though.","commit_id":"b8d63b0a4714c2bf49b2419c3d14a882e2b611ef"}],"ansible/roles/monasca/tasks/check-containers.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7310ed28871f659d114e0984605524b97ff7ba16","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    pid_mode: \"{{ item.value.pid_mode|default(\u0027\u0027) }}\""},{"line_number":10,"context_line":"    volumes: \"{{ item.value.volumes }}\""},{"line_number":11,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":12,"context_line":"    state: \"{{ item.value.state | d(\u0027running\u0027) }}\""},{"line_number":13,"context_line":"  when:"},{"line_number":14,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":15,"context_line":"    - item.value.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7ecc1054_b60bb790","line":12,"updated":"2021-06-03 16:36:02.000000000","message":"femto-nit: I think it makes sense to stay consistent with the code base and use default here instead of the shorthand.","commit_id":"b8d63b0a4714c2bf49b2419c3d14a882e2b611ef"}],"ansible/roles/monasca/tasks/config.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6e9c524af58e0a2042aa3ae3c9e0d7117592cc07","unresolved":true,"context_lines":[{"line_number":290,"context_line":"    - Reconfiguring monasca-thresh topology"},{"line_number":291,"context_line":"    - Restart monasca-thresh container"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"- name: Copying over kolla_monasca_extend_start"},{"line_number":294,"context_line":"  vars:"},{"line_number":295,"context_line":"    service: \"{{ monasca_services[\u0027monasca-thresh\u0027] }}\""},{"line_number":296,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d529f53f_54b378a7","line":293,"updated":"2021-05-17 16:51:54.000000000","message":"These extend start scripts are normally included via the Kolla project and get copied into the container in the Dockerfile. Please could you move it there, and add a Depends-On to the commit message here in Kolla Ansible?\n\nExample: https://github.com/openstack/kolla/tree/master/docker/monasca/monasca-api","commit_id":"32dc3d0b85c18433949251f717e172bc479c9a0e"},{"author":{"_account_id":33469,"name":"Scott Shambarger","email":"scott-openstack@shambarger.net","username":"sshambar"},"change_message_id":"3fa3e175f0a53b92ced732d2c8b1a1c796f37806","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    - Reconfiguring monasca-thresh topology"},{"line_number":291,"context_line":"    - Restart monasca-thresh container"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"- name: Copying over kolla_monasca_extend_start"},{"line_number":294,"context_line":"  vars:"},{"line_number":295,"context_line":"    service: \"{{ monasca_services[\u0027monasca-thresh\u0027] }}\""},{"line_number":296,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f963f5d_3856c321","line":293,"in_reply_to":"0e658782_9ad10bd9","updated":"2021-05-24 05:20:42.000000000","message":"Script is now moved to Change 792751","commit_id":"32dc3d0b85c18433949251f717e172bc479c9a0e"},{"author":{"_account_id":33469,"name":"Scott Shambarger","email":"scott-openstack@shambarger.net","username":"sshambar"},"change_message_id":"6e37e4153aefae4c5a6b350b153bf81529114185","unresolved":true,"context_lines":[{"line_number":290,"context_line":"    - Reconfiguring monasca-thresh topology"},{"line_number":291,"context_line":"    - Restart monasca-thresh container"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"- name: Copying over kolla_monasca_extend_start"},{"line_number":294,"context_line":"  vars:"},{"line_number":295,"context_line":"    service: \"{{ monasca_services[\u0027monasca-thresh\u0027] }}\""},{"line_number":296,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0e658782_9ad10bd9","line":293,"in_reply_to":"6657ea8c_263dd6ef","updated":"2021-05-20 10:11:25.000000000","message":"OK, I\u0027ll keep it as simple as possible... need to figure out how kolla images prefer to handle their environment based options - need to find some other images that use them.","commit_id":"32dc3d0b85c18433949251f717e172bc479c9a0e"},{"author":{"_account_id":33469,"name":"Scott Shambarger","email":"scott-openstack@shambarger.net","username":"sshambar"},"change_message_id":"e5d00c61aa1da6a79af5e772d9ff92e75652f465","unresolved":true,"context_lines":[{"line_number":290,"context_line":"    - Reconfiguring monasca-thresh topology"},{"line_number":291,"context_line":"    - Restart monasca-thresh container"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"- name: Copying over kolla_monasca_extend_start"},{"line_number":294,"context_line":"  vars:"},{"line_number":295,"context_line":"    service: \"{{ monasca_services[\u0027monasca-thresh\u0027] }}\""},{"line_number":296,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f282a444_b47b648f","line":293,"in_reply_to":"d529f53f_54b378a7","updated":"2021-05-17 20:44:57.000000000","message":"There\u0027s a very full featured docker start script in the monasca-thresh repository... looks like it was added after the kolla scripts were created.  Do you think it makes sense to pull it into the kolla image and use that? (it does include wait scripts for mysql and kafka topics... which we could remove, but regular kolla users may want them).","commit_id":"32dc3d0b85c18433949251f717e172bc479c9a0e"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"848bd11079eb84e2d698e1b9526c9642cf84ab25","unresolved":true,"context_lines":[{"line_number":290,"context_line":"    - Reconfiguring monasca-thresh topology"},{"line_number":291,"context_line":"    - Restart monasca-thresh container"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"- name: Copying over kolla_monasca_extend_start"},{"line_number":294,"context_line":"  vars:"},{"line_number":295,"context_line":"    service: \"{{ monasca_services[\u0027monasca-thresh\u0027] }}\""},{"line_number":296,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6657ea8c_263dd6ef","line":293,"in_reply_to":"f282a444_b47b648f","updated":"2021-05-18 08:19:47.000000000","message":"Good question - I agree there is some useful stuff there, like memory tunings that we don\u0027t have. My preference would be to consider pulling in some of that in another commit and try and keep this one simple so we can merge it quickly.","commit_id":"32dc3d0b85c18433949251f717e172bc479c9a0e"}],"ansible/roles/monasca/tasks/upgrade.yml":[{"author":{"_account_id":33469,"name":"Scott Shambarger","email":"scott-openstack@shambarger.net","username":"sshambar"},"change_message_id":"9f6748be61c5ed3d3936e0ff498de170e48c4d38","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- import_tasks: bootstrap_service.yml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# NOTE(sshambar): We don\u0027t want pre-upgrade monasca-thresh instances"},{"line_number":13,"context_line":"# running in local mode after an upgrade, so stop them."},{"line_number":14,"context_line":"# The first node will be replaced with the submission container in the"},{"line_number":15,"context_line":"# handlers below."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"39acd612_a22721fb","line":12,"updated":"2021-06-06 20:50:42.000000000","message":"Added to catch the case when pre-upgrade the thresh containers were running multinode","commit_id":"aea9bf355058a15e7ce7bb2649de3872e7041c89"},{"author":{"_account_id":33469,"name":"Scott Shambarger","email":"scott-openstack@shambarger.net","username":"sshambar"},"change_message_id":"4335fdbcbad7acf0ff647241ac62d9dc86565ea6","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- import_tasks: bootstrap_service.yml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# NOTE(sshambar): We don\u0027t want pre-upgrade monasca-thresh instances"},{"line_number":13,"context_line":"# running in local mode after an upgrade, so stop them."},{"line_number":14,"context_line":"# The first node will be replaced with the submission container in the"},{"line_number":15,"context_line":"# handlers below."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"b116fa5f_c12c127d","line":12,"in_reply_to":"39acd612_a22721fb","updated":"2021-07-12 18:22:00.000000000","message":"Ack","commit_id":"aea9bf355058a15e7ce7bb2649de3872e7041c89"}]}