)]}'
{"ansible/roles/prechecks/vars/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"26301c042fc8bff36e05611e7adadeb87ffe477f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_version_min: \u002718.09\u0027"},{"line_number":3,"context_line":"docker_py_version_min: \u00273.4.1\u0027"},{"line_number":4,"context_line":"ansible_version_min: \u00272.9\u0027"},{"line_number":5,"context_line":"ansible_version_max: \u00272.10\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fcb25fdd_b90cc205","line":2,"range":{"start_line":2,"start_character":21,"end_line":2,"end_character":26},"updated":"2021-05-21 13:34:53.000000000","message":"Given the fact that 18.09 branch under github/docker/docker-ce has been last updated 2 years ago - I doubt it\u0027s still maintained. Also Rancher supports only 19.03 and 20.10 on CentOS 8 - I would guess that we should bump minimum to 19.03 - or even 20.10 (to get cgroups v2 support).","commit_id":"07371ceadb1a37441e0d6d91482c11ebd2942a99"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"af75a8914918a1d2b54c056e1123ad5435710788","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_version_min: \u002718.09\u0027"},{"line_number":3,"context_line":"docker_py_version_min: \u00273.4.1\u0027"},{"line_number":4,"context_line":"ansible_version_min: \u00272.9\u0027"},{"line_number":5,"context_line":"ansible_version_max: \u00272.10\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"98b35cf0_8866abf8","line":2,"range":{"start_line":2,"start_character":21,"end_line":2,"end_character":26},"in_reply_to":"196f3d3f_486b929d","updated":"2021-05-24 18:42:50.000000000","message":"18.09 is what Debian buster has and it seems worky. They backport security patches.","commit_id":"07371ceadb1a37441e0d6d91482c11ebd2942a99"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06f5f704e73c98692e6fa977ec5774b853aef290","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_version_min: \u002718.09\u0027"},{"line_number":3,"context_line":"docker_py_version_min: \u00273.4.1\u0027"},{"line_number":4,"context_line":"ansible_version_min: \u00272.9\u0027"},{"line_number":5,"context_line":"ansible_version_max: \u00272.10\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9268812f_3aa014a6","line":2,"range":{"start_line":2,"start_character":21,"end_line":2,"end_character":26},"in_reply_to":"3d612f26_941bd26e","updated":"2021-05-28 13:02:25.000000000","message":"Yeah, that\u0027s another patch. https://review.opendev.org/c/openstack/kolla-ansible/+/790678","commit_id":"07371ceadb1a37441e0d6d91482c11ebd2942a99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0259570e0d719c8114b2d9f3e72b80ca9ebc623c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_version_min: \u002718.09\u0027"},{"line_number":3,"context_line":"docker_py_version_min: \u00273.4.1\u0027"},{"line_number":4,"context_line":"ansible_version_min: \u00272.9\u0027"},{"line_number":5,"context_line":"ansible_version_max: \u00272.10\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3d612f26_941bd26e","line":2,"range":{"start_line":2,"start_character":21,"end_line":2,"end_character":26},"in_reply_to":"870b083d_c3ae328a","updated":"2021-05-27 10:01:32.000000000","message":"We also need to support buster. We do need some check somewhere for 20.10/1.41 with cgroupsv2.","commit_id":"07371ceadb1a37441e0d6d91482c11ebd2942a99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"31421e58107264d2190219043e5223ee758e7d95","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_version_min: \u002718.09\u0027"},{"line_number":3,"context_line":"docker_py_version_min: \u00273.4.1\u0027"},{"line_number":4,"context_line":"ansible_version_min: \u00272.9\u0027"},{"line_number":5,"context_line":"ansible_version_max: \u00272.10\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"870b083d_c3ae328a","line":2,"range":{"start_line":2,"start_character":21,"end_line":2,"end_character":26},"in_reply_to":"98b35cf0_8866abf8","updated":"2021-05-27 06:11:41.000000000","message":"Buster - but we have Bullseye and we need 20.10 for cgroups v2, right? Should we have a variable that enables cgroupsv2 (by default on Bullseye) and use 20.10 if it\u0027s enabled, else 18.09?","commit_id":"07371ceadb1a37441e0d6d91482c11ebd2942a99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d359175d33206e187a8baaed091d9fae2da0721","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_version_min: \u002718.09\u0027"},{"line_number":3,"context_line":"docker_py_version_min: \u00273.4.1\u0027"},{"line_number":4,"context_line":"ansible_version_min: \u00272.9\u0027"},{"line_number":5,"context_line":"ansible_version_max: \u00272.10\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"196f3d3f_486b929d","line":2,"range":{"start_line":2,"start_character":21,"end_line":2,"end_character":26},"in_reply_to":"fcb25fdd_b90cc205","updated":"2021-05-24 10:11:34.000000000","message":"It doesn\u0027t really harm us to be flexible on these versions. Why be more restrictive than necessary?","commit_id":"07371ceadb1a37441e0d6d91482c11ebd2942a99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"26301c042fc8bff36e05611e7adadeb87ffe477f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_version_min: \u002718.09\u0027"},{"line_number":3,"context_line":"docker_py_version_min: \u00273.4.1\u0027"},{"line_number":4,"context_line":"ansible_version_min: \u00272.9\u0027"},{"line_number":5,"context_line":"ansible_version_max: \u00272.10\u0027"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3dc2d099_a450569c","line":3,"range":{"start_line":3,"start_character":24,"end_line":3,"end_character":29},"updated":"2021-05-21 13:34:53.000000000","message":"3.4.1? I think we\u0027re a bit conservative here - this version has been released in Aug 2018... I think we should require 4.x at least. 4.3.0 is tested with 19.03 - so maybe that should be our minimum?","commit_id":"07371ceadb1a37441e0d6d91482c11ebd2942a99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"31421e58107264d2190219043e5223ee758e7d95","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_version_min: \u002718.09\u0027"},{"line_number":3,"context_line":"docker_py_version_min: \u00273.4.1\u0027"},{"line_number":4,"context_line":"ansible_version_min: \u00272.9\u0027"},{"line_number":5,"context_line":"ansible_version_max: \u00272.10\u0027"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9af1fe70_8c26ae6d","line":3,"range":{"start_line":3,"start_character":24,"end_line":3,"end_character":29},"in_reply_to":"30d7c06a_735b3ce4","updated":"2021-05-27 06:11:41.000000000","message":"4.0.3 includes this: https://github.com/docker/docker-py/pull/2353 - I don\u0027t know if it\u0027s relevant for healthchecks, but I guess we\u0027re mostly installing something newer than this.","commit_id":"07371ceadb1a37441e0d6d91482c11ebd2942a99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d359175d33206e187a8baaed091d9fae2da0721","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_version_min: \u002718.09\u0027"},{"line_number":3,"context_line":"docker_py_version_min: \u00273.4.1\u0027"},{"line_number":4,"context_line":"ansible_version_min: \u00272.9\u0027"},{"line_number":5,"context_line":"ansible_version_max: \u00272.10\u0027"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a6d9d3d7_487155f5","line":3,"range":{"start_line":3,"start_character":24,"end_line":3,"end_character":29},"in_reply_to":"3dc2d099_a450569c","updated":"2021-05-24 10:11:34.000000000","message":"Again, this should really just be the minimum version that provides the features we need. People will in general use a more recent version.","commit_id":"07371ceadb1a37441e0d6d91482c11ebd2942a99"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"af75a8914918a1d2b54c056e1123ad5435710788","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_version_min: \u002718.09\u0027"},{"line_number":3,"context_line":"docker_py_version_min: \u00273.4.1\u0027"},{"line_number":4,"context_line":"ansible_version_min: \u00272.9\u0027"},{"line_number":5,"context_line":"ansible_version_max: \u00272.10\u0027"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"30d7c06a_735b3ce4","line":3,"range":{"start_line":3,"start_character":24,"end_line":3,"end_character":29},"in_reply_to":"a6d9d3d7_487155f5","updated":"2021-05-24 18:42:50.000000000","message":"Like above, I took this version from Debian buster. It really seems we don\u0027t use stuff from later versions. Perhaps the original 2.0.0 works too but I have not checked. 😜","commit_id":"07371ceadb1a37441e0d6d91482c11ebd2942a99"}]}