)]}'
{"ansible/roles/swift/handlers/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1c860ed77badb15f1db3cbb604378189b445eaa0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-api container"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"swift-api\""},{"line_number":5,"context_line":"    service: \"{{ swift_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"08bd3366_3f70302d","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":25},"updated":"2021-06-07 09:20:31.000000000","message":"the correct name is swift-proxy-server. You can change the name, see https://review.opendev.org/c/openstack/kolla-ansible/+/782387/7/ansible/roles/swift/defaults/main.yml.","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"77f828dd39e0b3b67f06c9c083a7cc9a92797466","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-api container"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"swift-api\""},{"line_number":5,"context_line":"    service: \"{{ swift_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fc3aa2e2_5d836fb7","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":25},"in_reply_to":"053711b4_9a724183","updated":"2021-06-07 13:16:48.000000000","message":"Not done in latest patch","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"aeafec6593b037d054eeb4f52bdfda67f2434c7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-api container"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"swift-api\""},{"line_number":5,"context_line":"    service: \"{{ swift_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"053711b4_9a724183","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":25},"in_reply_to":"08bd3366_3f70302d","updated":"2021-06-07 09:47:05.000000000","message":"Done","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e441dda2a950d1c8a1c18a849062721b8e15dac2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-api container"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"swift-api\""},{"line_number":5,"context_line":"    service: \"{{ swift_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4b02c079_4b520eec","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":25},"in_reply_to":"59b1077e_da2b5d1a","updated":"2021-06-07 15:35:16.000000000","message":"\u003e Not done in latest patch\n\nsure? https://review.opendev.org/c/openstack/kolla-ansible/+/795030/5/ansible/roles/swift/handlers/main.yml","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"58a09dc19ac8a2b4063ef7c3baaf67cc1e74c7e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-api container"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"swift-api\""},{"line_number":5,"context_line":"    service: \"{{ swift_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"59b1077e_da2b5d1a","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":25},"in_reply_to":"61173b9d_45380cbc","updated":"2021-06-07 14:58:40.000000000","message":"Makes sense.","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"553628088e99a9ed3769d7c5d630a4d37a6dbd18","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-api container"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"swift-api\""},{"line_number":5,"context_line":"    service: \"{{ swift_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"61173b9d_45380cbc","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":25},"in_reply_to":"c148d9a7_93ff43d6","updated":"2021-06-07 14:49:38.000000000","message":"It\u0027s correct in that that is what is in swift_services, but incorrect in that the name of the service is swift-proxy-server. I\u0027m suggesting that we fix it rather than propagate the error.","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8572e2207ac08068af2a37d9830a48de12441e64","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-api container"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"swift-api\""},{"line_number":5,"context_line":"    service: \"{{ swift_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c148d9a7_93ff43d6","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":25},"in_reply_to":"fc3aa2e2_5d836fb7","updated":"2021-06-07 13:41:30.000000000","message":"Is not \u0027swift-api\u0027 the currently correct one?","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1c860ed77badb15f1db3cbb604378189b445eaa0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-api container"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"swift-api\""},{"line_number":5,"context_line":"    service: \"{{ swift_services[service_name] }}\""},{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  kolla_docker:"},{"line_number":8,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":9,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":10,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":11,"context_line":"    image: \"{{ service.image }}\""},{"line_number":12,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":13,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":14,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":15,"context_line":"  when:"},{"line_number":16,"context_line":"    - kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"21aff4c2_63bd4b45","line":16,"range":{"start_line":3,"start_character":0,"end_line":16,"end_character":30},"updated":"2021-06-07 09:20:31.000000000","message":"Right now, restarting the container isn\u0027t necessary here for swift. We could use a noop meta action: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/meta_module.html","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"aeafec6593b037d054eeb4f52bdfda67f2434c7e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-api container"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"swift-api\""},{"line_number":5,"context_line":"    service: \"{{ swift_services[service_name] }}\""},{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  kolla_docker:"},{"line_number":8,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":9,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":10,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":11,"context_line":"    image: \"{{ service.image }}\""},{"line_number":12,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":13,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":14,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":15,"context_line":"  when:"},{"line_number":16,"context_line":"    - kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b5681ca8_68ff984c","line":16,"range":{"start_line":3,"start_character":0,"end_line":16,"end_character":30},"in_reply_to":"21aff4c2_63bd4b45","updated":"2021-06-07 09:47:05.000000000","message":"will check. thanks.","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"860b75dda14a3b568fc4a41a995aa75189b9b5c7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-api container"},{"line_number":3,"context_line":"  meta: noop"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1b75f34f_df6ade5f","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":25},"updated":"2021-06-07 16:09:50.000000000","message":"This should be swift-proxy-server, and you\u0027ll need to change swift_services in defaults.yml to match.","commit_id":"5b42f4fb4bf77f7cdb57853c4a5726071297f577"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6a476357f082d0269ab62c3651dc74e1aa547eb5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-api container"},{"line_number":3,"context_line":"  meta: noop"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7b966b82_018b7056","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":25},"in_reply_to":"1b75f34f_df6ade5f","updated":"2021-06-07 17:29:20.000000000","message":"so, You want to say we an another errors in role? the wrong container name which never used before?) will check for sure)))","commit_id":"5b42f4fb4bf77f7cdb57853c4a5726071297f577"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"95a35c3bb986e610b0d8035a0523edf62f8ef4c5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-proxy-server container"},{"line_number":3,"context_line":"  meta: noop"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"60e42792_fee7d087","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":12},"updated":"2021-06-07 22:16:08.000000000","message":"we faced an error. this is don\u0027t work in the handlers. the issue still exist: https://github.com/ansible/ansible/issues/52719","commit_id":"85abdb9823cf7c9dd672f6acfd51b9ab7ece8771"}],"ansible/roles/swift/tasks/deploy.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1c860ed77badb15f1db3cbb604378189b445eaa0","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    run_start_swift_proxy_server: \"yes\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- import_tasks: check.yml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Flush handlers"},{"line_number":13,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"eb2a5193_e393a4e0","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":22},"updated":"2021-06-07 09:20:31.000000000","message":"nit: strictly it\u0027s not required, since handlers are flushed at the end of a play.","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"aeafec6593b037d054eeb4f52bdfda67f2434c7e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    run_start_swift_proxy_server: \"yes\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- import_tasks: check.yml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Flush handlers"},{"line_number":13,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"63ad275f_defd7aed","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":22},"in_reply_to":"eb2a5193_e393a4e0","updated":"2021-06-07 09:47:05.000000000","message":"Done","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"}],"ansible/roles/swift/tasks/upgrade.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1c860ed77badb15f1db3cbb604378189b445eaa0","unresolved":true,"context_lines":[{"line_number":6,"context_line":"  when: not swift_enable_rolling_upgrade | bool"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Flush handlers"},{"line_number":9,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f2d3faaa_ef4fdad7","line":9,"updated":"2021-06-07 09:20:31.000000000","message":"ditto","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"aeafec6593b037d054eeb4f52bdfda67f2434c7e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  when: not swift_enable_rolling_upgrade | bool"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Flush handlers"},{"line_number":9,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"cb633b7e_18124c99","line":9,"in_reply_to":"f2d3faaa_ef4fdad7","updated":"2021-06-07 09:47:05.000000000","message":"Done","commit_id":"7b694788b504d079c7e7bf71ab38108154e9a1e0"}]}