)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"432bb74df4a16c419606d2f1201f96340bb47cdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"62c85296_391dd822","updated":"2022-08-29 11:07:30.000000000","message":"These are not used by the relevant daemons and so can be dropped to, e.g., avoid creating the cinder volume on hosts where there is no cinder.","commit_id":"b5ebb2b6bb6ac8809d68a908252718b7f4e9cee6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fdda3f2b825c5d7594f8afda8670045ee761c6ac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8fcc7f48_127e1dd0","in_reply_to":"62c85296_391dd822","updated":"2022-09-08 08:38:47.000000000","message":"This comment should go into the commit message.\n\nAlso maybe I\u0027m overcomplicating, but do we need to care about cleaning up existing volumes on upgrade?","commit_id":"b5ebb2b6bb6ac8809d68a908252718b7f4e9cee6"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bf54e69fbf5b93174f937a2242d69476b5018ff7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4a228f7b_eb258e50","in_reply_to":"8fcc7f48_127e1dd0","updated":"2022-09-09 21:23:23.000000000","message":"Thanks, you are right.\n\nRegarding the cleanup - we usually don\u0027t do it. Also, in this case the volumes take virtually no space as they are unused. The patch is more like cosmetic to prevent confusion in new deployments.","commit_id":"b5ebb2b6bb6ac8809d68a908252718b7f4e9cee6"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"024505d8420d9160fbf01930856db8f0686ca504","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cb8133f3_bda101e1","updated":"2022-09-10 10:28:47.000000000","message":"ok, cinder stuff passes but zun fails again; rocky passes because it uses old images","commit_id":"f0cda6577dd1dbbbe51c51213211dce476473d67"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bf0ca32b38eacb4fcef6059778421fa603550e69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f837c7a5_f5cfa911","updated":"2022-09-10 08:31:00.000000000","message":"recheck (debian connectivity issues, ubuntu some zun weirdness)","commit_id":"f0cda6577dd1dbbbe51c51213211dce476473d67"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bbc4b209eb229cb50b7c439f17f6faa1442314b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"20f64206_9e8b5b2d","updated":"2022-10-07 14:17:26.000000000","message":"recheck linting fixed","commit_id":"f0cda6577dd1dbbbe51c51213211dce476473d67"}],"ansible/roles/cinder/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fff92d8db7f77e5faeca86cb1344ed34ea0e73f6","unresolved":true,"context_lines":[{"line_number":154,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":155,"context_line":"  - \"/run/:/run/:shared\""},{"line_number":156,"context_line":"  - \"cinder:/var/lib/cinder\""},{"line_number":157,"context_line":"  - \"{% if enable_iscsid | bool %}iscsi_info:/etc/iscsi{% endif %}\""},{"line_number":158,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":159,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/cinder/cinder:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/cinder\u0027 if cinder_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":160,"context_line":"cinder_scheduler_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f579c066_d42c4e81","side":"PARENT","line":157,"updated":"2021-06-20 18:30:12.000000000","message":"note-to-self: undo this","commit_id":"5665d5e6194a63f42043b413943dee00314c1ff0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"42bfcacd99d3269ee6868e5a6a635108acca3585","unresolved":false,"context_lines":[{"line_number":154,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":155,"context_line":"  - \"/run/:/run/:shared\""},{"line_number":156,"context_line":"  - \"cinder:/var/lib/cinder\""},{"line_number":157,"context_line":"  - \"{% if enable_iscsid | bool %}iscsi_info:/etc/iscsi{% endif %}\""},{"line_number":158,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":159,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/cinder/cinder:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/cinder\u0027 if cinder_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":160,"context_line":"cinder_scheduler_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d39d8170_ca4602c3","side":"PARENT","line":157,"in_reply_to":"f579c066_d42c4e81","updated":"2022-09-26 11:56:40.000000000","message":"Done","commit_id":"5665d5e6194a63f42043b413943dee00314c1ff0"}]}