)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4634c5a65e1497eacae7c43190635174cfda598b","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Swift role is still using the old format today. and the refactor"},{"line_number":10,"context_line":"task was delayed for several cycles."},{"line_number":11,"context_line":"This commit refactors the swift role and keeps the privious logic."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1842637"},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/722798"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"d3f01f4f_2d301a0b","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":2},"updated":"2024-06-10 10:58:56.000000000","message":"typo: previous","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b3c2581d2983b14a10475cff6f73c8170a8b306a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Swift role is still using the old format today. and the refactor"},{"line_number":10,"context_line":"task was delayed for several cycles."},{"line_number":11,"context_line":"This commit refactors the swift role and keeps the privious logic."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1842637"},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/722798"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"ce231291_182615d3","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":2},"in_reply_to":"d3f01f4f_2d301a0b","updated":"2024-06-10 12:07:12.000000000","message":"Acknowledged","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"43715160a624bb170cb106bf2c30b20f103de522","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ae254ab5_5eaa9eea","updated":"2021-10-13 07:13:05.000000000","message":"check experimental\n\n","commit_id":"c8efcc675010e5a2fcb593c38031323e39ae01e9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c0078634c12a0fd3f13ca8e0454b266814963932","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"af4bfb54_ba75498e","updated":"2022-03-30 14:40:36.000000000","message":"check experimental\n\n","commit_id":"c8efcc675010e5a2fcb593c38031323e39ae01e9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"1b746736b0f7281b94db9aa0df7b89ff786ca7de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"13d98b5b_a496b4c5","updated":"2021-10-12 16:04:56.000000000","message":"hi, @mark, thanks for your review","commit_id":"c8efcc675010e5a2fcb593c38031323e39ae01e9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"2f022003017ea072c3571f4893c61bfcd07b4af0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"cbdd2fe1_b34f6643","updated":"2021-10-13 05:38:14.000000000","message":"recheck","commit_id":"c8efcc675010e5a2fcb593c38031323e39ae01e9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"8f773fb612b7ec0b004ecb16e74fba0a13917ce8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f8dd4c08_3d45c76d","updated":"2021-10-13 05:38:41.000000000","message":"recheck","commit_id":"c8efcc675010e5a2fcb593c38031323e39ae01e9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"37845d6939876d323faca01d6259880e363c757b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6124d773_02ff7d2f","in_reply_to":"ae254ab5_5eaa9eea","updated":"2024-07-16 15:53:30.000000000","message":"Done","commit_id":"c8efcc675010e5a2fcb593c38031323e39ae01e9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"666f38a018476983303f405d66315ec95fcb29ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ddc0fe47_6da1a852","updated":"2023-11-21 09:37:26.000000000","message":"check experimental","commit_id":"d4ac39e51721abbdac3af5b7b09674d91b0c6b28"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"7bd8dc02ef6bca515e783b06eae7da5829c88ebf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"db80171d_235ef165","updated":"2024-05-10 09:10:08.000000000","message":"Hi, I am very interested in this patchet, since I need it to move ahead with of my changes I would like to introduce to kolla-ansible. Would you be okay, if contributed to your work and solved some conflicts, etc. ?","commit_id":"2648e201c6f620bd54508c7859b284cb25ae01ae"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"2602239555b511712350179a2904565df65b1656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"039b935c_20ed3f77","updated":"2023-11-22 07:43:43.000000000","message":"ready for review","commit_id":"2648e201c6f620bd54508c7859b284cb25ae01ae"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"52add79e08e724c973557cdddb1006b9d419f1b6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e129123c_4feb167c","in_reply_to":"db80171d_235ef165","updated":"2024-05-10 14:00:29.000000000","message":"No problem. i will update it soon thanks","commit_id":"2648e201c6f620bd54508c7859b284cb25ae01ae"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"b608f63fdc73c2902f3094a1753b6dcb28b3de1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"cbff7398_bf9299b8","in_reply_to":"e129123c_4feb167c","updated":"2024-05-21 08:20:58.000000000","message":"Done","commit_id":"2648e201c6f620bd54508c7859b284cb25ae01ae"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3212b3096a1a07312bb639ab9b02c0cbfa637f55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"f85c77a9_7c45ab9a","updated":"2024-05-15 10:15:45.000000000","message":"hi, thanks for the review. will update it soon","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"df0860169e2feecb0048a2977ee9f9ae7de1da18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3c7281f0_c366f175","updated":"2024-05-15 14:44:24.000000000","message":"Hi Roman: please help to review again. thanks","commit_id":"c3eb6cf3971b1033329ad1d498f1efe5ffe96932"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3c06e5b9e4d6bce890929fadaf5992e9954c74f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"5b87f598_35e2b2dc","updated":"2024-05-17 02:11:52.000000000","message":"Thanks for the careful review. I will update it soon","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"881485c6e03cee6529d25fece86b4c91d49290f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"e81bdcb9_27642827","updated":"2024-05-20 13:52:10.000000000","message":"Hello roman, please help to review this again. I\u0027ve updated the hint you mentioned except the implementing of the `healthcheck_curl`, It seems like there is no better way to hit the swift endpoint at present(unless i misunderstood you). therefore, I remain the usage of `healthcheck_listen` and add health check for more service.","commit_id":"5acd92283d23db7a44655e3a82724c75565742fe"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"ea960c68a43e6c11d82102082c6a77df1a14333f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"7dbf3004_7f8725ad","updated":"2024-05-21 02:38:37.000000000","message":"recheck POST_FAILURE","commit_id":"5acd92283d23db7a44655e3a82724c75565742fe"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"b608f63fdc73c2902f3094a1753b6dcb28b3de1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"8ad0024c_448b2c42","updated":"2024-05-21 08:20:58.000000000","message":"Hello Wu. Thank you for you work on this patch. At this point, it looks good to me, so I\u0027ll leave it to the core reviewers to give us their final opinions. :)","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"c2187c76939dfa1c286f81ca00a9bc6d2c22cf10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"6ae651f0_12464e65","updated":"2024-06-03 10:58:43.000000000","message":"I also found this bug, which we might need to fix to make sure all tests pass. Not sure which containers should actually have the volume, but account, container and object services have ´´´recon_cache_path´´´ in config file (when enabled).\n\nhttps://bugs.launchpad.net/kolla-ansible/+bug/1941611","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"68280069186c0b0eaf5d9ce6434126ee3dea706d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"fdb2d4fb_3b415205","updated":"2024-05-22 13:45:42.000000000","message":"I\u0027ll review in depht later, but may I ask already to maybe add some tests to this?\nparts of swift where seriously broken because of our lack of tests.\n\nI fear such a large refactoring might introduce more error which our CI doesn\u0027t catch at the moment.\n\nSee here what was broken: https://review.opendev.org/c/openstack/kolla-ansible/+/914965","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"5d728d2633020837b415df8581a2ecd1a0056b36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"33fcec23_4cfd7e71","updated":"2024-05-23 06:30:01.000000000","message":"check experimental","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"07160d04e65af3b38e58d07d44b4daa40303095c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"c2172ec4_95ff9861","updated":"2024-05-23 03:06:00.000000000","message":"recheck","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"fbc3972c1206d1e5a07048eba99250f252edf80a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"5402675a_645b4fc5","updated":"2024-05-21 07:08:29.000000000","message":"recheck most likely a problem with docker daemon","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b3c2581d2983b14a10475cff6f73c8170a8b306a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"bdb2dc39_7b6687d9","in_reply_to":"6ae651f0_12464e65","updated":"2024-06-10 12:07:12.000000000","message":"thanks for the review. I will take a look at the bug.","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"ccef42dabf3ab3c16b14468e7f4c27b4a724ec5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"c1ac978b_a6327ca7","in_reply_to":"8ad0024c_448b2c42","updated":"2024-05-21 12:01:20.000000000","message":"ok, thanks for the careful review. Let\u0027s wait for core reviewers vote.","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dd50af992561a3d08586d944d700e1462b17c247","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b9a34c3a_59c4ec20","in_reply_to":"bcdc8b5b_967f12b1","updated":"2024-07-18 08:13:20.000000000","message":"Yes I know about those. To put it more blunt maybe: I don\u0027t think these are sufficient.\n\nIt\u0027s debatable of course if we can change this in this changeset.","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"1802799c5621fb00c656756cbfc765f95d50dc96","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"bcdc8b5b_967f12b1","in_reply_to":"fdb2d4fb_3b415205","updated":"2024-05-23 03:05:23.000000000","message":"Hi, we\u0027ve already had swift tests named \"kolla-ansible-rocky9|ubuntu-swift\" which are used to test swift deployment.\nAdditionally, we also had swift tests for upgrade operation in experimental pipeline.","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"91b0bd031ac1c2a5aa9d5178921d5b8b0fb64a92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"22170302_8c72fa9b","updated":"2024-07-16 12:51:35.000000000","message":"check experimental","commit_id":"e261640c19b3df2ae1e5362fb71c8fc65af02dfa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2c9f607a975275e4a4ab1c1a93eb18c9a13ab4a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"99d5f294_c9c22be1","updated":"2024-07-30 16:20:13.000000000","message":"overall LGTM, I reviewed this multiple times, but I still fear I overlooked something due to the huge diff.\n\nSo I would still like to see the swift tests being expanded to get more confidence when merging this, but I also want to hear other opinions on this topic, especially from people who use swift on a daily basis, as I\u0027m mostly exposed to S3-like APIs via ceph-rgw instead of swift.","commit_id":"e261640c19b3df2ae1e5362fb71c8fc65af02dfa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"37845d6939876d323faca01d6259880e363c757b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"d02fdca4_f7e2253c","updated":"2024-07-16 15:53:30.000000000","message":"please address the old open comments in any form (e.g. mark them done if they are no longer relevant).\n\nLGTM but won\u0027t +1 a change with that many open comments.","commit_id":"e261640c19b3df2ae1e5362fb71c8fc65af02dfa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dd50af992561a3d08586d944d700e1462b17c247","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":29,"id":"c7d7ce63_645d72a8","updated":"2024-07-18 08:13:20.000000000","message":"so, I think the code LGTM, but I don\u0027t personally use swift.\nRegardless I won\u0027t +1 this with this amount of unaddressed open comments, so please respond to the open comments in any form.\n\nI would also like to hear more opinions if we maybe should mandate additional tests for the swift role with a large change like this?\n\nThanks","commit_id":"e261640c19b3df2ae1e5362fb71c8fc65af02dfa"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"78215a77163085970d4641c8a5237db03287f9b4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":29,"id":"54c14f5a_e61727ae","updated":"2024-07-31 12:15:28.000000000","message":"there need minimal Swift service tests on CI","commit_id":"e261640c19b3df2ae1e5362fb71c8fc65af02dfa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2c9f607a975275e4a4ab1c1a93eb18c9a13ab4a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"17b12634_8c3d6a53","in_reply_to":"29009250_23d203b9","updated":"2024-07-30 16:20:13.000000000","message":"Done","commit_id":"e261640c19b3df2ae1e5362fb71c8fc65af02dfa"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4a028fb261cb3f66e26922079b11c40bd35856d2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":29,"id":"29009250_23d203b9","in_reply_to":"c7d7ce63_645d72a8","updated":"2024-07-19 05:04:41.000000000","message":"Thanks for the review. I\u0027ve respond the open comment. \nThe open comments were discussed about the previous upgrade logic. and now it\u0027s done by the new logic.","commit_id":"e261640c19b3df2ae1e5362fb71c8fc65af02dfa"}],"ansible/roles/swift/defaults/main.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":196,"context_line":"  - \"{{ node_config_directory }}/swift-rsyncd/:{{ container_config_directory }}/:ro\""},{"line_number":197,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":198,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":199,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":200,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":201,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":202,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"e0c3d3e2_a111eda2","line":199,"updated":"2021-08-23 15:34:47.000000000","message":"Kolla-ansible not using ansible_os_family anymore - Use ansible_facts.os_family","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"a875608dfe5e2b7c4e875a270c170ce66b30887e","unresolved":false,"context_lines":[{"line_number":196,"context_line":"  - \"{{ node_config_directory }}/swift-rsyncd/:{{ container_config_directory }}/:ro\""},{"line_number":197,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":198,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":199,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":200,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":201,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":202,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"919ab7eb_e1999aae","line":199,"in_reply_to":"e0c3d3e2_a111eda2","updated":"2021-08-24 01:24:59.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":205,"context_line":"  - \"{{ node_config_directory }}/swift-account-server/:{{ container_config_directory }}/:ro\""},{"line_number":206,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":207,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":208,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":209,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":210,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":211,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"81ba3308_95c8765d","line":208,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":205,"context_line":"  - \"{{ node_config_directory }}/swift-account-server/:{{ container_config_directory }}/:ro\""},{"line_number":206,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":207,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":208,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":209,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":210,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":211,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dfe87207_923e41e1","line":208,"in_reply_to":"81ba3308_95c8765d","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":215,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":216,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":217,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":218,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":219,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":220,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":221,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"604b8e18_6f8d6eb9","line":218,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":215,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":216,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":217,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":218,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":219,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":220,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":221,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3446db51_61fadebf","line":218,"in_reply_to":"604b8e18_6f8d6eb9","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":224,"context_line":"  - \"{{ node_config_directory }}/swift-account-replication-server/:{{ container_config_directory }}/:ro\""},{"line_number":225,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":226,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":227,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":228,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":229,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":230,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f8b7ebc_9de27a3e","line":227,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":224,"context_line":"  - \"{{ node_config_directory }}/swift-account-replication-server/:{{ container_config_directory }}/:ro\""},{"line_number":225,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":226,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":227,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":228,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":229,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":230,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ae3deff6_6d04f357","line":227,"in_reply_to":"7f8b7ebc_9de27a3e","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":234,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":235,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":236,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":237,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":238,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":239,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":240,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7d5901fd_e55d94e6","line":237,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":234,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":235,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":236,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":237,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":238,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":239,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":240,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fa13f67a_df0b9afe","line":237,"in_reply_to":"7d5901fd_e55d94e6","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":243,"context_line":"  - \"{{ node_config_directory }}/swift-account-reaper/:{{ container_config_directory }}/:ro\""},{"line_number":244,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":245,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":246,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":247,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":248,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":249,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"c2f2bfd1_1610bede","line":246,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":243,"context_line":"  - \"{{ node_config_directory }}/swift-account-reaper/:{{ container_config_directory }}/:ro\""},{"line_number":244,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":245,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":246,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":247,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":248,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":249,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f098e301_160c5607","line":246,"in_reply_to":"c2f2bfd1_1610bede","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":252,"context_line":"  - \"{{ node_config_directory }}/swift-container-server/:{{ container_config_directory }}/:ro\""},{"line_number":253,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":254,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":255,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":256,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":257,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":258,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dc9503dd_2b8f2cab","line":255,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":252,"context_line":"  - \"{{ node_config_directory }}/swift-container-server/:{{ container_config_directory }}/:ro\""},{"line_number":253,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":254,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":255,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":256,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":257,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":258,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5d14f40d_d9376a41","line":255,"in_reply_to":"dc9503dd_2b8f2cab","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":262,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":263,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":264,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":265,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":266,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":267,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":268,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8fad8f5d_3f85c03f","line":265,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":262,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":263,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":264,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":265,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":266,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":267,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":268,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f368f16_805e844d","line":265,"in_reply_to":"8fad8f5d_3f85c03f","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":271,"context_line":"  - \"{{ node_config_directory }}/swift-container-replication-server/:{{ container_config_directory }}/:ro\""},{"line_number":272,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":273,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":274,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":275,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":276,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":277,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"36719b95_687f47ec","line":274,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":271,"context_line":"  - \"{{ node_config_directory }}/swift-container-replication-server/:{{ container_config_directory }}/:ro\""},{"line_number":272,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":273,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":274,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":275,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":276,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":277,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ede1d059_2e79ec70","line":274,"in_reply_to":"36719b95_687f47ec","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":281,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":282,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":283,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":284,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":285,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":286,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":287,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8b2f22b3_0bc25bda","line":284,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":281,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":282,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":283,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":284,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":285,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":286,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":287,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"545887d5_6e28412d","line":284,"in_reply_to":"8b2f22b3_0bc25bda","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":291,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":292,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":293,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":294,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":295,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":296,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":297,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"48d36241_a6974c44","line":294,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":291,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":292,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":293,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":294,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":295,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":296,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":297,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4d4bbdd7_ef20ad88","line":294,"in_reply_to":"48d36241_a6974c44","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":301,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":302,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":303,"context_line":"  - \"swift_recon_cache:/var/cache/swift:ro\""},{"line_number":304,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":305,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":306,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":307,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"35122c02_d6d10190","line":304,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":301,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":302,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":303,"context_line":"  - \"swift_recon_cache:/var/cache/swift:ro\""},{"line_number":304,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":305,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":306,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":307,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5bdce37e_a15773ef","line":304,"in_reply_to":"35122c02_d6d10190","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":311,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":312,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":313,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":314,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":315,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":316,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":317,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"18db6b14_a4bda937","line":314,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":311,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":312,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":313,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":314,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":315,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":316,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":317,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"73124430_8a9cb61d","line":314,"in_reply_to":"18db6b14_a4bda937","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":320,"context_line":"  - \"{{ node_config_directory }}/swift-object-replication-server/:{{ container_config_directory }}/:ro\""},{"line_number":321,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":322,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":323,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":324,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":325,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":326,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d488d80e_72add017","line":323,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":320,"context_line":"  - \"{{ node_config_directory }}/swift-object-replication-server/:{{ container_config_directory }}/:ro\""},{"line_number":321,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":322,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":323,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":324,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":325,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":326,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f0273561_82f2acb3","line":323,"in_reply_to":"d488d80e_72add017","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":330,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":331,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":332,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":333,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":334,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":335,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":336,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7be00185_78de53fc","line":333,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":330,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":331,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":332,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":333,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":334,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":335,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":336,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"79df7152_1f0ec706","line":333,"in_reply_to":"7be00185_78de53fc","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":340,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":341,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":342,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":343,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":344,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":345,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":346,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7828921d_7fe915d7","line":343,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":340,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":341,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":342,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":343,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":344,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":345,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":346,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ea8e0824_eabd7f66","line":343,"in_reply_to":"7828921d_7fe915d7","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":350,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":351,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":352,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":353,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":354,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":355,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":356,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b8462f9b_8ab02155","line":353,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":350,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":351,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":352,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":353,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":354,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":355,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":356,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0e909706_9c1e6fac","line":353,"in_reply_to":"b8462f9b_8ab02155","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b08a881cbdca8704a25d04574009f3375f2d0ab1","unresolved":true,"context_lines":[{"line_number":358,"context_line":"  - \"{{ node_config_directory }}/swift/:/var/lib/kolla/swift/:ro\""},{"line_number":359,"context_line":"  - \"{{ node_config_directory }}/swift-proxy-server/:{{ container_config_directory }}/:ro\""},{"line_number":360,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":361,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":362,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":363,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":364,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dec4fb28_4902b793","line":361,"updated":"2021-08-23 15:34:47.000000000","message":"ditto","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":358,"context_line":"  - \"{{ node_config_directory }}/swift/:/var/lib/kolla/swift/:ro\""},{"line_number":359,"context_line":"  - \"{{ node_config_directory }}/swift-proxy-server/:{{ container_config_directory }}/:ro\""},{"line_number":360,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":361,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":362,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":363,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":364,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"742fa66d_c333f245","line":361,"in_reply_to":"dec4fb28_4902b793","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"48ce8adc7c2576613b592452cd1c09b143e411e1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-account-server\u0027] }}\""},{"line_number":40,"context_line":"    enabled: true"},{"line_number":41,"context_line":"    image: \"{{ swift_account_image_full }}\""},{"line_number":42,"context_line":"    volumes: \"{{ swift_account_server_default_volumes + swift_rsyncd_extra_volumes }}\""},{"line_number":43,"context_line":"    dimensions: \"{{ swift_account_server_dimensions }}\""},{"line_number":44,"context_line":"  swift-account-auditor:"},{"line_number":45,"context_line":"    container_name: swift_account_auditor"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a90186ef_c345a68e","line":42,"range":{"start_line":42,"start_character":62,"end_line":42,"end_character":68},"updated":"2021-09-15 16:47:37.000000000","message":"account_server","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-account-server\u0027] }}\""},{"line_number":40,"context_line":"    enabled: true"},{"line_number":41,"context_line":"    image: \"{{ swift_account_image_full }}\""},{"line_number":42,"context_line":"    volumes: \"{{ swift_account_server_default_volumes + swift_rsyncd_extra_volumes }}\""},{"line_number":43,"context_line":"    dimensions: \"{{ swift_account_server_dimensions }}\""},{"line_number":44,"context_line":"  swift-account-auditor:"},{"line_number":45,"context_line":"    container_name: swift_account_auditor"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"42c88a35_70fe55f6","line":42,"range":{"start_line":42,"start_character":62,"end_line":42,"end_character":68},"in_reply_to":"a90186ef_c345a68e","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    enabled: \"{{ swift_has_replication_network }}\""},{"line_number":55,"context_line":"    image: \"{{ swift_account_image_full }}\""},{"line_number":56,"context_line":"    volumes: \"{{ swift_account_replication_server_default_volumes + swift_account_replication_server_extra_volumes }}\""},{"line_number":57,"context_line":"    dimensions: \"{{ swift_account_replication_server_dimensions }}\""},{"line_number":58,"context_line":"  swift-account-replicator:"},{"line_number":59,"context_line":"    container_name: swift_account_replicator"},{"line_number":60,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-account-server\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3c7e01ac_2e30e582","line":57,"updated":"2021-09-15 16:47:37.000000000","message":"Missing:\n\n    environment:\n      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\"","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    enabled: \"{{ swift_has_replication_network }}\""},{"line_number":55,"context_line":"    image: \"{{ swift_account_image_full }}\""},{"line_number":56,"context_line":"    volumes: \"{{ swift_account_replication_server_default_volumes + swift_account_replication_server_extra_volumes }}\""},{"line_number":57,"context_line":"    dimensions: \"{{ swift_account_replication_server_dimensions }}\""},{"line_number":58,"context_line":"  swift-account-replicator:"},{"line_number":59,"context_line":"    container_name: swift_account_replicator"},{"line_number":60,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-account-server\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"b8934cbc_bb6f1c9c","line":57,"in_reply_to":"3c7e01ac_2e30e582","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    enabled: true"},{"line_number":62,"context_line":"    image: \"{{ swift_account_image_full }}\""},{"line_number":63,"context_line":"    volumes: \"{{ swift_account_replicator_default_volumes + swift_account_replicator_extra_volumes }}\""},{"line_number":64,"context_line":"    dimensions: \"{{ swift_account_replicator_dimensions }}\""},{"line_number":65,"context_line":"  swift-account-reaper:"},{"line_number":66,"context_line":"    container_name: swift_account_reaper"},{"line_number":67,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-account-server\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a05b7b57_91b71dbb","line":64,"updated":"2021-09-15 16:47:37.000000000","message":"Missing:\n\n    environment:\n      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\"","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    enabled: true"},{"line_number":62,"context_line":"    image: \"{{ swift_account_image_full }}\""},{"line_number":63,"context_line":"    volumes: \"{{ swift_account_replicator_default_volumes + swift_account_replicator_extra_volumes }}\""},{"line_number":64,"context_line":"    dimensions: \"{{ swift_account_replicator_dimensions }}\""},{"line_number":65,"context_line":"  swift-account-reaper:"},{"line_number":66,"context_line":"    container_name: swift_account_reaper"},{"line_number":67,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-account-server\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7a363f57_05d13afd","line":64,"in_reply_to":"a05b7b57_91b71dbb","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":89,"context_line":"    enabled: \"{{ swift_has_replication_network }}\""},{"line_number":90,"context_line":"    image: \"{{ swift_container_image_full }}\""},{"line_number":91,"context_line":"    volumes: \"{{ swift_container_replication_server_default_volumes + swift_container_replication_server_extra_volumes }}\""},{"line_number":92,"context_line":"    dimensions: \"{{ swift_container_replication_server_dimensions }}\""},{"line_number":93,"context_line":"  swift-container-replicator:"},{"line_number":94,"context_line":"    container_name: swift_container_replicator"},{"line_number":95,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-container-server\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6b92189b_217e1dec","line":92,"updated":"2021-09-15 16:47:37.000000000","message":"Missing:\n\n    environment:\n      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\"","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    enabled: \"{{ swift_has_replication_network }}\""},{"line_number":90,"context_line":"    image: \"{{ swift_container_image_full }}\""},{"line_number":91,"context_line":"    volumes: \"{{ swift_container_replication_server_default_volumes + swift_container_replication_server_extra_volumes }}\""},{"line_number":92,"context_line":"    dimensions: \"{{ swift_container_replication_server_dimensions }}\""},{"line_number":93,"context_line":"  swift-container-replicator:"},{"line_number":94,"context_line":"    container_name: swift_container_replicator"},{"line_number":95,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-container-server\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"83b817b3_387ae774","line":92,"in_reply_to":"6b92189b_217e1dec","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    enabled: true"},{"line_number":97,"context_line":"    image: \"{{ swift_container_image_full }}\""},{"line_number":98,"context_line":"    volumes: \"{{ swift_container_replicator_default_volumes + swift_container_replicator_extra_volumes }}\""},{"line_number":99,"context_line":"    dimensions: \"{{ swift_container_replicator_dimensions }}\""},{"line_number":100,"context_line":"  swift-container-updater:"},{"line_number":101,"context_line":"    container_name: swift_container_updater"},{"line_number":102,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-container-server\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c8fef8e4_bb62624a","line":99,"updated":"2021-09-15 16:47:37.000000000","message":"Missing:\n\n    environment:\n      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\"","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    enabled: true"},{"line_number":97,"context_line":"    image: \"{{ swift_container_image_full }}\""},{"line_number":98,"context_line":"    volumes: \"{{ swift_container_replicator_default_volumes + swift_container_replicator_extra_volumes }}\""},{"line_number":99,"context_line":"    dimensions: \"{{ swift_container_replicator_dimensions }}\""},{"line_number":100,"context_line":"  swift-container-updater:"},{"line_number":101,"context_line":"    container_name: swift_container_updater"},{"line_number":102,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-container-server\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"06bf6e5d_cd3b33f5","line":99,"in_reply_to":"c8fef8e4_bb62624a","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":124,"context_line":"    enabled: \"{{ swift_has_replication_network }}\""},{"line_number":125,"context_line":"    image: \"{{ swift_object_image_full }}\""},{"line_number":126,"context_line":"    volumes: \"{{ swift_object_replication_server_default_volumes + swift_object_replication_server_extra_volumes }}\""},{"line_number":127,"context_line":"    dimensions: \"{{ swift_object_replication_server_dimensions }}\""},{"line_number":128,"context_line":"  swift-object-replicator:"},{"line_number":129,"context_line":"    container_name: swift_object_replicator"},{"line_number":130,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-object-server\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"04eb3da5_2066fcfa","line":127,"updated":"2021-09-15 16:47:37.000000000","message":"Missing:\n\n    environment:\n      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\"","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    enabled: \"{{ swift_has_replication_network }}\""},{"line_number":125,"context_line":"    image: \"{{ swift_object_image_full }}\""},{"line_number":126,"context_line":"    volumes: \"{{ swift_object_replication_server_default_volumes + swift_object_replication_server_extra_volumes }}\""},{"line_number":127,"context_line":"    dimensions: \"{{ swift_object_replication_server_dimensions }}\""},{"line_number":128,"context_line":"  swift-object-replicator:"},{"line_number":129,"context_line":"    container_name: swift_object_replicator"},{"line_number":130,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-object-server\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"211f1b21_cd082d5d","line":127,"in_reply_to":"04eb3da5_2066fcfa","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    enabled: true"},{"line_number":132,"context_line":"    image: \"{{ swift_object_image_full }}\""},{"line_number":133,"context_line":"    volumes: \"{{ swift_object_replicator_default_volumes + swift_object_replicator_extra_volumes }}\""},{"line_number":134,"context_line":"    dimensions: \"{{ swift_object_replicator_dimensions }}\""},{"line_number":135,"context_line":"  swift-object-updater:"},{"line_number":136,"context_line":"    container_name: swift_object_updater"},{"line_number":137,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-object-server\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"0ba6a5cb_32b32b1a","line":134,"updated":"2021-09-15 16:47:37.000000000","message":"Missing:\n\n    environment:\n      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\"","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    enabled: true"},{"line_number":132,"context_line":"    image: \"{{ swift_object_image_full }}\""},{"line_number":133,"context_line":"    volumes: \"{{ swift_object_replicator_default_volumes + swift_object_replicator_extra_volumes }}\""},{"line_number":134,"context_line":"    dimensions: \"{{ swift_object_replicator_dimensions }}\""},{"line_number":135,"context_line":"  swift-object-updater:"},{"line_number":136,"context_line":"    container_name: swift_object_updater"},{"line_number":137,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-object-server\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"d2cca17d_4a5bfa25","line":134,"in_reply_to":"0ba6a5cb_32b32b1a","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":183,"context_line":"swift_proxy_server_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":184,"context_line":"swift_proxy_server_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":185,"context_line":"swift_proxy_server_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":186,"context_line":"swift_proxy_server_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_listen swift-proxy-server {{ swift_proxy_server_listen_port }}\"]"},{"line_number":187,"context_line":"swift_proxy_server_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":188,"context_line":"swift_proxy_server_healthcheck:"},{"line_number":189,"context_line":"  interval: \"{{ swift_proxy_server_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"b55d04a5_b568dfce","line":186,"range":{"start_line":186,"start_character":38,"end_line":186,"end_character":127},"updated":"2021-09-15 16:47:37.000000000","message":"Hitting the API would be nice, if possible.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fe7069a837db4d2ed67aa4c9375850508d530e05","unresolved":true,"context_lines":[{"line_number":183,"context_line":"swift_proxy_server_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":184,"context_line":"swift_proxy_server_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":185,"context_line":"swift_proxy_server_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":186,"context_line":"swift_proxy_server_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_listen swift-proxy-server {{ swift_proxy_server_listen_port }}\"]"},{"line_number":187,"context_line":"swift_proxy_server_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":188,"context_line":"swift_proxy_server_healthcheck:"},{"line_number":189,"context_line":"  interval: \"{{ swift_proxy_server_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fe66868_761514e9","line":186,"range":{"start_line":186,"start_character":38,"end_line":186,"end_character":127},"in_reply_to":"26419e0e_c24d0f6c","updated":"2024-05-20 11:32:45.000000000","message":"It appears that only the `healthcheck_listen` check is applicable then.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6ec82d54d2e648853aeb4ab9de19c3a17b5fb464","unresolved":true,"context_lines":[{"line_number":183,"context_line":"swift_proxy_server_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":184,"context_line":"swift_proxy_server_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":185,"context_line":"swift_proxy_server_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":186,"context_line":"swift_proxy_server_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_listen swift-proxy-server {{ swift_proxy_server_listen_port }}\"]"},{"line_number":187,"context_line":"swift_proxy_server_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":188,"context_line":"swift_proxy_server_healthcheck:"},{"line_number":189,"context_line":"  interval: \"{{ swift_proxy_server_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"26419e0e_c24d0f6c","line":186,"range":{"start_line":186,"start_character":38,"end_line":186,"end_character":127},"in_reply_to":"37449ad5_74a7df08","updated":"2024-05-17 14:54:00.000000000","message":"I also tried this and the ```/info``` endpoint is returning 200, but only when S3 API is enabled.\n\nI\u0027ve previously raised this as an issue, so maybe we should take a look at it before implementing the healthcheck, since the result of the healthcheck would be dependent on that setting.\n\nhttps://bugs.launchpad.net/kolla-ansible/+bug/2054130\n\n\n```/v1/endpoints``` requires auth.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"fbc3972c1206d1e5a07048eba99250f252edf80a","unresolved":false,"context_lines":[{"line_number":183,"context_line":"swift_proxy_server_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":184,"context_line":"swift_proxy_server_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":185,"context_line":"swift_proxy_server_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":186,"context_line":"swift_proxy_server_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_listen swift-proxy-server {{ swift_proxy_server_listen_port }}\"]"},{"line_number":187,"context_line":"swift_proxy_server_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":188,"context_line":"swift_proxy_server_healthcheck:"},{"line_number":189,"context_line":"  interval: \"{{ swift_proxy_server_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"453dfd84_05144c04","line":186,"range":{"start_line":186,"start_character":38,"end_line":186,"end_character":127},"in_reply_to":"3fe66868_761514e9","updated":"2024-05-21 07:08:29.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":true,"context_lines":[{"line_number":183,"context_line":"swift_proxy_server_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":184,"context_line":"swift_proxy_server_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":185,"context_line":"swift_proxy_server_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":186,"context_line":"swift_proxy_server_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_listen swift-proxy-server {{ swift_proxy_server_listen_port }}\"]"},{"line_number":187,"context_line":"swift_proxy_server_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":188,"context_line":"swift_proxy_server_healthcheck:"},{"line_number":189,"context_line":"  interval: \"{{ swift_proxy_server_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dea2b1c3_6f8fc234","line":186,"range":{"start_line":186,"start_character":38,"end_line":186,"end_character":127},"in_reply_to":"b55d04a5_b568dfce","updated":"2021-10-12 16:00:54.000000000","message":"CURL command return 401 Unauthorized","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":true,"context_lines":[{"line_number":183,"context_line":"swift_proxy_server_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":184,"context_line":"swift_proxy_server_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":185,"context_line":"swift_proxy_server_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":186,"context_line":"swift_proxy_server_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_listen swift-proxy-server {{ swift_proxy_server_listen_port }}\"]"},{"line_number":187,"context_line":"swift_proxy_server_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":188,"context_line":"swift_proxy_server_healthcheck:"},{"line_number":189,"context_line":"  interval: \"{{ swift_proxy_server_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"addd083e_cbc83619","line":186,"range":{"start_line":186,"start_character":38,"end_line":186,"end_character":127},"in_reply_to":"dea2b1c3_6f8fc234","updated":"2024-05-16 15:16:57.000000000","message":"Can we hit ```/info``` or ```/v1/endpoints``` endpoints? According to documentation they should be public.\n\nhttps://docs.openstack.org/api-ref/object-store/#list-activated-capabilities\nhttps://docs.openstack.org/api-ref/object-store/#list-endpoints","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3c06e5b9e4d6bce890929fadaf5992e9954c74f0","unresolved":true,"context_lines":[{"line_number":183,"context_line":"swift_proxy_server_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":184,"context_line":"swift_proxy_server_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":185,"context_line":"swift_proxy_server_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":186,"context_line":"swift_proxy_server_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_listen swift-proxy-server {{ swift_proxy_server_listen_port }}\"]"},{"line_number":187,"context_line":"swift_proxy_server_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":188,"context_line":"swift_proxy_server_healthcheck:"},{"line_number":189,"context_line":"  interval: \"{{ swift_proxy_server_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"37449ad5_74a7df08","line":186,"range":{"start_line":186,"start_character":38,"end_line":186,"end_character":127},"in_reply_to":"dea2b1c3_6f8fc234","updated":"2024-05-17 02:11:52.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":198,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":199,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":200,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":201,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"swift_account_server_default_volumes:"},{"line_number":204,"context_line":"  - \"{{ node_config_directory }}/swift/:/var/lib/kolla/swift/:ro\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1428169c_ed19fbe1","line":201,"range":{"start_line":201,"start_character":0,"end_line":201,"end_character":167},"updated":"2021-09-15 16:47:37.000000000","message":"Not required for rsyncd","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":198,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":199,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":200,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":201,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"swift_account_server_default_volumes:"},{"line_number":204,"context_line":"  - \"{{ node_config_directory }}/swift/:/var/lib/kolla/swift/:ro\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"58ae4ed7_a7790680","line":201,"range":{"start_line":201,"start_character":0,"end_line":201,"end_character":167},"in_reply_to":"1428169c_ed19fbe1","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":214,"context_line":"  - \"{{ node_config_directory }}/swift-account-auditor/:{{ container_config_directory }}/:ro\""},{"line_number":215,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":216,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":217,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":218,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":219,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":220,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"528a264b_d47ccb7e","line":217,"range":{"start_line":217,"start_character":2,"end_line":217,"end_character":40},"updated":"2021-09-15 16:47:37.000000000","message":"nit: move below timezone","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":214,"context_line":"  - \"{{ node_config_directory }}/swift-account-auditor/:{{ container_config_directory }}/:ro\""},{"line_number":215,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":216,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":217,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":218,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":219,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":220,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"e5bc1ec8_68c0981d","line":217,"range":{"start_line":217,"start_character":2,"end_line":217,"end_character":40},"in_reply_to":"528a264b_d47ccb7e","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":233,"context_line":"  - \"{{ node_config_directory }}/swift-account-replicator/:{{ container_config_directory }}/:ro\""},{"line_number":234,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":235,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":236,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":237,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":238,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":239,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5b9a81b9_5e43533f","line":236,"range":{"start_line":236,"start_character":2,"end_line":236,"end_character":40},"updated":"2021-09-15 16:47:37.000000000","message":"ditto","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":233,"context_line":"  - \"{{ node_config_directory }}/swift-account-replicator/:{{ container_config_directory }}/:ro\""},{"line_number":234,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":235,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":236,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":237,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":238,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":239,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c914e0e0_fc7c9df6","line":236,"range":{"start_line":236,"start_character":2,"end_line":236,"end_character":40},"in_reply_to":"5b9a81b9_5e43533f","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":261,"context_line":"  - \"{{ node_config_directory }}/swift-container-auditor/:{{ container_config_directory }}/:ro\""},{"line_number":262,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":263,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":264,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":265,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":266,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":267,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7938016d_1b1f55ee","line":264,"range":{"start_line":264,"start_character":2,"end_line":264,"end_character":40},"updated":"2021-09-15 16:47:37.000000000","message":"ditto","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":261,"context_line":"  - \"{{ node_config_directory }}/swift-container-auditor/:{{ container_config_directory }}/:ro\""},{"line_number":262,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":263,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":264,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":265,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":266,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":267,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7c4c3a3f_81579d52","line":264,"range":{"start_line":264,"start_character":2,"end_line":264,"end_character":40},"in_reply_to":"7938016d_1b1f55ee","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":280,"context_line":"  - \"{{ node_config_directory }}/swift-container-replicator/:{{ container_config_directory }}/:ro\""},{"line_number":281,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":282,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":283,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":284,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":285,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":286,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"eef48f6f_0255c4e8","line":283,"range":{"start_line":283,"start_character":2,"end_line":283,"end_character":40},"updated":"2021-09-15 16:47:37.000000000","message":"ditto","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":280,"context_line":"  - \"{{ node_config_directory }}/swift-container-replicator/:{{ container_config_directory }}/:ro\""},{"line_number":281,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":282,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":283,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":284,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":285,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":286,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa8c801_b93e3f89","line":283,"range":{"start_line":283,"start_character":2,"end_line":283,"end_character":40},"in_reply_to":"eef48f6f_0255c4e8","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":290,"context_line":"  - \"{{ node_config_directory }}/swift-container-updater/:{{ container_config_directory }}/:ro\""},{"line_number":291,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":292,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":293,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":294,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":295,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":296,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ace4024c_429df0f2","line":293,"updated":"2021-09-15 16:47:37.000000000","message":"ditto","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":290,"context_line":"  - \"{{ node_config_directory }}/swift-container-updater/:{{ container_config_directory }}/:ro\""},{"line_number":291,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":292,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":293,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":294,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":295,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":296,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"b0a638ea_700eef4c","line":293,"in_reply_to":"ace4024c_429df0f2","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":300,"context_line":"  - \"{{ node_config_directory }}/swift-object-server/:{{ container_config_directory }}/:ro\""},{"line_number":301,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":302,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":303,"context_line":"  - \"swift_recon_cache:/var/cache/swift:ro\""},{"line_number":304,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":305,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":306,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fb3fb915_04a3476e","line":303,"updated":"2021-09-15 16:47:37.000000000","message":"ditto","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":300,"context_line":"  - \"{{ node_config_directory }}/swift-object-server/:{{ container_config_directory }}/:ro\""},{"line_number":301,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":302,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":303,"context_line":"  - \"swift_recon_cache:/var/cache/swift:ro\""},{"line_number":304,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":305,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":306,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ab7c1ec1_79ab8d06","line":303,"in_reply_to":"fb3fb915_04a3476e","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":310,"context_line":"  - \"{{ node_config_directory }}/swift-object-auditor/:{{ container_config_directory }}/:ro\""},{"line_number":311,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":312,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":313,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":314,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":315,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":316,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3bd80fe6_92d9368d","line":313,"updated":"2021-09-15 16:47:37.000000000","message":"ditto","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":310,"context_line":"  - \"{{ node_config_directory }}/swift-object-auditor/:{{ container_config_directory }}/:ro\""},{"line_number":311,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":312,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":313,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":314,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":315,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":316,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"b0465809_5afc3bbb","line":313,"in_reply_to":"3bd80fe6_92d9368d","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":339,"context_line":"  - \"{{ node_config_directory }}/swift-object-updater/:{{ container_config_directory }}/:ro\""},{"line_number":340,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":341,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":342,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":343,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":344,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":345,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6b57fe76_2cf2ea8a","line":342,"updated":"2021-09-15 16:47:37.000000000","message":"ditto","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":339,"context_line":"  - \"{{ node_config_directory }}/swift-object-updater/:{{ container_config_directory }}/:ro\""},{"line_number":340,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":341,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":342,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":343,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":344,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":345,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6d899b22_0cdd994a","line":342,"in_reply_to":"6b57fe76_2cf2ea8a","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":349,"context_line":"  - \"{{ node_config_directory }}/swift-object-expirer/:{{ container_config_directory }}/:ro\""},{"line_number":350,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":351,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":352,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":353,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":354,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":355,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6b6cadd2_01ae130f","line":352,"updated":"2021-09-15 16:47:37.000000000","message":"ditto","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":349,"context_line":"  - \"{{ node_config_directory }}/swift-object-expirer/:{{ container_config_directory }}/:ro\""},{"line_number":350,"context_line":"  - \"{{ swift_devices_mount_point }}:{{ swift_devices_mount_point }}:shared\""},{"line_number":351,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":352,"context_line":"  - \"swift_recon_cache:/var/cache/swift\""},{"line_number":353,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":354,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":355,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/swift/swift:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/swift\u0027 if swift_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4803ba11_3c09a59c","line":352,"in_reply_to":"6b6cadd2_01ae130f","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    image: \"{{ swift_rsyncd_image_full }}\""},{"line_number":34,"context_line":"    volumes: \"{{ swift_rsyncd_default_volumes + swift_rsyncd_extra_volumes }}\""},{"line_number":35,"context_line":"    dimensions: \"{{ swift_rsyncd_dimensions }}\""},{"line_number":36,"context_line":"  swift-account-server:"},{"line_number":37,"context_line":"    container_name: swift_account_server"},{"line_number":38,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-account-server\u0027] }}\""},{"line_number":39,"context_line":"    enabled: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"52c90a60_05deafef","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":23},"updated":"2024-05-16 15:16:57.000000000","message":"Do you think it would be possible to implement healthchecks for swift-*-server using ``` healthcheck_port ``` or ``` healthcheck_listen ``` ?\n\nhttps://review.opendev.org/c/openstack/kolla/+/676128","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6ec82d54d2e648853aeb4ab9de19c3a17b5fb464","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    image: \"{{ swift_rsyncd_image_full }}\""},{"line_number":34,"context_line":"    volumes: \"{{ swift_rsyncd_default_volumes + swift_rsyncd_extra_volumes }}\""},{"line_number":35,"context_line":"    dimensions: \"{{ swift_rsyncd_dimensions }}\""},{"line_number":36,"context_line":"  swift-account-server:"},{"line_number":37,"context_line":"    container_name: swift_account_server"},{"line_number":38,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-account-server\u0027] }}\""},{"line_number":39,"context_line":"    enabled: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"90586d5e_71e9d81c","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":23},"in_reply_to":"52c90a60_05deafef","updated":"2024-05-17 14:54:00.000000000","message":"I tested these for each of the swift servers and rsync and it looks like it is working:\n\n```\nhealthcheck_listen swift-account-server {{ swift_account_server_port }}\nhealthcheck_listen swift-object-server {{ swift_object_server_port }}\nhealthcheck_listen swift-container-server {{ swift_container_server_port }}\nhealthcheck_listen rsync {{ swift_rsync_port }}\n```","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"fbc3972c1206d1e5a07048eba99250f252edf80a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    image: \"{{ swift_rsyncd_image_full }}\""},{"line_number":34,"context_line":"    volumes: \"{{ swift_rsyncd_default_volumes + swift_rsyncd_extra_volumes }}\""},{"line_number":35,"context_line":"    dimensions: \"{{ swift_rsyncd_dimensions }}\""},{"line_number":36,"context_line":"  swift-account-server:"},{"line_number":37,"context_line":"    container_name: swift_account_server"},{"line_number":38,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027swift-account-server\u0027] }}\""},{"line_number":39,"context_line":"    enabled: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3d9b13fa_92acf1cb","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":23},"in_reply_to":"90586d5e_71e9d81c","updated":"2024-05-21 07:08:29.000000000","message":"Done","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4634c5a65e1497eacae7c43190635174cfda598b","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    image: \"{{ swift_account_image_full }}\""},{"line_number":57,"context_line":"    volumes: \"{{ swift_account_replication_server_default_volumes + swift_account_replication_server_extra_volumes }}\""},{"line_number":58,"context_line":"    environment:"},{"line_number":59,"context_line":"      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\""},{"line_number":60,"context_line":"    dimensions: \"{{ swift_account_replication_server_dimensions }}\""},{"line_number":61,"context_line":"  swift-account-replicator:"},{"line_number":62,"context_line":"    container_name: swift_account_replicator"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"f94991fc_6fbc7ef2","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":2},"updated":"2024-06-10 10:58:56.000000000","message":"not sure if it\u0027s a good idea to supply this value this way (via env).","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"04023f8d4825c5b12808e4f28bd07fd822d57617","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    image: \"{{ swift_account_image_full }}\""},{"line_number":57,"context_line":"    volumes: \"{{ swift_account_replication_server_default_volumes + swift_account_replication_server_extra_volumes }}\""},{"line_number":58,"context_line":"    environment:"},{"line_number":59,"context_line":"      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\""},{"line_number":60,"context_line":"    dimensions: \"{{ swift_account_replication_server_dimensions }}\""},{"line_number":61,"context_line":"  swift-account-replicator:"},{"line_number":62,"context_line":"    container_name: swift_account_replicator"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"6e398d69_d3fe62bb","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":2},"in_reply_to":"2e82e201_75ebcc80","updated":"2024-07-10 09:12:36.000000000","message":"I took a look at swift docs and it looks like there is no other way to influence the rsync client port other then this env variable.\n\nMentions of \"replication_port\" relating to rtsync were promising in the docs, but I don\u0027t think that has to do anything with rsync directly.","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"907fd0b9ecac152260a263400231dcb0b2d5d49c","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    image: \"{{ swift_account_image_full }}\""},{"line_number":57,"context_line":"    volumes: \"{{ swift_account_replication_server_default_volumes + swift_account_replication_server_extra_volumes }}\""},{"line_number":58,"context_line":"    environment:"},{"line_number":59,"context_line":"      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\""},{"line_number":60,"context_line":"    dimensions: \"{{ swift_account_replication_server_dimensions }}\""},{"line_number":61,"context_line":"  swift-account-replicator:"},{"line_number":62,"context_line":"    container_name: swift_account_replicator"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"6f098058_90167c5c","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":2},"in_reply_to":"2e82e201_75ebcc80","updated":"2024-07-09 08:23:56.000000000","message":"currently, I think we should remain this usage in this commit. maybe we need to remove these environment in future when we have enough reason.","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dc343ff16baace276fff7c543116fc31fa6204d8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    image: \"{{ swift_account_image_full }}\""},{"line_number":57,"context_line":"    volumes: \"{{ swift_account_replication_server_default_volumes + swift_account_replication_server_extra_volumes }}\""},{"line_number":58,"context_line":"    environment:"},{"line_number":59,"context_line":"      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\""},{"line_number":60,"context_line":"    dimensions: \"{{ swift_account_replication_server_dimensions }}\""},{"line_number":61,"context_line":"  swift-account-replicator:"},{"line_number":62,"context_line":"    container_name: swift_account_replicator"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3424db6c_72892913","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":2},"in_reply_to":"6e398d69_d3fe62bb","updated":"2024-07-10 14:44:26.000000000","message":"Acknowledged","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"7cf2a387082a666402bc24cd04cf9e600dd3a81c","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    image: \"{{ swift_account_image_full }}\""},{"line_number":57,"context_line":"    volumes: \"{{ swift_account_replication_server_default_volumes + swift_account_replication_server_extra_volumes }}\""},{"line_number":58,"context_line":"    environment:"},{"line_number":59,"context_line":"      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\""},{"line_number":60,"context_line":"    dimensions: \"{{ swift_account_replication_server_dimensions }}\""},{"line_number":61,"context_line":"  swift-account-replicator:"},{"line_number":62,"context_line":"    container_name: swift_account_replicator"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3af4a861_af8995db","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":2},"in_reply_to":"6e398d69_d3fe62bb","updated":"2024-07-10 14:38:38.000000000","message":"Thanks for the review. I am sorry that i can\u0027t recall something related to the \"replication_port\".  Do you mean the \"swift_rsyncd_healthcheck_test\" ?","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b3c2581d2983b14a10475cff6f73c8170a8b306a","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    image: \"{{ swift_account_image_full }}\""},{"line_number":57,"context_line":"    volumes: \"{{ swift_account_replication_server_default_volumes + swift_account_replication_server_extra_volumes }}\""},{"line_number":58,"context_line":"    environment:"},{"line_number":59,"context_line":"      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\""},{"line_number":60,"context_line":"    dimensions: \"{{ swift_account_replication_server_dimensions }}\""},{"line_number":61,"context_line":"  swift-account-replicator:"},{"line_number":62,"context_line":"    container_name: swift_account_replicator"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"2e82e201_75ebcc80","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":2},"in_reply_to":"f94991fc_6fbc7ef2","updated":"2024-06-10 12:07:12.000000000","message":"this environment was copied from the previous code.","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"}],"ansible/roles/swift/handlers/main.yml":[{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"74126eb3b306555e3411fa226876ab63e38fdebf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-proxy-server container"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"swift-proxy-server\""},{"line_number":5,"context_line":"    service: \"{{ swift_services[service_name] }}\""},{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  kolla_container:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"2e0b02b8_43fdc700","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":38},"updated":"2024-05-13 07:08:03.000000000","message":"```service_name``` doesnt look like it is used anywhere else in the task, perhaps it cant be directly placed into the ``` service ``` definition?","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3212b3096a1a07312bb639ab9b02c0cbfa637f55","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-proxy-server container"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"swift-proxy-server\""},{"line_number":5,"context_line":"    service: \"{{ swift_services[service_name] }}\""},{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  kolla_container:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"68713514_b22ff838","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":38},"in_reply_to":"2e0b02b8_43fdc700","updated":"2024-05-15 10:15:45.000000000","message":"service_name was used in the next line. \n``{{ swift_services[service_name] }}``","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Restart swift-proxy-server container"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"swift-proxy-server\""},{"line_number":5,"context_line":"    service: \"{{ swift_services[service_name] }}\""},{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  kolla_container:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5aae4d94_09fb59ea","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":38},"in_reply_to":"68713514_b22ff838","updated":"2024-05-16 15:16:57.000000000","message":"Acknowledged","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"74126eb3b306555e3411fa226876ab63e38fdebf","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":10,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":11,"context_line":"    image: \"{{ service.image }}\""},{"line_number":12,"context_line":"    volumes: \"{{ service.volumes | reject(\u0027equalto\u0027, \u0027\u0027) | list }}\""},{"line_number":13,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":14,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":15,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"e0823ee5_db2ed43a","line":12,"range":{"start_line":12,"start_character":35,"end_line":12,"end_character":63},"updated":"2024-05-13 07:08:03.000000000","message":"Is this necessary? I dont see it used anywhere else in the k-a project.","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":10,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":11,"context_line":"    image: \"{{ service.image }}\""},{"line_number":12,"context_line":"    volumes: \"{{ service.volumes | reject(\u0027equalto\u0027, \u0027\u0027) | list }}\""},{"line_number":13,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":14,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":15,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"243d0389_efffd614","line":12,"range":{"start_line":12,"start_character":35,"end_line":12,"end_character":63},"in_reply_to":"9b80e861_a5cf5e3d","updated":"2024-05-16 15:16:57.000000000","message":"Acknowledged","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3212b3096a1a07312bb639ab9b02c0cbfa637f55","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":10,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":11,"context_line":"    image: \"{{ service.image }}\""},{"line_number":12,"context_line":"    volumes: \"{{ service.volumes | reject(\u0027equalto\u0027, \u0027\u0027) | list }}\""},{"line_number":13,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":14,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":15,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9b80e861_a5cf5e3d","line":12,"range":{"start_line":12,"start_character":35,"end_line":12,"end_character":63},"in_reply_to":"e0823ee5_db2ed43a","updated":"2024-05-15 10:15:45.000000000","message":"This code just was copied from other roles. \nIMO， when service.volumes is an empty string, this filter may be useful.","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"74126eb3b306555e3411fa226876ab63e38fdebf","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  kolla_container:"},{"line_number":72,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":73,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":74,"context_line":"    environment:"},{"line_number":75,"context_line":"      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\""},{"line_number":76,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":77,"context_line":"    image: \"{{ service.image }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"b70fb288_f168b2d2","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":16},"updated":"2024-05-13 07:08:03.000000000","message":"Wouldnt it be better to specify this in ```defaults/main.yml``` and then use ```{{ service.environment }}``` ? \n\nAlso right now, if the env variable changes ```check-containers.yml``` cant detect it.","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  kolla_container:"},{"line_number":72,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":73,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":74,"context_line":"    environment:"},{"line_number":75,"context_line":"      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\""},{"line_number":76,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":77,"context_line":"    image: \"{{ service.image }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"61686742_bb45024e","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":16},"in_reply_to":"24d88fa8_6dfc29d9","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3212b3096a1a07312bb639ab9b02c0cbfa637f55","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  kolla_container:"},{"line_number":72,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":73,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":74,"context_line":"    environment:"},{"line_number":75,"context_line":"      RSYNC_CONNECT_PROG: \"nc %H {{ swift_rsync_port }}\""},{"line_number":76,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":77,"context_line":"    image: \"{{ service.image }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"24d88fa8_6dfc29d9","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":16},"in_reply_to":"b70fb288_f168b2d2","updated":"2024-05-15 10:15:45.000000000","message":"This just keeps consistency with the previous code logic. but it should be fine to remove this to \"defaults/main.yaml\" theoretically","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"}],"ansible/roles/swift/tasks/check-containers.yml":[{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"74126eb3b306555e3411fa226876ab63e38fdebf","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    volumes: \"{{ item.value.volumes }}\""},{"line_number":10,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":11,"context_line":"    privileged: \"{{ item.value.privileged | default(False) }}\""},{"line_number":12,"context_line":"    environment: \"{{ item.value.environment | default(omit) }}\""},{"line_number":13,"context_line":"    healthcheck: \"{{ item.value.healthcheck | default(omit) }}\""},{"line_number":14,"context_line":"  when:"},{"line_number":15,"context_line":"    - item.value.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"67e19fff_48d0eaf0","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":63},"updated":"2024-05-13 07:08:03.000000000","message":"Missing definition of this value in ```defaults/main.yml```","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3212b3096a1a07312bb639ab9b02c0cbfa637f55","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    volumes: \"{{ item.value.volumes }}\""},{"line_number":10,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":11,"context_line":"    privileged: \"{{ item.value.privileged | default(False) }}\""},{"line_number":12,"context_line":"    environment: \"{{ item.value.environment | default(omit) }}\""},{"line_number":13,"context_line":"    healthcheck: \"{{ item.value.healthcheck | default(omit) }}\""},{"line_number":14,"context_line":"  when:"},{"line_number":15,"context_line":"    - item.value.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"86b9bb20_8c234aef","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":63},"in_reply_to":"67e19fff_48d0eaf0","updated":"2024-05-15 10:15:45.000000000","message":"It\u0027s ok here, because the default is omit. K-A has many similar usages.","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    volumes: \"{{ item.value.volumes }}\""},{"line_number":10,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":11,"context_line":"    privileged: \"{{ item.value.privileged | default(False) }}\""},{"line_number":12,"context_line":"    environment: \"{{ item.value.environment | default(omit) }}\""},{"line_number":13,"context_line":"    healthcheck: \"{{ item.value.healthcheck | default(omit) }}\""},{"line_number":14,"context_line":"  when:"},{"line_number":15,"context_line":"    - item.value.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9f4062d3_aa1b4af8","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":63},"in_reply_to":"86b9bb20_8c234aef","updated":"2024-05-16 15:16:57.000000000","message":"Acknowledged","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"}],"ansible/roles/swift/tasks/config-disk.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Looking up disks for Swift"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: docker exec -t kolla_toolbox sudo -E ansible localhost"},{"line_number":5,"context_line":"    -m find_disks"},{"line_number":6,"context_line":"    -a \"name\u003d{{ swift_devices_name }}"},{"line_number":7,"context_line":"        match_mode\u003d{{ swift_devices_match_mode }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1ae7b23c_e9be39ed","line":4,"updated":"2021-09-15 16:47:37.000000000","message":"Would be nicer if we could use the kolla_toolbox module here. That could be a separate change.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"74126eb3b306555e3411fa226876ab63e38fdebf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Looking up disks for Swift"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: docker exec -t kolla_toolbox sudo -E ansible localhost"},{"line_number":5,"context_line":"    -m find_disks"},{"line_number":6,"context_line":"    -a \"name\u003d{{ swift_devices_name }}"},{"line_number":7,"context_line":"        match_mode\u003d{{ swift_devices_match_mode }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"618b7d29_863ce857","line":4,"in_reply_to":"1ae7b23c_e9be39ed","updated":"2024-05-13 07:08:03.000000000","message":"This is working:\n```\n    - name: Looking up disks for Swift\n      become: true\n      kolla_toolbox:\n        container_engine: \"{{ kolla_container_engine }}\"\n        module_name: find_disks\n        module_args:\n          name: \"{{ swift_devices_name }}\"\n          match_mode: \"{{ swift_devices_match_mode }}\"\n      register: swift_disks\n```\n\nin the ``` Mounting swift disks ``` role you just need to use ``` swift_disk.disks ``` in the loop.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3212b3096a1a07312bb639ab9b02c0cbfa637f55","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Looking up disks for Swift"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: docker exec -t kolla_toolbox sudo -E ansible localhost"},{"line_number":5,"context_line":"    -m find_disks"},{"line_number":6,"context_line":"    -a \"name\u003d{{ swift_devices_name }}"},{"line_number":7,"context_line":"        match_mode\u003d{{ swift_devices_match_mode }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"e57cb70d_8b2ace5c","line":4,"in_reply_to":"618b7d29_863ce857","updated":"2024-05-15 10:15:45.000000000","message":"ok, thanks for test this. these code was copied from the previous one.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Looking up disks for Swift"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: docker exec -t kolla_toolbox sudo -E ansible localhost"},{"line_number":5,"context_line":"    -m find_disks"},{"line_number":6,"context_line":"    -a \"name\u003d{{ swift_devices_name }}"},{"line_number":7,"context_line":"        match_mode\u003d{{ swift_devices_match_mode }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a7a0215d_0d2e005d","line":4,"in_reply_to":"e57cb70d_8b2ace5c","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"74126eb3b306555e3411fa226876ab63e38fdebf","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    state: mounted"},{"line_number":30,"context_line":"    name: \"{{ swift_devices_mount_point }}/{{ item[\u0027fs_label\u0027] }}\""},{"line_number":31,"context_line":"  with_items: \"{{ swift_disks }}\""},{"line_number":32,"context_line":"  when: inventory_hostname in groups[\u0027swift-account-server\u0027] or"},{"line_number":33,"context_line":"        inventory_hostname in groups[\u0027swift-container-server\u0027] or"},{"line_number":34,"context_line":"        inventory_hostname in groups[\u0027swift-object-server\u0027]"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"6ce3fb1c_970e9816","line":34,"range":{"start_line":32,"start_character":2,"end_line":34,"end_character":59},"updated":"2024-05-13 07:08:03.000000000","message":"nit: A block could be used to avoid the repetition","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3212b3096a1a07312bb639ab9b02c0cbfa637f55","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    state: mounted"},{"line_number":30,"context_line":"    name: \"{{ swift_devices_mount_point }}/{{ item[\u0027fs_label\u0027] }}\""},{"line_number":31,"context_line":"  with_items: \"{{ swift_disks }}\""},{"line_number":32,"context_line":"  when: inventory_hostname in groups[\u0027swift-account-server\u0027] or"},{"line_number":33,"context_line":"        inventory_hostname in groups[\u0027swift-container-server\u0027] or"},{"line_number":34,"context_line":"        inventory_hostname in groups[\u0027swift-object-server\u0027]"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ff5e907e_aa4b7a76","line":34,"range":{"start_line":32,"start_character":2,"end_line":34,"end_character":59},"in_reply_to":"6ce3fb1c_970e9816","updated":"2024-05-15 10:15:45.000000000","message":"Acknowledged","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        fstype: xfs"},{"line_number":18,"context_line":"        opts: \"noatime,nodiratime,logbufs\u003d8\""},{"line_number":19,"context_line":"        state: mounted"},{"line_number":20,"context_line":"        name: \"{{ swift_devices_mount_point }}/{{ item[\u0027fs_label\u0027] }}\""},{"line_number":21,"context_line":"      with_items: \"{{ swift_disks.disks }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  when: inventory_hostname in groups[\u0027swift-account-server\u0027] or"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"eb3c1d98_44651e7e","line":20,"range":{"start_line":20,"start_character":54,"end_line":20,"end_character":66},"updated":"2024-05-16 15:16:57.000000000","message":"nit: can we use ``` item.fs_label ```?","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"907fd0b9ecac152260a263400231dcb0b2d5d49c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        fstype: xfs"},{"line_number":18,"context_line":"        opts: \"noatime,nodiratime,logbufs\u003d8\""},{"line_number":19,"context_line":"        state: mounted"},{"line_number":20,"context_line":"        name: \"{{ swift_devices_mount_point }}/{{ item[\u0027fs_label\u0027] }}\""},{"line_number":21,"context_line":"      with_items: \"{{ swift_disks.disks }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  when: inventory_hostname in groups[\u0027swift-account-server\u0027] or"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5039f37b_c6381434","line":20,"range":{"start_line":20,"start_character":54,"end_line":20,"end_character":66},"in_reply_to":"eb3c1d98_44651e7e","updated":"2024-07-09 08:23:56.000000000","message":"Done","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4634c5a65e1497eacae7c43190635174cfda598b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      mount:"},{"line_number":16,"context_line":"        src: \"UUID\u003d{{ item.fs_uuid }}\""},{"line_number":17,"context_line":"        fstype: xfs"},{"line_number":18,"context_line":"        opts: \"noatime,nodiratime,logbufs\u003d8\""},{"line_number":19,"context_line":"        state: mounted"},{"line_number":20,"context_line":"        name: \"{{ swift_devices_mount_point }}/{{ item[\u0027fs_label\u0027] }}\""},{"line_number":21,"context_line":"      with_items: \"{{ swift_disks.disks }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"2e6c8ea4_c7de21e8","line":18,"range":{"start_line":18,"start_character":34,"end_line":18,"end_character":43},"updated":"2024-06-10 10:58:56.000000000","message":"logbufs\u003d8 is the default, why do we set this explicitly here?","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4634c5a65e1497eacae7c43190635174cfda598b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      mount:"},{"line_number":16,"context_line":"        src: \"UUID\u003d{{ item.fs_uuid }}\""},{"line_number":17,"context_line":"        fstype: xfs"},{"line_number":18,"context_line":"        opts: \"noatime,nodiratime,logbufs\u003d8\""},{"line_number":19,"context_line":"        state: mounted"},{"line_number":20,"context_line":"        name: \"{{ swift_devices_mount_point }}/{{ item[\u0027fs_label\u0027] }}\""},{"line_number":21,"context_line":"      with_items: \"{{ swift_disks.disks }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"c6f507b4_e908251c","line":18,"range":{"start_line":18,"start_character":23,"end_line":18,"end_character":33},"updated":"2024-06-10 10:58:56.000000000","message":"noatime implies nodiratime, see \"man 8 mount\", so nodiratime is redundant here.","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"907fd0b9ecac152260a263400231dcb0b2d5d49c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      mount:"},{"line_number":16,"context_line":"        src: \"UUID\u003d{{ item.fs_uuid }}\""},{"line_number":17,"context_line":"        fstype: xfs"},{"line_number":18,"context_line":"        opts: \"noatime,nodiratime,logbufs\u003d8\""},{"line_number":19,"context_line":"        state: mounted"},{"line_number":20,"context_line":"        name: \"{{ swift_devices_mount_point }}/{{ item[\u0027fs_label\u0027] }}\""},{"line_number":21,"context_line":"      with_items: \"{{ swift_disks.disks }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"8e03902e_ff0933e6","line":18,"range":{"start_line":18,"start_character":23,"end_line":18,"end_character":33},"in_reply_to":"07c387a2_4d5d4431","updated":"2024-07-09 08:23:56.000000000","message":"yes, thanks for pointing this. I have checked the man mount doc and removed the ``nodiratime`` and ``logbufs`` from code which are redundant.","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b3c2581d2983b14a10475cff6f73c8170a8b306a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      mount:"},{"line_number":16,"context_line":"        src: \"UUID\u003d{{ item.fs_uuid }}\""},{"line_number":17,"context_line":"        fstype: xfs"},{"line_number":18,"context_line":"        opts: \"noatime,nodiratime,logbufs\u003d8\""},{"line_number":19,"context_line":"        state: mounted"},{"line_number":20,"context_line":"        name: \"{{ swift_devices_mount_point }}/{{ item[\u0027fs_label\u0027] }}\""},{"line_number":21,"context_line":"      with_items: \"{{ swift_disks.disks }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df935a4c_3b294f71","line":18,"range":{"start_line":18,"start_character":34,"end_line":18,"end_character":43},"in_reply_to":"2e6c8ea4_c7de21e8","updated":"2024-06-10 12:07:12.000000000","message":"this opt should be copied from the old script. i will check whether we should add this here.","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b3c2581d2983b14a10475cff6f73c8170a8b306a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      mount:"},{"line_number":16,"context_line":"        src: \"UUID\u003d{{ item.fs_uuid }}\""},{"line_number":17,"context_line":"        fstype: xfs"},{"line_number":18,"context_line":"        opts: \"noatime,nodiratime,logbufs\u003d8\""},{"line_number":19,"context_line":"        state: mounted"},{"line_number":20,"context_line":"        name: \"{{ swift_devices_mount_point }}/{{ item[\u0027fs_label\u0027] }}\""},{"line_number":21,"context_line":"      with_items: \"{{ swift_disks.disks }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"07c387a2_4d5d4431","line":18,"range":{"start_line":18,"start_character":23,"end_line":18,"end_character":33},"in_reply_to":"c6f507b4_e908251c","updated":"2024-06-10 12:07:12.000000000","message":"Acknowledged","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"907fd0b9ecac152260a263400231dcb0b2d5d49c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      mount:"},{"line_number":16,"context_line":"        src: \"UUID\u003d{{ item.fs_uuid }}\""},{"line_number":17,"context_line":"        fstype: xfs"},{"line_number":18,"context_line":"        opts: \"noatime,nodiratime,logbufs\u003d8\""},{"line_number":19,"context_line":"        state: mounted"},{"line_number":20,"context_line":"        name: \"{{ swift_devices_mount_point }}/{{ item[\u0027fs_label\u0027] }}\""},{"line_number":21,"context_line":"      with_items: \"{{ swift_disks.disks }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"f2e6300f_4a1cfdd7","line":18,"range":{"start_line":18,"start_character":34,"end_line":18,"end_character":43},"in_reply_to":"df935a4c_3b294f71","updated":"2024-07-09 08:23:56.000000000","message":"Done","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"}],"ansible/roles/swift/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":41,"context_line":"- name: Copying over swift.conf"},{"line_number":42,"context_line":"  vars:"},{"line_number":43,"context_line":"    service_name: \"{{ item.key }}\""},{"line_number":44,"context_line":"    services_need_swift_conf:"},{"line_number":45,"context_line":"      - \"swift-account-auditor\""},{"line_number":46,"context_line":"      - \"swift-account-reaper\""},{"line_number":47,"context_line":"      - \"swift-account-replication-server\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4c8954a7_cc7f3a88","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":28},"updated":"2021-09-15 16:47:37.000000000","message":"Is it just swift-rsyncd that doesn\u0027t need swift.conf? If so, it might be easier to invert the logic.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":41,"context_line":"- name: Copying over swift.conf"},{"line_number":42,"context_line":"  vars:"},{"line_number":43,"context_line":"    service_name: \"{{ item.key }}\""},{"line_number":44,"context_line":"    services_need_swift_conf:"},{"line_number":45,"context_line":"      - \"swift-account-auditor\""},{"line_number":46,"context_line":"      - \"swift-account-reaper\""},{"line_number":47,"context_line":"      - \"swift-account-replication-server\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1b9e276d_5f99993a","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":28},"in_reply_to":"4c8954a7_cc7f3a88","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":64,"context_line":"      - \"{{ role_path }}/templates/swift.conf.j2\""},{"line_number":65,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":66,"context_line":"      - \"{{ node_custom_config }}/swift.conf\""},{"line_number":67,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}/swift.conf\""},{"line_number":68,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}/swift.conf\""},{"line_number":69,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/swift.conf\""},{"line_number":70,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"84db69fa_167afc73","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":51},"updated":"2021-09-15 16:47:37.000000000","message":"Slight change in behaviour here - previously it would look for e.g. swift/account-server, now it looks for swift/swift-account-server. The new behaviour is more consistent with other services, but we should at least provide an upgrade release note about it, and possibly also support the old path for a release or two.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"9f96d27b648cac6a87c373cdc3aaa9783490d717","unresolved":true,"context_lines":[{"line_number":64,"context_line":"      - \"{{ role_path }}/templates/swift.conf.j2\""},{"line_number":65,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":66,"context_line":"      - \"{{ node_custom_config }}/swift.conf\""},{"line_number":67,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}/swift.conf\""},{"line_number":68,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}/swift.conf\""},{"line_number":69,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/swift.conf\""},{"line_number":70,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ec96ed5a_cf8a8c04","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":51},"in_reply_to":"84db69fa_167afc73","updated":"2021-09-22 12:08:40.000000000","message":"Good catch.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      - \"{{ role_path }}/templates/swift.conf.j2\""},{"line_number":65,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":66,"context_line":"      - \"{{ node_custom_config }}/swift.conf\""},{"line_number":67,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}/swift.conf\""},{"line_number":68,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}/swift.conf\""},{"line_number":69,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/swift.conf\""},{"line_number":70,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"658542c3_6ec3f041","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":51},"in_reply_to":"ec96ed5a_cf8a8c04","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":65,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":66,"context_line":"      - \"{{ node_custom_config }}/swift.conf\""},{"line_number":67,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}/swift.conf\""},{"line_number":68,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}/swift.conf\""},{"line_number":69,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/swift.conf\""},{"line_number":70,"context_line":"    mode: \"0660\""},{"line_number":71,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"b0e40a21_fe51b4c4","line":68,"range":{"start_line":68,"start_character":73,"end_line":68,"end_character":76},"updated":"2021-09-15 16:47:37.000000000","message":"ditto","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":66,"context_line":"      - \"{{ node_custom_config }}/swift.conf\""},{"line_number":67,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}/swift.conf\""},{"line_number":68,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}/swift.conf\""},{"line_number":69,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/swift.conf\""},{"line_number":70,"context_line":"    mode: \"0660\""},{"line_number":71,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4354b099_a3711b5f","line":68,"range":{"start_line":68,"start_character":73,"end_line":68,"end_character":76},"in_reply_to":"b0e40a21_fe51b4c4","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":92,"context_line":"      - \"{{ role_path }}/templates/account.conf.j2\""},{"line_number":93,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":94,"context_line":"      - \"{{ node_custom_config }}/swift/account.conf\""},{"line_number":95,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}.conf\""},{"line_number":96,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}.conf\""},{"line_number":97,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/{{ item.key[6:] }}.conf\""},{"line_number":98,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"e0497815_9330e634","line":95,"range":{"start_line":95,"start_character":43,"end_line":95,"end_character":51},"updated":"2021-09-15 16:47:37.000000000","message":"It is really here where we need the compatibility, since this is the user configuration path.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      - \"{{ role_path }}/templates/account.conf.j2\""},{"line_number":93,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":94,"context_line":"      - \"{{ node_custom_config }}/swift/account.conf\""},{"line_number":95,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}.conf\""},{"line_number":96,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}.conf\""},{"line_number":97,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/{{ item.key[6:] }}.conf\""},{"line_number":98,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"97511859_f8d9de97","line":95,"range":{"start_line":95,"start_character":43,"end_line":95,"end_character":51},"in_reply_to":"e0497815_9330e634","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    - item.value.enabled | bool"},{"line_number":102,"context_line":"    - item.value.host_in_groups | bool"},{"line_number":103,"context_line":"    - item.key in services_need_account_conf"},{"line_number":104,"context_line":"  with_dict: \"{{ swift_services }}\""},{"line_number":105,"context_line":"  notify:"},{"line_number":106,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3cc13bd7_f9b606cd","line":104,"range":{"start_line":104,"start_character":17,"end_line":104,"end_character":31},"updated":"2021-09-15 16:47:37.000000000","message":"nit: it would be cleaner to iterate over services_need_account_conf and avoid all the skipped tasks.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    - item.value.enabled | bool"},{"line_number":102,"context_line":"    - item.value.host_in_groups | bool"},{"line_number":103,"context_line":"    - item.key in services_need_account_conf"},{"line_number":104,"context_line":"  with_dict: \"{{ swift_services }}\""},{"line_number":105,"context_line":"  notify:"},{"line_number":106,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"f5c69a99_bea00bb6","line":104,"range":{"start_line":104,"start_character":17,"end_line":104,"end_character":31},"in_reply_to":"3cc13bd7_f9b606cd","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":196,"context_line":"    - item.value.enabled | bool"},{"line_number":197,"context_line":"    - item.value.host_in_groups | bool"},{"line_number":198,"context_line":"    - item.key in services_need_rsyncd_conf"},{"line_number":199,"context_line":"  with_dict: \"{{ swift_services }}\""},{"line_number":200,"context_line":"  notify:"},{"line_number":201,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":202,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"96ada8be_1c79ad4e","line":199,"range":{"start_line":199,"start_character":0,"end_line":199,"end_character":35},"updated":"2021-09-15 16:47:37.000000000","message":"Don\u0027t need a loop here","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    - item.value.enabled | bool"},{"line_number":197,"context_line":"    - item.value.host_in_groups | bool"},{"line_number":198,"context_line":"    - item.key in services_need_rsyncd_conf"},{"line_number":199,"context_line":"  with_dict: \"{{ swift_services }}\""},{"line_number":200,"context_line":"  notify:"},{"line_number":201,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":202,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"714158d2_e0816e41","line":199,"range":{"start_line":199,"start_character":0,"end_line":199,"end_character":35},"in_reply_to":"96ada8be_1c79ad4e","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"74126eb3b306555e3411fa226876ab63e38fdebf","unresolved":true,"context_lines":[{"line_number":64,"context_line":"      - \"{{ role_path }}/templates/swift.conf.j2\""},{"line_number":65,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":66,"context_line":"      - \"{{ node_custom_config }}/swift.conf\""},{"line_number":67,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}/swift.conf\""},{"line_number":68,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}/swift.conf\""},{"line_number":69,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/swift.conf\""},{"line_number":70,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a8c827f_34dc6423","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":51},"updated":"2024-05-13 07:08:03.000000000","message":"Shouldnt this be without the \"swift-\" prefix?\n\nThis also applies to many of the next uses of item.key","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"fbc3972c1206d1e5a07048eba99250f252edf80a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      - \"{{ role_path }}/templates/swift.conf.j2\""},{"line_number":65,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":66,"context_line":"      - \"{{ node_custom_config }}/swift.conf\""},{"line_number":67,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}/swift.conf\""},{"line_number":68,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}/swift.conf\""},{"line_number":69,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/swift.conf\""},{"line_number":70,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7fb355ef_fbd5897e","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":51},"in_reply_to":"038606f7_bff6bde8","updated":"2024-05-21 07:08:29.000000000","message":"Done","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3212b3096a1a07312bb639ab9b02c0cbfa637f55","unresolved":true,"context_lines":[{"line_number":64,"context_line":"      - \"{{ role_path }}/templates/swift.conf.j2\""},{"line_number":65,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":66,"context_line":"      - \"{{ node_custom_config }}/swift.conf\""},{"line_number":67,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}/swift.conf\""},{"line_number":68,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}/swift.conf\""},{"line_number":69,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/swift.conf\""},{"line_number":70,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"923dd65f_90c1b179","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":51},"in_reply_to":"3a8c827f_34dc6423","updated":"2024-05-15 10:15:45.000000000","message":"refer to the other roles. Kolla allows users to customize the config file by adding the config file to \"{node_custom_config}/{service}/{service_name}\"\nhowever, if we cut the \"swift-\" prefix, this will break this prescript. In this case, the users have to read the kolla-ansible code to find which directory they should put config file to.\n\nconsidering this case. I will add a new source path without \"swift-\" prefix to keep compatibility.","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":true,"context_lines":[{"line_number":64,"context_line":"      - \"{{ role_path }}/templates/swift.conf.j2\""},{"line_number":65,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":66,"context_line":"      - \"{{ node_custom_config }}/swift.conf\""},{"line_number":67,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}/swift.conf\""},{"line_number":68,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}/swift.conf\""},{"line_number":69,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/swift.conf\""},{"line_number":70,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"038606f7_bff6bde8","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":51},"in_reply_to":"923dd65f_90c1b179","updated":"2024-05-16 15:16:57.000000000","message":"I like your approach with using full service name and still maintaining backwards compatibility. \n\nHowever, I belive your implementation is not consistent. I belive the change should be also made in the invetory_hostname folder.\n\n```\n- \"{{ node_custom_config }}/swift/{{ item.key[6:] }}/swift.conf\"\n- \"{{ node_custom_config }}/swift/{{ item.key }}/swift.conf\"\n- \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key[6:] }}/swift.conf\"\n- \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}/swift.conf\"\n```","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"74126eb3b306555e3411fa226876ab63e38fdebf","unresolved":true,"context_lines":[{"line_number":80,"context_line":"# NOTE(wuchunyang): item.key[6:] means we remove the \u0027swift-\u0027 prefix for compatibility"},{"line_number":81,"context_line":"- name: Copying over account-*.conf"},{"line_number":82,"context_line":"  vars:"},{"line_number":83,"context_line":"    service_name: \"{{ item.key }}\""},{"line_number":84,"context_line":"    services_need_account_conf:"},{"line_number":85,"context_line":"      - \"swift-account-auditor\""},{"line_number":86,"context_line":"      - \"swift-account-reaper\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"0af45678_5f535741","line":83,"range":{"start_line":83,"start_character":4,"end_line":83,"end_character":34},"updated":"2024-05-13 07:08:03.000000000","message":"nit: To cut down in the number of iterations, you can use this structure:\n\n```\n    service_name: \"{{ item }}\"\n    service: \"{{ swift_services[service_name] }}\"\n    service_short: \"{{ item.split(\u0027swift-\u0027)[1] }}\" # does the same as your item.key[6:]\n    services_need_account_conf:\n      - \"swift-account-auditor\"\n      - \"swift-account-reaper\"\n      - \"swift-account-replication-server\"\n      - \"swift-account-replicator\"\n      - \"swift-account-server\"\n\n  ........\n\n  when:\n    - service.enabled | bool\n    - service.host_in_groups | bool\n  loop: \"{{ services_need_account_conf }}\"\n\n\n```","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3212b3096a1a07312bb639ab9b02c0cbfa637f55","unresolved":true,"context_lines":[{"line_number":80,"context_line":"# NOTE(wuchunyang): item.key[6:] means we remove the \u0027swift-\u0027 prefix for compatibility"},{"line_number":81,"context_line":"- name: Copying over account-*.conf"},{"line_number":82,"context_line":"  vars:"},{"line_number":83,"context_line":"    service_name: \"{{ item.key }}\""},{"line_number":84,"context_line":"    services_need_account_conf:"},{"line_number":85,"context_line":"      - \"swift-account-auditor\""},{"line_number":86,"context_line":"      - \"swift-account-reaper\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1d045af4_eed115aa","line":83,"range":{"start_line":83,"start_character":4,"end_line":83,"end_character":34},"in_reply_to":"0af45678_5f535741","updated":"2024-05-15 10:15:45.000000000","message":"thanks for your advice. i just used one structure to copy all config files, so, it\u0027s easy to re-used.","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# NOTE(wuchunyang): item.key[6:] means we remove the \u0027swift-\u0027 prefix for compatibility"},{"line_number":81,"context_line":"- name: Copying over account-*.conf"},{"line_number":82,"context_line":"  vars:"},{"line_number":83,"context_line":"    service_name: \"{{ item.key }}\""},{"line_number":84,"context_line":"    services_need_account_conf:"},{"line_number":85,"context_line":"      - \"swift-account-auditor\""},{"line_number":86,"context_line":"      - \"swift-account-reaper\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7d24e3fd_378c184f","line":83,"range":{"start_line":83,"start_character":4,"end_line":83,"end_character":34},"in_reply_to":"1d045af4_eed115aa","updated":"2024-05-16 15:16:57.000000000","message":"Acknowledged","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"74126eb3b306555e3411fa226876ab63e38fdebf","unresolved":true,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"- name: Copying over proxy-server.conf"},{"line_number":164,"context_line":"  vars:"},{"line_number":165,"context_line":"    service_name: \"{{ item.key }}\""},{"line_number":166,"context_line":"    services_need_server_conf:"},{"line_number":167,"context_line":"      - \"swift-proxy-server\""},{"line_number":168,"context_line":"  merge_configs:"},{"line_number":169,"context_line":"    sources:"},{"line_number":170,"context_line":"      - \"{{ role_path }}/templates/proxy-server.conf.j2\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"4a30af7b_54e859e6","line":167,"range":{"start_line":165,"start_character":4,"end_line":167,"end_character":28},"updated":"2024-05-13 07:08:03.000000000","message":"If this config is needed by only swift-proxy-server. Wouldnt it be better to just use \n\n``` \nservice_name: \"swift-proxy-server\"\nservice: \"{{ swift_services[service_name] }}\" \n```\n\nand drop the whole loop ``` with_dict ```\n\nPS: Here it is needed to split it to service_name and service since the variable \n``` service_name ``` is used in templating of the config files.","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3212b3096a1a07312bb639ab9b02c0cbfa637f55","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"- name: Copying over proxy-server.conf"},{"line_number":164,"context_line":"  vars:"},{"line_number":165,"context_line":"    service_name: \"{{ item.key }}\""},{"line_number":166,"context_line":"    services_need_server_conf:"},{"line_number":167,"context_line":"      - \"swift-proxy-server\""},{"line_number":168,"context_line":"  merge_configs:"},{"line_number":169,"context_line":"    sources:"},{"line_number":170,"context_line":"      - \"{{ role_path }}/templates/proxy-server.conf.j2\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"802ebf12_b4e3868e","line":167,"range":{"start_line":165,"start_character":4,"end_line":167,"end_character":28},"in_reply_to":"4a30af7b_54e859e6","updated":"2024-05-15 10:15:45.000000000","message":"Acknowledged","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"74126eb3b306555e3411fa226876ab63e38fdebf","unresolved":true,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"- name: Copying over rsyncd.conf"},{"line_number":187,"context_line":"  vars:"},{"line_number":188,"context_line":"    services_need_rsyncd_conf:"},{"line_number":189,"context_line":"      - \"swift-rsyncd\""},{"line_number":190,"context_line":"  template:"},{"line_number":191,"context_line":"    src: \"rsyncd.conf.j2\""},{"line_number":192,"context_line":"    dest: \"{{ node_config_directory }}/swift-rsyncd/rsyncd.conf\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ec0c1011_c7977b07","line":189,"range":{"start_line":188,"start_character":4,"end_line":189,"end_character":22},"updated":"2024-05-13 07:08:03.000000000","message":"Same as the ``` Copying over proxy-server.conf ``` comment. Minus the service and \n service_name split. For rsyncd it is not used.","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3212b3096a1a07312bb639ab9b02c0cbfa637f55","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"- name: Copying over rsyncd.conf"},{"line_number":187,"context_line":"  vars:"},{"line_number":188,"context_line":"    services_need_rsyncd_conf:"},{"line_number":189,"context_line":"      - \"swift-rsyncd\""},{"line_number":190,"context_line":"  template:"},{"line_number":191,"context_line":"    src: \"rsyncd.conf.j2\""},{"line_number":192,"context_line":"    dest: \"{{ node_config_directory }}/swift-rsyncd/rsyncd.conf\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"46411142_521ae0eb","line":189,"range":{"start_line":188,"start_character":4,"end_line":189,"end_character":22},"in_reply_to":"ec0c1011_c7977b07","updated":"2024-05-15 10:15:45.000000000","message":"Acknowledged","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"74126eb3b306555e3411fa226876ab63e38fdebf","unresolved":true,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"- name: Set swift policy file"},{"line_number":232,"context_line":"  set_fact:"},{"line_number":233,"context_line":"    swift_policy_file: \"{{ swift_policy.results.0.stat.path | basename }}\""},{"line_number":234,"context_line":"    swift_policy_file_path: \"{{ swift_policy.results.0.stat.path }}\""},{"line_number":235,"context_line":"  when:"},{"line_number":236,"context_line":"    - swift_policy.results"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"02cb5e2d_46031248","line":233,"range":{"start_line":233,"start_character":4,"end_line":233,"end_character":21},"updated":"2024-05-13 07:08:03.000000000","message":"If you are setting the ``` swift_policy_file ``` shouldnt this be reflected in the template files? Right now they are using static policies.yaml file, but the supported formats could include a .json file.","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3212b3096a1a07312bb639ab9b02c0cbfa637f55","unresolved":true,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"- name: Set swift policy file"},{"line_number":232,"context_line":"  set_fact:"},{"line_number":233,"context_line":"    swift_policy_file: \"{{ swift_policy.results.0.stat.path | basename }}\""},{"line_number":234,"context_line":"    swift_policy_file_path: \"{{ swift_policy.results.0.stat.path }}\""},{"line_number":235,"context_line":"  when:"},{"line_number":236,"context_line":"    - swift_policy.results"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"de125f8b_3fd11275","line":233,"range":{"start_line":233,"start_character":4,"end_line":233,"end_character":21},"in_reply_to":"02cb5e2d_46031248","updated":"2024-05-15 10:15:45.000000000","message":"Hi, i didn\u0027t find anywhere to config this file. could you share the link to me? thanks","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"fbc3972c1206d1e5a07048eba99250f252edf80a","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"- name: Set swift policy file"},{"line_number":232,"context_line":"  set_fact:"},{"line_number":233,"context_line":"    swift_policy_file: \"{{ swift_policy.results.0.stat.path | basename }}\""},{"line_number":234,"context_line":"    swift_policy_file_path: \"{{ swift_policy.results.0.stat.path }}\""},{"line_number":235,"context_line":"  when:"},{"line_number":236,"context_line":"    - swift_policy.results"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9be5c962_4eb2519b","line":233,"range":{"start_line":233,"start_character":4,"end_line":233,"end_character":21},"in_reply_to":"ae32d32e_a011569d","updated":"2024-05-21 07:08:29.000000000","message":"Done","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3c06e5b9e4d6bce890929fadaf5992e9954c74f0","unresolved":true,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"- name: Set swift policy file"},{"line_number":232,"context_line":"  set_fact:"},{"line_number":233,"context_line":"    swift_policy_file: \"{{ swift_policy.results.0.stat.path | basename }}\""},{"line_number":234,"context_line":"    swift_policy_file_path: \"{{ swift_policy.results.0.stat.path }}\""},{"line_number":235,"context_line":"  when:"},{"line_number":236,"context_line":"    - swift_policy.results"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ae32d32e_a011569d","line":233,"range":{"start_line":233,"start_character":4,"end_line":233,"end_character":21},"in_reply_to":"b471e309_c94f525b","updated":"2024-05-17 02:11:52.000000000","message":"thanks for clarifying this part. will update it soon","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":true,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"- name: Set swift policy file"},{"line_number":232,"context_line":"  set_fact:"},{"line_number":233,"context_line":"    swift_policy_file: \"{{ swift_policy.results.0.stat.path | basename }}\""},{"line_number":234,"context_line":"    swift_policy_file_path: \"{{ swift_policy.results.0.stat.path }}\""},{"line_number":235,"context_line":"  when:"},{"line_number":236,"context_line":"    - swift_policy.results"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"b471e309_c94f525b","line":233,"range":{"start_line":233,"start_character":4,"end_line":233,"end_character":21},"in_reply_to":"de125f8b_3fd11275","updated":"2024-05-16 15:16:57.000000000","message":"You are setting ``` supported_policy_format_list ``` few lines prior. This will include any policy file that is either ``` policy.json ``` or ``` policy.yaml ```\n\nLink to definition of that variable: https://github.com/openstack/kolla-ansible/blob/master/ansible/group_vars/all.yml#L687\n\nThus when the user would create a ``` policy.yaml ```, this task would find it, but due to the misconfiguration in ``` swift-someservice.json ``` it would try to import ``` policy.json ``` into the container. \n\nSee my abandoned change for example: https://review.opendev.org/c/openstack/kolla-ansible/+/918040/4/ansible/roles/swift/templates/swift-account-reaper.json.j2","commit_id":"99044d41ef4c74be1cbb0212efdbd92b06ea73a6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":true,"context_lines":[{"line_number":47,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":48,"context_line":"      - \"{{ node_custom_config }}/swift.conf\""},{"line_number":49,"context_line":"      # NOTE(wuchunyang): Remove \"swift-\" prefix for compatibility"},{"line_number":50,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key[6:] }}/swift.conf\""},{"line_number":51,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}/swift.conf\""},{"line_number":52,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}/swift.conf\""},{"line_number":53,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/swift.conf\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3b732062_8c09714e","line":50,"range":{"start_line":50,"start_character":43,"end_line":50,"end_character":55},"updated":"2024-05-16 15:16:57.000000000","message":"nit: use ```service_short``` instead of ```item.key[6:]``` (or vice versa) to make it more consistent :)","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3c06e5b9e4d6bce890929fadaf5992e9954c74f0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":48,"context_line":"      - \"{{ node_custom_config }}/swift.conf\""},{"line_number":49,"context_line":"      # NOTE(wuchunyang): Remove \"swift-\" prefix for compatibility"},{"line_number":50,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key[6:] }}/swift.conf\""},{"line_number":51,"context_line":"      - \"{{ node_custom_config }}/swift/{{ item.key }}/swift.conf\""},{"line_number":52,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ item.key }}/swift.conf\""},{"line_number":53,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/swift.conf\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"aba97101_36e89df8","line":50,"range":{"start_line":50,"start_character":43,"end_line":50,"end_character":55},"in_reply_to":"3b732062_8c09714e","updated":"2024-05-17 02:11:52.000000000","message":"Acknowledged","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":true,"context_lines":[{"line_number":77,"context_line":"      - \"{{ role_path }}/templates/account.conf.j2\""},{"line_number":78,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":79,"context_line":"      - \"{{ node_custom_config }}/swift/account.conf\""},{"line_number":80,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_name}}.conf\""},{"line_number":81,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_name }}.conf\""},{"line_number":82,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ service_short }}.conf\""},{"line_number":83,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"82564978_ab1ab057","line":80,"range":{"start_line":80,"start_character":6,"end_line":80,"end_character":63},"updated":"2024-05-16 15:16:57.000000000","message":"Also I belive this does not provide backwards compatibility. But the above comment needs to be resolved first.\n\nMaybe ? :\n\n```\n- \"{{ node_custom_config }}/swift/{{ service_short }}.conf\"\n- \"{{ node_custom_config }}/swift/{{ service_name }}.conf\"\n- \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_short }}.conf\"\n- \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_name }}.conf\"\n```","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":true,"context_lines":[{"line_number":77,"context_line":"      - \"{{ role_path }}/templates/account.conf.j2\""},{"line_number":78,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":79,"context_line":"      - \"{{ node_custom_config }}/swift/account.conf\""},{"line_number":80,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_name}}.conf\""},{"line_number":81,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_name }}.conf\""},{"line_number":82,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ service_short }}.conf\""},{"line_number":83,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"231d1b25_31a92735","line":80,"range":{"start_line":80,"start_character":6,"end_line":80,"end_character":63},"updated":"2024-05-16 15:16:57.000000000","message":"While I understand why you would want to change the naming scheme for folders in the previous task from (eg.) \"object-server/..\" to \"swift-object-server/..\"\n\nI am wondering if doing it here for config files is a good idea. Because this way the naming scheme in swift project and kolla-ansible would diverge. \n\nIf you take look inside the swift repo, they are using naming scheme without \"swift-\" prefix. I think this could be a little confusing for some folks.\nExample of swift config files: https://github.com/openstack/swift/tree/master/etc\n\nBut this is just my personal opinion and I am happy for any feedback.","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"fbc3972c1206d1e5a07048eba99250f252edf80a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      - \"{{ role_path }}/templates/account.conf.j2\""},{"line_number":78,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":79,"context_line":"      - \"{{ node_custom_config }}/swift/account.conf\""},{"line_number":80,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_name}}.conf\""},{"line_number":81,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_name }}.conf\""},{"line_number":82,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ service_short }}.conf\""},{"line_number":83,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"b97b81d8_4ab460ec","line":80,"range":{"start_line":80,"start_character":6,"end_line":80,"end_character":63},"in_reply_to":"107d2454_60c1fc4b","updated":"2024-05-21 07:08:29.000000000","message":"Done","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3c06e5b9e4d6bce890929fadaf5992e9954c74f0","unresolved":true,"context_lines":[{"line_number":77,"context_line":"      - \"{{ role_path }}/templates/account.conf.j2\""},{"line_number":78,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":79,"context_line":"      - \"{{ node_custom_config }}/swift/account.conf\""},{"line_number":80,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_name}}.conf\""},{"line_number":81,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_name }}.conf\""},{"line_number":82,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ service_short }}.conf\""},{"line_number":83,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"2b829552_9256e1a5","line":80,"range":{"start_line":80,"start_character":6,"end_line":80,"end_character":63},"in_reply_to":"231d1b25_31a92735","updated":"2024-05-17 02:11:52.000000000","message":"yes, though the name scheme in swift project may different with kolla project. but In my opinion, we should comply the kolla scheme  only.  because when user uses Kolla to deploy their cluster, they just need to read Kolla docs only. otherwise, For different serivces, they have to read the different services\u0027 docs to figure out which name scheme they should used.","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6ec82d54d2e648853aeb4ab9de19c3a17b5fb464","unresolved":true,"context_lines":[{"line_number":77,"context_line":"      - \"{{ role_path }}/templates/account.conf.j2\""},{"line_number":78,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":79,"context_line":"      - \"{{ node_custom_config }}/swift/account.conf\""},{"line_number":80,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_name}}.conf\""},{"line_number":81,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_name }}.conf\""},{"line_number":82,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ service_short }}.conf\""},{"line_number":83,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"107d2454_60c1fc4b","line":80,"range":{"start_line":80,"start_character":6,"end_line":80,"end_character":63},"in_reply_to":"2b829552_9256e1a5","updated":"2024-05-17 14:54:00.000000000","message":"Okay, that sounds good. 👍","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3c06e5b9e4d6bce890929fadaf5992e9954c74f0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      - \"{{ role_path }}/templates/account.conf.j2\""},{"line_number":78,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":79,"context_line":"      - \"{{ node_custom_config }}/swift/account.conf\""},{"line_number":80,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_name}}.conf\""},{"line_number":81,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_name }}.conf\""},{"line_number":82,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ service_short }}.conf\""},{"line_number":83,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"56fd0e63_976609e2","line":80,"range":{"start_line":80,"start_character":6,"end_line":80,"end_character":63},"in_reply_to":"82564978_ab1ab057","updated":"2024-05-17 02:11:52.000000000","message":"Acknowledged","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":true,"context_lines":[{"line_number":105,"context_line":"      - \"{{ role_path }}/templates/container.conf.j2\""},{"line_number":106,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":107,"context_line":"      - \"{{ node_custom_config }}/swift/container.conf\""},{"line_number":108,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_name }}.conf\""},{"line_number":109,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_name }}.conf\""},{"line_number":110,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ service_short }}.conf\""},{"line_number":111,"context_line":"    mode: \"0660\""},{"line_number":112,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9ef4e6d1_36e13dd6","line":109,"range":{"start_line":108,"start_character":6,"end_line":109,"end_character":89},"updated":"2024-05-16 15:16:57.000000000","message":"ditto backwards compatibility","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3c06e5b9e4d6bce890929fadaf5992e9954c74f0","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      - \"{{ role_path }}/templates/container.conf.j2\""},{"line_number":106,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":107,"context_line":"      - \"{{ node_custom_config }}/swift/container.conf\""},{"line_number":108,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_name }}.conf\""},{"line_number":109,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_name }}.conf\""},{"line_number":110,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ service_short }}.conf\""},{"line_number":111,"context_line":"    mode: \"0660\""},{"line_number":112,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bb819e31_63b1fa3e","line":109,"range":{"start_line":108,"start_character":6,"end_line":109,"end_character":89},"in_reply_to":"9ef4e6d1_36e13dd6","updated":"2024-05-17 02:11:52.000000000","message":"Acknowledged","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":true,"context_lines":[{"line_number":134,"context_line":"      - \"{{ role_path }}/templates/object.conf.j2\""},{"line_number":135,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":136,"context_line":"      - \"{{ node_custom_config }}/swift/object.conf\""},{"line_number":137,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_name }}.conf\""},{"line_number":138,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_name}}.conf\""},{"line_number":139,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ service_short }}.conf\""},{"line_number":140,"context_line":"    mode: \"0660\""},{"line_number":141,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"8c651ecc_379c52c2","line":138,"range":{"start_line":137,"start_character":6,"end_line":138,"end_character":88},"updated":"2024-05-16 15:16:57.000000000","message":"ditto backwards compatibility","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3c06e5b9e4d6bce890929fadaf5992e9954c74f0","unresolved":false,"context_lines":[{"line_number":134,"context_line":"      - \"{{ role_path }}/templates/object.conf.j2\""},{"line_number":135,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":136,"context_line":"      - \"{{ node_custom_config }}/swift/object.conf\""},{"line_number":137,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_name }}.conf\""},{"line_number":138,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_name}}.conf\""},{"line_number":139,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ service_short }}.conf\""},{"line_number":140,"context_line":"    mode: \"0660\""},{"line_number":141,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"978a7d09_a6621af3","line":138,"range":{"start_line":137,"start_character":6,"end_line":138,"end_character":88},"in_reply_to":"8c651ecc_379c52c2","updated":"2024-05-17 02:11:52.000000000","message":"Acknowledged","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    sources:"},{"line_number":156,"context_line":"      - \"{{ role_path }}/templates/proxy-server.conf.j2\""},{"line_number":157,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":158,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_short }}.conf\""},{"line_number":159,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_name }}.conf\""},{"line_number":160,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_short }}.conf\""},{"line_number":161,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ service_short }}.conf\""},{"line_number":162,"context_line":"    mode: \"0660\""},{"line_number":163,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"8b298c4c_c5864196","line":160,"range":{"start_line":158,"start_character":6,"end_line":160,"end_character":90},"updated":"2024-05-16 15:16:57.000000000","message":"ditto backwards compatibility","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3c06e5b9e4d6bce890929fadaf5992e9954c74f0","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    sources:"},{"line_number":156,"context_line":"      - \"{{ role_path }}/templates/proxy-server.conf.j2\""},{"line_number":157,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":158,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_short }}.conf\""},{"line_number":159,"context_line":"      - \"{{ node_custom_config }}/swift/{{ service_name }}.conf\""},{"line_number":160,"context_line":"      - \"{{ node_custom_config }}/swift/{{ inventory_hostname }}/{{ service_short }}.conf\""},{"line_number":161,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ service_short }}.conf\""},{"line_number":162,"context_line":"    mode: \"0660\""},{"line_number":163,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"affe080c_44d872df","line":160,"range":{"start_line":158,"start_character":6,"end_line":160,"end_character":90},"in_reply_to":"8b298c4c_c5864196","updated":"2024-05-17 02:11:52.000000000","message":"Acknowledged","commit_id":"ce67500298691f26de002d7a62ddd41b05beebfe"}],"ansible/roles/swift/tasks/legacy_upgrade.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- import_tasks: config-disk.yml"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- import_tasks: config.yml"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"d9689ba8_53a100f7","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":31},"updated":"2021-09-15 16:47:37.000000000","message":"Possibly not required for an upgrade","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c12579de2d32be6768504d69f195c4003821d9a9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- import_tasks: config-disk.yml"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- import_tasks: config.yml"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"56019265_20f94476","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":31},"in_reply_to":"d9689ba8_53a100f7","updated":"2021-10-12 16:00:54.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"}],"ansible/roles/swift/tasks/pull.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"867214808fd1e382b15fff18e0e34c769c6a17b0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Pulling swift images"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"pull_image\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"11a8f88a_255446e6","line":2,"updated":"2021-08-23 14:06:23.000000000","message":"Images pull was reworked, you should use role service-images-pull to pull images.","commit_id":"07994f5397b9504c208a39cd303dcf6fcd66eb39"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"53d28cadcb708764571257e9e6801df6aa80d180","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Pulling swift images"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"pull_image\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"04102bbb_c81b0acf","line":2,"in_reply_to":"11a8f88a_255446e6","updated":"2024-05-16 15:16:57.000000000","message":"Done","commit_id":"07994f5397b9504c208a39cd303dcf6fcd66eb39"}],"ansible/roles/swift/tasks/rolling_upgrade.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"daa354a0dad611286d60f344dfabfbd072ec2542","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# the old logic of ralling_upgrade are two steps"},{"line_number":3,"context_line":"# step 1: upgrade stroage nodes"},{"line_number":4,"context_line":"# seep 2: upgrade swift proxy nodes"},{"line_number":5,"context_line":"# the new logic of ralling_upgrade are"},{"line_number":6,"context_line":"# step 1: upgrade all service all the first nodes of groups"},{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ae21f01b_70482fcf","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":34},"updated":"2021-08-10 17:18:29.000000000","message":"are we sure this is sane and safe?","commit_id":"c271b43b4e19dd1cfb2b62e24b9007b2b9ee2255"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"53134a968ecf633df7bb2bc972895bcff73f94a4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# the old logic of ralling_upgrade are two steps"},{"line_number":3,"context_line":"# step 1: upgrade stroage nodes"},{"line_number":4,"context_line":"# seep 2: upgrade swift proxy nodes"},{"line_number":5,"context_line":"# the new logic of ralling_upgrade are"},{"line_number":6,"context_line":"# step 1: upgrade all service all the first nodes of groups"},{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9b4a234b_4a9c62cf","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":34},"in_reply_to":"01511086_4ee007a4","updated":"2021-08-11 11:52:11.000000000","message":"(will work on it)","commit_id":"c271b43b4e19dd1cfb2b62e24b9007b2b9ee2255"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a87ae662117b2d302e7c5ac62a070097e84677d5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# the old logic of ralling_upgrade are two steps"},{"line_number":3,"context_line":"# step 1: upgrade stroage nodes"},{"line_number":4,"context_line":"# seep 2: upgrade swift proxy nodes"},{"line_number":5,"context_line":"# the new logic of ralling_upgrade are"},{"line_number":6,"context_line":"# step 1: upgrade all service all the first nodes of groups"},{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"01511086_4ee007a4","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":34},"in_reply_to":"7b68c5b5_e4fd2dae","updated":"2021-08-11 11:51:57.000000000","message":"(I thought I only dreamed about it but it seems I have actually already proposed the upgrade job once: https://review.opendev.org/c/openstack/kolla-ansible/+/722798 )","commit_id":"c271b43b4e19dd1cfb2b62e24b9007b2b9ee2255"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b9acae5c50c081c2866be48bb61a64b9c99e2269","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# the old logic of ralling_upgrade are two steps"},{"line_number":3,"context_line":"# step 1: upgrade stroage nodes"},{"line_number":4,"context_line":"# seep 2: upgrade swift proxy nodes"},{"line_number":5,"context_line":"# the new logic of ralling_upgrade are"},{"line_number":6,"context_line":"# step 1: upgrade all service all the first nodes of groups"},{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c9592b82_18e6fce4","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":34},"in_reply_to":"9b4a234b_4a9c62cf","updated":"2021-08-11 12:04:20.000000000","message":"Actually， i am not sure whether this is safe. let\u0027s wait for https://review.opendev.org/c/openstack/kolla-ansible/+/722798  merged, and then test this ps.","commit_id":"c271b43b4e19dd1cfb2b62e24b9007b2b9ee2255"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4f019d9c63f44f9e3478f1894c88fdca97025269","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# the old logic of ralling_upgrade are two steps"},{"line_number":3,"context_line":"# step 1: upgrade stroage nodes"},{"line_number":4,"context_line":"# seep 2: upgrade swift proxy nodes"},{"line_number":5,"context_line":"# the new logic of ralling_upgrade are"},{"line_number":6,"context_line":"# step 1: upgrade all service all the first nodes of groups"},{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7b68c5b5_e4fd2dae","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":34},"in_reply_to":"ae21f01b_70482fcf","updated":"2021-08-10 17:18:58.000000000","message":"(could use a swift upgrade job in CI)","commit_id":"c271b43b4e19dd1cfb2b62e24b9007b2b9ee2255"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"97ed66161cc500e98db90ecbf9c4a5faafb078ff","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# the old logic of ralling_upgrade are two steps"},{"line_number":3,"context_line":"# step 1: upgrade stroage nodes"},{"line_number":4,"context_line":"# seep 2: upgrade swift proxy nodes"},{"line_number":5,"context_line":"# the new logic of ralling_upgrade are"},{"line_number":6,"context_line":"# step 1: upgrade all service all the first nodes of groups"},{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dc61096d_5bfa1d61","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":34},"in_reply_to":"c9592b82_18e6fce4","updated":"2021-08-11 12:12:03.000000000","message":"Ack, we might want to also query the Swift docs (and/or Swift team 😉) to know what\u0027s the best/recommended approach. The previous one might not have been the best either. I just don\u0027t know.","commit_id":"c271b43b4e19dd1cfb2b62e24b9007b2b9ee2255"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"67eb6976bd840563ebe8f0db5cebe346a9876aca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# the old logic of ralling_upgrade are two steps"},{"line_number":3,"context_line":"# step 1: upgrade stroage nodes"},{"line_number":4,"context_line":"# seep 2: upgrade swift proxy nodes"},{"line_number":5,"context_line":"# the new logic of ralling_upgrade are"},{"line_number":6,"context_line":"# step 1: upgrade all service all the first nodes of groups"},{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c007060e_5a6a26d1","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":34},"in_reply_to":"dc61096d_5bfa1d61","updated":"2024-07-19 05:01:04.000000000","message":"Done","commit_id":"c271b43b4e19dd1cfb2b62e24b9007b2b9ee2255"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# the old logic of ralling_upgrade are two steps"},{"line_number":3,"context_line":"# step 1: upgrade stroage nodes"},{"line_number":4,"context_line":"# seep 2: upgrade swift proxy nodes"},{"line_number":5,"context_line":"# the new logic of ralling_upgrade are"},{"line_number":6,"context_line":"# step 1: upgrade all service all the first nodes of groups"},{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"866a7284_f40f17a9","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":35},"updated":"2021-09-15 16:47:37.000000000","message":"We could achieve something like this by moving the proxy handler to the end of the handler list.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"67eb6976bd840563ebe8f0db5cebe346a9876aca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# the old logic of ralling_upgrade are two steps"},{"line_number":3,"context_line":"# step 1: upgrade stroage nodes"},{"line_number":4,"context_line":"# seep 2: upgrade swift proxy nodes"},{"line_number":5,"context_line":"# the new logic of ralling_upgrade are"},{"line_number":6,"context_line":"# step 1: upgrade all service all the first nodes of groups"},{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"db0fa0d7_98885cda","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":35},"in_reply_to":"866a7284_f40f17a9","updated":"2024-07-19 05:01:04.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# the old logic of ralling_upgrade are two steps"},{"line_number":3,"context_line":"# step 1: upgrade stroage nodes"},{"line_number":4,"context_line":"# seep 2: upgrade swift proxy nodes"},{"line_number":5,"context_line":"# the new logic of ralling_upgrade are"},{"line_number":6,"context_line":"# step 1: upgrade all service all the first nodes of groups"},{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"aa78fe34_19672630","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":34},"updated":"2021-09-15 16:47:37.000000000","message":"What is the reasoning behind this approach?","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"9f96d27b648cac6a87c373cdc3aaa9783490d717","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# the old logic of ralling_upgrade are two steps"},{"line_number":3,"context_line":"# step 1: upgrade stroage nodes"},{"line_number":4,"context_line":"# seep 2: upgrade swift proxy nodes"},{"line_number":5,"context_line":"# the new logic of ralling_upgrade are"},{"line_number":6,"context_line":"# step 1: upgrade all service all the first nodes of groups"},{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c932aabe_101d52f8","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":34},"in_reply_to":"aa78fe34_19672630","updated":"2021-09-22 12:08:40.000000000","message":"No reason for me.  will redo it  later, i am not sure which is the better way for upgrading.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"67eb6976bd840563ebe8f0db5cebe346a9876aca","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# the old logic of ralling_upgrade are two steps"},{"line_number":3,"context_line":"# step 1: upgrade stroage nodes"},{"line_number":4,"context_line":"# seep 2: upgrade swift proxy nodes"},{"line_number":5,"context_line":"# the new logic of ralling_upgrade are"},{"line_number":6,"context_line":"# step 1: upgrade all service all the first nodes of groups"},{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c1bc7389_79246e21","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":34},"in_reply_to":"c932aabe_101d52f8","updated":"2024-07-19 05:01:04.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  - import_tasks: config.yml"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"314fcdf6_3f8dd190","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":32},"updated":"2021-09-15 16:47:37.000000000","message":"Probably not required for an upgrade.","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6ec82d54d2e648853aeb4ab9de19c3a17b5fb464","unresolved":true,"context_lines":[{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  - import_tasks: config.yml"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"cb5dd95f_1110d93e","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":32},"in_reply_to":"314fcdf6_3f8dd190","updated":"2024-05-17 14:54:00.000000000","message":"+1","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"67eb6976bd840563ebe8f0db5cebe346a9876aca","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# setp 2: upgrade all remain nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - import_tasks: config-disk.yml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  - import_tasks: config.yml"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bec96c84_f14ac5b0","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":32},"in_reply_to":"cb5dd95f_1110d93e","updated":"2024-07-19 05:01:04.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e615964a0395e8c163a3e01063ecf3e79be90a13","unresolved":true,"context_lines":[{"line_number":32,"context_line":"  - name: Flush handlers"},{"line_number":33,"context_line":"    meta: flush_handlers"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  when: inventory_hostname !\u003d groups[\u0027swift-account-server\u0027][0] or"},{"line_number":36,"context_line":"        inventory_hostname !\u003d groups[\u0027swift-container-server\u0027][0] or"},{"line_number":37,"context_line":"        inventory_hostname !\u003d groups[\u0027swift-object-server\u0027][0] or"},{"line_number":38,"context_line":"        inventory_hostname !\u003d groups[\u0027swift-proxy-server\u0027][0]"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"db734413_4e7e17ca","line":35,"range":{"start_line":35,"start_character":64,"end_line":35,"end_character":66},"updated":"2021-09-15 16:47:37.000000000","message":"would need to be \u0027and\u0027 for an inverse of the above","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6ec82d54d2e648853aeb4ab9de19c3a17b5fb464","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  - name: Flush handlers"},{"line_number":33,"context_line":"    meta: flush_handlers"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  when: inventory_hostname !\u003d groups[\u0027swift-account-server\u0027][0] or"},{"line_number":36,"context_line":"        inventory_hostname !\u003d groups[\u0027swift-container-server\u0027][0] or"},{"line_number":37,"context_line":"        inventory_hostname !\u003d groups[\u0027swift-object-server\u0027][0] or"},{"line_number":38,"context_line":"        inventory_hostname !\u003d groups[\u0027swift-proxy-server\u0027][0]"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"f2dd9b9a_8a717a3e","line":35,"range":{"start_line":35,"start_character":64,"end_line":35,"end_character":66},"in_reply_to":"db734413_4e7e17ca","updated":"2024-05-17 14:54:00.000000000","message":"Done","commit_id":"d421a31b03e6f067a7988a9cfc6d81c1790d78f9"}],"releasenotes/notes/modernize-the-swift-role-d9db5f0f44270742.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4634c5a65e1497eacae7c43190635174cfda598b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Modernize the swift role for Kolla Ansible."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"e18328a6_ada9985d","line":4,"range":{"start_line":1,"start_character":3,"end_line":4,"end_character":47},"updated":"2024-06-10 10:58:56.000000000","message":"I don\u0027t think this belongs in the \"upgrade\" section in it\u0027s current form at least.\n\nImho the upgrade section should contain some actionable stuff for the operator, e.g. at least some notice if file locations change, stuff is deleted, they need to adjust configs if they want to preserve old behaviour etc.\n\nif it\u0027s purely informational, I think we can move this to features instead? I would prefer a text with some more details though.","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"907fd0b9ecac152260a263400231dcb0b2d5d49c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Modernize the swift role for Kolla Ansible."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ec768aaa_114f823d","line":4,"range":{"start_line":1,"start_character":3,"end_line":4,"end_character":47},"in_reply_to":"cb40bdc7_10b4c294","updated":"2024-07-09 08:23:56.000000000","message":"I\u0027ve re-written the release note, please help to review again. thanks.","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b3c2581d2983b14a10475cff6f73c8170a8b306a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Modernize the swift role for Kolla Ansible."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"cb40bdc7_10b4c294","line":4,"range":{"start_line":1,"start_character":3,"end_line":4,"end_character":47},"in_reply_to":"e18328a6_ada9985d","updated":"2024-06-10 12:07:12.000000000","message":"yes, i agree with you. this is purely informational. and this commit is compatible with the old code. so this reno doesn\u0027t make sense. should we remove this release note ？ or add to features with more details ?","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dc343ff16baace276fff7c543116fc31fa6204d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Modernize the swift role for Kolla Ansible."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"53c6162f_e6785f98","line":4,"range":{"start_line":1,"start_character":3,"end_line":4,"end_character":47},"in_reply_to":"ec768aaa_114f823d","updated":"2024-07-10 14:44:26.000000000","message":"Done","commit_id":"d10dfb40e8cbd826b9d1e65935c9aecd2d196955"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dc343ff16baace276fff7c543116fc31fa6204d8","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    Add a new custom config path for Swift services following the naming"},{"line_number":7,"context_line":"    schema ``node_custom_config/swift/\u003cservice-name\u003e.conf``, For example, users"},{"line_number":8,"context_line":"    can place `swift-proxy-server.conf` in ``/etc/kolla/config/swift/``,"},{"line_number":9,"context_line":"    while the previous config file was named ``proxy-server.conf``,"},{"line_number":10,"context_line":"    which did not contain the \"swift-\" prefix and was inconsistent with"},{"line_number":11,"context_line":"    other services. Both naming conventions for swift services should"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"49b31e74_61266372","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":72},"updated":"2024-07-10 14:44:26.000000000","message":"There is no `/config/` in this path afaik.\n\n```suggestion\n    can place `swift-proxy-server.conf` in ``/etc/kolla/swift/``,\n```","commit_id":"39706d3665dc4df2e032b9f929cf70cf8c6d3527"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"37845d6939876d323faca01d6259880e363c757b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    Add a new custom config path for Swift services following the naming"},{"line_number":7,"context_line":"    schema ``node_custom_config/swift/\u003cservice-name\u003e.conf``, For example, users"},{"line_number":8,"context_line":"    can place `swift-proxy-server.conf` in ``/etc/kolla/config/swift/``,"},{"line_number":9,"context_line":"    while the previous config file was named ``proxy-server.conf``,"},{"line_number":10,"context_line":"    which did not contain the \"swift-\" prefix and was inconsistent with"},{"line_number":11,"context_line":"    other services. Both naming conventions for swift services should"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"0a13106c_12b4e980","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":72},"in_reply_to":"0c57bcda_d4f384dc","updated":"2024-07-16 15:53:30.000000000","message":"Acknowledged","commit_id":"39706d3665dc4df2e032b9f929cf70cf8c6d3527"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"445e48e3354fe4f508e589cfa4c98eeba78459ec","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    Add a new custom config path for Swift services following the naming"},{"line_number":7,"context_line":"    schema ``node_custom_config/swift/\u003cservice-name\u003e.conf``, For example, users"},{"line_number":8,"context_line":"    can place `swift-proxy-server.conf` in ``/etc/kolla/config/swift/``,"},{"line_number":9,"context_line":"    while the previous config file was named ``proxy-server.conf``,"},{"line_number":10,"context_line":"    which did not contain the \"swift-\" prefix and was inconsistent with"},{"line_number":11,"context_line":"    other services. Both naming conventions for swift services should"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"0c57bcda_d4f384dc","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":72},"in_reply_to":"49b31e74_61266372","updated":"2024-07-10 15:30:47.000000000","message":"Hi, the default value of \u0027node_custom_config\u0027 is ``/etc/kolla/config/`` refer: https://github.com/openstack/kolla-ansible/blob/master/ansible/group_vars/all.yml#L13\nso we need the  ``/config/`` here","commit_id":"39706d3665dc4df2e032b9f929cf70cf8c6d3527"}],"tests/test-swift.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dc343ff16baace276fff7c543116fc31fa6204d8","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":11,"context_line":"    # python-openstackclient 6.6.0 didn\u0027t work with swift due to https://review.opendev.org/c/openstack/python-openstackclient/+/920001"},{"line_number":12,"context_line":"    # TODO: remove the installation once new package released on pypi.org."},{"line_number":13,"context_line":"    . ~/openstackclient-venv/bin/pip install -q git+https://github.com/openstack/python-openstackclient@master"},{"line_number":14,"context_line":"    . ~/openstackclient-venv/bin/activate"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    echo \"TESTING: Swift\""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-sh","patch_set":26,"id":"394af126_2963f1af","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":41},"updated":"2024-07-10 14:44:26.000000000","message":"I don\u0027t think we want to install python-openstackclient from master here as that might cause some breakage in the future.\n\nanother way to solve this would maybe just to provide the needed dependency?\n\nalso we first need to activate the venv before installing packages into it.\n\nfurthermore, _if_ we would install a certain python-openstackclient version we should use our canonical source - opendev.org - instead of the github mirror.\n\n```suggestion\n    . ~/openstackclient-venv/bin/activate\n    . ~/openstackclient-venv/bin/pip install -q simplejson\n\n```\nanother solution would be to adjust our own requirements file, to require simplejson, but I think that would be a little too much overhead.","commit_id":"39706d3665dc4df2e032b9f929cf70cf8c6d3527"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"445e48e3354fe4f508e589cfa4c98eeba78459ec","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":11,"context_line":"    # python-openstackclient 6.6.0 didn\u0027t work with swift due to https://review.opendev.org/c/openstack/python-openstackclient/+/920001"},{"line_number":12,"context_line":"    # TODO: remove the installation once new package released on pypi.org."},{"line_number":13,"context_line":"    . ~/openstackclient-venv/bin/pip install -q git+https://github.com/openstack/python-openstackclient@master"},{"line_number":14,"context_line":"    . ~/openstackclient-venv/bin/activate"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    echo \"TESTING: Swift\""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-sh","patch_set":26,"id":"c81c357c_2e43b628","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":41},"in_reply_to":"394af126_2963f1af","updated":"2024-07-10 15:30:47.000000000","message":"Acknowledged","commit_id":"39706d3665dc4df2e032b9f929cf70cf8c6d3527"}]}