)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"97e5925b06fae96919bcad17f37d01bf080164f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c7dbd437_5b21af63","updated":"2022-01-24 15:51:59.000000000","message":"CCing this","commit_id":"e4b6b1fba31e6289f33d4de73e9aa70db51f5b03"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bf6438c9af644878998c76d6d650cab6d06e6d80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e05642d1_bb287013","updated":"2021-12-14 10:26:38.000000000","message":"Isaac, could you please update this patch?","commit_id":"e4b6b1fba31e6289f33d4de73e9aa70db51f5b03"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9e4cf55a8fa8d46bb18dc6634b9fbea96e81a02e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b880080e_018ae122","updated":"2022-01-27 10:41:07.000000000","message":"also need to consider https://review.opendev.org/c/openstack/kolla-ansible/+/745111 and https://review.opendev.org/c/openstack/kolla-ansible/+/780629","commit_id":"79b59e2c0b43936a12a9c676d8a48cd62c733a0f"}],"ansible/roles/common/templates/conf/output/00-local.conf.j2":[{"author":{"_account_id":30438,"name":"Isaac Prior","email":"isaac@stackhpc.com","username":"Wasaac"},"change_message_id":"4fcfbb0d35b46bd649703a47bc5c9f5abfe79d6f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    @type file"},{"line_number":5,"context_line":"    path /var/log/kolla/swift/swift_latest"},{"line_number":6,"context_line":"    append true"},{"line_number":7,"context_line":"    \u003cbuffer []\u003e"},{"line_number":8,"context_line":"      path /var/log/kolla/swift/swift_latest.*.buffer"},{"line_number":9,"context_line":"    \u003c/buffer\u003e"},{"line_number":10,"context_line":"  \u003c/store\u003e"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ed4c5990_90cff7d0","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":15},"updated":"2021-10-12 14:49:20.000000000","message":"A brief explanation of this buffer [] weirdness for prospective reviewers.\nFluentd docs (https://docs.fluentd.org/configuration/buffer-section#blank-chunk-keys) explain that \u003cbuffer\u003e without a argument uses the default chunk keys specified by the output plugin if available. \nIn our case the output plugin is @type file and by default it uses the time chunk key (https://github.com/fluent/fluentd/blob/master/lib/fluent/plugin/out_file.rb#L63).\nBy providing [] we override the default so that chunks are written to a single file without a timestamp - this allows logrotate to manage/rotate/delete the files as intended.","commit_id":"e4b6b1fba31e6289f33d4de73e9aa70db51f5b03"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"71bdf14fdd782e78115c10e676e847e75385b766","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    @type file"},{"line_number":5,"context_line":"    path /var/log/kolla/swift/swift_latest"},{"line_number":6,"context_line":"    append true"},{"line_number":7,"context_line":"    \u003cbuffer []\u003e"},{"line_number":8,"context_line":"      path /var/log/kolla/swift/swift_latest.*.buffer"},{"line_number":9,"context_line":"    \u003c/buffer\u003e"},{"line_number":10,"context_line":"  \u003c/store\u003e"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"f8aa7647_2957f4f2","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":15},"in_reply_to":"ed4c5990_90cff7d0","updated":"2021-10-12 14:56:41.000000000","message":"Can we get this in commit message?","commit_id":"e4b6b1fba31e6289f33d4de73e9aa70db51f5b03"},{"author":{"_account_id":30438,"name":"Isaac Prior","email":"isaac@stackhpc.com","username":"Wasaac"},"change_message_id":"e506f50aa7841f04d2ba5d3b98613993036532a9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    @type file"},{"line_number":5,"context_line":"    path /var/log/kolla/swift/swift_latest"},{"line_number":6,"context_line":"    append true"},{"line_number":7,"context_line":"    \u003cbuffer []\u003e"},{"line_number":8,"context_line":"      path /var/log/kolla/swift/swift_latest.*.buffer"},{"line_number":9,"context_line":"    \u003c/buffer\u003e"},{"line_number":10,"context_line":"  \u003c/store\u003e"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"a445ea32_efcb1624","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":15},"in_reply_to":"f8aa7647_2957f4f2","updated":"2022-01-25 13:31:18.000000000","message":"Done","commit_id":"e4b6b1fba31e6289f33d4de73e9aa70db51f5b03"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5b5367ebd3548c715104f70e0b9060a2a3ceae09","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    append true"},{"line_number":7,"context_line":"    \u003cbuffer []\u003e"},{"line_number":8,"context_line":"      path /var/log/kolla/swift/swift_latest.*.buffer"},{"line_number":9,"context_line":"    \u003c/buffer\u003e"},{"line_number":10,"context_line":"  \u003c/store\u003e"},{"line_number":11,"context_line":"{% if log_direct_to_elasticsearch %}"},{"line_number":12,"context_line":"  \u003cstore\u003e"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"07844ba1_d148ec95","line":9,"updated":"2021-09-14 10:04:51.000000000","message":"Is there a reason we don\u0027t have the \u003cformat\u003e section here?","commit_id":"e4b6b1fba31e6289f33d4de73e9aa70db51f5b03"},{"author":{"_account_id":30438,"name":"Isaac Prior","email":"isaac@stackhpc.com","username":"Wasaac"},"change_message_id":"dea1ca1c89a350f97d1c07481ee151387e9b6e3a","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    append true"},{"line_number":7,"context_line":"    \u003cbuffer []\u003e"},{"line_number":8,"context_line":"      path /var/log/kolla/swift/swift_latest.*.buffer"},{"line_number":9,"context_line":"    \u003c/buffer\u003e"},{"line_number":10,"context_line":"  \u003c/store\u003e"},{"line_number":11,"context_line":"{% if log_direct_to_elasticsearch %}"},{"line_number":12,"context_line":"  \u003cstore\u003e"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3573babd_e9191eb1","line":9,"in_reply_to":"07844ba1_d148ec95","updated":"2021-09-28 13:39:15.000000000","message":"Looks like that was decided when fluentd was first added (https://opendev.org/openstack/kolla-ansible/commit/d3d4a933be797d1dc7ab156529878bc0c00f9e1c).\nThe flags used in \u003cformat\u003e section control whether tag/time are injected into the logfile (https://docs.fluentd.org/v/0.12/formatter/out_file#output_tag-boolean-optional-defaults-to-true). \nI suspect this was done because the haproxy logs already include date and program name at the start of the log where swift does not (see https://docs.openstack.org/swift/latest/logs.html for current swift log format).","commit_id":"e4b6b1fba31e6289f33d4de73e9aa70db51f5b03"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"71bdf14fdd782e78115c10e676e847e75385b766","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    append true"},{"line_number":7,"context_line":"    \u003cbuffer []\u003e"},{"line_number":8,"context_line":"      path /var/log/kolla/swift/swift_latest.*.buffer"},{"line_number":9,"context_line":"    \u003c/buffer\u003e"},{"line_number":10,"context_line":"  \u003c/store\u003e"},{"line_number":11,"context_line":"{% if log_direct_to_elasticsearch %}"},{"line_number":12,"context_line":"  \u003cstore\u003e"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3ae1489e_581d92f4","line":9,"in_reply_to":"3573babd_e9191eb1","updated":"2021-10-12 14:56:41.000000000","message":"let\u0027s add some comment in the file, so it\u0027s more-or-less explained for future references?","commit_id":"e4b6b1fba31e6289f33d4de73e9aa70db51f5b03"},{"author":{"_account_id":30438,"name":"Isaac Prior","email":"isaac@stackhpc.com","username":"Wasaac"},"change_message_id":"e506f50aa7841f04d2ba5d3b98613993036532a9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    append true"},{"line_number":7,"context_line":"    \u003cbuffer []\u003e"},{"line_number":8,"context_line":"      path /var/log/kolla/swift/swift_latest.*.buffer"},{"line_number":9,"context_line":"    \u003c/buffer\u003e"},{"line_number":10,"context_line":"  \u003c/store\u003e"},{"line_number":11,"context_line":"{% if log_direct_to_elasticsearch %}"},{"line_number":12,"context_line":"  \u003cstore\u003e"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ec3a20a2_1f4d5884","line":9,"in_reply_to":"3ae1489e_581d92f4","updated":"2022-01-25 13:31:18.000000000","message":"I\u0027ve added some comments on the parts changed by this PR. Further effort to document the fluentd config would be useful though. \nThere is also a mix of fluentd v0.12 and v1 config syntax (https://docs.fluentd.org/quickstart/update-from-v0.12) in use - see https://bugs.launchpad.net/kolla-ansible/+bug/1919179 for one example of a bug this causes. \nI suggest we resolve this bug and improve the documentation in the PR to address that.","commit_id":"e4b6b1fba31e6289f33d4de73e9aa70db51f5b03"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f46c0c8aebed9f8c1201914014c5f062fea87b6c","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    \u003cbuffer []\u003e"},{"line_number":73,"context_line":"      path /var/log/kolla/haproxy/haproxy_latest.*.buffer"},{"line_number":74,"context_line":"    \u003c/buffer\u003e"},{"line_number":75,"context_line":"    # Don\u0027t prepend syslog tag or timestamp to log output"},{"line_number":76,"context_line":"    \u003cformat\u003e"},{"line_number":77,"context_line":"      output_tag false"},{"line_number":78,"context_line":"      output_time false"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1a427460_533fcf3d","line":75,"updated":"2022-02-11 09:25:58.000000000","message":"Is there a reason we\u0027re not doing this for swift?","commit_id":"79b59e2c0b43936a12a9c676d8a48cd62c733a0f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"361b68d10185fadf04712d606e6ad9087ce4ff98","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    \u003cbuffer []\u003e"},{"line_number":73,"context_line":"      path /var/log/kolla/haproxy/haproxy_latest.*.buffer"},{"line_number":74,"context_line":"    \u003c/buffer\u003e"},{"line_number":75,"context_line":"    # Don\u0027t prepend syslog tag or timestamp to log output"},{"line_number":76,"context_line":"    \u003cformat\u003e"},{"line_number":77,"context_line":"      output_tag false"},{"line_number":78,"context_line":"      output_time false"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"b5130c31_c7c81322","line":75,"in_reply_to":"1a427460_533fcf3d","updated":"2022-02-11 09:33:20.000000000","message":"(FWIW, I answered on the backported change.)","commit_id":"79b59e2c0b43936a12a9c676d8a48cd62c733a0f"}],"releasenotes/notes/fix-haproxy-logrotate-e299a0000728fd8f.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8bc5db1dace3a5162b18c864dbc201afb7a4adc","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Existing fluentd log rotation failed to delete old haproxy, swift,"},{"line_number":11,"context_line":"    glance-tls-proxy and neutron-tls-proxy logs. Standardise rotation"},{"line_number":12,"context_line":"    and deletion of logs using logrotate."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8f12a369_7db35181","line":12,"updated":"2022-01-27 10:38:36.000000000","message":"nit: it\u0027s missing a reference to LP but it\u0027s not mandatory in this case; fix if something else needs to change","commit_id":"79b59e2c0b43936a12a9c676d8a48cd62c733a0f"}]}