)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"28e60f0480293064528ec0a469f439818af21b91","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add support of podman deployment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds basic deployment based on podman containers"},{"line_number":10,"context_line":"on CentOS8 and Ubuntu-20.04."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-authored-by: Martin Hiner \u003cmartin.hiner@tietoevry.com\u003e"},{"line_number":13,"context_line":"Signed-off-by: Ivan Halomi \u003civan.halomi@tietoevry.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"d9b1482c_31824eac","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":28},"updated":"2022-10-19 10:57:44.000000000","message":"we moved on with distro versions","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"cbc63e423c8705030cf7e7faf3afe641f8c94680","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support of podman deployment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds basic deployment based on podman containers"},{"line_number":10,"context_line":"on CentOS8 and Ubuntu-20.04."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-authored-by: Martin Hiner \u003cmartin.hiner@tietoevry.com\u003e"},{"line_number":13,"context_line":"Signed-off-by: Ivan Halomi \u003civan.halomi@tietoevry.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"7c11422f_2b0cda9d","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":28},"in_reply_to":"d9b1482c_31824eac","updated":"2022-10-19 11:17:19.000000000","message":"Done","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"28e60f0480293064528ec0a469f439818af21b91","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change adds basic deployment based on podman containers"},{"line_number":10,"context_line":"on CentOS8 and Ubuntu-20.04."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-authored-by: Martin Hiner \u003cmartin.hiner@tietoevry.com\u003e"},{"line_number":13,"context_line":"Signed-off-by: Ivan Halomi \u003civan.halomi@tietoevry.com\u003e"},{"line_number":14,"context_line":"Change-Id: I2b52964906ba8b19b8b1098717b9423ab954fa3d"},{"line_number":15,"context_line":"Signed-off-by: Ivan Halomi \u003ci.halomi@partner.samsung.com\u003e"},{"line_number":16,"context_line":"Signed-off-by: Martin Hiner \u003cm.hiner@partner.samsung.com\u003e"},{"line_number":17,"context_line":"Signed-off-by: Petr Tuma \u003cp.tuma@partner.samsung.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"84cb2d97_b9b4e7ff","line":17,"range":{"start_line":12,"start_character":0,"end_line":17,"end_character":53},"updated":"2022-10-19 10:57:44.000000000","message":"please move Change-Id to the end and organize S-o-b lines as there are repeats","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"cbc63e423c8705030cf7e7faf3afe641f8c94680","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change adds basic deployment based on podman containers"},{"line_number":10,"context_line":"on CentOS8 and Ubuntu-20.04."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-authored-by: Martin Hiner \u003cmartin.hiner@tietoevry.com\u003e"},{"line_number":13,"context_line":"Signed-off-by: Ivan Halomi \u003civan.halomi@tietoevry.com\u003e"},{"line_number":14,"context_line":"Change-Id: I2b52964906ba8b19b8b1098717b9423ab954fa3d"},{"line_number":15,"context_line":"Signed-off-by: Ivan Halomi \u003ci.halomi@partner.samsung.com\u003e"},{"line_number":16,"context_line":"Signed-off-by: Martin Hiner \u003cm.hiner@partner.samsung.com\u003e"},{"line_number":17,"context_line":"Signed-off-by: Petr Tuma \u003cp.tuma@partner.samsung.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"56190174_c68dc1e0","line":17,"range":{"start_line":12,"start_character":0,"end_line":17,"end_character":53},"in_reply_to":"84cb2d97_b9b4e7ff","updated":"2022-10-19 11:17:19.000000000","message":"Done","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"5001a36dede43c632488cf8d2ab9fc4350680e4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b0a0cd6e_6dba8351","updated":"2021-10-13 15:47:57.000000000","message":"Please extract introducing kolla_container_engine variable into separate patch - will be easier to review.\n\nThis patch should be split into series, but that can also wait to the moment when it passes Zuul.","commit_id":"2a4479208b774bae933f1d9562a510718fc8aadc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"faebb2bc6728c112eb442abdfda688d797033045","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4bb3b50f_ed74dc91","updated":"2021-10-13 16:21:55.000000000","message":"Wow, that is a big patch.\n\nI think before we go any further with this implementation we should agree on the approach and write up a high level design. The PTG next week is the right forum in which to discuss this, and podman is listed as a topic already. Please do get involved - a change of this size is unlikely to get approved without a consensus on the approach from the core team.","commit_id":"2a4479208b774bae933f1d9562a510718fc8aadc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7bd0693e74ca53cd5be5c3a59d048308c48b255f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"898dc823_7ea0952b","in_reply_to":"4bb3b50f_ed74dc91","updated":"2021-10-13 16:35:11.000000000","message":"I\u0027ve added some comments in the PTG etherpad: https://etherpad.opendev.org/p/kolla-yoga-ptg","commit_id":"2a4479208b774bae933f1d9562a510718fc8aadc"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"f7d06c1e170529f51b57e747f329067d789d54a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"362cd06d_603970db","in_reply_to":"97cad2ee_423057ec","updated":"2022-11-27 12:42:09.000000000","message":"Solved in separate patchset.","commit_id":"2a4479208b774bae933f1d9562a510718fc8aadc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a185a0f30804d9814211f2f6e017ff4322c62f3f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"97cad2ee_423057ec","in_reply_to":"b0a0cd6e_6dba8351","updated":"2021-10-13 17:06:54.000000000","message":"We also don\u0027t need to repeat this all over the place. Our modules can consume an arbitrary variable already.","commit_id":"2a4479208b774bae933f1d9562a510718fc8aadc"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"ba787426bc4a049c7287255c91815b1e431b8912","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"194ec1e8_349a5f6b","updated":"2022-03-31 12:06:28.000000000","message":"I\u0027ve noticed a lot of places the this style for doing ternary operations,\n\n {{ \u0027primary_text_value\u0027 if (some_condition \u003d\u003d false) else \u0027alternate_text_value\u0027 }}\n\nand while foreign to me they seem to work just fine. But I got a bit curious when I came across this particular one. And it doesn\u0027t seem to work as intended, here\u0027s a quick test-case;\n\n ---\n - name: test\n   hosts: localhost\n   vars:\n     kolla_container_engine: docker\n     #docker_runtime_directory: /test\n   tasks:\n     - debug:\n         msg: \"Path: {{ docker_runtime_directory or \u0027/var/lib/docker\u0027 if \n kolla_container_engine\u003d\u003d\u0027docker\u0027 else \u0027/var/lib/containers/storage\u0027 }}\"\n\nShould this style perhaps be changed to\n\n {{ (kolla_container_engine \u003d\u003d \u0027docker\u0027) | ternary(docker_runtime_directory | default(\u0027/var/lib/docker\u0027), \u0027/var/lib/containers/storage\u0027) }}\n\nI\u0027m new to kolla-ansible, so just checking in. Really excited to see podman support! :)","commit_id":"33deec1415e0039fbfe9000907947a436ffc9a5c"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"886152f4b4098c3aef8eea62ffca92d32fff5ca4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4caa7745_3374aadb","updated":"2022-03-10 11:03:35.000000000","message":"planned to do more detailed review but life called ;(","commit_id":"33deec1415e0039fbfe9000907947a436ffc9a5c"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e31646a9_736df958","in_reply_to":"4caa7745_3374aadb","updated":"2022-10-27 11:43:49.000000000","message":"Done","commit_id":"33deec1415e0039fbfe9000907947a436ffc9a5c"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"aed4ce15f3201f76c36594c1feee058e868d6345","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"4473291e_bf011db1","updated":"2022-09-01 07:09:27.000000000","message":"Please alse resolve review comments which are already incorporated.","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"28d10c9e48852f279c006ce515a639ad587388dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"09e27310_b32a750c","updated":"2022-10-19 10:59:50.000000000","message":"This patch is HUGE (+5407 -2027 lines). Would be nice if you can split it into (easier to review) parts.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"cc486c28_5a51c7bd","in_reply_to":"09e27310_b32a750c","updated":"2022-10-19 11:18:56.000000000","message":"Possible split:\n\n1. introduce \u0027kolla_container_engine\u0027 variable with \u0027docker\u0027 in it\n2. move adding \u0027common_options\u0027 to separate patch\n3. change in ansible/roles/common/handlers/main.yml feels like can be done separate too (after 1st)\n4. ansible/library ansible/module_utils etc. (here you can decide should it go as all-in-one on can be split)\n\nThis way patches 1-3 prepare ground for the real change.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"cbc63e423c8705030cf7e7faf3afe641f8c94680","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"0e23252f_336fae96","in_reply_to":"09e27310_b32a750c","updated":"2022-10-19 11:17:19.000000000","message":"We use this patch mostly to check and store our overall progress with full podman support. It is also being gradually split with current patch in focus being Systemd Container Control: https://review.opendev.org/c/openstack/kolla-ansible/+/816724","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"45380f55b27479ac7e782da3d96e51329aee4c14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"3019dc37_fa10261e","updated":"2023-02-20 15:48:17.000000000","message":"recheck","commit_id":"5500baf961c5688de9b85d5f449e89e1a7878b3f"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"65b9d063b41bb265df5ea5daa7ff4520505e2739","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":50,"id":"9c2f7624_8ceb2949","updated":"2023-03-01 10:25:57.000000000","message":"recheck","commit_id":"df20bbf64c140aaff29e7d309117f068d22963c2"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"8f5e4443b460426ca9040231e28af13305d50825","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":53,"id":"317e564c_eee5d49e","updated":"2023-03-24 12:27:58.000000000","message":"recheck","commit_id":"16f5c1dfb3b8b67d72ee145d7f0a0e5d22cd41cb"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"369eed4ad91d0a0433386ee1f76b02ee87d9730e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":55,"id":"1fea8883_4b0567c1","updated":"2023-03-29 10:36:13.000000000","message":"recheck","commit_id":"7dde8bdda2461d0b293c782e586e0bc26d62b981"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"ee439af44f79d892bafe76b4f45326e69060e4c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"7681895b_4d15ed0a","updated":"2023-04-13 12:25:04.000000000","message":"recheck","commit_id":"8312963edfa596d091ba7c023026fdf627d71243"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c873fb43afa4416023f3356784f0a3e5d683ba0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":71,"id":"02914d03_7acbe0dd","updated":"2023-06-27 16:21:42.000000000","message":"in general looks good to me.\n\nthis is of course still missing release notes.\n\nthese should contain at least the minimum and maximum supported podman versions\nand maybe even extend the currently available support matrix for container engines, if that makes sense?","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"db6c3346f69cc19670dd74f3d2a5ed75c4764ea3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"76db71af_a43b6217","updated":"2023-08-22 15:57:18.000000000","message":"recheck","commit_id":"cc5574cf9a98a4bd4b2ce1d82d8cfeb0374f7094"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"73a9e3f0ce8f724af84a0a2057f4c7103878ad76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":81,"id":"ec6d2915_1a4ee817","updated":"2023-08-24 13:25:41.000000000","message":"recheck","commit_id":"cc5574cf9a98a4bd4b2ce1d82d8cfeb0374f7094"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ef9e04bb45adfff6760232d83d95f40054af52c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":88,"id":"204445d8_fdc73000","updated":"2023-09-01 13:52:54.000000000","message":"Missing relnotes, like Michal noticed, good catch!","commit_id":"e81aa71e4be6d0efd633b2794be70046694f85ba"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5fe4a3f06782648ce137785e841faf1249caf508","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":88,"id":"49b865b8_cdf5fb88","updated":"2023-09-01 09:20:09.000000000","message":"We need to understand why aarch64 is failing on permission denied.","commit_id":"e81aa71e4be6d0efd633b2794be70046694f85ba"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"aac7b0a864ee77e5fc3cb9bbd1cc8d97185ce39a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":88,"id":"72c2a6ae_a7cd5577","in_reply_to":"204445d8_fdc73000","updated":"2023-09-04 11:13:03.000000000","message":"Release note added.","commit_id":"e81aa71e4be6d0efd633b2794be70046694f85ba"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4a79a0c9238d4cce1c4cf107f8276cdce7378a77","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":89,"id":"a72149ec_2ca89caa","updated":"2023-09-04 12:39:20.000000000","message":"not sure, but:\n\nshould this change also update the documentation?\n\nit\u0027s littered with docker specific stuff.\n\nor should this be done in a separate change?","commit_id":"602ba3ffb16ae5965f6e7fe80f0dbfb562736f51"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2fabdb1d2417f13e821594dc8df356905d725a62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":89,"id":"8d7dbf52_ff299984","in_reply_to":"a72149ec_2ca89caa","updated":"2023-09-11 08:52:12.000000000","message":"after discussion with frickler, we think the docs could be changed in a separate changeset.","commit_id":"602ba3ffb16ae5965f6e7fe80f0dbfb562736f51"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b69bab069446c19aadfe99227a8d14c75bf394fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":91,"id":"5d618a6b_46e36c18","updated":"2023-09-07 08:46:37.000000000","message":"recheck aarch64","commit_id":"71e0467a37fb0d3b5f29d2889185363aa80dd8d3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dfa2db754a311d08b84a2d090d03328a97acd6e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":93,"id":"d7a0c293_547a1db9","updated":"2023-09-11 08:52:46.000000000","message":"checking CI failure..","commit_id":"a105f3b56890e89b7213d96bf054e157dde77b59"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b149e0d0972956a857ddfc6c278799271f5a2edd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":94,"id":"c7c8f8a4_98b0591f","updated":"2023-09-12 00:39:03.000000000","message":"We need to merge https://review.opendev.org/c/openstack/kolla/+/825791 so we will have podman support in kolla. Then I hope I have a fix for kolla-ansible aarch64 podman.\n\nBut - I need to test it, so I need to add Depends-On kolla patch, but if I do this, it will trigger build from kolla via podman - which is still not merged in kolla.","commit_id":"2c8c2a6286b4fc23ef96a7f7b1150c2478c351fb"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"476559cc1457a277b9c25ed2b7e3ff35be04af06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":97,"id":"ae44f1ee_51b5fe00","updated":"2023-09-28 08:48:42.000000000","message":"just need to please the zuul god now 😊","commit_id":"77b803eb3294b50ab646b3b51e4d445cfdbc0d10"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"20dbdf206facd1647f9f507749fccd715b6749f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":97,"id":"74b09d99_7fbdf3ef","updated":"2023-10-06 13:42:44.000000000","message":"recheck new collections available","commit_id":"77b803eb3294b50ab646b3b51e4d445cfdbc0d10"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"78066304a03a2205400da5805a483fff0f091eff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":98,"id":"3a89492c_a24912fe","updated":"2023-10-11 07:28:14.000000000","message":"Build failure in:\n\n```\nTASK [neutron : Get container volume facts] ************************************\n\ntask path: /home/zuul/kolla-ansible-venv/share/kolla-ansible/ansible/roles/neutron/tasks/neutron_plugin_agent_check.yml:12\n\nMonday 09 October 2023  15:00:32 +0000 (0:00:00.490)       0:01:19.445 ******** \n\nUsing module file /home/zuul/kolla-ansible-venv/share/kolla-ansible/ansible/library/kolla_container_volume_facts.py\n\nPipelining is enabled.\n\n\u003c172.99.67.79\u003e ESTABLISH SSH CONNECTION FOR USER: None\n\n\u003c172.99.67.79\u003e SSH: EXEC ssh -C -o ControlMaster\u003dauto -o ControlPersist\u003d60s -o StrictHostKeyChecking\u003dno -o KbdInteractiveAuthentication\u003dno -o PreferredAuthentications\u003dgssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication\u003dno -o ConnectTimeout\u003d10 -o \u0027ControlPath\u003d\"/home/zuul/.ansible/cp/115ab8490d\"\u0027 172.99.67.79 \u0027/bin/sh -c \u0027\"\u0027\"\u0027sudo -H -S -n  -u root /bin/sh -c \u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027echo BECOME-SUCCESS-yynhjamnsaxpaqnyjqqeojktndlwhxil ; /usr/bin/python3\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027 \u0026\u0026 sleep 0\u0027\"\u0027\"\u0027\u0027\n\nEscalation succeeded\n\n\u003c172.99.67.79\u003e (1, b\u0027\u0027, b\u0027Traceback (most recent call last):\\n  File \"/usr/lib/python3/dist-packages/podman/api/uds.py\", line 40, in connect\\n    super().connect(netloc)\\nFileNotFoundError: [Errno 2] No such file or directory\\n\\nThe above exception was the direct cause of the following exception:\\n\\nTraceback (most recent call last):\\n  File \"/usr/lib/python3/dist-packages/urllib3/connectionpool.py\", line 715, in urlopen\\n    httplib_response \u003d self._make_request(\\n                       ^^^^^^^^^^^^^^^^^^^\\n  File \"/usr/lib/python3/dist-packages/urllib3/connectionpool.py\", line 416, in _make_request\\n    conn.request(method, url, **httplib_request_kw)\\n  File \"/usr/lib/python3/dist-packages/urllib3/connection.py\", line 244, in request\\n    super(HTTPConnection, self).request(method, url, body\u003dbody, headers\u003dheaders)\\n  File \"/usr/lib/python3.11/http/client.py\", line 1282, in request\\n    self._send_request(method, url, body, headers, encode_chunked)\\n  File \"/usr/lib/python3.11/http/client.py\", line 1328, in _send_request\\n    self.endheaders(body, encode_chunked\u003dencode_chunked)\\n  File \"/usr/lib/python3.11/http/client.py\", line 1277, in endheaders\\n    self._send_output(message_body, encode_chunked\u003dencode_chunked)\\n  File \"/usr/lib/python3.11/http/client.py\", line 1037, in _send_output\\n    self.send(msg)\\n  File \"/usr/lib/python3.11/http/client.py\", line 975, in send\\n    self.connect()\\n  File \"/usr/lib/python3/dist-packages/podman/api/uds.py\", line 85, in connect\\n    sock.connect()\\n  File \"/usr/lib/python3/dist-packages/podman/api/uds.py\", line 42, in connect\\n    raise APIError(f\"Unable to make connection to UDS \\\u0027{netloc}\\\u0027\") from e\\npodman.errors.exceptions.APIError: Unable to make connection to UDS \\\u0027/tmp/pyxdg-runtime-dir-fallback-root/podman/podman.sock\\\u0027\\n\\nDuring handling of the above exception, another exception occurred:\\n\\nTraceback (most recent call last):\\n  File \"/usr/lib/python3/dist-packages/requests/adapters.py\", line 486, in send\\n    resp \u003d conn.urlopen(\\n           ^^^^^^^^^^^^^\\n  File \"/usr/lib/python3/dist-packages/urllib3/connectionpool.py\", line 799, in urlopen\\n    retries \u003d retries.increment(\\n              ^^^^^^^^^^^^^^^^^^\\n  File \"/usr/lib/python3/dist-packages/urllib3/util/retry.py\", line 550, in increment\\n    raise six.reraise(type(error), error, _stacktrace)\\n          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\\n  File \"/usr/lib/python3/dist-packages/six.py\", line 718, in reraise\\n    raise value.with_traceback(tb)\\n  File \"/usr/lib/python3/dist-packages/urllib3/connectionpool.py\", line 715, in urlopen\\n    httplib_response \u003d self._make_request(\\n                       ^^^^^^^^^^^^^^^^^^^\\n  File \"/usr/lib/python3/dist-packages/urllib3/connectionpool.py\", line 416, in _make_request\\n    conn.request(method, url, **httplib_request_kw)\\n  File \"/usr/lib/python3/dist-packages/urllib3/connection.py\", line 244, in request\\n    super(HTTPConnection, self).request(method, url, body\u003dbody, headers\u003dheaders)\\n  File \"/usr/lib/python3.11/http/client.py\", line 1282, in request\\n    self._send_request(method, url, body, headers, encode_chunked)\\n  File \"/usr/lib/python3.11/http/client.py\", line 1328, in _send_request\\n    self.endheaders(body, encode_chunked\u003dencode_chunked)\\n  File \"/usr/lib/python3.11/http/client.py\", line 1277, in endheaders\\n    self._send_output(message_body, encode_chunked\u003dencode_chunked)\\n  File \"/usr/lib/python3.11/http/client.py\", line 1037, in _send_output\\n    self.send(msg)\\n  File \"/usr/lib/python3.11/http/client.py\", line 975, in send\\n    self.connect()\\n  File \"/usr/lib/python3/dist-packages/podman/api/uds.py\", line 85, in connect\\n    sock.connect()\\n  File \"/usr/lib/python3/dist-packages/podman/api/uds.py\", line 42, in connect\\n    raise APIError(f\"Unable to make connection to UDS \\\u0027{netloc}\\\u0027\") from e\\nurllib3.exceptions.ProtocolError: (\\\u0027Connection aborted.\\\u0027, APIError(\"Unable to make connection to UDS \\\u0027/tmp/pyxdg-runtime-dir-fallback-root/podman/podman.sock\\\u0027\"))\\n\\nDuring handling of the above exception, another exception occurred:\\n\\nTraceback (most recent call last):\\n  File \"/usr/lib/python3/dist-packages/podman/api/client.py\", line 404, in _request\\n    self.request(\\n  File \"/usr/lib/python3/dist-packages/requests/sessions.py\", line 589, in request\\n    resp \u003d self.send(prep, **send_kwargs)\\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\\n  File \"/usr/lib/python3/dist-packages/requests/sessions.py\", line 703, in send\\n    r \u003d adapter.send(request, **kwargs)\\n        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\\n  File \"/usr/lib/python3/dist-packages/requests/adapters.py\", line 501, in send\\n    raise ConnectionError(err, request\u003drequest)\\nrequests.exceptions.ConnectionError: (\\\u0027Connection aborted.\\\u0027, APIError(\"Unable to make connection to UDS \\\u0027/tmp/pyxdg-runtime-dir-fallback-root/podman/podman.sock\\\u0027\"))\\n\\nThe above exception was the direct cause of the following exception:\\n\\nTraceback (most recent call last):\\n  File \"\u003cstdin\u003e\", line 107, in \u003cmodule\u003e\\n  File \"\u003cstdin\u003e\", line 99, in _ansiballz_main\\n  File \"\u003cstdin\u003e\", line 47, in invoke_module\\n  File \"\u003cfrozen runpy\u003e\", line 226, in run_module\\n  File \"\u003cfrozen runpy\u003e\", line 98, in _run_module_code\\n  File \"\u003cfrozen runpy\u003e\", line 88, in _run_code\\n  File \"/tmp/ansible_kolla_container_volume_facts_payload_4icvih3x/ansible_kolla_container_volume_facts_payload.zip/ansible/modules/kolla_container_volume_facts.py\", line 108, in \u003cmodule\u003e\\n  File \"/tmp/ansible_kolla_container_volume_facts_payload_4icvih3x/ansible_kolla_container_volume_facts_payload.zip/ansible/modules/kolla_container_volume_facts.py\", line 93, in main\\n  File \"/tmp/ansible_kolla_container_volume_facts_payload_4icvih3x/ansible_kolla_container_volume_facts_payload.zip/ansible/modules/kolla_container_volume_facts.py\", line 75, in get_podman_volumes\\n  File \"/usr/lib/python3/dist-packages/podman/domain/volumes.py\", line 105, in list\\n    response \u003d self.client.get(\"/volumes/json\", params\u003d{\"filters\": filters})\\n               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\\n  File \"/usr/lib/python3/dist-packages/podman/api/client.py\", line 236, in get\\n    return self._request(\\n           ^^^^^^^^^^^^^^\\n  File \"/usr/lib/python3/dist-packages/podman/api/client.py\", line 415, in _request\\n    raise APIError(uri.geturl(), explanation\u003df\"{method.upper()} operation failed\") from e\\npodman.errors.exceptions.APIError: http://%2Ftmp%2Fpyxdg-runtime-dir-fallback-root%2Fpodman%2Fpodman.sock/v4.7.0/libpod/volumes/json (GET operation failed)\\n\u0027)\n\n\u003c172.99.67.79\u003e Failed to connect to the host via ssh: Traceback (most recent call last):\n\n  File \"/usr/lib/python3/dist-packages/podman/api/uds.py\", line 40, in connect\n\n    super().connect(netloc)\n\nFileNotFoundError: [Errno 2] No such file or directory\n\n[...]\n\npodman.errors.exceptions.APIError: Unable to make connection to UDS \u0027/tmp/pyxdg-runtime-dir-fallback-root/podman/podman.sock\u0027\n```\n\nin: https://zuul.opendev.org/t/openstack/build/4c39c434bd1a4fada989f66541cef85b/log/primary/logs/ansible/deploy-prechecks","commit_id":"4d7d29bb979c2f5213831ca060915e5a4001655a"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"4f30d70fb9ae5bb3d889eaa78d887fe7e8ee5a2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":98,"id":"aa398030_667340a7","in_reply_to":"1043c4e4_58876b54","updated":"2023-10-16 10:15:05.000000000","message":"Fixed now.","commit_id":"4d7d29bb979c2f5213831ca060915e5a4001655a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f3e280e5ae56b54cc9d8721a94d2026e300014ce","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":98,"id":"1043c4e4_58876b54","in_reply_to":"3a89492c_a24912fe","updated":"2023-10-11 07:28:59.000000000","message":"marking as unresolved, it looks likely that it\u0027s related to the change.","commit_id":"4d7d29bb979c2f5213831ca060915e5a4001655a"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"de048219da4c6164db0d0462082d21eccf55264e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":99,"id":"1db734a5_5fe8b883","updated":"2023-10-12 14:15:09.000000000","message":"recheck","commit_id":"1fe2828db734858d79c45d8449c2ab6ae1506c72"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"5b56fa304fae12c8da3b224e1f076f7f8fb5b78f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":100,"id":"440f3c44_79a3e1c1","updated":"2023-10-13 07:26:48.000000000","message":"recheck","commit_id":"fca6838c5a32d25e2dd48c54050c051655ae96f6"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"0d2921719b1d76d3e7640e86637c691d063499c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":101,"id":"f63ccd73_0a3b051c","updated":"2023-10-13 11:04:35.000000000","message":"Sven, we give it +2 ;)","commit_id":"a3454cd5a4677511e0aa1760fbe6729ae7289968"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"04c32ce5c878633a80f8337b16bbfaa651213fef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":106,"id":"b5f5bcc1_98db2de7","updated":"2023-10-19 15:25:36.000000000","message":"agree with frickler on jobs: either add gate jobs or make the jobs non voting.\n\nI\u0027d vouch for adding gate jobs so we are sure the feature actually works.","commit_id":"d3eac801ff2cccbc1a0dd3516f3f206572a41172"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9f6695ceaf0725a48d505bc2fd542be744c32ccb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":106,"id":"e0e69bcf_d81c6826","updated":"2023-10-19 14:42:25.000000000","message":"also a rebase is needed","commit_id":"d3eac801ff2cccbc1a0dd3516f3f206572a41172"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"71603837d45af9f13f31c34651800058ba0e272b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":108,"id":"c1f94518_688d1cbf","updated":"2023-10-19 19:09:21.000000000","message":"rebased","commit_id":"987bace493fa8018928c149182db343dc5d5370d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9c16fa3ba5aa5bfa0156a855f91c826bf2b49128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":112,"id":"47d51d09_026c5873","updated":"2023-10-20 10:37:27.000000000","message":"Hmm, probably rebased wrong ? :/ Thanks frickler","commit_id":"727b8d40ff6df47de62168d597ea71b0be4442a8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"544f4145b6813bfaed0c509bc84c4889501d35db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":112,"id":"bc09c9f2_0563d18c","updated":"2023-10-20 12:55:15.000000000","message":"actually let me still fix some bits, just waiting for CI results to roll in","commit_id":"727b8d40ff6df47de62168d597ea71b0be4442a8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5d767d10bec68a05b2662efb2e83ef23b8368936","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":112,"id":"6cccd056_d114be22","updated":"2023-10-20 12:53:37.000000000","message":"fwiw this is now PS106 again, just rebased off of a patch that was already merged","commit_id":"727b8d40ff6df47de62168d597ea71b0be4442a8"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"412dfcea4af36aeac90ade7a1b47ad8a5b51c753","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":113,"id":"2b63703d_79c0bfde","updated":"2023-10-24 15:58:51.000000000","message":"This has been a long time coming, congratulations🎉","commit_id":"9a3f46334506d655f302ebe4abcd23df7540bd80"}],"ansible/library/kolla_container_facts.py":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fe40f4fb9f1d4032bbcc4e7939f4100090f329fa","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    type: str or list"},{"line_number":43,"context_line":"  container_engine:"},{"line_number":44,"context_line":"    description:"},{"line_number":45,"context_line":"      - Name of container engine to use"},{"line_number":46,"context_line":"    required: True"},{"line_number":47,"context_line":"    type: str"},{"line_number":48,"context_line":"author: Jeffrey Zhang"}],"source_content_type":"text/x-python","patch_set":63,"id":"83b40515_2731e61d","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":39},"updated":"2023-04-19 15:47:52.000000000","message":"I would add: \"currently supported engines are `docker` and `podman`\"","commit_id":"8312963edfa596d091ba7c023026fdf627d71243"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"a81405600bf615a89ad08ccce7ac0384fd49033d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    type: str or list"},{"line_number":43,"context_line":"  container_engine:"},{"line_number":44,"context_line":"    description:"},{"line_number":45,"context_line":"      - Name of container engine to use"},{"line_number":46,"context_line":"    required: True"},{"line_number":47,"context_line":"    type: str"},{"line_number":48,"context_line":"author: Jeffrey Zhang"}],"source_content_type":"text/x-python","patch_set":63,"id":"461f0611_e84857ed","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":39},"in_reply_to":"83b40515_2731e61d","updated":"2023-04-20 14:25:57.000000000","message":"Done","commit_id":"8312963edfa596d091ba7c023026fdf627d71243"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fe40f4fb9f1d4032bbcc4e7939f4100090f329fa","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    description:"},{"line_number":45,"context_line":"      - Name of container engine to use"},{"line_number":46,"context_line":"    required: True"},{"line_number":47,"context_line":"    type: str"},{"line_number":48,"context_line":"author: Jeffrey Zhang"},{"line_number":49,"context_line":"\u0027\u0027\u0027"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"fdaf107c_6df463b9","line":47,"updated":"2023-04-19 15:47:52.000000000","message":"shouldn\u0027t we add a default (docker) here if it is required?","commit_id":"8312963edfa596d091ba7c023026fdf627d71243"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"a81405600bf615a89ad08ccce7ac0384fd49033d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    description:"},{"line_number":45,"context_line":"      - Name of container engine to use"},{"line_number":46,"context_line":"    required: True"},{"line_number":47,"context_line":"    type: str"},{"line_number":48,"context_line":"author: Jeffrey Zhang"},{"line_number":49,"context_line":"\u0027\u0027\u0027"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"51daa164_a5ffaaf3","line":47,"in_reply_to":"fdaf107c_6df463b9","updated":"2023-04-20 14:25:57.000000000","message":"Done","commit_id":"8312963edfa596d091ba7c023026fdf627d71243"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c873fb43afa4416023f3356784f0a3e5d683ba0","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    except pe.APIError as e:"},{"line_number":99,"context_line":"        module.fail_json(failed\u003dTrue, msg\u003df\"Internal error: {e.explanation}\")"},{"line_number":100,"context_line":"    names \u003d module.params.get(\u0027name\u0027)"},{"line_number":101,"context_line":"    if names and not isinstance(names, list):"},{"line_number":102,"context_line":"        names \u003d [names]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    for container in containers:"},{"line_number":105,"context_line":"        container.reload()"},{"line_number":106,"context_line":"        container_name \u003d container.attrs[\u0027Name\u0027]"},{"line_number":107,"context_line":"        if container_name not in names:"},{"line_number":108,"context_line":"            continue"},{"line_number":109,"context_line":"        results[\u0027_containers\u0027].append(container.attrs)"},{"line_number":110,"context_line":"        results[container_name] \u003d container.attrs"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":71,"id":"89f6a72e_6f5459cc","line":110,"range":{"start_line":101,"start_character":0,"end_line":110,"end_character":49},"updated":"2023-06-27 16:21:42.000000000","message":"for the record: we have some code duplication here between use_podman and use_docker, but it\u0027s subtle enough in the differences that I have no good idea how to merge some/all of it together.","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"52af5b31811718b89e7dc1d1d916c16540547184","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    client \u003d PodmanClient(base_url\u003d\"unix:/run/podman/podman.sock\")"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    try:"},{"line_number":97,"context_line":"        containers \u003d client.containers.list(all\u003dTrue, ignore_removed\u003dTrue)"},{"line_number":98,"context_line":"    except pe.APIError as e:"},{"line_number":99,"context_line":"        module.fail_json(failed\u003dTrue, msg\u003df\"Internal error: {e.explanation}\")"},{"line_number":100,"context_line":"    names \u003d module.params.get(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":78,"id":"bf627f02_803ea00a","line":97,"updated":"2023-08-21 09:33:10.000000000","message":"this apparently raised an api error in this test somehow:\n\nhttps://zuul.opendev.org/t/openstack/build/45f8150501e549aca739790997d6beaf/log/primary/logs/ansible/deploy-prechecks#5394\n\n```\n\u003c172.99.67.162\u003e SSH: EXEC ssh -C -o ControlMaster\u003dauto -o ControlPersist\u003d60s -o StrictHostKeyChecking\u003dno -o KbdInteractiveAuthentication\u003dno -o PreferredAuthentications\u003dgssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication\u003dno -o ConnectTimeout\u003d10 -o \u0027ControlPath\u003d\"/home/zuul/.ansible/cp/622be34da4\"\u0027 172.99.67.162 \u0027/bin/sh -c \u0027\"\u0027\"\u0027sudo -H -S -n  -u root /bin/sh -c \u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027echo BECOME-SUCCESS-swtxerwogbjjpmonzujqteooglwkbgyn ; /usr/bin/python3\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027 \u0026\u0026 sleep 0\u0027\"\u0027\"\u0027\u0027\n\nEscalation succeeded\n\n\u003c172.99.67.162\u003e (1, b\u0027\\n{\"failed\": true, \"msg\": \"Internal error: GET operation failed\", \"exception\": \"  File \\\\\"/tmp/ansible_kolla_container_facts_payload_1dl8j313/ansible_kolla_container_facts_payload.zip/ansible/modules/kolla_container_facts.py\\\\\", line 97, in use_podman\\\\n  File \\\\\"/usr/local/lib/python3.9/site-packages/podman/domain/containers_manager.py\\\\\", line 87, in list\\\\n    response \u003d self.client.get(\\\\\"/containers/json\\\\\", params\u003dparams)\\\\n  File \\\\\"/usr/local/lib/python3.9/site-packages/podman/api/client.py\\\\\", line 236, in get\\\\n    return self._request(\\\\n  File \\\\\"/usr/local/lib/python3.9/site-packages/podman/api/client.py\\\\\", line 415, in _request\\\\n    raise APIError(uri.geturl(), explanation\u003df\\\\\"{method.upper()} operation failed\\\\\") from e\\\\n\", \"invocation\": {\"module_args\": {\"container_engine\": \"podman\", \"name\": [\"haproxy\", \"proxysql\", \"keepalived\"], \"api_version\": \"auto\"}}}\\n\u0027, b\u0027\u0027)\n\n\u003c172.99.67.162\u003e Failed to connect to the host via ssh: \n\nThe full traceback is:\n\n  File \"/tmp/ansible_kolla_container_facts_payload_1dl8j313/ansible_kolla_container_facts_payload.zip/ansible/modules/kolla_container_facts.py\", line 97, in use_podman\n\n  File \"/usr/local/lib/python3.9/site-packages/podman/domain/containers_manager.py\", line 87, in list\n\n    response \u003d self.client.get(\"/containers/json\", params\u003dparams)\n\n  File \"/usr/local/lib/python3.9/site-packages/podman/api/client.py\", line 236, in get\n\n    return self._request(\n\n  File \"/usr/local/lib/python3.9/site-packages/podman/api/client.py\", line 415, in _request\n\n    raise APIError(uri.geturl(), explanation\u003df\"{method.upper()} operation failed\") from e\n\nfatal: [primary]: FAILED! \u003d\u003e {\n\n    \"changed\": false,\n\n    \"invocation\": {\n\n        \"module_args\": {\n\n            \"api_version\": \"auto\",\n\n            \"container_engine\": \"podman\",\n\n            \"name\": [\n\n                \"haproxy\",\n\n                \"proxysql\",\n\n                \"keepalived\"\n\n            ]\n\n        }\n\n    },\n\n    \"msg\": \"Internal error: GET operation failed\"\n\n}\n\n```","commit_id":"d9bfcf3c0ce0999eec7ac9c5b08d37da0916d6cf"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"50a9db279e18f0d5c1fc53797cd38fdae4179e09","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    client \u003d PodmanClient(base_url\u003d\"unix:/run/podman/podman.sock\")"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    try:"},{"line_number":97,"context_line":"        containers \u003d client.containers.list(all\u003dTrue, ignore_removed\u003dTrue)"},{"line_number":98,"context_line":"    except pe.APIError as e:"},{"line_number":99,"context_line":"        module.fail_json(failed\u003dTrue, msg\u003df\"Internal error: {e.explanation}\")"},{"line_number":100,"context_line":"    names \u003d module.params.get(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":78,"id":"31bbc851_0dd12457","line":97,"in_reply_to":"8c1633b6_663fec6c","updated":"2023-08-23 15:02:48.000000000","message":"Issue was with incorrect handling if adding linux capabilities to Podman config file, which resulted in a invalid config and Podman stopping to function.\nCapabilities used to be added in ansible-collection-kolla, now they are added inside the PodmanWorker class.","commit_id":"d9bfcf3c0ce0999eec7ac9c5b08d37da0916d6cf"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"d5cf532d903d94a9e7240c4a889d770d236e7cce","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    client \u003d PodmanClient(base_url\u003d\"unix:/run/podman/podman.sock\")"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    try:"},{"line_number":97,"context_line":"        containers \u003d client.containers.list(all\u003dTrue, ignore_removed\u003dTrue)"},{"line_number":98,"context_line":"    except pe.APIError as e:"},{"line_number":99,"context_line":"        module.fail_json(failed\u003dTrue, msg\u003df\"Internal error: {e.explanation}\")"},{"line_number":100,"context_line":"    names \u003d module.params.get(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":78,"id":"8c1633b6_663fec6c","line":97,"in_reply_to":"bf627f02_803ea00a","updated":"2023-08-21 09:37:59.000000000","message":"yes, but problem is that podman-py doesn÷t show what kind of error it is because it has hardcoded that it is method.upper() error which I highly doubt is the problem. Also thing I don\u0027t understand is that it was working some patches ago without problem.","commit_id":"d9bfcf3c0ce0999eec7ac9c5b08d37da0916d6cf"}],"ansible/library/kolla_container_volume_facts.py":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"95126f52b287de7b31d6864e6c1b47dd3f7c168d","unresolved":true,"context_lines":[{"line_number":70,"context_line":"def get_podman_volumes():"},{"line_number":71,"context_line":"    from podman import PodmanClient"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    client \u003d PodmanClient(base_url\u003d\"unix:/run/podman/podman.sock\")"},{"line_number":74,"context_line":"    volumes \u003d []"},{"line_number":75,"context_line":"    for volume in client.volumes.list():"},{"line_number":76,"context_line":"        volumes.append(volume.attrs)"}],"source_content_type":"text/x-python","patch_set":101,"id":"fb49e4fa_d7ac70bd","line":73,"range":{"start_line":73,"start_character":41,"end_line":73,"end_character":42},"updated":"2023-10-13 11:04:01.000000000","message":"//","commit_id":"a3454cd5a4677511e0aa1760fbe6729ae7289968"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"95126f52b287de7b31d6864e6c1b47dd3f7c168d","unresolved":true,"context_lines":[{"line_number":70,"context_line":"def get_podman_volumes():"},{"line_number":71,"context_line":"    from podman import PodmanClient"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    client \u003d PodmanClient(base_url\u003d\"unix:/run/podman/podman.sock\")"},{"line_number":74,"context_line":"    volumes \u003d []"},{"line_number":75,"context_line":"    for volume in client.volumes.list():"},{"line_number":76,"context_line":"        volumes.append(volume.attrs)"}],"source_content_type":"text/x-python","patch_set":101,"id":"96446619_92b163b6","line":73,"range":{"start_line":73,"start_character":26,"end_line":73,"end_character":66},"updated":"2023-10-13 11:04:01.000000000","message":"and btw, this is by default: https://github.com/containers/podman-py/blob/main/podman/client.py#L73","commit_id":"a3454cd5a4677511e0aa1760fbe6729ae7289968"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"95126f52b287de7b31d6864e6c1b47dd3f7c168d","unresolved":true,"context_lines":[{"line_number":70,"context_line":"def get_podman_volumes():"},{"line_number":71,"context_line":"    from podman import PodmanClient"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    client \u003d PodmanClient(base_url\u003d\"unix:/run/podman/podman.sock\")"},{"line_number":74,"context_line":"    volumes \u003d []"},{"line_number":75,"context_line":"    for volume in client.volumes.list():"},{"line_number":76,"context_line":"        volumes.append(volume.attrs)"}],"source_content_type":"text/x-python","patch_set":101,"id":"06cb9711_9c8d3dbe","line":73,"range":{"start_line":73,"start_character":36,"end_line":73,"end_character":40},"updated":"2023-10-13 11:04:01.000000000","message":"http+unix ?","commit_id":"a3454cd5a4677511e0aa1760fbe6729ae7289968"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"4f30d70fb9ae5bb3d889eaa78d887fe7e8ee5a2f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"def get_podman_volumes():"},{"line_number":71,"context_line":"    from podman import PodmanClient"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    client \u003d PodmanClient(base_url\u003d\"unix:/run/podman/podman.sock\")"},{"line_number":74,"context_line":"    volumes \u003d []"},{"line_number":75,"context_line":"    for volume in client.volumes.list():"},{"line_number":76,"context_line":"        volumes.append(volume.attrs)"}],"source_content_type":"text/x-python","patch_set":101,"id":"4c6c84b0_bdfe0c55","line":73,"range":{"start_line":73,"start_character":36,"end_line":73,"end_character":40},"in_reply_to":"06cb9711_9c8d3dbe","updated":"2023-10-16 10:15:05.000000000","message":"Done","commit_id":"a3454cd5a4677511e0aa1760fbe6729ae7289968"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8bb6bd9810c507d9b89821e02482bd1e402bb8b0","unresolved":true,"context_lines":[{"line_number":70,"context_line":"def get_podman_volumes():"},{"line_number":71,"context_line":"    from podman import PodmanClient"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    client \u003d PodmanClient(base_url\u003d\"unix:/run/podman/podman.sock\")"},{"line_number":74,"context_line":"    volumes \u003d []"},{"line_number":75,"context_line":"    for volume in client.volumes.list():"},{"line_number":76,"context_line":"        volumes.append(volume.attrs)"}],"source_content_type":"text/x-python","patch_set":101,"id":"f497b8cb_872886cd","line":73,"range":{"start_line":73,"start_character":26,"end_line":73,"end_character":66},"in_reply_to":"8c4e05f0_20cefa2b","updated":"2023-10-16 10:18:41.000000000","message":"strange. ack.","commit_id":"a3454cd5a4677511e0aa1760fbe6729ae7289968"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"4f30d70fb9ae5bb3d889eaa78d887fe7e8ee5a2f","unresolved":true,"context_lines":[{"line_number":70,"context_line":"def get_podman_volumes():"},{"line_number":71,"context_line":"    from podman import PodmanClient"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    client \u003d PodmanClient(base_url\u003d\"unix:/run/podman/podman.sock\")"},{"line_number":74,"context_line":"    volumes \u003d []"},{"line_number":75,"context_line":"    for volume in client.volumes.list():"},{"line_number":76,"context_line":"        volumes.append(volume.attrs)"}],"source_content_type":"text/x-python","patch_set":101,"id":"8c4e05f0_20cefa2b","line":73,"range":{"start_line":73,"start_character":26,"end_line":73,"end_character":66},"in_reply_to":"96446619_92b163b6","updated":"2023-10-16 10:15:05.000000000","message":"I see but it looks like it doesn\u0027t actually work. I tested it locally in interactive shell and when path was omitted it produced the GET error. Also, in here, the error was fixed when I added the path.","commit_id":"a3454cd5a4677511e0aa1760fbe6729ae7289968"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8bb6bd9810c507d9b89821e02482bd1e402bb8b0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"def get_podman_volumes():"},{"line_number":71,"context_line":"    from podman import PodmanClient"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    client \u003d PodmanClient(base_url\u003d\"unix:/run/podman/podman.sock\")"},{"line_number":74,"context_line":"    volumes \u003d []"},{"line_number":75,"context_line":"    for volume in client.volumes.list():"},{"line_number":76,"context_line":"        volumes.append(volume.attrs)"}],"source_content_type":"text/x-python","patch_set":101,"id":"e9a4b846_da6b5f0a","line":73,"range":{"start_line":73,"start_character":41,"end_line":73,"end_character":42},"in_reply_to":"a218b68f_6e45bcf5","updated":"2023-10-16 10:18:41.000000000","message":"ack.","commit_id":"a3454cd5a4677511e0aa1760fbe6729ae7289968"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"4f30d70fb9ae5bb3d889eaa78d887fe7e8ee5a2f","unresolved":true,"context_lines":[{"line_number":70,"context_line":"def get_podman_volumes():"},{"line_number":71,"context_line":"    from podman import PodmanClient"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    client \u003d PodmanClient(base_url\u003d\"unix:/run/podman/podman.sock\")"},{"line_number":74,"context_line":"    volumes \u003d []"},{"line_number":75,"context_line":"    for volume in client.volumes.list():"},{"line_number":76,"context_line":"        volumes.append(volume.attrs)"}],"source_content_type":"text/x-python","patch_set":101,"id":"a218b68f_6e45bcf5","line":73,"range":{"start_line":73,"start_character":41,"end_line":73,"end_character":42},"in_reply_to":"fb49e4fa_d7ac70bd","updated":"2023-10-16 10:15:05.000000000","message":"This also seems to produce the GET error, at least in interactive shell.","commit_id":"a3454cd5a4677511e0aa1760fbe6729ae7289968"}],"ansible/library/kolla_docker.py":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fe40f4fb9f1d4032bbcc4e7939f4100090f329fa","unresolved":true,"context_lines":[{"line_number":27,"context_line":"DOCUMENTATION \u003d \u0027\u0027\u0027"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":"module: kolla_docker"},{"line_number":30,"context_line":"short_description: Module for controlling containers"},{"line_number":31,"context_line":"description:"},{"line_number":32,"context_line":"     - A module targeting at controlling Docker as used by Kolla."},{"line_number":33,"context_line":"options:"}],"source_content_type":"text/x-python","patch_set":63,"id":"1cd90d1a_a40bf5f4","line":30,"updated":"2023-04-19 15:47:52.000000000","message":"should this file then maybe also get renamed from `kolla_docker.py` to `kolla_container.py`?","commit_id":"8312963edfa596d091ba7c023026fdf627d71243"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"a81405600bf615a89ad08ccce7ac0384fd49033d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"DOCUMENTATION \u003d \u0027\u0027\u0027"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":"module: kolla_docker"},{"line_number":30,"context_line":"short_description: Module for controlling containers"},{"line_number":31,"context_line":"description:"},{"line_number":32,"context_line":"     - A module targeting at controlling Docker as used by Kolla."},{"line_number":33,"context_line":"options:"}],"source_content_type":"text/x-python","patch_set":63,"id":"4bb56b6f_1948c31f","line":30,"in_reply_to":"1cd90d1a_a40bf5f4","updated":"2023-04-20 14:25:57.000000000","message":"IIRC long time ago we agreed to rename this module in separate patch and after this one is merged. Motivation was probably to not make this patch even bigger.","commit_id":"8312963edfa596d091ba7c023026fdf627d71243"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c873fb43afa4416023f3356784f0a3e5d683ba0","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DOCUMENTATION \u003d \u0027\u0027\u0027"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":"module: kolla_docker"},{"line_number":30,"context_line":"short_description: Module for controlling containers"},{"line_number":31,"context_line":"description:"},{"line_number":32,"context_line":"     - A module targeting at controlling Docker as used by Kolla."},{"line_number":33,"context_line":"options:"},{"line_number":34,"context_line":"  common_options:"},{"line_number":35,"context_line":"    description:"}],"source_content_type":"text/x-python","patch_set":71,"id":"16a99cb6_a4818e05","line":32,"range":{"start_line":29,"start_character":0,"end_line":32,"end_character":65},"updated":"2023-06-27 16:21:42.000000000","message":"I find this really confusing tbh:\n\n- the module still has the name \"kolla_docker\" but can also control podman, why isn\u0027t the name changed as well?\n- the short description get\u0027s altered to reflect that it can control containers in general, the long description still only mentions docker, without mentioning podman.","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"82ca9cf9c9538537a79566f986c7237c6eef0af4","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DOCUMENTATION \u003d \u0027\u0027\u0027"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":"module: kolla_docker"},{"line_number":30,"context_line":"short_description: Module for controlling containers"},{"line_number":31,"context_line":"description:"},{"line_number":32,"context_line":"     - A module targeting at controlling Docker as used by Kolla."},{"line_number":33,"context_line":"options:"},{"line_number":34,"context_line":"  common_options:"},{"line_number":35,"context_line":"    description:"}],"source_content_type":"text/x-python","patch_set":71,"id":"dfc5c7fc_5e31f33b","line":32,"range":{"start_line":29,"start_character":0,"end_line":32,"end_character":65},"in_reply_to":"16a99cb6_a4818e05","updated":"2023-06-30 08:20:40.000000000","message":"module name is not changes as it would make this change so much bigger because you would need to change it in almost every file so it was decided that we first add podman functionality to kolla_docker and then it will be refactored in playbooks to some other name. Maybe it can be done before merging this one.","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1853356844080f6abf1f7a5ea008ada5c4a231e9","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DOCUMENTATION \u003d \u0027\u0027\u0027"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":"module: kolla_docker"},{"line_number":30,"context_line":"short_description: Module for controlling containers"},{"line_number":31,"context_line":"description:"},{"line_number":32,"context_line":"     - A module targeting at controlling Docker as used by Kolla."},{"line_number":33,"context_line":"options:"},{"line_number":34,"context_line":"  common_options:"},{"line_number":35,"context_line":"    description:"}],"source_content_type":"text/x-python","patch_set":71,"id":"eaa2c2a3_9a836f50","line":32,"range":{"start_line":29,"start_character":0,"end_line":32,"end_character":65},"in_reply_to":"dfc5c7fc_5e31f33b","updated":"2023-07-03 12:45:08.000000000","message":"Ack","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c873fb43afa4416023f3356784f0a3e5d683ba0","unresolved":true,"context_lines":[{"line_number":283,"context_line":"        auth_password\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027, no_log\u003dTrue),"},{"line_number":284,"context_line":"        auth_registry\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":285,"context_line":"        auth_username\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":286,"context_line":"        command\u003ddict(required\u003dFalse, type\u003d\u0027raw\u0027),"},{"line_number":287,"context_line":"        detach\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dTrue),"},{"line_number":288,"context_line":"        labels\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict()),"},{"line_number":289,"context_line":"        name\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"}],"source_content_type":"text/x-python","patch_set":71,"id":"3fe745c9_28b6b22c","line":286,"range":{"start_line":286,"start_character":0,"end_line":286,"end_character":15},"updated":"2023-06-27 16:21:42.000000000","message":"why is this now raw?","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"82ca9cf9c9538537a79566f986c7237c6eef0af4","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        auth_password\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027, no_log\u003dTrue),"},{"line_number":284,"context_line":"        auth_registry\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":285,"context_line":"        auth_username\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":286,"context_line":"        command\u003ddict(required\u003dFalse, type\u003d\u0027raw\u0027),"},{"line_number":287,"context_line":"        detach\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dTrue),"},{"line_number":288,"context_line":"        labels\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict()),"},{"line_number":289,"context_line":"        name\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"}],"source_content_type":"text/x-python","patch_set":71,"id":"cb66b605_4cf63a88","line":286,"range":{"start_line":286,"start_character":0,"end_line":286,"end_character":15},"in_reply_to":"3fe745c9_28b6b22c","updated":"2023-06-30 08:20:40.000000000","message":"it was bcs of podman handling of command but was patched in podman API so can be restored now","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"}],"ansible/library/kolla_toolbox.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"886152f4b4098c3aef8eea62ffca92d32fff5ca4","unresolved":true,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def use_podman(module):"},{"line_number":244,"context_line":"    options \u003d \"-it -u root\""},{"line_number":245,"context_line":"    args \u003d r\u0027 \u0027.join(gen_commandline(module.params))"},{"line_number":246,"context_line":"    args \u003d args.replace(\u0027-a\u0027, \u0027-a \\\"\u0027)"},{"line_number":247,"context_line":"    command \u003d f\"podman exec { options } kolla_toolbox {args}\\\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"f1137c69_f75a2617","line":244,"range":{"start_line":244,"start_character":14,"end_line":244,"end_character":27},"updated":"2022-03-10 11:03:35.000000000","message":"are those options really needed?","commit_id":"33deec1415e0039fbfe9000907947a436ffc9a5c"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"0b7013194f118c5b49f1500a4e692fe6567b4c68","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def use_podman(module):"},{"line_number":244,"context_line":"    options \u003d \"-it -u root\""},{"line_number":245,"context_line":"    args \u003d r\u0027 \u0027.join(gen_commandline(module.params))"},{"line_number":246,"context_line":"    args \u003d args.replace(\u0027-a\u0027, \u0027-a \\\"\u0027)"},{"line_number":247,"context_line":"    command \u003d f\"podman exec { options } kolla_toolbox {args}\\\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"458f10dd_b3225a6e","line":244,"range":{"start_line":244,"start_character":14,"end_line":244,"end_character":27},"in_reply_to":"f1137c69_f75a2617","updated":"2022-09-08 08:01:41.000000000","message":"Podman kolla_toolbox was reworked to use podman API.","commit_id":"33deec1415e0039fbfe9000907947a436ffc9a5c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f47e3930c77775f19405a19f2d948c6a2a2db2bf","unresolved":true,"context_lines":[{"line_number":279,"context_line":"    try:"},{"line_number":280,"context_line":"        json_output \u003d raw_output.decode(\u0027utf-8\u0027)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # NOTE(m.hiner): for some reason Podman exec output now contains"},{"line_number":283,"context_line":"        # extra unicode characters and single \"(\""},{"line_number":284,"context_line":"        for char in (\u0027\\u0001\u0027, \u0027\\u0000\u0027):"},{"line_number":285,"context_line":"            json_output \u003d json_output.replace(char, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":103,"id":"0917c8f5_5d9fb42d","line":282,"updated":"2023-10-16 12:44:52.000000000","message":"this sounds like it could be a bug in upstream podman.\nDid you maybe reach out to upstream to check if this is a bug?\n\nIt would be good to know, so we could at least mark this as a workaround.","commit_id":"07a9daf3479ce621df92f4788d34748171704c73"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"bb3b6d6c59bfa15d4faf53b4246c75b529105ef0","unresolved":true,"context_lines":[{"line_number":279,"context_line":"    try:"},{"line_number":280,"context_line":"        json_output \u003d raw_output.decode(\u0027utf-8\u0027)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # NOTE(m.hiner): for some reason Podman exec output now contains"},{"line_number":283,"context_line":"        # extra unicode characters and single \"(\""},{"line_number":284,"context_line":"        for char in (\u0027\\u0001\u0027, \u0027\\u0000\u0027):"},{"line_number":285,"context_line":"            json_output \u003d json_output.replace(char, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":103,"id":"7e6654e3_e7231901","line":282,"in_reply_to":"0917c8f5_5d9fb42d","updated":"2023-10-16 15:18:41.000000000","message":"Created issue for this: https://github.com/containers/podman-py/issues/334\nI also noticed that this does not happen in 4.6.0 release of podman-py. Hopefully it will help them to find solution sooner. In the meantime, should we limit the version we install or continue with this workaround and wait for them to fix it?","commit_id":"07a9daf3479ce621df92f4788d34748171704c73"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"2545d3d8eecb682a2bd25ee403edb1d10a335fab","unresolved":true,"context_lines":[{"line_number":279,"context_line":"    try:"},{"line_number":280,"context_line":"        json_output \u003d raw_output.decode(\u0027utf-8\u0027)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # NOTE(m.hiner): for some reason Podman exec output now contains"},{"line_number":283,"context_line":"        # extra unicode characters and single \"(\""},{"line_number":284,"context_line":"        for char in (\u0027\\u0001\u0027, \u0027\\u0000\u0027):"},{"line_number":285,"context_line":"            json_output \u003d json_output.replace(char, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":103,"id":"c6dd0a18_aee14c70","line":282,"in_reply_to":"646dd879_78f8570b","updated":"2023-10-17 10:34:24.000000000","message":"Done in ansible-kolla-collection patch and this workaround was removed.","commit_id":"07a9daf3479ce621df92f4788d34748171704c73"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cad879d3f9eb3986103a9fcc31b21f90dee56b55","unresolved":true,"context_lines":[{"line_number":279,"context_line":"    try:"},{"line_number":280,"context_line":"        json_output \u003d raw_output.decode(\u0027utf-8\u0027)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # NOTE(m.hiner): for some reason Podman exec output now contains"},{"line_number":283,"context_line":"        # extra unicode characters and single \"(\""},{"line_number":284,"context_line":"        for char in (\u0027\\u0001\u0027, \u0027\\u0000\u0027):"},{"line_number":285,"context_line":"            json_output \u003d json_output.replace(char, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":103,"id":"646dd879_78f8570b","line":282,"in_reply_to":"7e6654e3_e7231901","updated":"2023-10-16 15:44:41.000000000","message":"Thanks for creating the upstream issue.\n\nIf there is a known good version I\u0027d personally vouch for pinning this version until this is resolved upstream and make a comment in the codebase where we pin it with a link to the upstream issue.","commit_id":"07a9daf3479ce621df92f4788d34748171704c73"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"52fec5035a675a056fe1b5f8f85990520a414135","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    try:"},{"line_number":280,"context_line":"        json_output \u003d raw_output.decode(\u0027utf-8\u0027)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # NOTE(m.hiner): for some reason Podman exec output now contains"},{"line_number":283,"context_line":"        # extra unicode characters and single \"(\""},{"line_number":284,"context_line":"        for char in (\u0027\\u0001\u0027, \u0027\\u0000\u0027):"},{"line_number":285,"context_line":"            json_output \u003d json_output.replace(char, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":103,"id":"b2e3fe9a_b13e4182","line":282,"in_reply_to":"c6dd0a18_aee14c70","updated":"2023-10-17 14:55:07.000000000","message":"Done","commit_id":"07a9daf3479ce621df92f4788d34748171704c73"}],"ansible/module_utils/kolla_container_worker.py":[{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"aed4ce15f3201f76c36594c1feee058e868d6345","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            self.compare_volumes_from(container_info) or"},{"line_number":68,"context_line":"            self.compare_environment(container_info) or"},{"line_number":69,"context_line":"            self.compare_container_state(container_info) or"},{"line_number":70,"context_line":"            # self.compare_dimensions(container_info) or"},{"line_number":71,"context_line":"            self.compare_command(container_info) or"},{"line_number":72,"context_line":"            self.compare_healthcheck(container_info)"},{"line_number":73,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":16,"id":"c015df29_dbedd29f","line":70,"range":{"start_line":70,"start_character":11,"end_line":70,"end_character":56},"updated":"2022-09-01 07:09:27.000000000","message":"why this is commented out? If it is not needed then remove it.","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"0b7013194f118c5b49f1500a4e692fe6567b4c68","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            self.compare_volumes_from(container_info) or"},{"line_number":68,"context_line":"            self.compare_environment(container_info) or"},{"line_number":69,"context_line":"            self.compare_container_state(container_info) or"},{"line_number":70,"context_line":"            # self.compare_dimensions(container_info) or"},{"line_number":71,"context_line":"            self.compare_command(container_info) or"},{"line_number":72,"context_line":"            self.compare_healthcheck(container_info)"},{"line_number":73,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":16,"id":"e2472c73_22d646cc","line":70,"range":{"start_line":70,"start_character":11,"end_line":70,"end_character":56},"in_reply_to":"c015df29_dbedd29f","updated":"2022-09-08 08:01:41.000000000","message":"This was commented out because it always returned True for podman, which was fixed recently.","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"}],"ansible/module_utils/kolla_docker_worker.py":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fe40f4fb9f1d4032bbcc4e7939f4100090f329fa","unresolved":true,"context_lines":[{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# FIXME(yoctozepto): restart_policy is *not* checked in the container"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import docker"},{"line_number":18,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":63,"id":"c52fae23_af007a11","side":"PARENT","line":15,"updated":"2023-04-19 15:47:52.000000000","message":"is it checked now? Where?","commit_id":"dab4764c7750070fa164553caeeb680be8942b12"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"a81405600bf615a89ad08ccce7ac0384fd49033d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# FIXME(yoctozepto): restart_policy is *not* checked in the container"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import docker"},{"line_number":18,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":63,"id":"a9503dc6_1ff2b7d6","side":"PARENT","line":15,"in_reply_to":"c52fae23_af007a11","updated":"2023-04-20 14:25:57.000000000","message":"It is not checked yet. this FIXME is just being moved to kolla_docker.py where it should have been.","commit_id":"dab4764c7750070fa164553caeeb680be8942b12"}],"ansible/module_utils/kolla_podman_worker.py":[{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"aed4ce15f3201f76c36594c1feee058e868d6345","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from podman import PodmanClient"},{"line_number":16,"context_line":"import podman.errors"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import shlex"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"c21fffae_b8fd1480","line":16,"in_reply_to":"08c3ac31_ad891ab5","updated":"2022-09-01 07:09:27.000000000","message":"\u003e linters: H306: imports not in alphabetical order (podman.podmanclient, podman.errors)\n\nPlease fix.","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"0b7013194f118c5b49f1500a4e692fe6567b4c68","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from podman import PodmanClient"},{"line_number":16,"context_line":"import podman.errors"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import shlex"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"f6813de1_71873ee2","line":16,"in_reply_to":"4d9f866a_d297f44e","updated":"2022-09-08 08:01:41.000000000","message":"Done","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"aed4ce15f3201f76c36594c1feee058e868d6345","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from podman import PodmanClient"},{"line_number":16,"context_line":"import podman.errors"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import shlex"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"4d9f866a_d297f44e","line":16,"in_reply_to":"6107fe75_9ed29ccf","updated":"2022-09-01 07:09:27.000000000","message":"\u003e pep8: H306: imports not in alphabetical order (podman.podmanclient, podman.errors)\n\nPlease fix.","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"0b7013194f118c5b49f1500a4e692fe6567b4c68","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from podman import PodmanClient"},{"line_number":16,"context_line":"import podman.errors"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import shlex"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"2bba3f65_fc3e8482","line":16,"in_reply_to":"c21fffae_b8fd1480","updated":"2022-09-08 08:01:41.000000000","message":"Done","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6ea5fc8f24c633f3ee5e40219dd0efd6c7e5b7ca","unresolved":true,"context_lines":[{"line_number":115,"context_line":"        # args[\u0027tmpfs\u0027] \u003d self.generate_tmpfs()"},{"line_number":116,"context_line":"        self.params.pop(\u0027tmpfs\u0027, None)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # NOTE(m.hiner): in case containers are not privileged,"},{"line_number":119,"context_line":"        # they need this capability"},{"line_number":120,"context_line":"        if not self.params.get(\u0027privileged\u0027, False):"},{"line_number":121,"context_line":"            args[\u0027cap_add\u0027] \u003d self.params.pop(\u0027cap_add\u0027, []) + [\u0027AUDIT_WRITE\u0027]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # maybe can be done straight away,"},{"line_number":124,"context_line":"        # at first it was around 6 keys that\u0027s why it is this way"}],"source_content_type":"text/x-python","patch_set":81,"id":"8ff3380f_4d622e64","line":121,"range":{"start_line":118,"start_character":8,"end_line":121,"end_character":78},"updated":"2023-08-23 07:18:45.000000000","message":"Why do our containers need the ability to directly write to the kernels audit log?\n\nRedHat writes[0]:\n\n\"For most applications in containers, from this default list, you can drop the following: AUDIT_WRITE, MKNOD, SETFCAP, SETPCAP. \"\n\nSo it seems most applications don\u0027t need this capability.\n\nImho we should document why a capability is needed, so we can remove it once it is no longer needed.\n\nThanks\n\n[0]: https://access.redhat.com/documentation/de-de/red_hat_enterprise_linux_atomic_host/7/html/container_security_guide/linux_capabilities_and_seccomp","commit_id":"cc5574cf9a98a4bd4b2ce1d82d8cfeb0374f7094"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6b9c394704840c479c19416ce82ec02910d20068","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        # args[\u0027tmpfs\u0027] \u003d self.generate_tmpfs()"},{"line_number":116,"context_line":"        self.params.pop(\u0027tmpfs\u0027, None)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # NOTE(m.hiner): in case containers are not privileged,"},{"line_number":119,"context_line":"        # they need this capability"},{"line_number":120,"context_line":"        if not self.params.get(\u0027privileged\u0027, False):"},{"line_number":121,"context_line":"            args[\u0027cap_add\u0027] \u003d self.params.pop(\u0027cap_add\u0027, []) + [\u0027AUDIT_WRITE\u0027]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # maybe can be done straight away,"},{"line_number":124,"context_line":"        # at first it was around 6 keys that\u0027s why it is this way"}],"source_content_type":"text/x-python","patch_set":81,"id":"2c43f32c_62587d78","line":121,"range":{"start_line":118,"start_character":8,"end_line":121,"end_character":78},"in_reply_to":"15c0fd1e_d48fe3fb","updated":"2023-08-25 12:19:06.000000000","message":"yes, I also researched this upstream and it seems to be commonly set, e.g. it at least is the default for all docker containers.\n\nweird that the redhat docs say something different.","commit_id":"cc5574cf9a98a4bd4b2ce1d82d8cfeb0374f7094"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"50a9db279e18f0d5c1fc53797cd38fdae4179e09","unresolved":true,"context_lines":[{"line_number":115,"context_line":"        # args[\u0027tmpfs\u0027] \u003d self.generate_tmpfs()"},{"line_number":116,"context_line":"        self.params.pop(\u0027tmpfs\u0027, None)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # NOTE(m.hiner): in case containers are not privileged,"},{"line_number":119,"context_line":"        # they need this capability"},{"line_number":120,"context_line":"        if not self.params.get(\u0027privileged\u0027, False):"},{"line_number":121,"context_line":"            args[\u0027cap_add\u0027] \u003d self.params.pop(\u0027cap_add\u0027, []) + [\u0027AUDIT_WRITE\u0027]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # maybe can be done straight away,"},{"line_number":124,"context_line":"        # at first it was around 6 keys that\u0027s why it is this way"}],"source_content_type":"text/x-python","patch_set":81,"id":"15c0fd1e_d48fe3fb","line":121,"range":{"start_line":118,"start_character":8,"end_line":121,"end_character":78},"in_reply_to":"8ff3380f_4d622e64","updated":"2023-08-23 15:02:48.000000000","message":"I think it is necessary. Without this capability, error message \"sudo: unable to send audit message: Operation not permitted\" keeps appearing in container logs of certain containers (e.g. fluentd). Although, I am not sure how critical this error is.","commit_id":"cc5574cf9a98a4bd4b2ce1d82d8cfeb0374f7094"}],"ansible/roles/aodh/tasks/precheck.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"886152f4b4098c3aef8eea62ffca92d32fff5ca4","unresolved":true,"context_lines":[{"line_number":10,"context_line":"  kolla_container_facts:"},{"line_number":11,"context_line":"    name:"},{"line_number":12,"context_line":"      - aodh_api"},{"line_number":13,"context_line":"    container_engine: \u0027{{ kolla_container_engine }}\u0027"},{"line_number":14,"context_line":"  register: container_facts"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Checking free port for Aodh API"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1c197258_523d78b4","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":52},"updated":"2022-03-10 11:03:35.000000000","message":"Are you planning to have mixed docker/podman environment? can\u0027t container_engine be global variable set once and then used?","commit_id":"33deec1415e0039fbfe9000907947a436ffc9a5c"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"f7d06c1e170529f51b57e747f329067d789d54a1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  kolla_container_facts:"},{"line_number":11,"context_line":"    name:"},{"line_number":12,"context_line":"      - aodh_api"},{"line_number":13,"context_line":"    container_engine: \u0027{{ kolla_container_engine }}\u0027"},{"line_number":14,"context_line":"  register: container_facts"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Checking free port for Aodh API"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"75160e6f_74d63176","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":52},"in_reply_to":"1c197258_523d78b4","updated":"2022-11-27 12:42:09.000000000","message":"Solved in separate patchset.","commit_id":"33deec1415e0039fbfe9000907947a436ffc9a5c"}],"ansible/roles/common/defaults/main.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":100,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":101,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":102,"context_line":"  - \"/dev/:/dev/\""},{"line_number":103,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":104,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":105,"context_line":"cron_default_volumes:"},{"line_number":106,"context_line":"  - \"{{ node_config_directory }}/cron/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"44ede389_09038248","line":103,"range":{"start_line":103,"start_character":81,"end_line":103,"end_character":122},"updated":"2022-10-19 11:18:56.000000000","message":"please expand","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"b0bb2b91e38464b2bfaa07af35339563878f834f","unresolved":true,"context_lines":[{"line_number":100,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":101,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":102,"context_line":"  - \"/dev/:/dev/\""},{"line_number":103,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":104,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":105,"context_line":"cron_default_volumes:"},{"line_number":106,"context_line":"  - \"{{ node_config_directory }}/cron/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ab412563_539d8049","line":103,"range":{"start_line":103,"start_character":81,"end_line":103,"end_character":122},"in_reply_to":"280b60df_9f21d4f8","updated":"2023-04-05 14:51:37.000000000","message":"Bug report link was already in comment in this file, but it should\u0027ve also be included in this thread.\n\nThanks for the help with this.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":true,"context_lines":[{"line_number":100,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":101,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":102,"context_line":"  - \"/dev/:/dev/\""},{"line_number":103,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":104,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":105,"context_line":"cron_default_volumes:"},{"line_number":106,"context_line":"  - \"{{ node_config_directory }}/cron/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"a99f87f8_eb1d1f56","line":103,"range":{"start_line":103,"start_character":81,"end_line":103,"end_character":122},"in_reply_to":"44ede389_09038248","updated":"2022-10-27 11:43:49.000000000","message":"Podman has problem with mounting /run directory. We have created an issue in podman\u0027s Github for this.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"27f0294c44c38a2cfbf6840317844f58cb6384dd","unresolved":true,"context_lines":[{"line_number":100,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":101,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":102,"context_line":"  - \"/dev/:/dev/\""},{"line_number":103,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":104,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":105,"context_line":"cron_default_volumes:"},{"line_number":106,"context_line":"  - \"{{ node_config_directory }}/cron/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"280b60df_9f21d4f8","line":103,"range":{"start_line":103,"start_character":81,"end_line":103,"end_character":122},"in_reply_to":"a99f87f8_eb1d1f56","updated":"2023-04-05 12:57:28.000000000","message":"I believe this is the mentioned bug report on github:\nhttps://github.com/containers/podman/issues/16305\n\nside note: please always link mentioned bug reports, this took a while to find.\n\nthe linked bugreport got closed, though.\n\nI\u0027m currently looking into if this could be resolved differently than listing every /run/ sub dir separately.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1aa1dbbf0c6ea1200648fb7c9a5485b29a945590","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":101,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":102,"context_line":"  - \"/dev/:/dev/\""},{"line_number":103,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":104,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":105,"context_line":"cron_default_volumes:"},{"line_number":106,"context_line":"  - \"{{ node_config_directory }}/cron/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"8d1e6435_e3c01c64","line":103,"range":{"start_line":103,"start_character":81,"end_line":103,"end_character":122},"in_reply_to":"ab412563_539d8049","updated":"2023-04-21 08:12:21.000000000","message":"Ack","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/common/tasks/bootstrap.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    name: \"kolla_logs\""},{"line_number":8,"context_line":"  when: inventory_hostname in groups[\u0027kolla-logs\u0027]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# TODO(martinhiner): create variables for each directory"},{"line_number":11,"context_line":"- name: Link kolla_logs volume to /var/log/kolla"},{"line_number":12,"context_line":"  become: true"},{"line_number":13,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"399fb899_3883ebae","line":10,"updated":"2022-10-19 11:18:56.000000000","message":"Create container_engine_volumes_path variable and use it instead of two similar blocks?","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    name: \"kolla_logs\""},{"line_number":8,"context_line":"  when: inventory_hostname in groups[\u0027kolla-logs\u0027]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# TODO(martinhiner): create variables for each directory"},{"line_number":11,"context_line":"- name: Link kolla_logs volume to /var/log/kolla"},{"line_number":12,"context_line":"  become: true"},{"line_number":13,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"4fb89205_f8d0a7d5","line":10,"in_reply_to":"399fb899_3883ebae","updated":"2022-10-27 11:43:49.000000000","message":"Done","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/keystone/tasks/bootstrap_service.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    image: \"{{ keystone_fernet.image }}\""},{"line_number":63,"context_line":"    labels:"},{"line_number":64,"context_line":"      BOOTSTRAP:"},{"line_number":65,"context_line":"    command: \u0027bash -c \"sudo -E kolla_set_configs \u0026\u0026"},{"line_number":66,"context_line":"      keystone-manage --config-file /etc/keystone/keystone.conf"},{"line_number":67,"context_line":"      fernet_setup --keystone-user {{ keystone_username }} --keystone-group {{ keystone_groupname }}\"\u0027"},{"line_number":68,"context_line":"    name: \"bootstrap_keystone_fernet\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"16a28a6f_ffb3cc35","line":65,"updated":"2022-10-19 11:18:56.000000000","message":"why change of format here?","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    image: \"{{ keystone_fernet.image }}\""},{"line_number":63,"context_line":"    labels:"},{"line_number":64,"context_line":"      BOOTSTRAP:"},{"line_number":65,"context_line":"    command: \u0027bash -c \"sudo -E kolla_set_configs \u0026\u0026"},{"line_number":66,"context_line":"      keystone-manage --config-file /etc/keystone/keystone.conf"},{"line_number":67,"context_line":"      fernet_setup --keystone-user {{ keystone_username }} --keystone-group {{ keystone_groupname }}\"\u0027"},{"line_number":68,"context_line":"    name: \"bootstrap_keystone_fernet\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"0cb6d116_7269576e","line":65,"in_reply_to":"16a28a6f_ffb3cc35","updated":"2022-10-27 11:43:49.000000000","message":"There was a problem with podman modules not parsing strings properly with the original format. This problem is not present anymore so I will revert to the original format.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/loadbalancer/tasks/precheck.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e4314466bc1b75a32875269f9dc38efa6d396a8b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    service_precheck_services: \"{{ loadbalancer_services }}\""},{"line_number":6,"context_line":"    service_name: \"{{ project_name }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Make sure podman service is running"},{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  service:"},{"line_number":11,"context_line":"    name: podman.socket"}],"source_content_type":"text/x-yaml","patch_set":74,"id":"c17049b3_6a2aefb3","line":8,"updated":"2023-07-03 14:41:16.000000000","message":"why was this removed?","commit_id":"1596714ca6df78fbc62fd34758d19b281ff69aee"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e61f75529fd37e2b3429787128b6ff27e598eacd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    service_precheck_services: \"{{ loadbalancer_services }}\""},{"line_number":6,"context_line":"    service_name: \"{{ project_name }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Make sure podman service is running"},{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  service:"},{"line_number":11,"context_line":"    name: podman.socket"}],"source_content_type":"text/x-yaml","patch_set":74,"id":"96904f40_35c30fd4","line":8,"in_reply_to":"8b0814ae_ad5848bf","updated":"2023-07-04 08:59:52.000000000","message":"Done","commit_id":"1596714ca6df78fbc62fd34758d19b281ff69aee"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"7e2cc8078363267aca011adc0a3a5f77de4cda30","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    service_precheck_services: \"{{ loadbalancer_services }}\""},{"line_number":6,"context_line":"    service_name: \"{{ project_name }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Make sure podman service is running"},{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  service:"},{"line_number":11,"context_line":"    name: podman.socket"}],"source_content_type":"text/x-yaml","patch_set":74,"id":"8b0814ae_ad5848bf","line":8,"in_reply_to":"c17049b3_6a2aefb3","updated":"2023-07-04 08:55:18.000000000","message":"it was added because I thought that it is a reason of failed testcase kolla-ansible-rocky9-podman but it looks like service is running anyway so it\u0027s not needed and problem is somewhere else","commit_id":"1596714ca6df78fbc62fd34758d19b281ff69aee"}],"ansible/roles/mariadb/tasks/lookup_cluster.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        - name: Check MariaDB service WSREP sync status"},{"line_number":46,"context_line":"          become: true"},{"line_number":47,"context_line":"          command: \u003e-"},{"line_number":48,"context_line":"            \"{{ kolla_container_engine }}\" exec {{ mariadb_service.container_name }}"},{"line_number":49,"context_line":"            mysql -uroot -p{{ database_password }}"},{"line_number":50,"context_line":"            --silent --skip-column-names"},{"line_number":51,"context_line":"            -e \u0027SHOW STATUS LIKE \"wsrep_local_state_comment\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"1e66c630_3d7a13e4","line":48,"updated":"2022-10-19 11:18:56.000000000","message":"why \"\"?","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        - name: Check MariaDB service WSREP sync status"},{"line_number":46,"context_line":"          become: true"},{"line_number":47,"context_line":"          command: \u003e-"},{"line_number":48,"context_line":"            \"{{ kolla_container_engine }}\" exec {{ mariadb_service.container_name }}"},{"line_number":49,"context_line":"            mysql -uroot -p{{ database_password }}"},{"line_number":50,"context_line":"            --silent --skip-column-names"},{"line_number":51,"context_line":"            -e \u0027SHOW STATUS LIKE \"wsrep_local_state_comment\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"30806963_42c22290","line":48,"in_reply_to":"1e66c630_3d7a13e4","updated":"2022-10-27 11:43:49.000000000","message":"No idea, probably random slip-up. Fixed.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/mariadb/tasks/recover_cluster.yml":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"ba787426bc4a049c7287255c91815b1e431b8912","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    - name: Copying MariaDB log file to /tmp"},{"line_number":44,"context_line":"      become: true"},{"line_number":45,"context_line":"      command: \"cp {{ docker_runtime_directory or \u0027/var/lib/docker\u0027 if kolla_container_engine\u003d\u003d\u0027docker\u0027 else  \u0027/var/lib/containers/storage\u0027 }}/volumes/kolla_logs/_data/mariadb/mariadb.log /tmp/mariadb_tmp.log\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Look for sequence number in logs. Format is:"},{"line_number":48,"context_line":"    # WSREP: Recovered position: \u003cUUID\u003e:\u003cseqno\u003e."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"eeab4e60_19b75eb2","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":142},"updated":"2022-03-31 12:06:28.000000000","message":"I get an error in this if `docker_runtime_directory` is not defined.\n\n\n {{ (kolla_container_engine \u003d\u003d \u0027docker\u0027) | ternary(docker_runtime_directory | default(\u0027/var/lib/docker\u0027), \u0027/var/lib/containers/storage\u0027) }}","commit_id":"33deec1415e0039fbfe9000907947a436ffc9a5c"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"0b7013194f118c5b49f1500a4e692fe6567b4c68","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    - name: Copying MariaDB log file to /tmp"},{"line_number":44,"context_line":"      become: true"},{"line_number":45,"context_line":"      command: \"cp {{ docker_runtime_directory or \u0027/var/lib/docker\u0027 if kolla_container_engine\u003d\u003d\u0027docker\u0027 else  \u0027/var/lib/containers/storage\u0027 }}/volumes/kolla_logs/_data/mariadb/mariadb.log /tmp/mariadb_tmp.log\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Look for sequence number in logs. Format is:"},{"line_number":48,"context_line":"    # WSREP: Recovered position: \u003cUUID\u003e:\u003cseqno\u003e."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7826a206_49092323","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":142},"in_reply_to":"eeab4e60_19b75eb2","updated":"2022-09-08 08:01:41.000000000","message":"Done","commit_id":"33deec1415e0039fbfe9000907947a436ffc9a5c"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    - name: Copying MariaDB log file to /tmp"},{"line_number":45,"context_line":"      become: true"},{"line_number":46,"context_line":"      command: \"cp {{ (kolla_container_engine \u003d\u003d \u0027docker\u0027) | ternary(docker_runtime_directory | default(\u0027/var/lib/docker\u0027, true), \u0027/var/lib/containers/storage\u0027) }}/volumes/kolla_logs/_data/mariadb/mariadb.log /tmp/mariadb_tmp.log\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Look for sequence number in logs. Format is:"},{"line_number":49,"context_line":"    # WSREP: Recovered position: \u003cUUID\u003e:\u003cseqno\u003e."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"3caaefe3_0716b3f7","line":46,"updated":"2022-10-19 11:18:56.000000000","message":"create variable like I suggested in other comment","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    - name: Copying MariaDB log file to /tmp"},{"line_number":45,"context_line":"      become: true"},{"line_number":46,"context_line":"      command: \"cp {{ (kolla_container_engine \u003d\u003d \u0027docker\u0027) | ternary(docker_runtime_directory | default(\u0027/var/lib/docker\u0027, true), \u0027/var/lib/containers/storage\u0027) }}/volumes/kolla_logs/_data/mariadb/mariadb.log /tmp/mariadb_tmp.log\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Look for sequence number in logs. Format is:"},{"line_number":49,"context_line":"    # WSREP: Recovered position: \u003cUUID\u003e:\u003cseqno\u003e."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"2a8633eb_6b6aeb60","line":46,"in_reply_to":"3caaefe3_0716b3f7","updated":"2022-10-27 11:43:49.000000000","message":"Done","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/mariadb/tasks/restart_services.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":30,"context_line":"- name: Wait for MariaDB service to sync WSREP"},{"line_number":31,"context_line":"  become: true"},{"line_number":32,"context_line":"  command: \u003e-"},{"line_number":33,"context_line":"    \"{{ kolla_container_engine }}\" exec {{ mariadb_service.container_name }}"},{"line_number":34,"context_line":"    mysql -uroot -p{{ database_password }}"},{"line_number":35,"context_line":"    --silent --skip-column-names"},{"line_number":36,"context_line":"    -e \u0027SHOW STATUS LIKE \"wsrep_local_state_comment\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"e52ead08_caf046df","line":33,"updated":"2022-10-19 11:18:56.000000000","message":"\"\" again","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- name: Wait for MariaDB service to sync WSREP"},{"line_number":31,"context_line":"  become: true"},{"line_number":32,"context_line":"  command: \u003e-"},{"line_number":33,"context_line":"    \"{{ kolla_container_engine }}\" exec {{ mariadb_service.container_name }}"},{"line_number":34,"context_line":"    mysql -uroot -p{{ database_password }}"},{"line_number":35,"context_line":"    --silent --skip-column-names"},{"line_number":36,"context_line":"    -e \u0027SHOW STATUS LIKE \"wsrep_local_state_comment\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"cc6e92f4_5e9edad0","line":33,"in_reply_to":"e52ead08_caf046df","updated":"2022-10-27 11:43:49.000000000","message":"Done","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":450,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":451,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":452,"context_line":"  - \"neutron_metadata_socket:/var/lib/neutron/kolla/\""},{"line_number":453,"context_line":"  - \"{{\u0027/run/netns:/run/netns:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\""},{"line_number":454,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":455,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/neutron/neutron:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/neutron\u0027 if neutron_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":456,"context_line":"neutron_l3_agent_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ae83d9af_7d7ddf61","line":453,"updated":"2022-10-19 11:18:56.000000000","message":"create var for it once at start and just use it in all places?","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"f7d06c1e170529f51b57e747f329067d789d54a1","unresolved":true,"context_lines":[{"line_number":450,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":451,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":452,"context_line":"  - \"neutron_metadata_socket:/var/lib/neutron/kolla/\""},{"line_number":453,"context_line":"  - \"{{\u0027/run/netns:/run/netns:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\""},{"line_number":454,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":455,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/neutron/neutron:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/neutron\u0027 if neutron_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":456,"context_line":"neutron_l3_agent_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"f6a8204e_97460449","line":453,"in_reply_to":"ae83d9af_7d7ddf61","updated":"2022-11-27 12:42:09.000000000","message":"not sure if this is good idea, there are multiple versions of mounting /run/ as /run/:, /run/netns/:, /run/openswitch/:, /run/libvirt... that would need separate variable each and since we are using same approach for timezone in every container don\u0027t really see point in doing this. It would just make definition more confusing.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"d4491358306cc0bf4450fd5be4f02dc631db9e49","unresolved":false,"context_lines":[{"line_number":450,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":451,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":452,"context_line":"  - \"neutron_metadata_socket:/var/lib/neutron/kolla/\""},{"line_number":453,"context_line":"  - \"{{\u0027/run/netns:/run/netns:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\""},{"line_number":454,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":455,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/neutron/neutron:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/neutron\u0027 if neutron_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":456,"context_line":"neutron_l3_agent_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"768dedfa_637f5fd8","line":453,"in_reply_to":"f6a8204e_97460449","updated":"2023-07-17 08:48:37.000000000","message":"Done","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/neutron/templates/neutron.conf.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":220,"context_line":"wapi_max_results \u003d {{ infoblox_wapi_max_results }}"},{"line_number":221,"context_line":"{% endif %}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"[experimental]"},{"line_number":224,"context_line":"linuxbridge \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"0141b0c9_fa452cf7","line":223,"updated":"2022-10-19 11:18:56.000000000","message":"why it is here?","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":220,"context_line":"wapi_max_results \u003d {{ infoblox_wapi_max_results }}"},{"line_number":221,"context_line":"{% endif %}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"[experimental]"},{"line_number":224,"context_line":"linuxbridge \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"a86f6cfe_0f82afc5","line":223,"in_reply_to":"0141b0c9_fa452cf7","updated":"2022-10-27 11:43:49.000000000","message":"We were trying linuxbridge deployment and I guess we forgot to remove it before pushing.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/nova-cell/defaults/main.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":364,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":365,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":366,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":367,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":368,"context_line":"  - \"/dev:/dev\""},{"line_number":369,"context_line":"  - \"{{ \u0027devpts:/dev/pts\u0027 if kolla_container_engine \u003d\u003d \u0027podman\u0027 else \u0027\u0027 }}\""},{"line_number":370,"context_line":"  - \"/sys/fs/cgroup:/sys/fs/cgroup\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"afd30cde_6707a3d4","line":367,"updated":"2022-10-19 11:18:56.000000000","message":"create var and use it","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"f7d06c1e170529f51b57e747f329067d789d54a1","unresolved":false,"context_lines":[{"line_number":364,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":365,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":366,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":367,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":368,"context_line":"  - \"/dev:/dev\""},{"line_number":369,"context_line":"  - \"{{ \u0027devpts:/dev/pts\u0027 if kolla_container_engine \u003d\u003d \u0027podman\u0027 else \u0027\u0027 }}\""},{"line_number":370,"context_line":"  - \"/sys/fs/cgroup:/sys/fs/cgroup\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"411dc56a_f50f326b","line":367,"in_reply_to":"afd30cde_6707a3d4","updated":"2022-11-27 12:42:09.000000000","message":"Same reasoning as above.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34311,"name":"Tadas Sutkaitis","display_name":"Tadas Sutkaitis","email":"tadasas@gmail.com","username":"t42x"},"change_message_id":"ef089a8e05f08de5e6f6356fbc851b8dd0fc493a","unresolved":true,"context_lines":[{"line_number":371,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":372,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":373,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":374,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":375,"context_line":"  - \"/dev:/dev\""},{"line_number":376,"context_line":"  - \"{{ \u0027devpts:/dev/pts\u0027 if kolla_container_engine \u003d\u003d \u0027podman\u0027 else \u0027\u0027 }}\""},{"line_number":377,"context_line":"  - \"/sys/fs/cgroup:/sys/fs/cgroup\""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"d1f31883_69737ebb","line":374,"updated":"2023-03-06 12:32:47.000000000","message":"You can\u0027t mount whole /run with podman because environment file is located at path /run/.containerenv inside container. In docker case this environment definition is located at path /.dockerenv .","commit_id":"a2276d816f33c7688959df500f91577361482e2a"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"1709a769f835015a303314be4dff2edf26334fa3","unresolved":true,"context_lines":[{"line_number":371,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":372,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":373,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":374,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":375,"context_line":"  - \"/dev:/dev\""},{"line_number":376,"context_line":"  - \"{{ \u0027devpts:/dev/pts\u0027 if kolla_container_engine \u003d\u003d \u0027podman\u0027 else \u0027\u0027 }}\""},{"line_number":377,"context_line":"  - \"/sys/fs/cgroup:/sys/fs/cgroup\""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"326e3a4e_dd3bfb88","line":374,"in_reply_to":"27535816_21e9590c","updated":"2023-05-04 08:30:08.000000000","message":"I tried this approach but it fails when directory doesnt exist under /run so you would have to manually create them and that is kinda against whole idea of /run. I was able to make mounting whole /run running with masking /run/secrets as tmpfs with command below:\nsudo podman run -d --mount type\u003dbind,src\u003d/run/,target\u003d/run/,shared --mount type\u003dtmpfs,destination\u003d/run/secrets  --name busybox1 busybox tail -f /dev/null\nbut then secrets got propagated to the host anyway so there is potential security issue. Also there were some issue of active user since it propagated user set in container to the host.\n\nMy main question is are we sure we need /run directory to be shared across containers? Isnt it used only to communicate with host machine?","commit_id":"a2276d816f33c7688959df500f91577361482e2a"},{"author":{"_account_id":34311,"name":"Tadas Sutkaitis","display_name":"Tadas Sutkaitis","email":"tadasas@gmail.com","username":"t42x"},"change_message_id":"2a26f5d60298da829444c793b8e1e9eb58ef48e0","unresolved":true,"context_lines":[{"line_number":371,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":372,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":373,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":374,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":375,"context_line":"  - \"/dev:/dev\""},{"line_number":376,"context_line":"  - \"{{ \u0027devpts:/dev/pts\u0027 if kolla_container_engine \u003d\u003d \u0027podman\u0027 else \u0027\u0027 }}\""},{"line_number":377,"context_line":"  - \"/sys/fs/cgroup:/sys/fs/cgroup\""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"96f9ec58_36554fb3","line":374,"in_reply_to":"326e3a4e_dd3bfb88","updated":"2023-05-04 08:44:26.000000000","message":"\u003e I tried this approach but it fails when directory doesnt exist under /run so you would have to manually create them and that is kinda against whole idea of /run. I was able to make mounting whole /run running with masking /run/secrets as tmpfs with command below:\n\u003e sudo podman run -d --mount type\u003dbind,src\u003d/run/,target\u003d/run/,shared --mount type\u003dtmpfs,destination\u003d/run/secrets  --name busybox1 busybox tail -f /dev/null\n\u003e but then secrets got propagated to the host anyway so there is potential security issue. Also there were some issue of active user since it propagated user set in container to the host.\n\u003e \n\u003e My main question is are we sure we need /run directory to be shared across containers? Isnt it used only to communicate with host machine?\n\nTry to restart container with this mount few times and you will se growing list of tmpfs.\n\nFrom my experience you need (for nova and libvirt) shared mount points:\n\n--mount type\u003dbind,source\u003d/run/netns,target\u003d/run/netns,shared \\\n--mount type\u003dbind,source\u003d/run/libvirt,target\u003d/run/libvirt,shared \\\n--mount type\u003dbind,source\u003d/run/nova,target\u003d/run/nova,shared \\\n\n/dev/netns for OVS and it should be shared between ovs/ovn agent, nova and libvirt\n/run/libvirt between nova/libvirt for nova to get access to libvirt socket\n/run/nova between nova/libvirt for libvirt to get info about state of instances\n\nThe list is endless and it is very hard to maintain","commit_id":"a2276d816f33c7688959df500f91577361482e2a"},{"author":{"_account_id":34311,"name":"Tadas Sutkaitis","display_name":"Tadas Sutkaitis","email":"tadasas@gmail.com","username":"t42x"},"change_message_id":"2415144192762543a0c6f70eb68b7b486e4fda40","unresolved":true,"context_lines":[{"line_number":371,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":372,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":373,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":374,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":375,"context_line":"  - \"/dev:/dev\""},{"line_number":376,"context_line":"  - \"{{ \u0027devpts:/dev/pts\u0027 if kolla_container_engine \u003d\u003d \u0027podman\u0027 else \u0027\u0027 }}\""},{"line_number":377,"context_line":"  - \"/sys/fs/cgroup:/sys/fs/cgroup\""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"27535816_21e9590c","line":374,"in_reply_to":"4a3a1995_12bc51d3","updated":"2023-03-09 10:31:18.000000000","message":"Good question.\nThis is snipped is from my other project:\n\nIn systemd style:\n\nExecStart\u003d/usr/bin/podman run --rm --network host \\\n          --conmon-pidfile /%t/%n/%n.pid --cidfile /%t/%n/%n.cid \\\n          --mount type\u003dbind,source\u003d/var/lib/nova,target\u003d/var/lib/nova \\\n          --mount type\u003dbind,source\u003d/var/lib/libvirt,target\u003d/var/lib/libvirt \\\n          --mount type\u003dbind,source\u003d/etc/libvirt/qemu,target\u003d/etc/libvirt/qemu \\\n          --mount type\u003dbind,source\u003d/var/log/libvirt,target\u003d/var/log/libvirt \\\n          --mount type\u003dbind,source\u003d/var/log/console_logs,target\u003d/var/log/console_logs \\\n          --mount type\u003dbind,source\u003d/etc/ssl,target\u003d/etc/ssl \\\n          --mount type\u003dbind,source\u003d/lib/modules,target\u003d/lib/modules,readonly\u003dtrue \\\n          --mount type\u003dbind,source\u003d/run/netns,target\u003d/run/netns,shared \\\n          --mount type\u003dbind,source\u003d/run/lock/nova,target\u003d/run/lock/nova,shared \\\n          --mount type\u003dbind,source\u003d/run/libvirt,target\u003d/run/libvirt,shared \\\n          --mount type\u003dbind,source\u003d/run/nova,target\u003d/run/nova,shared \\\n          --mount type\u003dbind,source\u003d/run/openvswitch,target\u003d/run/openvswitch \\\n          --mount type\u003dbind,source\u003d/dev,target\u003d/dev \\\n          --mount type\u003dbind,source\u003d/sys/fs/cgroup,target\u003d/sys/fs/cgroup \\\n          --mount type\u003dbind,source\u003d/etc/libvirt/qemu.conf,target\u003d/etc/libvirt/qemu.conf \\\n          --mount type\u003dbind,source\u003d/etc/libvirt/libvirtd.conf,target\u003d/etc/libvirt/libvirtd.conf \\\n{% if use_ceph %}\n          --mount type\u003dbind,source\u003d/etc/libvirt/secrets,target\u003d/etc/libvirt/secrets \\\n          --mount type\u003dbind,source\u003d/etc/ceph/ceph.conf,target\u003d/etc/ceph/ceph.conf \\\n{% endif %}\n          --privileged \\\n          --pid\u003dhost \\\n          --cgroupns\u003dhost \\\n          --hostname \"{{ kolla_fqdn }}\" \\\n          --name %n \\\n          {{ nova_libvirt_image_full }} /usr/sbin/libvirtd --listen\n\nBasically you should mount more paths under /run individually.","commit_id":"a2276d816f33c7688959df500f91577361482e2a"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"d4491358306cc0bf4450fd5be4f02dc631db9e49","unresolved":false,"context_lines":[{"line_number":371,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":372,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":373,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":374,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":375,"context_line":"  - \"/dev:/dev\""},{"line_number":376,"context_line":"  - \"{{ \u0027devpts:/dev/pts\u0027 if kolla_container_engine \u003d\u003d \u0027podman\u0027 else \u0027\u0027 }}\""},{"line_number":377,"context_line":"  - \"/sys/fs/cgroup:/sys/fs/cgroup\""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"44a85fca_9fd1cfbe","line":374,"in_reply_to":"96f9ec58_36554fb3","updated":"2023-07-17 08:48:37.000000000","message":"Done","commit_id":"a2276d816f33c7688959df500f91577361482e2a"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"68f738fe2a22a6d7a6a67a3126d12bc4bc55ae8f","unresolved":true,"context_lines":[{"line_number":371,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":372,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":373,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":374,"context_line":"  - \"{{ \u0027/run/:/run/:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":375,"context_line":"  - \"/dev:/dev\""},{"line_number":376,"context_line":"  - \"{{ \u0027devpts:/dev/pts\u0027 if kolla_container_engine \u003d\u003d \u0027podman\u0027 else \u0027\u0027 }}\""},{"line_number":377,"context_line":"  - \"/sys/fs/cgroup:/sys/fs/cgroup\""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"4a3a1995_12bc51d3","line":374,"in_reply_to":"d1f31883_69737ebb","updated":"2023-03-06 14:38:05.000000000","message":"So what do you propose as solution? If mounting whole /run is not possible","commit_id":"a2276d816f33c7688959df500f91577361482e2a"}],"ansible/roles/nova-cell/tasks/create_cells.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  kolla_docker:"},{"line_number":11,"context_line":"    action: \"start_container\""},{"line_number":12,"context_line":"    command: \"bash -c \u0027sudo -E kolla_set_configs \u0026\u0026 nova-manage cell_v2 create_cell{% if nova_cell_name %} --name {{ nova_cell_name }}{% endif %}\u0027\""},{"line_number":13,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":14,"context_line":"    detach: False"},{"line_number":15,"context_line":"    image: \"{{ nova_conductor.image }}\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"c4964bcc_650e8fce","line":12,"updated":"2022-10-19 11:18:56.000000000","message":"why \"\"?","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  kolla_docker:"},{"line_number":11,"context_line":"    action: \"start_container\""},{"line_number":12,"context_line":"    command: \"bash -c \u0027sudo -E kolla_set_configs \u0026\u0026 nova-manage cell_v2 create_cell{% if nova_cell_name %} --name {{ nova_cell_name }}{% endif %}\u0027\""},{"line_number":13,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":14,"context_line":"    detach: False"},{"line_number":15,"context_line":"    image: \"{{ nova_conductor.image }}\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"e4a7c5f1_5e2b2718","line":12,"in_reply_to":"c4964bcc_650e8fce","updated":"2022-10-27 11:43:49.000000000","message":"Same former podman issues.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/nova-cell/tasks/get_cell_settings.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  become: true"},{"line_number":6,"context_line":"  kolla_docker:"},{"line_number":7,"context_line":"    action: \"start_container\""},{"line_number":8,"context_line":"    command: \"bash -c \u0027sudo -E kolla_set_configs \u0026\u0026 nova-manage cell_v2 list_cells --verbose\u0027\""},{"line_number":9,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":10,"context_line":"    detach: False"},{"line_number":11,"context_line":"    image: \"{{ nova_conductor.image }}\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"3d121857_d7e70ce3","line":8,"updated":"2022-10-19 11:18:56.000000000","message":"why \"\"?","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  become: true"},{"line_number":6,"context_line":"  kolla_docker:"},{"line_number":7,"context_line":"    action: \"start_container\""},{"line_number":8,"context_line":"    command: \"bash -c \u0027sudo -E kolla_set_configs \u0026\u0026 nova-manage cell_v2 list_cells --verbose\u0027\""},{"line_number":9,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":10,"context_line":"    detach: False"},{"line_number":11,"context_line":"    image: \"{{ nova_conductor.image }}\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"79329df8_061c1b03","line":8,"in_reply_to":"3d121857_d7e70ce3","updated":"2022-10-27 11:43:49.000000000","message":"This was again because of problems with string parsing in past podman modules. With this issue fixed, this string will be reveted to original.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/nova/tasks/map_cell0.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  kolla_docker:"},{"line_number":8,"context_line":"    action: \"start_container\""},{"line_number":9,"context_line":"    command: \u0027bash -c \"sudo -E kolla_set_configs \u0026\u0026 nova-manage cell_v2 map_cell0 --database_connection {{ nova_cell0_connection }}\"\u0027"},{"line_number":10,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":11,"context_line":"    detach: False"},{"line_number":12,"context_line":"    image: \"{{ nova_api.image }}\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"6c6627d5_dbd695e0","line":9,"updated":"2022-10-19 11:18:56.000000000","message":"why \u0027\u0027?","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  kolla_docker:"},{"line_number":8,"context_line":"    action: \"start_container\""},{"line_number":9,"context_line":"    command: \u0027bash -c \"sudo -E kolla_set_configs \u0026\u0026 nova-manage cell_v2 map_cell0 --database_connection {{ nova_cell0_connection }}\"\u0027"},{"line_number":10,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":11,"context_line":"    detach: False"},{"line_number":12,"context_line":"    image: \"{{ nova_api.image }}\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"cb92e6d8_92466356","line":9,"in_reply_to":"6c6627d5_dbd695e0","updated":"2022-10-27 11:43:49.000000000","message":"Same former podman issues.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/nova/tasks/upgrade.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check nova upgrade status"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: \"{{ kolla_container_engine }} exec -t nova_api nova-status upgrade check\""},{"line_number":5,"context_line":"  register: nova_upgrade_check_stdout"},{"line_number":6,"context_line":"  when: inventory_hostname \u003d\u003d groups[\u0027nova-api\u0027][0]"},{"line_number":7,"context_line":"  failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"28f60f81_4c1b4bd7","line":4,"updated":"2022-10-19 11:18:56.000000000","message":"why \"\"?","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check nova upgrade status"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: \"{{ kolla_container_engine }} exec -t nova_api nova-status upgrade check\""},{"line_number":5,"context_line":"  register: nova_upgrade_check_stdout"},{"line_number":6,"context_line":"  when: inventory_hostname \u003d\u003d groups[\u0027nova-api\u0027][0]"},{"line_number":7,"context_line":"  failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"995fa278_25c2d538","line":4,"in_reply_to":"28f60f81_4c1b4bd7","updated":"2022-10-27 11:43:49.000000000","message":"For some reason ansible doesn\u0027t accept \"{{ kolla_container_engine }}\" exec..., and that\u0027s why the whole command has to be in a single string. Same goes for other commands in this format.","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/openvswitch/defaults/main.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":81,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":82,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":83,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":84,"context_line":"  - \"{{ \u0027/run/openvswitch:/run/openvswitch:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":85,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":86,"context_line":"  - \"openvswitch_db:/var/lib/openvswitch/\""},{"line_number":87,"context_line":"  - \"/run/openvswitch:/run/openvswitch:shared\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"0d06a05b_02df7bbf","line":84,"updated":"2022-10-19 11:18:56.000000000","message":"some? expand","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":82,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":83,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":84,"context_line":"  - \"{{ \u0027/run/openvswitch:/run/openvswitch:shared\u0027 if kolla_container_engine \u003d\u003d \u0027docker\u0027 else \u0027\u0027 }}\"   # not working with podman for some reason"},{"line_number":85,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":86,"context_line":"  - \"openvswitch_db:/var/lib/openvswitch/\""},{"line_number":87,"context_line":"  - \"/run/openvswitch:/run/openvswitch:shared\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"79b39b37_f8942b0d","line":84,"in_reply_to":"0d06a05b_02df7bbf","updated":"2022-10-27 11:43:49.000000000","message":"Done","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/openvswitch/handlers/main.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Waiting for openvswitch_db service to be ready"},{"line_number":21,"context_line":"  become: true"},{"line_number":22,"context_line":"  command: \"{{ kolla_container_engine }} exec openvswitch_db ovs-vsctl --no-wait show\""},{"line_number":23,"context_line":"  register: check_result"},{"line_number":24,"context_line":"  until: check_result is success"},{"line_number":25,"context_line":"  changed_when: False"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5a3843ab_77dbfc11","line":22,"updated":"2022-10-19 11:18:56.000000000","message":"why \"\"?","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Waiting for openvswitch_db service to be ready"},{"line_number":21,"context_line":"  become: true"},{"line_number":22,"context_line":"  command: \"{{ kolla_container_engine }} exec openvswitch_db ovs-vsctl --no-wait show\""},{"line_number":23,"context_line":"  register: check_result"},{"line_number":24,"context_line":"  until: check_result is success"},{"line_number":25,"context_line":"  changed_when: False"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"b0b43ba9_6d301467","line":22,"in_reply_to":"5a3843ab_77dbfc11","updated":"2022-10-27 11:43:49.000000000","message":"Ack","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/openvswitch/tasks/post-config.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Ensuring OVS bridge is properly setup"},{"line_number":21,"context_line":"  become: true"},{"line_number":22,"context_line":"  command: \"{{ kolla_container_engine }} exec openvswitch_db /usr/local/bin/kolla_ensure_openvswitch_configured {{ item.0 }} {{ item.1 }}\""},{"line_number":23,"context_line":"  register: status"},{"line_number":24,"context_line":"  changed_when: status.stdout.find(\u0027changed\u0027) !\u003d -1"},{"line_number":25,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"cf57ad06_449e340b","line":22,"updated":"2022-10-19 11:18:56.000000000","message":"again \"\"","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Ensuring OVS bridge is properly setup"},{"line_number":21,"context_line":"  become: true"},{"line_number":22,"context_line":"  command: \"{{ kolla_container_engine }} exec openvswitch_db /usr/local/bin/kolla_ensure_openvswitch_configured {{ item.0 }} {{ item.1 }}\""},{"line_number":23,"context_line":"  register: status"},{"line_number":24,"context_line":"  changed_when: status.stdout.find(\u0027changed\u0027) !\u003d -1"},{"line_number":25,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"7d40822e_9b0576b7","line":22,"in_reply_to":"cf57ad06_449e340b","updated":"2022-10-27 11:43:49.000000000","message":"Ack","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/ovs-dpdk/handlers/main.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    service_name: \"ovsdpdk-db\""},{"line_number":27,"context_line":"    service: \"{{ ovsdpdk_services[service_name] }}\""},{"line_number":28,"context_line":"  become: true"},{"line_number":29,"context_line":"  command: \"{{ kolla_container_engine }} exec {{ service.container_name }} ovs-vsctl --no-wait show\""},{"line_number":30,"context_line":"  register: check_result"},{"line_number":31,"context_line":"  until: check_result is success"},{"line_number":32,"context_line":"  changed_when: False"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"6c0ae71d_1c200a3d","line":29,"updated":"2022-10-19 11:18:56.000000000","message":"and again","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    service_name: \"ovsdpdk-db\""},{"line_number":27,"context_line":"    service: \"{{ ovsdpdk_services[service_name] }}\""},{"line_number":28,"context_line":"  become: true"},{"line_number":29,"context_line":"  command: \"{{ kolla_container_engine }} exec {{ service.container_name }} ovs-vsctl --no-wait show\""},{"line_number":30,"context_line":"  register: check_result"},{"line_number":31,"context_line":"  until: check_result is success"},{"line_number":32,"context_line":"  changed_when: False"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"62e221d5_83121ca0","line":29,"in_reply_to":"6c0ae71d_1c200a3d","updated":"2022-10-27 11:43:49.000000000","message":"Ack","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"}],"ansible/roles/service-rabbitmq/tasks/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4d9ea58214a35902ab7f1985fc6657f8f234f171","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      delay: \"{{ service_rabbitmq_delay }}\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    - name: \"{{ project_name }} | Ensure RabbitMQ users exist\""},{"line_number":17,"context_line":"      become: true"},{"line_number":18,"context_line":"      kolla_toolbox:"},{"line_number":19,"context_line":"        container_engine: \"{{ kolla_container_engine }}\""},{"line_number":20,"context_line":"        module_name: rabbitmq_user"}],"source_content_type":"text/x-yaml","patch_set":83,"id":"fcbd916d_4281ad40","line":17,"updated":"2023-08-25 10:33:30.000000000","message":"do we really need become here?","commit_id":"7dee5f35eb904c33f1d76a412dd6d7155d802fd1"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"0cd19f504dea98fe51d2ec6c3f1954ca74d82679","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      delay: \"{{ service_rabbitmq_delay }}\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    - name: \"{{ project_name }} | Ensure RabbitMQ users exist\""},{"line_number":17,"context_line":"      become: true"},{"line_number":18,"context_line":"      kolla_toolbox:"},{"line_number":19,"context_line":"        container_engine: \"{{ kolla_container_engine }}\""},{"line_number":20,"context_line":"        module_name: rabbitmq_user"}],"source_content_type":"text/x-yaml","patch_set":83,"id":"f3358274_202308ad","line":17,"in_reply_to":"fcbd916d_4281ad40","updated":"2023-08-25 11:42:30.000000000","message":"Tested it and it is not needed.","commit_id":"7dee5f35eb904c33f1d76a412dd6d7155d802fd1"}],"test-requirements.txt":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"beb3f1a204cd280b535824c13c32810777ddc7de","unresolved":true,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# unit testing"},{"line_number":5,"context_line":"docker\u003e\u003d2.4.2 # Apache-2.0"},{"line_number":6,"context_line":"podman\u003e\u003d4.3.0,\u003c5 # Apache-2.0"},{"line_number":7,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":8,"context_line":"stestr\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":9,"context_line":"ansible\u003e\u003d4,\u003c6 # GPLv3"}],"source_content_type":"text/plain","patch_set":60,"id":"e3c37683_eec70dac","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":15},"updated":"2023-04-06 08:42:24.000000000","message":"this fails the requirementscheck somehow:\n\nhttps://zuul.opendev.org/t/openstack/build/c3e7b932ea9448ef929a96af872ebfee\n\nThe error is:\n\nValidating test-requirements.txt\nERROR: Requirement \u0027{Requirement(package\u003d\u0027podman\u0027, location\u003d\u0027\u0027, specifiers\u003d\u0027\u003c5,\u003e\u003d4.3.0\u0027, markers\u003d\u0027\u0027, comment\u003d\u0027# Apache-2.0\u0027, extras\u003dfrozenset())}\u0027 not in openstack/requirements","commit_id":"8117e08b8bac2347c5fa86a969c67923189da125"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"a81405600bf615a89ad08ccce7ac0384fd49033d","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# unit testing"},{"line_number":5,"context_line":"docker\u003e\u003d2.4.2 # Apache-2.0"},{"line_number":6,"context_line":"podman\u003e\u003d4.3.0,\u003c5 # Apache-2.0"},{"line_number":7,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":8,"context_line":"stestr\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":9,"context_line":"ansible\u003e\u003d4,\u003c6 # GPLv3"}],"source_content_type":"text/plain","patch_set":60,"id":"e5e3b34f_1b09d836","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":15},"in_reply_to":"e3c37683_eec70dac","updated":"2023-04-20 14:25:57.000000000","message":"Done","commit_id":"8117e08b8bac2347c5fa86a969c67923189da125"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"256586b00a7bcabc6540c106c2bdbf368587e7d3","unresolved":true,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# unit testing"},{"line_number":5,"context_line":"docker\u003e\u003d2.4.2 # Apache-2.0"},{"line_number":6,"context_line":"podman\u003e\u003d4.3.0,\u003c5 # Apache-2.0"},{"line_number":7,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":8,"context_line":"stestr\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":9,"context_line":"ansible\u003e\u003d4,\u003c6 # GPLv3"}],"source_content_type":"text/plain","patch_set":75,"id":"4c89093d_9e4f04d0","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":15},"updated":"2023-07-11 16:18:20.000000000","message":"was this removed by accident?","commit_id":"317876b7e8cf6ca17f71a62a9a27a7b88caadf61"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"b8f858ded55e62cf31fa5caccd8e103a746b4fd1","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# unit testing"},{"line_number":5,"context_line":"docker\u003e\u003d2.4.2 # Apache-2.0"},{"line_number":6,"context_line":"podman\u003e\u003d4.3.0,\u003c5 # Apache-2.0"},{"line_number":7,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":8,"context_line":"stestr\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":9,"context_line":"ansible\u003e\u003d4,\u003c6 # GPLv3"}],"source_content_type":"text/plain","patch_set":75,"id":"318d8610_1d4f16d7","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":15},"in_reply_to":"4c89093d_9e4f04d0","updated":"2023-07-12 08:48:09.000000000","message":"No. This line fails the requirements checks because it is currently missing in overall requirements. So, as pre previous discussion, it was moved to tox.ini for the time being.","commit_id":"317876b7e8cf6ca17f71a62a9a27a7b88caadf61"}],"tests/kolla_docker_tests/test_docker_worker.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"492801249ed44c5ba54b959177efa3168e8d8aa7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 NEC Corporation"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":29,"id":"631de937_53889960","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":21},"updated":"2022-10-19 11:18:56.000000000","message":"python3 please. Same in other scripts","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"02a151cbdf4a550e6e04fb532457ec7b5452e26e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 NEC Corporation"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":29,"id":"71f111e1_3b802188","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":21},"in_reply_to":"631de937_53889960","updated":"2022-10-27 11:43:49.000000000","message":"Done","commit_id":"12ccca8052927a3cde3b416dd1bd6a357cc54e95"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ab59726897fdd41a857e1fbabf9bc4c24551308c","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        \u0027common_options\u0027: {"},{"line_number":43,"context_line":"            \u0027container_engine\u0027: \u0027docker\u0027"},{"line_number":44,"context_line":"        },"},{"line_number":45,"context_line":"        \u0027container_engine\u0027: \u0027docker\u0027,"},{"line_number":46,"context_line":"        \u0027api_version\u0027: None,"},{"line_number":47,"context_line":"        \u0027auth_username\u0027: None,"},{"line_number":48,"context_line":"        \u0027auth_password\u0027: None,"}],"source_content_type":"text/x-python","patch_set":106,"id":"9ddabbfd_afc1a16b","line":45,"updated":"2023-10-19 14:41:48.000000000","message":"Why does this parameter have to be given twice?","commit_id":"d3eac801ff2cccbc1a0dd3516f3f206572a41172"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"4a4258836dccbf2f41e605e880e10688605471be","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        \u0027common_options\u0027: {"},{"line_number":43,"context_line":"            \u0027container_engine\u0027: \u0027docker\u0027"},{"line_number":44,"context_line":"        },"},{"line_number":45,"context_line":"        \u0027container_engine\u0027: \u0027docker\u0027,"},{"line_number":46,"context_line":"        \u0027api_version\u0027: None,"},{"line_number":47,"context_line":"        \u0027auth_username\u0027: None,"},{"line_number":48,"context_line":"        \u0027auth_password\u0027: None,"}],"source_content_type":"text/x-python","patch_set":106,"id":"506bea44_3b5184ab","line":45,"in_reply_to":"9ddabbfd_afc1a16b","updated":"2023-10-20 15:53:23.000000000","message":"Its a mistake. Btw, common_options was removed because the generate_module function, which handles it, is mocked inside of the tests.","commit_id":"d3eac801ff2cccbc1a0dd3516f3f206572a41172"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ab59726897fdd41a857e1fbabf9bc4c24551308c","unresolved":true,"context_lines":[{"line_number":240,"context_line":"            mock_dw.return_value.changed \u003d False"},{"line_number":241,"context_line":"            mock_dw.return_value.result \u003d {\"some_key\": \"some_value\"}"},{"line_number":242,"context_line":"            kd.main()"},{"line_number":243,"context_line":"        mock_dw.assert_called_once_with(module_mock)"},{"line_number":244,"context_line":"        mock_dw.return_value.check_image.assert_called_once_with()"},{"line_number":245,"context_line":"        module_mock.exit_json.assert_called_once_with(changed\u003dFalse,"},{"line_number":246,"context_line":"                                                      result\u003dFalse,"},{"line_number":247,"context_line":"                                                      some_key\u003d\"some_value\")"}],"source_content_type":"text/x-python","patch_set":106,"id":"3ffbc391_beee3a9b","line":244,"range":{"start_line":243,"start_character":8,"end_line":244,"end_character":66},"updated":"2023-10-19 14:41:48.000000000","message":"these two lines need to be inside the \"with\" above I think?","commit_id":"d3eac801ff2cccbc1a0dd3516f3f206572a41172"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"4a4258836dccbf2f41e605e880e10688605471be","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            mock_dw.return_value.changed \u003d False"},{"line_number":241,"context_line":"            mock_dw.return_value.result \u003d {\"some_key\": \"some_value\"}"},{"line_number":242,"context_line":"            kd.main()"},{"line_number":243,"context_line":"        mock_dw.assert_called_once_with(module_mock)"},{"line_number":244,"context_line":"        mock_dw.return_value.check_image.assert_called_once_with()"},{"line_number":245,"context_line":"        module_mock.exit_json.assert_called_once_with(changed\u003dFalse,"},{"line_number":246,"context_line":"                                                      result\u003dFalse,"},{"line_number":247,"context_line":"                                                      some_key\u003d\"some_value\")"}],"source_content_type":"text/x-python","patch_set":106,"id":"bb17b7ab_108fa1e8","line":244,"range":{"start_line":243,"start_character":8,"end_line":244,"end_character":66},"in_reply_to":"3ffbc391_beee3a9b","updated":"2023-10-20 15:53:23.000000000","message":"Yes, I am kind of surprised that tox didn\u0027t catch it.","commit_id":"d3eac801ff2cccbc1a0dd3516f3f206572a41172"}],"tests/kolla_docker_tests/test_podman_worker.py":[{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"0b7013194f118c5b49f1500a4e692fe6567b4c68","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from unittest import mock"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslotest import base"},{"line_number":25,"context_line":"from podman import errors as podman_error"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"sys.modules[\u0027dbus\u0027] \u003d mock.MagicMock()"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"abb97021_02102bac","line":25,"in_reply_to":"0763d1c3_34626464","updated":"2022-09-08 08:01:41.000000000","message":"Done","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"aed4ce15f3201f76c36594c1feee058e868d6345","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from unittest import mock"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslotest import base"},{"line_number":25,"context_line":"from podman import errors as podman_error"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"sys.modules[\u0027dbus\u0027] \u003d mock.MagicMock()"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"d963fef2_c44063f7","line":25,"in_reply_to":"456d733a_4c4f1d13","updated":"2022-09-01 07:09:27.000000000","message":"\u003e linters: F401 \u0027podman.errors as podman_error\u0027 imported but unused\n\nPlease fix.","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"aed4ce15f3201f76c36594c1feee058e868d6345","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from unittest import mock"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslotest import base"},{"line_number":25,"context_line":"from podman import errors as podman_error"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"sys.modules[\u0027dbus\u0027] \u003d mock.MagicMock()"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"0763d1c3_34626464","line":25,"in_reply_to":"a4873a2b_7568c834","updated":"2022-09-01 07:09:27.000000000","message":"\u003e pep8: F401 \u0027podman.errors as podman_error\u0027 imported but unused\n\nPlease fix.","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"0b7013194f118c5b49f1500a4e692fe6567b4c68","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from unittest import mock"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslotest import base"},{"line_number":25,"context_line":"from podman import errors as podman_error"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"sys.modules[\u0027dbus\u0027] \u003d mock.MagicMock()"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"cb3f4d97_4e1dbc3f","line":25,"in_reply_to":"d963fef2_c44063f7","updated":"2022-09-08 08:01:41.000000000","message":"Done","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"aed4ce15f3201f76c36594c1feee058e868d6345","unresolved":true,"context_lines":[{"line_number":455,"context_line":"        self.pw.module.fail_json.assert_not_called()"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"#NOTE: create tests for prepare image args"},{"line_number":459,"context_line":"class TestImage(base.BaseTestCase):"},{"line_number":460,"context_line":"    pass"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"411e0b00_4489d7d8","line":458,"in_reply_to":"12d6f67a_27b4d999","updated":"2022-09-01 07:09:27.000000000","message":"\u003e pep8: E265 block comment should start with \u0027# \u0027\n\nPlease fix.","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"0b7013194f118c5b49f1500a4e692fe6567b4c68","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        self.pw.module.fail_json.assert_not_called()"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"#NOTE: create tests for prepare image args"},{"line_number":459,"context_line":"class TestImage(base.BaseTestCase):"},{"line_number":460,"context_line":"    pass"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"b18db64b_be05dbfd","line":458,"in_reply_to":"411e0b00_4489d7d8","updated":"2022-09-08 08:01:41.000000000","message":"Done","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"0b7013194f118c5b49f1500a4e692fe6567b4c68","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        self.pw.module.fail_json.assert_not_called()"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"#NOTE: create tests for prepare image args"},{"line_number":459,"context_line":"class TestImage(base.BaseTestCase):"},{"line_number":460,"context_line":"    pass"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"2e68d0dc_dfc33ada","line":458,"in_reply_to":"e90ee1de_73fe2416","updated":"2022-09-08 08:01:41.000000000","message":"Done","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"aed4ce15f3201f76c36594c1feee058e868d6345","unresolved":true,"context_lines":[{"line_number":455,"context_line":"        self.pw.module.fail_json.assert_not_called()"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"#NOTE: create tests for prepare image args"},{"line_number":459,"context_line":"class TestImage(base.BaseTestCase):"},{"line_number":460,"context_line":"    pass"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"e90ee1de_73fe2416","line":458,"in_reply_to":"ec4e4496_db2ca1d7","updated":"2022-09-01 07:09:27.000000000","message":"\u003e linters: E265 block comment should start with \u0027# \u0027\n\nPlease fix.","commit_id":"a6e938c32cb003cb0ef922fc0a46f550b402e6de"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c873fb43afa4416023f3356784f0a3e5d683ba0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 NEC Corporation"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":71,"id":"ab898aa0_5ea90b38","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":8},"updated":"2023-06-27 16:21:42.000000000","message":"is this correct, as this is a new file?\n\nif this is imported from somewhere else it would be good to note from where it got imported.","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"4f776f5fdf902d3b3ad179271c3ab0eb5538fac1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 NEC Corporation"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":71,"id":"8b09f459_89c419a8","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":8},"in_reply_to":"1731a81b_f3222d85","updated":"2023-08-30 11:14:38.000000000","message":"Sorry, I mistakenly thought that you were referring to the kolla_podman_worker.py instead of the unit test file. Header has been removed for real now (shebang remains for consistency with other test files).","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9b54972d326d2c45588b1778ebb3ff39817be4e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 NEC Corporation"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":71,"id":"993896b5_0f92ab72","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":8},"in_reply_to":"70f4167d_0b58eb5e","updated":"2023-09-01 14:07:26.000000000","message":"so, to just use this changeset as an example - sorry to the authors, this might be a little Off Topic -\n\nwhy is this job important?\nkolla-ansible-debian-aarch64-podman (failed)\n\nbut these are not?\nkolla-ansible-ubuntu-upgrade-cephadm (failed)\nkolla-ansible-debian-ironic (failed)\nkolla-ansible-rocky9-ironic (failed)\nkolla-ansible-debian-zun (failed)\n\nthe aarch64 jobs aren\u0027t even marked, which of those are non voting and which are voting? why is that?\n\nis the complete aarch64 target non voting? it isn\u0027t indicated in the text, I don\u0027t know.\n\nif the target is non voting, why should we inspect it, but not all other non voting failing jobs?\n\nthese are honest questions, I have no working heuristic, or rule or some docs on how to do this.\n\nSo please tell me, somone, how do I know which jobs to check?\n\nI know only the obvious path: zuul gives -1 I see a voting job that failed, I check that job.\n\nthe other path I don\u0027t know.\n\nI\u0027d be very happy if someone could write that down for me and anybody else.\n\nOr if docs exists, I don\u0027t know them, please point me somewhere.\n\nThank you very much in advance!","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"03196c52023ac223137084415c42d1c5e6778fda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 NEC Corporation"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":71,"id":"8de8e0b8_2e84425c","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":8},"in_reply_to":"8b09f459_89c419a8","updated":"2023-08-31 09:12:59.000000000","message":"Done","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e3bea8f85edf7c47f664e8fa84fc9ff47e313be2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 NEC Corporation"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":71,"id":"cf3e20a9_0d0c950a","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":8},"in_reply_to":"8de8e0b8_2e84425c","updated":"2023-09-01 09:19:46.000000000","message":"You are giving -1 for release notes in other reviews, but you don\u0027t mind the non-working functionality on aarch64 ? Why ? In addition, there is no reno or documentation here as well, so what is different in this review so you are ok with it?","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"50a9db279e18f0d5c1fc53797cd38fdae4179e09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 NEC Corporation"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":71,"id":"bf982dc9_4646a858","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":8},"in_reply_to":"ab898aa0_5ea90b38","updated":"2023-08-23 15:02:48.000000000","message":"Yes, this is a new file and the license header was copied from another file, mistakenly including the copyright. It is removed now (along with unnecessary shebang above).","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"268ebe1f2006bae9e3bc5e85d64c94f5ab5351d0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 NEC Corporation"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":71,"id":"1731a81b_f3222d85","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":8},"in_reply_to":"bf982dc9_4646a858","updated":"2023-08-28 16:51:25.000000000","message":"the wrong header still seems to be present, please let the people who did the initial comment decide if the comment was resolved successful.","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ef9e04bb45adfff6760232d83d95f40054af52c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 NEC Corporation"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":71,"id":"70f4167d_0b58eb5e","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":8},"in_reply_to":"cf3e20a9_0d0c950a","updated":"2023-09-01 13:52:54.000000000","message":"you are correct about the missing relnotes!\n\nI simply didn\u0027t catch that, my excuse would be that this is a really large change and I just overlooked it.\n\nThat\u0027s also why large commits are really discouraged. Nobody is physically able to _not_ overlook something in multi-thousand lines of commits. we are imperfect humans after all, and bound to overlook something or make other mistakes.\n\nthat\u0027s why patches should be small and self contained, to reduce the chance of such errors.\n\nin a better world we would have a CI check for missing relnotes when the word \"feature\" is detected in the commit message or something like this and this wouldn\u0027t even need manual review.\n\nwarning: long rant about CI following, skip if you\u0027re not in the mood for that:\n\nregarding the failing jobs on aarch64: I\u0027m honestly tired of our completely broken and erratic attempt of doing CI! At least That is my impression as a \"beginner\" when it comes to almost-full-time contributing to openstack.\n\nif zuul gives \"+1 verified\" that has to have some meaning, no?\nif a job is not gating, not voting, that has to mean something correct?\n\nif a job is deemed \"important\" by someone but it regularly breaks CI that someone should go fix that job, no?\n\nall: please stop complaining that people don\u0027t look at every zuul output if zuul posts a \"+1 verified\" message, or else we should just not let zuul give \"+1\" powers but should do this manually.\n\nthis way lies madness.\n\nfix broken CI but don\u0027t complain to unrelated devs that they don\u0027t look at half broken jobs.\n\neither fix the jobs, if they are important, or remove them, or silence them (like is done now), but don\u0027t complain about silenced jobs, that\u0027s just totally unreasonable imho.\n\nif something is important it should be fixed, that includes hard to fix jobs.\nif it\u0027s not that important after all, maybe jobs or architectures should be removed.\nSomeone had some interest in these arches, so probably they should fix the jobs to make them voting/gating again.\n\nI know this can be a lot of work.\n\nas a dev I want to be able to trust zuul, if I can\u0027t trust our CI jobs, what are they good for?\n\nthe current expected behaviour, even from core devs, is frankly, not good.\n\n\"look at these jobs, sometimes there are important errors in there, sometimes not\"\n\"what you want a list of jobs, which are non voting but are sometimes important? go, ask on IRC, there are no docs about this\".\n\nthis is a completely broken, undocumented and opaque approach, especially for a \"newbie\" contributor like me - that\u0027s what I consider myself at least.\n\nthis also slows down reviews by a lot, especially for beginners.\n\nI might be able to tell if some code is good/bad, but to know which CI job is \"okay\" to fail seems like an NP hard problem to me, which requires half the time guessing, reading thousands of log lines and asking more experienced devs if this error can be ignored or not.\n\nso if we want to let reviews grind to a halt, because of half broken jobs, I guess we are successful.\n\nAt the very least there should be a document _somewhere_ which jobs to check under what condition. if that already exists nobody did explain that to me. This would still be very bad, instead of fixing jobs, but I know that might not be possible to do fast, so documentation would be the next best thing, if the actual problem (broken ci jobs) can\u0027t be fixed.\n\nsorry for the rant, but I\u0027m really frustrated about the CI, not about anyone personally, I know it\u0027s hard to fix this stuff. I hope I didn\u0027t offend anybody, because that\u0027s really not what I want, I want to improve not just the tech but also our organization/workflow.\n\nI think this part of the CI should be improved by a lot, and that must not necessarily be via technical means (fixing jobs), but could also be partly achieved by better docs, better explanations, maybe a tutorial how to identify which broken non voting jobs are important. Sure fixed jobs that always work would be the dream come true. For now I at least demand better docs. I can also write them, but I don\u0027t know what to write down, so at least I would need help with that.\n\n/rant","commit_id":"377d6272ed39b79f116e5fa95cb04d9c973d141e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ab59726897fdd41a857e1fbabf9bc4c24551308c","unresolved":true,"context_lines":[{"line_number":181,"context_line":"            mock_pw.return_value.changed \u003d False"},{"line_number":182,"context_line":"            mock_pw.return_value.result \u003d {\"some_key\": \"some_value\"}"},{"line_number":183,"context_line":"            kd.main()"},{"line_number":184,"context_line":"        mock_pw.assert_called_once_with(module_mock)"},{"line_number":185,"context_line":"        mock_pw.return_value.check_image.assert_called_once_with()"},{"line_number":186,"context_line":"        module_mock.exit_json.assert_called_once_with(changed\u003dFalse,"},{"line_number":187,"context_line":"                                                      result\u003dFalse,"},{"line_number":188,"context_line":"                                                      some_key\u003d\"some_value\")"}],"source_content_type":"text/x-python","patch_set":106,"id":"8182a5e5_e0512b98","line":185,"range":{"start_line":184,"start_character":8,"end_line":185,"end_character":66},"updated":"2023-10-19 14:41:48.000000000","message":"these belong into the \"with\"?","commit_id":"d3eac801ff2cccbc1a0dd3516f3f206572a41172"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5d767d10bec68a05b2662efb2e83ef23b8368936","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            mock_pw.return_value.changed \u003d False"},{"line_number":182,"context_line":"            mock_pw.return_value.result \u003d {\"some_key\": \"some_value\"}"},{"line_number":183,"context_line":"            kd.main()"},{"line_number":184,"context_line":"        mock_pw.assert_called_once_with(module_mock)"},{"line_number":185,"context_line":"        mock_pw.return_value.check_image.assert_called_once_with()"},{"line_number":186,"context_line":"        module_mock.exit_json.assert_called_once_with(changed\u003dFalse,"},{"line_number":187,"context_line":"                                                      result\u003dFalse,"},{"line_number":188,"context_line":"                                                      some_key\u003d\"some_value\")"}],"source_content_type":"text/x-python","patch_set":106,"id":"ec5dc0da_6e63dd84","line":185,"range":{"start_line":184,"start_character":8,"end_line":185,"end_character":66},"in_reply_to":"8182a5e5_e0512b98","updated":"2023-10-20 12:53:37.000000000","message":"Done","commit_id":"d3eac801ff2cccbc1a0dd3516f3f206572a41172"}],"tests/setup_gate.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c45a5da7a160de4ab51f3391d66fc30801ab9e46","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    sudo tee -a /etc/kolla/kolla-build.conf \u003c\u003cEOF"},{"line_number":106,"context_line":"[DEFAULT]"},{"line_number":107,"context_line":"engine \u003d ${CONTAINER_ENGINE}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"[profiles]"}],"source_content_type":"text/x-sh","patch_set":96,"id":"992b95c6_a1afd355","line":106,"range":{"start_line":106,"start_character":1,"end_line":106,"end_character":8},"updated":"2023-09-26 10:42:58.000000000","message":"missing newline before this line.\nalso, why is this in all caps? does it need to be? the rest of the sections are not in all caps. So, if possible, please keep the style consistent 😊","commit_id":"7b294d49e6d30169c37d6c1483c09c4ca7f7902a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2c946fb79672aa3ecaf7911ebb91c95945b18bdd","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    sudo tee -a /etc/kolla/kolla-build.conf \u003c\u003cEOF"},{"line_number":106,"context_line":"[DEFAULT]"},{"line_number":107,"context_line":"engine \u003d ${CONTAINER_ENGINE}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"[profiles]"}],"source_content_type":"text/x-sh","patch_set":96,"id":"e156e39d_624abc89","line":106,"range":{"start_line":106,"start_character":1,"end_line":106,"end_character":8},"in_reply_to":"992b95c6_a1afd355","updated":"2023-09-26 11:12:05.000000000","message":"Haha, Sven have you ever seen oslo config file ? :D [DEFAULT] section is always caps :D (in all openstack services using oslo.config). \n\nMissing newline ? why ? Newline is on line 108 which divides one section from other section, no newline needed.\n\nThis is regular nice config file \u003e\u003e \n\n[DEFAULT]\nengine \u003d ${CONTAINER_ENGINE}\n\n[profiles]\ngate \u003d whatever,blabla\n\n\n\u003c\u003c\u003c\u003c\n\n\n\nIf you want to see how kolla-build.conf looks like, you can do this \n\nmichalarbet@pixla:/tmp$ git clone https://github.com/openstack/kolla; python3 -m venv /tmp/sven ; . /tmp/sven/bin/activate; pip3 install -e kolla \u003e /dev/null 2\u003e\u00261; pip3 install oslo.config \u003e /dev/null 2\u003e\u00261; oslo-config-generator --config-file kolla/etc/oslo-config-generator/kolla-build.conf  --output-file /tmp/sven-config ; head -n 2 /tmp/sven-config\nCloning into \u0027kolla\u0027...\nremote: Enumerating objects: 88350, done.\nremote: Counting objects: 100% (1990/1990), done.\nremote: Compressing objects: 100% (822/822), done.\nremote: Total 88350 (delta 1343), reused 1647 (delta 1140), pack-reused 86360\nReceiving objects: 100% (88350/88350), 16.66 MiB | 9.59 MiB/s, done.\nResolving deltas: 100% (53972/53972), done.\n\n[DEFAULT]\n\n\n\n\nSo, marking as resolved because all is irrelevant.","commit_id":"7b294d49e6d30169c37d6c1483c09c4ca7f7902a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"876bc2bcf93a623a100a1112b0a4422aeeb5a847","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    sudo tee -a /etc/kolla/kolla-build.conf \u003c\u003cEOF"},{"line_number":106,"context_line":"[DEFAULT]"},{"line_number":107,"context_line":"engine \u003d ${CONTAINER_ENGINE}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"[profiles]"}],"source_content_type":"text/x-sh","patch_set":96,"id":"1fc2c1a3_f713d0f9","line":106,"range":{"start_line":106,"start_character":1,"end_line":106,"end_character":8},"in_reply_to":"e156e39d_624abc89","updated":"2023-09-26 11:32:47.000000000","message":"Ok. I\u0027m horribly bad at remembering config file syntax 😄","commit_id":"7b294d49e6d30169c37d6c1483c09c4ca7f7902a"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"400c8301f211454d059a87cb51ffbada37712ad8","unresolved":true,"context_lines":[{"line_number":20,"context_line":"- job:"},{"line_number":21,"context_line":"    name: kolla-ansible-debian-aarch64-podman"},{"line_number":22,"context_line":"    parent: kolla-ansible-debian"},{"line_number":23,"context_line":"    nodeset: kolla-ansible-debian-bullseye-aarch64"},{"line_number":24,"context_line":"    timeout: 10800"},{"line_number":25,"context_line":"    vars:"},{"line_number":26,"context_line":"      container_engine: podman"}],"source_content_type":"text/x-yaml","patch_set":96,"id":"51fe02f4_1bebc389","line":23,"range":{"start_line":23,"start_character":34,"end_line":23,"end_character":42},"updated":"2023-09-26 11:42:24.000000000","message":"bookworm?","commit_id":"7b294d49e6d30169c37d6c1483c09c4ca7f7902a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9643a7d91070770dc80b40186975c43f52f2c384","unresolved":false,"context_lines":[{"line_number":20,"context_line":"- job:"},{"line_number":21,"context_line":"    name: kolla-ansible-debian-aarch64-podman"},{"line_number":22,"context_line":"    parent: kolla-ansible-debian"},{"line_number":23,"context_line":"    nodeset: kolla-ansible-debian-bullseye-aarch64"},{"line_number":24,"context_line":"    timeout: 10800"},{"line_number":25,"context_line":"    vars:"},{"line_number":26,"context_line":"      container_engine: podman"}],"source_content_type":"text/x-yaml","patch_set":96,"id":"9d4a89e2_1a4651f8","line":23,"range":{"start_line":23,"start_character":34,"end_line":23,"end_character":42},"in_reply_to":"51fe02f4_1bebc389","updated":"2023-09-26 18:43:41.000000000","message":"Thanks, good catch.","commit_id":"7b294d49e6d30169c37d6c1483c09c4ca7f7902a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"400c8301f211454d059a87cb51ffbada37712ad8","unresolved":true,"context_lines":[{"line_number":38,"context_line":"- job:"},{"line_number":39,"context_line":"    name: kolla-ansible-debian-podman"},{"line_number":40,"context_line":"    parent: kolla-ansible-base"},{"line_number":41,"context_line":"    nodeset: kolla-ansible-debian-bullseye"},{"line_number":42,"context_line":"    vars:"},{"line_number":43,"context_line":"      base_distro: debian"},{"line_number":44,"context_line":"      tls_enabled: true"}],"source_content_type":"text/x-yaml","patch_set":96,"id":"223598cf_b87700ff","line":41,"range":{"start_line":41,"start_character":34,"end_line":41,"end_character":42},"updated":"2023-09-26 11:42:24.000000000","message":"bookworm?","commit_id":"7b294d49e6d30169c37d6c1483c09c4ca7f7902a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9643a7d91070770dc80b40186975c43f52f2c384","unresolved":false,"context_lines":[{"line_number":38,"context_line":"- job:"},{"line_number":39,"context_line":"    name: kolla-ansible-debian-podman"},{"line_number":40,"context_line":"    parent: kolla-ansible-base"},{"line_number":41,"context_line":"    nodeset: kolla-ansible-debian-bullseye"},{"line_number":42,"context_line":"    vars:"},{"line_number":43,"context_line":"      base_distro: debian"},{"line_number":44,"context_line":"      tls_enabled: true"}],"source_content_type":"text/x-yaml","patch_set":96,"id":"e0ac2111_9942b031","line":41,"range":{"start_line":41,"start_character":34,"end_line":41,"end_character":42},"in_reply_to":"223598cf_b87700ff","updated":"2023-09-26 18:43:41.000000000","message":"Thanks, nice.","commit_id":"7b294d49e6d30169c37d6c1483c09c4ca7f7902a"}],"zuul.d/project.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ab59726897fdd41a857e1fbabf9bc4c24551308c","unresolved":true,"context_lines":[{"line_number":18,"context_line":"        - kolla-ansible-rocky9"},{"line_number":19,"context_line":"        - kolla-ansible-rocky9-podman"},{"line_number":20,"context_line":"        - kolla-ansible-ubuntu"},{"line_number":21,"context_line":"        - kolla-ansible-ubuntu-podman"},{"line_number":22,"context_line":"        - kolla-ansible-rocky9-kvm"},{"line_number":23,"context_line":"        - kolla-ansible-ubuntu-kvm"},{"line_number":24,"context_line":"        - kolla-ansible-rocky9-multinode-ipv6"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"8de1f9a4_03ac8265","line":21,"updated":"2023-10-19 14:41:48.000000000","message":"The podman jobs should either be non-voting for now or also be added into the gate queue. I\u0027m fine with either option.","commit_id":"d3eac801ff2cccbc1a0dd3516f3f206572a41172"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"4a4258836dccbf2f41e605e880e10688605471be","unresolved":true,"context_lines":[{"line_number":18,"context_line":"        - kolla-ansible-rocky9"},{"line_number":19,"context_line":"        - kolla-ansible-rocky9-podman"},{"line_number":20,"context_line":"        - kolla-ansible-ubuntu"},{"line_number":21,"context_line":"        - kolla-ansible-ubuntu-podman"},{"line_number":22,"context_line":"        - kolla-ansible-rocky9-kvm"},{"line_number":23,"context_line":"        - kolla-ansible-ubuntu-kvm"},{"line_number":24,"context_line":"        - kolla-ansible-rocky9-multinode-ipv6"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"a4afae01_b7e803a8","line":21,"in_reply_to":"8de1f9a4_03ac8265","updated":"2023-10-20 15:53:23.000000000","message":"Added jobs to gate for now.","commit_id":"d3eac801ff2cccbc1a0dd3516f3f206572a41172"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3b0919e01078cb83b509b627085abe32f6a049de","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        - kolla-ansible-rocky9"},{"line_number":19,"context_line":"        - kolla-ansible-rocky9-podman"},{"line_number":20,"context_line":"        - kolla-ansible-ubuntu"},{"line_number":21,"context_line":"        - kolla-ansible-ubuntu-podman"},{"line_number":22,"context_line":"        - kolla-ansible-rocky9-kvm"},{"line_number":23,"context_line":"        - kolla-ansible-ubuntu-kvm"},{"line_number":24,"context_line":"        - kolla-ansible-rocky9-multinode-ipv6"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"3db33a4f_c4a9ca1a","line":21,"in_reply_to":"a4afae01_b7e803a8","updated":"2023-10-23 10:16:30.000000000","message":"Done","commit_id":"d3eac801ff2cccbc1a0dd3516f3f206572a41172"}]}