)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c0fe41f52492b215906dd70f5d94d6b400eba57d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5772dcd7_b539b081","updated":"2022-03-23 19:34:22.000000000","message":"thx","commit_id":"ab391331b708db5f234d044ba7d062c598a89fbe"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"37bb63548e01cf51dc7a062ef74fcb03e04319bd","unresolved":true,"context_lines":[{"line_number":968,"context_line":"designate_internal_endpoint: \"{{ internal_protocol }}://{{ designate_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ designate_api_port }}\""},{"line_number":969,"context_line":"designate_public_endpoint: \"{{ public_protocol }}://{{ designate_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ designate_api_port }}\""},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"designate_enable_notifications: \"yes\""},{"line_number":972,"context_line":"designate_notifications_topic_name: \"notifications_designate\""},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"#######################"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"817aa236_f3e3a5a3","line":971,"range":{"start_line":971,"start_character":0,"end_line":971,"end_character":30},"updated":"2022-03-24 10:07:03.000000000","message":"designate_enable_notifications_sink (I encourage you to add \"sink\" to it to better reflect which notifications these are)","commit_id":"ab391331b708db5f234d044ba7d062c598a89fbe"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"04d52765903a668289244cf1aa25f605501eaba4","unresolved":false,"context_lines":[{"line_number":968,"context_line":"designate_internal_endpoint: \"{{ internal_protocol }}://{{ designate_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ designate_api_port }}\""},{"line_number":969,"context_line":"designate_public_endpoint: \"{{ public_protocol }}://{{ designate_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ designate_api_port }}\""},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"designate_enable_notifications: \"yes\""},{"line_number":972,"context_line":"designate_notifications_topic_name: \"notifications_designate\""},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"#######################"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ab6f9baf_88e65233","line":971,"range":{"start_line":971,"start_character":0,"end_line":971,"end_character":30},"in_reply_to":"817aa236_f3e3a5a3","updated":"2022-03-24 10:17:45.000000000","message":"Done","commit_id":"ab391331b708db5f234d044ba7d062c598a89fbe"}],"ansible/roles/designate/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"50457299f89c020cc72b8f2ff84d7234a25fb842","unresolved":true,"context_lines":[{"line_number":312,"context_line":"####################"},{"line_number":313,"context_line":"# Notifications"},{"line_number":314,"context_line":"####################"},{"line_number":315,"context_line":"designate_enable_notifications: \"yes\""},{"line_number":316,"context_line":"designate_notifications_topic_name: \"notifications_designate\""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"designate_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d4758443_8338a7d9","line":315,"range":{"start_line":315,"start_character":0,"end_line":315,"end_character":30},"updated":"2021-08-18 10:52:57.000000000","message":"Do we need to distinguish between designate generating notifications vs consuming them? It looks like currently we are using designate_notifications_topic_name for both, but that doesn\u0027t seem quite right to me. I suppose that\u0027s a separate issue.\n\nWould designate_enable_sink be clearer?","commit_id":"078a38cc80df4de7dd7443995b15be8d5353998e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2cac27b54239032e62b08e4fa86aedffdf283597","unresolved":false,"context_lines":[{"line_number":312,"context_line":"####################"},{"line_number":313,"context_line":"# Notifications"},{"line_number":314,"context_line":"####################"},{"line_number":315,"context_line":"designate_enable_notifications: \"yes\""},{"line_number":316,"context_line":"designate_notifications_topic_name: \"notifications_designate\""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"designate_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a264318_5d8cc6cb","line":315,"range":{"start_line":315,"start_character":0,"end_line":315,"end_character":30},"in_reply_to":"d4758443_8338a7d9","updated":"2022-03-23 13:09:18.000000000","message":"Ack","commit_id":"078a38cc80df4de7dd7443995b15be8d5353998e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3f989089c857c2755e8405a22fde28602f88241e","unresolved":true,"context_lines":[{"line_number":312,"context_line":"####################"},{"line_number":313,"context_line":"# Notifications"},{"line_number":314,"context_line":"####################"},{"line_number":315,"context_line":"designate_enable_notifications: \"yes\""},{"line_number":316,"context_line":"designate_notifications_topic_name: \"notifications_designate\""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"designate_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9b6c0093_4013ab0f","line":315,"updated":"2022-01-24 05:50:08.000000000","message":"_enable_sink? Or do you really want to use two different vars?","commit_id":"99a4080700dd2b490d5d8ec7036035735141e5a3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2cac27b54239032e62b08e4fa86aedffdf283597","unresolved":false,"context_lines":[{"line_number":312,"context_line":"####################"},{"line_number":313,"context_line":"# Notifications"},{"line_number":314,"context_line":"####################"},{"line_number":315,"context_line":"designate_enable_notifications: \"yes\""},{"line_number":316,"context_line":"designate_notifications_topic_name: \"notifications_designate\""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"designate_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f6465d04_450baca7","line":315,"in_reply_to":"9b6c0093_4013ab0f","updated":"2022-03-23 13:09:18.000000000","message":"Actually did one - if notifications are disabled, then sink is not deployed.","commit_id":"99a4080700dd2b490d5d8ec7036035735141e5a3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"37bb63548e01cf51dc7a062ef74fcb03e04319bd","unresolved":true,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"designate_notification_topics:"},{"line_number":318,"context_line":"  - name: \"{{ designate_notifications_topic_name }}\""},{"line_number":319,"context_line":"    enabled: True"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"designate_enabled_notification_topics: \"{{ designate_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":322,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"25342c23_51819e95","side":"PARENT","line":319,"range":{"start_line":319,"start_character":13,"end_line":319,"end_character":17},"updated":"2022-03-24 10:07:03.000000000","message":"this should also be controlled by the new boolean","commit_id":"8f05a309d148ee5f0f4ebc2cfb609c170362b771"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"04d52765903a668289244cf1aa25f605501eaba4","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"designate_notification_topics:"},{"line_number":318,"context_line":"  - name: \"{{ designate_notifications_topic_name }}\""},{"line_number":319,"context_line":"    enabled: True"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"designate_enabled_notification_topics: \"{{ designate_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":322,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e51c770e_58adcce6","side":"PARENT","line":319,"range":{"start_line":319,"start_character":13,"end_line":319,"end_character":17},"in_reply_to":"25342c23_51819e95","updated":"2022-03-24 10:17:45.000000000","message":"Done","commit_id":"8f05a309d148ee5f0f4ebc2cfb609c170362b771"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a983c648359c50b31a6b11aef209f1548ae97dae","unresolved":false,"context_lines":[{"line_number":314,"context_line":"####################"},{"line_number":315,"context_line":"designate_notification_topics:"},{"line_number":316,"context_line":"  - name: \"{{ designate_notifications_topic_name }}\""},{"line_number":317,"context_line":"    enabled: \"{{ designate_enable_notifications_sink | bool }}\""},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"designate_enabled_notification_topics: \"{{ designate_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":320,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4ab76256_0d135d01","line":317,"updated":"2022-03-24 10:23:08.000000000","message":"Final thoughts - I\u0027m not entirely convinced this is needed at all - designate does not seem to need to consume its own notifications. But I leave it as an extra optimisation exercise for someone to look into when they are bored.","commit_id":"a19e1eb44e6a74c60a687278240737f3697ab018"}],"ansible/roles/designate/templates/designate.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3f989089c857c2755e8405a22fde28602f88241e","unresolved":true,"context_lines":[{"line_number":65,"context_line":"max_retries \u003d 10"},{"line_number":66,"context_line":"idle_timeout \u003d 3600"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"{% if designate_enable_notifications | bool %}"},{"line_number":69,"context_line":"[handler:nova_fixed]"},{"line_number":70,"context_line":"#NOTE: zone_id must be manually filled an ID from openstack zone list"},{"line_number":71,"context_line":"zone_id \u003d"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"2b2b64df_cd515f22","line":68,"updated":"2022-01-24 05:50:08.000000000","message":"_enable_sink ?","commit_id":"99a4080700dd2b490d5d8ec7036035735141e5a3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2cac27b54239032e62b08e4fa86aedffdf283597","unresolved":false,"context_lines":[{"line_number":65,"context_line":"max_retries \u003d 10"},{"line_number":66,"context_line":"idle_timeout \u003d 3600"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"{% if designate_enable_notifications | bool %}"},{"line_number":69,"context_line":"[handler:nova_fixed]"},{"line_number":70,"context_line":"#NOTE: zone_id must be manually filled an ID from openstack zone list"},{"line_number":71,"context_line":"zone_id \u003d"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"291be089_df90effc","line":68,"in_reply_to":"2b2b64df_cd515f22","updated":"2022-03-23 13:09:18.000000000","message":"Ack","commit_id":"99a4080700dd2b490d5d8ec7036035735141e5a3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"37bb63548e01cf51dc7a062ef74fcb03e04319bd","unresolved":true,"context_lines":[{"line_number":59,"context_line":"max_retries \u003d 10"},{"line_number":60,"context_line":"idle_timeout \u003d 3600"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"{% if designate_enable_notifications | bool %}"},{"line_number":63,"context_line":"[service:sink]"},{"line_number":64,"context_line":"enabled_notification_handlers \u003d nova_fixed, neutron_floatingip"},{"line_number":65,"context_line":"workers \u003d {{ openstack_service_workers }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9fb27d11_92ba02f6","line":62,"updated":"2022-03-24 10:07:03.000000000","message":"this could also include the \"if service_name\" stanza so that we don\u0027t pollute all designate services with this config (yes, this is an improvement and not related to the patch but it makes sense to change it since we touch it already)","commit_id":"ab391331b708db5f234d044ba7d062c598a89fbe"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"04d52765903a668289244cf1aa25f605501eaba4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"max_retries \u003d 10"},{"line_number":60,"context_line":"idle_timeout \u003d 3600"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"{% if designate_enable_notifications | bool %}"},{"line_number":63,"context_line":"[service:sink]"},{"line_number":64,"context_line":"enabled_notification_handlers \u003d nova_fixed, neutron_floatingip"},{"line_number":65,"context_line":"workers \u003d {{ openstack_service_workers }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"239e8ffa_e9be73c8","line":62,"in_reply_to":"9fb27d11_92ba02f6","updated":"2022-03-24 10:17:45.000000000","message":"Done","commit_id":"ab391331b708db5f234d044ba7d062c598a89fbe"}],"ansible/roles/placement/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"37bb63548e01cf51dc7a062ef74fcb03e04319bd","unresolved":true,"context_lines":[{"line_number":86,"context_line":"  - name: notifications"},{"line_number":87,"context_line":"    enabled: \"{{ enable_ceilometer | bool or enable_neutron_infoblox_ipam_agent | bool }}\""},{"line_number":88,"context_line":"  - name: \"{{ designate_notifications_topic_name }}\""},{"line_number":89,"context_line":"    enabled: \"{{ designate_enable_notifications | bool }}\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"placement_enabled_notification_topics: \"{{ placement_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"eef6dc8d_44a2b8b4","line":89,"updated":"2022-03-24 10:07:03.000000000","message":"oddly, our designate-sink config ignores placement events; additionally, the designate docs do not mention placement so I\u0027m assuming this is needlessly polluting rmq - please consider proposing as a fix","commit_id":"ab391331b708db5f234d044ba7d062c598a89fbe"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"04d52765903a668289244cf1aa25f605501eaba4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  - name: notifications"},{"line_number":87,"context_line":"    enabled: \"{{ enable_ceilometer | bool or enable_neutron_infoblox_ipam_agent | bool }}\""},{"line_number":88,"context_line":"  - name: \"{{ designate_notifications_topic_name }}\""},{"line_number":89,"context_line":"    enabled: \"{{ designate_enable_notifications | bool }}\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"placement_enabled_notification_topics: \"{{ placement_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c50b88de_685d444c","line":89,"in_reply_to":"8398cc0e_249710e6","updated":"2022-03-24 10:17:45.000000000","message":"Done","commit_id":"ab391331b708db5f234d044ba7d062c598a89fbe"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fb0de84b0ab5b8a288169e8070466ec7d6a80fbe","unresolved":true,"context_lines":[{"line_number":86,"context_line":"  - name: notifications"},{"line_number":87,"context_line":"    enabled: \"{{ enable_ceilometer | bool or enable_neutron_infoblox_ipam_agent | bool }}\""},{"line_number":88,"context_line":"  - name: \"{{ designate_notifications_topic_name }}\""},{"line_number":89,"context_line":"    enabled: \"{{ designate_enable_notifications | bool }}\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"placement_enabled_notification_topics: \"{{ placement_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4efefd27_e8152009","line":89,"in_reply_to":"8398cc0e_249710e6","updated":"2022-03-24 10:14:43.000000000","message":"Yes, that\u0027s my thinking as well.","commit_id":"ab391331b708db5f234d044ba7d062c598a89fbe"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"46863cc045ffeeb49920f9c731844bdd609de1d0","unresolved":true,"context_lines":[{"line_number":86,"context_line":"  - name: notifications"},{"line_number":87,"context_line":"    enabled: \"{{ enable_ceilometer | bool or enable_neutron_infoblox_ipam_agent | bool }}\""},{"line_number":88,"context_line":"  - name: \"{{ designate_notifications_topic_name }}\""},{"line_number":89,"context_line":"    enabled: \"{{ designate_enable_notifications | bool }}\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"placement_enabled_notification_topics: \"{{ placement_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8398cc0e_249710e6","line":89,"in_reply_to":"eef6dc8d_44a2b8b4","updated":"2022-03-24 10:10:30.000000000","message":"I think it has been just copied when splitting Placement out of Nova.\nFrom Designate Sink docs: designate-sink is an optional service which listens for event Notifications, such as compute.instance.create.end, handlers are available for Nova and Neutron","commit_id":"ab391331b708db5f234d044ba7d062c598a89fbe"}]}