)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"79b20bf750d6b70cf4361276f006438db1d44899","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"74f7bfe9_a6037553","updated":"2022-03-23 13:05:21.000000000","message":"I still have this on my todo list and in particular I wanted to create a release note which I think is needed for this. More comments inline.","commit_id":"fb81bd5c808b9b16f2bcce1221bd7946b5794f16"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4ab071885b4450e065117d79b7b41c4c114ca5a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3525937a_668e922e","updated":"2022-03-23 13:05:59.000000000","message":"recheck logs expired","commit_id":"fb81bd5c808b9b16f2bcce1221bd7946b5794f16"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05132ba2606a87feda9de73a314b91628e0cfdb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ad314d25_9f39751e","updated":"2022-03-24 08:06:09.000000000","message":"I don\u0027t want to +2 my own amendments","commit_id":"f193d1af3e4ab9b6978eb42e761e37222d9ca0b2"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"79b20bf750d6b70cf4361276f006438db1d44899","unresolved":true,"context_lines":[{"line_number":959,"context_line":"# Valid options are [ bind9, infoblox ]"},{"line_number":960,"context_line":"designate_backend: \"bind9\""},{"line_number":961,"context_line":"designate_ns_record:"},{"line_number":962,"context_line":"  - \"ns1.sample.openstack.org\""},{"line_number":963,"context_line":"designate_backend_external: \"no\""},{"line_number":964,"context_line":"designate_backend_external_bind9_nameservers: \"\""},{"line_number":965,"context_line":"# Valid options are [ \u0027\u0027, redis ]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e2a6bb74_8ffce013","line":962,"updated":"2022-03-23 13:05:21.000000000","message":"No directly related, but I\u0027d very much prefer to use \"example.org\" as default instead of a domain that is in real use.","commit_id":"fb81bd5c808b9b16f2bcce1221bd7946b5794f16"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a58b30aa5af9bf19925c34c29648ca28aaa69e9e","unresolved":false,"context_lines":[{"line_number":959,"context_line":"# Valid options are [ bind9, infoblox ]"},{"line_number":960,"context_line":"designate_backend: \"bind9\""},{"line_number":961,"context_line":"designate_ns_record:"},{"line_number":962,"context_line":"  - \"ns1.sample.openstack.org\""},{"line_number":963,"context_line":"designate_backend_external: \"no\""},{"line_number":964,"context_line":"designate_backend_external_bind9_nameservers: \"\""},{"line_number":965,"context_line":"# Valid options are [ \u0027\u0027, redis ]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0ed694f9_6e64c337","line":962,"in_reply_to":"e2a6bb74_8ffce013","updated":"2022-03-23 14:04:27.000000000","message":"Done","commit_id":"fb81bd5c808b9b16f2bcce1221bd7946b5794f16"}],"ansible/roles/designate/templates/pools.yaml.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"79b20bf750d6b70cf4361276f006438db1d44899","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  description: Default BIND9 Pool"},{"line_number":5,"context_line":"  attributes: {}"},{"line_number":6,"context_line":"  ns_records:"},{"line_number":7,"context_line":"    {% for host in designate_ns_record %}"},{"line_number":8,"context_line":"    - hostname: {{ host}}."},{"line_number":9,"context_line":"      priority: 1"},{"line_number":10,"context_line":"    {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"6679a5e9_b886974a","line":7,"updated":"2022-03-23 13:05:21.000000000","message":"Can we somehow handle the old config smoothly? IIUC this code would produce one hostname entry for each letter in the configured hostname?","commit_id":"fb81bd5c808b9b16f2bcce1221bd7946b5794f16"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a58b30aa5af9bf19925c34c29648ca28aaa69e9e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  description: Default BIND9 Pool"},{"line_number":5,"context_line":"  attributes: {}"},{"line_number":6,"context_line":"  ns_records:"},{"line_number":7,"context_line":"    {% for host in designate_ns_record %}"},{"line_number":8,"context_line":"    - hostname: {{ host}}."},{"line_number":9,"context_line":"      priority: 1"},{"line_number":10,"context_line":"    {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa2f82a4_372f375b","line":7,"in_reply_to":"6679a5e9_b886974a","updated":"2022-03-23 14:04:27.000000000","message":"Done","commit_id":"fb81bd5c808b9b16f2bcce1221bd7946b5794f16"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5232dc170cbf5ed3c3edb21914f0754fb34cec02","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  description: Default BIND9 Pool"},{"line_number":5,"context_line":"  attributes: {}"},{"line_number":6,"context_line":"  ns_records:"},{"line_number":7,"context_line":"    {% if designate_ns_record is iterable %}"},{"line_number":8,"context_line":"    {% for host in designate_ns_record %}"},{"line_number":9,"context_line":"    - hostname: {{ host}}."},{"line_number":10,"context_line":"      priority: 1"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"098013a4_106a335b","line":7,"updated":"2022-03-24 07:30:12.000000000","message":"This doesn\u0027t work, as a string is iterable, resulting in a list of chars.\n\nWe can check for \"is string\" instead and then keep the old variant, let me push a patch.","commit_id":"32b0e0d90c1a01b7d74f68887b78f40852d9f242"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"aa66bfd5ad7ec8fe689af6f599576182a1a26745","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  description: Default BIND9 Pool"},{"line_number":5,"context_line":"  attributes: {}"},{"line_number":6,"context_line":"  ns_records:"},{"line_number":7,"context_line":"    {% if designate_ns_record is iterable %}"},{"line_number":8,"context_line":"    {% for host in designate_ns_record %}"},{"line_number":9,"context_line":"    - hostname: {{ host}}."},{"line_number":10,"context_line":"      priority: 1"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bf3c19f6_eb71ad91","line":7,"in_reply_to":"098013a4_106a335b","updated":"2022-03-24 07:39:21.000000000","message":"FYI the indendation of the {% %} statements is also breaking the yaml formatting, see the result in the magnum job:\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_4c2/802304/5/check/kolla-ansible-ubuntu-source-magnum/4c24d32/primary/logs/kolla_configs/designate-worker/pools.yaml","commit_id":"32b0e0d90c1a01b7d74f68887b78f40852d9f242"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05132ba2606a87feda9de73a314b91628e0cfdb9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  description: Default BIND9 Pool"},{"line_number":5,"context_line":"  attributes: {}"},{"line_number":6,"context_line":"  ns_records:"},{"line_number":7,"context_line":"    {% if designate_ns_record is iterable %}"},{"line_number":8,"context_line":"    {% for host in designate_ns_record %}"},{"line_number":9,"context_line":"    - hostname: {{ host}}."},{"line_number":10,"context_line":"      priority: 1"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"aa213a10_f06127ee","line":7,"in_reply_to":"bf3c19f6_eb71ad91","updated":"2022-03-24 08:06:09.000000000","message":"Done","commit_id":"32b0e0d90c1a01b7d74f68887b78f40852d9f242"}],"ansible/roles/neutron/templates/neutron.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"79b20bf750d6b70cf4361276f006438db1d44899","unresolved":true,"context_lines":[{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if enable_designate | bool %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ designate_ns_record }}."},{"line_number":69,"context_line":"external_dns_driver \u003d designate"},{"line_number":70,"context_line":"{% if neutron_plugin_agent \u003d\u003d \u0027vmware_nsxv\u0027 %}"},{"line_number":71,"context_line":"nsx_extension_drivers \u003d vmware_nsxv_dns"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9953ad75_72a4aa1a","side":"PARENT","line":68,"updated":"2022-03-23 13:05:21.000000000","message":"Shouldn\u0027t we continue to default this to the previous value?","commit_id":"8f05a309d148ee5f0f4ebc2cfb609c170362b771"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"acc4ceb8e88df59e568cda620b2ae2d323ac2afc","unresolved":false,"context_lines":[{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if enable_designate | bool %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ designate_ns_record }}."},{"line_number":69,"context_line":"external_dns_driver \u003d designate"},{"line_number":70,"context_line":"{% if neutron_plugin_agent \u003d\u003d \u0027vmware_nsxv\u0027 %}"},{"line_number":71,"context_line":"nsx_extension_drivers \u003d vmware_nsxv_dns"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"87d30d73_8bacef5c","side":"PARENT","line":68,"in_reply_to":"9953ad75_72a4aa1a","updated":"2022-03-23 13:28:18.000000000","message":"For now yes, don\u0027t remember how it got here.","commit_id":"8f05a309d148ee5f0f4ebc2cfb609c170362b771"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05132ba2606a87feda9de73a314b91628e0cfdb9","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if enable_designate | bool %}"},{"line_number":68,"context_line":"{% if designate_ns_record is string %}"},{"line_number":69,"context_line":"dns_domain \u003d {{ designate_ns_record }}."},{"line_number":70,"context_line":"{% endif %}"},{"line_number":71,"context_line":"external_dns_driver \u003d designate"},{"line_number":72,"context_line":"{% if neutron_plugin_agent \u003d\u003d \u0027vmware_nsxv\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"f58e37f3_12c42087","line":69,"updated":"2022-03-24 08:06:09.000000000","message":"I\u0027ve kept this for backwards compatibility, although it is really nonsense to use the same variable here as for the pool config. Might want to address this is a dedicated patch though.","commit_id":"f193d1af3e4ab9b6978eb42e761e37222d9ca0b2"}],"doc/source/reference/networking/designate-guide.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05132ba2606a87feda9de73a314b91628e0cfdb9","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"   dns_interface: \"eth1\""},{"line_number":38,"context_line":"   designate_ns_record:"},{"line_number":39,"context_line":"     - \"ns1.sample.openstack.org\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. important::"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"8f86ef8f_a7c4e8bc","line":39,"updated":"2022-03-24 08:06:09.000000000","message":"All the examples in this doc are using openstack.org, will clean up in another patch.","commit_id":"f193d1af3e4ab9b6978eb42e761e37222d9ca0b2"}]}