)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f64ffc10203f3536c1bc4c62096a6c65a2721158","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patchs adds two new vars to control retry behaviour."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The defaults preserve the previous behaviour of no extra tries"},{"line_number":18,"context_line":"to make this patch backportable."},{"line_number":19,"context_line":"For CI, we can override this for all relevant branches."},{"line_number":20,"context_line":"For end users of Xena+, we might want to set a larger"},{"line_number":21,"context_line":"default too."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fc18d681_c704ed07","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":32},"updated":"2021-08-09 09:18:42.000000000","message":"I think we can allow behaviour change where it fixes a bug or improves reliability.","commit_id":"d6c3ef16f0c80fa41e697671559ab27dd5143817"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c90f33bd2975a08ab033fa9c969e41d40bd51503","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patchs adds two new vars to control retry behaviour."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The defaults preserve the previous behaviour of no extra tries"},{"line_number":18,"context_line":"to make this patch backportable."},{"line_number":19,"context_line":"For CI, we can override this for all relevant branches."},{"line_number":20,"context_line":"For end users of Xena+, we might want to set a larger"},{"line_number":21,"context_line":"default too."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"11678a2b_2b52cf7f","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":32},"in_reply_to":"23af0977_f26cc4c1","updated":"2021-08-19 18:40:58.000000000","message":"Done","commit_id":"d6c3ef16f0c80fa41e697671559ab27dd5143817"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dd6d0ce8696500d8bd2a2351ff7dbce16f13b097","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patchs adds two new vars to control retry behaviour."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The defaults preserve the previous behaviour of no extra tries"},{"line_number":18,"context_line":"to make this patch backportable."},{"line_number":19,"context_line":"For CI, we can override this for all relevant branches."},{"line_number":20,"context_line":"For end users of Xena+, we might want to set a larger"},{"line_number":21,"context_line":"default too."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"23af0977_f26cc4c1","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":32},"in_reply_to":"fc18d681_c704ed07","updated":"2021-08-09 09:29:24.000000000","message":"Ok, I\u0027m all in if PTL even proposes that approach. 😊","commit_id":"d6c3ef16f0c80fa41e697671559ab27dd5143817"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"545e91e4f25379d6b31a64daea3bba169fcfde00","unresolved":true,"context_lines":[{"line_number":47,"context_line":"# Valid options are [ binary, source ]"},{"line_number":48,"context_line":"kolla_install_type: \"binary\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# Kolla image pulling settings: the amount of retries and the delay (in seconds)"},{"line_number":51,"context_line":"# between them. These are useful if your registry is not 100% reliable (usually"},{"line_number":52,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":53,"context_line":"# and ``delay``, respectively."},{"line_number":54,"context_line":"kolla_image_pull_retries: 3"},{"line_number":55,"context_line":"kolla_image_pull_delay: 5"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"kolla_internal_vip_address: \"{{ kolla_internal_address | default(\u0027\u0027) }}\""},{"line_number":58,"context_line":"kolla_internal_fqdn: \"{{ kolla_internal_vip_address }}\""},{"line_number":59,"context_line":"kolla_external_vip_address: \"{{ kolla_internal_vip_address }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f32c0f1c_668879a6","line":56,"range":{"start_line":50,"start_character":0,"end_line":56,"end_character":0},"updated":"2021-08-11 08:43:17.000000000","message":"nit: this doesn\u0027t feel like quite the right place for these options. Most people won\u0027t need to touch them, but they\u0027re in the middle of the most commonly used options. Suggest they go at least below the VIP/FQDN stuff?","commit_id":"e03db5c0b5cb81cedf961b23c3ac115cebb364f1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"64143e6ea8813109bd5a78bc948f65cde7cda749","unresolved":true,"context_lines":[{"line_number":47,"context_line":"# Valid options are [ binary, source ]"},{"line_number":48,"context_line":"kolla_install_type: \"binary\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# Kolla image pulling settings: the amount of retries and the delay (in seconds)"},{"line_number":51,"context_line":"# between them. These are useful if your registry is not 100% reliable (usually"},{"line_number":52,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":53,"context_line":"# and ``delay``, respectively."},{"line_number":54,"context_line":"kolla_image_pull_retries: 3"},{"line_number":55,"context_line":"kolla_image_pull_delay: 5"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"kolla_internal_vip_address: \"{{ kolla_internal_address | default(\u0027\u0027) }}\""},{"line_number":58,"context_line":"kolla_internal_fqdn: \"{{ kolla_internal_vip_address }}\""},{"line_number":59,"context_line":"kolla_external_vip_address: \"{{ kolla_internal_vip_address }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c0981156_7121ef1d","line":56,"range":{"start_line":50,"start_character":0,"end_line":56,"end_character":0},"in_reply_to":"beaf5f9b_0ed46bc7","updated":"2021-08-11 08:59:33.000000000","message":"True, but globals.yml roughly mirrors this one, and the same argument applies there IMO","commit_id":"e03db5c0b5cb81cedf961b23c3ac115cebb364f1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c90f33bd2975a08ab033fa9c969e41d40bd51503","unresolved":false,"context_lines":[{"line_number":47,"context_line":"# Valid options are [ binary, source ]"},{"line_number":48,"context_line":"kolla_install_type: \"binary\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# Kolla image pulling settings: the amount of retries and the delay (in seconds)"},{"line_number":51,"context_line":"# between them. These are useful if your registry is not 100% reliable (usually"},{"line_number":52,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":53,"context_line":"# and ``delay``, respectively."},{"line_number":54,"context_line":"kolla_image_pull_retries: 3"},{"line_number":55,"context_line":"kolla_image_pull_delay: 5"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"kolla_internal_vip_address: \"{{ kolla_internal_address | default(\u0027\u0027) }}\""},{"line_number":58,"context_line":"kolla_internal_fqdn: \"{{ kolla_internal_vip_address }}\""},{"line_number":59,"context_line":"kolla_external_vip_address: \"{{ kolla_internal_vip_address }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"db0f3789_c2b8a3f9","line":56,"range":{"start_line":50,"start_character":0,"end_line":56,"end_character":0},"in_reply_to":"c0981156_7121ef1d","updated":"2021-08-19 18:40:58.000000000","message":"Done","commit_id":"e03db5c0b5cb81cedf961b23c3ac115cebb364f1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2efcf1e8590e587600fa004901a1b51a7bda2340","unresolved":true,"context_lines":[{"line_number":47,"context_line":"# Valid options are [ binary, source ]"},{"line_number":48,"context_line":"kolla_install_type: \"binary\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# Kolla image pulling settings: the amount of retries and the delay (in seconds)"},{"line_number":51,"context_line":"# between them. These are useful if your registry is not 100% reliable (usually"},{"line_number":52,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":53,"context_line":"# and ``delay``, respectively."},{"line_number":54,"context_line":"kolla_image_pull_retries: 3"},{"line_number":55,"context_line":"kolla_image_pull_delay: 5"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"kolla_internal_vip_address: \"{{ kolla_internal_address | default(\u0027\u0027) }}\""},{"line_number":58,"context_line":"kolla_internal_fqdn: \"{{ kolla_internal_vip_address }}\""},{"line_number":59,"context_line":"kolla_external_vip_address: \"{{ kolla_internal_vip_address }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"beaf5f9b_0ed46bc7","line":56,"range":{"start_line":50,"start_character":0,"end_line":56,"end_character":0},"in_reply_to":"f32c0f1c_668879a6","updated":"2021-08-11 08:55:26.000000000","message":"People don\u0027t modify this file, they modify globals.yml (below) and I think the placement there is just fine. I tried to reflect it in both files similarly. We can obviously avoid adding this to globals.yml because, as you said, there is an extremely low chance one would want to tweak those (as there is hardly a better setting - if the registry is overly flaky, we are going to have issues no matter what 😊 ).","commit_id":"e03db5c0b5cb81cedf961b23c3ac115cebb364f1"}],"ansible/roles/service-images-pull/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"03a097b52d0c41bb3fa3ea7ebca78223eb330832","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":5,"context_line":"# and ``delay``, respectively."},{"line_number":6,"context_line":"kolla_image_pull_retries: 3"},{"line_number":7,"context_line":"kolla_image_pull_delay: 5"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"159bdd19_f7adbb54","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"updated":"2021-08-12 08:09:47.000000000","message":"debate merits of using the role name as a prefix for variables, e.g. service_images_pull_delay","commit_id":"228d9de39369b059b876e68785e3843332fb9baf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"11cc53666806acc2e5924eff435139f3bcb1412c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":5,"context_line":"# and ``delay``, respectively."},{"line_number":6,"context_line":"kolla_image_pull_retries: 3"},{"line_number":7,"context_line":"kolla_image_pull_delay: 5"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ee2946a9_79b4de8e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"159bdd19_f7adbb54","updated":"2021-08-12 09:12:43.000000000","message":"I\u0027m unsure. I would prefer to prefix kolla vars with kolla_ to avoid any collisions (however unlikely). kolla_service_images_pull_delay works for me, albeit being a bit overly verbose. WDYT?","commit_id":"228d9de39369b059b876e68785e3843332fb9baf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d43bae629de8fa6aff2cb49856b65bf7f4c69636","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":5,"context_line":"# and ``delay``, respectively."},{"line_number":6,"context_line":"kolla_image_pull_retries: 3"},{"line_number":7,"context_line":"kolla_image_pull_delay: 5"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"92536b85_662e9c81","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"2b427254_a91521ac","updated":"2021-08-18 12:23:40.000000000","message":"Well, these are very kolla-specific unlike the roles from Galaxy so I would argue we should then best rename the roles to include kolla in their names. WDYT? I would rename this role to kolla-service-images-pull and then adapt the variable names (need plural, missed it).","commit_id":"228d9de39369b059b876e68785e3843332fb9baf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"322fa97731e9fd11bae18744ddbd1b52eb9bcc1a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":5,"context_line":"# and ``delay``, respectively."},{"line_number":6,"context_line":"kolla_image_pull_retries: 3"},{"line_number":7,"context_line":"kolla_image_pull_delay: 5"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"cd9cfd15_c0582a9a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"80768e72_f2d16455","updated":"2021-08-19 17:31:36.000000000","message":"Hmm, yeah, probably not worth it for now.","commit_id":"228d9de39369b059b876e68785e3843332fb9baf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a34518b13d84e2c07e64d69c0676e60e985ddf09","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":5,"context_line":"# and ``delay``, respectively."},{"line_number":6,"context_line":"kolla_image_pull_retries: 3"},{"line_number":7,"context_line":"kolla_image_pull_delay: 5"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"80768e72_f2d16455","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"92536b85_662e9c81","updated":"2021-08-19 07:56:02.000000000","message":"That seems a bit heavy-handed, and would involve rewriting quite a lot of existing code","commit_id":"228d9de39369b059b876e68785e3843332fb9baf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e2c23102147358dfb76672f8b786725705a41ab3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":5,"context_line":"# and ``delay``, respectively."},{"line_number":6,"context_line":"kolla_image_pull_retries: 3"},{"line_number":7,"context_line":"kolla_image_pull_delay: 5"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"201a16d4_51e455b7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"cd9cfd15_c0582a9a","updated":"2021-08-19 18:40:30.000000000","message":"Done","commit_id":"228d9de39369b059b876e68785e3843332fb9baf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"53680a45f64be00593f63973aa5ce46d35d3c0de","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":5,"context_line":"# and ``delay``, respectively."},{"line_number":6,"context_line":"kolla_image_pull_retries: 3"},{"line_number":7,"context_line":"kolla_image_pull_delay: 5"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2b427254_a91521ac","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"ee2946a9_79b4de8e","updated":"2021-08-16 09:01:31.000000000","message":"Collisions with what? User defined variables? Agreed, very unlikely. A kolla_ prefix is quite common for \u0027global\u0027 variables, but for role variables we (and most sensible people in the ansible world) usually prefix with the role name, to provide psuedo-namespacing.","commit_id":"228d9de39369b059b876e68785e3843332fb9baf"}],"etc/kolla/globals.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"03a097b52d0c41bb3fa3ea7ebca78223eb330832","unresolved":true,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Optionally change the path to sysctl.conf modified by Kolla Ansible plays."},{"line_number":72,"context_line":"#kolla_sysctl_conf_path: /etc/sysctl.conf"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"#############################"},{"line_number":75,"context_line":"# Kolla image pulling options"},{"line_number":76,"context_line":"#############################"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Kolla image pulling settings: the amount of retries and the delay (in seconds)"},{"line_number":79,"context_line":"# between them. These are useful if your registry is not 100% reliable (usually"},{"line_number":80,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":81,"context_line":"# and ``delay``, respectively."},{"line_number":82,"context_line":"#kolla_image_pull_retries: 3"},{"line_number":83,"context_line":"#kolla_image_pull_delay: 5"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"################"},{"line_number":86,"context_line":"# Docker options"},{"line_number":87,"context_line":"################"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dfecd628_d4cf4955","line":84,"range":{"start_line":73,"start_character":0,"end_line":84,"end_character":0},"updated":"2021-08-12 08:09:47.000000000","message":"Do we think users will want to change these?","commit_id":"228d9de39369b059b876e68785e3843332fb9baf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e2c23102147358dfb76672f8b786725705a41ab3","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Optionally change the path to sysctl.conf modified by Kolla Ansible plays."},{"line_number":72,"context_line":"#kolla_sysctl_conf_path: /etc/sysctl.conf"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"#############################"},{"line_number":75,"context_line":"# Kolla image pulling options"},{"line_number":76,"context_line":"#############################"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Kolla image pulling settings: the amount of retries and the delay (in seconds)"},{"line_number":79,"context_line":"# between them. These are useful if your registry is not 100% reliable (usually"},{"line_number":80,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":81,"context_line":"# and ``delay``, respectively."},{"line_number":82,"context_line":"#kolla_image_pull_retries: 3"},{"line_number":83,"context_line":"#kolla_image_pull_delay: 5"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"################"},{"line_number":86,"context_line":"# Docker options"},{"line_number":87,"context_line":"################"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a19c0b3e_da5deebc","line":84,"range":{"start_line":73,"start_character":0,"end_line":84,"end_character":0},"in_reply_to":"17d48772_2326303b","updated":"2021-08-19 18:40:30.000000000","message":"Done","commit_id":"228d9de39369b059b876e68785e3843332fb9baf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"11cc53666806acc2e5924eff435139f3bcb1412c","unresolved":true,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Optionally change the path to sysctl.conf modified by Kolla Ansible plays."},{"line_number":72,"context_line":"#kolla_sysctl_conf_path: /etc/sysctl.conf"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"#############################"},{"line_number":75,"context_line":"# Kolla image pulling options"},{"line_number":76,"context_line":"#############################"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Kolla image pulling settings: the amount of retries and the delay (in seconds)"},{"line_number":79,"context_line":"# between them. These are useful if your registry is not 100% reliable (usually"},{"line_number":80,"context_line":"# due to load). They modify the Ansible image pulling task params ``retries``"},{"line_number":81,"context_line":"# and ``delay``, respectively."},{"line_number":82,"context_line":"#kolla_image_pull_retries: 3"},{"line_number":83,"context_line":"#kolla_image_pull_delay: 5"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"################"},{"line_number":86,"context_line":"# Docker options"},{"line_number":87,"context_line":"################"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"17d48772_2326303b","line":84,"range":{"start_line":73,"start_character":0,"end_line":84,"end_character":0},"in_reply_to":"dfecd628_d4cf4955","updated":"2021-08-12 09:12:43.000000000","message":"I doubt? I proposed to remove and eager to do so. 😄","commit_id":"228d9de39369b059b876e68785e3843332fb9baf"}]}