)]}'
{"ansible/roles/haproxy-config/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"97d5eca94431fdb8fc80e8da0bf6b6b35f13b9ad","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"haproxy_health_check: \"check inter 2000 rise 2 fall 5\""},{"line_number":16,"context_line":"haproxy_health_check_ssl: \"check check-ssl inter 2000 rise 2 fall 5\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"haproxy_enable_federation_openid: \"{{ keystone_identity_providers | selectattr(\u0027protocol\u0027,\u0027equalto\u0027,\u0027openid\u0027) | list | count \u003e 0 }}\""},{"line_number":19,"context_line":"haproxy_enable_federation_saml2: \"{{ keystone_identity_providers | selectattr(\u0027protocol\u0027,\u0027equalto\u0027,\u0027saml2\u0027) | list | count \u003e 0 }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b88eb32a_285ec379","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":130},"updated":"2021-08-17 10:03:30.000000000","message":"I don\u0027t see where these are used.","commit_id":"459ed07da207a3fe836ac9b6e75b34c764789325"}],"ansible/roles/keystone/defaults/main.yml":[{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"5369463f27ffde771769c9ecdc9fd44e7c070b51","unresolved":true,"context_lines":[{"line_number":198,"context_line":"keystone_federation_oidc_scopes: \"openid email profile\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"# SAML2 defaults."},{"line_number":201,"context_line":"keystone_container_federation_saml2_metadata_folder: \"{{ \u0027/etc/apache2/metadata\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027/etc/httpd/metadata\u0027 }}\""},{"line_number":202,"context_line":"keystone_container_federation_saml2_certificate_folder: \"{{ \u0027/etc/apache2/cert\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027/etc/httpd/cert\u0027 }}\""},{"line_number":203,"context_line":"keystone_host_federation_saml2_metadata_folder: \"{{ node_config_directory }}/keystone/federation/saml2/metadata\""},{"line_number":204,"context_line":"keystone_host_federation_saml2_certificate_folder: \"{{ node_config_directory }}/keystone/federation/saml2/cert\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d8e774b4_e0d202df","line":201,"updated":"2021-08-17 14:25:13.000000000","message":"this shouldn\u0027t be from within keystone default variables, they should be within the keystone.json.j2 directly.","commit_id":"459ed07da207a3fe836ac9b6e75b34c764789325"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"5369463f27ffde771769c9ecdc9fd44e7c070b51","unresolved":true,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"# SAML2 defaults."},{"line_number":201,"context_line":"keystone_container_federation_saml2_metadata_folder: \"{{ \u0027/etc/apache2/metadata\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027/etc/httpd/metadata\u0027 }}\""},{"line_number":202,"context_line":"keystone_container_federation_saml2_certificate_folder: \"{{ \u0027/etc/apache2/cert\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027/etc/httpd/cert\u0027 }}\""},{"line_number":203,"context_line":"keystone_host_federation_saml2_metadata_folder: \"{{ node_config_directory }}/keystone/federation/saml2/metadata\""},{"line_number":204,"context_line":"keystone_host_federation_saml2_certificate_folder: \"{{ node_config_directory }}/keystone/federation/saml2/cert\""},{"line_number":205,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"37dcea29_b28f203e","line":202,"updated":"2021-08-17 14:25:13.000000000","message":"same than upper.","commit_id":"459ed07da207a3fe836ac9b6e75b34c764789325"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"5369463f27ffde771769c9ecdc9fd44e7c070b51","unresolved":true,"context_lines":[{"line_number":200,"context_line":"# SAML2 defaults."},{"line_number":201,"context_line":"keystone_container_federation_saml2_metadata_folder: \"{{ \u0027/etc/apache2/metadata\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027/etc/httpd/metadata\u0027 }}\""},{"line_number":202,"context_line":"keystone_container_federation_saml2_certificate_folder: \"{{ \u0027/etc/apache2/cert\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027/etc/httpd/cert\u0027 }}\""},{"line_number":203,"context_line":"keystone_host_federation_saml2_metadata_folder: \"{{ node_config_directory }}/keystone/federation/saml2/metadata\""},{"line_number":204,"context_line":"keystone_host_federation_saml2_certificate_folder: \"{{ node_config_directory }}/keystone/federation/saml2/cert\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# These variables are used to define multiple trusted Horizon dashboards."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2941dca6_bf0b57e0","line":203,"updated":"2021-08-17 14:25:13.000000000","message":"same than upper.","commit_id":"459ed07da207a3fe836ac9b6e75b34c764789325"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"5369463f27ffde771769c9ecdc9fd44e7c070b51","unresolved":true,"context_lines":[{"line_number":201,"context_line":"keystone_container_federation_saml2_metadata_folder: \"{{ \u0027/etc/apache2/metadata\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027/etc/httpd/metadata\u0027 }}\""},{"line_number":202,"context_line":"keystone_container_federation_saml2_certificate_folder: \"{{ \u0027/etc/apache2/cert\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027/etc/httpd/cert\u0027 }}\""},{"line_number":203,"context_line":"keystone_host_federation_saml2_metadata_folder: \"{{ node_config_directory }}/keystone/federation/saml2/metadata\""},{"line_number":204,"context_line":"keystone_host_federation_saml2_certificate_folder: \"{{ node_config_directory }}/keystone/federation/saml2/cert\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# These variables are used to define multiple trusted Horizon dashboards."},{"line_number":207,"context_line":"# keystone_trusted_dashboards: [\u0027\u003chttps://dashboardServerOne/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerTwo/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerN/auth/websso/\u003e\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5cd4ac6a_5ee548fb","line":204,"updated":"2021-08-17 14:25:13.000000000","message":"same than upper.","commit_id":"459ed07da207a3fe836ac9b6e75b34c764789325"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"5369463f27ffde771769c9ecdc9fd44e7c070b51","unresolved":true,"context_lines":[{"line_number":207,"context_line":"# keystone_trusted_dashboards: [\u0027\u003chttps://dashboardServerOne/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerTwo/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerN/auth/websso/\u003e\u0027]"},{"line_number":208,"context_line":"keystone_trusted_dashboards: \"{{ [\u0027%s://%s/auth/websso/\u0027 % (public_protocol, kolla_external_fqdn), \u0027%s/auth/websso/\u0027 % (horizon_public_endpoint)] if enable_horizon | bool else [] }}\""},{"line_number":209,"context_line":"keystone_enable_federation_openid: \"{{ enable_keystone_federation | bool and keystone_identity_providers | selectattr(\u0027protocol\u0027,\u0027equalto\u0027,\u0027openid\u0027) | list | count \u003e 0 }}\""},{"line_number":210,"context_line":"keystone_enable_federation_saml2: \"{{ enable_keystone_federation | bool and keystone_identity_providers | selectattr(\u0027protocol\u0027,\u0027equalto\u0027,\u0027saml2\u0027) | list | count \u003e 0 }}\""},{"line_number":211,"context_line":"keystone_should_remove_attribute_mappings: False"},{"line_number":212,"context_line":"keystone_should_remove_identity_providers: False"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"09f18b06_3048b99f","line":210,"updated":"2021-08-17 14:25:13.000000000","message":"We should have enable_keystone_federation as a bool and then a keystone_federation_type variable which is an enum of (OIDC|SAML2).\n\nAnd this is also something that should apply to the OIDC patch.","commit_id":"459ed07da207a3fe836ac9b6e75b34c764789325"}],"ansible/roles/keystone/templates/keystone.conf.j2":[{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"5369463f27ffde771769c9ecdc9fd44e7c070b51","unresolved":true,"context_lines":[{"line_number":90,"context_line":"remote_id_attribute \u003d {{ keystone_remote_id_attribute_oidc }}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"[saml2]"},{"line_number":93,"context_line":"remote_id_attribute \u003d MELLON_IDP"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"[auth]"},{"line_number":96,"context_line":"methods \u003d password,token,openid,saml2,application_credential"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"b5c745da_c5410423","line":93,"range":{"start_line":93,"start_character":22,"end_line":93,"end_character":32},"updated":"2021-08-17 14:25:13.000000000","message":"This should be variabilize as customers may change it.","commit_id":"459ed07da207a3fe836ac9b6e75b34c764789325"}]}