)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"deb4c39f0279b7036717165f8a9f9e524cebd713","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow setting any_errors_fatal true for gather-facts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Additional info and reasoning available in the included reno."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7a74b937ded0b9da0621cf413f3a5d0d13a2cd68"},{"line_number":12,"context_line":"Partial-Bug: #1833737"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"471093c3_14ac5f4c","line":9,"updated":"2022-10-10 10:13:03.000000000","message":"Would it hurt much to copy that info here? Would make it much easier when reading git logs.","commit_id":"c1d10980c2303cae199aa9c0bcc45b68afd8b482"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d231b1ef7460b9dc1203bd443e1d95b278a4bd6a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow setting any_errors_fatal true for gather-facts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Additional info and reasoning available in the included reno."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7a74b937ded0b9da0621cf413f3a5d0d13a2cd68"},{"line_number":12,"context_line":"Partial-Bug: #1833737"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c2494f5e_91a8423f","line":9,"in_reply_to":"471093c3_14ac5f4c","updated":"2022-10-10 11:10:39.000000000","message":"Ok, makes sense. /me lazy with formatting","commit_id":"c1d10980c2303cae199aa9c0bcc45b68afd8b482"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e78f75a52622dbab0d01d1ab0350370af9e30af7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow setting any_errors_fatal true for gather-facts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Additional info and reasoning available in the included reno."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7a74b937ded0b9da0621cf413f3a5d0d13a2cd68"},{"line_number":12,"context_line":"Partial-Bug: #1833737"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c07b8c80_0f61cafc","line":9,"in_reply_to":"c2494f5e_91a8423f","updated":"2022-10-10 11:17:01.000000000","message":"Done","commit_id":"c1d10980c2303cae199aa9c0bcc45b68afd8b482"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"28df4f53e5b8d623ea27b49590209815d4b26b2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7ede7d36_ace22732","updated":"2022-04-29 14:25:18.000000000","message":"220429 13:05:44 mysqld_safe WSREP: Failed to recover position: \u0027/usr/sbin/mariadbd: 2: Syntax error: Unterminated quoted string\u0027\n\nreally curious","commit_id":"22479588f7c84839b20281a1b6e163797ca0b546"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a1093cf016b3fedb43b5f8caec64de85167a8352","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"60397847_8780ec82","updated":"2022-05-03 09:09:49.000000000","message":"I still think that max_fail_percentage is better, since it provides equivalent functionality and more.","commit_id":"22479588f7c84839b20281a1b6e163797ca0b546"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"3156e4cf974b5e23a3d096cc54aea4f9de70eac1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2042390f_8756aa9f","updated":"2022-04-29 12:25:46.000000000","message":"looks good, useful feature","commit_id":"22479588f7c84839b20281a1b6e163797ca0b546"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a252c91a4b92b41bfa0983a55df3ef939a980457","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"795ff897_87d06b19","updated":"2022-04-29 14:24:33.000000000","message":"recheck\n\nsome random mariadb issue?","commit_id":"22479588f7c84839b20281a1b6e163797ca0b546"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3047cef89cbdb0f05b9f1f86a6fa2fa8fd358961","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9e096e7f_8a7f1555","in_reply_to":"60397847_8780ec82","updated":"2022-05-04 18:50:10.000000000","message":"I find it hard to justify a max_fail_percentage different than 0 or 100 for fact gathering. It makes more sense in cases like nova computes but in here I stand strongly with favoring only any_errors_fatal. Unless you are thinking about splitting this fact gathering per node role (compute, network etc.) - then we could make it configurable per that and max_fail_percentage would make sense.","commit_id":"22479588f7c84839b20281a1b6e163797ca0b546"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"65c78e55c8eac24c94051b9b7f228eab974d2720","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"650d32a6_581f7821","in_reply_to":"9e096e7f_8a7f1555","updated":"2022-05-04 18:51:42.000000000","message":"An example to justify my reasoning. Suppose you have 25 computes and 3 controllers, if 1 controller fails then the playbooks will fail later on whatever you do unless you exclude it. What value of max_fail_percentage would help you then?","commit_id":"22479588f7c84839b20281a1b6e163797ca0b546"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ace76bba6e1c709f4413c7a4e895cdf4779f09fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"47d8e189_9d66157c","updated":"2022-10-10 07:06:57.000000000","message":"rebased and applied ansible-lint recommendations re booleans","commit_id":"c1d10980c2303cae199aa9c0bcc45b68afd8b482"},{"author":{"_account_id":34533,"name":"Ramona Beermann","display_name":"ra-beer","email":"ramona.beermann@osism.tech","username":"ramonarautenberg"},"change_message_id":"0cc282a1b23fa93b168d98cee1117b8cb729ebfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0f13cb96_74874472","updated":"2022-10-11 10:51:29.000000000","message":"LGTM. My opinion is: Changing true to yes is not needed since ansible-lint sometimes mark it as wrong. All boolean Ansible variables should change to true or false in the future.","commit_id":"5b431f0f7f932293362a01703673ee05d0a5bd8d"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"99da09a05a32f7541efa8f323c745b2522c3e193","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e01012c4_afafdeab","updated":"2022-11-22 08:45:29.000000000","message":"let me ignore \"yes\" vs true fight.","commit_id":"5b431f0f7f932293362a01703673ee05d0a5bd8d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e78f75a52622dbab0d01d1ab0350370af9e30af7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"499831fb_5f0575be","updated":"2022-10-10 11:17:01.000000000","message":"ty","commit_id":"5b431f0f7f932293362a01703673ee05d0a5bd8d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3a268ff68b3adb929609548522058e0f7332aed0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b4ce13b8_23e56b60","in_reply_to":"0f13cb96_74874472","updated":"2022-10-11 11:46:53.000000000","message":"That\u0027s right. The very reason why I default to ``true`` now and avoid strings altogether as well.","commit_id":"5b431f0f7f932293362a01703673ee05d0a5bd8d"}],"etc/kolla/globals.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"fef9363fa1c2141af489de5747c3cc81e22f8f8f","unresolved":true,"context_lines":[{"line_number":27,"context_line":"# due to missing facts (especially cross-host)."},{"line_number":28,"context_line":"# Do note this still supports host fact caching and it will not affect"},{"line_number":29,"context_line":"# scenarios with all facts cached (as there is no task to fail)."},{"line_number":30,"context_line":"#kolla_ansible_setup_any_errors_fatal: no"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"###############"},{"line_number":33,"context_line":"# Kolla options"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4dbfae6d_cd01f41e","line":30,"range":{"start_line":30,"start_character":39,"end_line":30,"end_character":41},"updated":"2022-04-29 12:51:47.000000000","message":"\"no\"","commit_id":"22479588f7c84839b20281a1b6e163797ca0b546"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f6d30ff55605c30a010f9451da1e3d908a5e4c85","unresolved":true,"context_lines":[{"line_number":27,"context_line":"# due to missing facts (especially cross-host)."},{"line_number":28,"context_line":"# Do note this still supports host fact caching and it will not affect"},{"line_number":29,"context_line":"# scenarios with all facts cached (as there is no task to fail)."},{"line_number":30,"context_line":"#kolla_ansible_setup_any_errors_fatal: no"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"###############"},{"line_number":33,"context_line":"# Kolla options"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c65ecf69_8f80f203","line":30,"range":{"start_line":30,"start_character":39,"end_line":30,"end_character":41},"in_reply_to":"4dbfae6d_cd01f41e","updated":"2022-04-29 13:21:32.000000000","message":"It seems I\u0027m challenging this \"quote everything\" approach. Let\u0027s not amend unless other issues are spotted.","commit_id":"22479588f7c84839b20281a1b6e163797ca0b546"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3fafb0b606b2d6e8365f3bc2c897b1da170e8128","unresolved":true,"context_lines":[{"line_number":27,"context_line":"# due to missing facts (especially cross-host)."},{"line_number":28,"context_line":"# Do note this still supports host fact caching and it will not affect"},{"line_number":29,"context_line":"# scenarios with all facts cached (as there is no task to fail)."},{"line_number":30,"context_line":"#kolla_ansible_setup_any_errors_fatal: no"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"###############"},{"line_number":33,"context_line":"# Kolla options"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fdec694e_ac6250f9","line":30,"range":{"start_line":30,"start_character":39,"end_line":30,"end_character":41},"in_reply_to":"c65ecf69_8f80f203","updated":"2022-04-29 13:33:30.000000000","message":"Haha, I\u0027m just trying to do my best when reviewing and when I\u0027ve checked globals.. most of these yes/no values had quotation marks, but yeah it works in both cases :)","commit_id":"22479588f7c84839b20281a1b6e163797ca0b546"}],"releasenotes/notes/facts-any-errors-fatal-44cae85bc7e225d7.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1613ab4f8047c3e3a1d432a80b086a3ba3369185","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Kolla Ansible will now fail execution early if fact collection fails"},{"line_number":5,"context_line":"    on any of the hosts to avoid late failures due to missing facts"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"85d44996_756302a9","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2021-08-19 09:43:50.000000000","message":"I wonder if it\u0027s better to move it to fixes and refer the LP. WDYT?","commit_id":"d62c071d22bed4ac815933f28b55655332d5a8f9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1d4abc8934855968b642950124d3422d26b391ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Kolla Ansible will now fail execution early if fact collection fails"},{"line_number":5,"context_line":"    on any of the hosts to avoid late failures due to missing facts"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"667e9f19_2b14d7a3","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"85d44996_756302a9","updated":"2022-04-29 12:18:27.000000000","message":"Done","commit_id":"d62c071d22bed4ac815933f28b55655332d5a8f9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"296690a142e2298c2f66ea51a8b70fc63015acfd","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Kolla Ansible will now fail execution early if fact collection fails"},{"line_number":5,"context_line":"    on any of the hosts to avoid late failures due to missing facts"},{"line_number":6,"context_line":"    (especially cross-host). This is done by setting ``any_errors_fatal: true``."},{"line_number":7,"context_line":"    Do note this still supports host fact caching and it will not affect"},{"line_number":8,"context_line":"    scenarios with all facts cached (as there is no task to fail)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f0ab388_7de599dd","line":6,"updated":"2021-08-23 14:08:48.000000000","message":"D001 Line too long","commit_id":"d62c071d22bed4ac815933f28b55655332d5a8f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0dd804866dc993895e2ad24ea8fe81e93d249bf4","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Kolla Ansible will now fail execution early if fact collection fails"},{"line_number":5,"context_line":"    on any of the hosts to avoid late failures due to missing facts"},{"line_number":6,"context_line":"    (especially cross-host). This is done by setting ``any_errors_fatal: true``."},{"line_number":7,"context_line":"    Do note this still supports host fact caching and it will not affect"},{"line_number":8,"context_line":"    scenarios with all facts cached (as there is no task to fail)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"660bab8c_03389315","line":6,"in_reply_to":"01e67c29_bdb648bd","updated":"2021-08-25 08:44:34.000000000","message":"Lesser mortals may appreciate the pointer","commit_id":"d62c071d22bed4ac815933f28b55655332d5a8f9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"44046a825a8eb72379e6b77a388c235d69c8f87a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Kolla Ansible will now fail execution early if fact collection fails"},{"line_number":5,"context_line":"    on any of the hosts to avoid late failures due to missing facts"},{"line_number":6,"context_line":"    (especially cross-host). This is done by setting ``any_errors_fatal: true``."},{"line_number":7,"context_line":"    Do note this still supports host fact caching and it will not affect"},{"line_number":8,"context_line":"    scenarios with all facts cached (as there is no task to fail)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"01e67c29_bdb648bd","line":6,"in_reply_to":"1f0ab388_7de599dd","updated":"2021-08-24 13:34:37.000000000","message":"You don\u0027t have to duplicate the CI. Everyone is aware of the issue. I\u0027m not fixing it as there is no point before I finish discussing the change with other cores. 😉","commit_id":"d62c071d22bed4ac815933f28b55655332d5a8f9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1d4abc8934855968b642950124d3422d26b391ec","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Kolla Ansible will now fail execution early if fact collection fails"},{"line_number":5,"context_line":"    on any of the hosts to avoid late failures due to missing facts"},{"line_number":6,"context_line":"    (especially cross-host). This is done by setting ``any_errors_fatal: true``."},{"line_number":7,"context_line":"    Do note this still supports host fact caching and it will not affect"},{"line_number":8,"context_line":"    scenarios with all facts cached (as there is no task to fail)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fcb7e83_96fa9e31","line":6,"in_reply_to":"3c55085a_b7e28432","updated":"2022-04-29 12:18:27.000000000","message":"Done","commit_id":"d62c071d22bed4ac815933f28b55655332d5a8f9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"976cff2a5b248047ea77a55d2975c784b30c4519","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Kolla Ansible will now fail execution early if fact collection fails"},{"line_number":5,"context_line":"    on any of the hosts to avoid late failures due to missing facts"},{"line_number":6,"context_line":"    (especially cross-host). This is done by setting ``any_errors_fatal: true``."},{"line_number":7,"context_line":"    Do note this still supports host fact caching and it will not affect"},{"line_number":8,"context_line":"    scenarios with all facts cached (as there is no task to fail)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3c55085a_b7e28432","line":6,"in_reply_to":"660bab8c_03389315","updated":"2021-08-25 09:02:50.000000000","message":"I\u0027m just pointing out that -1 for this is pure evil. 😊","commit_id":"d62c071d22bed4ac815933f28b55655332d5a8f9"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"fef9363fa1c2141af489de5747c3cc81e22f8f8f","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# NOTE(yoctozepto): In CI it makes sense to always try to fail"},{"line_number":9,"context_line":"# as early as possible."},{"line_number":10,"context_line":"kolla_ansible_setup_any_errors_fatal: yes"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"kolla_base_distro: \"{{ base_distro }}\""},{"line_number":13,"context_line":"kolla_install_type: \"{{ install_type }}\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"cf41a82a_35679e94","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":41},"updated":"2022-04-29 12:51:47.000000000","message":"\"yes\"","commit_id":"22479588f7c84839b20281a1b6e163797ca0b546"}]}