)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b697e49aa8d2e4b591136280ee62b627355404bd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"af9d9a4f_b28d3a99","updated":"2021-10-11 08:41:03.000000000","message":"ping about followup","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"0343ad7499c574e7bdb79a95807835e59930914b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4c4b3fdf_5d7cd721","in_reply_to":"af9d9a4f_b28d3a99","updated":"2021-12-06 08:31:38.000000000","message":"Pong😉","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"}],"ansible/roles/prometheus/templates/prometheus.yml.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3b1aca3fef9965bdafde4994523092ae402d8431","unresolved":true,"context_lines":[{"line_number":19,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":20,"context_line":"        - \u0027{{ host }}:{{ prometheus_port }}\u0027"},{"line_number":21,"context_line":"{% endfor %}"},{"line_number":22,"context_line":"    relabel_configs:"},{"line_number":23,"context_line":"    - source_labels: [__address__]"},{"line_number":24,"context_line":"      regex: \"([^:]+):\\\\d+\""},{"line_number":25,"context_line":"      target_label: instance"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1adab89a_507f180d","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":19},"updated":"2021-09-21 10:28:46.000000000","message":"what does it do?","commit_id":"2946ee0583f1868b37e00c2b64cee7f18d1120c8"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"3ba0a7f9cfa5378a020b05079fd922f5e39624fb","unresolved":true,"context_lines":[{"line_number":19,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":20,"context_line":"        - \u0027{{ host }}:{{ prometheus_port }}\u0027"},{"line_number":21,"context_line":"{% endfor %}"},{"line_number":22,"context_line":"    relabel_configs:"},{"line_number":23,"context_line":"    - source_labels: [__address__]"},{"line_number":24,"context_line":"      regex: \"([^:]+):\\\\d+\""},{"line_number":25,"context_line":"      target_label: instance"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7c65c848_a9dc907e","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":19},"in_reply_to":"1adab89a_507f180d","updated":"2021-09-21 20:14:18.000000000","message":"Sets the final shape of the \u0027instance\u0027 label on job\u0027s targets - in this case, strips off tcp port number, so values are {hostname} not {hostname:port}","commit_id":"2946ee0583f1868b37e00c2b64cee7f18d1120c8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fa91c93411628eae24971b4c554573bc2e82e32c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":20,"context_line":"        - \u0027{{ host }}:{{ prometheus_port }}\u0027"},{"line_number":21,"context_line":"{% endfor %}"},{"line_number":22,"context_line":"    relabel_configs:"},{"line_number":23,"context_line":"    - source_labels: [__address__]"},{"line_number":24,"context_line":"      regex: \"([^:]+):\\\\d+\""},{"line_number":25,"context_line":"      target_label: instance"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe962ad_fd12b52e","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":19},"in_reply_to":"7c65c848_a9dc907e","updated":"2021-09-22 11:44:38.000000000","message":"thanks","commit_id":"2946ee0583f1868b37e00c2b64cee7f18d1120c8"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dc079a62a50a73d26bfc276b8099ae6f49138bbc","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    static_configs:"},{"line_number":18,"context_line":"      - targets:"},{"line_number":19,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":20,"context_line":"        - \u0027{{ host }}:{{ prometheus_port }}\u0027"},{"line_number":21,"context_line":"{% endfor %}"},{"line_number":22,"context_line":"    relabel_configs:"},{"line_number":23,"context_line":"    - source_labels: [__address__]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"8e6f38e5_d5fb3cf9","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":18},"updated":"2021-10-06 16:34:38.000000000","message":"This isn\u0027t quite right - we are adding inventory_hostname, but what we add to /etc/hosts is ansible_facts.nodename and ansible_facts.hostname. They could be different.\n\nAlso we usually don\u0027t assume that people have /etc/hosts or DNS.\n\nIf we wanted to fix this and give people a path back to the old way, we could do this:\n\n prometheus_target_address: \"{{ ansible_facts.hostname }}\"\n\nThen here:\n\n {{ hostvars[host].prometheus_target_address | put_address_in_context(\u0027url\u0027) }}\n\nThis should allow people to override prometheus_target_address to api_interface_address to get the old behaviour.","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ab3862c469f4db8020eb274008e0b2a9c8399cb5","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    static_configs:"},{"line_number":18,"context_line":"      - targets:"},{"line_number":19,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":20,"context_line":"        - \u0027{{ host }}:{{ prometheus_port }}\u0027"},{"line_number":21,"context_line":"{% endfor %}"},{"line_number":22,"context_line":"    relabel_configs:"},{"line_number":23,"context_line":"    - source_labels: [__address__]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"cba7c999_7851cf00","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":18},"in_reply_to":"0e41b1b5_87d108f2","updated":"2021-10-07 09:57:33.000000000","message":"Awaiting a followup then.","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"26af074eb934723f01717ad143c1fcd6ccdc6788","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    static_configs:"},{"line_number":18,"context_line":"      - targets:"},{"line_number":19,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":20,"context_line":"        - \u0027{{ host }}:{{ prometheus_port }}\u0027"},{"line_number":21,"context_line":"{% endfor %}"},{"line_number":22,"context_line":"    relabel_configs:"},{"line_number":23,"context_line":"    - source_labels: [__address__]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"16434379_d7567799","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":18},"in_reply_to":"18fa7768_e804b171","updated":"2021-12-21 11:41:48.000000000","message":"I don\u0027t think we should change these assumptions:\n\n* inventory_hostname is arbitrary, and may not relate to hostnames\n* hostnames do not need to be resolvable\n\nDo we need to revert this on xena and try again?","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"0343ad7499c574e7bdb79a95807835e59930914b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    static_configs:"},{"line_number":18,"context_line":"      - targets:"},{"line_number":19,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":20,"context_line":"        - \u0027{{ host }}:{{ prometheus_port }}\u0027"},{"line_number":21,"context_line":"{% endfor %}"},{"line_number":22,"context_line":"    relabel_configs:"},{"line_number":23,"context_line":"    - source_labels: [__address__]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"18fa7768_e804b171","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":18},"in_reply_to":"4eea899e_96445c8b","updated":"2021-12-06 08:31:38.000000000","message":"I\u0027m just wondering if we are not overthinking this. I ended up with a working config for my suggestion above but I don\u0027t like it - each target had its own scraping job definition, but eventually targets of the same kind were grouped with the same job name via relabelling. The config file has grown significantly.\n\nIf people are using IPs not names to connect to servers - this should not be fixed / worked around here? They will be presented with an IPs as a names for their targets.\n\nMark\u0027s point is still valid but isn\u0027t that a corner case? Should we just discourage inventory_hostname \u003d! ansible_hostname in docs? I\u0027m reluctant to add yet another new variable.","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"a930d8dfc7588741aec4f1f65893b22933b11748","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    static_configs:"},{"line_number":18,"context_line":"      - targets:"},{"line_number":19,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":20,"context_line":"        - \u0027{{ host }}:{{ prometheus_port }}\u0027"},{"line_number":21,"context_line":"{% endfor %}"},{"line_number":22,"context_line":"    relabel_configs:"},{"line_number":23,"context_line":"    - source_labels: [__address__]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bbd5614a_1336cd6d","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":18},"in_reply_to":"543048d3_d19e4030","updated":"2021-10-07 08:24:51.000000000","message":"I realised this patch could leave target definitions untouched and focus on the relabeling. We don\u0027t have to change how Prometheus connects to the targets, only how it displays them.","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9c17d65c0222b1709a2ff1a23619fbe73c601812","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    static_configs:"},{"line_number":18,"context_line":"      - targets:"},{"line_number":19,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":20,"context_line":"        - \u0027{{ host }}:{{ prometheus_port }}\u0027"},{"line_number":21,"context_line":"{% endfor %}"},{"line_number":22,"context_line":"    relabel_configs:"},{"line_number":23,"context_line":"    - source_labels: [__address__]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"543048d3_d19e4030","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":18},"in_reply_to":"8e6f38e5_d5fb3cf9","updated":"2021-10-07 06:56:02.000000000","message":"Good thinking.","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8551fc9d12a241b79ba9fdf6c9e2dd8a348a4208","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    static_configs:"},{"line_number":18,"context_line":"      - targets:"},{"line_number":19,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":20,"context_line":"        - \u0027{{ host }}:{{ prometheus_port }}\u0027"},{"line_number":21,"context_line":"{% endfor %}"},{"line_number":22,"context_line":"    relabel_configs:"},{"line_number":23,"context_line":"    - source_labels: [__address__]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"0e41b1b5_87d108f2","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":18},"in_reply_to":"bbd5614a_1336cd6d","updated":"2021-10-07 08:43:32.000000000","message":"That sounds like a good solution.","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"86dc25b64b245f8c44a8fc07603fa728089ca908","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    static_configs:"},{"line_number":18,"context_line":"      - targets:"},{"line_number":19,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":20,"context_line":"        - \u0027{{ host }}:{{ prometheus_port }}\u0027"},{"line_number":21,"context_line":"{% endfor %}"},{"line_number":22,"context_line":"    relabel_configs:"},{"line_number":23,"context_line":"    - source_labels: [__address__]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"4eea899e_96445c8b","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":18},"in_reply_to":"cba7c999_7851cf00","updated":"2021-12-03 10:50:04.000000000","message":"Using IP addresses as targets would also mean we don\u0027t need to update /etc/hosts on the monitoring hosts each time a new compute host is added to the system.","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dc079a62a50a73d26bfc276b8099ae6f49138bbc","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  - job_name: rabbitmq"},{"line_number":68,"context_line":"    static_configs:"},{"line_number":69,"context_line":"      - targets:"},{"line_number":70,"context_line":"{% for host in groups[\u0027rabbitmq\u0027] %}"},{"line_number":71,"context_line":"        - \u0027{{ host }}:{{ hostvars[host][\u0027prometheus_rabbitmq_exporter_port\u0027] }}\u0027"},{"line_number":72,"context_line":"{% endfor %}"},{"line_number":73,"context_line":"    relabel_configs:"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e62f954c_0d9d997d","line":70,"range":{"start_line":70,"start_character":23,"end_line":70,"end_character":31},"updated":"2021-10-06 16:34:38.000000000","message":"This one could cause issues, since we wouldn\u0027t necessarily have the role default for these hosts.","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8551fc9d12a241b79ba9fdf6c9e2dd8a348a4208","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  - job_name: rabbitmq"},{"line_number":68,"context_line":"    static_configs:"},{"line_number":69,"context_line":"      - targets:"},{"line_number":70,"context_line":"{% for host in groups[\u0027rabbitmq\u0027] %}"},{"line_number":71,"context_line":"        - \u0027{{ host }}:{{ hostvars[host][\u0027prometheus_rabbitmq_exporter_port\u0027] }}\u0027"},{"line_number":72,"context_line":"{% endfor %}"},{"line_number":73,"context_line":"    relabel_configs:"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a36f22dc_1cbcfe40","line":70,"range":{"start_line":70,"start_character":23,"end_line":70,"end_character":31},"in_reply_to":"1e069b1b_ea677e7f","updated":"2021-10-07 08:43:32.000000000","message":"If we were to use a role default, these hosts would not necessarily have it defined. I just realised it could be in group_vars/all.yml though.","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ef75a75817cf688150167f9fbfd9cceb495a6ac8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  - job_name: rabbitmq"},{"line_number":68,"context_line":"    static_configs:"},{"line_number":69,"context_line":"      - targets:"},{"line_number":70,"context_line":"{% for host in groups[\u0027rabbitmq\u0027] %}"},{"line_number":71,"context_line":"        - \u0027{{ host }}:{{ hostvars[host][\u0027prometheus_rabbitmq_exporter_port\u0027] }}\u0027"},{"line_number":72,"context_line":"{% endfor %}"},{"line_number":73,"context_line":"    relabel_configs:"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7e7ba8f0_e1901749","line":70,"range":{"start_line":70,"start_character":23,"end_line":70,"end_character":31},"in_reply_to":"a36f22dc_1cbcfe40","updated":"2021-10-07 09:57:13.000000000","message":"Mhm.","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9c17d65c0222b1709a2ff1a23619fbe73c601812","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  - job_name: rabbitmq"},{"line_number":68,"context_line":"    static_configs:"},{"line_number":69,"context_line":"      - targets:"},{"line_number":70,"context_line":"{% for host in groups[\u0027rabbitmq\u0027] %}"},{"line_number":71,"context_line":"        - \u0027{{ host }}:{{ hostvars[host][\u0027prometheus_rabbitmq_exporter_port\u0027] }}\u0027"},{"line_number":72,"context_line":"{% endfor %}"},{"line_number":73,"context_line":"    relabel_configs:"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1e069b1b_ea677e7f","line":70,"range":{"start_line":70,"start_character":23,"end_line":70,"end_character":31},"in_reply_to":"e62f954c_0d9d997d","updated":"2021-10-07 06:56:02.000000000","message":"What do you mean?","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dc079a62a50a73d26bfc276b8099ae6f49138bbc","unresolved":true,"context_lines":[{"line_number":106,"context_line":"  - job_name: fluentd"},{"line_number":107,"context_line":"    static_configs:"},{"line_number":108,"context_line":"      - targets:"},{"line_number":109,"context_line":"{% for host in groups[\u0027fluentd\u0027] %}"},{"line_number":110,"context_line":"        - \u0027{{ host }}:{{ hostvars[host][\u0027prometheus_fluentd_integration_port\u0027] }}\u0027"},{"line_number":111,"context_line":"{% endfor %}"},{"line_number":112,"context_line":"    relabel_configs:"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"08d8d76d_b4e8296e","line":109,"range":{"start_line":109,"start_character":23,"end_line":109,"end_character":30},"updated":"2021-10-06 16:34:38.000000000","message":"ditto","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ef75a75817cf688150167f9fbfd9cceb495a6ac8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  - job_name: fluentd"},{"line_number":107,"context_line":"    static_configs:"},{"line_number":108,"context_line":"      - targets:"},{"line_number":109,"context_line":"{% for host in groups[\u0027fluentd\u0027] %}"},{"line_number":110,"context_line":"        - \u0027{{ host }}:{{ hostvars[host][\u0027prometheus_fluentd_integration_port\u0027] }}\u0027"},{"line_number":111,"context_line":"{% endfor %}"},{"line_number":112,"context_line":"    relabel_configs:"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"01816be7_480fd02f","line":109,"range":{"start_line":109,"start_character":23,"end_line":109,"end_character":30},"in_reply_to":"08d8d76d_b4e8296e","updated":"2021-10-07 09:57:13.000000000","message":"ditto","commit_id":"4ff65b7661ea06e9fa8631c4eb82232e03af77d7"}]}