)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"6c9426f69fba782611d5ceca49012209a30dc534","unresolved":true,"context_lines":[{"line_number":489,"context_line":"skydive_analyzer_port: \"8085\""},{"line_number":490,"context_line":"skydive_agents_port: \"8090\""},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"skyline_port: \"28000\""},{"line_number":493,"context_line":"skyline_enable_tls_backend: \"{{ kolla_enable_tls_backend }}\""},{"line_number":494,"context_line":"skyline_cert: \"{{ container_config_directory }}/skyline-cert.pem\""},{"line_number":495,"context_line":"skyline_key: \"{{ container_config_directory }}/skyline-key.pem\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5e0fa04d_127c2140","line":492,"range":{"start_line":492,"start_character":15,"end_line":492,"end_character":20},"updated":"2021-09-29 05:50:24.000000000","message":"9999, the same from devstack","commit_id":"215314485c75b77edb200742c39f9a077acba472"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"7d2c45707a603e83a0e283de5bf33143799a862b","unresolved":true,"context_lines":[{"line_number":493,"context_line":"skyline_enable_tls_backend: \"{{ kolla_enable_tls_backend }}\""},{"line_number":494,"context_line":"skyline_cert: \"{{ container_config_directory }}/skyline-cert.pem\""},{"line_number":495,"context_line":"skyline_key: \"{{ container_config_directory }}/skyline-key.pem\""},{"line_number":496,"context_line":"skyline_ssl_certfile: \"{{ skyline_cert if skyline_enable_tls | bool else \u0027\u0027 }}\""},{"line_number":497,"context_line":"skyline_ssl_keyfile: \"{{ skyline_key if skyline_enable_tls | bool else \u0027\u0027 }}\""},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"solum_application_deployment_port: \"9777\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a9c293ff_a46364ad","line":496,"range":{"start_line":496,"start_character":42,"end_line":496,"end_character":61},"updated":"2021-09-29 06:04:00.000000000","message":"skyline_enable_tls_backend ?","commit_id":"215314485c75b77edb200742c39f9a077acba472"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"7d2c45707a603e83a0e283de5bf33143799a862b","unresolved":true,"context_lines":[{"line_number":494,"context_line":"skyline_cert: \"{{ container_config_directory }}/skyline-cert.pem\""},{"line_number":495,"context_line":"skyline_key: \"{{ container_config_directory }}/skyline-key.pem\""},{"line_number":496,"context_line":"skyline_ssl_certfile: \"{{ skyline_cert if skyline_enable_tls | bool else \u0027\u0027 }}\""},{"line_number":497,"context_line":"skyline_ssl_keyfile: \"{{ skyline_key if skyline_enable_tls | bool else \u0027\u0027 }}\""},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"solum_application_deployment_port: \"9777\""},{"line_number":500,"context_line":"solum_image_builder_port: \"9778\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"85df10e7_271fa949","line":497,"range":{"start_line":497,"start_character":40,"end_line":497,"end_character":59},"updated":"2021-09-29 06:04:00.000000000","message":"skyline_enable_tls_backend ?","commit_id":"215314485c75b77edb200742c39f9a077acba472"}],"ansible/roles/skyline/defaults/main.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6fd29c72e51c1cee29e0f8252962cd444791ac87","unresolved":true,"context_lines":[{"line_number":178,"context_line":"###################"},{"line_number":179,"context_line":"skyline_volumes:"},{"line_number":180,"context_line":"  - \"kolla_logs:{{ log_dir }}\""},{"line_number":181,"context_line":"  - \"/etc/localtime:/etc/localtime:ro/\""},{"line_number":182,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":183,"context_line":"  - \"{{ node_config_directory }}/skyline/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0daf605f_bddafbf0","line":181,"range":{"start_line":181,"start_character":37,"end_line":181,"end_character":38},"updated":"2021-09-28 08:35:32.000000000","message":"Remove \"/\" after \":ro\" - as this will result in error below: \n\nHandler for POST /v1.41/containers/create returned error: invalid mode: ro/","commit_id":"1791b2af806bb41fb0e4de5e63d4e58395b85c24"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cc5412510206ce53748d3a0b97e051b01d97b6d5","unresolved":true,"context_lines":[{"line_number":82,"context_line":"####################"},{"line_number":83,"context_line":"internal_haproxy_members: \"{% for host in groups[\u0027skyline\u0027] %}server {{ hostvars[host][\u0027ansible_hostname\u0027] }} {{ \u0027api\u0027 | kolla_address(host) }}:{{ skyline_port }} check inter 2000 rise 2 fall 5{% if not loop.first %} backup{% endif %};{% endfor %}\""},{"line_number":84,"context_line":"external_haproxy_members: \"{% for host in groups[\u0027skyline\u0027] %}server {{ host }} {{ host }}:{{ skyline_port }} check inter 2000 rise 2 fall 5{% if not loop.first %} backup{% endif %};{% endfor %}\""},{"line_number":85,"context_line":"admin_haproxy_members: \"{% for host in groups[\u0027skyline\u0027] %}server {{ host }} {{ host }}:{{ skyline_port }} check inter 2000 rise 2 fall 5{% if not loop.first %} backup{% endif %};{% endfor %}\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"####################"},{"line_number":88,"context_line":"# Docker image"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"39adcb5c_41ca5599","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":192},"updated":"2021-09-28 13:40:15.000000000","message":"What is a purpose of admin_haproxy_members, it looks like it\u0027s same as internal_haproxy_members ?","commit_id":"215314485c75b77edb200742c39f9a077acba472"}],"ansible/roles/skyline/tasks/bootstrap.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"394748b0db182a032f0000a0c19962710e97cde2","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    image: \"{{ service.image }}\""},{"line_number":43,"context_line":"    detach: False"},{"line_number":44,"context_line":"    restart_policy: no"},{"line_number":45,"context_line":"    network_mode: host"},{"line_number":46,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":47,"context_line":"    environment:"},{"line_number":48,"context_line":"      KOLLA_BOOTSTRAP: \"\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"8d2ca590_df977cdf","line":45,"updated":"2021-09-29 10:57:46.000000000","message":"This parameter is not supported in kolla_docker module, just remove it, kolla is already setting network mode to host by default.","commit_id":"20171c81a93347b972455bee2daf770b4c388b81"}],"ansible/roles/skyline/tasks/config.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6fd29c72e51c1cee29e0f8252962cd444791ac87","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - skyline_enable_tls_backend | bool"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Copying over config.json files for services"},{"line_number":28,"context_line":"  become: true"},{"line_number":29,"context_line":"  template:"},{"line_number":30,"context_line":"    src: \"{{ item.key }}.json.j2\""},{"line_number":31,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/config.json\""},{"line_number":32,"context_line":"    mode: \"0660\""},{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":35,"context_line":"    - item.value.enabled | bool"},{"line_number":36,"context_line":"  with_dict: \"{{ skyline_services }}\""},{"line_number":37,"context_line":"  notify:"},{"line_number":38,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- import_tasks: bootstrap.yml"},{"line_number":41,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"180ac392_049a5aeb","line":38,"range":{"start_line":27,"start_character":0,"end_line":38,"end_character":40},"updated":"2021-09-28 08:35:32.000000000","message":"Missing skyline.conf copying task in config.yml, config.json will be rendered but container will not start as config is missing, also skyline.conf in this patchset is empty.","commit_id":"1791b2af806bb41fb0e4de5e63d4e58395b85c24"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e21b5086834cbd633d970408d60cf45a701893ca","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - skyline_enable_tls_backend | bool"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Copying over config.json files for services"},{"line_number":28,"context_line":"  become: true"},{"line_number":29,"context_line":"  template:"},{"line_number":30,"context_line":"    src: \"{{ item.key }}.json.j2\""},{"line_number":31,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/config.json\""},{"line_number":32,"context_line":"    mode: \"0660\""},{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":35,"context_line":"    - item.value.enabled | bool"},{"line_number":36,"context_line":"  with_dict: \"{{ skyline_services }}\""},{"line_number":37,"context_line":"  notify:"},{"line_number":38,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- import_tasks: bootstrap.yml"},{"line_number":41,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"25f00f0a_5ed7f22e","line":38,"range":{"start_line":27,"start_character":0,"end_line":38,"end_character":40},"in_reply_to":"180ac392_049a5aeb","updated":"2021-09-28 09:08:25.000000000","message":"\u003e Missing skyline.conf copying task in config.yml, config.json will be rendered but container will not start as config is missing, also skyline.conf in this patchset is empty.\n\nOk, new patchset changing to yaml extension and already providing yaml config file.","commit_id":"1791b2af806bb41fb0e4de5e63d4e58395b85c24"}],"ansible/roles/skyline/tasks/pull.yml":[{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"e02a28a62053ddddfe3b32b24d3decf10b22d17c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Pulling skyline images"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"pull_image\""},{"line_number":6,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":7,"context_line":"    image: \"{{ item.value.image }}\""},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":10,"context_line":"    - item.value.enabled | bool"},{"line_number":11,"context_line":"  with_dict: \"{{ skyline_services }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"430d7020_b2930648","line":11,"range":{"start_line":1,"start_character":0,"end_line":11,"end_character":37},"updated":"2021-09-29 05:53:14.000000000","message":"please refer to the cinder or other core project\u0027s pull.yml of openstack","commit_id":"215314485c75b77edb200742c39f9a077acba472"}],"ansible/roles/skyline/templates/skyline.json.j2":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"78cd91dff0a4d5c6a35a4801e348ed3b4882b13a","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        }{% endif %}"},{"line_number":28,"context_line":"        ],"},{"line_number":29,"context_line":"    \"permissions\": ["},{"line_number":30,"context_line":"        \"path\": \"/var/log/kolla/skyline\","},{"line_number":31,"context_line":"        \"owner\": \"skyline:skyline\","},{"line_number":32,"context_line":"        \"recurse\": true"},{"line_number":33,"context_line":"    ]"},{"line_number":34,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"25be23d1_773eddf3","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":23},"updated":"2021-09-28 09:07:29.000000000","message":"Invalid json, wrap with { } and add indention : \n\n        {\n            \"path\": \"/var/log/kolla/skyline\",\n            \"owner\": \"skyline:skyline\",\n            \"recurse\": true\n        }","commit_id":"81eb6228a3e0b8cf6e7ac228fadca3876fac7d7e"}]}
