)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"42fda1c8c171876533c102cd9659ea3ba404ce6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"09e25389_98ab7071","updated":"2021-11-12 09:12:30.000000000","message":"Anyone to review this ? It\u0027s trivial and usefull.","commit_id":"014347d020fb643c029b88be905c62c24bb9e1fa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3b829691779d619510e369c904d5675caea7ae59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a4aa655_45f0ba2a","updated":"2021-11-12 09:48:17.000000000","message":"release note","commit_id":"014347d020fb643c029b88be905c62c24bb9e1fa"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"80c0d17bc817ab0da2e47c380230b19cf69723e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2574458a_b32f640c","in_reply_to":"0a4aa655_45f0ba2a","updated":"2021-11-12 16:49:54.000000000","message":"Done","commit_id":"014347d020fb643c029b88be905c62c24bb9e1fa"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"11fb583ae2723c061bae9fb0e6948692aa14c76f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1f4b55a5_72892e43","updated":"2021-12-16 11:06:06.000000000","message":"I still have a problem understanding why would you want this, and why cron_logrotate_rotation_interval\nand cron_logrotate_rotation_count is not enough.","commit_id":"e598588c32c986499000cce06b8a9b62a8ac47f5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ffc2a47054b0501dabc33dc8bb8ece3872086e83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0f889d15_c379a2ee","updated":"2021-12-06 14:28:33.000000000","message":"Ping, reno added ? Anything else needed ? ","commit_id":"e598588c32c986499000cce06b8a9b62a8ac47f5"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"a1e75881e7a14a3b65f575cf44adadc954873a1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83aecf18_393385b7","updated":"2021-12-11 01:59:00.000000000","message":"Thanks!","commit_id":"e598588c32c986499000cce06b8a9b62a8ac47f5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0d35981584174064b06a46f0438c5f90573c5ea7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1efa76f4_ca89425b","updated":"2021-12-17 11:52:31.000000000","message":"What I am trying to say is, that if logrotate is configurable and user is able to change default cron_logrotate_rotation_interval: \"weekly\" via globals for example to hourly, cron\u0027s has to run minimal once per hour - this is not possible in current situation - because it\u0027s by default daily for logrote cron file.","commit_id":"e598588c32c986499000cce06b8a9b62a8ac47f5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3be99935a32c2c62ce52b4e247454ef0e6de6019","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"01347f9b_d8097cc2","updated":"2021-11-21 09:40:52.000000000","message":"ping","commit_id":"e598588c32c986499000cce06b8a9b62a8ac47f5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"78db2758995eaaa317310bcd95045e3ec4b3c518","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0246a843_95b572be","updated":"2021-12-21 18:53:22.000000000","message":"recheck","commit_id":"e598588c32c986499000cce06b8a9b62a8ac47f5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"913d7e26157a044544a32da147f34c932134eba7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a4f51aea_d2a31338","in_reply_to":"1f4b55a5_72892e43","updated":"2021-12-17 11:47:10.000000000","message":"Ok, let\u0027s assume that you have very big load to servers, servers are logging tons of logs to your disk and your disk is limited.\n\nFor this purpose you have logrotate which is configurable via kolla-ansible, you can set cron_logrotate_rotation_interval and cron_logrotate_rotation_count. What does it mean ? It means when logrotate process will start, it will check logrotate\u0027s configuration, let\u0027s assume you want to logrotate logs every hour and want to store N count of logs.\n\nSo, you setup cron_logrotate_rotation_interval: 1 and cron_logrotate_rotation_count.\n\nProblem is that logrotate process is executed via cron, and that cron is running *daily* on each distro.\n\nSo even if you want to run logrotate hourly (because you want to avoid situation when you will be out of space), you really need to logrotate often than one day - one day would be not enough as you can run out of space.\n\nIn current situation if you have for example logrotate weekly, and cron is running logrotate daily, everything is OK, because every day logrotate will be happy, because it is not already a week and on 7th day will logrotate files.\n\nIf you want to logrotate hourly .. it\u0027s not enough to run logrotate daily.\n\nIs it clear ?","commit_id":"e598588c32c986499000cce06b8a9b62a8ac47f5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8423cd20732aa389e40df4898fc6ec7bf8370d3d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f65bfa44_1de25a2a","in_reply_to":"a39d313a_d59a12bb","updated":"2021-12-17 11:57:56.000000000","message":"It was just example, you can configure logrotate to not follow a \"time\" but follow size of file. And if you are afraid situation with out of space, you really want to be less nervous than more - so you will do it every hour, not every day.\n\nIf you have debug on, it can be several gigabytes per hour * every service * 24 hours.\n\nWe are not discussing my setup, we are discussing feature in kolla which is usefull and not breaking anything, so where is a problem ?","commit_id":"e598588c32c986499000cce06b8a9b62a8ac47f5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e219a2a1ad67b86ea64574601daa6c6a8001a432","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a39d313a_d59a12bb","in_reply_to":"a4f51aea_d2a31338","updated":"2021-12-17 11:50:31.000000000","message":"Yes it is. But I still think that if you need logrotate being run hourly, there\u0027s something really wrong with your setup.","commit_id":"e598588c32c986499000cce06b8a9b62a8ac47f5"}]}