)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a300d56dd002705e9bef1a585bcb10489ef8afc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4e6570a5_cd2433f0","updated":"2021-10-12 08:09:35.000000000","message":"Ironic dnsmasq logs need an entry in ansible/roles/common/templates/conf/input/00-global.conf.j2","commit_id":"5b6ec4364cd2b1eb7649b2967063124a26c8a64c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"074713b3b4c02821a6e122cfaa04c3b840be0cd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"975f6a0e_4220c235","in_reply_to":"4e6570a5_cd2433f0","updated":"2021-10-12 08:32:42.000000000","message":"indeed) done.","commit_id":"5b6ec4364cd2b1eb7649b2967063124a26c8a64c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"65782b33a5d8822d0647578805174ef82dfcd9f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bd668a40_c9386c5e","updated":"2021-11-01 11:46:57.000000000","message":"I agree it would be nice to advertise the async change in the reno, or make it a separate commit, but I won\u0027t block on that - this is a useful patch, many thanks.","commit_id":"d559e2c39d2171e249ec4de3e29996fb25b20f3e"}],"ansible/roles/ironic/templates/ironic-dnsmasq.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d45cd7fab2586d91fd3e5c2e5e5a11da86864a1d","unresolved":true,"context_lines":[{"line_number":31,"context_line":"dhcp-option\u003doption:bootfile-name,{{ ironic_dnsmasq_boot_file }}"},{"line_number":32,"context_line":"{% endif %}{# ipv6/ipv4 #}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"log-async"},{"line_number":35,"context_line":"log-facility\u003d/var/log/kolla/ironic/dnsmasq.log"},{"line_number":36,"context_line":"{% if ironic_logging_debug | bool %}"},{"line_number":37,"context_line":"log-dhcp"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ad3494c8_8eb94a21","line":34,"updated":"2021-10-12 19:07:57.000000000","message":"what is this for?","commit_id":"4cdcac9e9e1b1863cb8f169d6e0f20e1a52736de"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1ec89291d83d84fa3841083d5f3ebf490a6811a1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"dhcp-option\u003doption:bootfile-name,{{ ironic_dnsmasq_boot_file }}"},{"line_number":32,"context_line":"{% endif %}{# ipv6/ipv4 #}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"log-async"},{"line_number":35,"context_line":"log-facility\u003d/var/log/kolla/ironic/dnsmasq.log"},{"line_number":36,"context_line":"{% if ironic_logging_debug | bool %}"},{"line_number":37,"context_line":"log-dhcp"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"b191d38c_165a4385","line":34,"in_reply_to":"90581f58_181f08bb","updated":"2021-10-13 12:36:46.000000000","message":"this is not important right now, evermore this option can be tuned to queue more than default 5 lines, but default is ok. enabling this also don\u0027t change the logging for standard load.","commit_id":"4cdcac9e9e1b1863cb8f169d6e0f20e1a52736de"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"79a207b126e3ad994443bb10a40c80415f05190a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"dhcp-option\u003doption:bootfile-name,{{ ironic_dnsmasq_boot_file }}"},{"line_number":32,"context_line":"{% endif %}{# ipv6/ipv4 #}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"log-async"},{"line_number":35,"context_line":"log-facility\u003d/var/log/kolla/ironic/dnsmasq.log"},{"line_number":36,"context_line":"{% if ironic_logging_debug | bool %}"},{"line_number":37,"context_line":"log-dhcp"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ae483a35_b8603334","line":34,"in_reply_to":"ad3494c8_8eb94a21","updated":"2021-10-12 19:31:00.000000000","message":"this enables asynchronous logging, just don\u0027t flush each line and use queue. used on heavy load and with syslog for example.","commit_id":"4cdcac9e9e1b1863cb8f169d6e0f20e1a52736de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ffd691089bacffdfade160ea319deff4900fc93d","unresolved":true,"context_lines":[{"line_number":31,"context_line":"dhcp-option\u003doption:bootfile-name,{{ ironic_dnsmasq_boot_file }}"},{"line_number":32,"context_line":"{% endif %}{# ipv6/ipv4 #}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"log-async"},{"line_number":35,"context_line":"log-facility\u003d/var/log/kolla/ironic/dnsmasq.log"},{"line_number":36,"context_line":"{% if ironic_logging_debug | bool %}"},{"line_number":37,"context_line":"log-dhcp"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"90581f58_181f08bb","line":34,"in_reply_to":"ae483a35_b8603334","updated":"2021-10-13 07:43:55.000000000","message":"Hmm, then we should include this information somewhere in the commit message and the reno.","commit_id":"4cdcac9e9e1b1863cb8f169d6e0f20e1a52736de"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"015358a827efb9b26304f256efdb3c98c60420c4","unresolved":true,"context_lines":[{"line_number":34,"context_line":"log-async"},{"line_number":35,"context_line":"log-facility\u003d/var/log/kolla/ironic/dnsmasq.log"},{"line_number":36,"context_line":"{% if ironic_logging_debug | bool %}"},{"line_number":37,"context_line":"log-dhcp"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if ironic_inspector_pxe_filter \u003d\u003d \u0027dnsmasq\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"707d0421_78b01c78","line":37,"updated":"2021-12-09 12:13:23.000000000","message":"no log-queries?","commit_id":"d559e2c39d2171e249ec4de3e29996fb25b20f3e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"16a95fbd1007400e1ad504a8c4515af8d0838581","unresolved":false,"context_lines":[{"line_number":34,"context_line":"log-async"},{"line_number":35,"context_line":"log-facility\u003d/var/log/kolla/ironic/dnsmasq.log"},{"line_number":36,"context_line":"{% if ironic_logging_debug | bool %}"},{"line_number":37,"context_line":"log-dhcp"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if ironic_inspector_pxe_filter \u003d\u003d \u0027dnsmasq\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"57139f51_b9047e32","line":37,"in_reply_to":"707d0421_78b01c78","updated":"2021-12-09 13:18:09.000000000","message":"Sure. dnsmasq here didn\u0027t provide DNS service.","commit_id":"d559e2c39d2171e249ec4de3e29996fb25b20f3e"}],"ansible/roles/neutron/templates/dnsmasq.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d45cd7fab2586d91fd3e5c2e5e5a11da86864a1d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"log-async"},{"line_number":2,"context_line":"log-facility\u003d/var/log/kolla/neutron/dnsmasq.log"},{"line_number":3,"context_line":"{% if neutron_logging_debug | bool %}"},{"line_number":4,"context_line":"log-dhcp"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5ba01579_9a42a1ac","line":1,"updated":"2021-10-12 19:07:57.000000000","message":"ditto","commit_id":"4cdcac9e9e1b1863cb8f169d6e0f20e1a52736de"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"79a207b126e3ad994443bb10a40c80415f05190a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"log-async"},{"line_number":2,"context_line":"log-facility\u003d/var/log/kolla/neutron/dnsmasq.log"},{"line_number":3,"context_line":"{% if neutron_logging_debug | bool %}"},{"line_number":4,"context_line":"log-dhcp"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"0437b53d_720cfb34","line":1,"in_reply_to":"5ba01579_9a42a1ac","updated":"2021-10-12 19:31:00.000000000","message":"see previous comment.","commit_id":"4cdcac9e9e1b1863cb8f169d6e0f20e1a52736de"}],"releasenotes/notes/update-dnsmasq-logging-a5d42f6180aff049.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d45cd7fab2586d91fd3e5c2e5e5a11da86864a1d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The container ``ironic-dnsmasq`` now creates the ``dnsmasq.log`` also as"},{"line_number":5,"context_line":"    the container ``neutron-dhcp-agent``. For both log files verbosity can be"},{"line_number":6,"context_line":"    increased globbaly via ``openstack_logging_debug`` or per service via"},{"line_number":7,"context_line":"    ``ironic_logging_debug`` or ``neutron_logging_debug`` variables."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a32733d_71f7d89d","line":4,"range":{"start_line":4,"start_character":69,"end_line":4,"end_character":74},"updated":"2021-10-12 19:07:57.000000000","message":"\"just\"","commit_id":"4cdcac9e9e1b1863cb8f169d6e0f20e1a52736de"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"79a207b126e3ad994443bb10a40c80415f05190a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The container ``ironic-dnsmasq`` now creates the ``dnsmasq.log`` also as"},{"line_number":5,"context_line":"    the container ``neutron-dhcp-agent``. For both log files verbosity can be"},{"line_number":6,"context_line":"    increased globbaly via ``openstack_logging_debug`` or per service via"},{"line_number":7,"context_line":"    ``ironic_logging_debug`` or ``neutron_logging_debug`` variables."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9722bc27_c20491c8","line":4,"range":{"start_line":4,"start_character":69,"end_line":4,"end_character":74},"in_reply_to":"5a32733d_71f7d89d","updated":"2021-10-12 19:31:00.000000000","message":"Done","commit_id":"4cdcac9e9e1b1863cb8f169d6e0f20e1a52736de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d45cd7fab2586d91fd3e5c2e5e5a11da86864a1d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The container ``ironic-dnsmasq`` now creates the ``dnsmasq.log`` also as"},{"line_number":5,"context_line":"    the container ``neutron-dhcp-agent``. For both log files verbosity can be"},{"line_number":6,"context_line":"    increased globbaly via ``openstack_logging_debug`` or per service via"},{"line_number":7,"context_line":"    ``ironic_logging_debug`` or ``neutron_logging_debug`` variables."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"332d6ce0_943ce0df","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":23},"updated":"2021-10-12 19:07:57.000000000","message":"nit: \"globally\"","commit_id":"4cdcac9e9e1b1863cb8f169d6e0f20e1a52736de"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"79a207b126e3ad994443bb10a40c80415f05190a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The container ``ironic-dnsmasq`` now creates the ``dnsmasq.log`` also as"},{"line_number":5,"context_line":"    the container ``neutron-dhcp-agent``. For both log files verbosity can be"},{"line_number":6,"context_line":"    increased globbaly via ``openstack_logging_debug`` or per service via"},{"line_number":7,"context_line":"    ``ironic_logging_debug`` or ``neutron_logging_debug`` variables."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fda51e6d_8cc9cfa1","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":23},"in_reply_to":"332d6ce0_943ce0df","updated":"2021-10-12 19:31:00.000000000","message":"Done","commit_id":"4cdcac9e9e1b1863cb8f169d6e0f20e1a52736de"}]}
