)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"59cbb3a0cd8ab371378148523b0d088cb137eefd","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of running mariadb role with --limit the group_by module will only include the limited hosts and other hosts that are not limited by ansible will not be included."},{"line_number":10,"context_line":"Using add_host will add all hosts in mariadb group to their shards group"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Seena Fallah \u003cseenafallah@gmail.com\u003e"},{"line_number":13,"context_line":"Change-Id: I1331698e313bd714a16fc35f38fb579d75b56370"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"db61fac1_9791f691","line":11,"updated":"2021-10-18 09:01:13.000000000","message":"Needs a bug report, describing the problem and its visible effects.","commit_id":"4a92f9d4931781881e1e5ec8256a37b12561b64b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b24e5b523e6b056f3392f3c89f4516f9734da2ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ddf61621_a4f3d7be","updated":"2021-10-17 08:18:52.000000000","message":"I will check ať the evening or tomorrow.","commit_id":"4a92f9d4931781881e1e5ec8256a37b12561b64b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f7ee6ff34391d88fb5d66cca74ce1f4954fc585d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d2c0fd7_84ba5d48","updated":"2021-10-17 07:13:54.000000000","message":"Please also report a bug ( https://bugs.launchpad.net/kolla-ansible )\nand add a release note ( https://docs.openstack.org/kolla-ansible/latest/contributor/release-notes.html ).","commit_id":"4a92f9d4931781881e1e5ec8256a37b12561b64b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"78587ef9f9d55695068e0a1d51dc81ef1d358ca7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"184ab2d4_8de8b472","updated":"2021-10-18 12:57:32.000000000","message":"Reno missing. Otherwise it looks fine.","commit_id":"fc82eda7c3c2f65050755968ae068393470f10d0"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"908d2ba2eaf1b4b6c0d4386d7b408c89d24c61a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b5bd9a5_82804d97","in_reply_to":"184ab2d4_8de8b472","updated":"2021-10-18 13:36:04.000000000","message":"\u003e Reno missing. Otherwise it looks fine.\n\nadded the commit message to point to the bug in launchpad","commit_id":"fc82eda7c3c2f65050755968ae068393470f10d0"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"c1cbb8992a600c478ccf0b6e4b9bf82c82925745","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e8d808c8_808f1af7","updated":"2021-10-19 22:31:16.000000000","message":"Fixed the CI issue by using directly the shard_id in roles default because I think using that variable will loaded with host variables.","commit_id":"33781b6496e120a32089419c3e2441d9cb1d9044"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"7cfee7de64a1cd4ffb91d9c21909e2d3cddb68db","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"de726d1c_ced7fc17","updated":"2021-10-21 21:47:31.000000000","message":"Is this PR pending for any changes?","commit_id":"49e9a9fcee8fb29f4dcd82466bd49f074de16706"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"966e83cb260dd04d7c3c9221703d46ddc815e777","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"543fea83_5a76eb58","updated":"2021-10-20 09:07:10.000000000","message":"Please also take a look at the bug report and describe the bug in more details.","commit_id":"49e9a9fcee8fb29f4dcd82466bd49f074de16706"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"69a54c1fcfbeedd01336448a0429f2e361dc6d2a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b2e46ded_6e593926","in_reply_to":"de726d1c_ced7fc17","updated":"2021-10-21 21:53:55.000000000","message":"Discussion, as always :)","commit_id":"49e9a9fcee8fb29f4dcd82466bd49f074de16706"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"d9e6da4e2c26e09011a7858ec6196775df90dc06","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c512c526_502a3081","updated":"2021-10-22 10:59:24.000000000","message":"Why not use my first patch to not define the variables in task again?","commit_id":"e1238585c502d004583839c48670aa447e8446bd"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d0e8314f591f53eea5d88f3de4ceefdc43ce11f2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cf0abdbc_1d751ac8","in_reply_to":"c512c526_502a3081","updated":"2021-10-22 11:40:56.000000000","message":"Let\u0027s see if patchset 1 passing with followup patches in chain. Then I will try previous patchset 10.","commit_id":"e1238585c502d004583839c48670aa447e8446bd"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"e0512ef560a0e289f900a8b4876882ce3f50b064","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"31c81317_91e1db60","updated":"2021-10-22 12:07:26.000000000","message":"Sorry I meant this patch that changed_when is false and also the mariadb_shard_database_user is in role default.","commit_id":"7f495ce5ab2b3cac3bea88d85fd2238699a14424"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"74f76e0bf5bd3ea2d7248daf11e5322d93bf02de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a5c6988d_ac9cf523","in_reply_to":"31c81317_91e1db60","updated":"2021-10-22 12:13:51.000000000","message":"patchsed number ?","commit_id":"7f495ce5ab2b3cac3bea88d85fd2238699a14424"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"ce04bba9c2d6c2db37a0fb90a465aac570d45221","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"102ae13b_6b4e5f86","in_reply_to":"a5c6988d_ac9cf523","updated":"2021-10-22 13:02:40.000000000","message":"\u003e patchsed number ?\n\nMix of 1 and 5 \u003d)","commit_id":"7f495ce5ab2b3cac3bea88d85fd2238699a14424"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cb6d8fd73ad7a41235148501a9dd2693db4b08aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3e98c4f9_471d2166","updated":"2021-10-27 15:22:29.000000000","message":"And respond to the question in the bug report please.","commit_id":"5f4c7c13b1cc568f08a9a5f6f5dea70acc9efae5"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"548ac20921678f10ebf8437ead4449729e31d9a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"83dab348_fdc3284a","updated":"2021-10-22 18:56:53.000000000","message":"Any plan to be merged? struggling with the bug :(","commit_id":"5f4c7c13b1cc568f08a9a5f6f5dea70acc9efae5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0eee349663b1e04da5242b193ac1e0c53a06582f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7c41f36a_62d69adc","updated":"2021-10-27 15:21:56.000000000","message":"Missing Closes-Bug","commit_id":"5f4c7c13b1cc568f08a9a5f6f5dea70acc9efae5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1114bb0c8ace99fed73c69d069af4f6d4d8c0b5e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6720c8f3_0c690423","in_reply_to":"369333b3_2993dc3f","updated":"2021-10-28 06:09:15.000000000","message":"There\u0027s add comment field on the bottom, it\u0027s fine to add it there.","commit_id":"5f4c7c13b1cc568f08a9a5f6f5dea70acc9efae5"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"db7af3c2f57ebee24b5fad74937344313657f1fa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"369333b3_2993dc3f","in_reply_to":"3e98c4f9_471d2166","updated":"2021-10-27 23:25:43.000000000","message":"It seems I can\u0027t edit the bug.","commit_id":"5f4c7c13b1cc568f08a9a5f6f5dea70acc9efae5"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"fdfe01cc889553ab220dd64028eb8892cdb09e93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d61be62f_157a568a","in_reply_to":"6720c8f3_0c690423","updated":"2021-10-28 11:40:57.000000000","message":"Done","commit_id":"5f4c7c13b1cc568f08a9a5f6f5dea70acc9efae5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a4cf3b2058726952a943d83fd4d1b5d9093e0312","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7e6ea37b_682da34c","in_reply_to":"79942bb8_fb7280f0","updated":"2021-10-28 16:27:26.000000000","message":"Ah, I saw only the summary updated, yet I see now you have also updated the description. I did not notice because it\u0027s so short. 😊 Ok, I understand the issue now, let me make the release note more appropriate and we can merge.","commit_id":"5f4c7c13b1cc568f08a9a5f6f5dea70acc9efae5"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"db7af3c2f57ebee24b5fad74937344313657f1fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ed8a8483_d742108f","in_reply_to":"7c41f36a_62d69adc","updated":"2021-10-27 23:25:43.000000000","message":"Done","commit_id":"5f4c7c13b1cc568f08a9a5f6f5dea70acc9efae5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8121a690f6898a822f1641860f25b64e981f7dfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fe9953f8_6aedc5f0","in_reply_to":"83dab348_fdc3284a","updated":"2021-10-22 20:13:32.000000000","message":"Unfortunatelly I have only +1 vote :(, but it\u0027s regular bug, so I hope guys will pay attention to this review.","commit_id":"5f4c7c13b1cc568f08a9a5f6f5dea70acc9efae5"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"43b377a9a5af6e90b7fe584ee3c00a310fc0436a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"79942bb8_fb7280f0","in_reply_to":"bb0e9ade_cefec521","updated":"2021-10-28 13:43:37.000000000","message":"\u003e The bug report still does not describe the issue. Are there any error messages? What happens? And when? What is the expected outcome?\n\nSorry but I don\u0027t get your point here! There is a regular bug here in the ansible and still, the patch is pending to merge and I and maybe others struggle with it! The bug is clear and I wrote it in Bugzilla that the MariaDB won\u0027t be cluster because the wsrep_cluster_address in galera.cnf will be empty!","commit_id":"5f4c7c13b1cc568f08a9a5f6f5dea70acc9efae5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f69469021a7a4adc82637d68c6a9bf4c0be1bd6c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"bb0e9ade_cefec521","in_reply_to":"d61be62f_157a568a","updated":"2021-10-28 13:24:13.000000000","message":"The bug report still does not describe the issue. Are there any error messages? What happens? And when? What is the expected outcome?","commit_id":"5f4c7c13b1cc568f08a9a5f6f5dea70acc9efae5"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"17594cd321cabcf9f6677a5eebf04d03f58a26c6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cee1883d_24b2c9eb","in_reply_to":"fe9953f8_6aedc5f0","updated":"2021-10-24 10:30:18.000000000","message":"Why not add your +1 vote? :)","commit_id":"5f4c7c13b1cc568f08a9a5f6f5dea70acc9efae5"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"2f73d7a5d3074bcf484cb09f24add927a98d1e23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"841aab46_0a45e5bd","updated":"2021-11-01 22:02:01.000000000","message":"ping","commit_id":"68cd2a055371cc25a0502ff4db22fbcdececd478"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f7ee6ff34391d88fb5d66cca74ce1f4954fc585d","unresolved":true,"context_lines":[{"line_number":377,"context_line":"mariadb_monitor_user: \"haproxy\""},{"line_number":378,"context_line":"mariadb_default_database_shard_id: 0"},{"line_number":379,"context_line":"mariadb_default_database_shard_hosts: \"{% set default_shard \u003d [] %}{% for host in groups[\u0027mariadb\u0027] %}{% if hostvars[host][\u0027mariadb_shard_id\u0027] is not defined or hostvars[host][\u0027mariadb_shard_id\u0027] \u003d\u003d mariadb_default_database_shard_id %}{{ default_shard.append(host) }}{% endif %}{% endfor %}{{ default_shard }}\""},{"line_number":380,"context_line":"mariadb_shard_id: \"{{ mariadb_default_database_shard_id }}\""},{"line_number":381,"context_line":"mariadb_shard_name: \"shard_{{ mariadb_shard_id }}\""},{"line_number":382,"context_line":"mariadb_shard_group: \"mariadb_{{ mariadb_shard_name }}\""},{"line_number":383,"context_line":"mariadb_shard_database_user: \"{% if mariadb_loadbalancer \u003d\u003d \u0027haproxy\u0027 %}{{ database_user }}{% else %}root_{{ mariadb_shard_name }}{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b8efffb4_6d201b6f","line":380,"updated":"2021-10-17 07:13:54.000000000","message":"Please don\u0027t move these variables.","commit_id":"4a92f9d4931781881e1e5ec8256a37b12561b64b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c761f6187df3478b503b8e04e33c74dbc7cb713e","unresolved":true,"context_lines":[{"line_number":380,"context_line":"mariadb_shard_id: \"{{ mariadb_default_database_shard_id }}\""},{"line_number":381,"context_line":"mariadb_shard_name: \"shard_{{ mariadb_shard_id }}\""},{"line_number":382,"context_line":"mariadb_shard_group: \"mariadb_{{ mariadb_shard_name }}\""},{"line_number":383,"context_line":"mariadb_shard_database_user: \"{% if mariadb_loadbalancer \u003d\u003d \u0027haproxy\u0027 %}{{ database_user }}{% else %}root_{{ mariadb_shard_name }}{% endif %}\""},{"line_number":384,"context_line":"mariadb_loadbalancer: \"haproxy\""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"masakari_api_port: \"15868\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a0698b4c_76bb5c3b","line":383,"range":{"start_line":383,"start_character":0,"end_line":383,"end_character":142},"updated":"2021-10-19 08:11:15.000000000","message":"Does this one need to be in group_vars?","commit_id":"721a311d4b8fb9500d9c773117be56d9cff95ed0"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"07e9f03652dc055fd52ac1195aff4612343c3fb5","unresolved":false,"context_lines":[{"line_number":380,"context_line":"mariadb_shard_id: \"{{ mariadb_default_database_shard_id }}\""},{"line_number":381,"context_line":"mariadb_shard_name: \"shard_{{ mariadb_shard_id }}\""},{"line_number":382,"context_line":"mariadb_shard_group: \"mariadb_{{ mariadb_shard_name }}\""},{"line_number":383,"context_line":"mariadb_shard_database_user: \"{% if mariadb_loadbalancer \u003d\u003d \u0027haproxy\u0027 %}{{ database_user }}{% else %}root_{{ mariadb_shard_name }}{% endif %}\""},{"line_number":384,"context_line":"mariadb_loadbalancer: \"haproxy\""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"masakari_api_port: \"15868\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"efc95a4c_9d475fe6","line":383,"range":{"start_line":383,"start_character":0,"end_line":383,"end_character":142},"in_reply_to":"a0698b4c_76bb5c3b","updated":"2021-10-19 08:40:10.000000000","message":"Moved to role defaults","commit_id":"721a311d4b8fb9500d9c773117be56d9cff95ed0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"35ccf763859302133b9de88df9d0f90e98031319","unresolved":false,"context_lines":[{"line_number":380,"context_line":"mariadb_shard_id: \"{{ mariadb_default_database_shard_id }}\""},{"line_number":381,"context_line":"mariadb_shard_name: \"shard_{{ mariadb_shard_id }}\""},{"line_number":382,"context_line":"mariadb_shard_group: \"mariadb_{{ mariadb_shard_name }}\""},{"line_number":383,"context_line":"mariadb_shard_database_user: \"{% if mariadb_loadbalancer \u003d\u003d \u0027haproxy\u0027 %}{{ database_user }}{% else %}root_{{ mariadb_shard_name }}{% endif %}\""},{"line_number":384,"context_line":"mariadb_loadbalancer: \"haproxy\""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"masakari_api_port: \"15868\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a70ef669_a5876758","line":383,"range":{"start_line":383,"start_character":0,"end_line":383,"end_character":142},"in_reply_to":"dd08cada_f3048a61","updated":"2021-10-19 16:07:21.000000000","message":"oh, sorry for mistification, yes, it can be role default","commit_id":"721a311d4b8fb9500d9c773117be56d9cff95ed0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"393c027a8621fcedbbf8ff9a173f8cbd3d1db8b8","unresolved":false,"context_lines":[{"line_number":380,"context_line":"mariadb_shard_id: \"{{ mariadb_default_database_shard_id }}\""},{"line_number":381,"context_line":"mariadb_shard_name: \"shard_{{ mariadb_shard_id }}\""},{"line_number":382,"context_line":"mariadb_shard_group: \"mariadb_{{ mariadb_shard_name }}\""},{"line_number":383,"context_line":"mariadb_shard_database_user: \"{% if mariadb_loadbalancer \u003d\u003d \u0027haproxy\u0027 %}{{ database_user }}{% else %}root_{{ mariadb_shard_name }}{% endif %}\""},{"line_number":384,"context_line":"mariadb_loadbalancer: \"haproxy\""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"masakari_api_port: \"15868\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dd08cada_f3048a61","line":383,"range":{"start_line":383,"start_character":0,"end_line":383,"end_character":142},"in_reply_to":"efc95a4c_9d475fe6","updated":"2021-10-19 15:36:15.000000000","message":"Well, yes - in proxysql patch not merged yet, it\u0027s needed to be in group vars ..because all roles are connecting to mariadb shard/cluster and using shard/cluster user and proxysql will route SQLs to right shard/cluster.","commit_id":"721a311d4b8fb9500d9c773117be56d9cff95ed0"}],"ansible/roles/mariadb/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f7ee6ff34391d88fb5d66cca74ce1f4954fc585d","unresolved":true,"context_lines":[{"line_number":119,"context_line":"# Clustercheck"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"enable_mariadb_clustercheck: \"{{ enable_haproxy }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"####################"},{"line_number":124,"context_line":"# Sharding"},{"line_number":125,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"75f20b89_83e08857","side":"PARENT","line":122,"updated":"2021-10-17 07:13:54.000000000","message":"Please don\u0027t move these variables.","commit_id":"41692908564f396577f20cd55e7763f6b078fd7b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3540bbd7e1a841004a9f3a6a315941819b5a17cc","unresolved":true,"context_lines":[{"line_number":119,"context_line":"# Clustercheck"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"enable_mariadb_clustercheck: \"{{ enable_haproxy }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"####################"},{"line_number":124,"context_line":"# Sharding"},{"line_number":125,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3423243a_ea3633d3","side":"PARENT","line":122,"in_reply_to":"75f20b89_83e08857","updated":"2021-10-18 09:50:48.000000000","message":"It looks  like these variables should be moved from role level to group_vars. Then with add hosts everything will be working as before and also with limit, I\u0027ve already tested it.","commit_id":"41692908564f396577f20cd55e7763f6b078fd7b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cd050869fc5aedb9afed2131602f4c7aa266f1bf","unresolved":true,"context_lines":[{"line_number":123,"context_line":"####################"},{"line_number":124,"context_line":"# Sharding"},{"line_number":125,"context_line":"####################"},{"line_number":126,"context_line":"mariadb_shard_id: \"{{ shard_id | default(mariadb_default_database_shard_id) }}\""},{"line_number":127,"context_line":"mariadb_shard_name: \"shard_{{ mariadb_shard_id }}\""},{"line_number":128,"context_line":"mariadb_shard_group: \"mariadb_{{ mariadb_shard_name }}\""},{"line_number":129,"context_line":"mariadb_shard_database_user: \"{% if mariadb_loadbalancer \u003d\u003d \u0027haproxy\u0027 %}{{ database_user }}{% else %}root_{{ mariadb_shard_name }}{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a9120dec_b30e4c7e","line":126,"range":{"start_line":126,"start_character":22,"end_line":126,"end_character":30},"updated":"2021-10-20 08:54:18.000000000","message":"I don\u0027t understand","commit_id":"49e9a9fcee8fb29f4dcd82466bd49f074de16706"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0639c7cfae7a9a834aafd3bbb39305ec63c5d527","unresolved":true,"context_lines":[{"line_number":123,"context_line":"####################"},{"line_number":124,"context_line":"# Sharding"},{"line_number":125,"context_line":"####################"},{"line_number":126,"context_line":"mariadb_shard_id: \"{{ shard_id | default(mariadb_default_database_shard_id) }}\""},{"line_number":127,"context_line":"mariadb_shard_name: \"shard_{{ mariadb_shard_id }}\""},{"line_number":128,"context_line":"mariadb_shard_group: \"mariadb_{{ mariadb_shard_name }}\""},{"line_number":129,"context_line":"mariadb_shard_database_user: \"{% if mariadb_loadbalancer \u003d\u003d \u0027haproxy\u0027 %}{{ database_user }}{% else %}root_{{ mariadb_shard_name }}{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"8bb30c60_29e283c8","line":126,"range":{"start_line":126,"start_character":22,"end_line":126,"end_character":30},"in_reply_to":"a9120dec_b30e4c7e","updated":"2021-10-20 12:23:12.000000000","message":"Inventory (just for note - default kolla-ansible inventory using mariadb without :children, but below is equivalent of all server in group [mariadb])\n\nScenrario 1 - two shards/clusters (first ids not defined, other defined)\n\n[mariadb:children]\nmariadb-cluster-regionOne\nmariadb-cluster-regionTwo\n\n[mariadb-cluster-regionOne]\nserver1\nserver2                        (no shard_id defined - typical kolla-ansible intentory)\nserver3\n\n[mariadb-cluster-regionTwo]\nserver4 shard_id\u003d2\nserver5 shard_id\u003d2\nserver6 shard_id\u003d2\n\nScenario 2 - two shards explicitly defined shard id in all shards/clusters\n\n[mariadb:children]\nmariadb-cluster-regionOne\nmariadb-cluster-regionTwo\n\n[mariadb-cluster-regionOne]\nserver1 shard_id\u003d1\nserver2 shard_id\u003d1\nserver3 shard_id\u003d1\n\n[mariadb-cluster-regionTwo]\nserver4 shard_id\u003d2\nserver5 shard_id\u003d2\nserver6 shard_id\u003d2\n\nSo, role is functional only if there is shard_id defined, but there is an edge case (actually default behaviour for most users - to not define any shard_id host variable). Because of this it is referenced in defaults/main.yml with default, in first scenario if var is not defined ..it\u0027s using default id, if it is defined ..it is available in role.\n\nWhy not mariadb_shard_group but shard_id explanation in below comment.","commit_id":"49e9a9fcee8fb29f4dcd82466bd49f074de16706"}],"ansible/roles/mariadb/tasks/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f7ee6ff34391d88fb5d66cca74ce1f4954fc585d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  add_host:"},{"line_number":4,"context_line":"    name: \"{{ item }}\""},{"line_number":5,"context_line":"    groups: \"{{ hostvars[item][\u0027mariadb_shard_group\u0027] }}\""},{"line_number":6,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: \"{{ kolla_action }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cfa77132_1640c0a0","line":5,"updated":"2021-10-17 07:13:54.000000000","message":"Instead use a |default in here. I.e., if the variable is not overridden for the host, use the role default.","commit_id":"4a92f9d4931781881e1e5ec8256a37b12561b64b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"64e8b7f408a5d72a0657cc0f63942319e5d76a82","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  add_host:"},{"line_number":4,"context_line":"    name: \"{{ item }}\""},{"line_number":5,"context_line":"    groups: \"{{ hostvars[item][\u0027mariadb_shard_group\u0027] }}\""},{"line_number":6,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: \"{{ kolla_action }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3b8c7902_e6103bc9","line":5,"in_reply_to":"015259bb_145bd480","updated":"2021-10-18 09:10:08.000000000","message":"Well, mariadb_shard_id was used because it is number. This number is then used in proxysql configuration to calculate proper groups ids. Then you can have several shards (clusters) of mariadb and accessible as one cluster. Unfortunatelly it\u0027s not merged yet :( -\u003e https://review.opendev.org/c/openstack/kolla-ansible/+/770215/46","commit_id":"4a92f9d4931781881e1e5ec8256a37b12561b64b"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"2a16cd731ae18c5a5558f6fdac56cea88d30d8bf","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  add_host:"},{"line_number":4,"context_line":"    name: \"{{ item }}\""},{"line_number":5,"context_line":"    groups: \"{{ hostvars[item][\u0027mariadb_shard_group\u0027] }}\""},{"line_number":6,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: \"{{ kolla_action }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6c5bd6f1_05ff5950","line":5,"in_reply_to":"3ac3fb72_2303865a","updated":"2021-10-17 09:10:16.000000000","message":"\u003e Yes, I wrote my suggestion already: use \u0027| default(\"mariadb_shard_group\")\u0027 right after the expression you already have. That should consume the role var in case it is otherwise not defined.\n\nWell, how should it work? In your commit message for the refactoring, you said just add mariadb_shard_id to the hostvars and done it will automatically create the shards groups. When using the role mariadb_shard_group variable it will calculate the value from one host for all and so it will pick up the mariadb_shard_id for the running host, not for each host.\nIf we want to use `default()` we should say in the commit message or release note that if you want to use shards you should define the mariadb_shard_group in hostvars not mariadb_shard_id!","commit_id":"4a92f9d4931781881e1e5ec8256a37b12561b64b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a534bd39a7e26400eec065402350f494259878ce","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  add_host:"},{"line_number":4,"context_line":"    name: \"{{ item }}\""},{"line_number":5,"context_line":"    groups: \"{{ hostvars[item][\u0027mariadb_shard_group\u0027] }}\""},{"line_number":6,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: \"{{ kolla_action }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"015259bb_145bd480","line":5,"in_reply_to":"6c5bd6f1_05ff5950","updated":"2021-10-17 12:02:06.000000000","message":"Hmm, fair point about mariadb_shard_id. Maybe some other core will have a better idea. For now let\u0027s assume we have to refactor as you suggested.","commit_id":"4a92f9d4931781881e1e5ec8256a37b12561b64b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"561b99de69c62292bc39158d8d385d888a01683a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  add_host:"},{"line_number":4,"context_line":"    name: \"{{ item }}\""},{"line_number":5,"context_line":"    groups: \"{{ hostvars[item][\u0027mariadb_shard_group\u0027] }}\""},{"line_number":6,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: \"{{ kolla_action }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3ac3fb72_2303865a","line":5,"in_reply_to":"7efde589_a8b86bc1","updated":"2021-10-17 08:59:09.000000000","message":"Yes, I wrote my suggestion already: use \u0027| default(\"mariadb_shard_group\")\u0027 right after the expression you already have. That should consume the role var in case it is otherwise not defined.","commit_id":"4a92f9d4931781881e1e5ec8256a37b12561b64b"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"d1c1ae6895ad21c817bff3b0b37b31a62ec79db4","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  add_host:"},{"line_number":4,"context_line":"    name: \"{{ item }}\""},{"line_number":5,"context_line":"    groups: \"{{ hostvars[item][\u0027mariadb_shard_group\u0027] }}\""},{"line_number":6,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: \"{{ kolla_action }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7efde589_a8b86bc1","line":5,"in_reply_to":"cfa77132_1640c0a0","updated":"2021-10-17 08:55:04.000000000","message":"\u003e Instead use a |default in here. I.e., if the variable is not overridden for the host, use the role default.\n\nIf the vars were defined at the role level they were not available in hostvars. also, add_host will run on one host and mariadb_shard_group value will be for the running host. Do you have any better solution?","commit_id":"4a92f9d4931781881e1e5ec8256a37b12561b64b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"59cbb3a0cd8ab371378148523b0d088cb137eefd","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  add_host:"},{"line_number":4,"context_line":"    name: \"{{ item }}\""},{"line_number":5,"context_line":"    groups: \"{{ hostvars[item][\u0027mariadb_shard_group\u0027] }}\""},{"line_number":6,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: \"{{ kolla_action }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9821296f_4afb248d","line":6,"updated":"2021-10-18 09:01:13.000000000","message":"This approach would need to use run_once.","commit_id":"4a92f9d4931781881e1e5ec8256a37b12561b64b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3540bbd7e1a841004a9f3a6a315941819b5a17cc","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  add_host:"},{"line_number":4,"context_line":"    name: \"{{ item }}\""},{"line_number":5,"context_line":"    groups: \"{{ hostvars[item][\u0027mariadb_shard_group\u0027] }}\""},{"line_number":6,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: \"{{ kolla_action }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"766b6621_6f92552c","line":6,"in_reply_to":"9821296f_4afb248d","updated":"2021-10-18 09:50:48.000000000","message":"With variables movement to group_vars and task below everything will work OK also with limit, tested. \n\n- name: Group MariaDB hosts based on shards\n  vars:\n    mariadb_shard_id: \"{{ hostvars[item][\u0027mariadb_shard_id\u0027] | default(mariadb_default_database_shard_id) }}\"\n  add_host:\n    name: \"{{ item }}\"\n    groups: \"{{ mariadb_shard_group }}\"\n  with_items: \"{{ groups[\u0027mariadb\u0027] }}\"\n  run_once: yes\n\nNote: There has to be shard_id as it\u0027s used in https://review.opendev.org/c/openstack/kolla-ansible/+/770215/46 \u003c- not merged (but hope it will be)","commit_id":"4a92f9d4931781881e1e5ec8256a37b12561b64b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c761f6187df3478b503b8e04e33c74dbc7cb713e","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""},{"line_number":8,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":9,"context_line":"  run_once: true"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- include_tasks: \"{{ kolla_action }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f5c5c74f_858636bf","line":9,"updated":"2021-10-19 08:11:15.000000000","message":"changed_when: false","commit_id":"721a311d4b8fb9500d9c773117be56d9cff95ed0"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"07e9f03652dc055fd52ac1195aff4612343c3fb5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""},{"line_number":8,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":9,"context_line":"  run_once: true"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- include_tasks: \"{{ kolla_action }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"41773d24_010a4266","line":9,"in_reply_to":"f5c5c74f_858636bf","updated":"2021-10-19 08:40:10.000000000","message":"Done","commit_id":"721a311d4b8fb9500d9c773117be56d9cff95ed0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7d228e7e24f220c58b9284331ec9405ea1e5cb9d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    mariadb_shard_id: \"{{ hostvars[item][\u0027mariadb_shard_id\u0027] | default(mariadb_default_database_shard_id) }}\""},{"line_number":5,"context_line":"  add_host:"},{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4ce1f238_37dbe9e1","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"updated":"2021-10-19 11:34:13.000000000","message":"hmm, I wonder if we could get weird precedence issues here? e.g. if someone overrides this variable in globals.yml.\n\nI\u0027d suggest using a different variable name for the other host\u0027s mariadb_shard_id and mariadb_shard_group.\n\nAlso, if we have the mariadb_shard_group variable in group_vars, wouldn\u0027t it be better to get that directly from hostvars[item]?","commit_id":"0807773efe0c8853c42ee7e87151fee0bcf298a7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"64ed44da4c0417cfa7c34a92d66ae5049685ecd0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    mariadb_shard_id: \"{{ hostvars[item][\u0027mariadb_shard_id\u0027] | default(mariadb_default_database_shard_id) }}\""},{"line_number":5,"context_line":"  add_host:"},{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b05e8953_c1fff293","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"in_reply_to":"0e708b7b_0bf951ff","updated":"2021-10-19 17:43:59.000000000","message":"Done.","commit_id":"0807773efe0c8853c42ee7e87151fee0bcf298a7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"752dfd32518a35a55f263f73e170d59852fd57a1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    mariadb_shard_id: \"{{ hostvars[item][\u0027mariadb_shard_id\u0027] | default(mariadb_default_database_shard_id) }}\""},{"line_number":5,"context_line":"  add_host:"},{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7cc21416_6dd46547","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"in_reply_to":"4ce1f238_37dbe9e1","updated":"2021-10-19 11:35:51.000000000","message":"Seconding that.","commit_id":"0807773efe0c8853c42ee7e87151fee0bcf298a7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c258ce31a81db78d4a8d20a76fd2c4f75c4fe23a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    mariadb_shard_id: \"{{ hostvars[item][\u0027mariadb_shard_id\u0027] | default(mariadb_default_database_shard_id) }}\""},{"line_number":5,"context_line":"  add_host:"},{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"62ae5841_53d0cbf2","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"in_reply_to":"5a1508ef_0c728cc0","updated":"2021-10-19 16:33:11.000000000","message":"Ok, now I think i got it.","commit_id":"0807773efe0c8853c42ee7e87151fee0bcf298a7"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"5856055a967d85988d057bdfefeb786dd56b93b5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    mariadb_shard_id: \"{{ hostvars[item][\u0027mariadb_shard_id\u0027] | default(mariadb_default_database_shard_id) }}\""},{"line_number":5,"context_line":"  add_host:"},{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9d1412c9_801a1cdd","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"in_reply_to":"62ae5841_53d0cbf2","updated":"2021-10-19 16:43:11.000000000","message":"\u003e Ok, now I think i got it.\n\nI think we could move back the variables from group vars to role defaults. Am I wrong?","commit_id":"0807773efe0c8853c42ee7e87151fee0bcf298a7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"393c027a8621fcedbbf8ff9a173f8cbd3d1db8b8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    mariadb_shard_id: \"{{ hostvars[item][\u0027mariadb_shard_id\u0027] | default(mariadb_default_database_shard_id) }}\""},{"line_number":5,"context_line":"  add_host:"},{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a1508ef_0c728cc0","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"in_reply_to":"7cc21416_6dd46547","updated":"2021-10-19 15:36:15.000000000","message":"If someone overrides variable in globals ? Which variable ? \nmariadb_shard_id or mariadb_default_database_shard_id.\n\nIf mariadb_default_database_shard_id -\u003e not problem, I\u0027m using different default (me: 1 , default: 0).\n\nIf you meant mariadb_shard_id -\u003e So that guys should read the docs which are here \nhttps://docs.openstack.org/kolla-ansible/latest/reference/databases/mariadb-guide.html.\n\nmariadb_shard_group should be in role defaults","commit_id":"0807773efe0c8853c42ee7e87151fee0bcf298a7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"91129ab2d67c39099d9d8aba1efd334fdf5e813f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    mariadb_shard_id: \"{{ hostvars[item][\u0027mariadb_shard_id\u0027] | default(mariadb_default_database_shard_id) }}\""},{"line_number":5,"context_line":"  add_host:"},{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0e708b7b_0bf951ff","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"in_reply_to":"9d1412c9_801a1cdd","updated":"2021-10-19 17:33:03.000000000","message":"Yeah, i think so, i will upload changes in few minutes.","commit_id":"0807773efe0c8853c42ee7e87151fee0bcf298a7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1c716820942802bb4bd87c79036c720459f95ade","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    mariadb_shard_id: \"{{ hostvars[item][\u0027mariadb_shard_id\u0027] | default(mariadb_default_database_shard_id) }}\""},{"line_number":5,"context_line":"  add_host:"},{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""},{"line_number":8,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":9,"context_line":"  run_once: true"},{"line_number":10,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"34e44213_f236ced3","line":7,"range":{"start_line":3,"start_character":0,"end_line":7,"end_character":39},"updated":"2021-10-19 11:30:42.000000000","message":"with this code in place, do we still need the role vars moved to group vars?","commit_id":"0807773efe0c8853c42ee7e87151fee0bcf298a7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"752dfd32518a35a55f263f73e170d59852fd57a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    mariadb_shard_id: \"{{ hostvars[item][\u0027mariadb_shard_id\u0027] | default(mariadb_default_database_shard_id) }}\""},{"line_number":5,"context_line":"  add_host:"},{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""},{"line_number":8,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":9,"context_line":"  run_once: true"},{"line_number":10,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b5910544_161ee7b1","line":7,"range":{"start_line":3,"start_character":0,"end_line":7,"end_character":39},"in_reply_to":"34e44213_f236ced3","updated":"2021-10-19 11:35:51.000000000","message":"Let\u0027s go with what Mark has proposed.","commit_id":"0807773efe0c8853c42ee7e87151fee0bcf298a7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"64ed44da4c0417cfa7c34a92d66ae5049685ecd0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    mariadb_shard_id: \"{{ hostvars[item][\u0027mariadb_shard_id\u0027] | default(mariadb_default_database_shard_id) }}\""},{"line_number":5,"context_line":"  add_host:"},{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""},{"line_number":8,"context_line":"  loop: \"{{ groups[\u0027mariadb\u0027] }}\""},{"line_number":9,"context_line":"  run_once: true"},{"line_number":10,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"678ba732_9091f041","line":7,"range":{"start_line":3,"start_character":0,"end_line":7,"end_character":39},"in_reply_to":"b5910544_161ee7b1","updated":"2021-10-19 17:43:59.000000000","message":"Done","commit_id":"0807773efe0c8853c42ee7e87151fee0bcf298a7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cd050869fc5aedb9afed2131602f4c7aa266f1bf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    mariadb_shard_id: \"{{ hostvars[item][\u0027shard_id\u0027] | default(mariadb_default_database_shard_id) }}\""},{"line_number":5,"context_line":"  add_host:"},{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f866d337_23c31f5a","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"updated":"2021-10-20 08:54:18.000000000","message":"My suggestion was to change the task variable, to use a different name than the shard variable. Also to reference directly the group variable. This approach would require the variables to be in group_vars, but that\u0027s not so bad.\n\n- name: Group MariaDB hosts based on shards\n  vars:\n    other_mariadb_shard_group: \"{{ hostvars[item][\u0027mariadb_shard_group\u0027] }}\"\n  add_host:\n    name: \"{{ item }}\"\n    groups: \"{{ other_mariadb_shard_group }}\"\n  loop: \"{{ groups[\u0027mariadb\u0027] }}\"\n  run_once: true\n  changed_when: false","commit_id":"49e9a9fcee8fb29f4dcd82466bd49f074de16706"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0639c7cfae7a9a834aafd3bbb39305ec63c5d527","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Group MariaDB hosts based on shards"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    mariadb_shard_id: \"{{ hostvars[item][\u0027shard_id\u0027] | default(mariadb_default_database_shard_id) }}\""},{"line_number":5,"context_line":"  add_host:"},{"line_number":6,"context_line":"    name: \"{{ item }}\""},{"line_number":7,"context_line":"    groups: \"{{ mariadb_shard_group }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ca7f2dfd_857e5acc","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"in_reply_to":"f866d337_23c31f5a","updated":"2021-10-20 12:23:12.000000000","message":"As I said in previous comments, there is need to use shard_id because proxysql patches generating hostgroups into proxysql configuration , proxysql has integer ids - it\u0027s simpler to just use var than crop that information from group (if it will be changed in hostvar from id to group - so if there is need to have \"id\" , group doesn\u0027t makes sense)","commit_id":"49e9a9fcee8fb29f4dcd82466bd49f074de16706"}]}