)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c17eefe13a3276998ad786666050cf1f31646b4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d45227f_75718b8b","updated":"2021-10-18 10:45:34.000000000","message":"Argh, I need to learn how to properly handle threads in the new Gerrit. 😄","commit_id":"e906a3dce6b8f12416c97a08024c4adc17b869dc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5af4b51926df349e249627ccea72d7b67ab9d601","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4dca6b08_d51df98e","updated":"2021-10-18 10:45:07.000000000","message":"This is due to:\n  enable_mariadb_clustercheck: \"{{ enable_haproxy }}\"\n","commit_id":"e906a3dce6b8f12416c97a08024c4adc17b869dc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"13eaa0d261265116a299b8be19dbced893aba488","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0a6c2829_deabc20a","updated":"2021-10-18 10:44:24.000000000","message":"so we need this in xena for all distros and for debian in wallaby; I guess we can put more conditions for Debian in Wallaby, eh!","commit_id":"e906a3dce6b8f12416c97a08024c4adc17b869dc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"79d01b04107c2a9feca31b1401ec6f68a9e726e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"24b4547a_5e351994","updated":"2021-10-18 10:43:34.000000000","message":"we even HAVE TO do this to fix the following issue: https://bugs.launchpad.net/kolla-ansible/+bug/1947534","commit_id":"e906a3dce6b8f12416c97a08024c4adc17b869dc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"803083a4f204c22865cc43316c3e55eb8c540719","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"024a15e0_e9ef5990","in_reply_to":"24b4547a_5e351994","updated":"2021-10-18 10:49:08.000000000","message":"Yes, as I mentioned last week - single node deploys with haproxy disabled end up not working.","commit_id":"e906a3dce6b8f12416c97a08024c4adc17b869dc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"41511071a86a3eac1708025dadc52dbc552bb451","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cc59e73f_1c425750","updated":"2021-10-18 11:46:03.000000000","message":"You forgot to remove the actual file. Also, the haproxy config in mariadb defaults has to be amended (simply no checks if clustercheck is disabled).","commit_id":"d26fb36f46b3b44edb2a86c49034615a3fdcc2d7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8323081523a4c6cd5fdc4a2a19d843d61a214c9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0f5b6bd1_98177b09","updated":"2021-10-19 11:22:59.000000000","message":"ah, the closes-bug was missed; let\u0027s add after tests pass","commit_id":"09f119800555385ee23b725a7e842e9b30efd3a9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3c8472fa5d111429a3123bf0cc06ec51cccab776","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"22c04136_76e12ab2","updated":"2021-10-19 11:22:40.000000000","message":"looks sensible, let\u0027s wait for testing in https://review.opendev.org/c/openstack/kolla-ansible/+/814553","commit_id":"09f119800555385ee23b725a7e842e9b30efd3a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"13a1f8f4374b65ba4742c853730272e973fc271d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2f674ad3_f22d0fd0","in_reply_to":"0f5b6bd1_98177b09","updated":"2021-10-19 12:09:02.000000000","message":"tests passed (broke on certificate for keystone on 192.0.2.1, but I\u0027m not going to work on this further - MariaDB works without HAProxy).","commit_id":"09f119800555385ee23b725a7e842e9b30efd3a9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"de0546b82fdd5fb6c5eccaf856d7a7711f5dacc7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"28c2a034_10e04b60","updated":"2021-10-19 12:56:14.000000000","message":"Ok, one last thing - do we want a bugfix reno here? Maybe?","commit_id":"77c23f1fe7eed5d02913df6b6f7a370d5dfa270f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8ec0e47b80af93e796f893a758681c211697a91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"06238b90_369defdb","updated":"2021-10-20 09:04:45.000000000","message":"in wallaby needs to be done for debian as a proper fix, not just complete removal; in xena clean backport","commit_id":"b6b7401c0d71298ac32b1437c3a309c6957ef5c0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3f839c9252797377a8386517c6503742b198640a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0b41125c_ad33c6d6","updated":"2021-10-20 07:04:06.000000000","message":"recheck (centos Ceph jobs failed...)","commit_id":"b6b7401c0d71298ac32b1437c3a309c6957ef5c0"}],"ansible/roles/mariadb/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"803ffd561e5112bea8955e7a1d88427fcd3a31cc","unresolved":true,"context_lines":[{"line_number":58,"context_line":"# HAProxy"},{"line_number":59,"context_line":"####################"},{"line_number":60,"context_line":"internal_haproxy_members: \"{% for host in mariadb_default_database_shard_hosts %} server {{ hostvars[host].ansible_facts.hostname }} {{ \u0027api\u0027 | kolla_address(host) }}:{{ mariadb_port }} check {% if enable_mariadb_clustercheck | bool %}port {{ mariadb_clustercheck_port }}{% endif %} inter 2000 rise 2 fall 5{% if not loop.first %} backup{% endif %};{% endfor %}\""},{"line_number":61,"context_line":"external_haproxy_members: \"{% for host in mariadb_default_database_shard_hosts %} server {{ host }} {{ host }}:{{ mariadb_port }} check {% if enable_mariadb_clustercheck | bool %}port {{ mariadb_clustercheck_port }}{% endif %} inter 2000 rise 2 fall 5{% if not loop.first %} backup{% endif %};{% endfor %}\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"####################"},{"line_number":64,"context_line":"# Docker"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"40c67e45_ab74da5e","line":61,"updated":"2021-10-18 13:03:30.000000000","message":"also in the two lines above - we have no check if there is no clustercheck","commit_id":"430135290ebfc7041581f91cf205a2afc52fb1c1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d131c1291165c8ed283d7973cfd13bd5250bf9b4","unresolved":true,"context_lines":[{"line_number":57,"context_line":"####################"},{"line_number":58,"context_line":"# HAProxy"},{"line_number":59,"context_line":"####################"},{"line_number":60,"context_line":"internal_haproxy_members: \"{% for host in mariadb_default_database_shard_hosts %} server {{ hostvars[host].ansible_facts.hostname }} {{ \u0027api\u0027 | kolla_address(host) }}:{{ mariadb_port }} {% if enable_mariadb_clustercheck | bool %}check port {{ mariadb_clustercheck_port }}{% endif %} inter 2000 rise 2 fall 5{% if not loop.first %} backup{% endif %};{% endfor %}\""},{"line_number":61,"context_line":"external_haproxy_members: \"{% for host in mariadb_default_database_shard_hosts %} server {{ host }} {{ host }}:{{ mariadb_port }} {% if enable_mariadb_clustercheck | bool %}check port {{ mariadb_clustercheck_port }}{% endif %} inter 2000 rise 2 fall 5{% if not loop.first %} backup{% endif %};{% endfor %}\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3ec7a694_3eace696","line":60,"range":{"start_line":60,"start_character":271,"end_line":60,"end_character":282},"updated":"2021-10-19 08:09:07.000000000","message":"need to move it further along too in this case; maybe we could just monitor the tcp port instead if we don\u0027t user mariadb_clustercheck?","commit_id":"10625c8a743a25e812aae33a21d92f41f257750f"}],"releasenotes/notes/bug-1947534-bf3b5ed19473015f.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"77e37147585f17fb0aa592b83e095dcdba5831fd","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with single node MariaDB deployments with HAProxy disabled."},{"line_number":5,"context_line":"    The WSREP notify script has been deprecated in Wallaby and is removed in"},{"line_number":6,"context_line":"    Xena. "},{"line_number":7,"context_line":"    See `bug 1947534 \u003chttps://launchpad.net/bugs/1947534\u003e`__ for details."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"214744f2_5c60969b","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":10},"updated":"2021-10-19 17:03:58.000000000","message":"whitespace; also, we don\u0027t have to repeat that here","commit_id":"b5d752ef9a2f5441b8315652886169431886c8ef"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"77e37147585f17fb0aa592b83e095dcdba5831fd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9e2cf437_08643583","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":0},"updated":"2021-10-19 17:03:58.000000000","message":"this is in the other file","commit_id":"b5d752ef9a2f5441b8315652886169431886c8ef"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6fb3d55f2c9fd6e2b5ca3547187c09cf9fc94287","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"888175b2_7a4c23ce","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"9e2cf437_08643583","updated":"2021-10-20 05:38:27.000000000","message":"That\u0027s how you end writing renos in PTG break ;-) Thanks.","commit_id":"b5d752ef9a2f5441b8315652886169431886c8ef"}],"releasenotes/notes/remove-wsrep-notify-dbb5ef5f700b06b1.yaml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"eeafd482a7106a95479604baa56a7c5ad2935cb1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``wsrep-notify.sh`` script has been removed (following deprecation"},{"line_number":5,"context_line":"    in Wallaby)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"91b41c17_76e0183c","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":16},"updated":"2021-10-18 11:33:03.000000000","message":"Shouldn\u0027t be also good to let users know that if they overriden enable_mariadb_clustercheck\u003dno in globals for some reason, this will not be supported and they have only one option - turn on clustercheck ?\n\nHovewer, for me this is not blocker, so I\u0027m adding +1.","commit_id":"d26fb36f46b3b44edb2a86c49034615a3fdcc2d7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1504c97cbdc49ca263bef4801c100728fca4e0f8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``wsrep-notify.sh`` script has been removed (following deprecation"},{"line_number":5,"context_line":"    in Wallaby)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"13c1243b_a265f003","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":16},"in_reply_to":"91b41c17_76e0183c","updated":"2021-10-18 11:42:16.000000000","message":"Yeah, sounds good to fail prechecks if clustercheck is disabled but haproxy is not.","commit_id":"d26fb36f46b3b44edb2a86c49034615a3fdcc2d7"}]}