)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"ebb70c1512845b411006dd1630a04b0d93ab8b70","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c43a81ee_a223d64a","updated":"2021-10-27 13:15:50.000000000","message":"@Radosław\n\nNot sure what would be the difference between KOLLA_OPENSTACK_RELEASE and KOLLA_BRANCH_NAME. Why do we need both?\n\n","commit_id":"cd094bb873dc75228bdaca00ceeb564ec2f3a769"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"9c82abd63a6ff5a1ef7ed9644a11d85031fe1925","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cebd1f6d_9fca89a9","in_reply_to":"168af40c_06f507af","updated":"2021-10-27 13:46:07.000000000","message":"I\u0027ve initially used KOLLA_GIT_BRANCH here:\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/815043/1/doc/source/conf.py#121\n\nbut got this feedback (opposed to yours):\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/815043/comment/dc615628_30485ab3/\n\nMy proposal is to only have KOLLA_GIT_BRANCH (used both for kolla and kolla-ansible). And comment above the variable that full branch name should be specified, e.g. \u0027master\u0027, \u0027stable/victoria\u0027 etc.\n\nI prefer this version instead of this less obvious workaround: if KOLLA_OPENSTACK_RELEASE !\u003d \u0027master\u0027: \u0027stable/{}\u0027.format(KOLLA_OPENSTACK_RELEASE)\n\nAnd completely remove KOLLA_OPENSTACK_RELEASE, since AFAIK it\u0027s not needed.\n\nAgreed? If not, please describe in detail why both KOLLA_OPENSTACK_RELEASE and KOLLA_GIT_BRANCH are needed.","commit_id":"cd094bb873dc75228bdaca00ceeb564ec2f3a769"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4f90bd4b1a836b566ac75e3d0d4d7bcc9b581b28","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"168af40c_06f507af","in_reply_to":"c43a81ee_a223d64a","updated":"2021-10-27 13:30:30.000000000","message":"Well, then the names reflect the contents. You don\u0027t strictly need KOLLA_OPENSTACK_RELEASE except for the fact that it\u0027s easy to define without forgetting about stable/ prefix.","commit_id":"cd094bb873dc75228bdaca00ceeb564ec2f3a769"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b3464daf322d27900887e45caa92bc8877514a97","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ddd61e04_db36966e","in_reply_to":"cebd1f6d_9fca89a9","updated":"2021-10-27 13:52:23.000000000","message":"As I said, we don\u0027t *need* both but it\u0027s nice to be able to provide only the name and have logic in place to convert the release name to branch name. It is also what we have in kolla-build internally - we have dedicated vars to created stable-release and stable/release flavours of identifiers. You can have both in code and in the map only KOLLA_BRANCH_NAME (KOLLA_GIT_BRANCH is fine too, whichever you prefer really) if you prefer to. But having both there will not hurt either.","commit_id":"cd094bb873dc75228bdaca00ceeb564ec2f3a769"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"81c4823c7dfa858d490be6c46e3c7bb457fca6c5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7eee1c39_b73b7fa6","updated":"2021-10-29 19:52:44.000000000","message":"And another thing\n\nKOLLA_OPENSTACK_RELEASE \u003d openstackdocstheme.ext._get_series_name()\n\nreturns \u0027victoria\u0027, \u0027wallby\u0027 etc., then being turned into ``git clone --branch stable/victoria https://opendev.org/openstack/kolla`` - which is fine)\n\nBut on master it returns \u0027latest\u0027 and there no latest remote branch like:\n\ngit clone --branch latest https://opendev.org/openstack/kolla\n\nCould do:\n\nif KOLLA_OPENSTACK_RELEASE \u003d\u003d \u0027latest\u0027:\n    KOLLA_BRANCH_NAME \u003d \u0027master\u0027\n\nwhich would give:\n\ngit clone --branch master https://opendev.org/openstack/kolla\n\nwhich is fine. Should I do it like that?\n\nSorry for asking all this noob questions, unfortunately I\u0027m not familiar with all the ecosystem.\n\n","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"b4b2d82162421f7176ad4144a9c0f06264321335","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e55c091e_b92be0d7","updated":"2021-11-03 15:54:34.000000000","message":"Decided in the Nov 3rd 2021 meeting to use pip with git URLs. I\u0027ll do this.\n\nhttps://meetings.opendev.org/irclogs/%23openstack-kolla/%23openstack-kolla.2021-11-03.log.html#t2021-11-03T15:36:31\n\n","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"ab2fd00b13a07dc5117c68eb09848bea5932f397","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8d678bd3_a3f8d890","updated":"2021-10-29 16:11:41.000000000","message":"I can make another commit. Should I keep the same change number? Not sure if it will work with the same change number now that previous commit is merged. And I guess I can\u0027t amend the commit now that it\u0027s in the master. I\u0027ll need a new commit.","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"12923ef722d4657f14fb95269e4f0149c5cdbe64","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e4322655_ac2bf6bf","updated":"2021-10-29 19:31:41.000000000","message":"I was testing steps in docs after changes and:\n\n$ pip install kolla-ansible\u003d\u003d13.*\nERROR: Could not find a version that satisfies the requirement kolla-ansible\u003d\u003d13.* (from versions: 4.0.0.0b2, 4.0.0.0b3, 4.0.0.0rc1, 4.0.0.0rc2, 4.0.0, 4.0.1, 4.0.2, 4.0.3, 4.0.4, 4.0.5, 5.0.0.0b2, 5.0.0.0b3, 5.0.0.0rc1, 5.0.0.0rc2, 5.0.0, 5.0.1, 5.0.2, 5.0.3, 5.0.4, 5.0.5, 5.0.6, 6.0.0.0b2, 6.0.0.0b3, 6.0.0.0rc1, 6.0.0.0rc2, 6.0.0, 6.1.0, 6.1.1, 6.2.0, 6.2.1, 6.2.2, 6.2.3, 7.0.0.0b2, 7.0.0.0b3, 7.0.0.0rc1, 7.0.0.0rc2, 7.0.0.0rc3, 7.0.0, 7.0.1, 7.1.0, 7.1.1, 7.1.2, 7.2.0, 7.2.1, 8.0.0.0b1, 8.0.0.0rc1, 8.0.0.0rc2, 8.0.0, 8.0.1, 8.1.0, 8.1.1, 8.2.0, 8.3.0, 9.0.0.0rc1, 9.0.0.0rc2, 9.0.0.0rc3, 9.0.0, 9.0.1, 9.1.0, 9.2.0, 9.3.0, 9.3.1, 9.3.2, 10.0.0.0rc1, 10.0.0.0rc2, 10.0.0, 10.1.0, 10.2.0, 10.3.0, 11.0.0.0rc1, 11.0.0.0rc2, 11.0.0, 11.1.0, 12.0.0.0rc1, 12.0.0.0rc2, 12.0.0, 12.1.0, 12.2.0, 13.0.0.0rc1)\nERROR: No matching distribution found for kolla-ansible\u003d\u003d13.*\n\nThis doesn\u0027t work since there no stable version matching 13.* (only a dev release).\n\nIt would work with:\n\npip install --pre kolla-ansible\u003d\u003d13.*\n\nPossible fix, would be to have this in config.py:\n\nif KOLLA_OPENSTACK_RELEASE \u003d\u003d \u0027master\u0027:\n    PIP_PRE_FLAG \u003d \u0027 --pre\u0027\nelse:\n    PIP_PRE_FLAG \u003d \u0027\u0027\n\nand then in quickstart.rst:\n\npip install|PIP_PRE_FLAG| kolla-ansible\u003d\u003d|KOLLA_ANSIBLE_MAJOR_VERSION|.*\n\nMakes sense or do you have a better idea?\n\nAny other git branches that would require --pre flag, besides master?\n\n","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"4f68241fd29fee4f5c48151d25cd7f8dd56bbfd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"669fe655_71f53e25","updated":"2021-10-29 09:13:35.000000000","message":"Mark, since this is already merged, let me know how should I proceed.","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"3543d14fc5999a9d9ee5cb29d8477a18894303a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"089c1233_cb8a71b9","updated":"2021-11-03 21:17:07.000000000","message":"New comments implemented in https://review.opendev.org/c/openstack/kolla-ansible/+/816582 ","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1ac3ea0a7b4c204a08e7183558f0cfe71c28a114","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4260e60c_684d3279","in_reply_to":"1ed16881_2f0cfc39","updated":"2021-11-01 11:11:00.000000000","message":"Let\u0027s discuss it during the next Kolla meeting or so. I agree to go with it but it needs more eyes. Added to the agenda. https://etherpad.opendev.org/p/KollaWhiteBoard","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"89d7b4208829c27ad67877008beba73fffd223b1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f12bf149_939e646a","in_reply_to":"1f5c8e0e_ed9397a2","updated":"2021-10-29 20:13:18.000000000","message":"No problem. Seems like drama keeps rolling, for such a minor issue :)\n\n1. I\u0027m over my head if install for PyPI is the same as install from git. E.g. what the PyPI release frequencies, does it matches https://opendev.org? And other implications that you know better.\n\n2. Install from git almost works now, but not entirely.\n\nIn a fresh env (python3 -m venv env):\n\npip install kolla-ansible - completes, though we do have an error:\n\nERROR: packaging 21.2 has requirement pyparsing\u003c3,\u003e\u003d2.0.2, but you\u0027ll have pyparsing 3.0.3 which is incompatible.\n\nshould I create a bug for it?\n\nBut installs from git gives fatal error:\n\npip install git+https://opendev.org/openstack/kolla-ansible@master\nand\npip install git+https://opendev.org/openstack/kolla-ansible@stable/victoria\n\nboth give:\n\n...\nBuilding wheels for collected packages: kolla-ansible\n  Building wheel for kolla-ansible (setup.py) ... error\n  ERROR: Command errored out with exit status 1:\n   command: /home/adrian/tt/env/bin/python3 -u -c \u0027import sys, setuptools, tokenize; sys.argv[0] \u003d \u0027\"\u0027\"\u0027/tmp/pip-req-build-xz7tp8e5/setup.py\u0027\"\u0027\"\u0027; __file__\u003d\u0027\"\u0027\"\u0027/tmp/pip-req-build-xz7tp8e5/setup.py\u0027\"\u0027\"\u0027;f\u003dgetattr(tokenize, \u0027\"\u0027\"\u0027open\u0027\"\u0027\"\u0027, open)(__file__);code\u003df.read().replace(\u0027\"\u0027\"\u0027\\r\\n\u0027\"\u0027\"\u0027, \u0027\"\u0027\"\u0027\\n\u0027\"\u0027\"\u0027);f.close();exec(compile(code, __file__, \u0027\"\u0027\"\u0027exec\u0027\"\u0027\"\u0027))\u0027 bdist_wheel -d /tmp/pip-wheel-dhc1upl3\n       cwd: /tmp/pip-req-build-xz7tp8e5/\n  Complete output (6 lines):\n  usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]\n     or: setup.py --help [cmd1 cmd2 ...]\n     or: setup.py --help-commands\n     or: setup.py cmd --help\n  \n  error: invalid command \u0027bdist_wheel\u0027\n  ----------------------------------------\n  ERROR: Failed building wheel for kolla-ansible\n  Running setup.py clean for kolla-ansible\nFailed to build kolla-ansible\n...\n\n\nSo if we decide to go with pip install from git, I think we need `wheel` in requirements.txt.","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"98c28e7f92a1acb709723df76141b6aafcc69c8f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4a5c977d_0b2ae23e","in_reply_to":"8d678bd3_a3f8d890","updated":"2021-10-29 17:51:16.000000000","message":"Yes, just new commit, standard procedures.","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0596a6ad26363f693e1bed008a81708f77a09880","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1ed16881_2f0cfc39","in_reply_to":"a2012ad9_e12b3515","updated":"2021-11-01 09:46:41.000000000","message":"openstack-ansible uses this to determine the most recent tag:\n\n latest_tag \u003d subprocess.check_output([\"git\", \"describe\", \"--abbrev\u003d0\", \"--tag\"]).strip().decode()\n\nOn master this command gives you the last RC1 release, which is probably not what we want. One option is to pass in the pip requirement as a variable, using\n\ngit+https://opendev.org/openstack/kolla-ansible@master\n\non master, and\n\nkolla-ansible\u003d\u003d\u003clatest tag\u003e\n\non stable branches. Alternatively we could go the branch route always. Is this something that should be discussed in a wider group?","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f5712f2557a2e53fcf198479e60e91154e443a39","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1f5c8e0e_ed9397a2","in_reply_to":"e4322655_ac2bf6bf","updated":"2021-10-29 19:38:26.000000000","message":"Yeah, the problem is that stable/xena currently needs it too. Hmm, I wonder if we should not encourage users to adopt more agile/devops mindset by using git repo over releases. That might make more sense even from the debuggability perspective, for us. Not to mention fixing all the issues with keeping the version numbers up to date. WDYT?\n\nAnd I also want to thank you for thinking about and working on this. This is much appreciated!","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"ad3a7e7a9744e647aa46cc4d862d41f7415f111c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a2012ad9_e12b3515","in_reply_to":"f12bf149_939e646a","updated":"2021-10-29 21:48:22.000000000","message":"Actually on 2. - never mind, install from git works after `pip install -U pip` (which is specified in documentation). It goes over the wheel issue:\n\n\u003e Using legacy \u0027setup.py install\u0027 for ansible, since package \u0027wheel\u0027 is not installed.\n\nAll these commands complete successfully after pip update:\n\npip install kolla-ansible\npip install git+https://opendev.org/openstack/kolla-ansible@master\npip install git+https://opendev.org/openstack/kolla-ansible@stable/victoria\n\nSo technically kolla-ansible can be installed with pip from git and it\u0027s just a matter of 1. - do we want this?","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"}],"doc/source/conf.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"35c984bb036d6b204030176a221d20d114c69ec8","unresolved":true,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"KOLLA_ANSIBLE_CURRENT_VERSION \u003d \u00279\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"KOLLA_GIT_BRANCH \u003d \u0027master\u0027"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"KOLLA_ANSIBLE_GIT_BRANCH \u003d \u0027master\u0027"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"GLOBAL_VARIABLE_MAP \u003d {"},{"line_number":125,"context_line":"    \"|KOLLA_ANSIBLE_CURRENT_VERSION|\": KOLLA_ANSIBLE_CURRENT_VERSION,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dc615628_30485ab3","line":122,"range":{"start_line":120,"start_character":0,"end_line":122,"end_character":35},"updated":"2021-10-27 11:34:27.000000000","message":"KOLLA_OPENSTACK_RELEASE should be enough as both Kolla and Kolla-Ansible should be in sync.\n\nKOLLA_OPENSTACK_RELEASE \u003d \"xena\" and then \"if !master then \u0027stable/KOLLA_OPENSTACK_RELEASE\u0027?","commit_id":"bceb8991c2f7794308c36adc5d98204dbebf38fb"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"ebb70c1512845b411006dd1630a04b0d93ab8b70","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"KOLLA_ANSIBLE_CURRENT_VERSION \u003d \u00279\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"KOLLA_GIT_BRANCH \u003d \u0027master\u0027"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"KOLLA_ANSIBLE_GIT_BRANCH \u003d \u0027master\u0027"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"GLOBAL_VARIABLE_MAP \u003d {"},{"line_number":125,"context_line":"    \"|KOLLA_ANSIBLE_CURRENT_VERSION|\": KOLLA_ANSIBLE_CURRENT_VERSION,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fedf76f4_c14be0ba","line":122,"range":{"start_line":120,"start_character":0,"end_line":122,"end_character":35},"in_reply_to":"dc615628_30485ab3","updated":"2021-10-27 13:15:50.000000000","message":"Done","commit_id":"bceb8991c2f7794308c36adc5d98204dbebf38fb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"716e9f459730556f63c988e6236cb779b32422d1","unresolved":true,"context_lines":[{"line_number":115,"context_line":"# For replacement, use in docs as |VAR_NAME| (note there\u0027s no space around variable name)"},{"line_number":116,"context_line":"# When adding new variables, make sure you add them to GLOBAL_VARIABLE_MAP dictionary as well"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"KOLLA_ANSIBLE_CURRENT_VERSION \u003d \u00279\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# use \u0027master\u0027 or release name, e.g. \u0027victoria\u0027, \u0027xena\u0027 etc."},{"line_number":121,"context_line":"KOLLA_OPENSTACK_RELEASE \u003d \u0027master\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"40c89224_06a61495","line":118,"range":{"start_line":118,"start_character":14,"end_line":118,"end_character":21},"updated":"2021-10-27 12:35:59.000000000","message":"MAJOR","commit_id":"cd094bb873dc75228bdaca00ceeb564ec2f3a769"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"716e9f459730556f63c988e6236cb779b32422d1","unresolved":true,"context_lines":[{"line_number":120,"context_line":"# use \u0027master\u0027 or release name, e.g. \u0027victoria\u0027, \u0027xena\u0027 etc."},{"line_number":121,"context_line":"KOLLA_OPENSTACK_RELEASE \u003d \u0027master\u0027"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"if KOLLA_OPENSTACK_RELEASE !\u003d \u0027master\u0027:"},{"line_number":124,"context_line":"    KOLLA_OPENSTACK_RELEASE \u003d \u0027stable/{}\u0027.format(KOLLA_OPENSTACK_RELEASE)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fade3997_f4b28753","line":123,"updated":"2021-10-27 12:35:59.000000000","message":"let\u0027s use a separate var for that, like \"KOLLA_BRANCH_NAME\"","commit_id":"cd094bb873dc75228bdaca00ceeb564ec2f3a769"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"55f48e5683105ab3e3f4ef7eff962a9788722f7d","unresolved":true,"context_lines":[{"line_number":120,"context_line":"# use \u0027master\u0027 or release name, e.g. \u0027victoria\u0027, \u0027xena\u0027 etc."},{"line_number":121,"context_line":"KOLLA_OPENSTACK_RELEASE \u003d \u0027master\u0027"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"if KOLLA_OPENSTACK_RELEASE !\u003d \u0027master\u0027:"},{"line_number":124,"context_line":"    KOLLA_OPENSTACK_RELEASE \u003d \u0027stable/{}\u0027.format(KOLLA_OPENSTACK_RELEASE)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fc2c6666_7cf723d3","line":123,"in_reply_to":"fade3997_f4b28753","updated":"2021-10-27 13:27:54.000000000","message":"Not sure what would be the difference between KOLLA_OPENSTACK_RELEASE and KOLLA_BRANCH_NAME. Why do we need both?","commit_id":"cd094bb873dc75228bdaca00ceeb564ec2f3a769"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eb23118bfc40328ac215bffda311a17c94369060","unresolved":true,"context_lines":[{"line_number":115,"context_line":"# For replacement, use in docs as |VAR_NAME| (note there\u0027s no space around variable name)"},{"line_number":116,"context_line":"# When adding new variables, make sure you add them to GLOBAL_VARIABLE_MAP dictionary as well"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"KOLLA_ANSIBLE_MAJOR_VERSION \u003d \u00279\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# use \u0027master\u0027 or release name, e.g. \u0027victoria\u0027, \u0027xena\u0027 etc."},{"line_number":121,"context_line":"KOLLA_OPENSTACK_RELEASE \u003d \u0027master\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"60aba6ae_6bb76d28","line":118,"range":{"start_line":118,"start_character":31,"end_line":118,"end_character":32},"updated":"2021-10-29 08:40:19.000000000","message":"Isn\u0027t xena 13? Anyway, let\u0027s not hard code it. We have enough upgrade steps already.","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"98ed661cafe77a3d322cca50c02e4041a3f8b6e4","unresolved":true,"context_lines":[{"line_number":115,"context_line":"# For replacement, use in docs as |VAR_NAME| (note there\u0027s no space around variable name)"},{"line_number":116,"context_line":"# When adding new variables, make sure you add them to GLOBAL_VARIABLE_MAP dictionary as well"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"KOLLA_ANSIBLE_MAJOR_VERSION \u003d \u00279\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# use \u0027master\u0027 or release name, e.g. \u0027victoria\u0027, \u0027xena\u0027 etc."},{"line_number":121,"context_line":"KOLLA_OPENSTACK_RELEASE \u003d \u0027master\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"ceadbad7_885fcf18","line":118,"range":{"start_line":118,"start_character":31,"end_line":118,"end_character":32},"in_reply_to":"0e5b7a85_827ed2eb","updated":"2021-10-29 16:00:08.000000000","message":"I don\u0027t think so. And yeah, Xena is 13, need to patch it. Good catch @mgoddard","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"4f68241fd29fee4f5c48151d25cd7f8dd56bbfd1","unresolved":true,"context_lines":[{"line_number":115,"context_line":"# For replacement, use in docs as |VAR_NAME| (note there\u0027s no space around variable name)"},{"line_number":116,"context_line":"# When adding new variables, make sure you add them to GLOBAL_VARIABLE_MAP dictionary as well"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"KOLLA_ANSIBLE_MAJOR_VERSION \u003d \u00279\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# use \u0027master\u0027 or release name, e.g. \u0027victoria\u0027, \u0027xena\u0027 etc."},{"line_number":121,"context_line":"KOLLA_OPENSTACK_RELEASE \u003d \u0027master\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"0e5b7a85_827ed2eb","line":118,"range":{"start_line":118,"start_character":31,"end_line":118,"end_character":32},"in_reply_to":"60aba6ae_6bb76d28","updated":"2021-10-29 09:13:35.000000000","message":"I think the idea from this issue was to have versions pinned and easy to update on each stable branch/master.\n\nIs there a way to get release number without hard coding?","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eb23118bfc40328ac215bffda311a17c94369060","unresolved":true,"context_lines":[{"line_number":118,"context_line":"KOLLA_ANSIBLE_MAJOR_VERSION \u003d \u00279\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# use \u0027master\u0027 or release name, e.g. \u0027victoria\u0027, \u0027xena\u0027 etc."},{"line_number":121,"context_line":"KOLLA_OPENSTACK_RELEASE \u003d \u0027master\u0027"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"if KOLLA_OPENSTACK_RELEASE \u003d\u003d \u0027master\u0027:"},{"line_number":124,"context_line":"    KOLLA_BRANCH_NAME \u003d KOLLA_OPENSTACK_RELEASE"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a81e812_789bfaea","line":121,"range":{"start_line":121,"start_character":26,"end_line":121,"end_character":34},"updated":"2021-10-29 08:40:19.000000000","message":"openstackdocstheme.ext._get_series_name()","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"4f68241fd29fee4f5c48151d25cd7f8dd56bbfd1","unresolved":true,"context_lines":[{"line_number":118,"context_line":"KOLLA_ANSIBLE_MAJOR_VERSION \u003d \u00279\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# use \u0027master\u0027 or release name, e.g. \u0027victoria\u0027, \u0027xena\u0027 etc."},{"line_number":121,"context_line":"KOLLA_OPENSTACK_RELEASE \u003d \u0027master\u0027"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"if KOLLA_OPENSTACK_RELEASE \u003d\u003d \u0027master\u0027:"},{"line_number":124,"context_line":"    KOLLA_BRANCH_NAME \u003d KOLLA_OPENSTACK_RELEASE"}],"source_content_type":"text/x-python","patch_set":6,"id":"a5b52b8b_474baad1","line":121,"range":{"start_line":121,"start_character":26,"end_line":121,"end_character":34},"in_reply_to":"9a81e812_789bfaea","updated":"2021-10-29 09:13:35.000000000","message":"I can do that.","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"98ed661cafe77a3d322cca50c02e4041a3f8b6e4","unresolved":true,"context_lines":[{"line_number":118,"context_line":"KOLLA_ANSIBLE_MAJOR_VERSION \u003d \u00279\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# use \u0027master\u0027 or release name, e.g. \u0027victoria\u0027, \u0027xena\u0027 etc."},{"line_number":121,"context_line":"KOLLA_OPENSTACK_RELEASE \u003d \u0027master\u0027"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"if KOLLA_OPENSTACK_RELEASE \u003d\u003d \u0027master\u0027:"},{"line_number":124,"context_line":"    KOLLA_BRANCH_NAME \u003d KOLLA_OPENSTACK_RELEASE"}],"source_content_type":"text/x-python","patch_set":6,"id":"62171eec_5c92b805","line":121,"range":{"start_line":121,"start_character":26,"end_line":121,"end_character":34},"in_reply_to":"a5b52b8b_474baad1","updated":"2021-10-29 16:00:08.000000000","message":"++","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"}],"doc/source/user/quickstart.rst":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e6571c83403bd48bdf4312cb4bb081231b97e49f","unresolved":true,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"   .. code-block:: console"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"      sudo pip3 install \u0027kolla-ansible\u003c|MAX_KOLLA_ANSIBLE_VER_EXCLUSIVE|\u0027"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"#. Create the ``/etc/kolla`` directory."},{"line_number":170,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"0b5816b4_6616bf11","line":167,"range":{"start_line":167,"start_character":6,"end_line":167,"end_character":73},"updated":"2021-10-27 10:40:32.000000000","message":"I would prefer to see here \"kolla-ansible \u003d\u003d KOLLA_ANSIBLE_CURRENT_VERSION.*\" to cleanly show which version it should be.","commit_id":"28b9f982050b801712080906c6cb5b761c2d814b"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"ebb70c1512845b411006dd1630a04b0d93ab8b70","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"   .. code-block:: console"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"      sudo pip3 install \u0027kolla-ansible\u003c|MAX_KOLLA_ANSIBLE_VER_EXCLUSIVE|\u0027"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"#. Create the ``/etc/kolla`` directory."},{"line_number":170,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"068f65e5_ef1b8620","line":167,"range":{"start_line":167,"start_character":6,"end_line":167,"end_character":73},"in_reply_to":"0b5816b4_6616bf11","updated":"2021-10-27 13:15:50.000000000","message":"Done","commit_id":"28b9f982050b801712080906c6cb5b761c2d814b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"716e9f459730556f63c988e6236cb779b32422d1","unresolved":true,"context_lines":[{"line_number":149,"context_line":"Install Kolla-ansible for deployment or evaluation"},{"line_number":150,"context_line":"--------------------------------------------------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"For a list of kolla-ansible versions compatible with each OpenStack release see"},{"line_number":153,"context_line":"`kolla-ansible release notes \u003chttps://docs.openstack.org/releasenotes/kolla-ansible/\u003e`__."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"#. Install kolla-ansible and its dependencies using ``pip``."}],"source_content_type":"text/x-rst","patch_set":3,"id":"c221665f_472bfae2","line":152,"range":{"start_line":152,"start_character":14,"end_line":152,"end_character":27},"updated":"2021-10-27 12:35:59.000000000","message":"put in `` ``","commit_id":"cd094bb873dc75228bdaca00ceeb564ec2f3a769"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"716e9f459730556f63c988e6236cb779b32422d1","unresolved":true,"context_lines":[{"line_number":150,"context_line":"--------------------------------------------------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"For a list of kolla-ansible versions compatible with each OpenStack release see"},{"line_number":153,"context_line":"`kolla-ansible release notes \u003chttps://docs.openstack.org/releasenotes/kolla-ansible/\u003e`__."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"#. Install kolla-ansible and its dependencies using ``pip``."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"57423d06_6e0e673d","line":153,"range":{"start_line":153,"start_character":1,"end_line":153,"end_character":14},"updated":"2021-10-27 12:35:59.000000000","message":"Kolla Ansible","commit_id":"cd094bb873dc75228bdaca00ceeb564ec2f3a769"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"695e3c6dd3d2f766cce534f1df085ff36bd73fe3","unresolved":true,"context_lines":[{"line_number":149,"context_line":"Install Kolla-ansible for deployment or evaluation"},{"line_number":150,"context_line":"--------------------------------------------------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"For a list of ``kolla-ansible`` versions compatible with each OpenStack release see"},{"line_number":153,"context_line":"`Kolla Ansible release notes \u003chttps://docs.openstack.org/releasenotes/kolla-ansible/\u003e`__."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"#. Install kolla-ansible and its dependencies using ``pip``."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ca7b295_65c663af","line":152,"updated":"2021-10-27 14:19:33.000000000","message":"only line too long and gtg","commit_id":"ef1f6fa3850eb05506f474aea1fa43b66abedafb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eb23118bfc40328ac215bffda311a17c94369060","unresolved":true,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"   .. code-block:: console"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"      pip install \u0027kolla-ansible \u003d\u003d |KOLLA_ANSIBLE_MAJOR_VERSION|.*\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"   If not using a virtual environment:"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9239504f_d05f4a6f","line":162,"range":{"start_line":162,"start_character":32,"end_line":162,"end_character":36},"updated":"2021-10-29 08:40:19.000000000","message":"It does seem to work with spaces when quoted, although it\u0027s the first time I\u0027ve seen it.","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eb23118bfc40328ac215bffda311a17c94369060","unresolved":true,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"   .. code-block:: console"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"      pip install \u0027kolla-ansible \u003d\u003d |KOLLA_ANSIBLE_MAJOR_VERSION|.*\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"   If not using a virtual environment:"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"4c55aef3_6a2e0d7a","line":162,"range":{"start_line":162,"start_character":6,"end_line":162,"end_character":9},"updated":"2021-10-29 08:40:19.000000000","message":"Seems we missed a pip3 here","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"98ed661cafe77a3d322cca50c02e4041a3f8b6e4","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"   .. code-block:: console"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"      pip install \u0027kolla-ansible \u003d\u003d |KOLLA_ANSIBLE_MAJOR_VERSION|.*\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"   If not using a virtual environment:"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"486b1b67_656d8501","line":162,"range":{"start_line":162,"start_character":6,"end_line":162,"end_character":9},"in_reply_to":"18e29441_f16bcad8","updated":"2021-10-29 16:00:08.000000000","message":"In venv the alias is always right.","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"4f68241fd29fee4f5c48151d25cd7f8dd56bbfd1","unresolved":true,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"   .. code-block:: console"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"      pip install \u0027kolla-ansible \u003d\u003d |KOLLA_ANSIBLE_MAJOR_VERSION|.*\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"   If not using a virtual environment:"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"18e29441_f16bcad8","line":162,"range":{"start_line":162,"start_character":6,"end_line":162,"end_character":9},"in_reply_to":"4c55aef3_6a2e0d7a","updated":"2021-10-29 09:13:35.000000000","message":"I\u0027ve just kept the `pip` command as it was already used on master.","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"4f68241fd29fee4f5c48151d25cd7f8dd56bbfd1","unresolved":true,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"   .. code-block:: console"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"      pip install \u0027kolla-ansible \u003d\u003d |KOLLA_ANSIBLE_MAJOR_VERSION|.*\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"   If not using a virtual environment:"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ca3fb209_0a97ac10","line":162,"range":{"start_line":162,"start_character":32,"end_line":162,"end_character":36},"in_reply_to":"9239504f_d05f4a6f","updated":"2021-10-29 09:13:35.000000000","message":"Quotes are needed since there are spaces in the expression. I guess I can remove spaces and quotes.","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"98ed661cafe77a3d322cca50c02e4041a3f8b6e4","unresolved":true,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"   .. code-block:: console"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"      pip install \u0027kolla-ansible \u003d\u003d |KOLLA_ANSIBLE_MAJOR_VERSION|.*\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"   If not using a virtual environment:"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"db4acfa1_38f9fd9b","line":162,"range":{"start_line":162,"start_character":32,"end_line":162,"end_character":36},"in_reply_to":"ca3fb209_0a97ac10","updated":"2021-10-29 16:00:08.000000000","message":"++","commit_id":"28b3b83cb202c132884345bc1be8314e22a9cc8e"}]}